Scott Taylor
3bbed6ceac
`audio`, `video`, and `playlist` shortcodes:
...
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur
See #22400 , #27881 .
Built from https://develop.svn.wordpress.org/trunk@28342
git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 17:36:18 +00:00
Scott Taylor
361e3e1ee6
In `wpdb`, remove dead code:
...
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28339
git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32
In `WP_Widget::update_callback()`, `$sidebars_widgets` is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28338
git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74
In `wp-includes/theme.php`, `break` is unreachable after `return`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28337
git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b
In `print_admin_styles()`, `$zip` is never used after being set. `$compress_css` does not need to be imported.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28336
git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961
In `wp_default_scripts()`, `$max_upload_size` and its entangled children `$max_up` and `$max_post` create quite the ternary operator... that is never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28335
git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80
In `wp-includes/revision.php` - remove dead code:
...
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28334
git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da
In `WP_Query`, remove duplicate variable setting:
...
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28333
git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108
In `get_pages()`, `$cache` does not need to be reset to an empty array. `update_post_cache( $pages )` takes care of priming.
...
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28332
git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160
In `wp_get_attachment_link()`, `$post_title` is set and then not used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28331
git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c
In `Walker_Nav_Menu::start_el()`, `$class_names` is set twice before it is used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28330
git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01
In `get_network_by_path()`, `$exact_domains` is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28329
git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326
In `update_metadata_by_mid()`, `$original_value` is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28328
git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:29:26 +00:00
Scott Taylor
0910376bfe
In `edit_post_link()`, `$post_type_obj` is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28327
git-svn-id: http://core.svn.wordpress.org/trunk@28155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:27:15 +00:00
Scott Taylor
3d0eed82f8
In `paginate_links()`, `break` is unreachable after `return`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28326
git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor
de4eaacd89
In `wp-includes/functions.php`, remove dead code:
...
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28325
git-svn-id: http://core.svn.wordpress.org/trunk@28153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:23:14 +00:00
Scott Taylor
7eeafa3537
In `wp_set_comment_status()`, the `default` case returns, so no default value for `$status` is needed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28324
git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:17:15 +00:00
Scott Taylor
de262f553c
In `wp-includes/comment-template.php`, remove dead code:
...
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28323
git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96
In `Walker::walk()` and `Walker::paged_walk()`, `$id_field` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28322
git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:09:19 +00:00
Sergey Biryukov
d711c32138
Update deleted site message in ms_site_check().
...
props boonebgorges.
fixes #28150 .
Built from https://develop.svn.wordpress.org/trunk@28321
git-svn-id: http://core.svn.wordpress.org/trunk@28149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:46:15 +00:00
Scott Taylor
013d4dc387
In `WP_Image_Editor::get_output_format()`, `$file_mime` and `$file_ext` are set twice before they are used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28320
git-svn-id: http://core.svn.wordpress.org/trunk@28148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:37:29 +00:00
Scott Taylor
73b102bd84
In `wp-includes/class-wp-customize-setting.php`, `break` is unreachable after `return`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28319
git-svn-id: http://core.svn.wordpress.org/trunk@28147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:34:14 +00:00
Scott Taylor
0a4af6d45c
In `wp-includes/class-wp-admin-bar.php`, `break` is unreachabled after `return`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28318
git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:29:15 +00:00
Scott Taylor
5bd852c262
In `WP_Http_Curl::request()`, `$theResponse` is unused. There are other `curl_exec()` calls that do not return as well.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28317
git-svn-id: http://core.svn.wordpress.org/trunk@28145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:26:14 +00:00
Scott Taylor
63a210e7c8
In `wp-includes/bookmark.php`, remove dead code:
...
* In `get_bookmarks()`, `$cache` is set twice before it is used.
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28316
git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:22:16 +00:00
Sergey Biryukov
d70e8a38fa
Add a filter for wp_list_comments() arguments.
...
props greenshady, hlashbrooke.
fixes #19581 .
Built from https://develop.svn.wordpress.org/trunk@28285
git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 11:58:14 +00:00
Drew Jaynes
2c00d8f9e3
Where a filter no longer exists, it need not be notated.
...
Fixes #24444 . See r28258.
Built from https://develop.svn.wordpress.org/trunk@28283
git-svn-id: http://core.svn.wordpress.org/trunk@28111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:38:15 +00:00
Andrew Nacin
e239dfad43
Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression.
...
props jeremyfelt.
fixes #27927 .
Built from https://develop.svn.wordpress.org/trunk@28280
git-svn-id: http://core.svn.wordpress.org/trunk@28108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:36 +00:00
Andrew Nacin
5b63b112f3
Multisite: Fix case sensitivity regressions in 3.9.
...
props jeremyfelt.
fixes #27866 .
Built from https://develop.svn.wordpress.org/trunk@28276
git-svn-id: http://core.svn.wordpress.org/trunk@28104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:24:14 +00:00
Scott Taylor
9bdbd50ac0
In `general-template.php` - remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28274
git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:58:16 +00:00
Andrew Nacin
6295631a4b
Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
...
props rzen, ehg.
fixes #27848 .
Built from https://develop.svn.wordpress.org/trunk@28266
git-svn-id: http://core.svn.wordpress.org/trunk@28094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:14:14 +00:00
Scott Taylor
00b03fe04f
Remove duplicate variable setting for `$link` in `wp_list_authors()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28265
git-svn-id: http://core.svn.wordpress.org/trunk@28093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:52:15 +00:00
Scott Taylor
b663fffe24
Add `.dfxp` and `.srt` files to mime-type whitelist in `wp_get_mime_types()`. They are both captioning formats supported by MediaElement.
...
Props joedolson.
Fixes #27643 .
Built from https://develop.svn.wordpress.org/trunk@28259
git-svn-id: http://core.svn.wordpress.org/trunk@28087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 20:08:16 +00:00
Scott Taylor
511145b418
When `$type` is `atom` in `get_the_category_rss()`, use `get_bloginfo_rss( 'url' )` when setting the `scheme` attribute for the `<category>` node.
...
Props ejdanderson.
Fixes #24444 .
Built from https://develop.svn.wordpress.org/trunk@28258
git-svn-id: http://core.svn.wordpress.org/trunk@28086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 19:05:14 +00:00
Scott Taylor
5e7ac8de94
Remove by-reference modifiers from arguments in `wp_remote_retrieve_*` functions.
...
Props jesin.
Fixes #27687 .
Built from https://develop.svn.wordpress.org/trunk@28257
git-svn-id: http://core.svn.wordpress.org/trunk@28085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 18:46:15 +00:00
Scott Taylor
f90a558df4
In `WP_Date_Query::get_sql_for_subquery()`, don't parse duplicate parameters - only parse one of `w` and `week` or `month` and `monthnum`.
...
Adds unit tests.
Props oso96_2000, ChriCo.
Fixes #25835 .
Built from https://develop.svn.wordpress.org/trunk@28252
git-svn-id: http://core.svn.wordpress.org/trunk@28080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 23:07:14 +00:00
Scott Taylor
a2067a7324
Set the proper value for `wp_title()` when `is_author()` and `is_post_type_archive()` are both true. `post_type` should always win due to the precedence indicated in `get_queried_object()`.
...
Props mordauk.
Fixes #25398 .
Built from https://develop.svn.wordpress.org/trunk@28251
git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 22:21:22 +00:00
Sergey Biryukov
0b08cd7a25
Prevent 'paged-*' from being added to body classes on 404 error pages.
...
props psoluch.
see #16468 .
Built from https://develop.svn.wordpress.org/trunk@28249
git-svn-id: http://core.svn.wordpress.org/trunk@28077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:15 +00:00
Drew Jaynes
a5366db845
Improve inline documentation for the wpdb::$show_errors property.
...
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.
Props ericlewis.
Fixes #16615 .
Built from https://develop.svn.wordpress.org/trunk@28243
git-svn-id: http://core.svn.wordpress.org/trunk@28071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 12:19:15 +00:00
Sergey Biryukov
7214648764
Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu().
...
props Tmeister.
fixes #27745 .
Built from https://develop.svn.wordpress.org/trunk@28242
git-svn-id: http://core.svn.wordpress.org/trunk@28070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:59:14 +00:00
Sergey Biryukov
3ad1c8897c
Correct 'show_in_menu' parameter description in register_taxonomy().
...
fixes #27943 .
Built from https://develop.svn.wordpress.org/trunk@28241
git-svn-id: http://core.svn.wordpress.org/trunk@28069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:29:13 +00:00
Sergey Biryukov
58dcece494
Correct @return value for current_time().
...
props arnee.
fixes #27940 .
Built from https://develop.svn.wordpress.org/trunk@28240
git-svn-id: http://core.svn.wordpress.org/trunk@28068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:25:15 +00:00
Dominik Schilling
c7adbde777
Update jQuery to 1.11.1.
...
fixes #28103 .
Built from https://develop.svn.wordpress.org/trunk@28238
git-svn-id: http://core.svn.wordpress.org/trunk@28066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 09:29:16 +00:00
Sergey Biryukov
d882dc9782
Fix arrow positioning in "Insert/edit link" modal.
...
props avryl, sergej.mueller.
fixes #28096 .
Built from https://develop.svn.wordpress.org/trunk@28236
git-svn-id: http://core.svn.wordpress.org/trunk@28064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 21:21:15 +00:00
Andrew Nacin
ba0168819c
Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets.
...
props gcorne.
props Clorith, jorbin for tests.
see #27907 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28223
git-svn-id: http://core.svn.wordpress.org/trunk@28051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 03:37:13 +00:00
Andrew Nacin
9f00179c58
Improve TinyMCE string for paste command browser support.
...
props ebinnion.
fixes #27988 .
Built from https://develop.svn.wordpress.org/trunk@28220
git-svn-id: http://core.svn.wordpress.org/trunk@28050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 21:20:14 +00:00
Dominik Schilling
20c10c5e2c
Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.
...
Add tests.
see #27936 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28219
git-svn-id: http://core.svn.wordpress.org/trunk@28049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:25:19 +00:00
Dominik Schilling
b6e3942bdd
Revert [28217].
...
Misfired commit for #27936 .
Built from https://develop.svn.wordpress.org/trunk@28218
git-svn-id: http://core.svn.wordpress.org/trunk@28048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:18:16 +00:00
Dominik Schilling
1849473907
Recent Posts Widget: Use `ob_end_flush()` instead of `ob_flush()`.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28217
git-svn-id: http://core.svn.wordpress.org/trunk@28047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 14:21:15 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00