Andrea Fercia
ce94f2dfbd
Refine the FTP credentials form interaction.
...
Properly toggle SSH2 Authentication Keys fieldset visibility.
JavaScript and CSS clean-up.
Props Mte90.
Fixes #34376 .
Built from https://develop.svn.wordpress.org/trunk@37467
git-svn-id: http://core.svn.wordpress.org/trunk@37435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-19 22:59:28 +00:00
Aaron Jorbin
262f3f2f7e
Update grunt-contrib-uglify from ~0.10.0 to ~1.0.1
...
This changes every JS file in WordPress, so we need to test everything.
Props netweb.
See #36520 .
Built from https://develop.svn.wordpress.org/trunk@37212
git-svn-id: http://core.svn.wordpress.org/trunk@37178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 16:10:37 +00:00
Dominik Schilling
8b781dfaa7
Updates: Prevent further actions if an update button is disabled.
...
Props adamsilverstein, afercia.
Fixes #35257 .
Built from https://develop.svn.wordpress.org/trunk@36558
git-svn-id: http://core.svn.wordpress.org/trunk@36525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:42:26 +00:00
Konstantin Obenland
c252e77ce3
Plugins: Use plugin file rather than slug as identifier
...
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes #35350 .
Built from https://develop.svn.wordpress.org/trunk@36221
git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 17:48:28 +00:00
Scott Taylor
8caf5d9759
Plugins: add dismissible notices to update failures.
...
Adds unit test.
Props afercia, mehulkaklotar.
Fixes #33465 .
Built from https://develop.svn.wordpress.org/trunk@35681
git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Andrea Fercia
19eb905f58
Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
...
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.
Fixes #33818 .
Built from https://develop.svn.wordpress.org/trunk@35155
git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 15:27:27 +00:00
Dion Hulse
629545aaf5
Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
...
Props magicroundabout. Fixes #32110 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32780
git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 04:28:25 +00:00
Dion Hulse
6eef8a8ff2
Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
...
Fixes #32435 , #32473
Built from https://develop.svn.wordpress.org/trunk@32779
git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:48:28 +00:00
Dion Hulse
04325cd834
Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32777
git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:20:28 +00:00
Dion Hulse
a4b4918377
Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32776
git-svn-id: http://core.svn.wordpress.org/trunk@32747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 02:48:28 +00:00
Dominik Schilling
aea00880f1
Don't try to focus disabled input fields in the request filesystem credentials form.
...
fixes #32064 .
Built from https://develop.svn.wordpress.org/trunk@32267
git-svn-id: http://core.svn.wordpress.org/trunk@32238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:57:26 +00:00
Aaron Jorbin
ee9adc354a
Move wp-plugin-update-success event to after lock is released
...
Fixes #31978
See #31819
Props DavidAnderson
Built from https://develop.svn.wordpress.org/trunk@32133
git-svn-id: http://core.svn.wordpress.org/trunk@32112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 14:37:27 +00:00
Aaron Jorbin
a07e9e127f
Use named function instead of anonymous function
...
The named function is testable and replaceable.
Fixes #31964
Props DavidAnderson, adamsilverstein, jorbin
Built from https://develop.svn.wordpress.org/trunk@32126
git-svn-id: http://core.svn.wordpress.org/trunk@32105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 16:42:26 +00:00
Aaron Jorbin
0402c0b877
Disable shiny updates from modal based on parent window
...
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal. Instead, let's use the parent window's location.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32082
git-svn-id: http://core.svn.wordpress.org/trunk@32061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:38:27 +00:00
Aaron Jorbin
7aeea37d47
Fix logic for details based shiny updates.
...
This fixes two problems. TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward. Also fixes logic error.
See #31739
Built from https://develop.svn.wordpress.org/trunk@32080
git-svn-id: http://core.svn.wordpress.org/trunk@32059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:27:26 +00:00
Aaron Jorbin
55cebbeeb6
Disable modal initiated shiny updates on wp-admin/update-core.php
...
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32067
git-svn-id: http://core.svn.wordpress.org/trunk@32046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 04:48:26 +00:00
Aaron Jorbin
1facff5425
Use dashes instead of dots as separator for jQuery events in shiny updates
...
`.` is used for namespaces, so better to use dashes.
see #31819
props iseulde
Built from https://develop.svn.wordpress.org/trunk@32063
git-svn-id: http://core.svn.wordpress.org/trunk@32042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:12:26 +00:00
Aaron Jorbin
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Aaron Jorbin
1985d00886
Trigger events upon the completion of a shiny update
...
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.
See #31819
Built from https://develop.svn.wordpress.org/trunk@32061
git-svn-id: http://core.svn.wordpress.org/trunk@32040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 02:32:26 +00:00
Aaron Jorbin
dd5b92a2fe
Remove Shiny Bulk Updates
...
Bulk updates don't need to be ajaxified so let's revert.
See #31770 , #29820 ,
Built from https://develop.svn.wordpress.org/trunk@32053
git-svn-id: http://core.svn.wordpress.org/trunk@32032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:21:26 +00:00
Aaron Jorbin
2c42b8f0b2
Conditionally add AYS to leaving shiny updates
...
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.
See #31769
Props ericlewis and adamsilverstein for initial patch
Built from https://develop.svn.wordpress.org/trunk@32052
git-svn-id: http://core.svn.wordpress.org/trunk@32031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:00:26 +00:00
Aaron Jorbin
3ac2f91922
Update aria-label when doing a shiny plugin update
...
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails
props mehulkaklotar, afercia
Fixes #31722
Built from https://develop.svn.wordpress.org/trunk@31982
git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
Aaron Jorbin
786083fd8e
Fix colors for activated and updated plugins
...
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared.
See #31608
Built from https://develop.svn.wordpress.org/trunk@31969
git-svn-id: http://core.svn.wordpress.org/trunk@31948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 21:31:26 +00:00
Aaron Jorbin
8f99fbeb8d
Refine UI for FTP modal and shiny updates
...
Numerous changes to make the FTP modal experience a good one. These include:
* Update HTML used by both the form here and the form on the standalone screen
* Allow users to cancel FTP install
* Focus locking in the modal
* Focus on modal form on load
* ARIA Attributes
* Style Enhancements
* Add low screen height (such as phone and some tablets) friendly experience for entering credentials
Props ericlewis, afercia
Fixes #31608
Built from https://develop.svn.wordpress.org/trunk@31949
git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Aaron Jorbin
4c05e8c71c
More clean up from removal of Shiny Plugin Installs
...
See #31773 , #29820
Unprops Jorbin, Pento
Built from https://develop.svn.wordpress.org/trunk@31900
git-svn-id: http://core.svn.wordpress.org/trunk@31879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 16:30:27 +00:00
Aaron Jorbin
9b23faef07
Remove Shiny Plugin Installs
...
See #31773 , #29820
Built from https://develop.svn.wordpress.org/trunk@31897
git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
Aaron Jorbin
a836a32fb4
Ensure that we target the correct plugin row for update updates
...
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.
Props ericlewis
Fixes #31621
Built from https://develop.svn.wordpress.org/trunk@31831
git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 05:26:28 +00:00
Aaron Jorbin
2d64637ff8
Request FTP and SSH credentials when needed during shiny updates
...
This is a restoration of [31749] which was reverted in [31755].
It includes a number of enhancements from the original version. Namely:
* Not doing a credential check in src/wp-includes/script-loader.php
* Add new function `wp_print_request_filesystem_credentials_modal`
* update the version number in the list table when a plugin is updated
UI still needs further work, but this basic version should enable more testing
Props ericlewis, jorbin
See #31528
Built from https://develop.svn.wordpress.org/trunk@31811
git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
Dominik Schilling
474f001c42
Revert [31749], see #31528 .
...
Built from https://develop.svn.wordpress.org/trunk@31755
git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 17:51:26 +00:00
Sergey Biryukov
5c9656393a
Shiny Updates: Disable body scrolling when filesystem request modal is open.
...
props ericlewis.
fixes #31607 .
Built from https://develop.svn.wordpress.org/trunk@31753
git-svn-id: http://core.svn.wordpress.org/trunk@31734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 14:57:26 +00:00
Aaron Jorbin
5b658df402
Request FTP and SSH credentials when needed during shiny updates
...
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates. There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates.
Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528
Built from https://develop.svn.wordpress.org/trunk@31749
git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 08:53:26 +00:00
Andrew Ozz
5e07bfdfd1
Add `wp.a11y.speak()` for audible alerts/updates in screen readers. Props afercia, GrahamArmfield (for the idea), iseulde. Fixes #31368 .
...
Built from https://develop.svn.wordpress.org/trunk@31594
git-svn-id: http://core.svn.wordpress.org/trunk@31575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 19:11:27 +00:00
Gary Pendergast
daf711a338
Shiny Updates: Replace `$.post()` calls with `wp.ajax.post()`, and clean up a bunch of the now unnecessary code.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31409
git-svn-id: http://core.svn.wordpress.org/trunk@31390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 05:06:28 +00:00
Boone Gorges
69504de9d8
jshint fixes for shiny updates JS.
...
As introduced in [31333].
Props iseulde.
See #29820 .
Built from https://develop.svn.wordpress.org/trunk@31341
git-svn-id: http://core.svn.wordpress.org/trunk@31322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:52:22 +00:00
Gary Pendergast
9c69213f2b
Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
...
This also includes JS architecture that can be expanded to support theme, core and language pack updates.
Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture
See #29820
Built from https://develop.svn.wordpress.org/trunk@31333
git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
Sergey Biryukov
79175d10cb
In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
...
props jdgrimes.
fixes #29527 .
Built from https://develop.svn.wordpress.org/trunk@29960
git-svn-id: http://core.svn.wordpress.org/trunk@29707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-18 19:55:18 +00:00
Sergey Biryukov
db4423c5cd
Avoid displaying a negative number of plugin updates in admin menu.
...
fixes #28073 .
Built from https://develop.svn.wordpress.org/trunk@28254
git-svn-id: http://core.svn.wordpress.org/trunk@28082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 09:39:17 +00:00
Andrew Nacin
0406d292c9
Remove title attributes on the fly when [27280] makes them incorrect. see #17703 .
...
Built from https://develop.svn.wordpress.org/trunk@27281
git-svn-id: http://core.svn.wordpress.org/trunk@27137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 07:37:14 +00:00
Andrew Nacin
13e868ac55
Decrement update count bubbles as plugins/themes are updated, live.
...
props gcorne, mitchoyoshitaka.
fixes #17703 .
Built from https://develop.svn.wordpress.org/trunk@27280
git-svn-id: http://core.svn.wordpress.org/trunk@27136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 06:55:14 +00:00