57c2b5d192
Customizer: Use "(Untitled)" as site title if `blogname` is empty.
...
Fixes a layout issue in the Customizer UI. Also de-duplicate title display logic, outputting "Loading..." as site title in PHP with actual title being set upon Customizer `ready`. Also update the site title in response to a `blogname` setting change as opposed to `input` DOM events on the control.
Fixes #35579 .
Built from https://develop.svn.wordpress.org/trunk@36388
git-svn-id: http://core.svn.wordpress.org/trunk@36355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-23 23:15:27 +00:00
fb8544a0ac
Customizer: Add shift-click on nav menu items in preview to focus on corresponding nav menu item controls in pane.
...
Add missing `params.completeCallback` to `MenuItemControl.focus()` for parity with `Control.focus()`. Also adds `params` to `MenuItemControl.expandForm`, `MenuItemControl.collapseForm()`, and `MenuItemControl.toggleForm()`.
Props MattGeri, westonruter.
Fixes #32681 .
Built from https://develop.svn.wordpress.org/trunk@36383
git-svn-id: http://core.svn.wordpress.org/trunk@36350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 21:21:26 +00:00
450cbb3e81
Accessibility: Remove title attributes from the Menus screen.
...
Also, adds missing labels and improves the existing ones.
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.
Fixes #35374 .
Built from https://develop.svn.wordpress.org/trunk@36379
git-svn-id: http://core.svn.wordpress.org/trunk@36346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 14:26:27 +00:00
496bde4e77
Quick/Bulk Edit: Remove a no more used jQuery loop for unsupported post formats.
...
See #23426 .
See #24096 .
Fixes #35564 .
Built from https://develop.svn.wordpress.org/trunk@36375
git-svn-id: http://core.svn.wordpress.org/trunk@36342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-21 22:50:25 +00:00
e41649c325
Accessibility: Improve focus handling on the Taxonomies Quick Edit.
...
Moves focus back to a proper place when saving or closing the form.
Fixes #35460 .
Built from https://develop.svn.wordpress.org/trunk@36304
git-svn-id: http://core.svn.wordpress.org/trunk@36271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 23:03:26 +00:00
c6ec579751
Accessibility: Improve focus handling and audible feedback on the Posts Quick-Bulk Edit.
...
Avoids a focus loss when saving or closing the form moving focus back to a proper place.
Uses `wp.a11y.speak()` to dispatch successful edits and error messages to screen readers.
Fixes #34756 .
Built from https://develop.svn.wordpress.org/trunk@36303
git-svn-id: http://core.svn.wordpress.org/trunk@36270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 22:58:27 +00:00
08693cd206
Administration: After [36295], mark `postBoxL10n` as a global to please JSHint.
...
See #26399 .
Built from https://develop.svn.wordpress.org/trunk@36296
git-svn-id: http://core.svn.wordpress.org/trunk@36263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 08:40:26 +00:00
9ae1736d01
Administration: Add a "Drag boxes here" message to empty dashboard meta boxes so it's clear to users that it's possible to drag meta boxes into empty spaces.
...
Props xavortm
Fixes #26399
Built from https://develop.svn.wordpress.org/trunk@36295
git-svn-id: http://core.svn.wordpress.org/trunk@36262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 04:13:26 +00:00
b7df807589
jQuery: Replace use of the `.load()` method for the "load" event with `.on( 'load', handler )`.
...
The shortcut is deprecated since jQuery 1.8.
See http://api.jquery.com/load-event/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36287
git-svn-id: http://core.svn.wordpress.org/trunk@36254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 17:22:27 +00:00
b3d8732c17
jQuery: Replace the use of the `.size()` method with the `.length` property.
...
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.
See https://api.jquery.com/size/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36286
git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 16:17:27 +00:00
c0e903a040
Themes: Clear floated theme cards on Themes page.
...
Also maintains visual separation for Broken Themes table on searches that
return no results.
See [36171] for `.wp-clearfix`.
Props 5um17, obenland, valendesigns, afercia.
Fixes #26646 .
Built from https://develop.svn.wordpress.org/trunk@36270
git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 17:13:29 +00:00
9b486acb9b
Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.
...
Fixes #35401 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36260
git-svn-id: http://core.svn.wordpress.org/trunk@36227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 13:15:29 +00:00
cbb245196c
Use a more generous selector when setting up tag suggestion.
...
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.
Props johnjamesjacoby..
Fixes #35349 .
Built from https://develop.svn.wordpress.org/trunk@36227
git-svn-id: http://core.svn.wordpress.org/trunk@36194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:18:25 +00:00
ae1575bd80
Media: make the Image Editor usable with a keyboard.
...
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes #28864 .
Built from https://develop.svn.wordpress.org/trunk@36223
git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:13:26 +00:00
c252e77ce3
Plugins: Use plugin file rather than slug as identifier
...
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes #35350 .
Built from https://develop.svn.wordpress.org/trunk@36221
git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 17:48:28 +00:00
d5fd177b96
Themes: Avoid changing the count of themes with updates in network admin.
...
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.
See [29786], [31495].
Fixes #35332 .
Built from https://develop.svn.wordpress.org/trunk@36204
git-svn-id: http://core.svn.wordpress.org/trunk@36171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:32:28 +00:00
1b3ee7098a
Media: set the image editor spinner on the smallest possible area.
...
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196 , #33311 , #33322 , and #34951 .
Fixes #35296 .
Built from https://develop.svn.wordpress.org/trunk@36162
git-svn-id: http://core.svn.wordpress.org/trunk@36128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 16:49:28 +00:00
f13881d4e3
Admin: Restore the "Show advanced menu properties" checkboxes IDs.
...
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.
Fixes #35112 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36137
git-svn-id: http://core.svn.wordpress.org/trunk@36103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:52:26 +00:00
27e5599bf7
Admin: fix repositioning of notices when the first header is not an immediate children of `.wrap`.
...
Props DvanKooten for the initial patch.
Fixes #35047 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36134
git-svn-id: http://core.svn.wordpress.org/trunk@36100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:05:31 +00:00
a7e13d0af9
Editor: Correctly indent definition lists when switching from the visual to the text editor.
...
Props ocean90, katieburch.
Fixes #23299 .
Built from https://develop.svn.wordpress.org/trunk@35999
git-svn-id: http://core.svn.wordpress.org/trunk@35964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 23:06:25 +00:00
282e7c36eb
Accessibility: Add an ARIA role `button` to links that behave like buttons when JavaScript is on.
...
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.
Patch prepared during WordCamp US 2015 Contributor Day.
Props mcapybara, garusky, takayukister.
See #26504 .
Fixes #34867 .
Built from https://develop.svn.wordpress.org/trunk@35947
git-svn-id: http://core.svn.wordpress.org/trunk@35911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 13:25:28 +00:00
5fa8ea8c6b
Passwords: Hide weak password confirmation checkbox when password strength improves.
...
Props subharanjan for initial patch.
Fixes #34950 .
Built from https://develop.svn.wordpress.org/trunk@35870
git-svn-id: http://core.svn.wordpress.org/trunk@35834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 21:54:27 +00:00
699c377856
Meta Boxes: Preserve radio inputs' state when sorting metaboxes.
...
When sorting a metabox, a clone of that metabox is created as a drag/drop "helper".
Previously, any checked radio input in the original metabox would become unchecked, when its clone "helper" was inserted into the DOM
(since only one radio within a set of radios of the same name can be checked).
Continued use of the clone helper is important so that the element being dragged isn't subject to the click and other event handlers attached to the real metabox,
so we can't just switch to dragging around the real metabox. See, for example, comment:10:ticket:16972.
Preserve the radios' state via some name attribute trickery.
Fixes #16972
Built from https://develop.svn.wordpress.org/trunk@35809
git-svn-id: http://core.svn.wordpress.org/trunk@35773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:49 +00:00
31f51e2cbb
The the Docs: Fix the the dittography
...
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.
(I've excluded external libs from this change.)
Fixes #34885 .
Built from https://develop.svn.wordpress.org/trunk@35793
git-svn-id: http://core.svn.wordpress.org/trunk@35757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:23:25 +00:00
7f3082491d
Passwords: Re-enable password fields before submitting the form.
...
Avoids an PHP undefined notice when creating new users.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35733
git-svn-id: http://core.svn.wordpress.org/trunk@35697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 21:17:27 +00:00
91759029e9
TinyMCE: fix the regexp used to protect line breaks inside script and pre tags to match `<script>` that load external scripts.
...
Fixes #34760 .
Built from https://develop.svn.wordpress.org/trunk@35727
git-svn-id: http://core.svn.wordpress.org/trunk@35691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 19:13:28 +00:00
8caf5d9759
Plugins: add dismissible notices to update failures.
...
Adds unit test.
Props afercia, mehulkaklotar.
Fixes #33465 .
Built from https://develop.svn.wordpress.org/trunk@35681
git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
9df7c4edea
Passwords: Only disable hidden password fields if they are really hidden.
...
Makes the password field on install and for password resets editable again. Both fields were accidentally set to disabled in [35603].
Props adamsilverstein, flixos90.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35649
git-svn-id: http://core.svn.wordpress.org/trunk@35613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:49:26 +00:00
a7848ea08b
Themes: Hide the favorites form when performing a search.
...
The search is global and ignores the user setting. Same for filters.
See #34206 .
Built from https://develop.svn.wordpress.org/trunk@35647
git-svn-id: http://core.svn.wordpress.org/trunk@35611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:50:26 +00:00
6381e168b7
Pinking Shears: Remove some errant non-breaking spaces from a few JavaScript files.
...
Props francoisb.
Fixes #34658 .
Built from https://develop.svn.wordpress.org/trunk@35627
git-svn-id: http://core.svn.wordpress.org/trunk@35591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 12:04:27 +00:00
27e4384e89
Comments: Dynamically update the document title text for all languages, not only English.
...
See [33821].
Fixes #33414 .
Built from https://develop.svn.wordpress.org/trunk@35615
git-svn-id: http://core.svn.wordpress.org/trunk@35579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 21:00:27 +00:00
5f93491286
Accessibility: improvements for the taxonomies Quick Edit form.
...
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.
Patch prepared at #wpcdit, first Italian WordPress Contributor Day.
Props garusky, chiara_09.
Fixes #34613 .
Built from https://develop.svn.wordpress.org/trunk@35605
git-svn-id: http://core.svn.wordpress.org/trunk@35569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 00:24:28 +00:00
66dee42444
Passwords: Disable hidden input fields on profile/user edit page.
...
Prevents an issue where password helpers would autofill the hidden password fields and inadvertently causing password changes when editing other fields on the profile page.
Props adamsilverstein.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35603
git-svn-id: http://core.svn.wordpress.org/trunk@35567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 20:41:26 +00:00
f4659f7ee0
Customize: Fix focus and autofocus on `nav_menu_item` controls.
...
Embed the `nav_menu_item` control not only when the contained `nav_menu` section expands, but also if the control was autofocused (via the `autofocus[control]` query param). Also applies change from [33596] to work-around a broken `:focusable` selector in jQuery UI.
See #33258 .
Fixes #34629 .
Built from https://develop.svn.wordpress.org/trunk@35584
git-svn-id: http://core.svn.wordpress.org/trunk@35548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:14:25 +00:00
5411447dd3
Customize: Fix sub-nav menu items from appearing to bump to root level in preview upon saving.
...
This issue would appear when the parent nav menu item was also newly-inserted. The issue was only apparent in the prevew, as the actual data saved was correct. The `menu_item_parent` properties of the saved sub-nav menu items needed to get updated to refer to the newly-inserted parent `nav_menu_item` post IDs, as opposed to retaining the placeholder IDs.
Fixes #34628 .
Built from https://develop.svn.wordpress.org/trunk@35581
git-svn-id: http://core.svn.wordpress.org/trunk@35545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 01:19:26 +00:00
e649fabb6a
Accessibility: add missing `alt` attributes to a gaggle of `<img>`s.
...
Props afercia.
Fixes #34583 .
Built from https://develop.svn.wordpress.org/trunk@35567
git-svn-id: http://core.svn.wordpress.org/trunk@35531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:12:27 +00:00
84c8243514
Themes: Remove an errant comma from `theme.js`.
...
Added in [35527].
See #34206 .
Built from https://develop.svn.wordpress.org/trunk@35533
git-svn-id: http://core.svn.wordpress.org/trunk@35497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 23:49:26 +00:00
a41e5d0270
Themes: Add a Favorites tab to the Add Themes screen.
...
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.
Props swissspidy.
Fixes #34206 .
Built from https://develop.svn.wordpress.org/trunk@35527
git-svn-id: http://core.svn.wordpress.org/trunk@35491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:49:26 +00:00
c443d45708
Admin: Ensure notices with the `below-h2` class are not repositioned after [35238].
...
Keeps the `.below-h2` class for backwards compatibility with plugins that are (incorrectly) using it. Plugins should use `.inline` instead.
Props stephenharris.
Fixes #34570 . See #34294 .
Built from https://develop.svn.wordpress.org/trunk@35516
git-svn-id: http://core.svn.wordpress.org/trunk@35480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:27:26 +00:00
2e98e461a2
Customize: Fix auto-expand (and focus) on newly added widgets.
...
Add widget controls with an initially-true `active` state so that calling `expand()` will not be short-circuited. Previously the `active` state would be set once the preview refreshes, but this happens too late for the `addWidget` call. Fixes regression introduced in [35231].
Fixes #34514 .
Built from https://develop.svn.wordpress.org/trunk@35486
git-svn-id: http://core.svn.wordpress.org/trunk@35450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 22:27:26 +00:00
de881c4a97
Precommit cleanup, see r35313.
...
Built from https://develop.svn.wordpress.org/trunk@35318
git-svn-id: http://core.svn.wordpress.org/trunk@35284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:33:24 +00:00
71ac079074
Widgets: add a button to delete all inactive widgets simultaneously for better UX.
...
Props cdog.
Fixes #19159 .
Built from https://develop.svn.wordpress.org/trunk@35317
git-svn-id: http://core.svn.wordpress.org/trunk@35283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:23:26 +00:00
e525ab849d
Administration: the current admin menu item should have an `aria-haspopup` attribute when the menu is folded.
...
Unify the jQuery selector caching for `window`, `document`, and `body`.
Props afercia.
Fixes #32578 .
Built from https://develop.svn.wordpress.org/trunk@35313
git-svn-id: http://core.svn.wordpress.org/trunk@35279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:41:24 +00:00
1e1e7a9fc9
Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
...
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.
Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.
Fixes #33327 .
Built from https://develop.svn.wordpress.org/trunk@35304
git-svn-id: http://core.svn.wordpress.org/trunk@35270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 20:15:26 +00:00
6d9d18315d
Customizer: Implement indicators for invalid nav menu items.
...
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.
Props kucrut, westonruter.
Fixes #33665 .
Built from https://develop.svn.wordpress.org/trunk@35302
git-svn-id: http://core.svn.wordpress.org/trunk@35268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:08:25 +00:00
e0af554638
Tags: Avoid a double trailing space after tags separator in auto-suggest.
...
Props afercia.
Fixes #33881 .
Built from https://develop.svn.wordpress.org/trunk@35292
git-svn-id: http://core.svn.wordpress.org/trunk@35258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:00:30 +00:00
f89b90a1c9
Theme Installer: toggle `iframe-ready` on the overlay to control the spinner animated GIF and high CPU usage.
...
Props afercia, adamsilverstein.
Fixes #33322 .
Built from https://develop.svn.wordpress.org/trunk@35281
git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
62d8b8c5bc
List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
...
See #31634 .
Built from https://develop.svn.wordpress.org/trunk@35277
git-svn-id: http://core.svn.wordpress.org/trunk@35243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:29:24 +00:00
e074209a3d
Accessibility: Improve the headings hierarchy in the Add Themes screen.
...
Fixes #33819 .
Built from https://develop.svn.wordpress.org/trunk@35273
git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
f676fdcee3
Customizer: Fix `margin-top` calculation for Themes section.
...
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].
See #33567 .
Built from https://develop.svn.wordpress.org/trunk@35251
git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:41:25 +00:00
08f71faac3
JSHint after [35238]
...
Built from https://develop.svn.wordpress.org/trunk@35239
git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:11:24 +00:00
47e364de42
Admin: fix repositioning notices
...
Fixes #34294 .
Props afercia.
Built from https://develop.svn.wordpress.org/trunk@35238
git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
6bcd8ad757
Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
...
Widgets panel will not wait to display until the preview loads.
Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.
Fixes #33052 .
Fixes #33567 .
Built from https://develop.svn.wordpress.org/trunk@35231
git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:48:25 +00:00
f98136c1b5
Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
...
Props afercia.
Fixes #34255 .
Built from https://develop.svn.wordpress.org/trunk@35229
git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
3babb1682a
Fix close button plugin modal after [18590]
...
See #18590 .
Built from https://develop.svn.wordpress.org/trunk@35198
git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 14:52:26 +00:00
19eb905f58
Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
...
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.
Fixes #33818 .
Built from https://develop.svn.wordpress.org/trunk@35155
git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 15:27:27 +00:00
a31d7e37dc
Color Picker: when opening and closing, toggle a `wp-picker-active` class on the wrapper.
...
Props norcross.
Fixes #29471 .
Built from https://develop.svn.wordpress.org/trunk@35099
git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:08:25 +00:00
6b449abadc
Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
...
Props mrahmadawais, afercia.
Fixes #33659 .
Built from https://develop.svn.wordpress.org/trunk@35015
git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 16:34:25 +00:00
5fdf928bcf
Admin JS: after [34977], avoid variable names conflicts with `e`.
...
Props afercia.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@35014
git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:50:24 +00:00
a6cf0b41a6
JS: in event callbacks replace the very outdated `return false` with `preventDefault()`.
...
Props adamsilverstein.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@34977
git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 01:27:27 +00:00
2783773775
Meta Boxes: reboot some of the code in `postbox.js` to support `aria-expanded` attribute toggling and to properly reference static class properties.
...
Props afercia, wonderboymusic.
Fixes #33754 .
Built from https://develop.svn.wordpress.org/trunk@34893
git-svn-id: http://core.svn.wordpress.org/trunk@34858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:58:25 +00:00
aa044b054e
Customizer: Ensure that `wp.customize.Widgets.savedWidgetIds` is defined up front.
...
In 4.3 the widget controls were fully initialized up front along with the sidebar controls. The sidebar control depended (unnecessarily) on the widget control to ensure that `wp.customize.Widgets.savedWidgetIds` was defined. So after [34563] there could be a situation where the widgets are added/removed from a sidebar before their controls are initialized (if the sidebar section is never expanded), resulting in an error attempting to get a property off of an undefined value. So this change does the right thing and defines `savedWidgetIds` up front.
Also changes the `savedWidgetIds` variable type from an array to an object, to match how it is used as a dictionary lookup.
See #33901 .
Built from https://develop.svn.wordpress.org/trunk@34883
git-svn-id: http://core.svn.wordpress.org/trunk@34848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 21:59:25 +00:00
31a394fcf7
Customizer: Reset horizontal scroll position when finished dragging a nav menu item.
...
Props karinedo, austinginder, adamsilverstein, tyxla.
Fixes #33367 .
Built from https://develop.svn.wordpress.org/trunk@34834
git-svn-id: http://core.svn.wordpress.org/trunk@34799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 20:46:27 +00:00
d9cca27386
Customize: Fix `nav_menu_item` CSS `classes` array being incorrectly presented in input field as comma-delimited list.
...
Instead of using `Array.toString()` to serialize an array with comma delimiters, explicitly `join` the array using spaces instead. Also ensure that `xfn` is handled properly if it ever gets stored as an array.
Props tyxla, westonruter.
Fixes #34111 .
Built from https://develop.svn.wordpress.org/trunk@34788
git-svn-id: http://core.svn.wordpress.org/trunk@34753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 00:15:24 +00:00
0acededa82
In `wp_comment_reply()` change the H5 headings in fieldset legends for better accessibility.
...
Also, add a "Edit Comment" legend before the Quick Edit form to pair it with "Reply to Comment" and "Add new Comment" and move the Name, Email, and URL fields after the Comment textarea.
Props joedolson, afercia.
Fixes #33757 .
Built from https://develop.svn.wordpress.org/trunk@34743
git-svn-id: http://core.svn.wordpress.org/trunk@34708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 14:52:25 +00:00
02703fae19
Sample permalink: Buttons still need the `.button` class.
...
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34671
git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 22:07:25 +00:00
e976f9b503
Edit: Remove the redundant "View Post" button-link and link the sample permalink.
...
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.
Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.
props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34670
git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 20:10:26 +00:00
208330f2dc
Customizer: Defer embedding widget controls to improve DOM performance and initial load time.
...
The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the `widget-added` event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.
Includes changes to `wp_widget_control()` to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.
Fixes #33901 .
Built from https://develop.svn.wordpress.org/trunk@34563
git-svn-id: http://core.svn.wordpress.org/trunk@34527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 21:02:27 +00:00
885944f79f
Customizer: Fix usage of `jQuery.contains()` allowing `active` state changes to again animate control visibility.
...
Aligns usage of `jQuery.contains()` in a control's `onChangeActive` method with the existing usage in the corresponding `onChangeActive` method for panels and sections.
Props nikeo.
Fixes #33509 .
Built from https://develop.svn.wordpress.org/trunk@34557
git-svn-id: http://core.svn.wordpress.org/trunk@34521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 19:54:50 +00:00
fa58223b49
Profile: when clicking "Generate Password", toggling visibility, then canceling, ensure that the UI resets properly for when the "Generate Password" button is clicked again.
...
Props umesh.nevase.
Fixes #33897 .
Built from https://develop.svn.wordpress.org/trunk@34539
git-svn-id: http://core.svn.wordpress.org/trunk@34503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 13:54:24 +00:00
e87150fc06
Comments List Table: after [34179], scope the `<th>`s and `<td>`s as direct descendants of their parent row.
...
Fixes #33943 .
Built from https://develop.svn.wordpress.org/trunk@34527
git-svn-id: http://core.svn.wordpress.org/trunk@34491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 02:21:26 +00:00
44822831fe
Comments List Table JS: move the dynamic count functions into closure scope so that `setCommentsList` AND `commentReply` can access them. Update counts when replying inline.
...
Fixes #33403 .
Built from https://develop.svn.wordpress.org/trunk@34517
git-svn-id: http://core.svn.wordpress.org/trunk@34481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:16:49 +00:00
4671e03766
Comments List Table: include count for "All". Dynamically update.
...
Fixes #17275 .
Built from https://develop.svn.wordpress.org/trunk@34506
git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:57:25 +00:00
5b9af35c4c
Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
...
Fixes #10422 .
Built from https://develop.svn.wordpress.org/trunk@34500
git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 15:53:25 +00:00
25f206e01f
List Tables: add JS code to dynamically toggle the `disabled` attribute of the Bulk Actions dropdown and Apply button.
...
Props wonderboymusic, pareshradadiya.
Fixes #31634 .
Built from https://develop.svn.wordpress.org/trunk@34467
git-svn-id: http://core.svn.wordpress.org/trunk@34431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 01:07:24 +00:00
39552b63ca
Passwords: fix the markup on the Reset Password Form for `user-pass1` so the JavaScript operates properly.
...
Props ldinclaux.
See #33892 .
Fixes #33908 .
Built from https://develop.svn.wordpress.org/trunk@34371
git-svn-id: http://core.svn.wordpress.org/trunk@34335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:57:24 +00:00
28964445d4
Admin: when toggling select/deselect "all" via JS - `:visible` needs to be bound to not toggle disabled inputs.
...
Props tywayne.
Fixes #32309 .
Built from https://develop.svn.wordpress.org/trunk@34325
git-svn-id: http://core.svn.wordpress.org/trunk@34289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:41:24 +00:00
c43f72fbfb
Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
...
Props adamsilverstein, wonderboymusic.
Fixes #33450 .
Built from https://develop.svn.wordpress.org/trunk@34312
git-svn-id: http://core.svn.wordpress.org/trunk@34276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:14:24 +00:00
57d2420ae5
Similar to #33386 , don't use `guid` when retrieving URL for a cropped header image in the Customizer.
...
Props polevaultweb.
Fixes #33319 .
Built from https://develop.svn.wordpress.org/trunk@34188
git-svn-id: http://core.svn.wordpress.org/trunk@34156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:46:32 +00:00
80165bfc4a
Comments: When setting the `colspan` value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Props afercia.
Fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34179
git-svn-id: http://core.svn.wordpress.org/trunk@34147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:44:34 +00:00
ab777c54cc
Ensure that widget carets close when dragging an expanded widget.
...
Props sdavis2702, mindctrl.
Fixes #33578 .
Built from https://develop.svn.wordpress.org/trunk@34165
git-svn-id: http://core.svn.wordpress.org/trunk@34133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:10:24 +00:00
387f271ea5
After [34070], account for the new ID in Quick Edit JS.
...
Props afercia.
Fixes #33770 .
Built from https://develop.svn.wordpress.org/trunk@34159
git-svn-id: http://core.svn.wordpress.org/trunk@34127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:31:26 +00:00
d36ffeb160
Passwords: Trigger a `wp-check-valid-field` event when the password field is filled with a password by `generatePassword()`.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
See #33406 .
Built from https://develop.svn.wordpress.org/trunk@34114
git-svn-id: http://core.svn.wordpress.org/trunk@34082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 10:39:27 +00:00
373d73f781
Turn off `autocomplete` for the `new-post-slug` field.
...
Props johnbillion.
Fixes #32752 .
Built from https://develop.svn.wordpress.org/trunk@34105
git-svn-id: http://core.svn.wordpress.org/trunk@34073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:03:25 +00:00
7f772bdaff
Comments: Fix inline edit/reply on small screens.
...
props ocean90, SergeyBiryukov.
fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34094
git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:47:27 +00:00
b453af5718
When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on `commentsBox`, `->load()`, that resets `st` (cool name) to the number of visible `<tr>`s before calling `->get()`. This will account for spam'd and trash'd comments when returning comments at the proper offset.
...
Props utkarshpatel.
Fixes #33829 .
Built from https://develop.svn.wordpress.org/trunk@34069
git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:28:26 +00:00
5f5ea8c3e2
Quick Edit: fix the Tags auto-suggest tooltip visibility.
...
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.
Props rommelxcastro for the initial patch.
Fixes #32580 .
Built from https://develop.svn.wordpress.org/trunk@34064
git-svn-id: http://core.svn.wordpress.org/trunk@34032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:34:25 +00:00
e1ccdf760e
Settings: properly set the password field label on loading.
...
See #33778 .
Built from https://develop.svn.wordpress.org/trunk@34062
git-svn-id: http://core.svn.wordpress.org/trunk@34030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:05:24 +00:00
0406f50cfb
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34061
git-svn-id: http://core.svn.wordpress.org/trunk@34029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 22:52:26 +00:00
efcdeea2f1
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
Built from https://develop.svn.wordpress.org/trunk@34060
git-svn-id: http://core.svn.wordpress.org/trunk@34028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:52:27 +00:00
d6f26e4c7c
Site Icon: For preview fall back to `full` size URL when `thumbnail` size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Props tyxla.
Fixes #33417 .
Built from https://develop.svn.wordpress.org/trunk@34056
git-svn-id: http://core.svn.wordpress.org/trunk@34024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:13:25 +00:00
bbbbf11961
After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).
...
See #33414 .
Built from https://develop.svn.wordpress.org/trunk@33982
git-svn-id: http://core.svn.wordpress.org/trunk@33951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:03:25 +00:00
7c6534fd4c
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Fixes #33695 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33939
git-svn-id: http://core.svn.wordpress.org/trunk@33908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:59:24 +00:00
274373afc6
Customize: Fix clearing of a color control's setting by using proper empty value.
...
Props stevehenty.
Fixes #30280 .
Built from https://develop.svn.wordpress.org/trunk@33938
git-svn-id: http://core.svn.wordpress.org/trunk@33907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:48:23 +00:00
44dace3487
Add Customizer docs.
...
Props ericlewis.
See #33503 .
Built from https://develop.svn.wordpress.org/trunk@33911
git-svn-id: http://core.svn.wordpress.org/trunk@33880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:53:24 +00:00
f0ce1f06ea
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`.
...
fixes #33685 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33902
git-svn-id: http://core.svn.wordpress.org/trunk@33871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 03:40:25 +00:00
1413f2edd5
Customizer: Collapse any expanded panel/sections before expanding other panel/sections
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Props celloexpressions, westonruter.
Fixes #33396 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33837
git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:42 +00:00
e3f3f470ea
Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
...
Fixes #23691 .
Built from https://develop.svn.wordpress.org/trunk@33836
git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:22 +00:00
7808d5d1fa
Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
...
Fixes #33414 .
Built from https://develop.svn.wordpress.org/trunk@33821
git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 17:58:22 +00:00
5a97ff5206
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
Built from https://develop.svn.wordpress.org/trunk@33820
git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Weston Ruter
Andrea Fercia
Pascal Birchler
John Blackbourn
Dominik Schilling
Konstantin Obenland
Boone Gorges
Michael Adams
Gary Pendergast
Andrew Ozz
Scott Taylor
Sergey Biryukov
Ella Iseulde Van Dorpe
Helen Hou-Sandí