589395347a
Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button.
...
`toggleClass()` expects a boolean as a second argument, not an integer.
Props iCaleb.
Fixes #42867 .
Built from https://develop.svn.wordpress.org/trunk@42457
git-svn-id: http://core.svn.wordpress.org/trunk@42286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 23:47:47 +00:00
0d23b38fd3
Media: Add `small-audio.flac` for a unit test added in [42451].
...
See #42225 .
Built from https://develop.svn.wordpress.org/trunk@42453
git-svn-id: http://core.svn.wordpress.org/trunk@42283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:33:47 +00:00
13e40181eb
Media: Add `flac` to the list of allowed file types.
...
Props blobfolio.
Fixes #42225 .
Built from https://develop.svn.wordpress.org/trunk@42451
git-svn-id: http://core.svn.wordpress.org/trunk@42281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:17:47 +00:00
35653f0432
Media: Bring consistency to `getimagesize()` error suppression.
...
Props chasewg, joemcgill, jeremyfelt.
Fixes #42480 .
Built from https://develop.svn.wordpress.org/trunk@42449
git-svn-id: http://core.svn.wordpress.org/trunk@42279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:44:47 +00:00
9cb44f5f2f
Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
...
Props chetan200891 for initial patch.
Fixes #42871 .
Built from https://develop.svn.wordpress.org/trunk@42447
git-svn-id: http://core.svn.wordpress.org/trunk@42277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:27:53 +00:00
1fb6a63449
TinyMCE: on the toolbar drop-downs apply overflow style on the actual element with text.
...
Props abdullahramzan, azaozz.
Fixes #43090 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42446
git-svn-id: http://core.svn.wordpress.org/trunk@42276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 09:51:48 +00:00
3fb8eee9fc
Accessibility: Media: Improve the usage of a few label elements in the media templates.
...
Label elements should only be used for labelable elements.
- `Uploaded By` and `Uploaded To` aren't form controls and shouldn't be associated with labels
- changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)
Props Presskopp, afercia.
Fixes #38759 , #40468 .
Built from https://develop.svn.wordpress.org/trunk@42444
git-svn-id: http://core.svn.wordpress.org/trunk@42274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-14 16:39:47 +00:00
239da4c1e6
Plugins: Fix the plugin details modal in the install plugin search tab after [41356].
...
Fixes #43082
Built from https://develop.svn.wordpress.org/trunk@42443
git-svn-id: http://core.svn.wordpress.org/trunk@42273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 18:53:51 +00:00
a492541c35
Formatting: Do not run formatting and texturization on author bios.
...
Removes the formatting and texturization added to author bios in #40040 due to back-compatibility concerns.
Reverts [41172], [41173].
Props 0x6f0, rabmalin for review.
Fixes #42578 .
Built from https://develop.svn.wordpress.org/trunk@42441
git-svn-id: http://core.svn.wordpress.org/trunk@42271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 01:11:49 +00:00
9c3344197d
Accessibility: use `aria-current` for the paginated post links output by `wp_link_pages()`.
...
Continues the introduction in core of the aria-current attribute after [41683], [41359], and [41371].
- changes the `wp_link_pages()` (see the `nextpage` quicktag) output to use an `aria-current` attribute on the current item
- adds `post-nav-links` and `post-page-numbers` CSS classes to help themes style these links
- updates the related tests
Props antonioeatgoat, alexstine.
Fixes #41859 .
Built from https://develop.svn.wordpress.org/trunk@42440
git-svn-id: http://core.svn.wordpress.org/trunk@42270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:17:51 +00:00
351d71d7ea
Twenty Seventeen: Remove unnecessary comment in `front-page.php`.
...
Props hardik-amipara, poena.
Fixes #42820 .
Built from https://develop.svn.wordpress.org/trunk@42437
git-svn-id: http://core.svn.wordpress.org/trunk@42267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:01:51 +00:00
6310ad30d0
Docs: Improve JS Docs for `controllers/customize-image-cropper.js`.
...
Props manuelaugustin, bramheijmink, andizer, ireneyoast.
Fixes #43020 .
Built from https://develop.svn.wordpress.org/trunk@42435
git-svn-id: http://core.svn.wordpress.org/trunk@42265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-11 14:32:52 +00:00
1d59873ace
Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
...
Props joemcgill, dd32.
Fixes #42963 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42433
git-svn-id: http://core.svn.wordpress.org/trunk@42263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 06:10:47 +00:00
cdfa5adc43
Streams: When checking in `wp_is_stream()` escape the stream wrapper names for PCRE to avoid PHP warnings when invalid stream wrappers are registered.
...
Fixes #43054 .
Built from https://develop.svn.wordpress.org/trunk@42432
git-svn-id: http://core.svn.wordpress.org/trunk@42262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 02:50:46 +00:00
7bfc60864f
Media: Skip `test_remove_orientation_data_on_rotate` if missing deps.
...
The `test_remove_orientation_data_on_rotate()` test was failing on systems that did not have the `exif` extension available.
Skips test when the `exif_read_data()` function does not exist.
Props danielbachhuber, desrosj.
Fixes #42447 .
Built from https://develop.svn.wordpress.org/trunk@42431
git-svn-id: http://core.svn.wordpress.org/trunk@42261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 01:17:51 +00:00
4a3faae0e8
Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element.
...
Props johnschulz, azaozz.
Fixes #43012 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42430
git-svn-id: http://core.svn.wordpress.org/trunk@42260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 20:20:53 +00:00
fbb1f9162b
Formatting: Fix capital_P_dangit() not capital P-ing, dangit.
...
Unfortunately, in my overzealous desire to fix all the un-capitalised Ps, [42343] capitalled some Ps that intentionally should not be capitals.
This commit fixes the incorrectly capitalling of Ps, as well as including unit tests and PHPCS instructions to ensure we never capitulate to capitalisationing them again.
Props superdav42.
Fixes #43040 .
Fixes #43041 .
Built from https://develop.svn.wordpress.org/trunk@42429
git-svn-id: http://core.svn.wordpress.org/trunk@42259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 10:36:51 +00:00
d1c58e7850
Docs: Improve JSDoc for `js/media-upload.js`.
...
Props terwdan, diedeexterkate, andizer, ireneyoast.
Fixes #42956 .
Built from https://develop.svn.wordpress.org/trunk@42426
git-svn-id: http://core.svn.wordpress.org/trunk@42257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-04 14:37:49 +00:00
4e5215deec
Editor: Link suggestions: add fallback title for posts with no title.
...
Fixes #42664 .
Built from https://develop.svn.wordpress.org/trunk@42425
git-svn-id: http://core.svn.wordpress.org/trunk@42256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-02 18:11:52 +00:00
502dcd51a4
General: Update copyright year to 2018 in license.txt.
...
Fixes #43007 .
Built from https://develop.svn.wordpress.org/trunk@42424
git-svn-id: http://core.svn.wordpress.org/trunk@42255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 03:17:48 +00:00
2eca52eaa4
REST API: Adjust unit testes to expect a 401 status code in error responses from permission callbacks when user is not authenticated.
...
Missed in [42421].
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42423
git-svn-id: http://core.svn.wordpress.org/trunk@42254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 02:31:46 +00:00
a787006298
REST API: Return the proper status code for failed permission callbacks in `WP_REST_Server->dispatch()`.
...
Use the `rest_authorization_required_code()` function to return a 401 status code when a permission callback fails due to a user not being logged in.
Props jaswrks.
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42421
git-svn-id: http://core.svn.wordpress.org/trunk@42252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-30 20:37:47 +00:00
386a5c397f
Comments: Introduce filter for the arguments for the comment query in the comments list table.
...
Add `comments_list_table_query_args` filter to the Comments List Table.
Props soulseekah, birgire.
Fixes #42997 .
Built from https://develop.svn.wordpress.org/trunk@42420
git-svn-id: http://core.svn.wordpress.org/trunk@42251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-29 18:21:52 +00:00
02d04f2b5c
WP: Don't attempt to convert multiple-nested arrays to a string in WP->parse_request().
...
See #14330 .
Fixes #42752 .
Built from https://develop.svn.wordpress.org/trunk@42419
git-svn-id: http://core.svn.wordpress.org/trunk@42250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 03:18:47 +00:00
699025a785
Taxonomy: Restore deprecated argument to `term_description()` signature.
...
This ensures that the parameter can't be reused for something else
in the future.
Props jorbin.
Fixes #42605 .
Built from https://develop.svn.wordpress.org/trunk@42417
git-svn-id: http://core.svn.wordpress.org/trunk@42248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 02:48:51 +00:00
02b86b8418
Docs: Improve JSDoc for `customize-preview-widgets.js`.
...
Props ireneyoast, andizer, robinvandervliet, boblinthorst.
Fixes #42954 .
Built from https://develop.svn.wordpress.org/trunk@42416
git-svn-id: http://core.svn.wordpress.org/trunk@42247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 15:12:49 +00:00
f296e2cbbc
Docs: Improve JSDoc for `media/views/attachments.js`.
...
Props maartenleenders, herregroen, jipmoors, ireneyoast.
Fixes #42832 .
Built from https://develop.svn.wordpress.org/trunk@42415
git-svn-id: http://core.svn.wordpress.org/trunk@42246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 14:27:52 +00:00
7dfcb33d4d
Docs: Remove erroneous zero-width space before URL in `fetch_feed()` DocBlock.
...
Props coffee2code.
Fixes #42951 . See #meta3212.
Built from https://develop.svn.wordpress.org/trunk@42414
git-svn-id: http://core.svn.wordpress.org/trunk@42245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 02:40:54 +00:00
1caa918dbc
i18n: Don't use `esc_attr_e()` on a variable.
...
Props yoavf.
Fuxes #42935 .
Built from https://develop.svn.wordpress.org/trunk@42413
git-svn-id: http://core.svn.wordpress.org/trunk@42244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-20 05:35:50 +00:00
a5e2908bbd
Docs: Improve the function and parameter descriptions for `do_meta_boxes()`.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42412
git-svn-id: http://core.svn.wordpress.org/trunk@42243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-19 15:03:52 +00:00
f6a37e7d39
Docs: Remove `@summary` tags from JSDoc.
...
As decided in the JavaScript core chat. With a few reasons:
* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.
The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.
Props herregroen.
Fixes #42901 .
Built from https://develop.svn.wordpress.org/trunk@42411
git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
65b715c991
Docs: Improve JSDoc for `js/media/controllers/edit-image.js`.
...
Amends r42392 - includes the built media files.
Built from https://develop.svn.wordpress.org/trunk@42410
git-svn-id: http://core.svn.wordpress.org/trunk@42239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 11:20:47 +00:00
df07690883
Canonical: After [42408], remove `sprintf()` call for consistency with `Location` header.
...
See #42313 .
Built from https://develop.svn.wordpress.org/trunk@42409
git-svn-id: http://core.svn.wordpress.org/trunk@42238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 01:11:47 +00:00
0bc86bc220
Canonical: Introduce `x_redirect_by` filter that allows applications to identify themselves via `X-Redirect-By` header when they're doing a redirect.
...
Props joostdevalk.
Fixes #42313 .
Built from https://develop.svn.wordpress.org/trunk@42408
git-svn-id: http://core.svn.wordpress.org/trunk@42237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 01:04:52 +00:00
cb53982d1f
Media: Pass the attachment ID to the `intermediate_image_sizes_advanced` filter.
...
Props drywallbmb, robbie505
Fixes 42745
Built from https://develop.svn.wordpress.org/trunk@42407
git-svn-id: http://core.svn.wordpress.org/trunk@42236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:47:47 +00:00
3ee38c0a05
Login and Registration: Instruct the browser to disable autocapitalisation for the user login field on the login screen.
...
Props drywallbmb
Fixes #42886
Built from https://develop.svn.wordpress.org/trunk@42406
git-svn-id: http://core.svn.wordpress.org/trunk@42235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:41:48 +00:00
e123166a3a
Build/Test Tools: Instruct Git and Subversion to ignore Composer's `vendor` directory.
...
Props netweb
Fixes #42909
Built from https://develop.svn.wordpress.org/trunk@42405
git-svn-id: http://core.svn.wordpress.org/trunk@42234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:38:53 +00:00
d82e2b02be
Media: improve flows for cropping on attachment details screen.
...
On the "Attachment Details" screen:
* The crop button is always 'enabled'.
* Clicking the crop button with no selection selects the entire image.
* Clicking the crop button with the entire image selected doesn't do anything.
* Clicking the crop button with a selection crops as expected.
Props sonjanyc, afercia, mikeschroder.
Fixes #30155 .
Built from https://develop.svn.wordpress.org/trunk@42404
git-svn-id: http://core.svn.wordpress.org/trunk@42233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 22:03:50 +00:00
1f707de9dd
Docs: Improve wp-admin JSDoc structural data globally.
...
JSDoc takes it structural data from `@namespace`, `@lends` and `@memberOf`. This change fixes these tags for all JavaScript files in the wp-admin folder.
* Add jsdoc configuration to parse wp-admin/js files. Use `jsdoc -c jsdoc.conf.json` to generate JSDoc.
* Define all used namespaces using `@namespace`.
* Define each usage of the extend function as a prototype assignment using `@lends`.
* Add `@alias` if JSDoc cannot detect the correct name automatically.
This has previously been corrected for all `wp-includes` JavaScript files: [41351].
Props herregroen.
Fixes #42485 .
Built from https://develop.svn.wordpress.org/trunk@42403
git-svn-id: http://core.svn.wordpress.org/trunk@42232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 13:42:46 +00:00
36498bd601
Improve performance of `wp_list_pages()` tests.
...
The changeset also removes the use of hardcoded post/author IDs.
Props frank-klein.
Fixes #42903 .
Built from https://develop.svn.wordpress.org/trunk@42402
git-svn-id: http://core.svn.wordpress.org/trunk@42231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 11:15:46 +00:00
6da54f0d9b
Canonical URLs: Redirect to the correct URL when the post date changes.
...
When a post slug is changed, we store a copy of the old slug, so that we can redirect visitors visiting the old URL to the new URL.
In the same way, this stores a copy of the old date, when the post date changes, so we can redirect visitors to the new URL.
Props nickmomrik.
Fixes #15397 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42401
git-svn-id: http://core.svn.wordpress.org/trunk@42230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 08:31:47 +00:00
7c77266b9b
Docs: Remove extra dot from some `@since` tags.
...
Props hardik-amipara.
Fixes #42899 .
Built from https://develop.svn.wordpress.org/trunk@42400
git-svn-id: http://core.svn.wordpress.org/trunk@42229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 05:16:47 +00:00
a3f69ffaa3
Docs: Add missing `@staticvar` entries in `wp-includes/l10n.php`.
...
Props birgire.
Fixes #42800 .
Built from https://develop.svn.wordpress.org/trunk@42399
git-svn-id: http://core.svn.wordpress.org/trunk@42228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 05:08:51 +00:00
ff89ce1879
Posts: Rename `$ID` to `$post` in `get_post_mime_type()` and `get_post_status()` for consistency with other functions.
...
See #42797 .
Built from https://develop.svn.wordpress.org/trunk@42398
git-svn-id: http://core.svn.wordpress.org/trunk@42227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 01:03:47 +00:00
0d09b75c4b
Docs: Add missing parameter description in `wp_get_post_parent_id()` function DocBlock.
...
Rename `$post_ID` to `$post` for consistency with other functions.
Add unit tests for `wp_get_post_parent_id()`.
Props keesiemeijer.
Fixes #42797 .
Built from https://develop.svn.wordpress.org/trunk@42397
git-svn-id: http://core.svn.wordpress.org/trunk@42226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 01:02:48 +00:00
faa04cf9b3
Docs: Add `@since` version for `WP_Customize_Widgets::filter_dynamic_sidebar_params()`.
...
Props keesiemeijer.
Fixes #42894 .
Built from https://develop.svn.wordpress.org/trunk@42396
git-svn-id: http://core.svn.wordpress.org/trunk@42225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:35:47 +00:00
835bec6282
Docs: Add `@since` version for `WP_Locale_Switcher::init()`.
...
Props keesiemeijer.
Fixes #42798 .
Built from https://develop.svn.wordpress.org/trunk@42395
git-svn-id: http://core.svn.wordpress.org/trunk@42224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:32:46 +00:00
986e46d2c0
Docs: Add missing `@since` tags for add menu page functions.
...
Props keesiemeijer.
Fixes #42882 .
Built from https://develop.svn.wordpress.org/trunk@42394
git-svn-id: http://core.svn.wordpress.org/trunk@42223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:15:52 +00:00
f544da9b38
Docs: Improve JS Docs for `wp-admin/js/dashboard.js`.
...
Props jipmoors, andizer, ireneyoast, boblinthorst.
Fixes #42831 .
Built from https://develop.svn.wordpress.org/trunk@42393
git-svn-id: http://core.svn.wordpress.org/trunk@42222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-14 14:11:51 +00:00
a846a553a1
Docs: Improve JS Docs for `js/media/controllers/edit-image.js`.
...
Props jjcomack, nicollle, andizer.
Fixes #42680 .
Built from https://develop.svn.wordpress.org/trunk@42392
git-svn-id: http://core.svn.wordpress.org/trunk@42221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-13 14:10:52 +00:00
fe2fda8cc2
Editor: Fix determining TinyMCE editor width when in inline mode instead of iframe mode.
...
See #40854 .
Amends [41985].
Props aduth.
Fixes #42416 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42390
git-svn-id: http://core.svn.wordpress.org/trunk@42219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-13 05:17:48 +00:00
1a357d3758
Docs: Improve JS Docs for `wp-includes/js/heartbeat.js`.
...
Most of the documentation was already present. This change achieves the following:
* Fixes the formatting for most doc blocks.
* Adds `@since` tags to all functions.
* Makes sure the heartbeat public methods are correctly added to the `wp.heartbeat` namespace.
Props andizer, jjcomack, carolinegeven.
Fixes #42675 .
Built from https://develop.svn.wordpress.org/trunk@42389
git-svn-id: http://core.svn.wordpress.org/trunk@42218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 14:33:54 +00:00
04efa7e7ea
WPDB: Always use `mysqli` when available.
...
This change makes WordPress use `mysqli` on PHP <5.5 when available, instead of only in PHP 5.5+ and development installs.
WPDB includes a fallback to `mysql` in the event that the database connection fails with `mysqli` so incompatibilities should be few and far between.
Fixes #42812 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42388
git-svn-id: http://core.svn.wordpress.org/trunk@42217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 05:43:48 +00:00
6322887487
Filesystem: Allow `wp_normalise_path()` to handle PHP stream wrappers such as `php://` correctly.
...
Props calin, dd32.
Fixes #42837 .
Built from https://develop.svn.wordpress.org/trunk@42387
git-svn-id: http://core.svn.wordpress.org/trunk@42216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 04:16:47 +00:00
d6ffe16606
Twenty Ten: Use global img contraint for captions
...
Fixes an incompatibility with the way caption width is set since 4.9, where the caption element would cover the whole content width.
Props slilley, Clorith, hardeepasrani.
Fixes #42604 .
Built from https://develop.svn.wordpress.org/trunk@42386
git-svn-id: http://core.svn.wordpress.org/trunk@42215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 23:32:46 +00:00
46cbfc405f
Docs: Improve JS Docs for `custom-header.js`.
...
The `custom-header.js` file is only used on the `wp-admin/themes.php?page=custom-header` page. As that page is no longer linked from the UI the functions in the file are marked deprecated.
Props nicollle, jipmoors, diedeexterkate.
Fixes #42678 .
Built from https://develop.svn.wordpress.org/trunk@42385
git-svn-id: http://core.svn.wordpress.org/trunk@42214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 16:27:51 +00:00
078b842c60
Docs: Correct some typos in the docs for `wp_ajax_get_community_events()`.
...
Props Presskopp.
Fixes #42861 .
Built from https://develop.svn.wordpress.org/trunk@42384
git-svn-id: http://core.svn.wordpress.org/trunk@42213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 08:49:48 +00:00
ea74239f90
Posts: When using `wp_update_post()` on a `attachment` post_type item, pass the `$wp_error` parameter through to `wp_insert_attachment()`.
...
Props MyThemeShop.
Fixes #41513 .
Built from https://develop.svn.wordpress.org/trunk@42383
git-svn-id: http://core.svn.wordpress.org/trunk@42212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 06:37:50 +00:00
24a94c55ae
Build/Test tools: Switch to PHPUnit's `expectOutputString()` method instead of manually using output buffers for output assertions.
...
Props birgire
Fixes #42098
Built from https://develop.svn.wordpress.org/trunk@42382
git-svn-id: http://core.svn.wordpress.org/trunk@42211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-10 00:31:46 +00:00
a985a50526
Build/Test tools: Remove unnecessary PHP functionality tests from the test suite.
...
Props Frank Klein
Fixes #42277
Built from https://develop.svn.wordpress.org/trunk@42381
git-svn-id: http://core.svn.wordpress.org/trunk@42210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-09 23:09:48 +00:00
ee51200c50
Role/Capability: When checking capabilities before setting a post slug, ensure the correct post type capabilities are used.
...
Previously, only the `publish_posts` capability was checked. Now, the correct meta or primitive capability for the post type is used where appropriate.
Props peterwilsoncc
Fixes #42464
Built from https://develop.svn.wordpress.org/trunk@42380
git-svn-id: http://core.svn.wordpress.org/trunk@42209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-09 22:51:54 +00:00
dbd8923458
Build/Test tools: Add inline documentation to undocumented methods in the `WP_UnitTestCase` class.
...
Props Frank Klein
Fixes #42731
Built from https://develop.svn.wordpress.org/trunk@42379
git-svn-id: http://core.svn.wordpress.org/trunk@42208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-08 21:01:51 +00:00
7ec3bfe1ce
Permalinks: Remove unnecesary temporary variable in `get_permalink()`.
...
Props JPry, danimalbrown.
Fixes #41981 .
Built from https://develop.svn.wordpress.org/trunk@42378
git-svn-id: http://core.svn.wordpress.org/trunk@42207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-07 14:50:46 +00:00
823ec0859a
Docs: Correct `@staticvar` entry for `wp_rand()`.
...
Props chetan200891, birgire.
Fixes #42796 .
Built from https://develop.svn.wordpress.org/trunk@42377
git-svn-id: http://core.svn.wordpress.org/trunk@42206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-07 13:53:47 +00:00
0354c3e2f1
Docs: Add missing `@return` entry for `WP_Comment_Query::get_comment_ids()`.
...
Props chetan200891, birgire.
Fixes #42795 .
Built from https://develop.svn.wordpress.org/trunk@42376
git-svn-id: http://core.svn.wordpress.org/trunk@42205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-07 13:47:52 +00:00
856e7917e8
Widgets: Always try restoring widget assignments
...
For code-historic reasons, restoring widget assignments would not be attempted if there were no sidebars to map.
Restoring previous assignments is something unrelated to sidebar mappings however, so now it will be attempted on every theme switch.
See #42719 .
Built from https://develop.svn.wordpress.org/trunk@42374
git-svn-id: http://core.svn.wordpress.org/trunk@42203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-07 02:20:52 +00:00
f4faaa53c7
Docs: Improve the usefulness of docs for `wp_generate_password()` by noting the use of wp_rand() vs `rand()` or `mt_rand()`.
...
Props webdevmattcrom.
Fixes #42782 .
Built from https://develop.svn.wordpress.org/trunk@42373
git-svn-id: http://core.svn.wordpress.org/trunk@42202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 22:40:47 +00:00
39c7daf7db
`category_description()` should be taxonomy-agnostic.
...
This change reinstates the previous de facto behavior of `category_description()`.
See [40979], [42364]. Because `term_description()` no longer passes `$taxonomy` to
`get_term_field()`, the parameter is no longer needed and has been deprecated.
Fixes #42605 . See #42771 .
Built from https://develop.svn.wordpress.org/trunk@42368
git-svn-id: http://core.svn.wordpress.org/trunk@42197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 21:49:46 +00:00
bc769416d8
`get_the_category_by_ID()` should be taxonomy-agnostic.
...
Prior to 4.9, this function was accidentally taxonomy-agnostic in most cases.
The fix in [40979] caused a regression in this function. For backward
compatibility, we make it explicit that the query is by ID only.
See #42771 .
Built from https://develop.svn.wordpress.org/trunk@42367
git-svn-id: http://core.svn.wordpress.org/trunk@42196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 21:03:48 +00:00
1abbaa0f74
Fix regression in `get_tag_link()` since 4.9.
...
See [42364] for description of the problem.
Because `get_category_link()` is now totally taxonomy-agnostic, `get_tag_link()`
can become a simple wrapper.
Props juiiee8487, markjaquith.
See #42771 .
Built from https://develop.svn.wordpress.org/trunk@42366
git-svn-id: http://core.svn.wordpress.org/trunk@42195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 20:52:48 +00:00
438f7a0701
Fix incorrect test names from [42364].
...
See #42771 .
Built from https://develop.svn.wordpress.org/trunk@42365
git-svn-id: http://core.svn.wordpress.org/trunk@42194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 20:47:49 +00:00
d8215873a2
Don't do a strict taxonomy check in `get_category_link()`.
...
Prior to version 4.9, a quirk in the implementation of `get_term()` caused
`get_category_link( 123 )` to fetch the taxonomy archive link for term 123
even if 123 is not in the 'category' taxonomy. The quirk was fixed in [40979];
see #40671 . This bugfix introduced a regression for theme authors who were
expecting the old behavior.
By lifting the 'category' restriction, we allow the template function to work
in the old way.
Fixes #42717 . See #42771 .
Built from https://develop.svn.wordpress.org/trunk@42364
git-svn-id: http://core.svn.wordpress.org/trunk@42193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 20:39:45 +00:00
ff25787995
Widgets: Don't try mapping empty sidebars.
...
Fixes a bug where the mapping logic would try mapping empty sidebars, resulting in PHP warnings.
Props ionvv, chetan200891 for initial patch.
Fixes #42603 .
Built from https://develop.svn.wordpress.org/trunk@42362
git-svn-id: http://core.svn.wordpress.org/trunk@42191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 20:12:48 +00:00
4048a63b01
Docs: Add missing description for `$weekday_name` parameter and `@return` entry in `WP_Locale::get_weekday_initial()`.
...
Props keesiemeijer, 1naveengiri.
Fixes #42793 .
Built from https://develop.svn.wordpress.org/trunk@42361
git-svn-id: http://core.svn.wordpress.org/trunk@42190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 15:59:54 +00:00
f617a2d6d9
Comments: Modernise JavaScript for comment reply links.
...
Update the comment reply JavaScript to be unobtrusive and use events rather than inline `onclick` attributes.
Along with bringing the code into the 2010s this prevents an edge-case in which `addComment.moveForm()` could be called before the JavaScript has loaded.
Props peterwilsoncc, bradparbs.
Fixes #31590 .
Built from https://develop.svn.wordpress.org/trunk@42360
git-svn-id: http://core.svn.wordpress.org/trunk@42189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 22:37:45 +00:00
389283f5bd
REST API: Include permalink_structure in the settings route.
...
There are situations where the REST API client wants to be able to read and set the permalink_structure option. Though this doesn’t fix the use case of front-end rendered unauthenticated websites, it still has utility as a setting in it’s own right.
Props aduth.
See #41014 .
Built from https://develop.svn.wordpress.org/trunk@42359
git-svn-id: http://core.svn.wordpress.org/trunk@42188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 22:29:45 +00:00
c857299cd2
GENERAL: Update recommended PHP version to 7.2.
...
Props otto42, johnbillion, rachelbaker, jorbin.
Fixes 42789.
Built from https://develop.svn.wordpress.org/trunk@42358
git-svn-id: http://core.svn.wordpress.org/trunk@42187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 21:58:46 +00:00
73aca50ff0
CODING STANDARDS: Fix single/double quotation mark
...
Broken in [42351].
Unprops adamsilverstein.
Fixes 42679.
Built from https://develop.svn.wordpress.org/trunk@42357
git-svn-id: http://core.svn.wordpress.org/trunk@42186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 21:19:48 +00:00
12c03d7aa8
REST API: Fix permissions error message in post statuses controller.
...
The permissions error message when a request tries to fetch post statuses unauthenticated is incorrect. It was a copy/paste from elsewhere, as indicated by the use of "in this post type" where this is no post type referenced.
Props schlessera.
Fixes #42303 .
Built from https://develop.svn.wordpress.org/trunk@42356
git-svn-id: http://core.svn.wordpress.org/trunk@42185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 20:49:47 +00:00
e4e0aa27a5
Docs: Add description for is_day().
...
Props webdevmattcrom.
Fixes #42784 .
Built from https://develop.svn.wordpress.org/trunk@42355
git-svn-id: http://core.svn.wordpress.org/trunk@42184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 20:42:47 +00:00
0e656c1a10
REST API: Correct HTTP status code in error for requests to create a duplicate term.
...
The 409 error code is intended for situations where it is expected that the user will resolve the conflict and resubmit the same request. We use 400 error codes for other routes when a duplicate request is made. The 400 status code tells the user they need to modify their request for it to be successful.
Props shooper.
Fixes #42781 . See #41370 .
Built from https://develop.svn.wordpress.org/trunk@42354
git-svn-id: http://core.svn.wordpress.org/trunk@42183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 19:09:49 +00:00
9ff1fb5af1
Docs: Improve JSDocs for cropper.js.
...
Ammends r42352 - include the built media files.
Built from https://develop.svn.wordpress.org/trunk@42353
git-svn-id: http://core.svn.wordpress.org/trunk@42182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 18:56:46 +00:00
56f0da1f45
Docs: Improve JSDocs for cropper.js.
...
Props manuelaugustin, bramheijmink.
Fixes #42677 .
Built from https://develop.svn.wordpress.org/trunk@42352
git-svn-id: http://core.svn.wordpress.org/trunk@42181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 18:47:46 +00:00
5b4c7c4fab
Docs: Improve JSDocs for common.js.
...
Props andizer, rensw90, benvaassen, jipmoors, ireneyoast and nicollle.
Fixes 42679.
Built from https://develop.svn.wordpress.org/trunk@42351
git-svn-id: http://core.svn.wordpress.org/trunk@42180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 18:12:41 +00:00
01eeeb80fd
REST API: Add existing term_id to the error data object when attempting to create a duplicate term.
...
Props shooper, coleh.
Fixes #42597 . See #41370 .
Built from https://develop.svn.wordpress.org/trunk@42350
git-svn-id: http://core.svn.wordpress.org/trunk@42179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 18:11:53 +00:00
36b3f1707c
Hooks: Standardize naming of dynamic hooks using values derived from superglobals to use interpolation vs concatenation.
...
This is a continuation of the work that happened in [38307] for #37748 .
Props ramiy.
Fixes #42698 .
Built from https://develop.svn.wordpress.org/trunk@42349
git-svn-id: http://core.svn.wordpress.org/trunk@42178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 11:36:50 +00:00
216441356a
Twenty Seventeen: Correct the number of recent posts in a comment in `template-parts/page/content-front-page-panels.php`.
...
Props skostadinov, marcelo2605.
Fixes #42621 .
Built from https://develop.svn.wordpress.org/trunk@42348
git-svn-id: http://core.svn.wordpress.org/trunk@42177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:47:52 +00:00
82e5b30939
Twenty Seventeen: Use consistent wording when referring to the front page in inline docs.
...
Props chetan200891.
Fixes #42666 .
Built from https://develop.svn.wordpress.org/trunk@42347
git-svn-id: http://core.svn.wordpress.org/trunk@42176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:44:47 +00:00
ea5c584222
Coding Standards: Add the `phpcs.xml.dist` file.
...
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42346
git-svn-id: http://core.svn.wordpress.org/trunk@42175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:41:47 +00:00
3c4df552ca
Docs: Correct `$attachment` parameter type for `wp_prepare_attachment_for_js` filter.
...
Props danielbachhuber.
Fixes #42449 .
Built from https://develop.svn.wordpress.org/trunk@42345
git-svn-id: http://core.svn.wordpress.org/trunk@42174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:30:47 +00:00
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
62be7ad218
Tests: Fix a couple of weirdly formatted comments.
...
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42342
git-svn-id: http://core.svn.wordpress.org/trunk@42171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 16:23:53 +00:00
67d03a98c2
Hardening: Remove the ability to upload JavaScript files for users who do not have the `unfiltered_html` capability.
...
Built from https://develop.svn.wordpress.org/trunk@42261
git-svn-id: http://core.svn.wordpress.org/trunk@42090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 16:00:48 +00:00
f1de7e42df
Hardening: Ensure the attributes of enclosures are correctly escaped in RSS and Atom feeds.
...
Built from https://develop.svn.wordpress.org/trunk@42260
git-svn-id: http://core.svn.wordpress.org/trunk@42089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 15:56:48 +00:00
3713ac5ebc
Hardening: Add escaping to the language attributes used on `html` elements.
...
Built from https://develop.svn.wordpress.org/trunk@42259
git-svn-id: http://core.svn.wordpress.org/trunk@42088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 15:55:47 +00:00
eaf1cfdc1f
Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring.
...
Built from https://develop.svn.wordpress.org/trunk@42258
git-svn-id: http://core.svn.wordpress.org/trunk@42087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 15:52:50 +00:00
ca6f54cfce
Users: After [42256], remove unnecessary double quotes around `first_name` and `last_name` properties.
...
See #42713 .
Built from https://develop.svn.wordpress.org/trunk@42257
git-svn-id: http://core.svn.wordpress.org/trunk@42086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 15:28:53 +00:00
05d60f74ed
Users: Display partial names in the user listing tables.
...
This allows showing a name when only the first or last name is provided.
Props shital-patel, antipole.
Fixes #42713 .
Built from https://develop.svn.wordpress.org/trunk@42256
git-svn-id: http://core.svn.wordpress.org/trunk@42085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 03:41:46 +00:00
b17405c3fe
General: Add complete test coverage for `WP_Error`.
...
See #42742 .
Built from https://develop.svn.wordpress.org/trunk@42255
git-svn-id: http://core.svn.wordpress.org/trunk@42084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 02:19:48 +00:00
d8a995fc15
Media: Further improvements to the handling of language codes that get passed to MediaElement.
...
This change means that only the leading portion of a locale code gets passed to MediaElement, removing problems that arise from locales such as `de_DE_formal` and `pt_PT_ao90`.
Props erich_k4wp, blobfolio, flixos90, ocean90, joemcgill, SergeyBiryukov.
Fixes #42574
Built from https://develop.svn.wordpress.org/trunk@42251
git-svn-id: http://core.svn.wordpress.org/trunk@42080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 14:52:51 +00:00
9b68e59534
REST API: Ensure rest_url() consistently has leading slash.
...
`rest_url()` inconsistent addes slashes to the passed path depending on whether the site has pretty permalinks enabled. Apart from being inconsistent, this also caused the unit tests to fail when pretty permalinks are enabled.
Props frank-klein.
Fixes #42452 . See #41451 .
Built from https://develop.svn.wordpress.org/trunk@42250
git-svn-id: http://core.svn.wordpress.org/trunk@42079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 07:10:46 +00:00
882db52bdd
General: Add inline PHPCS options to leave regex indentation.
...
We have a handful of super long regexen that are written over multiple lines, as a collection of strings concatenated together. Each string is indented appropriately for the regex, but PHPCS doesn't recognised this, so defaults to removing the extra whitespace.
Disabling the `Squiz.Strings.ConcatenationSpacing.PaddingFound` rule for these blocks stops the extra whitespace from being removed.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42249
git-svn-id: http://core.svn.wordpress.org/trunk@42078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 04:24:57 +00:00
58a904e893
Theme Editor: Translate the URL to the Child Themes Codex page.
...
Props odysseygate, johnpgreen.
Fixes #42454 .
Built from https://develop.svn.wordpress.org/trunk@42247
git-svn-id: http://core.svn.wordpress.org/trunk@42076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:52:47 +00:00
271e08a26e
Theme Editior: Base the nonce on a simpler combination of fields, for easier debugging & reading.
...
See #42609 .
Fixes #42705 .
Built from https://develop.svn.wordpress.org/trunk@42246
git-svn-id: http://core.svn.wordpress.org/trunk@42075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:44:47 +00:00
daacc37405
Theme Editor: Validate files are editable based on their relative filenames, rather than full file path.
...
This fixes theme editing on Windows platforms where `validate_file()` will return `2` on a full file path.
Fixes #42609 .
Built from https://develop.svn.wordpress.org/trunk@42244
git-svn-id: http://core.svn.wordpress.org/trunk@42073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:28:48 +00:00
28677d382d
Theme/Plugin Editor: Remove the caching added in [41806] as it causes more problems than it fixes.
...
While caching here seemed like a good idea in theory, in practice the cache would be often stale causing development issues.
We exclude common folders (such as `node_modules`) from the scanning to avoid directories which are not useful to the end-user, so as long as those exclusion lists are held up this shouldn't cause too much of a degredation in the future.
We may consider adding caching here again in the future if it's determined that it is really needed.
Props precies, ibenic, mariovalney, schlessera, and all the others who commented on the ticket(s).
This partually reverts [41806].
See #6531 .
Fixes #42573 .
Built from https://develop.svn.wordpress.org/trunk@42242
git-svn-id: http://core.svn.wordpress.org/trunk@42071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 02:59:47 +00:00
c90cfa3b50
General: Fix some precision alignment formatting warnings.
...
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42228
git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
611c090b41
Docs: Update the documentation for `get_post_meta()` to clarify that `$single` has no effect when the `$meta_key` is not provided.
...
Props chetan200891, titodevera.
Fixes #42687 .
Built from https://develop.svn.wordpress.org/trunk@42227
git-svn-id: http://core.svn.wordpress.org/trunk@42056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 03:17:54 +00:00
b33967cd31
WPDB: Fix the parsing of sockets which contain colons within the socket name (used on some cloud providers).
...
Props natacado.
Fixes #42634 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42226
git-svn-id: http://core.svn.wordpress.org/trunk@42055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-24 05:52:46 +00:00
5342b33a0b
Template: Don't output an empty `<ul>` in `the_meta()` when a post only has protected metas.
...
Props campusboy1987, birgire.
Fixes #42629 .
Built from https://develop.svn.wordpress.org/trunk@42225
git-svn-id: http://core.svn.wordpress.org/trunk@42054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-24 05:21:51 +00:00
4073743527
Filesystem: Use a more unique filename in `wp_tempnam()` and `get_filesystem_method()`.
...
Using a filename which was generated from `time()` could cause two processes to try to use the same filename, causing unexpected behaviour.
Props jrchamp, bikecrazyy.
Fixes #42265 .
Built from https://develop.svn.wordpress.org/trunk@42224
git-svn-id: http://core.svn.wordpress.org/trunk@42053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-24 03:05:50 +00:00
e0b4933fdb
Themes: Prevent JS error on Themes admin screen when only one theme is installed.
...
Amends [42029].
Props chetan200891, afercia.
See #42348 .
Fixes #42673 .
Built from https://develop.svn.wordpress.org/trunk@42222
git-svn-id: http://core.svn.wordpress.org/trunk@42051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 19:29:46 +00:00
8c7bb9009c
Users: Correct the value of the `lang` attribute in the admin area.
...
This corrects the value when the user's language is set to `English (United States)` but the site language is not.
Props ocean90, afercia
Fixes #42242
Built from https://develop.svn.wordpress.org/trunk@42220
git-svn-id: http://core.svn.wordpress.org/trunk@42049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 19:04:46 +00:00
871c6d2b45
Setup: Allow for `wp-config-sample.php` to be formatted according to coding standards.
...
When the setup process reads `wp-config-sample.php`, it assumes that there are no spaces inside the brackes of the `define()`s. Unfortunately, this doesn't match our coding standards, so will no longer work correctly once we start enforcing them.
This also improves coding standards of the generated `wp-config.php` file.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42218
git-svn-id: http://core.svn.wordpress.org/trunk@42047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 05:23:50 +00:00
a779284c00
General: Reformat inline `if ()` statements inside HTML tags.
...
This pattern occurs a handful of times across the codebase:
`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`
Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42217
git-svn-id: http://core.svn.wordpress.org/trunk@42046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 04:09:49 +00:00
850532fb01
Cron API: Improvements to docblocks for the event scheduling functions.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42216
git-svn-id: http://core.svn.wordpress.org/trunk@42045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-22 15:16:47 +00:00
27116397c5
Upgrade: Fix updating plugins which include a numeric file/folder names.
...
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).
Props edo888.
See #41524 .
Fixes #42628 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42214
git-svn-id: http://core.svn.wordpress.org/trunk@42043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 04:15:47 +00:00
2322b40358
Introduce `meta_box_sanitize_cb` taxonomy argument.
...
The `meta_box_cb` argument was introduced in [25572] to allow plugin
authors to provide a custom callback for rendering their taxonomy's meta
box on the post edit screen. However, the routine used to handle the saving
of these custom taxonomy meta boxes was not customizable, but was instead
based simply on whether the taxonomy was hierarchicaly. See [13535].
The new `meta_box_sanitize_cb` argument defaults to the "tag" routine for
non-hierarchical taxonomies and the "category" routine for hierarchical ones,
thereby maintaining the current default behavior. Developers can override this
when the data passed from their `meta_box_cb` differs.
Props boonebgorges, ZaneMatthew, stephenharris.
Fixes #36514 .
Built from https://develop.svn.wordpress.org/trunk@42211
git-svn-id: http://core.svn.wordpress.org/trunk@42040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 03:15:50 +00:00
d14a2988e7
Multisite: Fix broken update `blog_versions` query after [41661].
...
Props Mista-Flo, lenasterg.
Fixes #42641 .
Built from https://develop.svn.wordpress.org/trunk@42210
git-svn-id: http://core.svn.wordpress.org/trunk@42039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 23:46:48 +00:00
d86fe35b7f
Improve data types returned from empty hierarchical term queries.
...
When querying for 'count', ensure that 0 is returned. Otherwise,
ensure that it's an array.
Props xParham, birgire.
Fixes #42327 .
Built from https://develop.svn.wordpress.org/trunk@42209
git-svn-id: http://core.svn.wordpress.org/trunk@42038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 22:46:47 +00:00
aed08a0f25
HTTP API: Add a `WP_Http` class constant for the HTTP status code `301`.
...
Fixes #42490
Built from https://develop.svn.wordpress.org/trunk@42208
git-svn-id: http://core.svn.wordpress.org/trunk@42037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:54:49 +00:00
6e39468def
HTTP API: Add support for a description for HTTP status code `103`.
...
Props Dhruvin
Fixes #42490
Built from https://develop.svn.wordpress.org/trunk@42207
git-svn-id: http://core.svn.wordpress.org/trunk@42036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:35:48 +00:00
bb5621a084
General: Pass on the return value from `wp_redirect()` for `wp_safe_redirect()`.
...
This brings the behaviour of the two functions in line with each other.
Props Drivingralle
Fixes 42108
Built from https://develop.svn.wordpress.org/trunk@42206
git-svn-id: http://core.svn.wordpress.org/trunk@42035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 20:24:48 +00:00
71bdb1635b
DB Repair: Only allow non-falsey values of `WP_ALLOW_REPAIR` to access the DB repair functionality.
...
This allows defining the constant as `false` to prevent access (rather than requiring the constant to be removed entirely).
Props tiagohillebrandt, munklefish.
See #11717 .
Fixes #42622 .
Built from https://develop.svn.wordpress.org/trunk@42205
git-svn-id: http://core.svn.wordpress.org/trunk@42034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-20 06:21:52 +00:00
4ef018df2b
Docs: Correct the `@since` property for the `page_attributes_misc_attributes` action.
...
Props jeremyescott, jfarthing84
Fixes #42607
Built from https://develop.svn.wordpress.org/trunk@42203
git-svn-id: http://core.svn.wordpress.org/trunk@42033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-19 11:52:52 +00:00
d9e4fc273d
Multisite: Do not show edit links in network users table for users that cannot be edited.
...
Props ocean90.
Fixes #42552 .
Built from https://develop.svn.wordpress.org/trunk@42202
git-svn-id: http://core.svn.wordpress.org/trunk@42032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 21:35:51 +00:00
24b1297fab
Remove the `svn:keywords` property from files that don't need it.
...
See #42594
Built from https://develop.svn.wordpress.org/trunk@42201
git-svn-id: http://core.svn.wordpress.org/trunk@42031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 03:01:47 +00:00
cf14a9432c
Remove the `svn:executable` property from files that don't need it.
...
See #42594
Built from https://develop.svn.wordpress.org/trunk@42200
git-svn-id: http://core.svn.wordpress.org/trunk@42030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-17 02:58:45 +00:00
1a5adcf722
Rewrite Rules: Correct the logic in `extract_from_markers()` after [41928].
...
Props stodorovic.
Fixes #42579 . See #39920 .
Built from https://develop.svn.wordpress.org/trunk@42199
git-svn-id: http://core.svn.wordpress.org/trunk@42029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-16 13:25:50 +00:00
5749295a59
Editor: Re-build `tinymce.min.js` after [42191].
...
See #42553 .
Built from https://develop.svn.wordpress.org/trunk@42193
git-svn-id: http://core.svn.wordpress.org/trunk@42023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 23:35:49 +00:00
5cab65edab
Editor: Disable `wp_keep_scroll_position` in IE11 since buggy; fix `matches` polyfill conflict with ME.js by doing runtime feature detection in context window.
...
Props westonruter, SergeyBiryukov, Clorith for testing.
See #41962 , #42029 .
Fixes #42553 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42191
git-svn-id: http://core.svn.wordpress.org/trunk@42021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:59:47 +00:00
f4e974057e
File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes.
...
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423 .
Fixes #42554 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42189
git-svn-id: http://core.svn.wordpress.org/trunk@42019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:29:46 +00:00
9fabdfb212
Customize: Prevent themes panel from auto-expanding in IE11.
...
In IE11 the `input` event erroneously gets triggered initially without any user input.
Amends [41648].
See #37661 .
Fixes #42556 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42187
git-svn-id: http://core.svn.wordpress.org/trunk@42017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:12:53 +00:00
ee126d2567
Widgets: Set global `$post` to current queried object instead of nullifying when `is_singular()` while applying filters (and shortcodes) in Text widget and (via plugin) Custom HTML widget.
...
Also prevent `[gallery]` shortcode from dumping out every attachment on the site when a containing Text widget is shown on an archive template.
Props westonruter, bobbingwide, joemcgill for testing.
See #10457 .
Fixes #42548 , #42547 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42185
git-svn-id: http://core.svn.wordpress.org/trunk@42015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 02:27:48 +00:00
9986ebdc0b
Editor: Improve scrolling behavior and prevent autosave logic from causing dirty state when just switching between Visual and Text tabs.
...
Props pento.
See #41962 , #42029 .
Fixes #42530 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42183
git-svn-id: http://core.svn.wordpress.org/trunk@42013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 00:21:48 +00:00
6c64136035
About Page: Fix issue with overlapping images and text on IE11 and Edge 15.
...
Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42514 .
Fixes #42545 .
Built from https://develop.svn.wordpress.org/trunk@42181
git-svn-id: http://core.svn.wordpress.org/trunk@42011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 23:02:48 +00:00
fc0f64e1ef
Editor: Cease adding paragraphs when switching editor tabs.
...
Fixes an error since [41783] in which extra paragraphs could be added to content when switching editor tabs.
Props pento, adamsilverstein, aduth.
Fixes #42531 .
Built from https://develop.svn.wordpress.org/trunk@42177
git-svn-id: http://core.svn.wordpress.org/trunk@42007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:24:47 +00:00
5dab6b6e61
Editor: When switching Editor tabs, don't scroll unnecessarily.
...
- When switching to the Text view, wait until after the Visual editor element has been hidden, before focussing the `<textarea>`.
- When switching to the Visual view, only scroll if the cursor is not visible on the current screen.
Fixes #42530 .
Built from https://develop.svn.wordpress.org/trunk@42175
git-svn-id: http://core.svn.wordpress.org/trunk@42005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:19:49 +00:00
54a2c0dd1f
About: Fix jumping behavior for titles and columns when scrolling.
...
Props ryelle.
See #42087 .
Fixes #42514 , #42526 .
Built from https://develop.svn.wordpress.org/trunk@42173
git-svn-id: http://core.svn.wordpress.org/trunk@42003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:47:58 +00:00
e484b66335
Customize: Allow notifications for linting errors in code editor control (for Additional CSS) to be overridden to allow saving.
...
Implements the same override that was implemented in [41721] for the theme/plugin editors.
See #41897 , #41887 .
Fixes #42528 .
Built from https://develop.svn.wordpress.org/trunk@42171
git-svn-id: http://core.svn.wordpress.org/trunk@42001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:46:34 +00:00
609c0db668
Customize: Prevent PHP notice on theme-switch dashboard welcome link (and link to themes admin screen) when user cannot `customize`.
...
Props skostadinov, ocean90.
Amends [41699].
See #42050 .
Fixes #42525 .
Built from https://develop.svn.wordpress.org/trunk@42169
git-svn-id: http://core.svn.wordpress.org/trunk@41999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:45:11 +00:00
2f95f44008
Correct documentation for `status` param of `WP_Comment_Query`.
...
The `status` parameter accepts an array or string/comma-separated list.
Introduced in [30084].
Props pbiron.
Fixes #41338 .
Built from https://develop.svn.wordpress.org/trunk@42165
git-svn-id: http://core.svn.wordpress.org/trunk@41996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 16:26:47 +00:00
4e320fe008
I18N: Fix passing singular/plural strings to JS.
...
This is a temporary solution while waiting for full I18N support in JS.
Props ocean90, dd32, westonruter, Mirucon for testing.
Amends [41376], [41721], [41389],
See #20491 .
Fixes #42510 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42163
git-svn-id: http://core.svn.wordpress.org/trunk@41994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 07:08:47 +00:00
6d2bf4398c
About: Add vertical alignment for developer happiness sections.
...
Also run CSS autoprefixer to add `-ms-` prefixes for CSS grid identifiers for IE11.
Props Presskopp.
Amends [42121].
See #42087 .
Fixes #42524 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42161
git-svn-id: http://core.svn.wordpress.org/trunk@41992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:48:47 +00:00
41d60f59f8
About: Fix grammar typo with pluralization.
...
Props metodiew, westonruter.
Amends [42121].
See #42087 .
Fixes #42476 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42159
git-svn-id: http://core.svn.wordpress.org/trunk@41990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:19:50 +00:00
2bec203118
About: Synchronize 4.9 tagline across about pages for credits, freedoms, and privacy.
...
Props dave.pullig.
Amends [41943].
See #42087 .
Fixes #42518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42157
git-svn-id: http://core.svn.wordpress.org/trunk@41988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-12 19:59:53 +00:00
2aa2c686d4
Theme Editor: Fix styling of child theme notice.
...
Props westonruter, melchoyce, ndiego.
See #24048 .
Fixes #42491 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42155
git-svn-id: http://core.svn.wordpress.org/trunk@41986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-11 20:43:53 +00:00
826c589f11
Customize: Restore ability to add Custom Link nav menu items for jump links and other URLs that were previously allowed.
...
Simplify regular expression for checking URL validity to just do basic checks to confirm the value looks like a URL. Leave the complete validation to the server-side logic in `WP_Customize_Nav_Menu_Item_Setting::sanitize()` to avoid having to maintain two separate codebases for validating URLs.
Props westonruter, SergeyBiryukov for testing.
Amends [41697].
See #32816 .
Fixes #42506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42153
git-svn-id: http://core.svn.wordpress.org/trunk@41984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:41:53 +00:00
e86536afc9
Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.
...
Props obenland.
Amends [41817].
See #42157 .
Fixes #42492 .
Built from https://develop.svn.wordpress.org/trunk@42152
git-svn-id: http://core.svn.wordpress.org/trunk@41983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:01:48 +00:00
67c973f95e
Docs: Correct parameter type documentation for various `__call()` methods.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42151
git-svn-id: http://core.svn.wordpress.org/trunk@41982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:56:47 +00:00
6c6d112e74
Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.
...
Amends [38810].
Props dlh.
Fixes #42497 .
Built from https://develop.svn.wordpress.org/trunk@42150
git-svn-id: http://core.svn.wordpress.org/trunk@41981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:51:46 +00:00
016a3f9ecd
Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).
...
Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721 , #34923 , #42220 .
Fixes #42489 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42148
git-svn-id: http://core.svn.wordpress.org/trunk@41979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:44:52 +00:00
10ac2ccd3a
Settings: Replace `count()` call with `empty()` in `get_settings_errors()` to prevent PHP 7.2 warnings when `$wp_settings_errors` is `null`.
...
Props pross, dd32, westonruter.
See #40109 .
Fixes #42498 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42146
git-svn-id: http://core.svn.wordpress.org/trunk@41977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:30:56 +00:00
9db496159e
Customize: Ensure autosave revision is dismissed immediately after implicit restoration notice dismissal as done with explicit notice dismissal.
...
Fixes issue where a drafted/scheduled changeset could inadvertently re-use the previous autosave revision in the preview while a user expects it to have been dismissed.
See #39896 , [41597].
Fixes #42502 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42144
git-svn-id: http://core.svn.wordpress.org/trunk@41975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 21:44:55 +00:00
3be5d4b4f0
Docs: Improve inline docs for the `wp_redirect()` and `wp_safe_redirect()` functions.
...
See #42505 , #42108
Built from https://develop.svn.wordpress.org/trunk@42143
git-svn-id: http://core.svn.wordpress.org/trunk@41974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 13:44:47 +00:00
e8229a25d5
REST API: Add `permalink_structure` to the index endpoint.
...
This allows Gutenberg to implement permalink editing.
Props schlessera.
Fixes #42465 .
Built from https://develop.svn.wordpress.org/trunk@42142
git-svn-id: http://core.svn.wordpress.org/trunk@41973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 06:11:51 +00:00
4bf8081e64
Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied.
...
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.
Amends [41252].
See #41274 .
Fixes #42488 .
Built from https://develop.svn.wordpress.org/trunk@42140
git-svn-id: http://core.svn.wordpress.org/trunk@41971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 01:28:49 +00:00
1ee26acf95
Customize: Fix reliability of just-in-time publishing for changesets that miss their schedule when visiting `customize.php`.
...
When just doing `wp_publish_post()` for the changeset from `customize.php`, any option-based settings will fail to get saved because `WP_Customize_Manager` would have already been loaded with `settings_previewed`, resulting in `update_option()` calls being short-circuited. So an admin-ajax request to `customize_save` is used to work around this.
Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for testing.
Amends [41626].
See #28721 , #39221 .
Fixes #42457 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42138
git-svn-id: http://core.svn.wordpress.org/trunk@41969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:44:47 +00:00
19ec50f92a
Customize: Ensure `autosaving` message gets sent to preview after initial change when `saved` state is first dirty.
...
Amends [41667].
Fixes #42475 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42136
git-svn-id: http://core.svn.wordpress.org/trunk@41967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:15:49 +00:00
6c00350575
Settings: Fix date/time format previewing.
...
Props afercia.
Amends [41857].
Fixes #41603 .
Built from https://develop.svn.wordpress.org/trunk@42134
git-svn-id: http://core.svn.wordpress.org/trunk@41965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 03:55:46 +00:00
3c6ce6751f
Customize: Restore search icon to available widgets pane incorrectly removed in [41893].
...
See #42215 .
Fixes #42472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42132
git-svn-id: http://core.svn.wordpress.org/trunk@41963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 01:02:47 +00:00
39a3fe9180
Admin Bar: Fix another HTML error introduced in [42128].
...
Props Otto42.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42131
git-svn-id: http://core.svn.wordpress.org/trunk@41962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 23:13:46 +00:00
0a81bcf4ff
External Libraries: Update Random_Compat from 1.2.1 to 2.0.11.
...
Notably this fixes PHP7 parse errors of the files and removes the OpenSSL functionality.
Full Changes: https://github.com/paragonie/random_compat/compare/v1.2.1...v2.0.11
Props jrdelarosa.
See #42439 .
Built from https://develop.svn.wordpress.org/trunk@42130
git-svn-id: http://core.svn.wordpress.org/trunk@41961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 11:48:49 +00:00
e822e4578a
Admin Bar: Fix a HTML error introduced in [42128].
...
Props swissspidy.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42129
git-svn-id: http://core.svn.wordpress.org/trunk@41960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:52:48 +00:00
bde3b95936
Admin Bar: Reformat the render methods.
...
The admin bar render methods use some cute tricks which don't come close to the WordPress coding standards. So that we can more easily apply automated code fixing to the codebase, these tricks need to be removed.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42128
git-svn-id: http://core.svn.wordpress.org/trunk@41959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:35:51 +00:00
d7b49bbc3e
Trunk is now 5.0-alpha
...
Built from https://develop.svn.wordpress.org/trunk@42127
git-svn-id: http://core.svn.wordpress.org/trunk@41958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 05:47:51 +00:00
59fdb7a220
Post WordPress 4.9 RC2 bump.
...
Built from https://develop.svn.wordpress.org/trunk@42125
git-svn-id: http://core.svn.wordpress.org/trunk@41956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 05:26:47 +00:00
f76b491135
WordPress 4.9 RC2.
...
Built from https://develop.svn.wordpress.org/trunk@42124
git-svn-id: http://core.svn.wordpress.org/trunk@41955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:54:47 +00:00
4eda9c7388
About: Hardcoded image sources.
...
We're committed to these images now.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42123
git-svn-id: http://core.svn.wordpress.org/trunk@41954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:26:48 +00:00
e4fe01e2b4
Customize: Fix logic inversion in [42113] which prevented themes from being installed in Customizer.
...
Also fix PHP notice related to parent themes and WordPress.org theme query results.
Props dd32, obenland, celloexpressions, westonruter, atachibana for testing.
See #42406 , #37661 .
Fixes #42442 .
Built from https://develop.svn.wordpress.org/trunk@42122
git-svn-id: http://core.svn.wordpress.org/trunk@41953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:17:47 +00:00
2382232692
About Page: Implement design.
...
Props ryelle, karmatosed, transl8or, obenland, melchoyce.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42121
git-svn-id: http://core.svn.wordpress.org/trunk@41952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:11:47 +00:00
8255d04abb
WPDB: Check that `AUTH_SALT` is not empty.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` defaults to `AUTH_SALT`, but `hash_hmac()` will return an empty string if the key is empty.
This had the side effect of the string `{}` being incorrectly replaced with a `%` character in queries just about to be run on the database.
Props jsonfry.
Fixes #42431 .
Built from https://develop.svn.wordpress.org/trunk@42120
git-svn-id: http://core.svn.wordpress.org/trunk@41949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 01:09:47 +00:00
002d65112f
WPDB: Fix a PHP notice when `AUTH_SALT` is undefined.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` falls back to `rand()` when `AUTH_SALT` is undefined. `hash_hmac()` requires the key to be a string, however, so we need to cast it as such.
Props mkomar.
Fixes #42401 .
Built from https://develop.svn.wordpress.org/trunk@42119
git-svn-id: http://core.svn.wordpress.org/trunk@41948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 00:30:46 +00:00
a74afff787
Customize: Prevent `customize_autosaved=on` from getting added to frontend preview URLs.
...
Amends [41969].
See #39896 , #42450 .
Fixes #42433 .
Built from https://develop.svn.wordpress.org/trunk@42118
git-svn-id: http://core.svn.wordpress.org/trunk@41947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 23:11:53 +00:00
c15b2a0908
Customize: Fall back to ISO date format for date/time control inputs if year, month, or day are missing from the `date_format` option.
...
Amends [42111].
Props dlh, westonruter.
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42117
git-svn-id: http://core.svn.wordpress.org/trunk@41946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 20:28:48 +00:00
b8de3548d3
Administration: Ensure the new Privacy Policy screen appears when within the Network Admin and User Admin.
...
Props hnle, dd32
Fixes #42443
Built from https://develop.svn.wordpress.org/trunk@42116
git-svn-id: http://core.svn.wordpress.org/trunk@41945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 18:17:54 +00:00
65c1468ff5
File Editors: Account for network admin use
...
Fixes a bug where files couldn't be accessed in multisite installs.
Props flixos90, westonruter.
Fixes #42420 .
Built from https://develop.svn.wordpress.org/trunk@42115
git-svn-id: http://core.svn.wordpress.org/trunk@41944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 18:51:49 +00:00
76e01c3562
Customize: Ensure `changeset_uuid` param for autosave auto-draft gets stripped from location after previewing theme switch when not in branching mode.
...
Amends [41597].
See #39896 .
Fixes #42415 .
Built from https://develop.svn.wordpress.org/trunk@42114
git-svn-id: http://core.svn.wordpress.org/trunk@41943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 17:37:52 +00:00
d0608c5585
Customize: Make sure theme switch blocking in the Customizer is consistently applied when changeset is drafted/scheduled.
...
* Consider both `selectedChangesetStatus` and `changesetStatus` states when deciding to disable.
* Factor out common logic into `canSwitchTheme` function on `ThemesPanel`.
* Keep Live Preview and Install buttons disabled in Themes controls and detail overlays when appropriate.
Props westonruter, dlh.
Amends [41788].
See #42126 , #37661 , #39896 .
Fixes #42406 .
Built from https://develop.svn.wordpress.org/trunk@42113
git-svn-id: http://core.svn.wordpress.org/trunk@41942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 00:59:47 +00:00
83c29a4d08
Theme Editor: Ensure files listed recursively can be both viewed and edited.
...
Prevent edits to 2-level deep theme files from returning a `disallowed_theme_file` error when attempting to save an edit. Aligns logic for gathering `$allowed_files` in `theme-editor.php` for listing files with the validation logic in `wp_edit_theme_plugin_file()`.
Amends [41806].
See #6531 .
Fixes #42425 .
Built from https://develop.svn.wordpress.org/trunk@42112
git-svn-id: http://core.svn.wordpress.org/trunk@41941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:05:48 +00:00
ef272167c4
Customize: Present the date/time control input fields in the same format (and order) as `date_format`.
...
Props westonruter, obenland, atachibana for testing, Mirucon for testing.
See #42373 , #28721 .
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42111
git-svn-id: http://core.svn.wordpress.org/trunk@41940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:00:49 +00:00
99c19a5a82
Codemirror: Unify line endings in csslint.js
...
This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in a future release.
Fixes #42424 .
Built from https://develop.svn.wordpress.org/trunk@42110
git-svn-id: http://core.svn.wordpress.org/trunk@41939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 22:31:47 +00:00
8902ddba18
Customize: Always use underlying changeset post date as initial date in scheduled date fields if date is future.
...
Prevent user from having to re-enter the previously-supplied future date if they had switched from schedule to draft but wanted to switch back again. Improves parity with behavior of post edit screen.
Props dlh, westonruter, obenland.
See #39896 , #28721 .
Fixes #42413 .
Built from https://develop.svn.wordpress.org/trunk@42109
git-svn-id: http://core.svn.wordpress.org/trunk@41938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 20:00:48 +00:00
fbee634ac7
Customize: Prevent `history.replaceState()` and `history.pushState()` calls from causing error in customize preview before DOM ready.
...
Amends [41597].
See #39896 .
Fixes #42414 .
Built from https://develop.svn.wordpress.org/trunk@42108
git-svn-id: http://core.svn.wordpress.org/trunk@41937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:27:47 +00:00
5f16c57782
Customize: Prevent re-importing starter content when changeset is saved as draft or scheduled.
...
Themes cannot currently be switched in Customizer after changeset is saved anyway.
Props dlh, westonruter.
See #40146 , #42411 , #42126 .
Fixes #42395 .
Built from https://develop.svn.wordpress.org/trunk@42107
git-svn-id: http://core.svn.wordpress.org/trunk@41936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:00:54 +00:00
7deb33b386
Bundled Themes: Fix fragile `update-theme` phpunit test which broke after version updates in [42105].
...
See #42090 .
Built from https://develop.svn.wordpress.org/trunk@42106
git-svn-id: http://core.svn.wordpress.org/trunk@41935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 01:26:48 +00:00
7b74056cf5
Bundled Themes: Bump version numbers and update changelogs for 4.9 release
...
* Also, updates POT files for Twenty Ten and Twenty Eleven.
Props lemacarl, maedahbatool, mrahmadawais, davidakennedy.
Fixes #42090 .
Built from https://develop.svn.wordpress.org/trunk@42105
git-svn-id: http://core.svn.wordpress.org/trunk@41934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 22:43:47 +00:00
926f2114f0
Customize: Strip zero padding when setting month to prevent de-selection; add zero-padding for `number` input fields when blurring.
...
Amends [42042].
See #42373 .
Fixes #42392 .
Built from https://develop.svn.wordpress.org/trunk@42104
git-svn-id: http://core.svn.wordpress.org/trunk@41933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 21:04:53 +00:00
a2693fd860
Database: Restore numbered placeholders in `wpdb::prepare()`.
...
[41496] removed support for numbered placeholders in queries send through `wpdb::prepare()`, which, despite being undocumented, were quite commonly used.
This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to `wpdb::prepare()`, given the number of placeholders.
See #41925 .
Built from https://develop.svn.wordpress.org/trunk@42056
git-svn-id: http://core.svn.wordpress.org/trunk@41885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 12:00:49 +00:00
6f2db8ea69
Post WordPress 4.9 RC1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@42050
git-svn-id: http://core.svn.wordpress.org/trunk@41884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 04:32:48 +00:00
84c6d74a8c
WordPress 4.9 RC1.
...
Built from https://develop.svn.wordpress.org/trunk@42049
git-svn-id: http://core.svn.wordpress.org/trunk@41883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 03:42:49 +00:00
8a1dc558a1
Customize: Consolidate sourcing of control `params`.
...
Prevent needlessly iterating over `controlConstructor` to find `type` when it is already supplied.
Amends [41750], [41726].
See #42083 .
Built from https://develop.svn.wordpress.org/trunk@42048
git-svn-id: http://core.svn.wordpress.org/trunk@41882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:59:47 +00:00
274792f9cd
REST API: JS client - Enumerate endpoints supporting trash.
...
Improve the logic determining which endpoints support the trash by enumerating them. Endpoints that don't support the trash require `force=true` when deleting. The previous approach relied on the `force` argument description, which is a translated string and was fragile. In the future, we can expose whether an endpoint supports the trash as part of its schema and automate this logic.
Props Soean.
Fixes #40672 .
Built from https://develop.svn.wordpress.org/trunk@42047
git-svn-id: http://core.svn.wordpress.org/trunk@41881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:54:48 +00:00
b61de38e87
Customize: Spiff up theme updates
...
Fixes UI bugs around theme updates in the Customizer. Theme versions now get updated and users are no longer left alone after a successful update.
Props rinkuyadav999, celloexpressions for initial patch.
Fixes #42365 .
Built from https://develop.svn.wordpress.org/trunk@42046
git-svn-id: http://core.svn.wordpress.org/trunk@41880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 01:33:47 +00:00
8981414082
About page: Tweak the privacy policy language, for clarity.
...
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@42045
git-svn-id: http://core.svn.wordpress.org/trunk@41879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 00:21:49 +00:00
f7aa0e24a7
About Page: Update the blurb in "Warning: Potential Danger Ahead!" to be more accurate.
...
Props transl8or, karmatosed, chanthaboune.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42044
git-svn-id: http://core.svn.wordpress.org/trunk@41878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 20:58:50 +00:00
82c6a301f2
Multisite: Pass network object instead of ID to `pre_get_main_site_id`.
...
In the original function introduced in [41380], and subsequently [41861], only the network ID was passed to the new `pre_get_main_site_id` filter. In order to make give quick access to other network properties, it was decided to pass the whole object instead. The changeset includes an additional test.
Fixes #29684 .
Built from https://develop.svn.wordpress.org/trunk@42043
git-svn-id: http://core.svn.wordpress.org/trunk@41877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 19:56:47 +00:00
ca84147401
Customize: Allow 0:00-0:59 in date/time control when 24-hour time used.
...
* Let min hour be 0 and max be 23 in 24-hour time; let min hour be 1 and max be 12 in 12-hour time.
* Show error notification when an invalid date value is provided, not just when not a future date.
* Fix translation of custom validity message.
* Start checking for validity after all inputs have been initially populated.
* Remove support for being able to enter 24:00.
* Cease forcing date input elements from being casted to integers, to allow for invalid inputs to be detected.
Props westonruter, Presskopp, peterwilsoncc, atachibana for testing.
See #39896 , #28721 .
Fixes #42373 .
Built from https://develop.svn.wordpress.org/trunk@42042
git-svn-id: http://core.svn.wordpress.org/trunk@41876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 16:40:47 +00:00
285c6a57c8
Tests: Remove references to deleted JS files in QUnit tests.
...
Amends [41570], [40584].
See #41755 , #40690 .
Built from https://develop.svn.wordpress.org/trunk@42041
git-svn-id: http://core.svn.wordpress.org/trunk@41875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 04:06:48 +00:00
fbb0b8bc8f
Customize: Debounce requests for theme searches and the updating of the resulting filter count.
...
Props celloexpressions.
See #37661 .
Fixes #42343 .
Built from https://develop.svn.wordpress.org/trunk@42040
git-svn-id: http://core.svn.wordpress.org/trunk@41874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 03:57:52 +00:00
9a18c87e0c
Customize: Fix phpdoc for params in `WP_Customize_Manager::add_section()`.
...
Amends [40804].
See #39671 .
Fixes #42372 .
Built from https://develop.svn.wordpress.org/trunk@42039
git-svn-id: http://core.svn.wordpress.org/trunk@41873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 03:22:49 +00:00
5fc9fddccc
Customize: Fix interface alignment between `Setting` and `Control`, adding `defaults` to `wp.customize.Setting` and using `wp.customize.previewer` as default `previewer` param.
...
Also move jsdoc from class to `initialize` method and correct the param types.
Amends [41726], [42037], [32681].
See #42083 , #30737 .
Built from https://develop.svn.wordpress.org/trunk@42038
git-svn-id: http://core.svn.wordpress.org/trunk@41872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 03:08:53 +00:00
35172737ef
Customize: Support instantiation of partials with flat/unwrapped params for parity with controls, sections, and panels in [41726].
...
* Passing `options.params` when constructing `Partial` is now deprecated in favor of just passing `options`.
* Improve usage of jsdoc in JS `Partial` class.
* Also add `defaults` property to `wp.customize.selectiveRefresh.Partial` class for parity with `Control`.
See #42083 .
Built from https://develop.svn.wordpress.org/trunk@42037
git-svn-id: http://core.svn.wordpress.org/trunk@41871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 00:15:53 +00:00
cb7483b595
Customize: Fix mobile placement of panes for available widgets and nav menu items.
...
Props Mahvash-Fatima.
Amends [41893].
See #42215 .
Fixes #42359 .
Built from https://develop.svn.wordpress.org/trunk@42036
git-svn-id: http://core.svn.wordpress.org/trunk@41870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 06:54:47 +00:00
84b969efea
Customize: Ensure `id` for section and panel is passed among `params` to respective templates.
...
Fixes issue where JS-added Publish Settings section failed to get container element ID set properly to hide its section-meta.
Amends [42025].
See #42337 , #42083 .
Built from https://develop.svn.wordpress.org/trunk@42035
git-svn-id: http://core.svn.wordpress.org/trunk@41869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 06:37:47 +00:00
685e3c1a67
Customize: Deprecate nav menu classes that are no longer used, instead of removing them immediately.
...
* Deprecate PHP classes `WP_Customize_New_Menu_Section` and `WP_Customize_New_Menu_Control`.
* Deprecate JS class `wp.customize.Menus.NewMenuControl`.
* Also introduce `wp.customize.Menus.createNavMenu()` for logic to create nav menus separately from the logic for handling UI interactions.
Amends [41768].
See #40104 , #42364 .
Fixes #42357 .
Built from https://develop.svn.wordpress.org/trunk@42034
git-svn-id: http://core.svn.wordpress.org/trunk@41868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 05:48:47 +00:00
9dca5ae189
Customize: Fix deep-linking to sections for themes via `autofocus[section]` query parameter.
...
* Expand containing panel when expanding themes section.
* Consolidate UI changes related to a section's expanded state change.
* Prevent collapsing current section when expanding.
* Auto-expand first themes section when expanding panel if one is not expanded already.
See #37661 , #42354 .
Fixes #42360 .
Built from https://develop.svn.wordpress.org/trunk@42033
git-svn-id: http://core.svn.wordpress.org/trunk@41867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 05:22:46 +00:00
615a9afab8
Tests: Update `wp-api-generated.js`.
...
[41979] caused a change in `wp-api-generated.js`, so it needs to be updated.
See #39996 .
Built from https://develop.svn.wordpress.org/trunk@42032
git-svn-id: http://core.svn.wordpress.org/trunk@41866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 01:56:46 +00:00
d348f1624b
Customize: Improve Media control accessibility and compatibility for `settings` passed as arrays or as solitary `setting`.
...
* Eliminate Media control template from having dependency on `params.settings.default` for element ID, to fix compat with `params.settings` array or single `params.setting`. See #36167 .
* Move description out of label and add `aria-describedby` to Media control's Select button. See #30738 , #33085 .
* Obtain notification container whenever content is (re-)rendered (such as for Media control). See #38794 .
* Re-render notifications after control content is re-rendered, if control is in expanded section. See #38794 .
Amends [41390].
See #36167 , #38794 , #33085 , #30738 .
Built from https://develop.svn.wordpress.org/trunk@42031
git-svn-id: http://core.svn.wordpress.org/trunk@41865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 20:18:47 +00:00
cb877e10ba
Widgets: Prevent showing underlying attachment excerpt as caption when empty caption value is supplied in Image widget.
...
Allow underlying attachment to display if `caption` is `null`.
Props miyauchi, westonruter.
See #39993 .
Fixes #42350 .
Built from https://develop.svn.wordpress.org/trunk@42030
git-svn-id: http://core.svn.wordpress.org/trunk@41864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 05:05:51 +00:00
7b0de1f1b0
Themes: Switch back from throttling to debouncing in theme searches on admin screen.
...
Start debouncing after initial search performed when `search` query param is present to prevent initial "flash of unsearched themes".
Props afercia, westonruter.
Amends [41797].
See #40254 .
Fixes #42348 .
Built from https://develop.svn.wordpress.org/trunk@42029
git-svn-id: http://core.svn.wordpress.org/trunk@41863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 03:31:53 +00:00
c6fd6b0374
External Libraries: Remove usage of `each()` from the `Text_Diff_Engine_native` class.
...
This removes deprecated notices in PHP 7.2 but takes a different approach to the upstream class from Horde, which appears to be buggy.
Props SergeyBiryukov
Fixes #41526
Built from https://develop.svn.wordpress.org/trunk@42028
git-svn-id: http://core.svn.wordpress.org/trunk@41862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-26 12:52:53 +00:00
4550ef5b2c
External Libraries: Remove usage of text strings in `assert()` in the `Text_Diff_Engine_native` class.
...
See #41526
Built from https://develop.svn.wordpress.org/trunk@42027
git-svn-id: http://core.svn.wordpress.org/trunk@41861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-26 11:32:48 +00:00
db00af7cc2
Menus: Add `menu-$i` slugs to mapping groups
...
Helps to future proof the feature.
Also orders slugs by popularity to optimize mapping time.
See #39692 .
Built from https://develop.svn.wordpress.org/trunk@42026
git-svn-id: http://core.svn.wordpress.org/trunk@41860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 22:29:49 +00:00
a6af74ec32
Customize: Register the Publish Settings section in JS to ensure it does not get unregistered via PHP.
...
The `publish_settings` section is a fundamental dependency for Customizer, so it must be guaranteed to be registered.
Also unconditionally register core types for panels, sections, and controls in case plugin unhooks all `customize_register` actions.
See #39896 .
Fixes #42337 .
Built from https://develop.svn.wordpress.org/trunk@42025
git-svn-id: http://core.svn.wordpress.org/trunk@41859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 21:45:49 +00:00
3ed6bbf4a4
Customize: Link `elements` prior to embedding to prevent possible errors when a control is associated with a non-existent section.
...
Fixes issue specifically with attempting to access an orphaned control's `elements` immediately after it has been added. Normally this would not happen because a control would not be registered without a section, and also a control should only be interacted with once its `embedded` deferred has been resolved.
Also harden logic for gathering list of deferred setting IDs.
See #37964 .
Fixes #42330 .
Built from https://develop.svn.wordpress.org/trunk@42024
git-svn-id: http://core.svn.wordpress.org/trunk@41858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 16:49:49 +00:00
6b3b489a5d
Permalinks: Change mention of URI to URL in the description of `%category%` tag.
...
Props danieltj, tobifjellner.
Fixes #42147 .
Built from https://develop.svn.wordpress.org/trunk@42023
git-svn-id: http://core.svn.wordpress.org/trunk@41857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 11:11:45 +00:00
7fc62bbd4f
External Libraries: Revert [41633]. This causes warnings when editing and viewing certain revisions.
...
See #41526
Built from https://develop.svn.wordpress.org/trunk@42022
git-svn-id: http://core.svn.wordpress.org/trunk@41856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 09:56:53 +00:00
6794fd18ef
Post WordPress 4.9 Beta 4 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@42021
git-svn-id: http://core.svn.wordpress.org/trunk@41855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 07:08:52 +00:00
f6bf73792c
WordPress 4.9 Beta 4.
...
Built from https://develop.svn.wordpress.org/trunk@42020
git-svn-id: http://core.svn.wordpress.org/trunk@41854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 06:13:47 +00:00
750098da21
Bundled Themes: Make sure new gallery widgets look good in themes
...
Twenty Ten: Reduces image size and removes image borders for galleries in widget areas.
Twenty Eleven: Reduces image size and removes image borders for galleries in widget areas.
Twenty Twelve: Reduces image size for some gallery sizes in widget areas.
Twenty Thirteen: Ensure proper clearing for images, hide captions for some gallery column combos and ensure good display for galleries in widget areas.
Twenty Fourteen: Ensure proper clearing for images and hide captions for some gallery column combos for galleries in widget areas.
Twenty Seventeen: Hide captions for some gallery column combos for galleries in widget areas.
Props joyously, williampatton, davidakennedy, melchoyce, crunnells.
Fixes #41969 .
Built from https://develop.svn.wordpress.org/trunk@42019
git-svn-id: http://core.svn.wordpress.org/trunk@41853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 02:17:47 +00:00
d19c79fa21
Customize: Remove `theme_installing` notification when installation fails.
...
Amends [41648].
Props celloexpressions.
See #42184 , #37661 .
Built from https://develop.svn.wordpress.org/trunk@42018
git-svn-id: http://core.svn.wordpress.org/trunk@41852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 01:14:46 +00:00
3cd984f024
About page: The link URLs in the privacy policy shouldn't be translatable.
...
Both of these URLs live on the main wordpress.org site, not Rosetta sites.
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@42017
git-svn-id: http://core.svn.wordpress.org/trunk@41851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 01:07:47 +00:00
2762709d2a
Dashboard: Strip ports from IPs to avoid PHP warnings.
...
Fixes #41083 .
Props pento, iandunn, EatonZ, birgire, dd32.
Built from https://develop.svn.wordpress.org/trunk@42016
git-svn-id: http://core.svn.wordpress.org/trunk@41850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 00:07:46 +00:00
12c626c82e
Update `$_old_files` to add the deleted MediaElement.js files when it was upgraded from 2.22.0 to 4.2.3.
...
Amends [41198].
See #39686 .
Fixes #42097 .
Built from https://develop.svn.wordpress.org/trunk@42015
git-svn-id: http://core.svn.wordpress.org/trunk@41849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 00:02:50 +00:00
116e4712cb
I18N: Use a consistent pattern for translator comments for placeholders in the string added in [42013].
...
See #41974 .
Built from https://develop.svn.wordpress.org/trunk@42014
git-svn-id: http://core.svn.wordpress.org/trunk@41848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:40:46 +00:00
7495a110cc
Code Editors: Add a persistent notification on CSS files, encouraging people to use the CSS panel in the Customizer instead of editing their CSS files directly.
...
Props helen, westonruter, nic.bertino, michelleweber.
Fixes #42100 .
Built from https://develop.svn.wordpress.org/trunk@42013
git-svn-id: http://core.svn.wordpress.org/trunk@41847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:35:46 +00:00
d96b7af890
Permalinks: Fix placement of structure tags based on last cursor position.
...
Props felipeelia, afercia.
See #29872 .
Fixes #42042 .
Built from https://develop.svn.wordpress.org/trunk@42012
git-svn-id: http://core.svn.wordpress.org/trunk@41846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:27:48 +00:00
2f3e91028a
Filesystem API: Add more specificity to the rules for valid files in `validate_file()`.
...
This now treats files containing `./` as valid, and also treats files containing a trailing `../` as valid due to widespread use of this pattern in theme and plugin zip files.
Adds tests.
Props Ipstenu, borgesbruno, DavidAnderson, philipjohn, birgire
Fixes #42016 , #36170
Built from https://develop.svn.wordpress.org/trunk@42011
git-svn-id: http://core.svn.wordpress.org/trunk@41845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:15:49 +00:00
16cfe96580
Filesystem API: Don't immediately return an error for invalid file names contained within a Zip while it's being extracted.
...
This allows the extraction of the rest of the valid files within the archive to continue.
See #42016
Built from https://develop.svn.wordpress.org/trunk@42010
git-svn-id: http://core.svn.wordpress.org/trunk@41844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:11:50 +00:00
48e726bbef
Embeds: Improve consistency of update and refresh logic for oEmbed caching between `oembed_cache` and post meta.
...
* Allow updating oEmbed cache during `parse-embed` requests for non-post editors (such as widgets).
* Update any existing `oembed_cache` post when `usecache` and TTL has passed.
* Do not overwrite a previously valid cache with `{{unknown}}`.
Props dlh.
See #34115 .
Fixes #42310 .
Built from https://develop.svn.wordpress.org/trunk@42009
git-svn-id: http://core.svn.wordpress.org/trunk@41843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:10:48 +00:00
5dd45b38c8
Transients: After [41963], add missing cron task for `delete_expired_transients()`.
...
Props dlh.
Fixes #41699 .
Built from https://develop.svn.wordpress.org/trunk@42008
git-svn-id: http://core.svn.wordpress.org/trunk@41842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:00:47 +00:00
4812370aab
Docs: Improve the docs for `validate_file()` and `validate_file_to_edit()`.
...
See #42016 , #36170 , #41017
Built from https://develop.svn.wordpress.org/trunk@42007
git-svn-id: http://core.svn.wordpress.org/trunk@41841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:50:49 +00:00
29d5ee851c
I18N: Use a consistent pattern for translator comments for placeholders in some more Customizer strings.
...
See #41974 .
Built from https://develop.svn.wordpress.org/trunk@42006
git-svn-id: http://core.svn.wordpress.org/trunk@41840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:47:46 +00:00
f156f90ff5
I18N: Add a context for remaining "Schedule" strings.
...
Props Mirucon.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@42005
git-svn-id: http://core.svn.wordpress.org/trunk@41839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:35:47 +00:00
55c8978f1f
Twenty Seventeen: Make gallery link styles consistent in all widget areas
...
Removes the box shadow on gallery links in footer widget areas so they're consistent with the sidebar widget area.
Props transl8or, sami.keijonen, davidakennedy.
Fixes #42302 .
Built from https://develop.svn.wordpress.org/trunk@42004
git-svn-id: http://core.svn.wordpress.org/trunk@41838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:53:51 +00:00
a1ec65b695
Themes: Harmonize list of theme features on Theme Install screen with list in the Customizer.
...
Use the core list, rather than the .org API, due to inconsistencies and to ensure tags are translated.
Props celloexpressions.
See #37661 , #42306 .
Built from https://develop.svn.wordpress.org/trunk@42003
git-svn-id: http://core.svn.wordpress.org/trunk@41837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:46:47 +00:00
50c6a55fba
I18N: Give context to "Installed" string added in [41648].
...
Props dimadin.
Fixes #42325 .
Built from https://develop.svn.wordpress.org/trunk@42002
git-svn-id: http://core.svn.wordpress.org/trunk@41836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:43:47 +00:00
fd2e006968
Widgets: Limit container-constraining logic in Text widget to `video`, `iframe`, `object`, and `embed` elements.
...
Amends [41779].
See #40854 .
Built from https://develop.svn.wordpress.org/trunk@42001
git-svn-id: http://core.svn.wordpress.org/trunk@41835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:32:46 +00:00
bebb0b0d82
REST API: Don’t remove unregistered properties from objects in schema.
...
In r41727 the ability to sanitise and validate objects from JSON schema was added, with a whitelist approach. It was decided we should pass through all non-registered properties to reflect the behaviour of the root object in register_rest_route. To prevent arbitrary extra data via setting objects, we force additionalProperties to false in the settings endpoint.
See #38583 .
Built from https://develop.svn.wordpress.org/trunk@42000
git-svn-id: http://core.svn.wordpress.org/trunk@41834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:05:49 +00:00
c0d0380baa
Code Editors: Tweak styles to work better on smaller screens.
...
See #42100 .
Built from https://develop.svn.wordpress.org/trunk@41999
git-svn-id: http://core.svn.wordpress.org/trunk@41833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 20:29:46 +00:00
9c7eb32fc2
Credits: Update "Contributing Developers" to "Noteworthy Contributors."
...
"Developers" excludes the various major contributors in non-developer roles, so let's update this term to be more inclusive.
See #41022 .
Built from https://develop.svn.wordpress.org/trunk@41998
git-svn-id: http://core.svn.wordpress.org/trunk@41832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 19:29:47 +00:00
6737643773
Customize: Prevent theme installation and deletion in Customizer while SFTP credentials need to be requested.
...
This is a temporary measure while we wait for credentials to be able to be supplied in the Customizer.
Amends [41788].
See #42184 , #37661 , #42126 .
Built from https://develop.svn.wordpress.org/trunk@41997
git-svn-id: http://core.svn.wordpress.org/trunk@41831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 19:06:47 +00:00
b008754486
Code Editors: Update copy in warning modals.
...
Props helen.
See #42100 .
Built from https://develop.svn.wordpress.org/trunk@41996
git-svn-id: http://core.svn.wordpress.org/trunk@41830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 18:47:47 +00:00
5aa45cd12e
Customize: Allow previewed menus to be customized
...
Fixes a bug where menu assignements couldn't be changed when previewing a theme.
Also removes an unnecessary call to menu mapping after a theme switch from the customizer and makes sure the locations option is always written, for good measure.
Props westonruter.
See #39692 .
Built from https://develop.svn.wordpress.org/trunk@41995
git-svn-id: http://core.svn.wordpress.org/trunk@41829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 18:35:48 +00:00
7e689f541d
Code Editor: Fix phpunit tests related to `gutters` after [41974].
...
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41994
git-svn-id: http://core.svn.wordpress.org/trunk@41828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:58:50 +00:00
abc1579a42
TinyMCE: Set undefined FloatPanel zIndex
...
See [40995] for the Customizer.
Fixes #42322 .
Built from https://develop.svn.wordpress.org/trunk@41993
git-svn-id: http://core.svn.wordpress.org/trunk@41827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:52:56 +00:00
226263bfec
Code Editor: Define default `gutters` and toggle lint markers based on changes to `lint` option.
...
Explicitly define `gutters` in base `defaultSettings` to improve merges of multiple calls to `wp_enqueue_code_editor()`.
Props westonruter, georgestephanis for testing.
Amends [41974].
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41992
git-svn-id: http://core.svn.wordpress.org/trunk@41826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:35:54 +00:00
9eb75432b6
Canonical: Strip trailing punctuation from permalinks.
...
Previously attempted in [40256], which caused the test for decoded curly quotes to fail in some environments.
`$_SERVER['REQUEST_URI']` contains the encoded URI, so this version removes the failing tests and only checks for encoded curly quotes.
Props joostdevalk, lancewillett, SergeyBiryukov.
Fixes #20383 .
Built from https://develop.svn.wordpress.org/trunk@41991
git-svn-id: http://core.svn.wordpress.org/trunk@41825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 14:18:48 +00:00
bcdedf7f4a
Formatting: Make sure `wp_allowed_protocols()` is filterable until `wp_loaded` has fired.
...
Fixes the issue with plugins not being able to use the `kses_allowed_protocols` filter if `esc_url()` was called too early.
Props turtlepod, SergeyBiryukov.
Fixes #36033 .
Built from https://develop.svn.wordpress.org/trunk@41990
git-svn-id: http://core.svn.wordpress.org/trunk@41824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 13:25:55 +00:00
Sergey Biryukov
Andrew Ozz
Andrea Fercia
Peter Wilson
atimmer
Dion Hulse
Mike Schroder
Gary Pendergast
Rachel Baker
Boone Gorges
John Blackbourn
Adam Silverstein
Weston Ruter
Konstantin Obenland
Drew Jaynes
Joe Hoyle
Aaron Jorbin
Ryan McCue
Felix Arntz
Mel Choyce
David A. Kennedy
iandunn
Ella Iseulde Van Dorpe