5352f51516
Fix edge-case in media cropping where selection and destination are the same size.
...
Adds unit tests.
Props mboynes.
Fixes #19793 .
Built from https://develop.svn.wordpress.org/trunk@30639
git-svn-id: http://core.svn.wordpress.org/trunk@30629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 06:27:23 +00:00
1e10385a90
Remove an invalid parameter from the DocBlock for the `gallery_style` hook.
...
Props keesiemeijer.
Fixes #30507 .
Built from https://develop.svn.wordpress.org/trunk@30635
git-svn-id: http://core.svn.wordpress.org/trunk@30625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 05:58:47 +00:00
c512f1d916
Remove return descriptions from the DocBlocks for `add_image_size()` and `set_post_thumbnail_size()` as they don't return anything.
...
Also document the `$_wp_additional_image_sizes` global, leveraged in `add_image_size()`.
Props stevegrunwell.
Fixes #30511 .
Built from https://develop.svn.wordpress.org/trunk@30633
git-svn-id: http://core.svn.wordpress.org/trunk@30623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 05:49:23 +00:00
b8c612ca1c
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30542
git-svn-id: http://core.svn.wordpress.org/trunk@30531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:47:23 +00:00
8f2842a07e
Replace invalid use of ltrim() in attachment_url_to_postid() with substr().
...
props bradyvercher.
fixes #30346 .
Built from https://develop.svn.wordpress.org/trunk@30501
git-svn-id: http://core.svn.wordpress.org/trunk@30490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 06:35:22 +00:00
c2f334bf3c
Playlists are video by default. props duck_
...
Built from https://develop.svn.wordpress.org/trunk@30422
git-svn-id: http://core.svn.wordpress.org/trunk@30417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 13:11:23 +00:00
52f51d65ae
Media: Remove another unused string.
...
props pavelevap.
see #29741 .
Built from https://develop.svn.wordpress.org/trunk@30342
git-svn-id: http://core.svn.wordpress.org/trunk@30341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 17:46:22 +00:00
f34d3b1b5a
Media: Remove unused string.
...
props pavelevap.
fixes #29741 .
Built from https://develop.svn.wordpress.org/trunk@30341
git-svn-id: http://core.svn.wordpress.org/trunk@30340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 17:31:23 +00:00
15c062eb79
In `wp_audio|video_shortcode()`, make sure that `autoplay` and `loop` are booleans. Passing `'false'` to them will force them to be active, which is bad.
...
Fixes #29825 .
Built from https://develop.svn.wordpress.org/trunk@30185
git-svn-id: http://core.svn.wordpress.org/trunk@30185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:03:21 +00:00
cd9bb04981
In `gallery_shortcode()`, when the `link` attribute is equal to `file`, make sure to pass `$attr` as the 6th (!) argument, not 5th, to `wp_get_attachment_link()`.
...
Props bradyvercher.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@30161
git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:47:24 +00:00
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
3d8e31fb82
Don't hardcode `height` for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace.
...
Fixes MediaElement by hand in the interim: https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.
Fixes #30078 .
Built from https://develop.svn.wordpress.org/trunk@30082
git-svn-id: http://core.svn.wordpress.org/trunk@30082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 00:47:24 +00:00
5d17d2bd28
The `gallery` shortcode used to accept a SQL chunk for the value of the `orderby` attribute. The reason? `get_posts()` used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, `sanitize_sql_orderby()` was created in [7592].
...
`sanitize_sql_orderby()` expects a comma to be present when multiple `orderby` values were passed. The correct syntax for multiple fields is space-delimited. Since [29027], comma-separated values would never be parsed correctly when passed to `WP_Query->parse_orderby()`.
`sanitize_sql_orderby()` is used nowhere else in core, save for the `playlist` shortcode - I only added it there because I was mimic'ing the `gallery` logic. The function call can be removed from both shortcode handlers.
See #6476 .
Fixes #23873 .
Built from https://develop.svn.wordpress.org/trunk@30068
git-svn-id: http://core.svn.wordpress.org/trunk@30068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 20:43:22 +00:00
007ec52958
Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8.
...
Change all core calls from `json_encode()` to `wp_json_encode()`.
Fixes #28786 .
Built from https://develop.svn.wordpress.org/trunk@30055
git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:35:19 +00:00
72d12b514d
Add a 6th (!) attribute to `wp_get_attachment_link()` to allow `aria-describedby` to be added to gallery output.
...
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@29914
git-svn-id: http://core.svn.wordpress.org/trunk@29667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:28:17 +00:00
45062d7f5c
Update @param docs for wp_get_attachment_image().
...
see #29869 .
Built from https://develop.svn.wordpress.org/trunk@29837
git-svn-id: http://core.svn.wordpress.org/trunk@29601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-05 17:52:15 +00:00
d769e29279
Pass the requested size to 'wp_get_attachment_image_attributes' filter.
...
props mattheu.
fixes #29869 .
Built from https://develop.svn.wordpress.org/trunk@29836
git-svn-id: http://core.svn.wordpress.org/trunk@29600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-05 17:50:16 +00:00
7a55ab9164
Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29776
git-svn-id: http://core.svn.wordpress.org/trunk@29548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 00:14:18 +00:00
10e0807cce
Add context for 'Trash' string in media modal.
...
props pavelevap.
fixes #29739 .
Built from https://develop.svn.wordpress.org/trunk@29764
git-svn-id: http://core.svn.wordpress.org/trunk@29536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-24 13:49:20 +00:00
ee9d74dc05
Ordering by `RAND()`:
...
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.
In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.
Adds unit tests.
Fixes #29629 .
Built from https://develop.svn.wordpress.org/trunk@29760
git-svn-id: http://core.svn.wordpress.org/trunk@29532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-23 03:52:15 +00:00
2008fc0c89
Correct 'wp_get_attachment_image_attributes' filter docs.
...
props tillkruess.
fixes #29701 .
Built from https://develop.svn.wordpress.org/trunk@29750
git-svn-id: http://core.svn.wordpress.org/trunk@29522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-18 12:36:17 +00:00
69e7171f41
Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
...
Built from https://develop.svn.wordpress.org/trunk@29729
git-svn-id: http://core.svn.wordpress.org/trunk@29503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 22:40:16 +00:00
0113d3457b
Avoid PHP notices in media modal caused by orphaned attachments.
...
fixes #29566 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29724
git-svn-id: http://core.svn.wordpress.org/trunk@29498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 10:03:14 +00:00
e496cc6e4b
Media: Ensure media-views is enqueued and registered before localizing.
...
fixes #24724 .
Built from https://develop.svn.wordpress.org/trunk@29678
git-svn-id: http://core.svn.wordpress.org/trunk@29453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 19:36:16 +00:00
703b625820
Media: add a class to the <script> tag for the JSON encoded playlist data so it can be easily selected in WPPlaylistView. Props SergeyBiryukov, fixes #29383
...
Built from https://develop.svn.wordpress.org/trunk@29660
git-svn-id: http://core.svn.wordpress.org/trunk@29434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-01 19:55:18 +00:00
72593add22
Media grid: Don't show a misleading message for an empty library.
...
This uses the existing string from the list table. We should revisit a better overall experience for the two situations (empty library vs. search with no results) in 4.1.
props voldemortensen.
fixes #29404 .
Built from https://develop.svn.wordpress.org/trunk@29655
git-svn-id: http://core.svn.wordpress.org/trunk@29429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-01 18:39:17 +00:00
149346ff6e
MCE View sandboxes:
...
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately
Props avryl, azaozz.
Fixes #29048 .
Built from https://develop.svn.wordpress.org/trunk@29615
git-svn-id: http://core.svn.wordpress.org/trunk@29389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:46:15 +00:00
d6213d64a5
After [29543], the iframe sandboxes for media need to load Open Sans. Playlists look aggressively bad without it. Adds font styles for the body.
...
See #29048 .
Built from https://develop.svn.wordpress.org/trunk@29564
git-svn-id: http://core.svn.wordpress.org/trunk@29338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 03:36:16 +00:00
53c047263b
TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048 .
...
Built from https://develop.svn.wordpress.org/trunk@29559
git-svn-id: http://core.svn.wordpress.org/trunk@29334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-20 21:34:15 +00:00
afdb25bd56
TinyMCE wpView sandbox iframes:
...
- Make them transparent.
- Don't load tons of unrelated styles that can break them. This could result in minimal styling mismatch to the front-end, but keeps the views working well and looking good.
Props avryl, fixes #29048 .
Built from https://develop.svn.wordpress.org/trunk@29543
git-svn-id: http://core.svn.wordpress.org/trunk@29319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 21:53:15 +00:00
6b3a4e6ddd
Media Grid: Use an existing string for posts without a title.
...
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@29493
git-svn-id: http://core.svn.wordpress.org/trunk@29271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 21:41:16 +00:00
b0c782bf08
Media Grid, support `MEDIA_TRASH`: add AYS to bulk actions.
...
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29492
git-svn-id: http://core.svn.wordpress.org/trunk@29270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 19:08:14 +00:00
571111022e
Media Grid, support `MEDIA_TRASH`:
...
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.
Props koop for the knowledge sharing and thought partnership.
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29490
git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:31:19 +00:00
82a69241f1
Remove now-unused strings. see #28842 .
...
Built from https://develop.svn.wordpress.org/trunk@29486
git-svn-id: http://core.svn.wordpress.org/trunk@29264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 04:23:16 +00:00
9c08ad236a
Media Grid: add Bulk Selection mode for deleting attachments.
...
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29484
git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 22:45:15 +00:00
1c93f05e2a
Upgrade MediaElement to 2.15.0:
...
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273
All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29457
git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 20:44:17 +00:00
28c22db07d
Video:
...
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29456
git-svn-id: http://core.svn.wordpress.org/trunk@29234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 19:39:15 +00:00
647b6d907b
Clean up some missing `@access` tags and other tweaks for 4.0.0-functionality docs.
...
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29455
git-svn-id: http://core.svn.wordpress.org/trunk@29233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 19:32:16 +00:00
8c96874742
Media Grid:
...
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29438
git-svn-id: http://core.svn.wordpress.org/trunk@29216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:01:15 +00:00
ccd0499d96
Media Grid: use a `media.view.Label` instance in the toolbar for the screen reader text for Search.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29437
git-svn-id: http://core.svn.wordpress.org/trunk@29215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:54:15 +00:00
8593f7b5e9
Media Grid: add screen reader text in a subview on the toolbar, a `media.view.Label` instance before `media.view.DateFilter`.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29435
git-svn-id: http://core.svn.wordpress.org/trunk@29213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:25:16 +00:00
3f17e7040e
Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text.
...
Make an initial instance of it for the label for Bulk Actions in Media Grid.
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29434
git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
c5dff42d51
Revert [29428] to avoid errors with Add Media for now.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29432
git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
b053fe2e04
Video: use `auto` instead of actual height for the responsive wrapper in generated markup.
...
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29430
git-svn-id: http://core.svn.wordpress.org/trunk@29208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 06:20:15 +00:00
b938bfb7d5
MediaElement upgrade: cleanup for generated markup for videos.
...
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29429
git-svn-id: http://core.svn.wordpress.org/trunk@29207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:53:15 +00:00
afb0b3e4ef
Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
...
Props afercia.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29428
git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
8ed123c97f
In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`.
...
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead.
Props ocean90, wonderboymusic.
Fixes #29065 .
Built from https://develop.svn.wordpress.org/trunk@29426
git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
42809dad43
Use proper non-capturing regex syntax for YouTube in `wp_video_shortcode()`.
...
Props Fab1en.
See [27063].
Fixes #29119 .
Built from https://develop.svn.wordpress.org/trunk@29401
git-svn-id: http://core.svn.wordpress.org/trunk@29179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:01:17 +00:00
3f3395a086
Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
...
Synchronize the 'edit_post' capability check between the list table and the media grid.
fixes #27446 .
Built from https://develop.svn.wordpress.org/trunk@29320
git-svn-id: http://core.svn.wordpress.org/trunk@29101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 01:41:16 +00:00
Scott Taylor
Drew Jaynes
Sergey Biryukov
Andrew Nacin
Dominik Schilling
Gary Pendergast
Andrew Ozz
Helen Hou-Sandí