Sergey Biryukov
94b3dcc605
Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex.
...
Props samanehmirrajabi.
Fixes #46823 .
Built from https://develop.svn.wordpress.org/trunk@45126
git-svn-id: http://core.svn.wordpress.org/trunk@44935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:23:51 +00:00
John Blackbourn
9ab303dbdf
Bootstrap/Load: Ignore `wp-content/fatal-error-handler.php` and `wp-content/php-error.php` from version control.
...
See #44458
Built from https://develop.svn.wordpress.org/trunk@45125
git-svn-id: http://core.svn.wordpress.org/trunk@44934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 18:43:51 +00:00
Sergey Biryukov
3215ab96ce
Twenty Twelve: Correct `linear-gradient` direction argument syntax.
...
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.
Props: ianbelanger, joyously, man4toman.
Fixes #46786 .
Built from https://develop.svn.wordpress.org/trunk@45124
git-svn-id: http://core.svn.wordpress.org/trunk@44933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:17:50 +00:00
Sergey Biryukov
95d13df56d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/nav-menus.css`.
...
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45123
git-svn-id: http://core.svn.wordpress.org/trunk@44932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:10:51 +00:00
Sergey Biryukov
5810543816
PHPCS: Fix WPCS violation in [45119].
...
See #46809 .
Built from https://develop.svn.wordpress.org/trunk@45122
git-svn-id: http://core.svn.wordpress.org/trunk@44931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:02:52 +00:00
Sergey Biryukov
80e638ad0e
Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.
...
Props Clorith, earnjam.
Fixes #46789 .
Built from https://develop.svn.wordpress.org/trunk@45121
git-svn-id: http://core.svn.wordpress.org/trunk@44930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:00:51 +00:00
Sergey Biryukov
d36c01909a
Site Health: Use a consistent heading and description when referring to Info and Status pages.
...
Props chetan200891, afercia.
Fixes #46728 .
Built from https://develop.svn.wordpress.org/trunk@45120
git-svn-id: http://core.svn.wordpress.org/trunk@44929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:42:52 +00:00
Sergey Biryukov
4d3fb9b22b
Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044].
...
The backticks ensure that the data is formatted accordingly on pasting whenever possible.
Props Clorith.
Fixes #46809 .
Built from https://develop.svn.wordpress.org/trunk@45119
git-svn-id: http://core.svn.wordpress.org/trunk@44928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:36:51 +00:00
Sergey Biryukov
a431028795
Site Health: Display a correct error message for a failing request in `wp_version_check()` test.
...
Props Clorith, axaak.
Fixes #46814 .
Built from https://develop.svn.wordpress.org/trunk@45118
git-svn-id: http://core.svn.wordpress.org/trunk@44927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:28:50 +00:00
Felix Arntz
5754da106b
Administration: Improve user experience and clarify when in recovery mode.
...
This changeset introduces several changes around usability when recovery mode is active:
* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.
Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608 .
Built from https://develop.svn.wordpress.org/trunk@45117
git-svn-id: http://core.svn.wordpress.org/trunk@44926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 17:00:52 +00:00
Felix Arntz
52354f3f0b
Bootstrap/Load: Do not redefine constants because tests don't like it.
...
See #46045 .
Built from https://develop.svn.wordpress.org/trunk@45116
git-svn-id: http://core.svn.wordpress.org/trunk@44925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:53:50 +00:00
Felix Arntz
5d2c761568
Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
...
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.
Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812 .
Built from https://develop.svn.wordpress.org/trunk@45115
git-svn-id: http://core.svn.wordpress.org/trunk@44924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:33:52 +00:00
Felix Arntz
6d58109b09
Bootstrap/Load: Ensure `WP_Fatal_Error_Handler` does not conflict with existing mechanisms treating fatal errors.
...
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.
Furthermore this applies to breaking a plugin or theme when editing from the backend.
Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045 , #46751 .
Built from https://develop.svn.wordpress.org/trunk@45114
git-svn-id: http://core.svn.wordpress.org/trunk@44923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:20:55 +00:00
Pascal Birchler
ec05cd3168
Site Health: Remove unused `$wp_config_path` variable.
...
Discovered and fixed during WordCamp London 2019 contributor day.
Props m_uysl.
Fixes #46808 .
Built from https://develop.svn.wordpress.org/trunk@45113
git-svn-id: http://core.svn.wordpress.org/trunk@44922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 11:09:51 +00:00
tellyworth
23fe2800cc
Upgrade/Install: Add more context in signature verify failures.
...
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.
Props dd32.
See #39309 .
Built from https://develop.svn.wordpress.org/trunk@45112
git-svn-id: http://core.svn.wordpress.org/trunk@44921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 05:20:51 +00:00
Andrew Ozz
4601e178e5
Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
...
Fixes #46645 .
Built from https://develop.svn.wordpress.org/trunk@45111
git-svn-id: http://core.svn.wordpress.org/trunk@44920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 21:54:53 +00:00
desrosj
adbaba7d56
Site Health: Ensure the user locale is listed in debug information.
...
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.
Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/
Props: Clorith, desrosj.
Fixes #46694 .
Built from https://develop.svn.wordpress.org/trunk@45110
git-svn-id: http://core.svn.wordpress.org/trunk@44919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 21:24:52 +00:00
desrosj
fc2c675582
Twenty Eleven: Correct `linear-gradient` direction argument syntax.
...
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.
Props: ianbelanger, Malae, man4toman.
Fixes #46770 .
Built from https://develop.svn.wordpress.org/trunk@45109
git-svn-id: http://core.svn.wordpress.org/trunk@44918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 18:26:52 +00:00
Sergey Biryukov
4ee7d453fa
Site Health: Use `wp_get_upload_dir()` instead of `wp_upload_dir()`, remove duplicate call.
...
Props m_uysl.
Fixes #46729 .
Built from https://develop.svn.wordpress.org/trunk@45108
git-svn-id: http://core.svn.wordpress.org/trunk@44917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 11:20:51 +00:00
Sergey Biryukov
991eb4258d
Site Health: Use correct property for database-related messages.
...
Props mukesh27, birgire.
Fixes #46783 .
Built from https://develop.svn.wordpress.org/trunk@45107
git-svn-id: http://core.svn.wordpress.org/trunk@44916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 11:01:53 +00:00
Sergey Biryukov
ef948cbfd6
PHPCS: Fix WPCS violations in [45104].
...
See #46645 .
Built from https://develop.svn.wordpress.org/trunk@45106
git-svn-id: http://core.svn.wordpress.org/trunk@44915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 02:14:51 +00:00
Sergey Biryukov
5d0bd0ec47
Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes.
...
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735 .
Built from https://develop.svn.wordpress.org/trunk@45105
git-svn-id: http://core.svn.wordpress.org/trunk@44914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 02:01:51 +00:00
Andrew Ozz
2cdc22aded
Site health:
...
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.
Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645 .
Built from https://develop.svn.wordpress.org/trunk@45104
git-svn-id: http://core.svn.wordpress.org/trunk@44913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 23:33:53 +00:00
Sergey Biryukov
1909df67a7
Docs: Remove an empty line between `@param` and `@return` in the tests added in [45101], per documentation coding standards.
...
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45103
git-svn-id: http://core.svn.wordpress.org/trunk@44912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:22:50 +00:00
Sergey Biryukov
0c92764023
Site Health: Use an established pattern for numbered placeholders in translator comments in `WP_Debug_Data`.
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45102
git-svn-id: http://core.svn.wordpress.org/trunk@44911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:18:52 +00:00
Sergey Biryukov
cbbe38c09c
Widgets: Make sure changes to media widgets' instance schema via `widget_{$this->id_base}_instance_schema` filter are not overridden by subclasses.
...
Add unit tests missed in [45100].
Props Toro_Unit, birgire.
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45101
git-svn-id: http://core.svn.wordpress.org/trunk@44910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:15:51 +00:00
Sergey Biryukov
2931a2d95e
Widgets: Make sure changes to media widgets' instance schema via `widget_{$this->id_base}_instance_schema` filter are not overridden by subclasses.
...
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.
Props Toro_Unit, birgire.
Fixes #45029 .
Built from https://develop.svn.wordpress.org/trunk@45100
git-svn-id: http://core.svn.wordpress.org/trunk@44909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:13:52 +00:00
Sergey Biryukov
f7357d3957
Site Health: i18n audit, take 1.
...
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.
Props ocean90, SergeyBiryukov.
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45099
git-svn-id: http://core.svn.wordpress.org/trunk@44908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 21:32:53 +00:00
Sergey Biryukov
5291f46c8a
Docs: Fix typo in a comment in `unzip_file()`.
...
Props mukesh27.
Fixes #46766 .
Built from https://develop.svn.wordpress.org/trunk@45098
git-svn-id: http://core.svn.wordpress.org/trunk@44907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:34:53 +00:00
desrosj
6d1f493d1d
Administration: Remove unnecessary `transition-delay` values from Dashicons.
...
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.
See #43195 .
Fixes #46774 .
Built from https://develop.svn.wordpress.org/trunk@45097
git-svn-id: http://core.svn.wordpress.org/trunk@44906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:19:52 +00:00
Sergey Biryukov
45cd565be3
Twenty Fifteen: Fix typo in a comment for print styles.
...
Props mukesh27.
Fixes #46767 .
Built from https://develop.svn.wordpress.org/trunk@45096
git-svn-id: http://core.svn.wordpress.org/trunk@44905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:07:51 +00:00
Sergey Biryukov
474f57e0fa
Site Health: Add missing i18n for Security and Performance badge labels.
...
Props iworks.
Fixes #46755 . See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45095
git-svn-id: http://core.svn.wordpress.org/trunk@44904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 10:08:56 +00:00
Sergey Biryukov
ccbf084609
Docs: Fix more typos in `WP_Site_Health` DocBlocks.
...
See #46753 .
Built from https://develop.svn.wordpress.org/trunk@45094
git-svn-id: http://core.svn.wordpress.org/trunk@44903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:30:52 +00:00
Sergey Biryukov
12a2bf946a
Docs: Fix typos in `WP_Site_Health` DocBlocks.
...
Props mukesh27.
Fixes #46753 .
Built from https://develop.svn.wordpress.org/trunk@45093
git-svn-id: http://core.svn.wordpress.org/trunk@44902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:23:50 +00:00
Sergey Biryukov
9c8e9354b1
Docs: Add missing `@since` tag for `WP_Site_Health::get_test_php_extensions()`.
...
Props mukesh27.
Fixes #46752 .
Built from https://develop.svn.wordpress.org/trunk@45092
git-svn-id: http://core.svn.wordpress.org/trunk@44901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:17:54 +00:00
Andrea Fercia
83546a04f5
Administration: Site Health: reserve some space for the admin notices.
...
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651 .
Built from https://develop.svn.wordpress.org/trunk@45091
git-svn-id: http://core.svn.wordpress.org/trunk@44900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 18:01:52 +00:00
Sergey Biryukov
57a8f51e06
PHPCS: Fix WPCS violation in [45088].
...
See #38168 .
Built from https://develop.svn.wordpress.org/trunk@45090
git-svn-id: http://core.svn.wordpress.org/trunk@44899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:49:50 +00:00
Sergey Biryukov
130495e1c4
Docs: Correct `@param` description for `remove_theme_support()`.
...
Add `@return` description for `current_theme_supports()`.
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45089
git-svn-id: http://core.svn.wordpress.org/trunk@44898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:21:50 +00:00
Sergey Biryukov
3f3593aa6c
Customize: Only add `custom-background` to `body_class()` if the current theme supports custom background.
...
Props wido, swissspidy, ocean90, Mte90.
Fixes #38168 .
Built from https://develop.svn.wordpress.org/trunk@45088
git-svn-id: http://core.svn.wordpress.org/trunk@44897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:18:52 +00:00
Andrea Fercia
d8b8994336
Accessibility: Improve the Site Health accordions.
...
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation
Props mukesh27 for the initial patch.
Fixes #46714 .
Built from https://develop.svn.wordpress.org/trunk@45087
git-svn-id: http://core.svn.wordpress.org/trunk@44896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 15:08:58 +00:00
Sergey Biryukov
95541a86ff
Docs: Correct parameter types for `the_author()`, `get_the_author_meta()`, and `the_author_meta()`.
...
Props subrataemfluence.
Fixes #45596 .
Built from https://develop.svn.wordpress.org/trunk@45086
git-svn-id: http://core.svn.wordpress.org/trunk@44895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 14:23:53 +00:00
Sergey Biryukov
0aedea9470
Docs: Improve documentation for `get_plugin_page_hook()` and `get_plugin_page_hookname()`.
...
Props subrataemfluence, desrosj.
Fixes #44224 .
Built from https://develop.svn.wordpress.org/trunk@45085
git-svn-id: http://core.svn.wordpress.org/trunk@44894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 14:09:52 +00:00
Sergey Biryukov
06d8f376ea
PHPCS: Fix WPCS violation in [45082].
...
See #42223 .
Built from https://develop.svn.wordpress.org/trunk@45084
git-svn-id: http://core.svn.wordpress.org/trunk@44893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 13:30:52 +00:00
Sergey Biryukov
733ec3da48
Docs: Improve documentation for `postbox_classes()`.
...
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.
Props sharifkiberu, DrewAPicture.
Fixes #45179 .
Built from https://develop.svn.wordpress.org/trunk@45083
git-svn-id: http://core.svn.wordpress.org/trunk@44892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 12:47:51 +00:00
Sergey Biryukov
2f5b5baa07
I18N: Merge similar strings about allowed space allocation in Multisite.
...
Props ramiy, Jonathandejong, pento.
Fixes #42223 .
Built from https://develop.svn.wordpress.org/trunk@45082
git-svn-id: http://core.svn.wordpress.org/trunk@44891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 12:24:51 +00:00
Sergey Biryukov
76e6cc67c2
Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
...
Props man4toman, andraganescu.
Fixes #46450 .
Built from https://develop.svn.wordpress.org/trunk@45081
git-svn-id: http://core.svn.wordpress.org/trunk@44890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 11:56:52 +00:00
Sergey Biryukov
de95fac19c
Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
...
Props man4toman.
See #46450 .
Built from https://develop.svn.wordpress.org/trunk@45080
git-svn-id: http://core.svn.wordpress.org/trunk@44889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 11:55:52 +00:00
Sergey Biryukov
5cca79f806
Site Health: If `WP_DEBUG_LOG` contains a file path, display it on Site Info tab.
...
Props xkon, knutsp, ocean90.
Fixes #46692 .
Built from https://develop.svn.wordpress.org/trunk@45079
git-svn-id: http://core.svn.wordpress.org/trunk@44888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 01:26:51 +00:00
Sergey Biryukov
c241c16846
Site Health: Simplify the checks for constants that are always defined by default.
...
Props xkon.
Fixes #46738 .
Built from https://develop.svn.wordpress.org/trunk@45078
git-svn-id: http://core.svn.wordpress.org/trunk@44887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 00:10:53 +00:00
Sergey Biryukov
63d0abd5ff
Administration: Fix typo in fatal error email notification.
...
Props kraftbj.
Fixes #46722 .
Built from https://develop.svn.wordpress.org/trunk@45077
git-svn-id: http://core.svn.wordpress.org/trunk@44886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 18:54:51 +00:00