Commit Graph

17578 Commits

Author SHA1 Message Date
Andrea Fercia 3d1f02b537 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
Merges [45520] to the 5.2 branch.
Fixes #45094 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45521


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:24:55 +00:00
Sergey Biryukov 3b157938be I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
Props pedromendonca, garrett-eclipse.
Merges [45515] to the 5.2 branch.
Fixes #47475.
Built from https://develop.svn.wordpress.org/branches/5.2@45516


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:16:53 +00:00
Andrea Fercia 8da585f83f Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield. 

Merges [45463] to the 5.2 branch.
Fixes #46960 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45514


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:03:52 +00:00
Andrea Fercia b2fbbe2100 Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.

Merges [45501] and [45502] to the 5.2 branch.
Fixes #46749 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45513


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:59:52 +00:00
Sergey Biryukov 7eab77d326 I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
Props ramiy.
Merges [45488] to the 5.2 branch.
Fixes #47227.
Built from https://develop.svn.wordpress.org/branches/5.2@45512


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:48:52 +00:00
Sergey Biryukov e28153577f Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Merges [45495] to the 5.2 branch.
Fixes #46289.
Built from https://develop.svn.wordpress.org/branches/5.2@45511


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:46:52 +00:00
desrosj f8677253e4 I18N: Combine similar strings with minor differences.
Merges [45298] to the 5.2 branch.

Props dimadin.
Fixes #47158.
Built from https://develop.svn.wordpress.org/branches/5.2@45510


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:34:45 +00:00
Andrea Fercia c3bc45b95d Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Merges [45503] to the 5.2 branch.
Fixes #45094 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45509


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:33:52 +00:00
Peter Wilson 426d43abb7 Site health: Introduce `view_site_health_checks` capability.
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Merges [45507] to the 5.2 branch.
Fixes #46957 for 5.2.2.


Built from https://develop.svn.wordpress.org/branches/5.2@45508


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:50:53 +00:00
Sergey Biryukov da22a1cc85 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if `wp_get_update_php_url()` and `wp_get_update_php_annotation()` exist.
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Merges [45365] to the 5.2 branch.
Fixes #47323.
Built from https://develop.svn.wordpress.org/branches/5.2@45366


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:32:02 +00:00
desrosj b3425b83cd Help/About: Replace minor release strings with pre-existing ones.
Also, update the number of bugs fixed in 5.2.1 to include those being fixed after RC1.

Reviewed by desrosj, SergeyBiryukov.

Props ocean90, SergeyBiryukov, mukesh27.
Fixes #47312.
Built from https://develop.svn.wordpress.org/branches/5.2@45364


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:22:02 +00:00
desrosj d7266b423d Help/About: Update the about page for 5.2.1.
32 bugs were squashed in 5.2.1.

Props earnjam, ianbelanger, chanthaboune.
Fixes #47294.
Built from https://develop.svn.wordpress.org/branches/5.2@45359


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:51:52 +00:00
Sergey Biryukov 1c574a4d6b Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Merges [45357] to the 5.2 branch.
Fixes #46937.
Built from https://develop.svn.wordpress.org/branches/5.2@45358


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:16:54 +00:00
desrosj 0e0e8daf1d Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The `sodium_compat` library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Merges [45345] to the 5.2 branch.

Props dd32, paragoninitiativeenterprises, tellyworth.
Fixes #47186.
Built from https://develop.svn.wordpress.org/branches/5.2@45356


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 17:49:54 +00:00
Sergey Biryukov f47af3f8d6 Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Merges [45346] to the 5.2 branch.
Fixes #47161.
Built from https://develop.svn.wordpress.org/branches/5.2@45347


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:56:52 +00:00
Sergey Biryukov 3715885b2b Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Merges [45338] to the 5.2 branch.
Fixes #46408.
Built from https://develop.svn.wordpress.org/branches/5.2@45339


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:09:52 +00:00
Sergey Biryukov 12a29911fb Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Merges [45336] to the 5.2 branch.
Fixes #47264.
Built from https://develop.svn.wordpress.org/branches/5.2@45337


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:01:53 +00:00
Sergey Biryukov 84256959b7 I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Merges [45334] to the 5.2 branch.
Fixes #47159.
Built from https://develop.svn.wordpress.org/branches/5.2@45335


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:56:54 +00:00
desrosj 9bb8bd243e Accessibility: Improve the "skip links" position for medium and small screens.
Merges [45301] to the 5.2 branch.

Props afercia.
Fixes #47065.
Built from https://develop.svn.wordpress.org/branches/5.2@45333


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:42:54 +00:00
Sergey Biryukov 608c219a7d Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Merges [45331] to the 5.2 branch.
Fixes #47161.
Built from https://develop.svn.wordpress.org/branches/5.2@45332


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:09:54 +00:00
Sergey Biryukov 056dae6ac5 Site Health: In HTTP requests test, when checking whether the `WP_HTTP_BLOCK_EXTERNAL` constant is defined, check its value as well.
Props chesio.
Merges [45328] to the 5.2 branch.
Fixes #47297.
Built from https://develop.svn.wordpress.org/branches/5.2@45329


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:24:53 +00:00
desrosj a32c70deb9 Privacy: Prevent email field for personal data requests from overflowing.
Merges [45326] to the 5.2 branch.

Props anischarolia, ianbelanger, afercia.
Fixes #46961.
Built from https://develop.svn.wordpress.org/branches/5.2@45327


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:47:55 +00:00
desrosj 36bf915264 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Merges [45324] to the 5.2 branch.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.
Built from https://develop.svn.wordpress.org/branches/5.2@45325


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:08:53 +00:00
desrosj 3386574b51 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Merges [45322] to the 5.2 branch.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.
Built from https://develop.svn.wordpress.org/branches/5.2@45323


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:33:01 +00:00
desrosj 64f5990104 Accessibility: Add aria-current to the links in the <nav> elements introduced in [44905].
Also fixes a few translators comments and coding standards.

Merges [45300] to the 5.2 branch.

Props audrasjb, afercia.
Fixes #47106.
Built from https://develop.svn.wordpress.org/branches/5.2@45318


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 16:35:04 +00:00
desrosj 5bb4b73062 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.
Built from https://develop.svn.wordpress.org/branches/5.2@45314


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:52:54 +00:00
desrosj 6d0e5ee9d0 Site Health: Link to the correct plugin update screen in multisite installs.
Merges [45308] to the 5.2 branch.

Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.
Built from https://develop.svn.wordpress.org/branches/5.2@45313


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:49:52 +00:00
desrosj d8620b86c7 Administration: Prevent cards on the Tools page from overflowing on small screens.
Merges [45296] to the 5.2 branch.

Props anischarolia, mukesh27.
Fixes #46972.
Built from https://develop.svn.wordpress.org/branches/5.2@45303


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-10 14:45:56 +00:00
desrosj a97d03e4d0 Help/About: Move 5.2 tagline to Freedoms and Credits.
Reviewed by ocean90, SergeyBiryukov.
Props ocean90.
Fixes #46901.
Built from https://develop.svn.wordpress.org/branches/5.2@45293


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 20:01:53 +00:00
desrosj 32fce28909 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Reviewed by afercia, desrosj.
Merges [45287] to the 5.2 branch.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
Fixes #46901.
Built from https://develop.svn.wordpress.org/branches/5.2@45288


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:22:56 +00:00
desrosj 3360974ad2 Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45278


git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
desrosj d53659ed71 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
desrosj 6ac1d4ec1a Site Health: Disable recommendations that could be problematic on multisite installs.
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.
Built from https://develop.svn.wordpress.org/trunk@45275


git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-01 18:08:53 +00:00
Aaron Jorbin e4a0fd4c01 Admin: Add some additional clarity to some about page links
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.

This was signed off on by chanthaboune and jorbin.

Props afercia.
See: #46901.


Built from https://develop.svn.wordpress.org/trunk@45274


git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-30 17:31:55 +00:00
Gary Pendergast d86524f09d Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.


Built from https://develop.svn.wordpress.org/trunk@45271


git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00
Sergey Biryukov 8b333f8c20 Docs: Use 3-digit, x.x.x style semantic versioning for `@since 5.2.0` entries in `wp-admin/includes/file.php`.
See #46543.
Built from https://develop.svn.wordpress.org/trunk@45266


git-svn-id: http://core.svn.wordpress.org/trunk@45075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 23:36:51 +00:00
tellyworth ed802428e3 Upgrade/install: fix verification bugs and scale back signature checks.
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.

At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.

Props dd32.
See #39309, #46615


Built from https://develop.svn.wordpress.org/trunk@45262


git-svn-id: http://core.svn.wordpress.org/trunk@45071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 07:44:51 +00:00
Andrew Ozz 0da8c2265f Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900.
Built from https://develop.svn.wordpress.org/trunk@45260


git-svn-id: http://core.svn.wordpress.org/trunk@45069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:37:53 +00:00
Andrew Ozz 2548263bac Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878.
Built from https://develop.svn.wordpress.org/trunk@45259


git-svn-id: http://core.svn.wordpress.org/trunk@45068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:05:52 +00:00
Sergey Biryukov bd9421104a Networks and Sites: Use correct escaping function for classes added via ` ms_user_list_site_class` filter.
Props david.binda.
Fixes #46990. See #41146.
Built from https://develop.svn.wordpress.org/trunk@45252


git-svn-id: http://core.svn.wordpress.org/trunk@45061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:51:51 +00:00
Dominik Schilling 2d58638ba0 Site Health: Fix debug data with nested fields for copying.
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.

Props Clorith, ocean90.
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45246


git-svn-id: http://core.svn.wordpress.org/trunk@45055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:26:51 +00:00
Dominik Schilling 3e6183c69c Site Health: Provide context for tab headings to be able to distinguish them from existing strings.
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45245


git-svn-id: http://core.svn.wordpress.org/trunk@45054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:06:51 +00:00
Gary Pendergast 6fcd281707 CSS: Remove the units from `line-height` properties in `common.css`.
Props ianbelanger, talldanwp.
Fixes #46493.


Built from https://develop.svn.wordpress.org/trunk@45243


git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 06:02:53 +00:00
Andrew Ozz 3a0563e853 Site Health info tab: fix replacing the size strings in the copied info.
Props xkon.
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45241


git-svn-id: http://core.svn.wordpress.org/trunk@45050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 04:51:52 +00:00
Andrew Ozz 9659676fca Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite.
Props xkon, desrosj, azaozz.
Built from https://develop.svn.wordpress.org/trunk@45239


git-svn-id: http://core.svn.wordpress.org/trunk@45048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 00:34:51 +00:00
Andrew Ozz 2a5c2a2cce Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators).
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45237


git-svn-id: http://core.svn.wordpress.org/trunk@45046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 21:26:52 +00:00
Sergey Biryukov 23de32062e Site Health: Allow any callable added via `site_status_tests` filter to return test results for direct tests.
Async tests still need to be a string for the AJAX action.

Props kraftbj.
Fixes #46836.
Built from https://develop.svn.wordpress.org/trunk@45234


git-svn-id: http://core.svn.wordpress.org/trunk@45043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:35:50 +00:00
Sergey Biryukov 1be34a234f Docs: Remove `@global` tag for `$wpdb` from `wp-admin/install.php` and `wp-admin/upgrade.php`.
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.

The code in question uses the variable in global namespace, but does not explicitly declare it.

Props jayupadhyay01, dswebsme.
Fixes #46602.
Built from https://develop.svn.wordpress.org/trunk@45233


git-svn-id: http://core.svn.wordpress.org/trunk@45042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:07:53 +00:00
Sergey Biryukov d2ccaacedf Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook.
Props man4toman, samanehmirrajabi.
Fixes #45857.
Built from https://develop.svn.wordpress.org/trunk@45232


git-svn-id: http://core.svn.wordpress.org/trunk@45041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 13:26:51 +00:00
Sergey Biryukov 604769cca5 Site Health: Group `WP_DEBUG`-related constants together.
Props tmatsuur.
Fixes #46955.
Built from https://develop.svn.wordpress.org/trunk@45230


git-svn-id: http://core.svn.wordpress.org/trunk@45039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 12:00:54 +00:00