Commit Graph

14452 Commits

Author SHA1 Message Date
Helen Hou-Sandí c87224eaf6 List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Helen Hou-Sandí 06ebd0a2aa List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@32723


git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:31:25 +00:00
Helen Hou-Sandí 51b5ed9fa4 List tables: Better primary column back-compat.
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32722


git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:59:30 +00:00
Helen Hou-Sandí 3562ac028d List tables: Consolidate `<td>` output for posts.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32721


git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:01:28 +00:00
Konstantin Obenland ce16fd8dca More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.


Built from https://develop.svn.wordpress.org/trunk@32720


git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 09:09:25 +00:00
Jeremy Felt 0e76a2c570 Additional improvement to sites list table display
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.

Built from https://develop.svn.wordpress.org/trunk@32719


git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 07:28:26 +00:00
Jeremy Felt 93ff65e677 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
Helen Hou-Sandí 005d937ce2 List tables:
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32717


git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 01:46:27 +00:00
Konstantin Obenland bafb008be1 When inline editing a post, reset password field to be editable by default.
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.


Built from https://develop.svn.wordpress.org/trunk@32716


git-svn-id: http://core.svn.wordpress.org/trunk@32686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:02:27 +00:00
Aaron Jorbin 82e8acd70b Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.

In the words of Colonel Jessep: You can't handle the truth!

Introduced in [32714]

Fixes #32011


Built from https://develop.svn.wordpress.org/trunk@32715


git-svn-id: http://core.svn.wordpress.org/trunk@32685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:00:28 +00:00
Aaron Jorbin d1586725d1 Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.

Fixes #32011.
Props Oxymoron.


Built from https://develop.svn.wordpress.org/trunk@32714


git-svn-id: http://core.svn.wordpress.org/trunk@32684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 17:59:24 +00:00
Konstantin Obenland 6d56231da3 Sort screen options for meta boxes according to the meta box's priority.
Props swissspidy.
Fixes #32582.


Built from https://develop.svn.wordpress.org/trunk@32707


git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 12:35:26 +00:00
Ella Iseulde Van Dorpe 8acda26129 Autoprefixer after autoprefixer-core 5.2 update
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.

See #31700.

Built from https://develop.svn.wordpress.org/trunk@32704


git-svn-id: http://core.svn.wordpress.org/trunk@32674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 20:08:24 +00:00
Helen Hou-Sandí 93b5a9a7fa Nav menus: Hidden inputs do not need an ID, especially one that's already in use.
props sagarjadhav.
fixes #31816.

Built from https://develop.svn.wordpress.org/trunk@32695


git-svn-id: http://core.svn.wordpress.org/trunk@32665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 15:36:27 +00:00
Konstantin Obenland c20edc4df5 Remove title attributes in user list tables.
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.


Built from https://develop.svn.wordpress.org/trunk@32694


git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 08:40:26 +00:00
Konstantin Obenland 5daf12dba4 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00
Helen Hou-Sandí 0e77b693ac Nav menus: hide the title attribute field by default for new users and installs.
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

Built from https://develop.svn.wordpress.org/trunk@32691


git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:38:25 +00:00
Helen Hou-Sandí 9d0ab29bc4 Nav menus: Provide visual feedback when attempting to add an empty custom link.
props pragunbhutani for the initial patch.
fixes #18517.

Built from https://develop.svn.wordpress.org/trunk@32690


git-svn-id: http://core.svn.wordpress.org/trunk@32660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:31:26 +00:00
John Blackbourn acec5066f6 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
Props jkudish, MikeHansenMe.
Fixes #20791

Built from https://develop.svn.wordpress.org/trunk@32689


git-svn-id: http://core.svn.wordpress.org/trunk@32659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 22:59:25 +00:00
Helen Hou-Sandí 6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
Helen Hou-Sandí 40fca44c89 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
Helen Hou-Sandí 2d3a637598 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32686


git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:08:28 +00:00
Konstantin Obenland 5e787a900a Use WordPress' default focus styles for links on login screens.
Props afercia.
Fixes #31712.


Built from https://develop.svn.wordpress.org/trunk@32682


git-svn-id: http://core.svn.wordpress.org/trunk@32652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-02 05:51:27 +00:00
Dominik Schilling 974ca19e36 Customizer: Improve JS templates for Panels and Sections added in [32658].
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.

Includes QUnit tests.

Props celloexpressions, westonruter, ocean90.
Fixes #30737.
Built from https://develop.svn.wordpress.org/trunk@32681


git-svn-id: http://core.svn.wordpress.org/trunk@32651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 22:47:25 +00:00
Andrew Ozz 02f5020d52 Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
Fixes #31655.
Built from https://develop.svn.wordpress.org/trunk@32680


git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 19:02:25 +00:00
Andrew Ozz b3d04247b7 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
Sergey Biryukov ecf0bcc9fc Revert a part of [32673] that caused a fatal error with `SCRIPT_DEBUG` disabled.
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32676


git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 04:14:25 +00:00
John Blackbourn 02192cb53f Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Scott Taylor 42d51a4f89 Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 03:18:25 +00:00
Drew Jaynes 9cb1017b3c Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
See #32529.

Built from https://develop.svn.wordpress.org/trunk@32671


git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 02:00:26 +00:00
Drew Jaynes 0df0e0bf36 Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_Users_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32670


git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:45:27 +00:00
Drew Jaynes 65f31bc52e Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Terms_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32669


git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:44:26 +00:00
Drew Jaynes a69f867738 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Posts_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32668


git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:42:25 +00:00
Drew Jaynes 5e2983a77e Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Plugins_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32667


git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:40:29 +00:00
Drew Jaynes d7428fc35d Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Users_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32666


git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:38:26 +00:00
Drew Jaynes 5e84c7004d Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_MS_Themes_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32665


git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:36:27 +00:00
Drew Jaynes 88569734d8 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Sites_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32664


git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:34:25 +00:00
Drew Jaynes 42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Media_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:32:26 +00:00
Drew Jaynes 8bcf53cc68 Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for `WP_List_Table`.
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32662


git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:29:26 +00:00
Drew Jaynes 2a0048b1fb Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Links_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32661


git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:23:26 +00:00
Drew Jaynes 5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:18:26 +00:00
Weston Ruter 98b03d376e Add JS templates for Customizer Panels and Sections.
This extends the approach taken for Customizer Controls in #29572.

Props celloexpressions, westonruter, ocean90.
See #30737.

Built from https://develop.svn.wordpress.org/trunk@32658


git-svn-id: http://core.svn.wordpress.org/trunk@32628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 00:03:30 +00:00
Scott Taylor 6a08b00632 Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor b3e0cfd25d Add (more) missing doc blocks to `wp-admin/includes/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor a51dfa3971 In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
Scott Taylor 9a29d8ac7b Add missing` annotations to `ajax-actions.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32652


git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 16:01:27 +00:00
Helen Hou-Sandí f5646cd9e5 Define a primary column for `WP_Post_Comments_List_Table`.
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:52:25 +00:00
Scott Taylor 19a3aacc94 Add `@static*` annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
Dominik Schilling fccc19b510 Customizer: Replace accordion behavior of sections with a slide-in navigation.
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.

props valendesigns, celloexpressions.
see #31336.
Built from https://develop.svn.wordpress.org/trunk@32649


git-svn-id: http://core.svn.wordpress.org/trunk@32619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:57:26 +00:00
Helen Hou-Sandí fbb83441cb After [32644], sanity for a pile of selectors.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32645


git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 03:00:26 +00:00
Helen Hou-Sandí 4c0c7fd7ba List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:41:25 +00:00
Scott Taylor 282e28ad81 Add `@global` annotations to (the rest of the?) `wp-admin/*` files.
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:06:31 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Helen Hou-Sandí abfece527b About: Give bottom navigation links the full width.
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.

Built from https://develop.svn.wordpress.org/trunk@32636


git-svn-id: http://core.svn.wordpress.org/trunk@32606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:39:24 +00:00
Jeremy Felt a5c688e817 Use site objects rather than get_blog_status() in MS list tables.
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 23:14:29 +00:00
Mark Jaquith 0a70901c50 Insert temporary password field hook for feature development in a plugin.
Built from https://develop.svn.wordpress.org/trunk@32625


git-svn-id: http://core.svn.wordpress.org/trunk@32595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 19:59:25 +00:00
Scott Taylor 19b8ef0c92 `get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
Drew Jaynes 4c37f68b79 Fix inline documentation syntax in `wp_xmlrpc_server`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
Scott Taylor af7a017f46 When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32545


git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
Helen Hou-Sandí 248a49c930 Updates: Use the warning color for the backup notice, as it's not a success message.
props paulwilde.
fixes #32241.

Built from https://develop.svn.wordpress.org/trunk@32522


git-svn-id: http://core.svn.wordpress.org/trunk@32492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:10:25 +00:00
Aaron Jorbin 2dff825af7 In List Tables, ensure sorting indicator is visible on focus
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189


Built from https://develop.svn.wordpress.org/trunk@32521


git-svn-id: http://core.svn.wordpress.org/trunk@32491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:05:26 +00:00
Scott Taylor a69b8b3b91 In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32517


git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
Scott Taylor 5a3dc2a371 In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32516


git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:46:25 +00:00
Jeremy Felt 2a2e976501 Move network update submenu items to the Network Dashboard menu item
Provides parity with the placement of the "Updates" submenu item in single site.

props Ipstenu.
fixes #32431.

Built from https://develop.svn.wordpress.org/trunk@32514


git-svn-id: http://core.svn.wordpress.org/trunk@32484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 17:00:29 +00:00
Helen Hou-Sandí 348ec03052 Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
props afercia.
fixes #31962.

Built from https://develop.svn.wordpress.org/trunk@32509


git-svn-id: http://core.svn.wordpress.org/trunk@32479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-18 18:37:29 +00:00
Helen Hou-Sandí 7381d50904 Autoprefixer for [32506]. see #31874.
Built from https://develop.svn.wordpress.org/trunk@32508


git-svn-id: http://core.svn.wordpress.org/trunk@32478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 20:44:25 +00:00
Helen Hou-Sandí 1e8a787aa1 Media: Visually align upload errors with other admin notices.
props sagarjadhav.
fixes #31874.

Built from https://develop.svn.wordpress.org/trunk@32506


git-svn-id: http://core.svn.wordpress.org/trunk@32476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 16:19:26 +00:00
Andrew Ozz 8cbfdfa51b Fix dragging to the bottom of the screen on the Dashboard.
Props eltobiano. See #32094.
Built from https://develop.svn.wordpress.org/trunk@32505


git-svn-id: http://core.svn.wordpress.org/trunk@32475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 23:50:28 +00:00
Dion Hulse 2ba7f3da75 Allow plugins to activate other plugins within their Activation hook. Fixes #32368
Built from https://develop.svn.wordpress.org/trunk@32504


git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 06:58:27 +00:00
Andrew Ozz fe427017a5 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.
Built from https://develop.svn.wordpress.org/trunk@32495


git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Dominik Schilling a42b5dc78e Improve focus styles for the Switch View links in Posts listings and Media Library.
props afercia.
fixes #32294.
Built from https://develop.svn.wordpress.org/trunk@32485


git-svn-id: http://core.svn.wordpress.org/trunk@32455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 19:34:27 +00:00
Andrew Ozz 999ae33a2e Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32480


git-svn-id: http://core.svn.wordpress.org/trunk@32450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 00:32:31 +00:00
Dominik Schilling 42cd948544 Improve focus styles for:
* Quick Draft links
* Media Library list mode thumbnails 

props afercia.
fixes #32284, #32291.
Built from https://develop.svn.wordpress.org/trunk@32476


git-svn-id: http://core.svn.wordpress.org/trunk@32446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 21:05:25 +00:00
Dominik Schilling bbcdcc084d Improve focus styles for:
* Welcome Panel dismiss link
* Welcome Panel assembled links
* At a Glance links
* Recently Published/Publishing Soon and latest Comments links in the Dashboard Activity box 

props afercia.
fixes #32287, #32288, #32289, #32292.
Built from https://develop.svn.wordpress.org/trunk@32475


git-svn-id: http://core.svn.wordpress.org/trunk@32445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 20:35:27 +00:00
Dominik Schilling e44d2f7289 Merge a help tab string for pages.
fixes #32328.
Built from https://develop.svn.wordpress.org/trunk@32474


git-svn-id: http://core.svn.wordpress.org/trunk@32444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 20:07:26 +00:00
Dominik Schilling f9e1c18698 List Table: Add placeholder to a plural string.
props SergeyBiryukov.
fixes #32034.
Built from https://develop.svn.wordpress.org/trunk@32473


git-svn-id: http://core.svn.wordpress.org/trunk@32443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:22:24 +00:00
Dominik Schilling 5268a77a80 Sites List Table: Replace context with a translators comment for the site name and tagline.
props ramiy.
fixes #31849.
Built from https://develop.svn.wordpress.org/trunk@32472


git-svn-id: http://core.svn.wordpress.org/trunk@32442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:18:27 +00:00
Dominik Schilling c37bdc3c9e Merge similar error strings.
props pavelevap.
fixes #32327.
Built from https://develop.svn.wordpress.org/trunk@32471


git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 18:27:26 +00:00
Gary Pendergast 02621f2a14 Upgrades: If a table has already been converted to `utf8mb4`, there's no need to try and convert it again.
Props gabrielperezs for the initial patch.

See #32310.


Built from https://develop.svn.wordpress.org/trunk@32456


git-svn-id: http://core.svn.wordpress.org/trunk@32426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 12:22:25 +00:00
Gary Pendergast 837fd1ca10 When saving Writing Options, check that the UI is enabled for `use_smilies` and `use_balanceTags` before trying to update them.
Fixes #5161.
Fixes #32298.


Built from https://develop.svn.wordpress.org/trunk@32455


git-svn-id: http://core.svn.wordpress.org/trunk@32425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 11:59:26 +00:00
Gary Pendergast 412e070d69 On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.
Fixes #5161.
Fixes #32298.


Built from https://develop.svn.wordpress.org/trunk@32454


git-svn-id: http://core.svn.wordpress.org/trunk@32424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 06:52:27 +00:00
Michael Adams a3807c1d34 Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
Props jorbin, et alii.

See #32165.

Built from https://develop.svn.wordpress.org/trunk@32440


git-svn-id: http://core.svn.wordpress.org/trunk@32410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-07 01:11:29 +00:00
Michael Adams 26c3c6d9cb Upgrade: `$wpdb->get_col_length()` sanity check: bail on unexpected return value.
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32429


git-svn-id: http://core.svn.wordpress.org/trunk@32399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 23:11:26 +00:00
Michael Adams 0640526e72 Upgrade: Ensure unintelligible DB schemas don't result in content loss.
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32417


git-svn-id: http://core.svn.wordpress.org/trunk@32387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 21:46:26 +00:00
Aaron Jorbin 2d189ef812 When upgrading WordPress remove genericons example.html files
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin

--This line,build.wordpress-develop.dea and those below, will be ignored--

M    src/wp-admin/includes/update-core.php

Built from https://develop.svn.wordpress.org/trunk@32385


git-svn-id: http://core.svn.wordpress.org/trunk@32355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 18:37:25 +00:00
Sergey Biryukov 708791aa6b Customizer: Use a semantic, accessible element for Remove Header Image button.
Make the button more noticeable on dark, light, and busy images.

props afercia, RDall, melchoyce.
fixes #32227, #31325.
Built from https://develop.svn.wordpress.org/trunk@32382


git-svn-id: http://core.svn.wordpress.org/trunk@32352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 10:54:27 +00:00
Sergey Biryukov 77572cf024 Multisite: Add translator comments to default email messages with non-typical placeholders.
props yoavf.
fixes #32263.
Built from https://develop.svn.wordpress.org/trunk@32381


git-svn-id: http://core.svn.wordpress.org/trunk@32351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 09:12:25 +00:00
Gary Pendergast 4e615fb9ff Fix an incorrect version number check in [32378].
See #32099.


Built from https://develop.svn.wordpress.org/trunk@32379


git-svn-id: http://core.svn.wordpress.org/trunk@32349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:41:24 +00:00
Gary Pendergast 3a6e79c409 Upgrades: When converting to `utf8mb4`, we were trying to change the wrong index on `wp_signups`, causing the conversion to later fail.
Props kovshenin, pento.

See #32099.


Built from https://develop.svn.wordpress.org/trunk@32378


git-svn-id: http://core.svn.wordpress.org/trunk@32348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:34:24 +00:00
Gary Pendergast 364886a5be WPDB: When checking that a string can be sent to MySQL, we shouldn't use `mb_convert_encoding()`, as it behaves differently to MySQL's character encoding conversion.
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.


Built from https://develop.svn.wordpress.org/trunk@32364


git-svn-id: http://core.svn.wordpress.org/trunk@32335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 03:00:25 +00:00
Drew Jaynes a452927c39 Fix documentation syntax and formatting for the `media_sideload_image()` DocBlock.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32352


git-svn-id: http://core.svn.wordpress.org/trunk@32323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:20:25 +00:00
Drew Jaynes cbd07f213d Add two changelog entries for functional changes introduced in 4.2.0.
Props dimadin.
See #31925.

Built from https://develop.svn.wordpress.org/trunk@32350


git-svn-id: http://core.svn.wordpress.org/trunk@32321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:16:25 +00:00
Drew Jaynes 08e3572b7c Add a missing DocBlock for `wp_caption_input_textarea()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32341


git-svn-id: http://core.svn.wordpress.org/trunk@32312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:13:25 +00:00
Drew Jaynes e7e93f50cf Add a missing `@return` tag to the DocBlock for `uninstall_plugin().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32340


git-svn-id: http://core.svn.wordpress.org/trunk@32311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:08:27 +00:00
Drew Jaynes 87e149a19f Add a missing `@return` tag to the DocBlock for `site_admin_notice()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32339


git-svn-id: http://core.svn.wordpress.org/trunk@32310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:06:25 +00:00
Drew Jaynes cdbecf201b Clarify accepted types for the `$args` and `$context` parameters in `WP_Filesystem()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32338


git-svn-id: http://core.svn.wordpress.org/trunk@32309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:04:25 +00:00
Andrew Ozz a5cee54aea Emoji: rename the exclude class to wp-exclude-emoji.
Props Clorith. See #32197.
Built from https://develop.svn.wordpress.org/trunk@32337


git-svn-id: http://core.svn.wordpress.org/trunk@32308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 00:05:28 +00:00
Andrew Ozz 8eb93bc838 Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
See #32197.
Built from https://develop.svn.wordpress.org/trunk@32336


git-svn-id: http://core.svn.wordpress.org/trunk@32307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 20:18:26 +00:00
Sergey Biryukov ed0da72d97 Replace `echo __()` with `_e()`.
props marsjaninzmarsa.
fixes #32239.
Built from https://develop.svn.wordpress.org/trunk@32333


git-svn-id: http://core.svn.wordpress.org/trunk@32304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 16:18:28 +00:00
Sergey Biryukov 13af7e1d72 Merge two strings from theme details dialog.
props McGuive7.
fixes #32047.
Built from https://develop.svn.wordpress.org/trunk@32332


git-svn-id: http://core.svn.wordpress.org/trunk@32303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-02 09:11:25 +00:00
Scott Taylor 2807b7146f After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.

Built from https://develop.svn.wordpress.org/trunk@32330


git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 21:40:25 +00:00
Sergey Biryukov aaafb3113a Bulk Edit: Properly associate the Format select with its label.
props afercia.
fixes #32210.
Built from https://develop.svn.wordpress.org/trunk@32329


git-svn-id: http://core.svn.wordpress.org/trunk@32300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 16:04:24 +00:00
Sergey Biryukov 5a0f970b2e Use correct closing tag.
props eligijus, TobiasBg.
fixes #32205.
Built from https://develop.svn.wordpress.org/trunk@32328


git-svn-id: http://core.svn.wordpress.org/trunk@32299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 14:30:25 +00:00
Dion Hulse 610e34c215 When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop.
Props hnle, taka2. Fixes #32135. See #31811

Built from https://develop.svn.wordpress.org/trunk@32322


git-svn-id: http://core.svn.wordpress.org/trunk@32293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-29 03:17:31 +00:00
Gary Pendergast 44b56d9393 When deleting suspicious comments, do so permanently.
Built from https://develop.svn.wordpress.org/trunk@32310


git-svn-id: http://core.svn.wordpress.org/trunk@32281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:11:26 +00:00
Gary Pendergast b89fc65951 [32308] was for 4.3, not 4.2.1.
Built from https://develop.svn.wordpress.org/trunk@32309


git-svn-id: http://core.svn.wordpress.org/trunk@32280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:08:27 +00:00
Gary Pendergast 51402dc520 When upgrading to 4.2.1, delete suspicious comments.
Built from https://develop.svn.wordpress.org/trunk@32308


git-svn-id: http://core.svn.wordpress.org/trunk@32279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:04:25 +00:00
Helen Hou-Sandí 25a0ca9f69 About page: Finalize media for 4.2.
props ocean90, Nao.
fixes #31929.

Built from https://develop.svn.wordpress.org/trunk@32277


git-svn-id: http://core.svn.wordpress.org/trunk@32248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-23 15:43:25 +00:00
Helen Hou-Sandí 685ebd0a6c Customizer theme details modal: Repair the layout for IE8.
props obenland.
fixes #32066.

Built from https://develop.svn.wordpress.org/trunk@32269


git-svn-id: http://core.svn.wordpress.org/trunk@32240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 18:57:25 +00:00
Helen Hou-Sandí 6fbfc06e0d Admin menu: prevent (most) lock outs caused by plugins or IE7.
fixes #30900.

Built from https://develop.svn.wordpress.org/trunk@32268


git-svn-id: http://core.svn.wordpress.org/trunk@32239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 18:38:29 +00:00
Dominik Schilling aea00880f1 Don't try to focus disabled input fields in the request filesystem credentials form.
fixes #32064.
Built from https://develop.svn.wordpress.org/trunk@32267


git-svn-id: http://core.svn.wordpress.org/trunk@32238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:57:26 +00:00
Dominik Schilling 89e45feb4c Don't focus input fields outside of the request filesystem credentials form.
props valendesigns.
fixes #32055.
Built from https://develop.svn.wordpress.org/trunk@32266


git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:24:26 +00:00
Dominik Schilling b29c8c503b Theme Switcher: Provide an easier way to reset back to the current active theme.
* Add control for the active theme when doing a theme preview
* Highlight an active theme and move it to the top

props valendesigns, ocean90.
fixes #32002.
Built from https://develop.svn.wordpress.org/trunk@32265


git-svn-id: http://core.svn.wordpress.org/trunk@32236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:15:27 +00:00
Dominik Schilling e0657e6904 Don't return empty themes in `wp_prepare_themes_for_js()`.
see #32002.
Built from https://develop.svn.wordpress.org/trunk@32264


git-svn-id: http://core.svn.wordpress.org/trunk@32235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:11:25 +00:00
Sergey Biryukov 3e99df2858 About page design for 4.2.
props melchoyce, ryelle.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32260


git-svn-id: http://core.svn.wordpress.org/trunk@32231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 06:04:29 +00:00
Andrew Ozz 60706015e1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.
Built from https://develop.svn.wordpress.org/trunk@32258


git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
Helen Hou-Sandí e8ee561a4f Shiny Updates: Prevent the post-update success message from jumping.
props pareshradadiya, afercia.
fixes #31984.

Built from https://develop.svn.wordpress.org/trunk@32256


git-svn-id: http://core.svn.wordpress.org/trunk@32227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 20:41:28 +00:00
Helen Hou-Sandí 1d1c026e8e Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`.
props DrewAPicture.
fixes #31789.

Built from https://develop.svn.wordpress.org/trunk@32246


git-svn-id: http://core.svn.wordpress.org/trunk@32217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:23:27 +00:00
Helen Hou-Sandí f861754016 Customizer: Better experience for widget filtering in desktop and iOS Safari.
Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.

props dsmart, ocean90.
fixes #31987.

Built from https://develop.svn.wordpress.org/trunk@32243


git-svn-id: http://core.svn.wordpress.org/trunk@32214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:15:26 +00:00
Helen Hou-Sandí b0a5febdf2 Press This: Prevent bottom buttons from wrapping on narrow screens.
props Michael Arestad.
fixes #32022.

Built from https://develop.svn.wordpress.org/trunk@32230


git-svn-id: http://core.svn.wordpress.org/trunk@32204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 21:03:26 +00:00
Gary Pendergast e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard.
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Gary Pendergast e2d3bdf615 Correctly escape theme version numbers when displaying them.
Props collinsinternet.


Built from https://develop.svn.wordpress.org/trunk@32170


git-svn-id: http://core.svn.wordpress.org/trunk@32145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 06:27:25 +00:00
Andrew Nacin 9e92fab289 Update wp_die() calls modified in [31658] to use shorthand calling style.
see #31422.

Built from https://develop.svn.wordpress.org/trunk@32152


git-svn-id: http://core.svn.wordpress.org/trunk@32127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 03:27:27 +00:00
Sergey Biryukov 7f48138743 Press This: Update documentation for `press_this_save_redirect` filter after [31992].
props kraftbj.
fixes #31996.
Built from https://develop.svn.wordpress.org/trunk@32143


git-svn-id: http://core.svn.wordpress.org/trunk@32123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-19 01:34:28 +00:00
Dominik Schilling 1ec6848eec About page: All strings are available for translation.
* Remove AJAX call added in [30840].
* Remove `<code>` tags out of localized strings.

props johnbillion, ocean90.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32136


git-svn-id: http://core.svn.wordpress.org/trunk@32115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 18:19:25 +00:00
Helen Hou-Sandí dacf31fa4a About page: A last round of text updates.
props DrewAPicture, johnbillion, afercia, helen.
see #31929.

Built from https://develop.svn.wordpress.org/trunk@32135


git-svn-id: http://core.svn.wordpress.org/trunk@32114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 17:34:25 +00:00
Dominik Schilling 786bce5b9c Customizer: Escape theme preview URLs.
props johnbillion, ocean90.
see #31896.
Built from https://develop.svn.wordpress.org/trunk@32134


git-svn-id: http://core.svn.wordpress.org/trunk@32113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 16:33:25 +00:00
Aaron Jorbin ee9adc354a Move wp-plugin-update-success event to after lock is released
Fixes #31978
See #31819
Props DavidAnderson


Built from https://develop.svn.wordpress.org/trunk@32133


git-svn-id: http://core.svn.wordpress.org/trunk@32112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 14:37:27 +00:00
Sergey Biryukov 20d39c8478 About page: Two more string tweaks.
props DrewAPicture, pento.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32132


git-svn-id: http://core.svn.wordpress.org/trunk@32111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 01:24:24 +00:00
Sergey Biryukov 875585d147 About page updates.
* Change the subhead strings on credits.php and freedoms.php to match about.php.
* Link the Emoji Codex article in the emoji blurb.
* Add a second sentence to the JavaScript Accessibility blurb.
* Switch positions for the JavaScript Accessibility and Complex Query Ordering sections for balance.

props DrewAPicture, ocean90, pavelevap.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32131


git-svn-id: http://core.svn.wordpress.org/trunk@32110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 00:38:27 +00:00
Dominik Schilling d72d9f21ab Update about page for 4.2.
props siobhan, DrewAPicture.
see #31929
Built from https://develop.svn.wordpress.org/trunk@32130


git-svn-id: http://core.svn.wordpress.org/trunk@32109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 18:53:25 +00:00
Dominik Schilling 4073ff026b Force default avatar for HiDPI avatars on Discussion Settings.
props SergeyBiryukov.
fixes #31972.
Built from https://develop.svn.wordpress.org/trunk@32129


git-svn-id: http://core.svn.wordpress.org/trunk@32108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 18:09:26 +00:00
Dominik Schilling d31d2ff792 Reset padding for buttons in theme details modal.
props awbauer.
fixes #31963.
Built from https://develop.svn.wordpress.org/trunk@32128


git-svn-id: http://core.svn.wordpress.org/trunk@32107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 18:04:28 +00:00
Aaron Jorbin a07e9e127f Use named function instead of anonymous function
The named function is testable and replaceable.

Fixes #31964
Props DavidAnderson, adamsilverstein, jorbin



Built from https://develop.svn.wordpress.org/trunk@32126


git-svn-id: http://core.svn.wordpress.org/trunk@32105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 16:42:26 +00:00
Scott Taylor 5e4616039c Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
Props iseulde, ocean90.
Fixes #31912.

Built from https://develop.svn.wordpress.org/trunk@32125


git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
Sergey Biryukov dafccdd922 Fix typo on About page.
props jamescollins.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32123


git-svn-id: http://core.svn.wordpress.org/trunk@32102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 06:54:25 +00:00
Andrew Ozz fe150b9ef2 Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
Props kraftbj. Fixes #31968.
Built from https://develop.svn.wordpress.org/trunk@32122


git-svn-id: http://core.svn.wordpress.org/trunk@32101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 05:45:28 +00:00
Dominik Schilling 7b24017cdb Customizer Theme Switcher: Don't re-render a theme control if it has already been rendered.
Move initialization of `$customizeSidebar` to `api.ThemesSection.initialize()` to prevent cases where the result can be undefined.

props westonruter, ocean90.
fixes #31793.
Built from https://develop.svn.wordpress.org/trunk@32119


git-svn-id: http://core.svn.wordpress.org/trunk@32098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-13 22:10:29 +00:00
Dominik Schilling da928039a6 4.2 about page text, rough cut.
props helen, siobhan, DrewAPicture, samuelsidler, markjaquith, nacin.
see #31929.
Built from https://develop.svn.wordpress.org/trunk@32118


git-svn-id: http://core.svn.wordpress.org/trunk@32097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-13 15:39:29 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Gary Pendergast 0179958273 When `dbDelta()` is checking whether an index is defined in a `CREATE TABLE` statement, don't worry if MySQL has a subpart defined on an index, but the `CREATE TABLE` doesn't.
Fixes #31869.


Built from https://develop.svn.wordpress.org/trunk@32108


git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-11 10:40:31 +00:00
Andrew Ozz ad475b3c69 Press This: check the bookmarklet version and add the update notice from PHP.
Fixes #31942.
Built from https://develop.svn.wordpress.org/trunk@32106


git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 21:08:29 +00:00
Helen Hou-Sandí 95ce53a090 Customizer theme switcher: Fix some esoteric breakage in iOS Safari.
This manifested in only being able to switch your theme once in the customizer before the "Change" button would appear to stop responding, though a switch to "Preview" and back to "Customize" would reveal the theme switcher after all. Animated positioning appears to be the problem here. The animations are not critical to the experience, particularly on touch+smaller screen devices.

props iseulde.
see #31794.

Built from https://develop.svn.wordpress.org/trunk@32103


git-svn-id: http://core.svn.wordpress.org/trunk@32082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 02:44:29 +00:00
Andrew Ozz 0d4b29ffb9 Press This: add ARIA attributes to the `alerts` container.
Props afercia. Fixes #31942.
Built from https://develop.svn.wordpress.org/trunk@32102


git-svn-id: http://core.svn.wordpress.org/trunk@32081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 23:45:27 +00:00
Andrew Ozz 8d01d0be3f Revert [32099] per discussion in #core: https://wordpress.slack.com/archives/core/p1428608303003309.
See #30900.
Built from https://develop.svn.wordpress.org/trunk@32100


git-svn-id: http://core.svn.wordpress.org/trunk@32079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 19:56:27 +00:00
Andrew Ozz 9e87e6b098 Remove z-index from `#adminmenuback`.
Fixes #30900.
Built from https://develop.svn.wordpress.org/trunk@32099


git-svn-id: http://core.svn.wordpress.org/trunk@32078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 19:26:25 +00:00
Andrew Ozz 923ca312e4 Press This:
- Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
- Reset the Save Draft button on node change in the editor.
See #31923.
Built from https://develop.svn.wordpress.org/trunk@32098


git-svn-id: http://core.svn.wordpress.org/trunk@32077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 19:07:28 +00:00
Andrew Ozz 9db5bac3c4 Press This: change the link text to Standard Editor.
Props Michael-Arestad. See #31923.
Built from https://develop.svn.wordpress.org/trunk@32093


git-svn-id: http://core.svn.wordpress.org/trunk@32072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:28:25 +00:00
Andrew Ozz 33a0022773 Press This:
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923.
Built from https://develop.svn.wordpress.org/trunk@32092


git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:14:28 +00:00
Dominik Schilling d43d1503f7 Customize Headers: Improve handling of the initial header model.
Headers are currently keyed by the basename of the image, see #31786. When two images have the same key only one image will be listed and the current image can be empty in the header control.
To prevent this we now fall back to the raw current header image if the image isn't in `_wpCustomizeHeader.uploads`.

props sirbrillig.
fixes #31742.
Built from https://develop.svn.wordpress.org/trunk@32091


git-svn-id: http://core.svn.wordpress.org/trunk@32070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 22:28:27 +00:00
Andrew Ozz ab8441ccc1 Fix flickering of the admin menu on over-scrolling.
Props joemcgill, mindrun. Fixes #30900.
Built from https://develop.svn.wordpress.org/trunk@32089


git-svn-id: http://core.svn.wordpress.org/trunk@32068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 21:39:26 +00:00
Dominik Schilling 755d44736a Customizer Theme Switcher: Lazy load theme screenshots.
props westonruter, ocean90.
fixes #31793.
Built from https://develop.svn.wordpress.org/trunk@32088


git-svn-id: http://core.svn.wordpress.org/trunk@32067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 20:52:29 +00:00
Dominik Schilling 15f24a7730 Customizer Theme Switcher: Fix tabbing order if section is open.
see #31289.
Built from https://develop.svn.wordpress.org/trunk@32087


git-svn-id: http://core.svn.wordpress.org/trunk@32066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 19:03:25 +00:00
Dominik Schilling 79eee23a29 Customizer Theme Switcher: Don't deactivate section on empty search results.
props westonruter.
fixes #31889.
Built from https://develop.svn.wordpress.org/trunk@32083


git-svn-id: http://core.svn.wordpress.org/trunk@32062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:53:28 +00:00
Aaron Jorbin 0402c0b877 Disable shiny updates from modal based on parent window
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal.  Instead, let's use the parent window's location.

Fixes #31739



Built from https://develop.svn.wordpress.org/trunk@32082


git-svn-id: http://core.svn.wordpress.org/trunk@32061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:38:27 +00:00
Aaron Jorbin 7aeea37d47 Fix logic for details based shiny updates.
This fixes two problems.  TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward.  Also fixes logic error.

See #31739


Built from https://develop.svn.wordpress.org/trunk@32080


git-svn-id: http://core.svn.wordpress.org/trunk@32059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:27:26 +00:00
Boone Gorges 54a6a8e137 Don't allow whitespace-only image captions from the Media modal.
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.

Fixes #21848.
Built from https://develop.svn.wordpress.org/trunk@32079


git-svn-id: http://core.svn.wordpress.org/trunk@32058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:11:27 +00:00
Aaron Jorbin abfddb8f3e Update placeholder for FTP credentials
Two changes:
 * Remove superfluous __ function call
 * Update domain used

Fixes #31922
Props Tmeister


Built from https://develop.svn.wordpress.org/trunk@32077


git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:50:27 +00:00
Helen Hou-Sandí dbc8943dd5 Dashboard: Ensure images other than avatars (such as emoji replacements) in recent comments are not incorrectly positioned.
props SergeyBiryukov.
fixes #31919.

Built from https://develop.svn.wordpress.org/trunk@32076


git-svn-id: http://core.svn.wordpress.org/trunk@32055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:49:26 +00:00
Helen Hou-Sandí 4e7cb5e05d Admin menu: fix colors for focus state and in IE8.
props afercia.
fixes #31345.

Built from https://develop.svn.wordpress.org/trunk@32075


git-svn-id: http://core.svn.wordpress.org/trunk@32054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:38:26 +00:00
Helen Hou-Sandí 2a0d187a15 Modals: Significantly improve the touch scrolling experience.
This particularly fixes the attachment and plugin details modals, but also improves other modals such as wpLink and interim login.

props iseulde.
fixes #31609, #31611. see #31610, #31612.

Built from https://develop.svn.wordpress.org/trunk@32073


git-svn-id: http://core.svn.wordpress.org/trunk@32052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 03:19:28 +00:00
Helen Hou-Sandí efbf3e2c3c Ensure post title input is not shortened for non-public post types.
props tyxla.
fixes #30968.

Built from https://develop.svn.wordpress.org/trunk@32071


git-svn-id: http://core.svn.wordpress.org/trunk@32050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 20:44:27 +00:00
Helen Hou-Sandí f780e422d8 Dismissible notices: more precise positioning across browsers.
props valendesigns.
fixes #31233.

Built from https://develop.svn.wordpress.org/trunk@32068


git-svn-id: http://core.svn.wordpress.org/trunk@32047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 18:44:27 +00:00
Aaron Jorbin 55cebbeeb6 Disable modal initiated shiny updates on wp-admin/update-core.php
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.

Fixes #31739


Built from https://develop.svn.wordpress.org/trunk@32067


git-svn-id: http://core.svn.wordpress.org/trunk@32046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 04:48:26 +00:00
Aaron Jorbin 1facff5425 Use dashes instead of dots as separator for jQuery events in shiny updates
`.` is used for namespaces, so better to use dashes.

see #31819
props iseulde 


Built from https://develop.svn.wordpress.org/trunk@32063


git-svn-id: http://core.svn.wordpress.org/trunk@32042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:12:26 +00:00
Aaron Jorbin 99d6c67148 Enable users to initiate a shiny update from plugin detail modal
The plugin detail modal can contain a link to update a plugin.  When it does, we should initiate a shiny update.

This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on.  These are the same users that can't use the customizer. 

Fixes #31739



Built from https://develop.svn.wordpress.org/trunk@32062


git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Aaron Jorbin 1985d00886 Trigger events upon the completion of a shiny update
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.  

See #31819


Built from https://develop.svn.wordpress.org/trunk@32061


git-svn-id: http://core.svn.wordpress.org/trunk@32040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 02:32:26 +00:00
Helen Hou-Sandí 42028327a2 Insert from URL: Make sure the link text is actually used.
Turns out there were more pieces to renaming the field.

props iseulde.
fixes #29476.

Built from https://develop.svn.wordpress.org/trunk@32055


git-svn-id: http://core.svn.wordpress.org/trunk@32034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 18:25:27 +00:00
Dominik Schilling 6d2c70aa0d Customizer: Refresh nonces when a session expires and the user logs in again.
This was broken since 4.0 and the introduction of user session tokens. The nonces are now tied to session tokens as opposed to user IDs, and thus they change with each re-login.
Custom nonces can be added through the `customize_refresh_nonces` filter. On a successful refresh request the JavaScript API will trigger a `nonce-refresh` event. See widget's update nonce as an example.

props westonruter for initial patch.
fixes #31294.
Built from https://develop.svn.wordpress.org/trunk@32054


git-svn-id: http://core.svn.wordpress.org/trunk@32033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 15:10:27 +00:00
Aaron Jorbin dd5b92a2fe Remove Shiny Bulk Updates
Bulk updates don't need to be ajaxified so let's revert.

See #31770, #29820,


Built from https://develop.svn.wordpress.org/trunk@32053


git-svn-id: http://core.svn.wordpress.org/trunk@32032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:21:26 +00:00
Aaron Jorbin 2c42b8f0b2 Conditionally add AYS to leaving shiny updates
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.

See #31769
Props ericlewis and adamsilverstein for initial patch


Built from https://develop.svn.wordpress.org/trunk@32052


git-svn-id: http://core.svn.wordpress.org/trunk@32031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:00:26 +00:00
Helen Hou-Sandí bfda508c18 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Sergey Biryukov f2a69e631c After [31941], use the decoupled strings from `wp-admin/network/themes.php` in `wp-admin/network/site-themes.php` as well.
fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@32029


git-svn-id: http://core.svn.wordpress.org/trunk@32008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:58:27 +00:00
Sergey Biryukov 443760252b `wp_install_maybe_enable_pretty_permalinks()` should have a consistent `@return` value.
props DrewAPicture.
fixes #6481. see #31888.
Built from https://develop.svn.wordpress.org/trunk@32027


git-svn-id: http://core.svn.wordpress.org/trunk@32006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:49:53 +00:00
Drew Jaynes ba1e7a7243 Correct grammar when referring to "a user" vs "an user" in several places.
Props ocean90.
Fixes #31894.

Built from https://develop.svn.wordpress.org/trunk@32025


git-svn-id: http://core.svn.wordpress.org/trunk@32004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:44:27 +00:00
Drew Jaynes 7c3e469326 Clarify the DocBlock summary and parameter description for `wp_edit_attachments_query_vars()`.
See [31037]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32019


git-svn-id: http://core.svn.wordpress.org/trunk@31998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:52:25 +00:00
Drew Jaynes 6ccba88ea5 Add proper descriptions for the `@global` and `@param` tags in the `wp_media_attach_action()` DocBlock.
See [31619]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32018


git-svn-id: http://core.svn.wordpress.org/trunk@31997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:35:25 +00:00
Drew Jaynes 02810a305f Clarify the DocBlock description for `wp_print_request_filesystem_credentials_modal()`.
See [31811]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32016


git-svn-id: http://core.svn.wordpress.org/trunk@31995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:13:26 +00:00
Drew Jaynes 654ee78c93 Clarify 4.2.0 changelog entry, add global description to the DocBlock for `WP_Users_List_Table->single_row()`.
See #31888.

Built from https://develop.svn.wordpress.org/trunk@32015


git-svn-id: http://core.svn.wordpress.org/trunk@31994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:09:27 +00:00
Drew Jaynes e82de7ef27 Add missing `@since` versions from a variety of methods in `WP_Press_This`.
See [31693]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32014


git-svn-id: http://core.svn.wordpress.org/trunk@31993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 19:46:26 +00:00
Drew Jaynes 7b89119eee Add missing DocBlocks for the `_limit_array()`, `_limit_string()`, `_limit_url()`, `_limit_img()`, `_limit_embed()`, and `_process_meta_entry()` utility methods in `WP_Press_This`.
See [31609]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32013


git-svn-id: http://core.svn.wordpress.org/trunk@31992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 18:23:26 +00:00
Dominik Schilling 4f3fb2315d Customize Widgets: Improve sync logic for select[multiple] inputs.
The current logic doesn't account for the special case of `select[multiple]` inputs which lack a single value to synchronize: The value to synchronize is an array of zero or more values.
This change replaces `_getInputStatePropertyName()` with `_getInputState()`, which returns the state for an input depending on its type, and `_setInputState()`, which updates an input's state based on its type.

props westonruter.
fixes #31885.
Built from https://develop.svn.wordpress.org/trunk@32012


git-svn-id: http://core.svn.wordpress.org/trunk@31991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:34:26 +00:00
Drew Jaynes 0306f2c011 Fix filter doc vernacular for the `quick_edit_show_taxonomy` filter.
See [31308]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32011


git-svn-id: http://core.svn.wordpress.org/trunk@31990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:08:26 +00:00
Drew Jaynes 4239756a47 Fix syntax for the `$to_display` parameter description in the DocBlock for `WP_Posts_List_Table->_page_rows()`.
See [31730]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32010


git-svn-id: http://core.svn.wordpress.org/trunk@31989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:04:28 +00:00
Drew Jaynes 8a3b21aad5 Add a return description to the DocBlock for `WP_Posts_List_Table->is_base_request()`.
See [31828]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32009


git-svn-id: http://core.svn.wordpress.org/trunk@31988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:01:27 +00:00
Dominik Schilling 785f479245 Customizer: Fix spinners after [31996].
props westonruter.
fixes #31884.
Built from https://develop.svn.wordpress.org/trunk@32008


git-svn-id: http://core.svn.wordpress.org/trunk@31987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 15:42:28 +00:00
Drew Jaynes b500d3e978 Fix typos in the function summaries for `wp_ajax_press_this_save_post()` and `wp_ajax_press_this_add_category()`.
See [31534]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32007


git-svn-id: http://core.svn.wordpress.org/trunk@31986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:38:26 +00:00
Drew Jaynes 05fa6879ce Add an `@see` mention for `Plugin_Upgrader`, plus spacing to the `wp_ajax_update_plugin()` delcaration.
See #31888.

Built from https://develop.svn.wordpress.org/trunk@32006


git-svn-id: http://core.svn.wordpress.org/trunk@31985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:19:27 +00:00
Drew Jaynes c477b2c966 Add a more descriptive function summary for `options_discussion_add_js()`.
See [31095]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32005


git-svn-id: http://core.svn.wordpress.org/trunk@31984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:16:27 +00:00
Dominik Schilling 59c586e5ad Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.
see #31837.
Built from https://develop.svn.wordpress.org/trunk@32004


git-svn-id: http://core.svn.wordpress.org/trunk@31983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:14:26 +00:00
Drew Jaynes d8f67f4340 Fix Docblock syntax for the `taxonomy_parent_dropdown_args` filter.
See [30998]. See #31888

Built from https://develop.svn.wordpress.org/trunk@32003


git-svn-id: http://core.svn.wordpress.org/trunk@31982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:13:27 +00:00
Boone Gorges 62450e9f0f After [31114] and [31323], 'View Post' generated in `get_sample_permalink_html()` should go to pretty permalink.
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.

Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@32002


git-svn-id: http://core.svn.wordpress.org/trunk@31981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 01:27:28 +00:00
Sergey Biryukov 247fdbfe19 Remove hidden `user_id` input from `wp_comment_reply()`.
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31999


git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 13:28:26 +00:00
Helen Hou-Sandí 3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Andrew Ozz 52db6356a1 Themes screen: remove extra debounce when searching.
Props evansolomon. Fixes #31812.
Built from https://develop.svn.wordpress.org/trunk@31995


git-svn-id: http://core.svn.wordpress.org/trunk@31974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:37:32 +00:00
Andrew Ozz 2d36b8ff4a Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.
Built from https://develop.svn.wordpress.org/trunk@31994


git-svn-id: http://core.svn.wordpress.org/trunk@31973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:32:28 +00:00
Andrew Ozz a99b349283 Accessibility improvements for Options general screen: add missing labels and aria attributes.
Props DrewAPicture, afercia. Fixes #31144.
Built from https://develop.svn.wordpress.org/trunk@31993


git-svn-id: http://core.svn.wordpress.org/trunk@31972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:55:40 +00:00
Andrew Ozz 05a549723c Press This:
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.
Built from https://develop.svn.wordpress.org/trunk@31992


git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
John Blackbourn d05236f756 Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
See #31770.

Built from https://develop.svn.wordpress.org/trunk@31991


git-svn-id: http://core.svn.wordpress.org/trunk@31970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 00:18:27 +00:00
Dion Hulse 02403eadd1 Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865

Built from https://develop.svn.wordpress.org/trunk@31990


git-svn-id: http://core.svn.wordpress.org/trunk@31969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 23:49:27 +00:00
Andrew Ozz b98ba09e5b Press This: prevent pasting of HTML in the title H2. Insert the clipboard text instead.
Fixes #31768.
Built from https://develop.svn.wordpress.org/trunk@31987


git-svn-id: http://core.svn.wordpress.org/trunk@31966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 21:11:30 +00:00
Sergey Biryukov c691addc73 Remove unnecessary `echo()`, add translator comment.
props ramiy.
fixes #31873.
Built from https://develop.svn.wordpress.org/trunk@31986


git-svn-id: http://core.svn.wordpress.org/trunk@31965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 19:01:27 +00:00
Dominik Schilling 942c6a9edc Customizer: Update selector, missed in [31984].
see #28784.
Built from https://develop.svn.wordpress.org/trunk@31985


git-svn-id: http://core.svn.wordpress.org/trunk@31964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 17:18:25 +00:00
Dominik Schilling eafbdb0a2f Customizer: Improve the overlay close button for iOS.
see #28784.
Built from https://develop.svn.wordpress.org/trunk@31984


git-svn-id: http://core.svn.wordpress.org/trunk@31963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 17:16:28 +00:00
Aaron Jorbin 3ac2f91922 Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722



Built from https://develop.svn.wordpress.org/trunk@31982


git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
Sergey Biryukov 633241e60d Press This: Use more accurate wording on Tools screen.
props kraftbj.
see #31836.
Built from https://develop.svn.wordpress.org/trunk@31980


git-svn-id: http://core.svn.wordpress.org/trunk@31959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 01:30:28 +00:00
Dominik Schilling 254b9e3264 Customizer Theme Switcher: Navigation streamlining.
* Detach Themes section from other controls
* Move to buttons to navigate back and forth
* Change titles based on current theme status, active/previewing
* Hide the active/previewing theme from the list of available themes

props folletto for the design concepts.
props designsimply, celloexpressions for initial patches.
props Team Gandalf.
see #31289.
Built from https://develop.svn.wordpress.org/trunk@31975


git-svn-id: http://core.svn.wordpress.org/trunk@31954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:51:27 +00:00
Dominik Schilling ba7f53f029 Customizer: Make the available widgets overlay closable on narrow screens.
see #28784.
Built from https://develop.svn.wordpress.org/trunk@31974


git-svn-id: http://core.svn.wordpress.org/trunk@31953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:25:28 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Aaron Jorbin 786083fd8e Fix colors for activated and updated plugins
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared. 

See #31608



Built from https://develop.svn.wordpress.org/trunk@31969


git-svn-id: http://core.svn.wordpress.org/trunk@31948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 21:31:26 +00:00
Sergey Biryukov d013c703e4 Merge title strings on Edit Site screens.
props ramiy.
fixes #31844.
Built from https://develop.svn.wordpress.org/trunk@31962


git-svn-id: http://core.svn.wordpress.org/trunk@31941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 18:00:28 +00:00
Sergey Biryukov 72bddcc1d5 Remove unused `printf()` on network setup screen.
props ramiy.
fixes #31841.
Built from https://develop.svn.wordpress.org/trunk@31961


git-svn-id: http://core.svn.wordpress.org/trunk@31940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 17:01:26 +00:00
Scott Taylor 62279ae07d In `WP_Posts_List_Table::get_views()`, don't add the `current` class to the `all` status link if `->user_posts_count` has a value, which triggers the additional `mine` status.
See [31828].
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31959


git-svn-id: http://core.svn.wordpress.org/trunk@31938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:17:28 +00:00
Sergey Biryukov 29cddbeda9 Add translator comments for placeholders in network-related strings.
props ramiy.
fixes #31834.
Built from https://develop.svn.wordpress.org/trunk@31956


git-svn-id: http://core.svn.wordpress.org/trunk@31935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:26:28 +00:00
Dominik Schilling a7ba89b027 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.
Built from https://develop.svn.wordpress.org/trunk@31955


git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:17:27 +00:00
Dominik Schilling 8ab7c076d6 Customizer Theme Switcher: Switch the details/live preview buttons.
props celloexpressions, ocean90.
fixes #31791.
Built from https://develop.svn.wordpress.org/trunk@31954


git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
Dominik Schilling 43352a0759 Themes: Improve focus styling of add-new-theme link.
props celloexpressions, mrahmadawais.
fixes #31203.
Built from https://develop.svn.wordpress.org/trunk@31952


git-svn-id: http://core.svn.wordpress.org/trunk@31931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:22:27 +00:00
Sergey Biryukov 6a297b848a After [31941], use the decoupled strings from `WP_Customize_Manager::register_controls()` on the Menus screen.
see #28502.
Built from https://develop.svn.wordpress.org/trunk@31951


git-svn-id: http://core.svn.wordpress.org/trunk@31930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 11:37:26 +00:00
Aaron Jorbin 8f99fbeb8d Refine UI for FTP modal and shiny updates
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608


Built from https://develop.svn.wordpress.org/trunk@31949


git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Dominik Schilling 79a29b077e Customizer: Defer rendering theme controls until the section is displayed.
see #31793.
Built from https://develop.svn.wordpress.org/trunk@31944


git-svn-id: http://core.svn.wordpress.org/trunk@31923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:21:25 +00:00
Sergey Biryukov efb2740e88 Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`.
props mattwiebe, DrewAPicture.
fixes #31789.
Built from https://develop.svn.wordpress.org/trunk@31943


git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 20:04:25 +00:00
Sergey Biryukov 5fae37471a Media Library: Add a label for attachment type select in list mode.
props afercia.
fixes #31795.
Built from https://develop.svn.wordpress.org/trunk@31942


git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
Sergey Biryukov 36643388ef Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@31941


git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
Dion Hulse 7e1e32909e Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811

Built from https://develop.svn.wordpress.org/trunk@31936


git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:26 +00:00
Dominik Schilling 289db2d37b Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother.
see #31782.
Built from https://develop.svn.wordpress.org/trunk@31933


git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
Sergey Biryukov e70e4e74fa Press This: Use the error message returned by `wp_update_post()` instead of a generic one.
props stephdau.
fixes #31808.
Built from https://develop.svn.wordpress.org/trunk@31930


git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
Sergey Biryukov cd2e63700e Use a more specific selector for comment moderation hotkeys after [31513].
props afercia.
fixes #31545.
Built from https://develop.svn.wordpress.org/trunk@31929


git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Sergey Biryukov 43a99e0f1b Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
props SergeyBiryukov, afercia, tyxla.
fixes #30766.
Built from https://develop.svn.wordpress.org/trunk@31928


git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
Sergey Biryukov a1dbd97adb Fix duplicate ID for Save Menu button on Menus screen.
props sagarjadhav.
fixes #31803.
Built from https://develop.svn.wordpress.org/trunk@31927


git-svn-id: http://core.svn.wordpress.org/trunk@31906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 09:49:26 +00:00
Andrew Ozz 6cd9c9645e Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes #31575.
Built from https://develop.svn.wordpress.org/trunk@31925


git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Dominik Schilling 7bc60fed4a Customizer: Increase initial-scale viewport specification to 1.0.
see #31794, #28784.
Built from https://develop.svn.wordpress.org/trunk@31921


git-svn-id: http://core.svn.wordpress.org/trunk@31900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 12:23:27 +00:00
Dominik Schilling b07e3e2de7 Customizer: Fix calculation of panel positions when accessing via deep-links.
Make sure that the parent `li` is shown before attempting to calculate its position.
Improve also the logic for focusing on a panel to prevent focusing hidden elements.

props westonruter.
fixes #31014.
see #31794.
Built from https://develop.svn.wordpress.org/trunk@31920


git-svn-id: http://core.svn.wordpress.org/trunk@31899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 11:17:28 +00:00
Andrew Ozz 71f48f45e0 Press This:
- When saving, replace emoji images with chars in the title text.
- Clean up the title text on paste.
See #31768.
Built from https://develop.svn.wordpress.org/trunk@31919


git-svn-id: http://core.svn.wordpress.org/trunk@31898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 03:14:28 +00:00
Dominik Schilling 96b88a391b Theme Switcher: Use the global panel back button instead of adding a new one.
This ensures the back button is visible on iOS devices. Same as in [29610].

see #31794.
Built from https://develop.svn.wordpress.org/trunk@31918


git-svn-id: http://core.svn.wordpress.org/trunk@31897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 22:09:26 +00:00
Dominik Schilling 7875dd4853 Customizer: Increase size of search field and disable text size adjustment to prevent auto zooming.
see #31794.
Built from https://develop.svn.wordpress.org/trunk@31917


git-svn-id: http://core.svn.wordpress.org/trunk@31896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 21:03:27 +00:00
Dominik Schilling 80972b7ecd Customizer: Fix selector for container which includes the controls. Broken since [30102].
see #31794, #31014.
Built from https://develop.svn.wordpress.org/trunk@31916


git-svn-id: http://core.svn.wordpress.org/trunk@31895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 20:47:30 +00:00
Dominik Schilling 2c036f589e Remove a stray > introduced in [31905].
see #31776.
Built from https://develop.svn.wordpress.org/trunk@31915


git-svn-id: http://core.svn.wordpress.org/trunk@31894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 23:20:27 +00:00
Dominik Schilling ee2829959a Theme Switcher: Opening themes details modal shouldn't require two clicks on touch devices.
Inspired by [26838].

see #31794.
Built from https://develop.svn.wordpress.org/trunk@31914


git-svn-id: http://core.svn.wordpress.org/trunk@31893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:54:29 +00:00
Dominik Schilling d51fded34c Customizer: Use responsive button styles if screen is max-width 640px.
see #31794, #28784.
Built from https://develop.svn.wordpress.org/trunk@31913


git-svn-id: http://core.svn.wordpress.org/trunk@31892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:17:30 +00:00
Dominik Schilling 2dfb835751 Theme Switcher: Don't hide action buttons on narrow screens.
see #31794.
Built from https://develop.svn.wordpress.org/trunk@31912


git-svn-id: http://core.svn.wordpress.org/trunk@31891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 21:53:27 +00:00
Helen Hou-Sandí 007665e7be Admin menu: Revert [31720] for swipe open/closed.
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.

see #31187.

Built from https://develop.svn.wordpress.org/trunk@31910


git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Andrew Ozz 321b551650 Fix focusing in the plugin and theme editors. Update the help.
Props afercia, Cheffheid. Fixes #31415.
Built from https://develop.svn.wordpress.org/trunk@31908


git-svn-id: http://core.svn.wordpress.org/trunk@31887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 22:35:27 +00:00
Andrew Ozz f663dc73d4 Press This: remove `role="application"` from the Categories list wrapper. This doesn't make it work better in screen readers.
See #31443.
Built from https://develop.svn.wordpress.org/trunk@31907


git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:49:32 +00:00
Dominik Schilling 8daaa09c9b Improve newly added strings for i18n:
* Add context to "Format" string.
* Use "Format" with context for "Post format".

see #31776.
Built from https://develop.svn.wordpress.org/trunk@31906


git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:19:26 +00:00
Dominik Schilling 55519962cc Improve newly added strings for i18n:
* Use a placeholder for the theme name to be able to reorder words.
* Uppercase D for "Theme Details" to match existing strings.
* Merge two revision date formats.
* Add translator comment to strings with placeholders.

props obenland.
see #31776.
Built from https://develop.svn.wordpress.org/trunk@31905


git-svn-id: http://core.svn.wordpress.org/trunk@31884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 20:56:26 +00:00
Aaron Jorbin 4c05e8c71c More clean up from removal of Shiny Plugin Installs
See #31773, #29820
Unprops Jorbin, Pento


Built from https://develop.svn.wordpress.org/trunk@31900


git-svn-id: http://core.svn.wordpress.org/trunk@31879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 16:30:27 +00:00
Aaron Jorbin 9b23faef07 Remove Shiny Plugin Installs
See #31773, #29820


Built from https://develop.svn.wordpress.org/trunk@31897


git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
Boone Gorges 60c26865f9 Check that `$_POST` array index is set before comparing it in `post_preview()`.
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.

Props tyxla.
Fixes #31760.
Built from https://develop.svn.wordpress.org/trunk@31896


git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:45:26 +00:00
Boone Gorges bc3d8197aa When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it.
Taxonomy metaboxes that are disabled for the current user are included in the
post.php markup, but do not contain the 'newtag' field, and so should be
skipped when looping through the metaboxes to avoid invoking String methods
on a variable of type `undefined`.

Props MikeNGarrett, A5hleyRich.
Fixes #30859.
Built from https://develop.svn.wordpress.org/trunk@31895


git-svn-id: http://core.svn.wordpress.org/trunk@31874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:23:28 +00:00
Andrew Ozz 6cc20e7095 Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
Props stephdau. Fixes #31763.
Built from https://develop.svn.wordpress.org/trunk@31894


git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:17:26 +00:00
Dominik Schilling de7ecc80d3 Customizer: [31885] actually hasn't fixed the `SecurityError`s. This one does.
props mattwiebe.
fixes #31687.
Built from https://develop.svn.wordpress.org/trunk@31893


git-svn-id: http://core.svn.wordpress.org/trunk@31872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 23:36:27 +00:00
Dominik Schilling f333f9ef11 Customizer Theme Switcher: Reset font size of theme names in overlay. Apply left position only to themes section.
see #31303.
Built from https://develop.svn.wordpress.org/trunk@31892


git-svn-id: http://core.svn.wordpress.org/trunk@31871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:58:27 +00:00
Dominik Schilling 51854c53b4 Improve alignment of labels and inputs in Quick Edit.
props mattheu, valendesigns.
fixes #31408.
Built from https://develop.svn.wordpress.org/trunk@31890


git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:25:26 +00:00
Dominik Schilling 5ef13b688e Comments List: Don't let "Quick Edit" break on smaller screens.
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.

props kraftbj.
fixes #31482.
Built from https://develop.svn.wordpress.org/trunk@31889


git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:15:27 +00:00
Dominik Schilling 7925e4c912 Customizer: Avoid `SecurityError`s when the Customizer is embedded in an origin other than wp-admin.
props mattwiebe.
fixes #31687.
Built from https://develop.svn.wordpress.org/trunk@31885


git-svn-id: http://core.svn.wordpress.org/trunk@31864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 17:26:26 +00:00
Drew Jaynes 1ad0eaf416 Clean up DocBlock information and syntax for `get_filesystem_method()`.
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267.

Built from https://develop.svn.wordpress.org/trunk@31884


git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 16:32:28 +00:00
Dion Hulse 7b5ae90225 When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL.
Fixes #31758. See #23367

Built from https://develop.svn.wordpress.org/trunk@31882


git-svn-id: http://core.svn.wordpress.org/trunk@31861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 04:32:26 +00:00
Andrew Ozz f5e6f92174 Do not output empty name and id HTML attributes in get_submit_button().
Props afercia. Fixes #31749.
Built from https://develop.svn.wordpress.org/trunk@31880


git-svn-id: http://core.svn.wordpress.org/trunk@31859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 03:23:27 +00:00
Gary Pendergast 2c45fd7ed7 Emoji: Revert [31877], and print the emoji shim and styles during `admin_print_scripts` and `admin_print_styles`, instead. This is a few milliseconds slower, but easier to reuse in Press This, and any other code that uses admin scripts and styles, without using `admin-header.php`.
See #31701.


Built from https://develop.svn.wordpress.org/trunk@31879


git-svn-id: http://core.svn.wordpress.org/trunk@31858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 01:43:28 +00:00
Gary Pendergast 4b3e47a843 Emoji: Print the emoji support shim in wp-admin, too.
See #31701.


Built from https://develop.svn.wordpress.org/trunk@31877


git-svn-id: http://core.svn.wordpress.org/trunk@31856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 01:14:27 +00:00
Sergey Biryukov ce6c00f140 Fix a typo in [31872].
see #31738.
Built from https://develop.svn.wordpress.org/trunk@31873


git-svn-id: http://core.svn.wordpress.org/trunk@31852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:33:27 +00:00
Aaron Jorbin 9c409e31f2 Fill `$plugins['upgrade']` with extra info for use in list table
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.   

Fixes #31738.


Built from https://develop.svn.wordpress.org/trunk@31872


git-svn-id: http://core.svn.wordpress.org/trunk@31851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:30:26 +00:00
Andrew Ozz 0329852941 Press This:
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745.
Built from https://develop.svn.wordpress.org/trunk@31868


git-svn-id: http://core.svn.wordpress.org/trunk@31847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 01:33:29 +00:00
Gary Pendergast 8acca2f52a Taxonomy List Tables: On mobile devices, hide the slug column, to avoid cramping the action links into two rows.
Props MikeNGarrett.

Fixes #29992.


Built from https://develop.svn.wordpress.org/trunk@31865


git-svn-id: http://core.svn.wordpress.org/trunk@31844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 12:21:28 +00:00
Dion Hulse 3dc53770b7 Upgrader: When creating a temporary working directory, strip off `.tmp` as well as `.zip` incase we end up using that directory as the items main directory.
Fixes #30945

Built from https://develop.svn.wordpress.org/trunk@31863


git-svn-id: http://core.svn.wordpress.org/trunk@31842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 04:40:27 +00:00
Dion Hulse cc903c3422 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121

Built from https://develop.svn.wordpress.org/trunk@31862


git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 02:14:27 +00:00
Helen Hou-Sandí bc54176af0 Media: Show filename instead of extension in the list table.
This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.

fixes #30943.

Built from https://develop.svn.wordpress.org/trunk@31857


git-svn-id: http://core.svn.wordpress.org/trunk@31836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-22 11:02:29 +00:00
Sergey Biryukov 42b9557137 Remove leading newlines from two translatable strings.
fixes #29480.
Built from https://develop.svn.wordpress.org/trunk@31844


git-svn-id: http://core.svn.wordpress.org/trunk@31826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:42:26 +00:00
Sergey Biryukov e8c164c118 Use bold Arial for RTL headings.
props valendesigns.
fixes #30807.
Built from https://develop.svn.wordpress.org/trunk@31843


git-svn-id: http://core.svn.wordpress.org/trunk@31825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:20:28 +00:00
Sergey Biryukov e838ab315d After [31730], replace one more instance of `array_shift()` with `reset()` for better performance.
see #31259, #15459.
Built from https://develop.svn.wordpress.org/trunk@31841


git-svn-id: http://core.svn.wordpress.org/trunk@31823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 01:57:27 +00:00
Sergey Biryukov b568da1997 Make a comment clearer (without implying inversed logic) and fix a typo.
see #31645.
Built from https://develop.svn.wordpress.org/trunk@31837


git-svn-id: http://core.svn.wordpress.org/trunk@31819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:45:27 +00:00
Andrew Ozz 1666eb5616 Press This: small clean-up when generating the suggested content. Ensure all keys are always set in the array that is passed through the filter.
See #31637.
Built from https://develop.svn.wordpress.org/trunk@31836


git-svn-id: http://core.svn.wordpress.org/trunk@31818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:18:26 +00:00
Aaron Jorbin 22476bf617 Fix notice that exists for plugins with no slug
Not all plugins have a slug, especially plugins not from the WordPress.org repository. 

Props imath for initial patch. 
Fixes #31694


Built from https://develop.svn.wordpress.org/trunk@31834


git-svn-id: http://core.svn.wordpress.org/trunk@31816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 17:48:29 +00:00
Jeremy Felt a18118ed7c Make dates in multisite site and user list tables translatable.
Props pavelevap.

Fixes #22302.

Built from https://develop.svn.wordpress.org/trunk@31833


git-svn-id: http://core.svn.wordpress.org/trunk@31815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 16:22:28 +00:00
Aaron Jorbin a836a32fb4 Ensure that we target the correct plugin row for update updates
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621



Built from https://develop.svn.wordpress.org/trunk@31831


git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 05:26:28 +00:00
Scott Taylor 55fd3fa791 In the "Send Trackbacks" meta box, the description of how pingbacks work was missing a comma after the introductory clause.
Props cfinke.
Fixes #31668.

Built from https://develop.svn.wordpress.org/trunk@31830


git-svn-id: http://core.svn.wordpress.org/trunk@31812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 04:06:27 +00:00
Scott Taylor bce851dcf2 Replace `array_shift()` with `reset()` where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.

Built from https://develop.svn.wordpress.org/trunk@31829


git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 03:56:27 +00:00
Scott Taylor 55ae3f9ea0 Add `WP_Posts_List_Table::is_base_request()` to determine if the current "view" is the "All" (default) view.
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31828


git-svn-id: http://core.svn.wordpress.org/trunk@31810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 02:26:26 +00:00
Andrew Ozz 40ebc2784f Press This: check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content.
Fixes #31637.
Built from https://develop.svn.wordpress.org/trunk@31827


git-svn-id: http://core.svn.wordpress.org/trunk@31809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 00:52:26 +00:00
Dominik Schilling 11a205d489 Edit Terms: Show error messages actually as error messages.
props rahulbhangale, SergeyBiryukov.
fixes #31241.
Built from https://develop.svn.wordpress.org/trunk@31823


git-svn-id: http://core.svn.wordpress.org/trunk@31805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 21:59:27 +00:00
Helen Hou-Sandí 591c4b7d3b List tables: Go back to inserting quick edit rows after, as some plugins rely on that assumption. Results are the same.
fixes #26060.

Built from https://develop.svn.wordpress.org/trunk@31820


git-svn-id: http://core.svn.wordpress.org/trunk@31802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 21:50:27 +00:00
Andrew Ozz 4303ea5379 Press This: prepend the site domain to root-relative URLs. Reject other relative URLs.
Part props stephdau, kraftbj. Fixes #31645.
Built from https://develop.svn.wordpress.org/trunk@31818


git-svn-id: http://core.svn.wordpress.org/trunk@31800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 20:43:27 +00:00
Dominik Schilling c4a624aa22 Customizer: Remove a `throw error` call which prevents further actions, like `jqxhr.always()`.
props westonruter.
fixes #31501.
Built from https://develop.svn.wordpress.org/trunk@31816


git-svn-id: http://core.svn.wordpress.org/trunk@31798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 19:29:27 +00:00
Dominik Schilling 9b79c36713 WP_Filesystem: Change `WP_Filesystem_FTPext::exists()` and `WP_Filesystem_ftpsockets::exists()` to return true for empty directories.
Both methods are using *nlist() which returns a list of files in a given directory or the file itself for a given file. If the result was an empty list we assumed that the file doesn't exists. This includes also cases where $file is actually an empty directory. To prevent this we now check if $file is a directory before returning the result of an empty list.
Other filesystem methods are using `file_exists()` which already checks whether a file or directory exists.

fixes #30815.
Built from https://develop.svn.wordpress.org/trunk@31815


git-svn-id: http://core.svn.wordpress.org/trunk@31797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 19:22:27 +00:00
Aaron Jorbin 2d64637ff8 Request FTP and SSH credentials when needed during shiny updates
This is a restoration of [31749] which was reverted in [31755].

It includes a number of enhancements from the original version.  Namely:
 * Not doing a credential check in src/wp-includes/script-loader.php
 * Add new function `wp_print_request_filesystem_credentials_modal`
 * update the version number in the list table when a plugin is updated

UI still needs further work, but this basic version should enable more testing

Props ericlewis, jorbin
See #31528


Built from https://develop.svn.wordpress.org/trunk@31811


git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
Andrew Ozz f26a2e8113 Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated.
Props kraftbj. Fixes #31639.
Built from https://develop.svn.wordpress.org/trunk@31810


git-svn-id: http://core.svn.wordpress.org/trunk@31792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:51:27 +00:00
Andrew Ozz d63cd35bde Press This: fix editor buttons visibility on mobile.
Props Michael Arestad. Fixes #31622.
Built from https://develop.svn.wordpress.org/trunk@31809


git-svn-id: http://core.svn.wordpress.org/trunk@31791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:25:29 +00:00
Andrew Ozz b00ae388c6 Press This: add `aria-describedby` to the new tag field.
Props afercia. Fixes #31546.
Built from https://develop.svn.wordpress.org/trunk@31808


git-svn-id: http://core.svn.wordpress.org/trunk@31790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:18:27 +00:00
Andrew Ozz 441e1e6ab9 Press This: fix the header styling and add a logo.
Props Michael-Arestad. Fixes #31472.
Built from https://develop.svn.wordpress.org/trunk@31807


git-svn-id: http://core.svn.wordpress.org/trunk@31789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:09:27 +00:00
Andrew Ozz 7d9eee8920 Press This: fix styling on the Tools screen.
Props Michael-Arestad, see #31462.
Built from https://develop.svn.wordpress.org/trunk@31806


git-svn-id: http://core.svn.wordpress.org/trunk@31788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 01:58:27 +00:00
Andrew Ozz acbce27aa9 Press This: fix styling of the "Scan" button. Fixes #31444.
Built from https://develop.svn.wordpress.org/trunk@31805


git-svn-id: http://core.svn.wordpress.org/trunk@31787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 01:40:27 +00:00
Dominik Schilling 9a73d487ee Update `grunt-rtlcss` to 1.6.0.
Changes:
* https://github.com/MohammadYounes/grunt-rtlcss/compare/1.5.1...1.6.0
* https://github.com/MohammadYounes/rtlcss/compare/1.5.1...1.6.1

see #31332.
Built from https://develop.svn.wordpress.org/trunk@31802


git-svn-id: http://core.svn.wordpress.org/trunk@31784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 12:18:33 +00:00
Andrew Ozz c04a1affd1 Press This: bump bookmarklet's version. See #31657.
Built from https://develop.svn.wordpress.org/trunk@31800


git-svn-id: http://core.svn.wordpress.org/trunk@31782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 01:19:27 +00:00
Andrew Ozz 9e1d17ad36 Press This:
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660.
Built from https://develop.svn.wordpress.org/trunk@31799


git-svn-id: http://core.svn.wordpress.org/trunk@31781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 00:47:28 +00:00
Andrew Ozz bf34e504dc Press This: change the Publish button text to Submit for Review for contributors (like on the Edit Post screen).
Props stephdau, DrewAPicture. Fixes #31658.
Built from https://develop.svn.wordpress.org/trunk@31798


git-svn-id: http://core.svn.wordpress.org/trunk@31780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 21:07:27 +00:00
Andrew Ozz c1c29782c9 Press This:
- Test image sizes from JS after Press This loads, before adding them to  "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561.
Built from https://develop.svn.wordpress.org/trunk@31797


git-svn-id: http://core.svn.wordpress.org/trunk@31779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:51:26 +00:00
Andrew Ozz 48ce41f15a Press This: exclude both bookmarklet.js and bookmarklet.min.js from the main uglify task. Props stephdau. Fixes #31657.
Built from https://develop.svn.wordpress.org/trunk@31796


git-svn-id: http://core.svn.wordpress.org/trunk@31778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:37:28 +00:00
Andrew Ozz a7fd4a3774 Emoji:
- Add the styling for the replacement images to the admin CSS.
- Revert to using `.emoji` as replacement image class.
- When pasting in the editor, convert emoji images to our format so we can replace them with chars on saving.
- Some more clean up of both the plugin and wp-emoji.js.
See #31242.
Built from https://develop.svn.wordpress.org/trunk@31786


git-svn-id: http://core.svn.wordpress.org/trunk@31766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-15 23:16:29 +00:00
Andrew Ozz ed7f297579 PressThis: increase the number of meta tags we check in the bookmarklet to 200. Sometimes there are empty meta tag nodes (no attributes) in some browsers.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31778


git-svn-id: http://core.svn.wordpress.org/trunk@31758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-14 20:12:34 +00:00
Sergey Biryukov 2c98f83b70 Remove duplicate label on Add New User screen.
props abhishekfdd.
fixes #31131.
Built from https://develop.svn.wordpress.org/trunk@31777


git-svn-id: http://core.svn.wordpress.org/trunk@31757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-14 01:04:27 +00:00
Sergey Biryukov bc54c02021 Remove hidden `user_id` input from Edit Comment screen.
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31776


git-svn-id: http://core.svn.wordpress.org/trunk@31756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-14 00:53:27 +00:00
Andrew Ozz 634df7e4a4 PressThis: add a wrapped with role = application to the categories section.
Props: afercia. See #31443.
Built from https://develop.svn.wordpress.org/trunk@31775


git-svn-id: http://core.svn.wordpress.org/trunk@31755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 23:41:27 +00:00
Andrew Ozz 5080f1e3af PressThis: improve translatable strings on the Tools screen.
Props: afercia. See #28873.
Built from https://develop.svn.wordpress.org/trunk@31768


git-svn-id: http://core.svn.wordpress.org/trunk@31748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 17:31:28 +00:00
Andrew Ozz 805c530cf0 PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form.
Part prop: Michael-Arestad. Fixes #31443.
Built from https://develop.svn.wordpress.org/trunk@31765


git-svn-id: http://core.svn.wordpress.org/trunk@31745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 16:57:26 +00:00
Dominik Schilling 474f001c42 Revert [31749], see #31528.
Built from https://develop.svn.wordpress.org/trunk@31755


git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 17:51:26 +00:00
Sergey Biryukov 5c9656393a Shiny Updates: Disable body scrolling when filesystem request modal is open.
props ericlewis.
fixes #31607.
Built from https://develop.svn.wordpress.org/trunk@31753


git-svn-id: http://core.svn.wordpress.org/trunk@31734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 14:57:26 +00:00
Sergey Biryukov e8a600ac94 Shiny Updates: Don't translate an error code string.
props ericlewis.
fixes #31606.
Built from https://develop.svn.wordpress.org/trunk@31751


git-svn-id: http://core.svn.wordpress.org/trunk@31732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 13:09:27 +00:00
Gary Pendergast b7546d798f Emoji: Instead of having custom hooks for Ajax callbacks, use MutationObserver to re-parse any changed elements in the DOM.
Props iseulde

See #31242


Built from https://develop.svn.wordpress.org/trunk@31750


git-svn-id: http://core.svn.wordpress.org/trunk@31731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 12:52:26 +00:00
Aaron Jorbin 5b658df402 Request FTP and SSH credentials when needed during shiny updates
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates.  There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates. 

Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528


Built from https://develop.svn.wordpress.org/trunk@31749


git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 08:53:26 +00:00
Helen Hou-Sandí 296dba2804 Nav menus: Return to calling links "Custom Links".
It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI.

props tyxla.
fixes #31344.

Built from https://develop.svn.wordpress.org/trunk@31748


git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 06:15:27 +00:00
Helen Hou-Sandí 593bd1251a Star ratings: Use a yellow color across the board. Keying these to color schemes originally turned out to be weird.
props hugobaeta.
fixes #31424.

Built from https://develop.svn.wordpress.org/trunk@31747


git-svn-id: http://core.svn.wordpress.org/trunk@31728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 05:41:27 +00:00
Andrew Nacin 78679bfb3f Emoji JS cleanup.
* Filename: emoji.js => wp-emoji.js
 * Script handle: emoji => wp-emoji
 * Object: WPEmoji => wp.emoji
 * Script settings: EmojiSettings => _wpemojiSettings
 * Setting key: base_url => baseUrl
 * Remove executable bit from files

see #31242.

Built from https://develop.svn.wordpress.org/trunk@31744


git-svn-id: http://core.svn.wordpress.org/trunk@31725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 03:17:26 +00:00
Sergey Biryukov 93e6326f8c Press This: Remove obsolete help tab in Settings -> Writing.
props kraftbj.
fixes #26794.
Built from https://develop.svn.wordpress.org/trunk@31743


git-svn-id: http://core.svn.wordpress.org/trunk@31724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 02:37:27 +00:00
Sergey Biryukov 9f6cd01346 Fix JSHint errors in [31734] and add missing dependencies.
props iseulde.
fixes #31328.
Built from https://develop.svn.wordpress.org/trunk@31741


git-svn-id: http://core.svn.wordpress.org/trunk@31722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 01:05:26 +00:00
Andrew Ozz 1581ca7092 PressThis: add inline comments and some cleanup for the images and embeds regex.
Props stephdau. Fixes #31373.
Built from https://develop.svn.wordpress.org/trunk@31739


git-svn-id: http://core.svn.wordpress.org/trunk@31720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:37:28 +00:00
Andrew Ozz ce297a7227 PressThis: update _limit_url(), use esc_url_raw(). Fixes checking of urlencoded strings.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31737


git-svn-id: http://core.svn.wordpress.org/trunk@31718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:23:25 +00:00
Dominik Schilling 4cc85f4da2 Administration: Remove single-use URL parameters and create canonical link based on new URL.
The default removable query args are 'message', 'settings-updated', 'saved', 'update', 'updated','activated', 'activate', 'deactivate', 'locked', 'deleted', 'trashed', 'untrashed', 'enabled', 'disabled', and 'skipped'. 

props morganestes.
fixes #23367.
Built from https://develop.svn.wordpress.org/trunk@31736


git-svn-id: http://core.svn.wordpress.org/trunk@31717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:09:26 +00:00
Gary Pendergast 03ade8c011 Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.
Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328


Built from https://develop.svn.wordpress.org/trunk@31734


git-svn-id: http://core.svn.wordpress.org/trunk@31715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 22:55:28 +00:00
John Blackbourn bb99536bf5 Introduce a new algorithm for displaying a hierarchical list of post objects in the `WP_Posts_List_Table`. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages.
Props nofearinc, rodrigosprimo, nacin, johnbillion.
Fixes #15459

Built from https://develop.svn.wordpress.org/trunk@31730


git-svn-id: http://core.svn.wordpress.org/trunk@31711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 20:46:27 +00:00
Andrew Ozz 6e14ff9234 TinyMCE:
- Abstract the code for creating floating toolbars.
- Introduce `editor.wp` namespace to hold exported methods from our plugins.
- Create the wpView toolbar(s) with the new method. This makes them work the same as the image toolbar: shortcuts, esc key, etc.
Props iseulde. See #30619.
Built from https://develop.svn.wordpress.org/trunk@31725


git-svn-id: http://core.svn.wordpress.org/trunk@31706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 19:12:28 +00:00
Andrew Ozz 4eba346517 Allow swiping of the admin menu on touch devices.
Props iseulde, ninnypants. See #31187.
Built from https://develop.svn.wordpress.org/trunk@31720


git-svn-id: http://core.svn.wordpress.org/trunk@31701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 16:29:26 +00:00
Helen Hou-Sandí e5a7fc36d8 Plugin details: Ensure banner image doesn't repeat.
props senff, valendesigns.
fixes #30773.

Built from https://develop.svn.wordpress.org/trunk@31719


git-svn-id: http://core.svn.wordpress.org/trunk@31700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 16:12:26 +00:00
Dominik Schilling 50c2cee32d Merge three similar strings.
props pavelevap.
see #31013.
Built from https://develop.svn.wordpress.org/trunk@31717


git-svn-id: http://core.svn.wordpress.org/trunk@31698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 15:25:28 +00:00
Dominik Schilling 31b7a7a762 Update jQuery UI to 1.11.4.
Changelog:
* https://jqueryui.com/changelog/1.11.4/
* https://github.com/jquery/jquery-ui/compare/1.11.3...1.11.4

props scott.gonzalez for arranging this release.
fixes #31597, #30998.
Built from https://develop.svn.wordpress.org/trunk@31716


git-svn-id: http://core.svn.wordpress.org/trunk@31697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 15:12:27 +00:00
Sergey Biryukov 26f454de3e Restore `<title>` tag on Posts and Pages screens after [31696].
fixes #31349.
Built from https://develop.svn.wordpress.org/trunk@31709


git-svn-id: http://core.svn.wordpress.org/trunk@31690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 00:49:29 +00:00
Dominik Schilling 9250d59e6a Customizer: Prevent a race condition when attempting to publish too soon after updating widget form fields with multiple edits.
props westonruter.
fixes #31501.
Built from https://develop.svn.wordpress.org/trunk@31706


git-svn-id: http://core.svn.wordpress.org/trunk@31687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 22:45:27 +00:00
Dominik Schilling b96a624cb9 Customizer: Fix previewing and applying widgets when previewing another theme.
* Unset `wp_get_sidebars_widgets()`' non-admin cache var `$_wp_sidebars_widgets` in Customize theme preview.
* Add `WP_Customize_Setting::$dirty` so that settings can be initially-dirty when the Customizer loads.
* Mark `old_sidebars_widgets_data` setting initially-dirty.
* Mark all `sidebars_widgets` settings as initially-dirty during theme switch.

props westonruter.
see #31484.
Built from https://develop.svn.wordpress.org/trunk@31705


git-svn-id: http://core.svn.wordpress.org/trunk@31686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 22:39:28 +00:00
Dominik Schilling 2ae3dfa119 Customizer: Add title attributes to iframes.
props afercia.
fixes #31202.
Built from https://develop.svn.wordpress.org/trunk@31704


git-svn-id: http://core.svn.wordpress.org/trunk@31685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 21:20:26 +00:00
Dominik Schilling 286545cad6 Theme Details: Hide admin toolbar on smaller screens.
props obenland.
fixes #31381.
Built from https://develop.svn.wordpress.org/trunk@31702


git-svn-id: http://core.svn.wordpress.org/trunk@31683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 20:04:26 +00:00
Dominik Schilling f9180e1b4b Customizer: Introduce `WP_Customize_Media_Control`.
`WP_Customize_Media_Control` is a new base class for all Customizer media controls. If used directly it supports the ID of an attachment instead of an URL like `WP_Customize_Upload_Control`.

props celloexpressions.
fixes #29215.
Built from https://develop.svn.wordpress.org/trunk@31698


git-svn-id: http://core.svn.wordpress.org/trunk@31679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 18:02:28 +00:00
Dominik Schilling 3349b7d25b Customizer: Add loading indicators for the Customizer preview.
props Fab1en, westonruter.
fixes #31196.
Built from https://develop.svn.wordpress.org/trunk@31697


git-svn-id: http://core.svn.wordpress.org/trunk@31678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 15:56:26 +00:00
Dominik Schilling 13ad2d4e16 Screen Options: Improve items per page option label.
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.
Built from https://develop.svn.wordpress.org/trunk@31696


git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 15:32:27 +00:00
Dominik Schilling 70b7369935 Comments: Fix undefined `$comment_url` variable notice, introduced in [31641].
see #23988.
Built from https://develop.svn.wordpress.org/trunk@31695


git-svn-id: http://core.svn.wordpress.org/trunk@31676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 14:51:26 +00:00
Sergey Biryukov 19f1d4f402 EXIF/IPTC captions should populate Caption (`post_excerpt`) on upload, not Description (`post_content`).
Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set.

props beaulebens, ericlewis, bendoh, SergeyBiryukov.
fixes #22768.
Built from https://develop.svn.wordpress.org/trunk@31694


git-svn-id: http://core.svn.wordpress.org/trunk@31675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 05:07:28 +00:00
Andrew Ozz be24bc3a97 PressThis:
- Filter and select the content on the PHP side. Then pass only the needed data to JS.
- Add the suggested post title and contend directly to the HTML.
- Standardise the data type names.
- Some cleanup/reduction of the code in the bookmarklet.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31693


git-svn-id: http://core.svn.wordpress.org/trunk@31674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 21:49:28 +00:00
Helen Hou-Sandí fe47177a65 Media library: Revert [31582], as it introduces navigation difficulties for many users.
see #30333.

Built from https://develop.svn.wordpress.org/trunk@31692


git-svn-id: http://core.svn.wordpress.org/trunk@31673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 21:17:29 +00:00
Scott Taylor 6ffa051689 Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Built from https://develop.svn.wordpress.org/trunk@31690


git-svn-id: http://core.svn.wordpress.org/trunk@31671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 19:44:26 +00:00
Drew Jaynes 4815bfc2a0 Update hook docs for the `editable_slug` filter as it is evaluated in more than just a term slug context, it is also leveraged for use with post URIs.
See #31569.

Built from https://develop.svn.wordpress.org/trunk@31688


git-svn-id: http://core.svn.wordpress.org/trunk@31669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 07:04:27 +00:00
Dion Hulse 4f7856aabe Fix the editable_slug hook documentation, the PHPDoc must come directly before the hook call, with no HTML inbetween.
Props DrewAPicture. Fixes #31569

Built from https://develop.svn.wordpress.org/trunk@31687


git-svn-id: http://core.svn.wordpress.org/trunk@31668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 06:43:26 +00:00
Dion Hulse 8a9181d8d4 SSH2 Upgrade transport: Trim the trailing newline character from the ouput of `pwd` to avoid a PHP Segfault.
Fixes #30802 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31686


git-svn-id: http://core.svn.wordpress.org/trunk@31667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 04:32:27 +00:00
Scott Taylor 0ec87e4584 There are a few functions that have the ability to return `false` instead of a string, so the return value should be checked before being passed to functions that expect string.
These are trivial, but they clear out some Scrutinizer issues.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31681


git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 02:11:28 +00:00
Andrew Ozz ff5b22b872 PressThis: fix styling of wpLink.
Props Michael-Arestad, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31680


git-svn-id: http://core.svn.wordpress.org/trunk@31661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 23:23:26 +00:00
Scott Taylor dccf5ceb90 Empty `return` statements are unnecessary at the end of functions.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31679


git-svn-id: http://core.svn.wordpress.org/trunk@31660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 23:09:27 +00:00
Boone Gorges 6aff223ffb jshint fixes for press-this.js.
Built from https://develop.svn.wordpress.org/trunk@31677


git-svn-id: http://core.svn.wordpress.org/trunk@31658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 16:27:28 +00:00
Andrew Ozz 7c65a95e4b Fix tagBox init on the Edit Post screen. Props tyxla. Fixes #31558.
Built from https://develop.svn.wordpress.org/trunk@31675


git-svn-id: http://core.svn.wordpress.org/trunk@31656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 04:54:26 +00:00
Jeremy Felt 0f34b98bcf Reveal row actions on focus in the network users list table.
In the future, we'll re-factor this selector pile in a way that makes things cleaner. See #25408.

Props afercia.

Fixes #31003.

Built from https://develop.svn.wordpress.org/trunk@31674


git-svn-id: http://core.svn.wordpress.org/trunk@31655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 02:27:27 +00:00
Jeremy Felt b5b5c98e0a Introduce delete_site meta capability.
Map `delete_site` as a meta capability to `manage_options` so that the ability to delete sites can be more granularly managed for individual site administrators on a multisite network.

Props thomaswm.

Fixes #30470.

Built from https://develop.svn.wordpress.org/trunk@31673


git-svn-id: http://core.svn.wordpress.org/trunk@31654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 02:10:30 +00:00
Scott Taylor c1cab11ceb Use `$this->` instead of `parent::` when calling `tablenav()` in `WP_Theme_Install_List_Table`.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31672


git-svn-id: http://core.svn.wordpress.org/trunk@31653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 23:03:27 +00:00
Dominik Schilling 08f0376f91 Customizer: Add audio/video previews for upload controls.
props celloexpressions, Fab1en, wonderboymusic.
fixes #30850.
Built from https://develop.svn.wordpress.org/trunk@31661


git-svn-id: http://core.svn.wordpress.org/trunk@31642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 11:06:29 +00:00
Jeremy Felt 80d13281ed Return HTTP status code 403 in network admin when access is forbidden.
When the error message "You do not have permission to access this page" is used in network admin screens, return an HTTP status code of 403 to match. Previously: [30356] and [31300].

Props yo-l1982.

Fixes #31422.

Built from https://develop.svn.wordpress.org/trunk@31658


git-svn-id: http://core.svn.wordpress.org/trunk@31639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 06:00:28 +00:00
Jeremy Felt 63ceacb67a Improve experience when deleting users from a multisite network.
When deleting a user who is not associated with any sites, the current messaging can be confusing as only users associated with at least one site actually appear on the confirmation page for deletion.

This experience can be improved by showing all users being deleted as well as their current site associations.

* If an empty array of users is passed, don't attempt to confirm deletion.
* If one user is passed, show a message crafted for a user of one.
* If multiple users are passed, show a message crafted for many.
* Show the pending results of all users to be deleted.
* Update messaging around the deletion/confirmation process to be less misleading.

Props Idealien, HarishChaudhari, DrewAPicture.

Fixes #18132.

Built from https://develop.svn.wordpress.org/trunk@31656


git-svn-id: http://core.svn.wordpress.org/trunk@31637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 04:40:28 +00:00
Andrew Ozz be207e6550 PressThis: make the Preview button "subtle".
See #31458.
Built from https://develop.svn.wordpress.org/trunk@31655


git-svn-id: http://core.svn.wordpress.org/trunk@31636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:50:26 +00:00
Andrew Ozz 9716d171c7 PressThis: add preview functionality. Opens the preview in a new window or a tab next to the source tab.
Fixes #31458.
Built from https://develop.svn.wordpress.org/trunk@31654


git-svn-id: http://core.svn.wordpress.org/trunk@31635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:17:26 +00:00
Andrew Ozz a27967aa05 PressThis:
- Close the sidebar on moving the focus outside of it (by clicking or by "tabbing").
- Fix a (weird) structural CSS problem where clicks go through the sidebar when it is open.
- Clean up the JS a bit.
Fixes #31457.
Built from https://develop.svn.wordpress.org/trunk@31651


git-svn-id: http://core.svn.wordpress.org/trunk@31632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 22:57:26 +00:00
Scott Taylor 6dd747f27c Update `grunt-sass` to `0.18.0`.
Props netweb.
Fixes #31343.

Built from https://develop.svn.wordpress.org/trunk@31648


git-svn-id: http://core.svn.wordpress.org/trunk@31629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 21:05:46 +00:00
Scott Taylor 8f0b626d13 Introduce a function, `wp_attachment_is( $type, $post = 0 )`, to collapse the logic for determining whether an attachment is an `image`, `audio`, or `video`.
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.

Built from https://develop.svn.wordpress.org/trunk@31645


git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 20:26:26 +00:00
Helen Hou-Sandí 7ce4256d4d Comments: Show more identifying information for moderation and editing.
Attempting to moderate comments without context about the post is more difficult than necessary. The comment moderation screen you are sent to via email link was also in need of some better visual treatment.

props thaicloud, seanchayes, adamsilverstein.
see #23988.

Built from https://develop.svn.wordpress.org/trunk@31641


git-svn-id: http://core.svn.wordpress.org/trunk@31622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 14:06:24 +00:00
Andrew Ozz 5abac389fa PressThis: when server-side parsing, filter small images by the width and height attributes if set.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31637


git-svn-id: http://core.svn.wordpress.org/trunk@31618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 02:03:27 +00:00
Andrew Ozz 0ba8fe0132 PressThis: fix toggling of `aria-expanded` attribute.
Props afercia, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31636


git-svn-id: http://core.svn.wordpress.org/trunk@31617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 01:51:25 +00:00
Andrew Ozz bcad925af4 PressThis:
- Fix error when checking for empty array keys.
- Add better DailyMotion embed support.
Props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31635


git-svn-id: http://core.svn.wordpress.org/trunk@31616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 01:17:24 +00:00
Scott Taylor b8341a472d When adding `post_type` to `$sendback` in `wp-admin/post.php`, use `add_query_arg()` instead of string concatenation.
Props podpirate.
Fixes #31492.

Built from https://develop.svn.wordpress.org/trunk@31633


git-svn-id: http://core.svn.wordpress.org/trunk@31614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 22:31:24 +00:00
Scott Taylor da7359b060 After [31620], when checking for HTTP URLs, make sure we are checking the shortcode body instead of an indexed attribute.
See #31139.

Built from https://develop.svn.wordpress.org/trunk@31626


git-svn-id: http://core.svn.wordpress.org/trunk@31607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 16:26:25 +00:00
Scott Taylor f9c138b4c4 `detached` affects the `wp()` call for the media list table, so switch our new `$_GET` key to `detach`.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31624


git-svn-id: http://core.svn.wordpress.org/trunk@31605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 15:59:27 +00:00
Scott Taylor cc953717b7 Allow inline editing of `width` and `height` parameters while previewing an embed in the media modal:
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

This is a first pass to allow broad testing with recent MCE view changes. 

See #31139.

Built from https://develop.svn.wordpress.org/trunk@31620


git-svn-id: http://core.svn.wordpress.org/trunk@31601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 06:00:26 +00:00
Scott Taylor d3471e9850 Allow attachments to be Detached from their parent in media grid and list modes.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31619


git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 05:35:28 +00:00
Andrew Ozz 09ef640af4 PressThis: remove the extra .length tests for strings from press-this.js.
Props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31613


git-svn-id: http://core.svn.wordpress.org/trunk@31594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 21:01:25 +00:00
Helen Hou-Sandí 77f3f6943d Autocomplete: Update CSS based on both jQuery UI and general visual changes.
props rodrigosprimo for the initial patch.
fixes #31427.

Built from https://develop.svn.wordpress.org/trunk@31611


git-svn-id: http://core.svn.wordpress.org/trunk@31592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 20:24:25 +00:00
Helen Hou-Sandí df08581656 List tables: Display front and posts page indicators.
fixes #30190.

Built from https://develop.svn.wordpress.org/trunk@31610


git-svn-id: http://core.svn.wordpress.org/trunk@31591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:45:25 +00:00
Andrew Ozz f53199487d PressThis:
- Improve handling of the data, both from the bookmarklet and from server-side parsing.
- Standardize on processing the data in PHP and remove duplicate code from JS.
- Improve the bookmarklet code and remove pre-filtering of the data.
Part props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31609


git-svn-id: http://core.svn.wordpress.org/trunk@31590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:29:25 +00:00
Helen Hou-Sandí 513a038159 Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.
It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.

Built from https://develop.svn.wordpress.org/trunk@31607


git-svn-id: http://core.svn.wordpress.org/trunk@31588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:53:25 +00:00
Helen Hou-Sandí b201f3a5cb Fix some inline doc typos that were missed in [31604]. see #25698.
Built from https://develop.svn.wordpress.org/trunk@31605


git-svn-id: http://core.svn.wordpress.org/trunk@31586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:18:25 +00:00
Helen Hou-Sandí 5567d03278 Nav menus: Better JS performance on initial load of edit screen.
The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus.

Also simplifies a redundant set of click event handlers down to one, which further enhances performance.

props atimmer, sevenspark.
fixes #25698.

Built from https://develop.svn.wordpress.org/trunk@31604


git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:14:25 +00:00
Sergey Biryukov b8bbd959e2 Themes: Avoid jumping when selecting a feature in the feature filter on Add Themes screen.
props abhishekfdd.
fixes #31497.
Built from https://develop.svn.wordpress.org/trunk@31603


git-svn-id: http://core.svn.wordpress.org/trunk@31584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 19:47:25 +00:00
Andrew Ozz a9f165915f Press This:
- Remove classes from suggested HTML for the editor.
- Improve the filter, pass an associative array as param.
- Use <em> instead of <cite>.
Props Michael-Arestad, kraftbj. Fixes #31493.
Built from https://develop.svn.wordpress.org/trunk@31601


git-svn-id: http://core.svn.wordpress.org/trunk@31582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 23:41:27 +00:00
Drew Jaynes 0b3c3092fc Clean up and refine DocBlocks for a variety of functions and methods in wp-admin/includes/template.php.
* Also documents the default arguments of `wp_terms_checklist()` as a hash notation.

Props ipm-frommen, DrewAPicture.
Fixes #31248.

Built from https://develop.svn.wordpress.org/trunk@31599


git-svn-id: http://core.svn.wordpress.org/trunk@31580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 06:11:40 +00:00
Andrew Ozz acc6c422e2 PressThis: fix and update buttons styles. Props Michael-Arestad. Fixes #31498.
Built from https://develop.svn.wordpress.org/trunk@31598


git-svn-id: http://core.svn.wordpress.org/trunk@31579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 01:18:27 +00:00
Andrew Ozz c22307fd9a PressThis: make sure buttons.css is loaded before press-this.css. Use (int) $post_ID instead of $post->ID.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31597


git-svn-id: http://core.svn.wordpress.org/trunk@31578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 00:58:25 +00:00
Andrew Ozz 3a124ac2f4 PressThis:
- Replace all `%1$s` and `%2$s` in suggestedHTML in case plugins repeat them.
- Fix docs typo, props kraftbj.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31596


git-svn-id: http://core.svn.wordpress.org/trunk@31577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 23:28:26 +00:00
Andrew Ozz 4e8138cea5 PressThis:
- Simplify `getSuggestedContent()` and helpers. No need to override the global `data`.
- Replace the `press_this_source_string` and `press_this_source_link` filters with `press_this_suggested_html` that allows filtering of the link and the wrapper HTML tags.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31595


git-svn-id: http://core.svn.wordpress.org/trunk@31576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 22:44:25 +00:00
Andrew Ozz 5e07bfdfd1 Add `wp.a11y.speak()` for audible alerts/updates in screen readers. Props afercia, GrahamArmfield (for the idea), iseulde. Fixes #31368.
Built from https://develop.svn.wordpress.org/trunk@31594


git-svn-id: http://core.svn.wordpress.org/trunk@31575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 19:11:27 +00:00
Drew Jaynes a337c34c4e Fix a typo in the `$args` parameter hash notation description for `add_settings_field()`.
See #28975, [31592].

Built from https://develop.svn.wordpress.org/trunk@31593


git-svn-id: http://core.svn.wordpress.org/trunk@31574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:57:32 +00:00
Drew Jaynes 82fd5e33dd Add a hash notation for the optional `$args` parameter in `add_settings_field()`, which includes a description for the new `$class` argument added in [31560].
Also adds a changelog entry to `add_settings_field()` DocBlock for the new `$class` argument.

See [31560].
Fixes #28975.

Built from https://develop.svn.wordpress.org/trunk@31592


git-svn-id: http://core.svn.wordpress.org/trunk@31573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:53:25 +00:00
Andrew Ozz 8164f8fe0e PressThis:
- Remove unneeded passing of post formats strings to JS.
- Set the currently selected post format name with jQuery.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31589


git-svn-id: http://core.svn.wordpress.org/trunk@31570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 20:08:27 +00:00
Dominik Schilling 8ecb7f5d1e Press This: Backwards compatibility enhancements.
* Add missing actions for printing styles/scripts.
* Since `$hook_suffix` is null, hardcode `press-this.php`.
* Restore body classes, add filter.
* Use boolean value instead of `__return_false()`.
* Use `wp_json_encode()`.
* Update docs for filters in script-loader.php.
* Make `<a href="%1$s">%2$s</a>` not translatable.

see #31373.
Built from https://develop.svn.wordpress.org/trunk@31588


git-svn-id: http://core.svn.wordpress.org/trunk@31569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 10:36:25 +00:00
Andrew Ozz 0b626ffea2 PressThis: when there is a protocol mismatch (http vs. https), use server-side media detection instead of submitting a form as it triggers "Unsafe data" warning in some browsers. Props stephdau. Fixes #31468.
Built from https://develop.svn.wordpress.org/trunk@31584


git-svn-id: http://core.svn.wordpress.org/trunk@31565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 22:06:25 +00:00
Andrew Ozz 9f86b1023b PressThis: fix selecting a post format (radio buttons) with the keyboard. Props afercia, Michael-Arestad. Fixes #31440.
Built from https://develop.svn.wordpress.org/trunk@31583


git-svn-id: http://core.svn.wordpress.org/trunk@31564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 21:53:25 +00:00
Scott Taylor 39dabbb8b1 When viewing media in List mode, auto-submit the form for attachment filters when the value of a `<select>` changes. This makes it behave similar to Grid mode and "feels" more performant, even though it is a full page load.
Fixes #30333.

Built from https://develop.svn.wordpress.org/trunk@31582


git-svn-id: http://core.svn.wordpress.org/trunk@31563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 21:27:25 +00:00
Dominik Schilling 03a50ce509 Build: Let RTLCSS handle swapping the codes for right/left arrows from Dashicons.
Exclude `wp-includes/css/dashicons.css` from core task since we don't want/need a RTL version of it.

fixes #31478.
Built from https://develop.svn.wordpress.org/trunk@31579


git-svn-id: http://core.svn.wordpress.org/trunk@31560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 20:19:29 +00:00
Dominik Schilling c7dba8b015 Press This: RTL improvements.
* Load the RTL version of press-this-editor.css.
* Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.
Built from https://develop.svn.wordpress.org/trunk@31577


git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:44:24 +00:00
Scott Taylor f6b1b01ecd Make a new function, `wp_delete_file()`. Use it.
Props scribu, wonderboymusic.
Fixes #17864.

Built from https://develop.svn.wordpress.org/trunk@31575


git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 16:51:25 +00:00
Dominik Schilling d2f0abf85f RTL CSS generation: Switch from CSSJanus to RTLCSS.
CSSJanus (introduced in [26107]), we had a great time with you, but sadly you don't like our fancy CSS.

RTLCSS is a framework for converting CSS from LTR to RTL, same as CSSJanus, with support for more CSS properties like `transform`, `transition` or multiple box and text shadows.

Changes:
* devDependencies: Remove `grunt-cssjanus`, add `grunt-rtlcss`.
* RTLCSS uses `/* rtl:ignore */` to ignore a rule, switch existing `/* @noflip */` to the new directive.
* RTLCSS supports the `transform` property, means we can remove some ignore rules.
* RTLCSS supports string maps for custom replace rules. This commit includes a rule `import-rtl-stylesheet` which replaces ".css" with "-rtl.css" in URLs.

Notes for core development:
* The file generation task is still `grunt rtl`.
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Remember the new directive `/* rtl:ignore */`.

fixes #31332.

Build: https://build.trac.wordpress.org/changeset/31554
Built from https://develop.svn.wordpress.org/trunk@31573


git-svn-id: http://core.svn.wordpress.org/trunk@31554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 13:41:30 +00:00
Dominik Schilling 5e47a1f633 Press This: Use boolean value instead of __return_true(). Add missing hook docs.
see #31373.
Built from https://develop.svn.wordpress.org/trunk@31571


git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 11:15:25 +00:00
Dominik Schilling 789cd2e824 Customize Widgets: Don't return undefined items in getWidgetFormControls method.
props westonruter.
fixes #31465.
Built from https://develop.svn.wordpress.org/trunk@31570


git-svn-id: http://core.svn.wordpress.org/trunk@31551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 10:35:24 +00:00
Dominik Schilling 8f44036ea7 Update jQuery UI to 1.11.3.
Changelog:
* http://jqueryui.com/changelog/1.11.3/
* https://github.com/jquery/jquery-ui/compare/1.11.2...1.11.3

fixes #31473.
Built from https://develop.svn.wordpress.org/trunk@31569


git-svn-id: http://core.svn.wordpress.org/trunk@31550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 10:21:26 +00:00
Andrew Ozz 4593319ea7 PressThis: accessibility enhancements:
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449.
Built from https://develop.svn.wordpress.org/trunk@31566


git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 02:50:25 +00:00
Andrew Ozz dd79f77b26 PressThis: enable scrollbars in Firefox, remove overflow-x: hidden from the html element. Part props Michael-Arestad. Fixes #31455.
Built from https://develop.svn.wordpress.org/trunk@31565


git-svn-id: http://core.svn.wordpress.org/trunk@31546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 01:55:26 +00:00
Helen Hou-Sandí 6d03323746 CSS: Move relevant `#sidemenu` rules into `deprecated-media.css` and remove the cruft.
fixes #27956.

Built from https://develop.svn.wordpress.org/trunk@31564


git-svn-id: http://core.svn.wordpress.org/trunk@31545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 23:24:27 +00:00
Scott Taylor a8dcd7aced Persist search terms across grid/list modes:
* In `grid` mode, when the page loads and `s` is in the URL, all attachments are loaded and then the search value is set, which will filter the attachments. If the page loads with the attachments already filtered, the library will have to be requery'd to get the full set, which will require weirder code.
* When a user searches, the mode-switcher link for `list` view is updated dynamically to represent the current `location.href` in the proper `mode=` and `s=` context.

Fixes #30583.

Built from https://develop.svn.wordpress.org/trunk@31562


git-svn-id: http://core.svn.wordpress.org/trunk@31543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 23:01:25 +00:00
Helen Hou-Sandí b95d99d1c1 Settings API: Allow passing a class to `add_settings_field()` via the `$args` array.
While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168.

props valendesigns.
fixes #28975. see #30168.

Built from https://develop.svn.wordpress.org/trunk@31560


git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 19:59:25 +00:00