5b5b756edf
In `get_terms_to_edit()`, call `get_object_term_cache()` before priming cache with `wp_get_object_terms()`.
...
In `get_inline_data()`, do the same.
On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).
Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968 .
Built from https://develop.svn.wordpress.org/trunk@28561
git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 19:29:14 +00:00
8d4d645629
Fix parsing in `wp_match_mime_types()` to allow some mime-types with `+` in them to appear in the list of filter links shown above the list table on `upload.php`.
...
Props _duck.
Fixes #20672 .
Built from https://develop.svn.wordpress.org/trunk@28553
git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 21:36:15 +00:00
d22b5226a8
In `wp_dashboard_recent_posts()`, `$i` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28545
git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:56:15 +00:00
0e03abda62
`$theme_name` is set but no longer used in `wp_dashboard_right_now()`. The theme name is displayed with the call to `update_right_now_message()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28544
git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:54:13 +00:00
b8d469600b
These functions import `$wpdb` but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
219321eedc
Fix inconsistent header underlining and spacing in background update emails.
...
fixes #28306 .
Built from https://develop.svn.wordpress.org/trunk@28537
git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 09:41:15 +00:00
45d5e5d32f
Use correct function name.
...
props ericlewis.
fixes #28329 .
Built from https://develop.svn.wordpress.org/trunk@28535
git-svn-id: http://core.svn.wordpress.org/trunk@28361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 07:59:16 +00:00
7de0b2b2c8
Upgrade `_WP_List_Table_Compat` to PHP5-style constructor.
...
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28531
git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:20:17 +00:00
7415ae10a3
`hackificator` doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28530
git-svn-id: http://core.svn.wordpress.org/trunk@28356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:10:15 +00:00
09ecc213c8
In `WP_Filesystem_Base`, the constructor is a noop, so it shouldn't even be declared. Setting it implies that `parent::__construct()` should be called by its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28529
git-svn-id: http://core.svn.wordpress.org/trunk@28355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 16:46:14 +00:00
85f73cf458
Classes that have `__set()` also need `__isset()` and `__unset()`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28524
git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:52:14 +00:00
821246b4ae
Some classes with `__get()` method also need `__set()`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28521
git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:31:15 +00:00
dfa4de15fa
Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28514
git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:00:15 +00:00
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
511eabe5f3
Improve inline documentation of default arguments for `post_format_meta_box()`, `post_tags_meta_box()`, and `post_categories_meta_box()`.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28499
git-svn-id: http://core.svn.wordpress.org/trunk@28325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 03:23:13 +00:00
130771a383
`hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28497
git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
1383990ae2
Add access modifier (`public`) to methods and members of `WP_Upgrader` and its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28496
git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:29:15 +00:00
58ca85e106
Add access modifier (`public`) to methods and members of `WP_Upgrader_Skin` and its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28495
git-svn-id: http://core.svn.wordpress.org/trunk@28321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:23:15 +00:00
f090ff507d
Add access modifiers to methods and members of `WP_Users_List_Table`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28494
git-svn-id: http://core.svn.wordpress.org/trunk@28320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:19:14 +00:00
d28f6344de
Add access modifiers to methods and members of list table classes:
...
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28493
git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:17:15 +00:00
4e894f05f5
Add access modifier (`public`) to methods in `WP_Importer`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28492
git-svn-id: http://core.svn.wordpress.org/trunk@28318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:19:15 +00:00
d5e35d187f
Add access modifier (`public`) to members and methods in `WP_Filesystem_SSH2`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28491
git-svn-id: http://core.svn.wordpress.org/trunk@28317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:18:14 +00:00
41e1ecdfaf
Add access modifier (`public`) to members and methods in `WP_Filesystem_ftpsockets`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28490
git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:14:14 +00:00
0dbc6b37a7
Add access modifier (`public`) to members and methods in `WP_Filesystem_FTPext`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28489
git-svn-id: http://core.svn.wordpress.org/trunk@28315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:12:15 +00:00
eb750d0bd1
Add access modifier (`public`) to methods in `WP_Filesystem_Direct`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28488
git-svn-id: http://core.svn.wordpress.org/trunk@28314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:09:14 +00:00
7a378bc48f
Add access modifiers to members and methods in `WP_Filesystem_Base`. Add magic `__get()` method for backwards compatibility.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28487
git-svn-id: http://core.svn.wordpress.org/trunk@28313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:06:14 +00:00
e43e775c45
Add access modifier (`public`) to members and methods in `WP_Comments_List_Table` and `WP_Post_Comments_List_Table`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28486
git-svn-id: http://core.svn.wordpress.org/trunk@28312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 23:59:15 +00:00
e917c14144
In `edit-link-form.php`, `hackificator` bails because there is a `</form>` with no open `<form>`. It exists, but is needlessly constructed with PHP. It always returns a `<form>`, only the `id` and `name` are different. The dynamic piece just returns the ID now.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28485
git-svn-id: http://core.svn.wordpress.org/trunk@28311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 22:07:15 +00:00
a659275338
`hackificator` bails on this file because of mixed quote styles on some HTML attributes.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28484
git-svn-id: http://core.svn.wordpress.org/trunk@28310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 21:47:14 +00:00
6a765cdd03
Remove public keyword from some JS functions. Sorry.
...
Props ocean90.
See #22234 .
Built from https://develop.svn.wordpress.org/trunk@28483
git-svn-id: http://core.svn.wordpress.org/trunk@28309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 21:43:14 +00:00
68cfacf9ec
`hackificator` bails on this file because the `<meta>` isn't self-closing.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28482
git-svn-id: http://core.svn.wordpress.org/trunk@28308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 21:36:15 +00:00
2e912d3108
Use proper access modifiers and add a magic `__get()` method to `Custom_Background` and `Custom_Image_Header`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28481
git-svn-id: http://core.svn.wordpress.org/trunk@28307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 21:31:16 +00:00
b9afafffe3
`hackificator` complains if you call `include 'file.php'` without the parens, needs to be `include( 'file.php' )`
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28479
git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:52:15 +00:00
112ca4e055
Because the `WP_ADMIN` constant name can be bound in multiple files, all instances should check `! defined` first. `wp-admin/admin.php` already has this check.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28478
git-svn-id: http://core.svn.wordpress.org/trunk@28305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:42:16 +00:00
fc23dc3551
The About page has a `<div>` that doesn't close. Also, `<hr>`s should self-close. `hackificator` complains about these things.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28477
git-svn-id: http://core.svn.wordpress.org/trunk@28304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:33:15 +00:00
8dacdb77be
Fix wp_insert_link(), broken in [28406]/[28408].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28475
git-svn-id: http://core.svn.wordpress.org/trunk@28302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 09:56:15 +00:00
d75ca7aaaf
Add inline documentation for default arguments in `wp_insert_category()`.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28474
git-svn-id: http://core.svn.wordpress.org/trunk@28301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 07:28:14 +00:00
c453340a49
Update help text on Add Themes screen.
...
props thomasvanderbeek.
fixes #28132 .
Built from https://develop.svn.wordpress.org/trunk@28473
git-svn-id: http://core.svn.wordpress.org/trunk@28300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 23:44:15 +00:00
4ce9706db1
Add inline comment after fix in [28467].
...
Props jesin.
Fixes #28292 .
Built from https://develop.svn.wordpress.org/trunk@28468
git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:42:14 +00:00
bdd1ae2fc7
Restore `$soucrce` in `WP_Upgrader::install_package()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28467
git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:40:15 +00:00
8eb9f2ffe4
Eliminate use of `extract()` in `request_filesystem_credentials()`.
...
The only property that doesn't need to be set to a variable is `$password`.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28456
git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:26:15 +00:00
f184243aa3
DFW: fix closing only the wpLink or media modal when pressing Esc.
...
Built from https://develop.svn.wordpress.org/trunk@28455
git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:17:14 +00:00
39de969bf2
Update inline docs for `wp_handle_upload|sideload` to reflect their non-use of `extract()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28452
git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 17:41:16 +00:00
632eb5b17e
Eliminate use of `extract()` in `wp_handle_sideload()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28451
git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 16:15:14 +00:00
4caf3e79f3
Eliminate use of `extract()` in `wp_handle_upload()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28450
git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 16:10:38 +00:00
abc830ca9d
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
Built from https://develop.svn.wordpress.org/trunk@28443
git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 10:43:14 +00:00
b2d1e73fd5
Eliminate the use of `extract()` in `WP_Upgrader`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28418
git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:02:14 +00:00
d74272ecf5
Eliminate one of the uses of `extract()` in `wp_handle_upload()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28417
git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:31:14 +00:00
fc59804352
Eliminate one of the uses of `extract()` in `wp_handle_sideload()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28416
git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:29:15 +00:00
a7a6cb5bef
Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28411
git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:14:14 +00:00
7ebab48f4c
Eliminate use of `extract()` in `wp_terms_checklist()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28410
git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:09:15 +00:00
a75f8137bc
Eliminate use of `extract()` in `wp_star_rating()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28409
git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:57:14 +00:00
ff665b2f38
(REALLY) Eliminate use of `extract()` in `wp_insert_link()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28408
git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:55:16 +00:00
54321f4c6e
Eliminate use of `extract()` in `get_media_item()`.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
5f06d0f50a
Eliminate use of `extract()` in `wp_insert_link()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28406
git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:28:14 +00:00
1121efb54c
Eliminate use of `extract()` in `display_setup_form()`. Only needs to read `password` and `password_message`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28396
git-svn-id: http://core.svn.wordpress.org/trunk@28224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-14 16:43:15 +00:00
a23cc5634f
Properly split and document the `admin_post*` actions into the following four hooks:
...
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action
See [28349], [28350], [28351].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28394
git-svn-id: http://core.svn.wordpress.org/trunk@28222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 07:24:15 +00:00
40a738c21c
Clarify inline documentation for back-compat `load-*` action hooks.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28393
git-svn-id: http://core.svn.wordpress.org/trunk@28221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 06:28:15 +00:00
fd9abeb0f9
Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`.
...
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28391
git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:48:17 +00:00
9476cd33a3
Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`:
...
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28390
git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:37:14 +00:00
aef35fe6a2
Eliminate use of `extract()` in `WP_List_Table::pagination()`:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28389
git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:27:14 +00:00
530a107ec9
Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28388
git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:17:14 +00:00
192e235672
Eliminate use of `extract()` in `WP_List_Table::ajax_response()`:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28387
git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:14:14 +00:00
08d73b9e23
Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28386
git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:08:13 +00:00
f617b8669a
Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28385
git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:04:14 +00:00
4c60b2e207
Eliminate use of `extract()` in `Custom_Image_Header::step_2()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28384
git-svn-id: http://core.svn.wordpress.org/trunk@28212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:54:14 +00:00
ec88da1ee3
Clarify documentation for *what* gets "automatically fired" when the `do_mu_upgrade` filter evaluates to true in Multisite.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28376
git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:18:14 +00:00
b4ca72583a
Fix incomplete inline documentation for the `wp_header_image_attachment_metadata` filter.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28375
git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:13:15 +00:00
6bbc5b570c
Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass.
...
Props MikeHansenMe.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28374
git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 03:27:13 +00:00
2bea9fcc0b
In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
Built from https://develop.svn.wordpress.org/trunk@28368
git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
88b96dc036
In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty.
...
Props SergeyBiryukov.
Fixes #23706 .
Built from https://develop.svn.wordpress.org/trunk@28367
git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 05:54:15 +00:00
e9f87b2688
Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it.
...
Props MikeHansenMe.
Fixes #17736 .
Built from https://develop.svn.wordpress.org/trunk@28366
git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 03:42:14 +00:00
0b6729c3f9
In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`).
...
Props oso96_2000, c3mdigital, scribu.
It takes a village.
Fixes #16864 .
Built from https://develop.svn.wordpress.org/trunk@28360
git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:05:15 +00:00
f22beb987c
First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
Built from https://develop.svn.wordpress.org/trunk@28358
git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:36:18 +00:00
81cfb9427a
Fix mid-file section header style in wp-admin/includes/ajax-actions.php.
...
See #28200 .
Built from https://develop.svn.wordpress.org/trunk@28356
git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:02:13 +00:00
0ef7244ce7
Add baseline doc blocks for all ajax handlers in ajax-actions.php.
...
Fixes #28200 .
Built from https://develop.svn.wordpress.org/trunk@28355
git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:00:19 +00:00
f609524261
Minor phpDoc fixes for the `got_rewrite`, `got_url_rewrite`, and `documentation_ignore_functions` hooks.
...
Props GaryJ.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28352
git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:13:14 +00:00
c02696f43f
Rename the `$action` hook in wp-admin/admin-post.php to `admin_post{$action}`.
...
Also, clarify documentation of priv vs nopriv prefixing of the hook name.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28351
git-svn-id: http://core.svn.wordpress.org/trunk@28179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:00:15 +00:00
f427187fa8
Revert [28349] in favor of retaining the single dynamic `admin_post*` hook.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28350
git-svn-id: http://core.svn.wordpress.org/trunk@28178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:47:15 +00:00
a6755201d8
Convert and rename the `$action` hook in wp-admin/admin-post to two dynamic hook sets.
...
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users
Props Otto42, DrewAPicture.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28349
git-svn-id: http://core.svn.wordpress.org/trunk@28177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:27:14 +00:00
32e674f44e
Use interpolation instead of concatenation for the `manage_{$screen->id}_columns` hook name.
...
Props Otto42.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28348
git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 09:58:14 +00:00
8906f83802
Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly.
...
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.
Props Otto42 for the initial patch.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28347
git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 08:16:15 +00:00
1daa7d6723
Leverage `size_format()` when displaying `max_upload_size`:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
Built from https://develop.svn.wordpress.org/trunk@28343
git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
5f27d149a3
In `wp-admin/users.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28315
git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:19:14 +00:00
402d8b80fb
In `core_upgrade_preamble()`, `$alternate` is set then never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28314
git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:17:18 +00:00
e9bb9c0f12
In `wp-admin/theme-editor.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28313
git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:16:26 +00:00
517dbfaa21
In `wp-admin/post.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28312
git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:15:15 +00:00
327b38f298
In `wp-admin/plugins.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28311
git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:13:14 +00:00
ac63c66c5a
In `wp-admin/plugin-editor.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28310
git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:12:14 +00:00
0f8fb8a148
In `wp-admin/network/users.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28309
git-svn-id: http://core.svn.wordpress.org/trunk@28137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:11:14 +00:00
64418c0192
In `wp-admin/network/themes.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28308
git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:08:14 +00:00
f5d23b82bd
In `wp-admin/link.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28307
git-svn-id: http://core.svn.wordpress.org/trunk@28135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:06:14 +00:00
213a7de0b7
In `display_setup_form()`, `$admin_password` is set and (fortunately) not used or displayed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28306
git-svn-id: http://core.svn.wordpress.org/trunk@28134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:04:15 +00:00
c2d44c5736
In `wp-admin/includes/upgrade.php`, remove dead code:
...
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28305
git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:27:15 +00:00
aaa3eb07ad
In `wp-admin/includes/update.php`, remove dead code:
...
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28304
git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:21:14 +00:00
b80cda5d17
In `WP_Screen::render_screen_options()`, remove dead code:
...
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28303
git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:14:15 +00:00
2e417f0ca4
In `get_sample_permalink_html()`, `$view_link` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28302
git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:11:14 +00:00
44e2d48a3c
In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28301
git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:00:18 +00:00
e57fa7300d
In `wp-admin/includes/nav-menu.php`, remove dead code:
...
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it.
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28300
git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:55:14 +00:00
85bdc64173
In `update_option_new_admin_email()`, `$email` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28299
git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:48:14 +00:00
6066f85853
In `attachment_submit_meta_box()`, remove dead code:
...
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28298
git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:45:14 +00:00
71ac0f21c2
In `get_media_item()`, `$tags` and `$_tags` are set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28297
git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
3054b924a3
In `WP_Users_List_Table::get_views()`, `$current_role` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28296
git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:33:15 +00:00
209f008d77
In `WP_MS_Users_List_Table::get_views()`, remove dead code:
...
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28295
git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:30:14 +00:00
f7539feb4d
Custom Header: Fix logic when a theme doesn't set `default-text-color`.
...
fixes #28042 .
Built from https://develop.svn.wordpress.org/trunk@28294
git-svn-id: http://core.svn.wordpress.org/trunk@28122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:54 +00:00
970477d25e
In `WP_Media_List_Table`, remove dead code:
...
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28293
git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:33 +00:00
28d98a89f3
In `ajax-actions.php`, remove dead code:
...
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28292
git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:19:14 +00:00
d433f8f1ed
Remove unreachable `break` statements in `wp-admin/edit-tags.php`. `break` is unnecessary after `die`, `exit`, and `wp_die`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28291
git-svn-id: http://core.svn.wordpress.org/trunk@28119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:52:16 +00:00
d3dd9916d8
In `wp-admin/custom-header.php`, `$default_color` is set twice before it is used. The first is unnecessary.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28290
git-svn-id: http://core.svn.wordpress.org/trunk@28118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:51:19 +00:00
97e6942e4a
Remove unreachable `break` statements in `wp-admin/comments.php`. `break` is unnecessary after `die`, `exit`, and `wp_die`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28289
git-svn-id: http://core.svn.wordpress.org/trunk@28117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:46:16 +00:00
10ab8b1055
Translate a string added in 3.7 but never translated previously.
...
props andrezrv.
fixes #28025 .
Built from https://develop.svn.wordpress.org/trunk@28288
git-svn-id: http://core.svn.wordpress.org/trunk@28116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:49:15 +00:00
527a1ea6e3
Use a consistent context to remove duplicate strings.
...
props pavelevap.
fixes #28123 .
Built from https://develop.svn.wordpress.org/trunk@28287
git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:34:14 +00:00
28cafbb868
Add context for 'Previous' and 'Next' theme strings.
...
see #28120 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28286
git-svn-id: http://core.svn.wordpress.org/trunk@28114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:20:14 +00:00
8b72aebdaa
Add missing Dashicons classes to User Admin menu.
...
props imath.
see #28144 , #26630 .
Built from https://develop.svn.wordpress.org/trunk@28284
git-svn-id: http://core.svn.wordpress.org/trunk@28112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 07:58:15 +00:00
ded4871368
In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28279
git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:15 +00:00
7509795517
Custom header: Avoid warnings in the process_default_headers() method.
...
props obenland.
fixes #27850 .
Built from https://develop.svn.wordpress.org/trunk@28275
git-svn-id: http://core.svn.wordpress.org/trunk@28103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:07:13 +00:00
dd73ad4299
In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28271
git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
962e8113ab
Customizer: Only tie header button action events to the header controls.
...
props danielbachhuber.
fixes #28046 . see #27848 .
Built from https://develop.svn.wordpress.org/trunk@28269
git-svn-id: http://core.svn.wordpress.org/trunk@28097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:30:23 +00:00
644024dfc4
Dead code in `wp-admin/includes/file.php`:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28268
git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:22:14 +00:00
3d7a4e6798
Remove unused variable setting for `$revisions` in `wp_prepare_revisions_for_js()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28264
git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:45:14 +00:00
21379dcde0
Remove a dead variable, `$start`, from `wp_dashboard_recent_comments()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28263
git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:35:14 +00:00
f44e4226fa
Move 'home' option to the top of populate_options().
...
fixes #28141 .
Built from https://develop.svn.wordpress.org/trunk@28260
git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 21:57:14 +00:00
751e624ff7
Deprecate unused argument of delete_plugins(). Clarify @return value.
...
props jdgrimes for initial patch.
fixes #28111 .
Built from https://develop.svn.wordpress.org/trunk@28256
git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:24:15 +00:00
13cbcc92cf
Fix closing tag in image editor.
...
props t4k1s.
fixes #28130 .
Built from https://develop.svn.wordpress.org/trunk@28255
git-svn-id: http://core.svn.wordpress.org/trunk@28083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:17:19 +00:00
db4423c5cd
Avoid displaying a negative number of plugin updates in admin menu.
...
fixes #28073 .
Built from https://develop.svn.wordpress.org/trunk@28254
git-svn-id: http://core.svn.wordpress.org/trunk@28082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 09:39:17 +00:00
997cbaa03c
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
Built from https://develop.svn.wordpress.org/trunk@28253
git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 08:26:24 +00:00
e6644720f9
Color Picker: Close color picker when clicking outside of them and when opening another one.
...
props mattwiebe.
fixes #25539 .
Built from https://develop.svn.wordpress.org/trunk@28239
git-svn-id: http://core.svn.wordpress.org/trunk@28067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:18:15 +00:00
8e7e53b22e
Widgets: Toggle widget arrow when widget is open/closed.
...
props MikeHansenMe.
fixes #26748 .
Built from https://develop.svn.wordpress.org/trunk@28235
git-svn-id: http://core.svn.wordpress.org/trunk@28063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 14:09:16 +00:00
a0086bd102
Quick Draft: Use text cursor for description label.
...
fixes #27766 .
Built from https://develop.svn.wordpress.org/trunk@28234
git-svn-id: http://core.svn.wordpress.org/trunk@28062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 13:12:16 +00:00
058ff61dec
Mark the `$hook` and `$page_hook` hooks as `@internal` to skip parsing.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28216
git-svn-id: http://core.svn.wordpress.org/trunk@28046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:54:21 +00:00
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
029dd247be
Ensure the `wp_edit_nav_menu_walker` filter is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28213
git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:50:15 +00:00
ef643d9136
Ensure all duplicate calls of the `wp_create_file_in_uploads` filter are labeled as such.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28212
git-svn-id: http://core.svn.wordpress.org/trunk@28042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:46:19 +00:00
a866838b31
Ensure adjacency of a duplicate hook comment for a `the_category` filter call.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28211
git-svn-id: http://core.svn.wordpress.org/trunk@28041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:43:16 +00:00
73c851c227
Ensure the `submitlink_box` action hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28210
git-svn-id: http://core.svn.wordpress.org/trunk@28040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:34:15 +00:00
a9b74e2088
Ensure the `nav_menu_meta_box_object` filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28207
git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:14:15 +00:00
a43313fe12
Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
...
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205
git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 00:35:25 +00:00
46bdcce0eb
Ensure the editor height is saved properly, props jupiterwise, see #28000 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28193
git-svn-id: http://core.svn.wordpress.org/trunk@28023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 04:11:15 +00:00
571353164f
Fix cursor style for the resize handle of the editor, props avryl, see #27595 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28186
git-svn-id: http://core.svn.wordpress.org/trunk@28017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-22 21:48:15 +00:00
be7a2513cf
Don't allow disabled input styling to get lost in the cascade. props ocean90. see #27906 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28179
git-svn-id: http://core.svn.wordpress.org/trunk@28010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-21 20:55:15 +00:00
51cf3e9f9a
Simplify the admin menu notification selector so color schemes don't get stomped. props celloexpressions. see #27920 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28177
git-svn-id: http://core.svn.wordpress.org/trunk@28008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-21 18:55:16 +00:00
b89775445e
Theme Installer: Proper redirection and action links post-install in multisite.
...
fixes #27869 .
Built from https://develop.svn.wordpress.org/trunk@28163
git-svn-id: http://core.svn.wordpress.org/trunk@27994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:18:16 +00:00
cd6b973b54
Use correct echoing context function. see #27889 .
...
Built from https://develop.svn.wordpress.org/trunk@28160
git-svn-id: http://core.svn.wordpress.org/trunk@27991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:09:16 +00:00
3a9851d0fa
Context for 'Installed' and 'Already Installed' theme strings.
...
props SergeyBiryukov.
see #27889 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28159
git-svn-id: http://core.svn.wordpress.org/trunk@27990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:08:17 +00:00
b0f672d552
About page: Don't use wp_playlist_scripts() as that prints stuff.
...
fixes #27713 .
Built from https://develop.svn.wordpress.org/trunk@28151
git-svn-id: http://core.svn.wordpress.org/trunk@27982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 17:55:15 +00:00
e3a4c57563
Final about page.
...
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713 , #27837 .
Built from https://develop.svn.wordpress.org/trunk@28150
git-svn-id: http://core.svn.wordpress.org/trunk@27981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 17:40:14 +00:00
dd8531a3b3
Widgets: Better padding for translations of "Reorder".
...
fixes #27788 .
Built from https://develop.svn.wordpress.org/trunk@28148
git-svn-id: http://core.svn.wordpress.org/trunk@27979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 13:07:16 +00:00
f5c0ad0115
Theme Installer: Properly call router navigation.
...
props gcorne.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28147
git-svn-id: http://core.svn.wordpress.org/trunk@27978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 03:06:16 +00:00
e23f57ec56
About page: Use a better preposition to describe drag-and-drop.
...
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28146
git-svn-id: http://core.svn.wordpress.org/trunk@27977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:46:14 +00:00
2bc282957c
Translate a string added in 3.7.1 but never translated previously.
...
props SergeyBiryukov.
fixes #27819 .
Built from https://develop.svn.wordpress.org/trunk@28145
git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:38:14 +00:00
dbca0c5e15
Widgets: Remove create_function() from the customizer class.
...
props westonruter.
fixes #27805 .
Built from https://develop.svn.wordpress.org/trunk@28143
git-svn-id: http://core.svn.wordpress.org/trunk@27974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:11:35 +00:00
55e3a1101a
TinyMCE: fix icons in IE7, fixes #27829
...
Built from https://develop.svn.wordpress.org/trunk@28142
git-svn-id: http://core.svn.wordpress.org/trunk@27973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:10:14 +00:00
d46037e0b5
Theme Installer: Fixes for browsers without pushState.
...
props gcorne.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28141
git-svn-id: http://core.svn.wordpress.org/trunk@27972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:04:15 +00:00
ca0b5c9859
Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815
...
Built from https://develop.svn.wordpress.org/trunk@28137
git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 10:57:14 +00:00
03d953d963
Fix entities on about page. see #27713 .
...
Built from https://develop.svn.wordpress.org/trunk@28136
git-svn-id: http://core.svn.wordpress.org/trunk@27967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 09:22:14 +00:00
fa3900168e
Allow the API to add text to auto update emails.
...
fixes #27812 .
Built from https://develop.svn.wordpress.org/trunk@28134
git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 08:52:15 +00:00
82da8e9b0b
Fix typo on about page.
...
props helen.
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28133
git-svn-id: http://core.svn.wordpress.org/trunk@27964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 08:26:15 +00:00
4a0ae35eb1
Final about page text.
...
props siobhan, kerikae, DH-Shredder, nacin.
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28132
git-svn-id: http://core.svn.wordpress.org/trunk@27963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 07:53:14 +00:00
86daa61c45
About page design, first pass.
...
props melchoyce, ryelle.
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28127
git-svn-id: http://core.svn.wordpress.org/trunk@27958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:31:14 +00:00
9f81d0526e
Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
...
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639 , #27581 , #27055 ).
A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.
props ocean90.
fixes #27798 .
Built from https://develop.svn.wordpress.org/trunk@28126
git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:16:14 +00:00
6b579e0d59
Customizer: Properly handle widget settings when activating a previewed theme.
...
props westonruter, ocean90, gcorne.
fixes #27767 .
Built from https://develop.svn.wordpress.org/trunk@28124
git-svn-id: http://core.svn.wordpress.org/trunk@27955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 22:46:16 +00:00
f911d99902
Theme installer: Improve route handling and make ?theme= work.
...
props matveb.
fixes #27708 .
Built from https://develop.svn.wordpress.org/trunk@28123
git-svn-id: http://core.svn.wordpress.org/trunk@27954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 22:06:15 +00:00
77e2da21cf
Color scheme support for widget choosers.
...
props ocean90.
fixes #27793 .
Built from https://develop.svn.wordpress.org/trunk@28122
git-svn-id: http://core.svn.wordpress.org/trunk@27953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 20:22:14 +00:00
3de93ccba3
DFW:
...
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709
Built from https://develop.svn.wordpress.org/trunk@28116
git-svn-id: http://core.svn.wordpress.org/trunk@27947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 08:15:16 +00:00
cb4eb9c13f
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
Reverts [27990] which did not fix it for authors and comment/ping status.
props dd32, DrewAPicture.
fixes #27792 .
Built from https://develop.svn.wordpress.org/trunk@28113
git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 07:48:14 +00:00
c9f5ed0801
Plupload: restore the settings in media_upload_form(), see #27763
...
Built from https://develop.svn.wordpress.org/trunk@28110
git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:41:15 +00:00
55b0cd935e
Fix feature pointer RTL placement.
...
props SergeyBiryukov, ocean90.
fixes #27778 .
Built from https://develop.svn.wordpress.org/trunk@28107
git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:00:14 +00:00
cd5f8d517c
Theme install: Set a timeout and error message for API responses.
...
props ocean90.
fixes #27708 .
Built from https://develop.svn.wordpress.org/trunk@28105
git-svn-id: http://core.svn.wordpress.org/trunk@27936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 19:02:14 +00:00
6fc0120e20
Themes screen: Fix RTL layout issue in Firefox.
...
props SergeyBiryukov.
fixes #27779 .
Built from https://develop.svn.wordpress.org/trunk@28104
git-svn-id: http://core.svn.wordpress.org/trunk@27935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 18:26:15 +00:00
c593fe63d3
Don't auto-resize Quick Draft textarea in IE < 9. Avoids IE8 crash.
...
props morganestes.
fixes #27761 .
Built from https://develop.svn.wordpress.org/trunk@28103
git-svn-id: http://core.svn.wordpress.org/trunk@27934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 18:25:15 +00:00
a2924c6be0
Custom header: Fix image ordering.
...
props ehg.
see #21785 . fixes #27791 .
Built from https://develop.svn.wordpress.org/trunk@28102
git-svn-id: http://core.svn.wordpress.org/trunk@27933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 18:22:14 +00:00
e77dc6b97b
Fix feature pointer border when using a color scheme.
...
props ryelle.
see #27778 .
Built from https://develop.svn.wordpress.org/trunk@28098
git-svn-id: http://core.svn.wordpress.org/trunk@27929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 16:33:14 +00:00
41d2a7f82b
RTL for login screen.
...
props yoavf.
fixes #27784 .
Built from https://develop.svn.wordpress.org/trunk@28096
git-svn-id: http://core.svn.wordpress.org/trunk@27927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 16:06:14 +00:00
eca26bc5ae
The widgets pointer requires the edit_theme_options capability.
...
(It's hypothetically possible to have only switch_themes.)
see #27777 .
Built from https://develop.svn.wordpress.org/trunk@28093
git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 20:53:15 +00:00
826d79d572
Translate another About string and use _e(). see #27713 .
...
Built from https://develop.svn.wordpress.org/trunk@28092
git-svn-id: http://core.svn.wordpress.org/trunk@27923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 20:52:14 +00:00
497b0df4a5
Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4.
...
see #27777 .
Built from https://develop.svn.wordpress.org/trunk@28090
git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 20:48:15 +00:00
da29181acd
About page: Translate all Under the Hood strings.
...
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28088
git-svn-id: http://core.svn.wordpress.org/trunk@27919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 19:39:15 +00:00
d50e4bc08c
Custom Headers: Allow for longer strings.
...
props ehg.
see #27755 .
Built from https://develop.svn.wordpress.org/trunk@28086
git-svn-id: http://core.svn.wordpress.org/trunk@27917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 18:40:14 +00:00
c87ac82d7b
Update $_old_files for 3.9. see #27775 .
...
Built from https://develop.svn.wordpress.org/trunk@28085
git-svn-id: http://core.svn.wordpress.org/trunk@27916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 18:27:17 +00:00
5e51ea9940
Priority fixes for various existing hook documentation.
...
Props kpdesign.
See #26869
Built from https://develop.svn.wordpress.org/trunk@28083
git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
3ddc52b236
Add the new modlas styling to the importer details Thickbox on Tools -> Import. Props ocean90, fixes #26952
...
Built from https://develop.svn.wordpress.org/trunk@28080
git-svn-id: http://core.svn.wordpress.org/trunk@27911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 21:50:15 +00:00
a32f0dcd4c
Fix color of disabled buttons in non-default color schemes, props ryelle, fixes #27759
...
Built from https://develop.svn.wordpress.org/trunk@28079
git-svn-id: http://core.svn.wordpress.org/trunk@27910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 21:35:17 +00:00
51412f2e9b
Account for new cropping settings in the image editor.
...
props Otto42, SergeyBiryukov.
fixes #19393 .
Built from https://develop.svn.wordpress.org/trunk@28072
git-svn-id: http://core.svn.wordpress.org/trunk@27903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 03:10:14 +00:00
dea2eaa1e3
Fix typo in var definition in [28069], see #27750
...
Built from https://develop.svn.wordpress.org/trunk@28070
git-svn-id: http://core.svn.wordpress.org/trunk@27901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-10 22:14:15 +00:00
8072976c06
Fix tabbing out of the title field on Media -> Edit Media screen, fixes #27750
...
Built from https://develop.svn.wordpress.org/trunk@28069
git-svn-id: http://core.svn.wordpress.org/trunk@27900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-10 22:10:15 +00:00
cc694bac21
Fix TinyMCE Views in IE8 and 7:
...
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546
Built from https://develop.svn.wordpress.org/trunk@28062
git-svn-id: http://core.svn.wordpress.org/trunk@27894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-09 00:58:15 +00:00
5fa5b037ec
3.9 about page text, rough cut.
...
props markjaquith, nacin.
see #27713 .
Built from https://develop.svn.wordpress.org/trunk@28052
git-svn-id: http://core.svn.wordpress.org/trunk@27882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 17:47:15 +00:00
e8da400c69
Don't show featured images for image attachments. Remove abstractions for now.
...
fixes #27673 .
Built from https://develop.svn.wordpress.org/trunk@28051
git-svn-id: http://core.svn.wordpress.org/trunk@27881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 17:40:28 +00:00
b631825414
Theme installer keyboard fixes. Updates [28033] and [28036].
...
props matveb.
see #27521 .
Built from https://develop.svn.wordpress.org/trunk@28049
git-svn-id: http://core.svn.wordpress.org/trunk@27879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 16:24:14 +00:00
f2d874e3db
Theme Installer: Prevent default events for "Upload Theme" and "Browse" buttons.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28047
git-svn-id: http://core.svn.wordpress.org/trunk@27877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 12:35:18 +00:00
fd0ae7e406
Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055 , #26907 , #16284
...
Built from https://develop.svn.wordpress.org/trunk@28045
git-svn-id: http://core.svn.wordpress.org/trunk@27875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 08:29:14 +00:00
3f3a1380d2
Widget Customizer: Fix widget filtering.
...
props westonruter.
fixes #27451 .
Built from https://develop.svn.wordpress.org/trunk@28044
git-svn-id: http://core.svn.wordpress.org/trunk@27874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 08:12:15 +00:00
268092761d
DFW:
...
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907 , see #27709
Built from https://develop.svn.wordpress.org/trunk@28043
git-svn-id: http://core.svn.wordpress.org/trunk@27873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 07:49:14 +00:00
252a5434ff
Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php.
...
Fixes #27711 .
Built from https://develop.svn.wordpress.org/trunk@28040
git-svn-id: http://core.svn.wordpress.org/trunk@27870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 06:26:16 +00:00
9a82e9070e
Theme Installer: Show 'Preview' button for installed themes.
...
props adamsilverstein.
see #27055 , see #27708 .
Built from https://develop.svn.wordpress.org/trunk@28038
git-svn-id: http://core.svn.wordpress.org/trunk@27868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:38:15 +00:00
e7fc009f7c
Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28037
git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:30:15 +00:00
640d9cb1a1
Theme Installer: Left/right arrow keys in the overlay.
...
props adamsilverstein.
see #27521 .
Built from https://develop.svn.wordpress.org/trunk@28036
git-svn-id: http://core.svn.wordpress.org/trunk@27866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:13:30 +00:00
93d2e831cb
Theme Installer: Use 'browse' instead of 'sort' for routes.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28035
git-svn-id: http://core.svn.wordpress.org/trunk@27865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:13:16 +00:00
5ea061ef8d
Widget Customizer: Fix incorrect replacement in [27995].
...
props westonruter.
fixes #27690 .
Built from https://develop.svn.wordpress.org/trunk@28034
git-svn-id: http://core.svn.wordpress.org/trunk@27864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:03:14 +00:00
658032c9f9
Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs.
...
props adamsilverstein, DH-Shredder.
fixes #27521 .
Built from https://develop.svn.wordpress.org/trunk@28033
git-svn-id: http://core.svn.wordpress.org/trunk@27863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 03:57:15 +00:00
c870767d98
Header Images: Add suggested dimensions to the media workflow.
...
This updates [28030] to the latest patch.
props gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@28031
git-svn-id: http://core.svn.wordpress.org/trunk@27861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:57:16 +00:00
6b41f728d4
Header Images: Add suggested dimensions to the media workflow.
...
props ehg, gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@28030
git-svn-id: http://core.svn.wordpress.org/trunk@27860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:55:15 +00:00
131c940cf8
Expose toolbar keyboard shortcut in Help documentation for TinyMCE.
...
props joedolson, jorbin.
fixes #27024 .
Built from https://develop.svn.wordpress.org/trunk@28029
git-svn-id: http://core.svn.wordpress.org/trunk@27859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:39:14 +00:00
56c1deba7c
Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections.
...
props matveb.
see #27055 . fixes #27695 .
Built from https://develop.svn.wordpress.org/trunk@28025
git-svn-id: http://core.svn.wordpress.org/trunk@27855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 23:04:15 +00:00
418aa98588
Widget Customizer: Update icons to new Dashicons, part 2.
...
props Michael Arestad.
fixes #27400 .
Built from https://develop.svn.wordpress.org/trunk@28013
git-svn-id: http://core.svn.wordpress.org/trunk@27843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 21:37:14 +00:00
382a5aa4c2
Widget Customizer: Update icons to new Dashicons.
...
props melchoyce.
see #27400 .
Built from https://develop.svn.wordpress.org/trunk@28005
git-svn-id: http://core.svn.wordpress.org/trunk@27835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:50:15 +00:00
f6df2c6921
Use the correct parameter variables in the hook docs for `wp_upgrade`.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27998
git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:13:15 +00:00
181fe84d47
Align parameters in the hook docs for the `attachment_thumbnail_args` filter.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27997
git-svn-id: http://core.svn.wordpress.org/trunk@27827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:10:16 +00:00
bf75eebfa7
Add missing parameter descriptions to the PHPDocs for `WP_Upgrader_Skin::decrement_update_count()` and `Bulk_Upgrader_Skin::decrement_update_count()`.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27996
git-svn-id: http://core.svn.wordpress.org/trunk@27826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:02:15 +00:00
f69f3d3d18
Widget Customizer: Cleanup `wp.customize.Widgets.SidebarControl`.
...
see #27690 .
Built from https://develop.svn.wordpress.org/trunk@27995
git-svn-id: http://core.svn.wordpress.org/trunk@27825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:00:16 +00:00
2d710c6fad
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
props kovshenin.
see [27964], see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27990
git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 17:59:14 +00:00
5bd1e16992
Widget Customizer: Cleanup `wp.customize.Widgets.WidgetControl`.
...
see #27690 .
Built from https://develop.svn.wordpress.org/trunk@27988
git-svn-id: http://core.svn.wordpress.org/trunk@27818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 16:32:15 +00:00
5f76bf3b0d
Widget Customizer: Make the available widgets panel a Backbone view.
...
see #27690 .
Built from https://develop.svn.wordpress.org/trunk@27986
git-svn-id: http://core.svn.wordpress.org/trunk@27816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 14:10:14 +00:00
fabc65b787
Widget Customizer: Move `WidgetCustomizer` to `wp.customize.Widgets`. First pass.
...
see #27690 .
Built from https://develop.svn.wordpress.org/trunk@27985
git-svn-id: http://core.svn.wordpress.org/trunk@27815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 09:04:14 +00:00
2f80a1c72f
Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation.
...
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27975
git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 22:08:15 +00:00
5f1c818477
Header images: Improve accessibility of Randomize buttons.
...
props ehg.
see #27598 , #21785 .
Built from https://develop.svn.wordpress.org/trunk@27970
git-svn-id: http://core.svn.wordpress.org/trunk@27800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 19:28:16 +00:00
0c5d4db466
Widgets: Trigger jQuery events for widget updates.
...
* `widget-added` when a widget is added to a sidebar
* `widget-updated` when a widget is updated
A jQuery object of the widget is passed along to the event handler. Same events are used in the Widget Customizer, see [27909].
fixes #19675 .
Built from https://develop.svn.wordpress.org/trunk@27969
git-svn-id: http://core.svn.wordpress.org/trunk@27799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 19:06:14 +00:00
a11553eafe
Inline documentation for remaining hooks in wp-admin/includes/upgrade.php.
...
Props jackreichert, vancoder.
Fixes #27646 .
Built from https://develop.svn.wordpress.org/trunk@27965
git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 22:30:14 +00:00
1ec9b44673
Better checks for contributors when saving posts.
...
props dd32, kovshenin, plocha.
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27964
git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 21:19:14 +00:00
7cd04f4829
Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27963
git-svn-id: http://core.svn.wordpress.org/trunk@27793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:46:15 +00:00
f532f117e1
Theme Installer: Don't encode description entities/HTML.
...
props johnbillion.
fixes #27641 .
Built from https://develop.svn.wordpress.org/trunk@27962
git-svn-id: http://core.svn.wordpress.org/trunk@27792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:30:15 +00:00
9fc1d41ec1
Theme Installer: Use JSONP for api.wordpress.org requests.
...
fixes #27639 .
Built from https://develop.svn.wordpress.org/trunk@27961
git-svn-id: http://core.svn.wordpress.org/trunk@27791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:28:14 +00:00
c5127a9232
Theme Installer: Better responsive styles for feature filters.
...
props matveb.
fixes #27661 .
Built from https://develop.svn.wordpress.org/trunk@27959
git-svn-id: http://core.svn.wordpress.org/trunk@27789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:04:14 +00:00
e36c1cbf9e
Theme Installer: Fix displaying of errors.
...
props SergeyBiryukov.
fixes #27640 .
Built from https://develop.svn.wordpress.org/trunk@27958
git-svn-id: http://core.svn.wordpress.org/trunk@27788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 19:26:14 +00:00
df9b44649c
RTL: Fix taxonomy quick edit list alignment.
...
props SergeyBiryukov.
fixes #27629 .
Built from https://develop.svn.wordpress.org/trunk@27956
git-svn-id: http://core.svn.wordpress.org/trunk@27786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 18:14:15 +00:00
12334929d7
Fix typo in hook description for `async_upload_{$type}`.
...
Built from https://develop.svn.wordpress.org/trunk@27955
git-svn-id: http://core.svn.wordpress.org/trunk@27785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 14:12:16 +00:00
5803c6bc2f
Customizer: Add `height: auto;` for `select[multiple]`.
...
fixes #27662 .
Built from https://develop.svn.wordpress.org/trunk@27954
git-svn-id: http://core.svn.wordpress.org/trunk@27784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 13:12:15 +00:00
2194145373
When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657
...
Built from https://develop.svn.wordpress.org/trunk@27951
git-svn-id: http://core.svn.wordpress.org/trunk@27781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 01:29:14 +00:00
27c422364c
Header images: Accessibility and style improvements. Headers no longer jump around when chosen.
...
props mcsf, ehg.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27947
git-svn-id: http://core.svn.wordpress.org/trunk@27777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 15:49:15 +00:00
5e79b94d81
Header images: Handle cropping failures.
...
props ehg.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27946
git-svn-id: http://core.svn.wordpress.org/trunk@27776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 15:48:16 +00:00
d4755ebea3
TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
...
Built from https://develop.svn.wordpress.org/trunk@27944
git-svn-id: http://core.svn.wordpress.org/trunk@27774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 05:23:14 +00:00
2d0ce517e8
TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279
...
Built from https://develop.svn.wordpress.org/trunk@27941
git-svn-id: http://core.svn.wordpress.org/trunk@27771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 01:31:15 +00:00
be70db8c5f
Theme Installer: Center spinner, remove plural string.
...
fixes #27581 . see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27940
git-svn-id: http://core.svn.wordpress.org/trunk@27770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:46:15 +00:00
b48021f65f
Clarify tooltips on Edit Image screen.
...
props siobhan.
fixes #27651 .
Built from https://develop.svn.wordpress.org/trunk@27939
git-svn-id: http://core.svn.wordpress.org/trunk@27769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:03:28 +00:00
2cb849fc52
Fix typo in verify_file_md5() description. see [25541].
...
props siobhan.
see #27651 .
Built from https://develop.svn.wordpress.org/trunk@27938
git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:03:14 +00:00
0163a95d79
Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
...
props matveb.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27937
git-svn-id: http://core.svn.wordpress.org/trunk@27767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 23:53:15 +00:00
dcb39d4dad
Themes: Hide 'Add New' with no JS. see #27055 .
...
Built from https://develop.svn.wordpress.org/trunk@27936
git-svn-id: http://core.svn.wordpress.org/trunk@27766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 23:06:16 +00:00
96203ceb97
Fix styling for plugin update details Thickbox.
...
see #26952 .
Built from https://develop.svn.wordpress.org/trunk@27932
git-svn-id: http://core.svn.wordpress.org/trunk@27762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 14:08:15 +00:00
f8c39d6186
Use multiplication sign instead of a colon for selection size when editing an image.
...
props siobhan.
fixes #27652 .
Built from https://develop.svn.wordpress.org/trunk@27931
git-svn-id: http://core.svn.wordpress.org/trunk@27761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 09:46:17 +00:00
a2e1d9f4c8
Edit Image modal:
...
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366
Built from https://develop.svn.wordpress.org/trunk@27918
git-svn-id: http://core.svn.wordpress.org/trunk@27748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:21:15 +00:00
803d4ff54d
Remove old links_recently_updated_* DB options that never had a UI.
...
fixes #27649 .
Built from https://develop.svn.wordpress.org/trunk@27916
git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:10:15 +00:00
158597a5e3
Widget Customizer: Restore deferral of `previewer-loading` class removal until preview is synced.
...
props westonruter.
fixes #27635 .
Built from https://develop.svn.wordpress.org/trunk@27913
git-svn-id: http://core.svn.wordpress.org/trunk@27744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 19:25:15 +00:00
074d31f253
Widget Customizer: Don't use opacity for the update spinner.
...
`opacity` isn't supported in IE8 and makes the spinner always visible.
see #27485 .
Built from https://develop.svn.wordpress.org/trunk@27912
git-svn-id: http://core.svn.wordpress.org/trunk@27743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 19:20:15 +00:00
944fba8e2f
Widget Customizer: Improve support for dynamically-created inputs.
...
* Re-work how and when widget forms get updated.
* Replace ad hoc hooks system with jQuery events,
* Add `widget-updated`/`widget-synced` events for widget soft/hard updates.
* Enter into a non-live form update mode, where the Apply button is restored when a sanitized form does not have the same fields as currently in the form, and so the fields cannot be easily updated to their sanitized values without doing a complete form replacement. Also restores live update mode if sanitized fields are aligned with the existing fields again.
Note: jQuery events are *not* final yet, see #19675 .
props westonruter.
see #27491 .
Built from https://develop.svn.wordpress.org/trunk@27909
git-svn-id: http://core.svn.wordpress.org/trunk@27740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 18:20:16 +00:00
cde6d602ea
Widget Customizer: Improve plugin compatibility.
...
Some plugins are using custom scripts and styles for there widgets. These are available on the Widgets screens, but not in the Customizer yet.
Scripts and styles can be enqueued via:
* `admin_enqueue_scripts`
* `admin_print_scripts` and `admin_print_scripts-widgets.php`
* `admin_print_styles` and `admin_print_styles-widgets.php`
* `admin_print_footer_scripts` and `admin_footer-widgets.php`
All this hooks are now called in the Customizer too.
Previously we have add the `#widgets-right` ID to a container div via jQuery. Remember: `#widgets-right` exists on the Widgets screen and is used by many plugins to do event delegation from that element.
But since our script files are loaded in the footer, the JavaScript way is a bit late for some plugins.
We have decided to add a `div#widgets-right` container element to customizer. "Less hacky hack."
props westonruter, ocean90. Thanks dpe415 for testing.
fixes #27619 .
Built from https://develop.svn.wordpress.org/trunk@27907
git-svn-id: http://core.svn.wordpress.org/trunk@27738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 17:04:14 +00:00
50a7503c2e
Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633
...
Built from https://develop.svn.wordpress.org/trunk@27905
git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 13:05:15 +00:00
668235fb42
Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465
...
Built from https://develop.svn.wordpress.org/trunk@27901
git-svn-id: http://core.svn.wordpress.org/trunk@27732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 02:42:16 +00:00
2547ba21ae
TinyMCE: update to 4.0.21, see #24067
...
Built from https://develop.svn.wordpress.org/trunk@27897
git-svn-id: http://core.svn.wordpress.org/trunk@27728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 22:46:14 +00:00
d330c402c8
Theme Installer fixes:
...
* Better more filters section. props sonjanyc for some mockups.
* Better handling of no results.
* Use # for hrefs.
props matveb.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27896
git-svn-id: http://core.svn.wordpress.org/trunk@27727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 22:20:14 +00:00
dc5effa8cc
Cleanup [27892].
...
Built from https://develop.svn.wordpress.org/trunk@27893
git-svn-id: http://core.svn.wordpress.org/trunk@27724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 15:30:16 +00:00
ae1f4e146f
Widget Customizer: Use postMessage to highlight widgets in preview or sections/controls in Customizer.
...
fixes #27622 .
Built from https://develop.svn.wordpress.org/trunk@27892
git-svn-id: http://core.svn.wordpress.org/trunk@27723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 15:26:15 +00:00
404fe8710d
Widget Customizer: Remove WidgetCustomizer.showFirstSidebarIfRequested().
...
It's currently unused and needs another iteration.
see #27290 .
Built from https://develop.svn.wordpress.org/trunk@27891
git-svn-id: http://core.svn.wordpress.org/trunk@27722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 12:38:15 +00:00
6528b7804b
Revert [27654] for strings.
...
props westonruter.
fixes #27485 .
Built from https://develop.svn.wordpress.org/trunk@27890
git-svn-id: http://core.svn.wordpress.org/trunk@27721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 11:08:16 +00:00
4af2840a47
Clarify PHPDoc return description for `media_handle_upload()`.
...
Props jdgrimes.
Fixes #27519 .
Built from https://develop.svn.wordpress.org/trunk@27880
git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 22:33:15 +00:00
01d2062af3
Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
...
Props nacin.
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27869
git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
8acf74fe7b
Use correct formatting function. see [27864], see #27574 .
...
Built from https://develop.svn.wordpress.org/trunk@27866
git-svn-id: http://core.svn.wordpress.org/trunk@27697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 22:12:29 +00:00
c95f232727
Cleanups for audio/video metadata, see [27862].
...
see #27574 .
Built from https://develop.svn.wordpress.org/trunk@27864
git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 21:08:14 +00:00
7eb24edf4e
In `wp_generate_attachment_metadata()`, when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a `_cover_hash` value in post meta that matches the `md5` representation of the bits.
...
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.
Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573 .
Built from https://develop.svn.wordpress.org/trunk@27863
git-svn-id: http://core.svn.wordpress.org/trunk@27694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 20:54:15 +00:00
d947a55495
Metadata for audio and video files:
...
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27862
git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 19:28:16 +00:00
bfaf007e97
Editor:
...
- Use standard button styles for the Quicktags buttons.
- Better style for the TinyMCE buttons (hover/focus/active/disabled).
- Move the fullscreen (DFW) button to the right.
- Better style for the Visual/Text buttons in DFW.
Props avryl, see #27279
Built from https://develop.svn.wordpress.org/trunk@27857
git-svn-id: http://core.svn.wordpress.org/trunk@27688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 23:58:14 +00:00
51c58c5be3
Customizer: Style "Cheatin’ uh?" message like wp_die().
...
props jackreichert.
fixes #27490
Built from https://develop.svn.wordpress.org/trunk@27856
git-svn-id: http://core.svn.wordpress.org/trunk@27687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 23:19:15 +00:00
2f0c68ad0e
Adjust colors in wp_die() and install.css.
...
Missed in [26788] and [26837], see #25858 .
fixes #27589 .
Built from https://develop.svn.wordpress.org/trunk@27855
git-svn-id: http://core.svn.wordpress.org/trunk@27686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 23:06:14 +00:00
c347b4a5cb
Restore some CSS rules that are necessary for non-default schemes. see #18380 .
...
Built from https://develop.svn.wordpress.org/trunk@27852
git-svn-id: http://core.svn.wordpress.org/trunk@27683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 17:48:15 +00:00
f320b43587
Custom Headers: Simplify and consolidate the querying of custom headers for the customizer.
...
props mcsf.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27849
git-svn-id: http://core.svn.wordpress.org/trunk@27680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 10:53:15 +00:00
495c73fc1c
Theme Installer: Avoid race condition during pagination.
...
props matveb.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27845
git-svn-id: http://core.svn.wordpress.org/trunk@27679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 09:09:14 +00:00
6531ed1efc
Theme Installer: Remove unused variables and undesired commas.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27843
git-svn-id: http://core.svn.wordpress.org/trunk@27677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 08:53:16 +00:00
3c1cdaa362
Restyle the image editor so it looks way less hideous.
...
props avryl.
see #27544 .
Built from https://develop.svn.wordpress.org/trunk@27842
git-svn-id: http://core.svn.wordpress.org/trunk@27676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 08:51:14 +00:00
5851e00b93
Add a value to the password checkbox when creating a new user so the toggle is remembered.
...
props chriseverson, SergeyBiryukov.
fixes #27006 .
Built from https://develop.svn.wordpress.org/trunk@27838
git-svn-id: http://core.svn.wordpress.org/trunk@27672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 06:23:17 +00:00
665df851ad
Restore the original z-index of the sticky admin menu, as first set in [26442].
...
The inline comment is now correct again. This z-index was changed in [26701], but those circumstances no longer apply after [27532].
props mordauk.
see #26442 , #26952 .
fixes #26567 .
Built from https://develop.svn.wordpress.org/trunk@27833
git-svn-id: http://core.svn.wordpress.org/trunk@27667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 03:30:14 +00:00
d88315a6f7
Correct cascade issues and remove some unused CSS for the admin menu. see #18380 .
...
Built from https://develop.svn.wordpress.org/trunk@27832
git-svn-id: http://core.svn.wordpress.org/trunk@27666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 02:47:14 +00:00
e96b783f69
Theme Installer: Caching and paginating of API requests.
...
props matveb.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27830
git-svn-id: http://core.svn.wordpress.org/trunk@27664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 21:49:14 +00:00
d15863865a
Widget Customizer: Remove some specific styles for Widget Visibility from Jetpack.
...
This hasn't worked well and is now fixed upstream.
props westonruter.
see #27112 .
Built from https://develop.svn.wordpress.org/trunk@27824
git-svn-id: http://core.svn.wordpress.org/trunk@27658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 20:44:15 +00:00
5613b40981
The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates.
...
See #25374 , #25501 , #27531 .
Built from https://develop.svn.wordpress.org/trunk@27823
git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 19:47:15 +00:00
db6e8aa84e
Install: Allow an installation to go through with a custom user table with the username 'admin'.
...
This could be better, but this solves the regression caused by [25115].
fixes #27093 , see #24078 .
Built from https://develop.svn.wordpress.org/trunk@27822
git-svn-id: http://core.svn.wordpress.org/trunk@27656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 19:00:15 +00:00
c2f839b7b6
Widget Customizer: Simplify nonces.
...
see #27534 .
Built from https://develop.svn.wordpress.org/trunk@27819
git-svn-id: http://core.svn.wordpress.org/trunk@27653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 15:35:15 +00:00
c707faa639
Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets.
...
see #27504 .
props westonruter.
Built from https://develop.svn.wordpress.org/trunk@27816
git-svn-id: http://core.svn.wordpress.org/trunk@27650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 14:07:14 +00:00
ebdd64f6ad
Widget Customizer: Set hightlight color to blue. Same color as in [27741].
...
fixes #27358 .
Built from https://develop.svn.wordpress.org/trunk@27814
git-svn-id: http://core.svn.wordpress.org/trunk@27648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 13:33:14 +00:00
eb146fd12d
Make DFW usable on touch devices: change the toolbar to two rows and keep it and borders visible. See #26907
...
Built from https://develop.svn.wordpress.org/trunk@27806
git-svn-id: http://core.svn.wordpress.org/trunk@27640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 04:40:14 +00:00
3c72ba4282
Bring keyboard accessibility to the theme install screen and theme action buttons. props jorbin. see #27521 .
...
Built from https://develop.svn.wordpress.org/trunk@27804
git-svn-id: http://core.svn.wordpress.org/trunk@27638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 03:16:15 +00:00
c3ca81ba94
Always decode special characters for email subjects.
...
props tlovett1, jeremyfelt.
fixes #25346 .
Built from https://develop.svn.wordpress.org/trunk@27801
git-svn-id: http://core.svn.wordpress.org/trunk@27636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 02:44:15 +00:00
e1e09075d4
Widget Customizer: Improve behavior of bigger widgets.
...
* Support widgets which are higher than browsers viewport.
* Use widgets width as max-width.
* Don't animate the width of wide widgets to make them visible, instead fade them in/out.
* Fix Chrome flickerings while updating wide widgets.
props adamsilverstein, westonruter, ocean90.
see #27348 .
Built from https://develop.svn.wordpress.org/trunk@27798
git-svn-id: http://core.svn.wordpress.org/trunk@27633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 23:13:14 +00:00
4038e52276
Add some missing CSS prefixes. props `grunt autoprefixer:core`.
...
Built from https://develop.svn.wordpress.org/trunk@27790
git-svn-id: http://core.svn.wordpress.org/trunk@27626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 19:17:15 +00:00
999183669c
Color scheme support for the new theme installer UI.
...
props ryelle.
fixes #27522 .
Built from https://develop.svn.wordpress.org/trunk@27784
git-svn-id: http://core.svn.wordpress.org/trunk@27620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:56:14 +00:00
68bfa704cf
Remove unused JS variables after [27770]. see #27013 .
...
Built from https://develop.svn.wordpress.org/trunk@27783
git-svn-id: http://core.svn.wordpress.org/trunk@27619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:31:14 +00:00
bec78b5e11
Proper IDs for the custom fields box.
...
props SergeyBiryukov.
fixes #14376 .
Built from https://develop.svn.wordpress.org/trunk@27776
git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 06:56:14 +00:00
ce1ace6347
Fix flyout menus on most mobile devices.
...
props ocean90.
fixes #26482 .
Built from https://develop.svn.wordpress.org/trunk@27775
git-svn-id: http://core.svn.wordpress.org/trunk@27612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 06:30:14 +00:00
1ade5bb2f3
Comments: Update border color and help text.
...
props bcworkz.
fixes #26967 .
Built from https://develop.svn.wordpress.org/trunk@27774
git-svn-id: http://core.svn.wordpress.org/trunk@27611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 05:08:14 +00:00
56a2b67e21
Make sure inputs in Press This have a type so they are styled appropriately. see #18380 .
...
Built from https://develop.svn.wordpress.org/trunk@27772
git-svn-id: http://core.svn.wordpress.org/trunk@27609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:39:14 +00:00
15549e75f3
Remove containment of scrolling inside the editor for now. See #27013
...
Built from https://develop.svn.wordpress.org/trunk@27770
git-svn-id: http://core.svn.wordpress.org/trunk@27607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:35:14 +00:00
f9964e361c
Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189 , #27188 .
...
Built from https://develop.svn.wordpress.org/trunk@27769
git-svn-id: http://core.svn.wordpress.org/trunk@27606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:02:14 +00:00
c3b59e06b8
Better, more consistent styling for plugin details Thickbox and TinyMCE help.
...
props avryl. fixes #26952 .
Built from https://develop.svn.wordpress.org/trunk@27765
git-svn-id: http://core.svn.wordpress.org/trunk@27602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:08:15 +00:00
fd0e34ec9f
The bulk editor and post format meta box should use the same checks for available post formats.
...
Props eightface.
Fixes #27187 .
Built from https://develop.svn.wordpress.org/trunk@27762
git-svn-id: http://core.svn.wordpress.org/trunk@27599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:06:15 +00:00
2133c89e8f
Remove select and input from wpautop()'s HTML blocks list.
...
props rachelbaker, DH-Shredder.
fixes #22230 .
Built from https://develop.svn.wordpress.org/trunk@27761
git-svn-id: http://core.svn.wordpress.org/trunk@27598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:01:15 +00:00
8ff7cf5c3e
Themes screen: Use a normal error for WP_Theme errors.
...
see #27235 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27760
git-svn-id: http://core.svn.wordpress.org/trunk@27597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:37:25 +00:00
d4e46e3f8d
Fix double avatars and JS errors when spamming/trashing comments.
...
Props avryl, SergeyBiryukov.
Fixes #27329 .
Built from https://develop.svn.wordpress.org/trunk@27759
git-svn-id: http://core.svn.wordpress.org/trunk@27596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:14:15 +00:00
d67790d44e
Customizer: Improve accessibility.
...
Prevent the form only from saving when enter is pressed on a select element or an input, which hasn't the button type.
props westonruter, ocean90.
fixes #26633 .
Built from https://develop.svn.wordpress.org/trunk@27757
git-svn-id: http://core.svn.wordpress.org/trunk@27594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:56:29 +00:00
d8f50c98a0
Ensure active tabs have a background color to avoid any awkward bleed-through in case of overlap. props TobiasBg. fixes #27116 .
...
Built from https://develop.svn.wordpress.org/trunk@27749
git-svn-id: http://core.svn.wordpress.org/trunk@27586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 20:57:15 +00:00
b5d0471fef
Merge some theme update strings.
...
props pavelevap, yoavf.
fixes #25083 .
Built from https://develop.svn.wordpress.org/trunk@27748
git-svn-id: http://core.svn.wordpress.org/trunk@27585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 20:08:15 +00:00
2fd8b60c22
Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon.
...
props aubreypwd.
fixes #24741 .
Built from https://develop.svn.wordpress.org/trunk@27747
git-svn-id: http://core.svn.wordpress.org/trunk@27584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 18:53:15 +00:00
84a4d86536
Themes screens: Bump to 20 items per page so it fills a high resolution display. see #26968 .
...
Built from https://develop.svn.wordpress.org/trunk@27744
git-svn-id: http://core.svn.wordpress.org/trunk@27581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 17:46:16 +00:00
Scott Taylor
Sergey Biryukov
Drew Jaynes
Andrew Ozz
Dominik Schilling
Andrew Nacin
Mark Jaquith
Helen Hou-Sandí
Dion Hulse