Commit Graph

27152 Commits

Author SHA1 Message Date
Scott Taylor eb66e40790 After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for `$object_id`.
Props SergeyBiryukov.
Fixes #28315.

Built from https://develop.svn.wordpress.org/trunk@29421


git-svn-id: http://core.svn.wordpress.org/trunk@29199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 22:08:16 +00:00
Scott Taylor 935f10413e Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.

Built from https://develop.svn.wordpress.org/trunk@29420


git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 21:44:17 +00:00
Scott Taylor 582b5144b2 Media Grid: after [28996], use the same cover size for audio/video files that images use for thumbnails.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29416


git-svn-id: http://core.svn.wordpress.org/trunk@29194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:33:14 +00:00
Scott Taylor a58a4da852 Media Grid: display upload errors in a dismissable sidebar.
See #29037.

Built from https://develop.svn.wordpress.org/trunk@29415


git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:13:15 +00:00
Andrew Nacin fd93879c86 4.0-beta3
Built from https://develop.svn.wordpress.org/trunk@29414


git-svn-id: http://core.svn.wordpress.org/trunk@29192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 18:28:17 +00:00
Andrew Nacin bcb8e53d16 Ignore entities in XML-RPC requests.
props mdawaffe, nacin.

Built from https://develop.svn.wordpress.org/trunk@29404


git-svn-id: http://core.svn.wordpress.org/trunk@29182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:38:17 +00:00
Scott Taylor 27b0d4cd20 In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action.
Fixes #29101.

Built from https://develop.svn.wordpress.org/trunk@29403


git-svn-id: http://core.svn.wordpress.org/trunk@29181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:24:19 +00:00
Scott Taylor 6b8ee0942c Don't show the Featured Image metabox for users with the `contributor` role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc.
Props SergeyBiryukov.
Fixes #28327.

Built from https://develop.svn.wordpress.org/trunk@29402


git-svn-id: http://core.svn.wordpress.org/trunk@29180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:17:16 +00:00
Scott Taylor 42809dad43 Use proper non-capturing regex syntax for YouTube in `wp_video_shortcode()`.
Props Fab1en.
See [27063].
Fixes #29119.

Built from https://develop.svn.wordpress.org/trunk@29401


git-svn-id: http://core.svn.wordpress.org/trunk@29179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:01:17 +00:00
Andrew Nacin ee4ce8688d Escape late in get_avatar().
Built from https://develop.svn.wordpress.org/trunk@29397


git-svn-id: http://core.svn.wordpress.org/trunk@29175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 07:50:18 +00:00
Andrew Ozz 9d707e16c9 Media modal/grid: fix the position of attachment icons, restore the background, fix in ie8. See #27423.
Built from https://develop.svn.wordpress.org/trunk@29393


git-svn-id: http://core.svn.wordpress.org/trunk@29171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 06:29:16 +00:00
Andrew Nacin 7d672c38a4 Constant time for wp_verify_nonce().
Built from https://develop.svn.wordpress.org/trunk@29382


git-svn-id: http://core.svn.wordpress.org/trunk@29160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 05:26:16 +00:00
Sergey Biryukov 444a25b375 Avoid PHP notices in wp-login.php if password reset cookie is not set.
props mdawaffe.
see #29060.
Built from https://develop.svn.wordpress.org/trunk@29381


git-svn-id: http://core.svn.wordpress.org/trunk@29159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 02:17:15 +00:00
Andrew Ozz b61903f2bb TinyMCE: add support for `class` attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
Built from https://develop.svn.wordpress.org/trunk@29380


git-svn-id: http://core.svn.wordpress.org/trunk@29158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 00:58:16 +00:00
Andrew Ozz 8fc01225ac Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29379


git-svn-id: http://core.svn.wordpress.org/trunk@29157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 19:37:15 +00:00
Andrew Nacin 8b7beb2378 Disable external entities in ID3.
Built from https://develop.svn.wordpress.org/trunk@29378


git-svn-id: http://core.svn.wordpress.org/trunk@29156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 19:14:18 +00:00
Andrew Nacin 4ecf30559b Verify the MAC earlier in WP_Customize_Widgets. props duck_.
Built from https://develop.svn.wordpress.org/trunk@29377


git-svn-id: http://core.svn.wordpress.org/trunk@29155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 06:50:15 +00:00
Andrew Ozz e6b0d0c9ee Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29376


git-svn-id: http://core.svn.wordpress.org/trunk@29154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 05:20:18 +00:00
Sergey Biryukov e1eab74aa6 Use wp_normalize_path() in plugins_url().
props paulschreiber.
fixes #29058.
Built from https://develop.svn.wordpress.org/trunk@29375


git-svn-id: http://core.svn.wordpress.org/trunk@29153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 01:31:16 +00:00
Andrew Nacin c49eb0be05 Language chooser: Adjust continue button alignment.
Built from https://develop.svn.wordpress.org/trunk@29374


git-svn-id: http://core.svn.wordpress.org/trunk@29152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 21:23:15 +00:00
Andrew Ozz a8fd1330ae Media modal: use the same classes to hide the "or" that is above the "Select files" button when no drag-drop support. See #28851.
Built from https://develop.svn.wordpress.org/trunk@29373


git-svn-id: http://core.svn.wordpress.org/trunk@29151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 21:17:16 +00:00
Andrew Nacin 40258a41b8 Language chooser imporvements.
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.

Built from https://develop.svn.wordpress.org/trunk@29372


git-svn-id: http://core.svn.wordpress.org/trunk@29150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 20:47:16 +00:00
Andrew Nacin 58b22fce7d Move plugin details link into the description area.
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29371


git-svn-id: http://core.svn.wordpress.org/trunk@29149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 18:49:17 +00:00
Andrew Ozz 666fec5144 TinyMCE: fix alignment buttons when used on image with caption. Remove old/unneeded code. Fixes #28705.
Built from https://develop.svn.wordpress.org/trunk@29370


git-svn-id: http://core.svn.wordpress.org/trunk@29148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 00:52:17 +00:00
Andrew Ozz 42c8135fac Mobile: hide the onscreen keyboard when the media modal opens, fixes #28549.
Built from https://develop.svn.wordpress.org/trunk@29369


git-svn-id: http://core.svn.wordpress.org/trunk@29147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 22:34:16 +00:00
Scott Taylor 27890cc734 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
Props ericlewis.
Fixes #29104.

Built from https://develop.svn.wordpress.org/trunk@29368


git-svn-id: http://core.svn.wordpress.org/trunk@29146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:40:17 +00:00
Scott Taylor 696c12bc55 Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`.
Props ericlewis.
See #28965.

Built from https://develop.svn.wordpress.org/trunk@29367


git-svn-id: http://core.svn.wordpress.org/trunk@29145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:37:19 +00:00
Andrew Nacin 2d212cbfac Update the Akismet external to 3.0.1 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@29144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 17:18:22 +00:00
Andrew Ozz 9662dc9f7b Fix CSS for form elements for Firefox 30+, fixes #28500.
Built from https://develop.svn.wordpress.org/trunk@29366


git-svn-id: http://core.svn.wordpress.org/trunk@29142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 00:34:15 +00:00
Dominik Schilling 5be014c7c9 Standardize transition-animations on modal close/arrow buttons.
props celloexpressions.
fixes #29021.
Built from https://develop.svn.wordpress.org/trunk@29365


git-svn-id: http://core.svn.wordpress.org/trunk@29141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 22:02:19 +00:00
Dominik Schilling e6513fe33b Media Modal: Restore uploader view, when no items are found.
see #28963.
Built from https://develop.svn.wordpress.org/trunk@29364


git-svn-id: http://core.svn.wordpress.org/trunk@29140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:47:16 +00:00
Scott Taylor 91764118fb Add an action, `pre_get_users`, in `WP_User_Query::prepare_query()`.
Props rmccue.
Fixes #29084.

Built from https://develop.svn.wordpress.org/trunk@29363


git-svn-id: http://core.svn.wordpress.org/trunk@29139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:46:16 +00:00
Andrew Ozz 9662554bfb Add blog_id to the `wp-settings-*` cookie (used for storing user state) to prevent it being overloaded on sub-domain sites. Fixes #29095.
Built from https://develop.svn.wordpress.org/trunk@29362


git-svn-id: http://core.svn.wordpress.org/trunk@29138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:09:16 +00:00
Dominik Schilling 28170e0d82 Remove some unused dashboard-widget-* CSS classes. Unused since [9103].
props michalzuber.
fixes #28930.
Built from https://develop.svn.wordpress.org/trunk@29361


git-svn-id: http://core.svn.wordpress.org/trunk@29137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:02:17 +00:00
Dominik Schilling 1ad95ec66d Media: Don't stretch radio and checkbox inputs in compat fields. Adjust margin for radio inputs.
props kovshenin for initial patch.
fixes #28647.
Built from https://develop.svn.wordpress.org/trunk@29360


git-svn-id: http://core.svn.wordpress.org/trunk@29136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 19:53:17 +00:00
Dominik Schilling 410ca0a29c Plugin install: Improve styling of the no results message.
see #28753.
Built from https://develop.svn.wordpress.org/trunk@29359


git-svn-id: http://core.svn.wordpress.org/trunk@29135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 15:24:16 +00:00
Dominik Schilling 68f16e0ef8 Language Upgrader: Don't print a footer when translations are updated async.
fixes #28947.
Built from https://develop.svn.wordpress.org/trunk@29358


git-svn-id: http://core.svn.wordpress.org/trunk@29134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 15:16:16 +00:00
Dominik Schilling cd58a064cf Upgrader: Use always `window.postMessage` for decrement of update count bubbles when `IFRAME_REQUEST` is defined.
Fixes decrement of translation update count bubbles when updated through the bulk upgrader.

fixes #29054.
Built from https://develop.svn.wordpress.org/trunk@29357


git-svn-id: http://core.svn.wordpress.org/trunk@29133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 14:37:16 +00:00
Dominik Schilling 608d505b24 Attach Media: Display the correct error message when search result is empty.
fixes #29093.
Built from https://develop.svn.wordpress.org/trunk@29356


git-svn-id: http://core.svn.wordpress.org/trunk@29132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 14:24:15 +00:00
Dominik Schilling 8ea68677f3 Media Upload: Improve styling of error messages.
props afercia, michalzuber.
fixes #29047.
Built from https://develop.svn.wordpress.org/trunk@29355


git-svn-id: http://core.svn.wordpress.org/trunk@29131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 14:14:19 +00:00
Dominik Schilling 203c44581b To improve troubleshooting use `esc_html()` for a failed embed.
see #28195.
Built from https://develop.svn.wordpress.org/trunk@29354


git-svn-id: http://core.svn.wordpress.org/trunk@29130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 22:34:15 +00:00
Dominik Schilling 2cb623b062 RTL: Fix media attach modal alignment.
props SergeyBiryukov.
fixes #28010.
Built from https://develop.svn.wordpress.org/trunk@29353


git-svn-id: http://core.svn.wordpress.org/trunk@29129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 21:59:16 +00:00
Andrew Ozz e50ffd401e Editor scrolling: run one more adjust() 200ms after scroll or resize in case the browser is slow to re-calculate the element heights and pin/unpin the toolbars. See #28328, fixes #29059.
Built from https://develop.svn.wordpress.org/trunk@29352


git-svn-id: http://core.svn.wordpress.org/trunk@29128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 21:43:18 +00:00
Dominik Schilling 9a9b1791ca Add some braces to [29225].
see #28673.
Built from https://develop.svn.wordpress.org/trunk@29350


git-svn-id: http://core.svn.wordpress.org/trunk@29127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 21:04:15 +00:00
Sergey Biryukov 7753c3ff05 Avoid an undefined index notice in wp_reschedule_event().
props paulschreiber.
fixes #29077.
Built from https://develop.svn.wordpress.org/trunk@29349


git-svn-id: http://core.svn.wordpress.org/trunk@29126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:57:16 +00:00
Dominik Schilling 12e961cb61 Plugin install: Add missing closing HTML tags.
props jwenerd.
fixes #29090. see #28673.
Built from https://develop.svn.wordpress.org/trunk@29348


git-svn-id: http://core.svn.wordpress.org/trunk@29125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:44:14 +00:00
Dominik Schilling fb9084eed3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.
Built from https://develop.svn.wordpress.org/trunk@29346


git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:15:15 +00:00
Scott Taylor 6018cd50b6 Revert [28640] as per @DH-Shredder.
See #24380.

Built from https://develop.svn.wordpress.org/trunk@29345


git-svn-id: http://core.svn.wordpress.org/trunk@29123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:43:16 +00:00
Scott Taylor 69dbf4f5df Clarify that `get_the_date()`, `get_the_time()`, `get_post_time()` and `get_post_modified_time()` should return `false` when `get_post()` is `null`.
Adds unit tests.

Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310.

Built from https://develop.svn.wordpress.org/trunk@29344


git-svn-id: http://core.svn.wordpress.org/trunk@29122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:40:16 +00:00
Helen Hou-Sandí 5d102f8e0b Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one.
props philipjohn, GaVrA, seanchayes. fixes #17209.

Built from https://develop.svn.wordpress.org/trunk@29343


git-svn-id: http://core.svn.wordpress.org/trunk@29121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:32:15 +00:00