Scott Taylor
c6a4512b1b
Add missing doc blocks to `wp-admin/includes/*`.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32654
git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
b56b9b3e5c
Add `@global` annotations for `wp-admin/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor
b8341a472d
When adding `post_type` to `$sendback` in `wp-admin/post.php`, use `add_query_arg()` instead of string concatenation.
...
Props podpirate.
Fixes #31492 .
Built from https://develop.svn.wordpress.org/trunk@31633
git-svn-id: http://core.svn.wordpress.org/trunk@31614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 22:31:24 +00:00
Scott Taylor
84867b3e9c
Admin globals:
...
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and `$post` as globals where applicable
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31121
git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:29:22 +00:00
Andrew Ozz
3d60d9f875
Autosave: prevent setting multiple stale `wp-saving-post-*` cookies when the browser disregards "session cookies" expiration on quit:
...
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294 .
Built from https://develop.svn.wordpress.org/trunk@29572
git-svn-id: http://core.svn.wordpress.org/trunk@29346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 00:25:16 +00:00
Scott Taylor
517dbfaa21
In `wp-admin/post.php`, `break` is unreachabled after `exit`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28312
git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:15:15 +00:00
Helen Hou-Sandí
593bd2a495
Avoid an undefined function due to `/wp-admin/includes/dashboard.php` being included too late. props obenland. fixes #27457 .
...
Built from https://develop.svn.wordpress.org/trunk@27630
git-svn-id: http://core.svn.wordpress.org/trunk@27473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 01:31:15 +00:00
Andrew Ozz
335add2573
Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272 .
...
Built from https://develop.svn.wordpress.org/trunk@26995
git-svn-id: http://core.svn.wordpress.org/trunk@26872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 04:56:16 +00:00
Andrew Nacin
3189d79f46
Don't let Quick Draft ignore default comment_status and ping_status.
...
props kovshenin.
fixes #26722 .
Built from https://develop.svn.wordpress.org/trunk@26959
git-svn-id: http://core.svn.wordpress.org/trunk@26838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-16 20:24:13 +00:00
Drew Jaynes
89211ee8d6
Inline documentation for hooks in wp-admin/post.php.
...
Props nukaga, kpdesign.
Fixes #25846 .
Built from https://develop.svn.wordpress.org/trunk@26399
git-svn-id: http://core.svn.wordpress.org/trunk@26299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 07:44:10 +00:00
Sergey Biryukov
ecd594b5a6
PHPDoc and i18n fixes for dashboard widgets.
...
props dimadin for initial patch.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26241
git-svn-id: http://core.svn.wordpress.org/trunk@26148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:21:10 +00:00
Andrew Nacin
c03d9d3f01
Revert these action blocks in wp-admin/post.php to their pre-[26144] state.
...
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26231
git-svn-id: http://core.svn.wordpress.org/trunk@26138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 22:29:09 +00:00
Andrew Nacin
791e807f08
More dash updates.
...
* Shuffle around some pixels.
* Rename some things that weren't caught in [26220].
* Revert default-widgets.php change from [26144].
props lessbloat.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26230
git-svn-id: http://core.svn.wordpress.org/trunk@26137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 22:23:09 +00:00
Andrew Nacin
809b335f7a
Merge the new dashboard design into core.
...
Merges https://github.com/growthdesigner/wp-dash .
props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26144
git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
Andrew Nacin
fd57b239d2
Don't rely on include_path to include files.
...
Always use dirname() or, once available, ABSPATH.
props ketwaroo, hakre.
fixes #17092 .
Built from https://develop.svn.wordpress.org/trunk@25616
git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin
c2db94d10c
Use meta caps edit_post, read_post, and delete_post directly, rather than consulting the post type object. map_meta_cap() handles that for us. props markjaquith, kovshenin. fixes #23226 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:05:42 +00:00
Andrew Ozz
a26190eb2e
Post locks:
...
- Change from IDs to classes for the notification-dialog divs so they can be reused.
- Do not check post locks if the dialog's html is not present.
- Do not check post locks if there is only one user on a single site install.
See #23697 .
git-svn-id: http://core.svn.wordpress.org/trunk@24304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 19:36:29 +00:00
Sergey Biryukov
6898eba2f2
Avoid PHP notices when deleting or restoring an item that no longer exists. props johnbillion, ocean90. fixes #24246 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 18:56:54 +00:00
Sergey Biryukov
bfc9c67861
Remove unused variables. props ocean90. fixes #24247 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 17:52:18 +00:00
Andrew Ozz
9fe85b154e
Revisions: move the call to _wp_upgrade_revisions_of_post() to edit-form-advanced.php, in the code block checking whether we should show the revisions postbox. See #16215
...
git-svn-id: http://core.svn.wordpress.org/trunk@23929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 23:43:05 +00:00
Mark Jaquith
cccb2939db
Fix a longstanding "off by one" revision authorship bug.
...
* Fixes old revision data on the fly when you open a post for editing.
* Uses post_name of revisions to store a post version number (-v1), so we know what has been fixed.
* Latest version should also have a revision stored, whereas before it did not.
props adamsilverstein, mdawaffe. fixes #16215 .
git-svn-id: http://core.svn.wordpress.org/trunk@23823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 20:21:38 +00:00
Andrew Ozz
a224d8aaf7
Local autosave: set a temp cookie on submitting the form and change it on redirecting after the post is saved/updated, then use it to determine if saving worked properly. Removes the chance for false positives after saving/updating a post. See #23220
...
git-svn-id: http://core.svn.wordpress.org/trunk@23693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 03:06:07 +00:00
Andrew Ozz
edb9333d40
Check post locks with heartbeat and display modal notifications when a post is locked or a user takes over editing, props dh-shredder, see #23697
...
git-svn-id: http://core.svn.wordpress.org/trunk@23661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 03:22:30 +00:00
Andrew Nacin
83e0ce2ac1
Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 18:28:41 +00:00
Andrew Ozz
0e38402629
Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes #22491
...
git-svn-id: http://core.svn.wordpress.org/trunk@22725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 19:46:38 +00:00
Andrew Nacin
33af30eb7f
Use the regular post type UI for editing single media items (attachments).
...
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
* Taxonomies attached to the media library now appear in the admin menu (if show_ui).
* Editing, cropping, uploading, etc. is still very rough, but mostly functional.
API-wise:
* New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
* Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
* wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
* New edit_form_after_title hook.
props helenyhou, ocean90. see #21391 .
git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:52:54 +00:00
Ryan Boren
52b3f498e6
Add tags_input, page_template, and post_category get magic to WP_Post.
...
Deprecate get_post_to_edit() and wp_get_single_post().
Props scribu
see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 19:08:28 +00:00
Ryan Boren
f56d8278bb
Remove return ref from all calls to get_post()
...
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Ryan Boren
15dd7f70b0
Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
...
git-svn-id: http://core.svn.wordpress.org/trunk@21504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:39:15 +00:00
duck_
a442d476fe
Check that $post_type_object exists before accessing its properties. Props markoheijnen. Fixes #20064 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 19:32:32 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
0ec7ae44ca
Fix edit.php row action redirects when referrers are not sent. Return false from wp_get_referer() when no referrer found. Props mitchoyoshitaka. fixes #17628
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 16:59:45 +00:00
nacin
c2064f9976
Move from quickpress_post_ID to post_ID. fixes #19095 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 17:08:36 +00:00
nacin
12de7d1e2d
Move WP_Screen to a full registry. Have convert_to_screen() return a WP_Screen object. Improve and verify values for post_type and taxonomy. see #18785 . also fixes #14886 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 18:34:08 +00:00
nacin
de8cc0eae1
Release a user's post lock when the user leaves a post. see #18515 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-27 20:52:07 +00:00
markjaquith
188f57edfa
Add New links when editing content. fixes #17499
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-19 01:34:34 +00:00
nacin
8b5122b411
Don't load the QuickPress widget via XHR. see #16927 . Reverts [16725] as it's no longer needed. Reverts part of [14815], which introduced the behavior, see #10917 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 12:02:24 +00:00
ryan
85f1feed84
Bring out the shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-06 04:11:14 +00:00
westi
7b0389984e
Ensure the Parent menu is hilighted correctly when Custom Post Types are shown under an existing top level menu. Fixes #16015 props duck_.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-29 16:25:22 +00:00
nacin
a717edca97
Always exit after wp_redirect. props filosofo, fixes #15518 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
dd32
4f3b9f7b7f
Use Absolute URL's & API's in header redirects in more locations. See #14062
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 10:43:43 +00:00
nacin
3507e2b200
Remove wp-admin/sidebar.php. fixes #15164 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-20 09:58:21 +00:00
westi
0c850182dc
Ensure that QuickPress media uploads get attached to the auto-draft we create for new posts correctly. Fixes #10917 props ocean90.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-23 07:58:06 +00:00
nacin
7734a07cb2
Move post type object capabilities to a 'cap' object. Allow them to be initialized via the 'capabilities' key (an array) when registering support for the post type. Caps are now referred to by the name of the cap as if it was a post, i.e. ->cap->edit_post. see #13358 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 20:45:18 +00:00
nbachiyski
46afe7c285
I18n for custom post type labels. Props demetris, dimadin. Fixes #12968
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-11 19:52:50 +00:00
nbachiyski
049af4a425
Trash should always be in titlecase for consistency
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-20 14:54:36 +00:00
nacin
6ec7cb4540
Use relative paths when including files, avoiding include_path. fixes #12594 , props sorich87.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 06:14:45 +00:00
nacin
340acf8263
Don't enqueue unnecessary scripts when the post type doesn't support the editor. fixes #12590 , props scribu, _duck.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-16 14:03:48 +00:00
dd32
679250491d
Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-20 02:01:46 +00:00
dd32
8136de990c
Introduce 'singular_label' for Post Types. Props scribu. See #12214
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 08:56:38 +00:00