Commit Graph

27 Commits

Author SHA1 Message Date
Sergey Biryukov 30b61fc9e8 Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.
Built from https://develop.svn.wordpress.org/trunk@47886


git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
Sergey Biryukov 7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov dcb08f0637 Docs: Fix placement of some duplicate hook references.
Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references.

Includes minor code layout fixes.

See #47110.
Built from https://develop.svn.wordpress.org/trunk@46088


git-svn-id: http://core.svn.wordpress.org/trunk@45900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-10 19:23:55 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast 28a8f31ffa Coding Standards: Add missing translator comments.
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin 5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Lance Willett 25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:50:11 +00:00
lancewillett 0188837271 Twenty Eleven and Twenty Twelve: fix incorrect end HTML comment left over from Twenty Ten.
See #19978.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 05:44:31 +00:00
ryan 6e8e8298d0 Back compat for twentyeleven. Props duck_. fixes #19504
git-svn-id: http://svn.automattic.com/wordpress/trunk@19584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-10 19:43:49 +00:00
ryan dd64f17ab7 More consistent attribute escaping. Props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-10 19:18:51 +00:00
ryan fdc7409251 twentyeleven code tidy up. Props dd32, lancewillett. fixes #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-30 21:57:50 +00:00
dd32 ee1bb15914 Consistently wrap the "Pages:" text in <span> tags, Combine the 2 identical translations for the Pages text (one with, and one without, span tags). See #17744
git-svn-id: http://svn.automattic.com/wordpress/trunk@18312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-14 15:14:24 +00:00
dd32 27ec6b7e00 Remove debug comments & more housecleaning. See #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 03:44:42 +00:00
azaozz 3a29a3d893 Twenty Eleven code review and cleanup, props dd32, fixes #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 23:01:16 +00:00
nacin 53cd4287e1 Twenty Eleven: escaping frenzy, hide authors if a single author blog. props DH-Shredder, props iandstewart, see #17385, fixes #17563.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 21:57:18 +00:00
azaozz 853d1ab1a2 Implement rel="author" in Twenty Eleven and Twenty Ten, props joostdevalk, fixes #17722
git-svn-id: http://svn.automattic.com/wordpress/trunk@18189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-08 02:02:09 +00:00
iandstewart 66beb266a1 Twenty Eleven: bug fixes and enhancements ...
* Improvements to the dark color scheme; Props matveb
* Remove link colors from the dark color scheme and let the default link color cascade
* Check for multiple authors before showing author information on single posts
* Remove the span before the edit link on the image template
* Add a comment icon; Props hugobaeta
* Replace the default reply text with an icon to prevent i18n issues with the design; Props matveb
* Don't output sidebar on the no sidebar layout
* Use the search form styling from the header for all search forms
* Style fixes for no search results page
* Fixes for fancy blockquote styles
* Style fixes for the showcase slider
* Margin for galleries
* Only showing the top post navigation on paged results
* Remove floats from images for the smallest screen sizes


git-svn-id: http://svn.automattic.com/wordpress/trunk@18072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-30 01:29:55 +00:00
iandstewart ef03662627 Twenty Eleven: make categories and tags i18n friendly; Props dimadin; Fixes #17531
git-svn-id: http://svn.automattic.com/wordpress/trunk@18029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 15:19:33 +00:00
nacin 7f98b9beaf Fix Twenty Eleven phpdoc subpackage names. props zeo, fixes #17444.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 19:06:09 +00:00
iandstewart ff4d0e5249 Twenty Eleven: updated DocBlock comments following Twenty Ten's example; See #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-02 21:04:44 +00:00
lancewillett 972a41501e Twenty Eleven: strip trailing spaces, props kawauso - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:34:52 +00:00
matt 7d581043df Importing Duster theme, first pass at a candidate for twentyeleven theme.
Nice to have, but optional, improvements it'd be nice to have:

* Ability to have random rotating headers. (Core improvement to custom header functionality.)
* Color and layout options.
* More post formats. (Currently supporst  Asides, Links, and Galleries.)
* CMS-style slider home page option.

Welcome, TwentyEleven née Duster. :) Track at #17198.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 21:46:33 +00:00