Commit Graph

62 Commits

Author SHA1 Message Date
Gary Pendergast be127956e0 Bundled Themes: Run the `pingback_url` through `esc_url()`.
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.

Props soulseekah, sharaz.
Fixes #43717.


Built from https://develop.svn.wordpress.org/trunk@44500


git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast c90cfa3b50 General: Fix some precision alignment formatting warnings.
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
Lance Willett ff5628169e Twenty Ten: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31266


git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:44 +00:00
Sergey Biryukov 2c97f4640b Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes.
props psoluch, rob1n.
fixes #16468.
Built from https://develop.svn.wordpress.org/trunk@28250


git-svn-id: http://core.svn.wordpress.org/trunk@28078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:28 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 6268f714e0 Twenty Ten: update code comments to reflect WP inline docs standards. Props DrewAPicture, closes #25256.
Built from https://develop.svn.wordpress.org/trunk@25627


git-svn-id: http://core.svn.wordpress.org/trunk@25544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 17:04:10 +00:00
Lance Willett 399ab4bb59 Twenty Ten and Twenty Eleven: revert r23720 and r23721 (closes #23772) and r23718 and r23719 (closes #23774).
Unfortunately, it's too late for these improvements in older themes since it's very likely they'll adversely affect child themes.

git-svn-id: http://core.svn.wordpress.org/trunk@23778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-22 16:15:24 +00:00
Lance Willett f4b2484cc9 Twenty Ten: use callback in functions.php to enqueue scripts and styles rather than putting them directly in header.php template file. Props obenland, fixes #23772.
git-svn-id: http://core.svn.wordpress.org/trunk@23721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:24:45 +00:00
Lance Willett 24e099bb3e Twenty Ten: use a filter to modify the output of `wp_title()`. Props obenland, closes #23774.
git-svn-id: http://core.svn.wordpress.org/trunk@23719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:16:47 +00:00
ryan 55958522c1 Back compat for bundled themes. Props nacin, SergeyBiryukov, kobenland. fixes #20768
git-svn-id: http://core.svn.wordpress.org/trunk@20983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 14:43:19 +00:00
nacin fa631702a6 Flexible heights for Twenty Ten's custom headers. see #20448.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-15 20:51:24 +00:00
nacin 1a265e464c Move Twenty Ten and the rest of Twenty Eleven to add_theme_support() for headers and backgrounds. props sabreuse for initial patch. fixes #20265. see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 21:32:42 +00:00
ryan 9f5c80eb92 Use one space, not two, after trailing punctuation. Prop Zeo. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-16 17:13:16 +00:00
nacin 82f597e296 Check for theme support before calling has_post_thumbnail for child theme compatibility. see #14903.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-14 19:16:21 +00:00
nacin 1e161cfe48 Don't pass optional argument with its default value. props hakre, fixes #15450.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:33:08 +00:00
nacin a92dc7abaf Check for header image before showing it, in Twenty Ten. props koopersmith, see #14486 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-23 05:58:55 +00:00
nacin c43b5bc26b Update to Twenty Ten 1.0.3 from theme dir. see #14284.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-12 19:40:21 +00:00
nacin 4c53975440 Use wp_title() proper in Twenty Ten, and move the janky stuff to a filter. see #13751.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 18:26:53 +00:00
nacin 9880197be6 Use default wp_nav_menu sorting in Twenty Ten. props iandstewart, fixes #13660.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-31 21:13:24 +00:00
nacin a35791a4ae In Twenty Ten, final pass on inline docs et al. props jorbin, zeo. fixes #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 18:56:27 +00:00
nacin f713b87e31 In Twenty Ten, documentation and code improvements. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 06:36:11 +00:00
nacin ff66f09ec9 @subpackage cannot have spaces.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 17:10:21 +00:00
nacin a743de0788 First pass on 'Theme Locations' for navigation menus. Themes need to specify a location when calling wp_nav_menu and register locations in functions.php. Users then map menus to locations in the nav menu admin. Subject to review. see #13378.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 06:20:30 +00:00
wpmuguru 21bef33fc6 add menu slots/theme_menus, props ryan, see #13378
git-svn-id: http://svn.automattic.com/wordpress/trunk@14611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-13 22:14:54 +00:00
westi 5bcf419601 Add ARIA landmark roles to TwentyTen. Fixes #13055 props demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 21:10:12 +00:00
nbachiyski 41d8837397 Various twentyten i18n fixes. Props zeo, dimadin. Fixes #13198
git-svn-id: http://svn.automattic.com/wordpress/trunk@14544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 20:30:58 +00:00
nbachiyski d4e3352f1e I18n fixes for header.php in Twentyten. Props zeo. See #13198
git-svn-id: http://svn.automattic.com/wordpress/trunk@14535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 06:04:14 +00:00
nacin 3e035809a1 Twenty Ten spacing and string cleanups. props zeo, markmcwilliams. see #13198. Add a twentyten_credits filter, props nathanrice, fixes #12804. Also clean up the generator/credits string.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 07:01:09 +00:00
ryan a35bf04b19 Use get_search_query(). Props zeo. see #13198
git-svn-id: http://svn.automattic.com/wordpress/trunk@14388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 19:28:04 +00:00
nacin 1f94349afb Check thread_comments before loading the comment-reply script. props ptahdunbar, fixes #12932
git-svn-id: http://svn.automattic.com/wordpress/trunk@14339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-02 20:51:30 +00:00
iammattthomas f0b91458e4 In Twenty Ten, fix the ordering of items in the title tag.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-28 17:17:42 +00:00
iammattthomas 6dfe0a43ac In Twenty Ten, remove the pipe separator from the title when there is no blog description. Props noel.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-28 17:11:18 +00:00
dd32 b22d2ea457 Move all Feature Images => header image integration into a is_singular() check. Prevents a PHP notice when $post is not set (For example, a 404 page). Fixes #12661
git-svn-id: http://svn.automattic.com/wordpress/trunk@14002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-05 02:58:39 +00:00
nacin a4c7fb5869 Rough cut of Twenty Ten inline documentation. see #12695. props jorbin, demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-29 22:03:15 +00:00
iammattthomas 0fe0c542ec Merge twentyten print style into style.css. Fixes #12733. Props demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-29 00:48:03 +00:00
iammattthomas 45b1a1fe24 A compromise approach for #12542 -- Treat site-title as H1 on front page, unless it's a static page.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-27 21:50:39 +00:00
iammattthomas 209d4a7a2e Twenty Ten: Don't use post thumbnail as the custom header if it's smaller than the header size. See #12661. Props iandstewart
git-svn-id: http://svn.automattic.com/wordpress/trunk@13836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-27 01:59:46 +00:00
nacin 40773a776b Remove trailing whites and double semicolons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:36:49 +00:00
iammattthomas 8babcc5d7c Replace query strings with arras in Twenty Ten, see #12698. Props demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 05:37:55 +00:00
iammattthomas a70633cedc Coding standards cleanup in twentyten, see #9015. Props sivel
git-svn-id: http://svn.automattic.com/wordpress/trunk@13720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-16 20:17:22 +00:00
ryan f635d99754 Menus rework. Props ptahdunbar. see #11817
git-svn-id: http://svn.automattic.com/wordpress/trunk@13704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-15 16:26:46 +00:00
iammattthomas f1961ae08d Moving mobile webkit styles to style.css; adjusting widget_search label and site-description sizes. See #12303
git-svn-id: http://svn.automattic.com/wordpress/trunk@13566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 00:38:00 +00:00
iammattthomas 2d85143b5e Use a short HTML5-style charset declaration in twentyten, props demetris. See #12483
git-svn-id: http://svn.automattic.com/wordpress/trunk@13565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 00:19:18 +00:00
nacin 750448871a Cleaner and ideally future-proof detection of mobile Safari browsers. see #12303
git-svn-id: http://svn.automattic.com/wordpress/trunk@13555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-02 18:48:31 +00:00
iammattthomas 03e8e13e3d Add mobile webkit styles for twentyten. See #12303
git-svn-id: http://svn.automattic.com/wordpress/trunk@13554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-02 18:43:22 +00:00
ryan 25a2a06a9e Menu enhancements. Props ptahdunbar. fixes #11817
git-svn-id: http://svn.automattic.com/wordpress/trunk@13512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-28 20:00:49 +00:00
dd32 7b2c083769 Better internationalisation for TwentyTen. Props filosofo. Fixes #12384
git-svn-id: http://svn.automattic.com/wordpress/trunk@13498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-28 11:43:04 +00:00
ryan 091d1150d3 Fallback to wp_page_menu() from wp_nav_menu() if no menus are setup. Use wp_nav_menu() in twentyten. see #11817
git-svn-id: http://svn.automattic.com/wordpress/trunk@13368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 08:45:26 +00:00