Scott Taylor
432f9891f7
Ensure that private posts cannot be made sticky via Quick Edit.
...
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.
Props wonderboymusic, obenland, chriscct7.
Fixes #20662 .
Built from https://develop.svn.wordpress.org/trunk@33325
git-svn-id: http://core.svn.wordpress.org/trunk@33297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 18:09:25 +00:00
Ella Iseulde Van Dorpe
dac985cdc4
Editor: Add Media should be a button
...
Props afercia.
Fixes #32969 .
Built from https://develop.svn.wordpress.org/trunk@33298
git-svn-id: http://core.svn.wordpress.org/trunk@33270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:38:23 +00:00
Konstantin Obenland
2883bbbb68
Customize: Provide a default way to save cropped images.
...
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.
Props celloexpressions for initial patch.
Fixes #29211 .
Built from https://develop.svn.wordpress.org/trunk@33280
git-svn-id: http://core.svn.wordpress.org/trunk@33252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:54:25 +00:00
Scott Taylor
4d34e37311
List Tables:
...
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.
Props wonderboymusic, paulwilde.
Fixes #29881 .
Built from https://develop.svn.wordpress.org/trunk@33270
git-svn-id: http://core.svn.wordpress.org/trunk@33242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:47:24 +00:00
Konstantin Obenland
4f94d3a969
Media: Don't indent action links if there is no media icon.
...
See #32254 .
Built from https://develop.svn.wordpress.org/trunk@33269
git-svn-id: http://core.svn.wordpress.org/trunk@33241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:46:24 +00:00
Konstantin Obenland
2a0ddf8523
Media: Reduce link noise between icons and titles in list view.
...
Props afercia.
Fixes #32254 .
Built from https://develop.svn.wordpress.org/trunk@33268
git-svn-id: http://core.svn.wordpress.org/trunk@33240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:24:26 +00:00
Helen Hou-Sandí
4182df24f8
List tables: Even more robust fallback for the primary column.
...
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.
props ocean90.
fixes #32996 .
Built from https://develop.svn.wordpress.org/trunk@33266
git-svn-id: http://core.svn.wordpress.org/trunk@33238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 16:18:25 +00:00
Konstantin Obenland
542e01162f
Media: Remove `post_type` variable, unused since [32676].
...
Fixes #32948 .
Built from https://develop.svn.wordpress.org/trunk@33263
git-svn-id: http://core.svn.wordpress.org/trunk@33235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 15:06:25 +00:00
Dion Hulse
43077a6ef8
Updates: When performing an ajax plugin update, rely upon `wp_update_plugins()` to check the contents of the transient and return early if no request needs to be made.
...
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk
Built from https://develop.svn.wordpress.org/trunk@33257
git-svn-id: http://core.svn.wordpress.org/trunk@33229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 08:01:25 +00:00
Drew Jaynes
e4ecc7e5c4
Fix summaries and add missing `@global` descriptions to the `upgrade_430_fix_comments()` and `split_all_shared_terms()` functions added in 4.3.
...
See [33020], [32643]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33212
git-svn-id: http://core.svn.wordpress.org/trunk@33184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 19:56:24 +00:00
Drew Jaynes
f9194e361c
Add a description for the dynamic portion of the `nav_menu_items_{$post_type_name}_recent` filter added in 4.3.
...
See [32833]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33211
git-svn-id: http://core.svn.wordpress.org/trunk@33183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 19:51:24 +00:00
Drew Jaynes
2d0721aab9
Fix the summary for the `WP_Users_List_Table->get_default_primary_column_name()` method added in 4.3.
...
See [32644]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33210
git-svn-id: http://core.svn.wordpress.org/trunk@33182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 19:48:25 +00:00
Drew Jaynes
0322d0e89b
Fix inline documentation syntax in the `WP_Upgrader->clear_destination()` method added in 4.3.
...
See [32854]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33209
git-svn-id: http://core.svn.wordpress.org/trunk@33181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 19:46:25 +00:00
Drew Jaynes
f9070e11b4
Fix summaries for two methods added to `WP_Terms_List_Table` in 4.3.
...
See [32644]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33207
git-svn-id: http://core.svn.wordpress.org/trunk@33179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 18:22:25 +00:00
Drew Jaynes
d1a3d2e6ea
Add missing summaries, `@access` tags, and some parameter descriptions for methods added to `WP_Links_List_Table` in 4.3.
...
See [32753]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33204
git-svn-id: http://core.svn.wordpress.org/trunk@33176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 18:03:24 +00:00
Konstantin Obenland
2829827c1c
Site Icon: Add Android-specific app icon.
...
Falling back to Apple app icons is deprecated behavior and will not work
forever. 192px is the recommended size for that icon.
Props kraftbj.
Fixes #32964 .
Built from https://develop.svn.wordpress.org/trunk@33202
git-svn-id: http://core.svn.wordpress.org/trunk@33174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:58:47 +00:00
Drew Jaynes
5ebb6855b6
Add missing summaries, `@access` tags, and some parameter descriptions for methods added to `WP_MS_Sites_List_Table` in 4.3.
...
See [32755]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33199
git-svn-id: http://core.svn.wordpress.org/trunk@33171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:53:24 +00:00
Drew Jaynes
88229587c0
Improving formatting for various pieces of inline documentation in the new `WP_Site_Icon` class added in 4.3.
...
See [32994]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33198
git-svn-id: http://core.svn.wordpress.org/trunk@33170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:51:24 +00:00
Drew Jaynes
b2cc4de9b2
Add missing summaries, `@access` tags, and some parameter descriptions to methods added to `WP_Posts_List_Table` in 4.3.
...
See [32740]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33197
git-svn-id: http://core.svn.wordpress.org/trunk@33169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:49:25 +00:00
Drew Jaynes
9a2261d3bf
Fix the DocBlock summary for `WP_Plugins_List_Table->get_primary_column_name()`, added in 4.3.
...
See [32644]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33196
git-svn-id: http://core.svn.wordpress.org/trunk@33168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:46:26 +00:00
Drew Jaynes
3361f39479
Add missing summaries and parameter descriptions to new methods added to `WP_MS_Users_List_Table` in 4.3.
...
See [32757]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33195
git-svn-id: http://core.svn.wordpress.org/trunk@33167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 17:43:25 +00:00
Drew Jaynes
5961dbb65b
Add missing summaries to new methods added to `WP_MS_Themes_List_Table` in 4.3.
...
See [32756]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33193
git-svn-id: http://core.svn.wordpress.org/trunk@33165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 16:13:26 +00:00
John Blackbourn
f3eba1581c
Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size.
...
Props andg
Fixes #32804
Built from https://develop.svn.wordpress.org/trunk@33192
git-svn-id: http://core.svn.wordpress.org/trunk@33164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 15:32:25 +00:00
John Blackbourn
396cc7b2e4
Correct a parameter name in the docs for `wp_insert_category()`.
...
Built from https://develop.svn.wordpress.org/trunk@33190
git-svn-id: http://core.svn.wordpress.org/trunk@33162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 12:59:25 +00:00
John Blackbourn
1f7a3bc58d
Append the current locale to dashboard RSS widget cache keys so they refresh accordingly when the locale is changed.
...
Fixes #32804
Props andg
Built from https://develop.svn.wordpress.org/trunk@33183
git-svn-id: http://core.svn.wordpress.org/trunk@33155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 22:07:25 +00:00
Konstantin Obenland
13ab10fff7
Site Icon: Improve a11y in Settings.
...
Props afercia.
Fixes #32970 .
Built from https://develop.svn.wordpress.org/trunk@33180
git-svn-id: http://core.svn.wordpress.org/trunk@33152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 19:43:24 +00:00
Drew Jaynes
967b04a7f8
Add missing summaries and `@access` tags to methods added to `WP_Media_List_Table` in 4.3.
...
See [32754]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33179
git-svn-id: http://core.svn.wordpress.org/trunk@33151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 18:34:24 +00:00
Drew Jaynes
d7c887fe5d
Fix the summaries for a few methods and hooks added to `WP_List_Table` in 4.3.
...
See [32644]. See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33178
git-svn-id: http://core.svn.wordpress.org/trunk@33150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 18:32:24 +00:00
Drew Jaynes
703d4c259c
Fix filter doc vernacular for the new `wp_ajax_cropped_attachment_id` hook added in 4.3.
...
See #32891 .
Built from https://develop.svn.wordpress.org/trunk@33176
git-svn-id: http://core.svn.wordpress.org/trunk@33148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 18:26:24 +00:00
Jeremy Felt
9f0506e3b2
Add better handling for actions and messaging in MS Sites List Table row actions
...
* Simplify URLs used for row actions to remove messaging and site domain/path.
* Use confirmation messaging from a managed list of actions when handling the request.
* Find the site address from the site ID rather than using information passed in the URL.
Fixes #32963 .
Built from https://develop.svn.wordpress.org/trunk@33173
git-svn-id: http://core.svn.wordpress.org/trunk@33145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 02:36:26 +00:00
Helen Hou-Sandí
6e73f1282e
List tables: Better accessibility and design for the comments bubble.
...
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.
props picard102, afercia, karinchristen.
fixes #32152 .
Built from https://develop.svn.wordpress.org/trunk@33155
git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:44:25 +00:00
Konstantin Obenland
f29e5044cd
Site Icon: Add Customizer UI.
...
Second part of the Site Icon feature after [32994] introduced it for Settings.
Props celloexpressions.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33154
git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:33:24 +00:00
Dominik Schilling
75d6c10b01
Customizer: Use a `<button>` for the collapse sidebar … button.
...
props afercia.
fixes #32819 .
Built from https://develop.svn.wordpress.org/trunk@33153
git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:22:26 +00:00
Jeremy Felt
0bc0b0c917
Do not allow deletion of a super admin user through `wpmu_delete_user()`.
...
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.
Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935 .
Built from https://develop.svn.wordpress.org/trunk@33143
git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:16:25 +00:00
Andrew Ozz
4cd790906f
TinyMCE, Press This: add the `wptextpattern` plugin to the Press This editor.
...
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@33128
git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:53:25 +00:00
Helen Hou-Sandí
9c3bc85649
Ensure error messages look like, well, errors.
...
props obenland, rachelbaker.
fixes #32475 .
Built from https://develop.svn.wordpress.org/trunk@33117
git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:11:24 +00:00
Scott Taylor
0deed4b842
In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present.
...
Props tyxla.
Fixes #32889 .
Built from https://develop.svn.wordpress.org/trunk@33114
git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:19:24 +00:00
Helen Hou-Sandí
0b046085ae
Show row actions on focus for the dashboard comment list.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33106
git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Helen Hou-Sandí
81c2f541b0
List tables: Add a fallback for the primary column.
...
Without a primary column defined, nothing shows in the responsive view at all, which is bad.
props mordauk.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33104
git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:12:27 +00:00
Helen Hou-Sandí
df220685a0
List tables: Account for comments being reused on the post edit screen.
...
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33101
git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:09:24 +00:00
Jeremy Felt
c9027b00ba
Assign proper active class when showing plugin updates in network admin
...
Previously, a plugin would trigger an active class if it was active on the network's main site.
Fixes #32901 .
Built from https://develop.svn.wordpress.org/trunk@33100
git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:02:24 +00:00
Jeremy Felt
3faebf40a6
Remove unused `$current_site` global in MS Sites list table
...
Found itself unused after [32719].
See #32434 .
Built from https://develop.svn.wordpress.org/trunk@33097
git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:51:25 +00:00
Konstantin Obenland
c9a29b0123
Check for all required caps before (un)sticking a post.
...
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.
Props ericmann, chriscct7.
Fixes #24153 .
Built from https://develop.svn.wordpress.org/trunk@33096
git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:41:25 +00:00
Sergey Biryukov
c543f98ee6
Plugins list table: Add an `aria-label` attribute with the plugin name to plugin action links to provide context for screen reader users.
...
props bramd, rianrietveld, afercia.
fixes #26167 .
Built from https://develop.svn.wordpress.org/trunk@33087
git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 15:03:25 +00:00
Konstantin Obenland
664b0373dc
Site Icon: Switch to using H1 headings.
...
See #31650 .
Props afercia.
Fixes #32885 .
Built from https://develop.svn.wordpress.org/trunk@33084
git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 18:49:27 +00:00
Jeremy Felt
767ed1e9b1
Use the full site URL in `choose_primary_blog()` when a user is a member of only one site.
...
Aligns with the output used when a user is a member of multiple sites.
Fixes #32884 .
Built from https://develop.svn.wordpress.org/trunk@33081
git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:21:24 +00:00
Sergey Biryukov
b2299463b6
Plugins list table: Use case-insensitive sorting.
...
props GaryJ.
fixes #32735 .
Built from https://develop.svn.wordpress.org/trunk@33076
git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:53:25 +00:00
Konstantin Obenland
cf22cd7d72
Site Icon: Remove date dropdown from media modal.
...
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.
Props ocean90.
Fixes #32860 .
Built from https://develop.svn.wordpress.org/trunk@33075
git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:28:24 +00:00
Dion Hulse
ceaec85751
Press This: Rewrite `WP_Press_This::fetch_source_html()` to utilise the HTTP API better without the need for a local temporary file.
...
This reverts [33061] but keeps it's custom UA string.
See #32864
Built from https://develop.svn.wordpress.org/trunk@33062
git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 12:01:25 +00:00
Sergey Biryukov
fc8c36eb97
Press This: Set explicit user agent.
...
props kraftbj.
fixes #32864 .
Built from https://develop.svn.wordpress.org/trunk@33061
git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 11:17:24 +00:00