Commit Graph

80 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Sergey Biryukov dd185824cd Docs: Fix typo in `_walk_bookmarks()` DocBlock.
Props abhijitrakas.
Fixes #44242.
Built from https://develop.svn.wordpress.org/trunk@43319


git-svn-id: http://core.svn.wordpress.org/trunk@43148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-27 08:36:23 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Drew Jaynes b7fc55237d Docs: Standardize filter docs in wp-includes/bookmark-template.php to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37494


git-svn-id: http://core.svn.wordpress.org/trunk@37462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:24:28 +00:00
Scott Taylor 744cc75cd1 Sanitize the class passed to `wp_list_bookmarks()` and allow passing an array.
Props ryan, obenland.
Fixes #23150.

Built from https://develop.svn.wordpress.org/trunk@32906


git-svn-id: http://core.svn.wordpress.org/trunk@32877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:55:28 +00:00
Scott Taylor bd8fafea54 Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:40:25 +00:00
Drew Jaynes 8f6188ae53 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Two arguments in `_walk_bookmarks()`
* A code snippet in the class header for `WP_Roles`
* A code snippet in the class header for `WP_HTTP_Proxy`
* Inline code fixes in the summary and a parameter description for `WP_oEmbed::discover()`
* An argument description in `_WP_Editors::parse_settings()`
* Inline code fixes in the summary and a parameter description the `embed_oembed_discover` hook.

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30536


git-svn-id: http://core.svn.wordpress.org/trunk@30525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:42:22 +00:00
Drew Jaynes dcccc6af4a Add indentation for the hash notation missed in [29108].
See #28841.

Built from https://develop.svn.wordpress.org/trunk@29109


git-svn-id: http://core.svn.wordpress.org/trunk@28895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 22:59:16 +00:00
Drew Jaynes 805e0fa692 Convert default arguments documentation for `_walk_bookmarks()` and `wp_list_bookmarks()` into hash notations.
Props coffee2code for the initial patch.
See #28841.

Built from https://develop.svn.wordpress.org/trunk@29108


git-svn-id: http://core.svn.wordpress.org/trunk@28894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 22:54:14 +00:00
Scott Taylor 5d72cd4949 In `wp_list_bookmarks()`, `$categorize` should now be `$r['categorize]`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28501


git-svn-id: http://core.svn.wordpress.org/trunk@28327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:11:14 +00:00
Scott Taylor 54321f4c6e Eliminate use of `extract()` in `get_media_item()`.
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor 9d6eeca015 Eliminate use of `extract()` in `wp_list_bookmarks()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28405


git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:18:16 +00:00
Scott Taylor 748765c5ad Eliminate use of `extract()` in `_walk_bookmarks()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28404


git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:05:15 +00:00
Andrew Nacin 803d4ff54d Remove old links_recently_updated_* DB options that never had a UI.
fixes #27649.

Built from https://develop.svn.wordpress.org/trunk@27916


git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:10:15 +00:00
Drew Jaynes 7c38bb38b7 Use a docs-specific variable for the `link_category` hook docs in wp-admin/bookmarks-template.php.
See #25364.

Built from https://develop.svn.wordpress.org/trunk@26980


git-svn-id: http://core.svn.wordpress.org/trunk@26857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-18 16:58:13 +00:00
Drew Jaynes 9577cc4640 Inline documentation for hooks in wp-includes/bookmark-template.php.
Props vinod dalvi, kpdesign.
Fixes #25364.

Built from https://develop.svn.wordpress.org/trunk@25533


git-svn-id: http://core.svn.wordpress.org/trunk@25453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 23:09:09 +00:00
Ryan Boren efcc9adf34 In wp_list_bookmarks(), don't stomp the categorize argument. Fixes categorized display in the links widget.
fixes #22216


git-svn-id: http://core.svn.wordpress.org/trunk@22910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 23:19:03 +00:00
Andrew Nacin 30d4885613 Avoid notices with [22426]. props pross. fixes #22420.
git-svn-id: http://core.svn.wordpress.org/trunk@22565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 05:09:23 +00:00
Andrew Nacin 5e4cb3af70 Display links if no link categories exist. props MikeHansenMe. fixes #22216.
git-svn-id: http://core.svn.wordpress.org/trunk@22426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:25:18 +00:00
Andrew Nacin 557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
markjaquith d65e49c9f3 Bunch of PHPDoc corrections and cleanups. props c3mdigital. props SergeyBiryukov. fixes #21149
git-svn-id: http://core.svn.wordpress.org/trunk@21241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 05:03:53 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 059d7225fb Refresh deprecated bookmark functions. Props filosofo. fixes #10920
git-svn-id: http://svn.automattic.com/wordpress/trunk@12525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-23 18:49:22 +00:00
ryan 8513b29792 Prophylactic escapes
git-svn-id: http://svn.automattic.com/wordpress/trunk@11838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-18 16:05:07 +00:00
markjaquith 3ebf837ced Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url()
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 16:00:33 +00:00
markjaquith 6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
azaozz 154896f99d Add a space between image and name in bookmark-template.php, props sivel, fixes #8608
git-svn-id: http://svn.automattic.com/wordpress/trunk@11184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 02:23:40 +00:00
ryan 2d489767bb s/attribute_escape/attr/. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 05:58:45 +00:00
ryan 2b430c9751 Links widget options. Props DD32. see #9196
git-svn-id: http://svn.automattic.com/wordpress/trunk@10712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-04 23:49:21 +00:00
ryan 9fd20b9893 Update _walk_bookmarks phpdoc. Props brh and sivel. fixes #8607 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@10207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-16 07:54:17 +00:00
ryan e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
ryan 2d1010a8fb Don't use deprecated functions. Props filosofo. fixes #8130
git-svn-id: http://svn.automattic.com/wordpress/trunk@9590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-10 17:45:38 +00:00
ryan fc81ae374d Formatting cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@9410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-30 04:07:24 +00:00
ryan 611bbf9955 wp_list_bookmarks should always show name if there is no image to show. Props mtdewvirus. fixes #7981
git-svn-id: http://svn.automattic.com/wordpress/trunk@9366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-27 16:23:07 +00:00
ryan 1f1409a786 link_before and link_after from thee17. fixes #5652
git-svn-id: http://svn.automattic.com/wordpress/trunk@9202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-16 19:13:30 +00:00
ryan 586e660529 Add show_name to wp_list_bookmarks(). Props Otto42. fixes #7847
git-svn-id: http://svn.automattic.com/wordpress/trunk@9139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-13 22:43:05 +00:00
westi f7b32217a3 phpDoc corrections for wp-includes. See #7550 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-27 06:45:13 +00:00
azaozz 643f76d20c Fix typo in bookmark template. Props brianwhite, fixes #7414 for 2.7
git-svn-id: http://svn.automattic.com/wordpress/trunk@8463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-26 19:56:08 +00:00
ryan 9e585b7c30 Add exclude_category argument to wp_list_bookmarks(). Props ionfish. fixes #6808
git-svn-id: http://svn.automattic.com/wordpress/trunk@8183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-24 17:44:30 +00:00
westi 829ac35bbe Add xoxo microformat markup to the blogroll. Fixes #4954 props Otto42.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-20 13:54:23 +00:00
ryan d69adece5a category_name is not a valid arg. Use name__like. Props drdavid. fixes #6722 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@8104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-16 22:19:34 +00:00
ryan 62784a594f phpdoc updates from jacobsantos. see #7038
git-svn-id: http://svn.automattic.com/wordpress/trunk@7990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-25 15:45:05 +00:00
ryan 938f29414f Use array calling style. see #6647
git-svn-id: http://svn.automattic.com/wordpress/trunk@7911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-08 19:19:58 +00:00
westi ab4ce8237d '>"
git-svn-id: http://svn.automattic.com/wordpress/trunk@6828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-13 21:56:56 +00:00
ryan 3b04c16b5e Add wp_list_bookmarks filter. Props codealsatian. fixes #5532
git-svn-id: http://svn.automattic.com/wordpress/trunk@6822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-13 18:47:34 +00:00
ryan d88983793b Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 06:47:27 +00:00
westi 30145d1a56 Add documentation for bookmark-template.php. Fixes #5521 props darkdragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-24 07:04:29 +00:00
westi 1f889417e5 Fix some of the notices visible with WP_DEBUG enabled.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-20 21:25:12 +00:00
ryan a48973211c Fix typo. fixes #5061
git-svn-id: http://svn.automattic.com/wordpress/trunk@6161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-24 01:48:36 +00:00
ryan 8d349aa85c Add some filtering. Props jhodgdon. fixes #3595
git-svn-id: http://svn.automattic.com/wordpress/trunk@6160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-23 19:25:15 +00:00