e5f57d2870
TinyMCE: fix the tooltip for 'alignnone' button on the image toolbar. Props johnbillion, see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30385
git-svn-id: http://core.svn.wordpress.org/trunk@30382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 17:27:22 +00:00
9b9289e0a3
Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates.
...
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.
Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424
See #10205 , #30245
Built from https://develop.svn.wordpress.org/trunk@30384
git-svn-id: http://core.svn.wordpress.org/trunk@30381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 05:40:23 +00:00
d95b5196cc
Improvements to `wp_make_link_relative()`.
...
* Support relative URL input.
* When the URL being made relative has another URL as a parameter, don't make the second URL relative.
Props voldemortensen.
Fixes #30373 .
Built from https://develop.svn.wordpress.org/trunk@30383
git-svn-id: http://core.svn.wordpress.org/trunk@30380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 01:53:24 +00:00
e34a587ea6
Add some missing inline documentation for methods in the `WP_Widget` class in wp-includes/widgets.php.
...
Props ericlewis, jazzs3quence.
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30382
git-svn-id: http://core.svn.wordpress.org/trunk@30379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 22:58:22 +00:00
f7648300c8
Add missing documentation for the `$password` parameter, passed to the `check_password` hook.
...
Props coffee2code.
Fixes #30311 .
Built from https://develop.svn.wordpress.org/trunk@30381
git-svn-id: http://core.svn.wordpress.org/trunk@30378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 18:56:21 +00:00
51e7e8e695
Clarify/correct inline documentation in wp-includes/l10n.php.
...
* Add a missing `@return` description for `load_default_textdomain()`
* Clarify the `@param` description for `$locale` with an inline `@see` tag
* Ensure the correct parameter variable is used when documenting `$args` for `wp_dropdown_languages()`
Props camdensegal.
Fixes #30385 .
Built from https://develop.svn.wordpress.org/trunk@30380
git-svn-id: http://core.svn.wordpress.org/trunk@30377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 18:47:22 +00:00
5943966b69
Ensure the mixed type of `string|int` is reflected on the `$title` parameter in `wp_die()`.
...
The ability to pass an error code as short-hand to the `$title` and `$args` parameters was added in r30355. Changes also include cleaned-up formatting and line-wraps for other documentation in the DocBlock.
See [30355]. Fixes #10551 .
Built from https://develop.svn.wordpress.org/trunk@30379
git-svn-id: http://core.svn.wordpress.org/trunk@30376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 16:47:23 +00:00
5945363d82
Update the inline docs for the `keyEvent` callback in the media grid.
...
Props adamsilverstein
See #29725
Built from https://develop.svn.wordpress.org/trunk@30378
git-svn-id: http://core.svn.wordpress.org/trunk@30375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 04:29:23 +00:00
02c773efb0
Avoid re-registering the `keydown` event controller in the media grid so arrow controls don't skip media items.
...
Fixes #30348
Props UmeshSingla
Built from https://develop.svn.wordpress.org/trunk@30377
git-svn-id: http://core.svn.wordpress.org/trunk@30374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 04:28:22 +00:00
cca329174f
Improve Thickbox's close button so it can be announced by screen readers.
...
Fixes #29455
Props SergeyBiryukov
Built from https://develop.svn.wordpress.org/trunk@30376
git-svn-id: http://core.svn.wordpress.org/trunk@30373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 03:55:23 +00:00
739a20a659
WPDB: When a `db.php` drop-in is being used, and it doesn't explicitly define itself as connecting to MySQL, skip the character set checks. This ensures that existing drop-ins won't accidentally run checks that they don't support.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30375
git-svn-id: http://core.svn.wordpress.org/trunk@30372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 03:38:23 +00:00
e2a0c6a86d
Improve keyboard control of Edit Selection mode in the media manager.
...
See #29326
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@30374
git-svn-id: http://core.svn.wordpress.org/trunk@30371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 03:34:25 +00:00
254ff0a4c9
Add inline `@see` tags to the docs for the `get_categories_taxonomy` hook.
...
Props tw2113.
Fixes #30310 .
Built from https://develop.svn.wordpress.org/trunk@30370
git-svn-id: http://core.svn.wordpress.org/trunk@30368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 17:37:23 +00:00
14bf4939e4
WPDB: When removing invalid characters from utf8 strings in older versions of PHP, the regex was too large to be compiled.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@30366
git-svn-id: http://core.svn.wordpress.org/trunk@30365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 11:58:22 +00:00
ddbb5a850f
Remove a stray translator comment for a non-translatable string added in [30209] See #27238
...
Built from https://develop.svn.wordpress.org/trunk@30365
git-svn-id: http://core.svn.wordpress.org/trunk@30364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 04:36:25 +00:00
c61a028898
TinyMCE: fix the border on the image toolbar arrow. Props afercia, see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30363
git-svn-id: http://core.svn.wordpress.org/trunk@30362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 00:19:23 +00:00
69b529024a
Fix typo in [30361], see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30362
git-svn-id: http://core.svn.wordpress.org/trunk@30361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 23:15:23 +00:00
22b760088c
TinyMCE: don't show image toolbar for placeholder images. See #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30361
git-svn-id: http://core.svn.wordpress.org/trunk@30360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 23:12:22 +00:00
81858cdd99
Correctly wrap the text in long input labels in the media manager.
...
Fixes #23003
Props ramiabraham
Built from https://develop.svn.wordpress.org/trunk@30359
git-svn-id: http://core.svn.wordpress.org/trunk@30358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 19:01:22 +00:00
96e57d411b
Add `$depth` parameter to the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` filters.
...
Fixes #19064
Props cyclometh, chriscct7, johnbillion
Built from https://develop.svn.wordpress.org/trunk@30358
git-svn-id: http://core.svn.wordpress.org/trunk@30357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 07:37:22 +00:00
d88ed475b0
Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors.
...
Fixes #10551
Props nacin
Built from https://develop.svn.wordpress.org/trunk@30356
git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:16:22 +00:00
5f30f13780
Allow the response code to be passed as a shorthand to the `$title` or `$args` parameter of `wp_die()`, for brevity.
...
See #10551 and #11286
Props nacin
Built from https://develop.svn.wordpress.org/trunk@30355
git-svn-id: http://core.svn.wordpress.org/trunk@30354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:11:22 +00:00
b3e14b36ff
TinyMCE: fix the cursor appearance while it is outside the editor body. Props miyauchi, fixes #30112 .
...
Built from https://develop.svn.wordpress.org/trunk@30349
git-svn-id: http://core.svn.wordpress.org/trunk@30348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-15 01:21:22 +00:00
f561b53695
WordPress 4.1-beta1
...
Built from https://develop.svn.wordpress.org/trunk@30348
git-svn-id: http://core.svn.wordpress.org/trunk@30347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:57:24 +00:00
866cfdf19b
Flush cache for newly created term in `_split_shared_term()`.
...
The term itself does not have any cached values yet, but in some cases the new
term's taxonomy may need its cached hierarchy to be refreshed as a result of
the term splitting.
Props jorbin.
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30347
git-svn-id: http://core.svn.wordpress.org/trunk@30346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:53:22 +00:00
e61bebdbfc
If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30346
git-svn-id: http://core.svn.wordpress.org/trunk@30345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:34:22 +00:00
ecc27d0b27
When creating a post containing emoji, the post can be saved incorrectly if MySQL isn't using a character set that supports emoji.
...
This change prevents the save from occurring, so it can be handled correctly in the UI.
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30345
git-svn-id: http://core.svn.wordpress.org/trunk@30344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:28:22 +00:00
c5bb06dafe
Reinstate term splitting on term update.
...
Originally introduced in [30241] and reverted in [30336], term splitting is
back and better than ever. Now with *more unit tests* and *improved treatment
of child terms*!
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30344
git-svn-id: http://core.svn.wordpress.org/trunk@30343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:27:24 +00:00
fe63317dad
Sync our jQuery UI styles with jQuery UI 1.11.2 CSS.
...
Removes also our own implementations for touch-action compatibility for IE Touch.
props georgestephanis, ocean90.
fixes #26843 .
Built from https://develop.svn.wordpress.org/trunk@30343
git-svn-id: http://core.svn.wordpress.org/trunk@30342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 19:28:22 +00:00
52f51d65ae
Media: Remove another unused string.
...
props pavelevap.
see #29741 .
Built from https://develop.svn.wordpress.org/trunk@30342
git-svn-id: http://core.svn.wordpress.org/trunk@30341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 17:46:22 +00:00
f34d3b1b5a
Media: Remove unused string.
...
props pavelevap.
fixes #29741 .
Built from https://develop.svn.wordpress.org/trunk@30341
git-svn-id: http://core.svn.wordpress.org/trunk@30340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 17:31:23 +00:00
b922be3f71
Only use the 'Installed' optgroup in wp_dropdown_languages() if it's needed.
...
see #30335 .
Built from https://develop.svn.wordpress.org/trunk@30340
git-svn-id: http://core.svn.wordpress.org/trunk@30339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 03:24:23 +00:00
560574da45
TinyMCE: set the image toolbar's z-index higher than the editor when the new DFW is active. See #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30339
git-svn-id: http://core.svn.wordpress.org/trunk@30338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 23:29:22 +00:00
7c4b9419f4
Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance
...
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return
Feature plugin work happened here: https://github.com/avryl/focus
props avryl, azaozz, Michael Arestad
fixes #29806
Built from https://develop.svn.wordpress.org/trunk@30338
git-svn-id: http://core.svn.wordpress.org/trunk@30337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 22:31:22 +00:00
95513a0bca
When asserting microtime output as a number, make it a number
...
microtime is by default a string. Doing a greater then or less than check of that string is a bad idea since it uses the first part (the micro part of microtime) rather then the actual time. This adds a helper to convert microtime output into a float which we can then use to properly compare the output of microtime.
This fixes an intermittent test failure.
fixes #30336
Built from https://develop.svn.wordpress.org/trunk@30337
git-svn-id: http://core.svn.wordpress.org/trunk@30336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 22:04:23 +00:00
eb8f89bb13
Don't split shared terms on term update.
...
Splitting shared terms means assigning a new term_id to a given term_taxonomy_id.
It was uncovered that this change could cause problems for sites that have
cached the original term_id somehow - say, in postmeta - since future lookups
using that term_id will now fail.
Removing for 4.1-beta1. We'll look at improvements to backward compatibility
to try to get this back into a later beta.
Props mboynes.
See #30335 .
Built from https://develop.svn.wordpress.org/trunk@30336
git-svn-id: http://core.svn.wordpress.org/trunk@30335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 20:05:24 +00:00
8fb6f317ff
Site Language: Install translations on the fly.
...
The language dropdown now includes installed languages and all available translations when the filesystem is writable by WordPress.
Go to wp-admin/options-general.php, select one of the available translations, submit the form and let WordPress handle the rest.
Works for Multisite's Default Language too.
see #29395 .
Built from https://develop.svn.wordpress.org/trunk@30335
git-svn-id: http://core.svn.wordpress.org/trunk@30334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 17:01:24 +00:00
4a1cb796fc
Improvements to [30333]:
...
* Move `.hide-if-no-js` class to table row
* Add a wrapper class
* Add missing translators comment
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30334
git-svn-id: http://core.svn.wordpress.org/trunk@30333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 15:54:20 +00:00
c02845330e
Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared.
...
See #30264 .
Props jorbin, ocean90, johnbillion
Built from https://develop.svn.wordpress.org/trunk@30333
git-svn-id: http://core.svn.wordpress.org/trunk@30332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 15:21:21 +00:00
f93a197089
Fix selector for the "Live Widget Previews" feature pointer.
...
props rzen.
fixes #30158 .
Built from https://develop.svn.wordpress.org/trunk@30332
git-svn-id: http://core.svn.wordpress.org/trunk@30331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:50:22 +00:00
e1cf2b8523
Twenty Fifteen: Add a transparent border to a link in the footer to avoid jumpiness on hover.
...
props iamtakashi.
fixes #30332 .
Built from https://develop.svn.wordpress.org/trunk@30331
git-svn-id: http://core.svn.wordpress.org/trunk@30330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:42:24 +00:00
b8bfbf42e6
Color Picker: Allow to override `mode` and `width` values for Iris via wpColorPicker options.
...
props jtsternberg.
fixes #30182 .
Built from https://develop.svn.wordpress.org/trunk@30330
git-svn-id: http://core.svn.wordpress.org/trunk@30329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:34:23 +00:00
41197a7c31
Customizer: Improve ability to filter active state for widget area Customizer sections.
...
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.
props westonruter.
fixes #30235 .
Built from https://develop.svn.wordpress.org/trunk@30329
git-svn-id: http://core.svn.wordpress.org/trunk@30328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:19:23 +00:00
92e3890daa
Correct `@since` tag in `count_user_posts()` docs.
...
Props pavelevap, DrewAPicture.
See #21364 .
Built from https://develop.svn.wordpress.org/trunk@30328
git-svn-id: http://core.svn.wordpress.org/trunk@30327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:15:23 +00:00
120cb5e6ef
Improve keyboard accessibility on Custom Header and Custom Background screen.
...
props florianziegler.
fixes #29289 .
Built from https://develop.svn.wordpress.org/trunk@30327
git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
e0c9ba2d63
Customizer: Prevent double-encoding in `WP_Customize_Control`.
...
Control's label and description may include HTML.
fixes #29572 .
Built from https://develop.svn.wordpress.org/trunk@30326
git-svn-id: http://core.svn.wordpress.org/trunk@30325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 11:44:23 +00:00
3acf55cf96
Twenty Fifteen: cleaning up JS introduced in r30305 that doesn't pass jshint.
...
Props boonebgorges, fixes #29988 .
Built from https://develop.svn.wordpress.org/trunk@30325
git-svn-id: http://core.svn.wordpress.org/trunk@30324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 03:18:23 +00:00
3f967c8f1a
Twenty Fifteen: unfix the sidebar if we have a menu with submenus as there is a chance visitors might not be able to scroll down to see submenus in some situations.
...
Props mattwiebe, fixes #30208 .
Built from https://develop.svn.wordpress.org/trunk@30324
git-svn-id: http://core.svn.wordpress.org/trunk@30323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 03:09:22 +00:00
912cdc5978
Pass query object to 'the_post' filter.
...
Props tlovett1.
Fixes #30327 .
Built from https://develop.svn.wordpress.org/trunk@30323
git-svn-id: http://core.svn.wordpress.org/trunk@30322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:25:22 +00:00
a0b8caa29b
Introduce `$post_type` param for `count_user_posts()`.
...
Props Caspie, engelen, DrewAPicture.
Fixes #21364 .
Built from https://develop.svn.wordpress.org/trunk@30322
git-svn-id: http://core.svn.wordpress.org/trunk@30321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:19:22 +00:00
6b9b865b33
Twenty Fifteen: reduce the margins on the editor body in esitor-style.css. Fixes #30331 .
...
Built from https://develop.svn.wordpress.org/trunk@30321
git-svn-id: http://core.svn.wordpress.org/trunk@30320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:02:24 +00:00
d7df822944
Manually delete fixture in `test_mysqli_flush_sync()`.
...
This test creates a dummy post and subsequently runs a query containing
`DROP PROCEDURE`. This latter query implies a `COMMIT`, which means that the
post is not cleaned up for later tests. Manually deleting the post with
`wp_delete_post()` solves this problem.
Fixes #28155 .
Built from https://develop.svn.wordpress.org/trunk@30320
git-svn-id: http://core.svn.wordpress.org/trunk@30319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 02:00:21 +00:00
14ae707fd6
Fix typo in translatable string, see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30319
git-svn-id: http://core.svn.wordpress.org/trunk@30318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 01:00:23 +00:00
69105d29e8
TinyMCE: enhance the inline toolbar for images:
...
- Add alignment (left, center, right, none) buttons.
- Position the menu above the image when possible, except on iOS.
- Fix selecting images on iOS.
First run, part props avryl. See #30147 .
Built from https://develop.svn.wordpress.org/trunk@30318
git-svn-id: http://core.svn.wordpress.org/trunk@30317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 00:56:22 +00:00
07eba31e0b
Twenty Fifteen: improve appearance of page links when there are tons of pages to link to
...
Props iamtakashi, fixes #30301
Built from https://develop.svn.wordpress.org/trunk@30317
git-svn-id: http://core.svn.wordpress.org/trunk@30316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:39:23 +00:00
40c73b7d0d
Twenty Fifteen: adding context to pagination links for screenreaders.
...
Props afercia, iamtakashi, fixes #30152
Built from https://develop.svn.wordpress.org/trunk@30316
git-svn-id: http://core.svn.wordpress.org/trunk@30315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:26:25 +00:00
99a35f20e6
Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.
...
Props celloexpressions, iandstewart, fixes #30316
Built from https://develop.svn.wordpress.org/trunk@30315
git-svn-id: http://core.svn.wordpress.org/trunk@30314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:01:21 +00:00
7f970d53b1
Twenty Fifteen: adding context to page links for screenreaders.
...
Props afercia, fixes #30174 .
Built from https://develop.svn.wordpress.org/trunk@30314
git-svn-id: http://core.svn.wordpress.org/trunk@30313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 22:55:22 +00:00
06201646c3
Use a brighter blue against dark backgrounds in the admin menu and toolbar.
...
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.
props melchoyce. fixes #30323 .
Built from https://develop.svn.wordpress.org/trunk@30313
git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
50271a97d5
Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags.
...
Props aprea, obenland, fixes #30319
Built from https://develop.svn.wordpress.org/trunk@30312
git-svn-id: http://core.svn.wordpress.org/trunk@30311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 17:21:21 +00:00
e17d09f233
PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
...
Built from https://develop.svn.wordpress.org/trunk@30311
git-svn-id: http://core.svn.wordpress.org/trunk@30310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 10:44:23 +00:00
3e702d8b52
Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
...
See #29628
Built from https://develop.svn.wordpress.org/trunk@30310
git-svn-id: http://core.svn.wordpress.org/trunk@30309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 03:06:23 +00:00
6d83c8c29e
Customizer: Add support for the media library in Background Image controls.
...
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.
props celloexpressions, and ericlewis for docs.
see #21483 .
Built from https://develop.svn.wordpress.org/trunk@30309
git-svn-id: http://core.svn.wordpress.org/trunk@30308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 23:52:22 +00:00
8b32164b67
Customizer: Trigger `widget-added` event when initializing.
...
Widget controls are now added to the pane dynamically via JavaScript, see #28709 .
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.
props westonruter.
fixes #30236 .
Built from https://develop.svn.wordpress.org/trunk@30308
git-svn-id: http://core.svn.wordpress.org/trunk@30307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:46:23 +00:00
d21799ee1f
Customizer: Use `jQuery.fn.toggle()` instead of `slideUp`/`slideDown` if panel/section/control is not inserted into DOM yet.
...
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709 .
props westonruter.
fixes #30251 .
Built from https://develop.svn.wordpress.org/trunk@30307
git-svn-id: http://core.svn.wordpress.org/trunk@30306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:37:22 +00:00
b250062311
Customizer: When navigating around the site within the Customizer preview, update the document title.
...
props westonruter.
fixes #28542 .
Built from https://develop.svn.wordpress.org/trunk@30306
git-svn-id: http://core.svn.wordpress.org/trunk@30305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:29:23 +00:00
1317409eda
Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
...
Props celloexpressions, see #29988
Built from https://develop.svn.wordpress.org/trunk@30305
git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:36:23 +00:00
87bd82a0ab
Twenty Fifteen: simplify the code used to generate screen reader text for the is_home title.
...
Props davidakennedy, fixes #30305
Built from https://develop.svn.wordpress.org/trunk@30304
git-svn-id: http://core.svn.wordpress.org/trunk@30303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:24:22 +00:00
47ec29c1ba
Twenty Fifteen: create consistent spacing with embeds and images.
...
Props afercia, fixes #30286
Built from https://develop.svn.wordpress.org/trunk@30303
git-svn-id: http://core.svn.wordpress.org/trunk@30302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:04:21 +00:00
1f2397af34
Twenty Fifteen: simpler CSS by using divs instead of spans for menu descriptions.
...
Props philiparthurmoore, fixes #30296
Built from https://develop.svn.wordpress.org/trunk@30302
git-svn-id: http://core.svn.wordpress.org/trunk@30301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:02:22 +00:00
5fe8fa2b40
Correct grammar error in `WP_Date_Query` error message.
...
Props Offereins.
See #25834 .
Built from https://develop.svn.wordpress.org/trunk@30301
git-svn-id: http://core.svn.wordpress.org/trunk@30300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 14:56:24 +00:00
4cf91d7c1d
Improve localization for `WP_Date_Query` error strings.
...
* Don't create an extra variable for the string when it's only used once.
* Avoid using `<code>` HTML tags inside of translatable string.
* Improve data types and escaping on sprintfed values.
Props dd32.
Fixes #25834 .
Built from https://develop.svn.wordpress.org/trunk@30300
git-svn-id: http://core.svn.wordpress.org/trunk@30299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 13:24:24 +00:00
21467af4db
wpdb: When flushing results on a mysqli connection, make sure that `wpdb::$dbh` is a valid mysqli connection handle.
...
Fixes a unit test failure introduced in [30297].
Fixes #28155 .
Props soulseekah.
Built from https://develop.svn.wordpress.org/trunk@30299
git-svn-id: http://core.svn.wordpress.org/trunk@30298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 02:17:28 +00:00
dd61164577
Exclude external-http tests when running `phpunit`.
...
The external-http tests are very slow, and `Wp_Http` functionality is fairly
isolated, so the benefits of skipping these tests by default outweigh the
risks.
A `grunt phpunit:external-http` subtask has been added, to ensure that the
tests are executed during exhaustive runs of the test suite, such as in
continuous integration.
Fixes #30304 .
Built from https://develop.svn.wordpress.org/trunk@30298
git-svn-id: http://core.svn.wordpress.org/trunk@30297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 14:49:24 +00:00
0013150649
`wpdb::flush()` was not flushing results correctly when using mysqli.
...
This change also allows stored procedures or queries made with `mysqli_multi_query()` to be flushed.
Includes unit tests.
Fixes #28155 .
Props soulseekah.
Built from https://develop.svn.wordpress.org/trunk@30297
git-svn-id: http://core.svn.wordpress.org/trunk@30296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 05:40:23 +00:00
5f27bdc78d
TinyMCE: enable direct calls to `_WP_Editors::wp_mce_translation()`. When using TinyMCE directly, this makes it easier to load the translation of the default strings. Fixes #30293 .
...
Built from https://develop.svn.wordpress.org/trunk@30296
git-svn-id: http://core.svn.wordpress.org/trunk@30295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:07:22 +00:00
383c75db29
Fix PHP notice in `Tests_Feed_RSS2::test_items()`.
...
A notice was being thrown when `get_the_tags()` returned false, and `foreach()`
was run over that return value.
See [30283].
Built from https://develop.svn.wordpress.org/trunk@30295
git-svn-id: http://core.svn.wordpress.org/trunk@30294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:05:22 +00:00
b3da068590
TinyMCE: remove strings that are not translated before outputting the translations. Fixes #27797 .
...
Built from https://develop.svn.wordpress.org/trunk@30294
git-svn-id: http://core.svn.wordpress.org/trunk@30293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:00:22 +00:00
ba10ab197b
Heartbeat:
...
- Use the page visibility API (when available) and document.hasFocus() instead of window.onfocus/onblur. Improves speeding up/slowing down the interval and works for iframes by default.
- Add a setting for minimal interval. Maximum value is 10 min. This overrides all other intervals and cannot be changed after setting it at initialization. Can be used to reduce the frequency of requests on hosts that have low limits for used CPU time, etc.
- Extend the setting of interval to support 120 sec. (60 sec, is still the default).
- Always suspend after one hour of keyboard/mouse/touch inactivity.
Fixes #29779 .
Built from https://develop.svn.wordpress.org/trunk@30293
git-svn-id: http://core.svn.wordpress.org/trunk@30292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 01:47:24 +00:00
f572927353
WPDB's `__get()` function should perform strict comparisons against member names
...
Built from https://develop.svn.wordpress.org/trunk@30292
git-svn-id: http://core.svn.wordpress.org/trunk@30291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-09 12:04:23 +00:00
2508d31b81
Remove failing Unbalanced tags tests
...
Patch with tests added to #6297 for use in the future
Props MikeHansenMe for creating patch of current unit test
see #30284
Built from https://develop.svn.wordpress.org/trunk@30291
git-svn-id: http://core.svn.wordpress.org/trunk@30290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 23:15:23 +00:00
70416f2225
Remove failing shortcode unit tests
...
Test added to #14050 in case we want to include it in a future fix.
see #30284
Built from https://develop.svn.wordpress.org/trunk@30290
git-svn-id: http://core.svn.wordpress.org/trunk@30289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 22:51:22 +00:00
2ed6de333b
Remove failing uploadfile test in trunk
...
The test has been added to #11946 and can be readded when that ticket is fixed.
Props MikeHansenMe for creating patch of current unit test
See #30284
Built from https://develop.svn.wordpress.org/trunk@30289
git-svn-id: http://core.svn.wordpress.org/trunk@30288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:56:22 +00:00
3e94d3a931
Fix incorrect documentation in the DocBlocks for `get_lastpostmodified()` and `_get_last_post_time()`.
...
Props ericlewis for the initial patch.
Fixes #30249 .
Built from https://develop.svn.wordpress.org/trunk@30287
git-svn-id: http://core.svn.wordpress.org/trunk@30287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:45 +00:00
112f854021
Move tests for ms_files_rewriting to separate group, ms-files
...
When the `ms_files_rewriting` flag is enabled, `ms_upload_constants()` is required to properly set upload directory constants. Once this fires, it is impossible to clean up for a non `ms_files_rewriting` test by turning the option back off.
Excluding these tests by default offer a more consistent environment overall. Any tests written for uploaded files in multisite should ideally have a correspondign test in this area.
This commit also moves existing `ms_files_rewriting` tests for `test_switch_upload_dir()`.
Fixes #30256
Built from https://develop.svn.wordpress.org/trunk@30286
git-svn-id: http://core.svn.wordpress.org/trunk@30286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:24 +00:00
ef442d8224
Remove failing test related to post galleries.
...
It relied on the old _WPDataset technique, which is no longer used.
The test has been added to #UT30 as a patch, in case anyone wants to make
future use of it.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30285
git-svn-id: http://core.svn.wordpress.org/trunk@30285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:02:22 +00:00
92c153aa8c
Fix the syntax for some status-related documentation introduced in [30155].
...
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30284
git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:56:22 +00:00
77e2821d54
Improve `Tests_Feed_RSS2::test_items()`.
...
* Better reference to post author, to avoid PHP notices.
* Code styling.
* More reliable checking of tags and categories.
Props kurtpayne.
Fixes #UT32. See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30283
git-svn-id: http://core.svn.wordpress.org/trunk@30283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:55:22 +00:00
9e5cb0301c
Remove failing unit tests from 'canonical' group.
...
Each removed test has been turned into a patch and posted to the open ticket
that it belongs to.
See #30284 .
Built from https://develop.svn.wordpress.org/trunk@30282
git-svn-id: http://core.svn.wordpress.org/trunk@30282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:37:22 +00:00
e7b465046a
Cross-reference `WP_Comment_Query::query()` as the location for finding information on default arguments for `WP_Comment_Query`.
...
Also updates the return types on `get_comments()` and `get_approved_comments()`, as an integer can also be returned if the `$count` argument is true.
Fixes #30111 .
Built from https://develop.svn.wordpress.org/trunk@30281
git-svn-id: http://core.svn.wordpress.org/trunk@30281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:35:22 +00:00
35e509b0c8
Document default arguments for `WP_Comment_Query` class as a hash notation.
...
Props boonebgorges, DrewAPicture.
See #30111 .
Built from https://develop.svn.wordpress.org/trunk@30280
git-svn-id: http://core.svn.wordpress.org/trunk@30280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:19:23 +00:00
bd3a0b33b1
Use `remove_added_uploads()` in `tearDown()` for XMLRPC tests
...
This cleanup avoids false test failures due to incrementing filenames in the uploads directory.
Fixes #30290
Built from https://develop.svn.wordpress.org/trunk@30279
git-svn-id: http://core.svn.wordpress.org/trunk@30279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:18:22 +00:00
0b90415e75
In unit tests, use `wpmu_delete_user()` to delete users when `is_multisite()`.
...
`wp_delete_user()` doesn't remove the user from the database, which causes all
sorts of problems in certain cases.
Props jeremyfelt.
See [30277], #30017 .
Built from https://develop.svn.wordpress.org/trunk@30278
git-svn-id: http://core.svn.wordpress.org/trunk@30278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 19:56:22 +00:00
b5b923c347
Share fixtures across 'canonical' automated tests.
...
Sharing these fixtures results in a speed improvement of almost one minute per
run of the test suite.
My hope is that future WordPress developers will spend this extra minute with
their loved ones, for life on this earth is short, my friends, and the moments
you spend watching WP generate test data can never again be reclaimed from the
grizzled clutches of Time, and none of us are really getting younger, I mean,
geez, have you looked in the mirror lately, Gandalf?
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@30277
git-svn-id: http://core.svn.wordpress.org/trunk@30277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 19:29:22 +00:00
b6d3190be2
Share fixtures across a number of query-related test classes.
...
This shaves 10-20 seconds off the running time for the suite.
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@30276
git-svn-id: http://core.svn.wordpress.org/trunk@30276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 15:30:25 +00:00
68a6a69a91
Twenty Fifteen: updates to customize-preview.js missed in r30274.
...
Props celloexpressions, See #29988 .
Built from https://develop.svn.wordpress.org/trunk@30275
git-svn-id: http://core.svn.wordpress.org/trunk@30275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 21:11:25 +00:00
fa81522cb2
Twenty Fifteen: add instant updating of color schemes to the customizer with postMessage.
...
Props celloexpressions, bradyvercher, westonruter, fixes #29988 .
Built from https://develop.svn.wordpress.org/trunk@30274
git-svn-id: http://core.svn.wordpress.org/trunk@30274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 20:55:23 +00:00
066967be6c
Twenty Fifteen: Removing email obfuscation from social links menu.
...
We really should be doing this in all menus, at which point this becomes core or plugin functionality, not a theme feature.
Closes #30214 .
Built from https://develop.svn.wordpress.org/trunk@30273
git-svn-id: http://core.svn.wordpress.org/trunk@30273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:38:21 +00:00
c3ec04c532
Twenty Fifteen: adding help text to explain how color changes to header and sidebar are affected by responsive design.
...
Props iamtakashi, iandstewart, fixes #30165 .
Built from https://develop.svn.wordpress.org/trunk@30272
git-svn-id: http://core.svn.wordpress.org/trunk@30272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:31:22 +00:00
78c26017c6
Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions.
...
Props celloexpressions, fixes #30160 .
Built from https://develop.svn.wordpress.org/trunk@30271
git-svn-id: http://core.svn.wordpress.org/trunk@30271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:20:22 +00:00
1b0b11b593
Twenty Fifteen: use antispambot to obfuscate email adresses in the social links menu.
...
Props tywayne, fixes #30214 .
Built from https://develop.svn.wordpress.org/trunk@30270
git-svn-id: http://core.svn.wordpress.org/trunk@30270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 16:46:21 +00:00
85fd2fa467
Twenty Fifteen: update earlier patch to borders on linked images so we're not affecting the display of linked icons in widgets.
...
Props iamtakashi, fixes #29963 .
Built from https://develop.svn.wordpress.org/trunk@30269
git-svn-id: http://core.svn.wordpress.org/trunk@30269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 16:34:24 +00:00
7ca9e7d428
Correct variable name in `WP_UnitTestCase::temp_filename()`.
...
Built from https://develop.svn.wordpress.org/trunk@30268
git-svn-id: http://core.svn.wordpress.org/trunk@30268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 01:37:21 +00:00
88de93790b
Unset the default permalink structure after installing Multisite for automated tests.
...
Most of our unit tests that involve permalinks expect non-pretty permalinks;
this is the default setting for WP. However, when the test suite installs
multisite, `populate_network()` is run before WP recogizes itself as multisite,
which leads to pretty permalinks being set. This breaks a number of unit
tests in ways that are difficult to trace.
Built from https://develop.svn.wordpress.org/trunk@30267
git-svn-id: http://core.svn.wordpress.org/trunk@30267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 01:25:22 +00:00
0b1cd9a67a
Use `assertEqualSets()` for some `WP_Comment_Query` tests.
...
Built from https://develop.svn.wordpress.org/trunk@30266
git-svn-id: http://core.svn.wordpress.org/trunk@30266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 22:28:25 +00:00
c357de63ef
Don't force child_of=0 for non-hierarchical taxonomies in `get_terms()`.
...
This forcing appears to have been introduced to save unnecessary queries, but
(a) in some cases it appeared to be causing *more* queries, and (b) it caused
incorrect results when the 'exclude_tree' param of `get_terms()` called
`get_terms()` on each item in the tree using the 'child_of' param.
Fixes #30275 .
Built from https://develop.svn.wordpress.org/trunk@30265
git-svn-id: http://core.svn.wordpress.org/trunk@30265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 21:47:23 +00:00
5ce7ae59df
Add tests for `get_adjacent_post_link()` wrappers.
...
Props MikeHansenMe.
See #29663 .
Built from https://develop.svn.wordpress.org/trunk@30264
git-svn-id: http://core.svn.wordpress.org/trunk@30264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 20:17:22 +00:00
4743ee9326
In `get_adjacent_post()`, `$excluded_terms` should check term_id rather than term_taxonom_id.
...
See #29663 , #22112 .
Built from https://develop.svn.wordpress.org/trunk@30263
git-svn-id: http://core.svn.wordpress.org/trunk@30263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 20:12:22 +00:00
cd0ba24e95
Twenty Fifteen: Our next-previous labels were reversed.
...
Props iamtakashi, fixes #30265 .
Built from https://develop.svn.wordpress.org/trunk@30247
git-svn-id: http://core.svn.wordpress.org/trunk@30247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 20:31:22 +00:00
03ea739661
In `get_page_children()`, only check `$page->ancestors` once to avoid duplicates when the function recurses. Adds an argument, `$ancestors`.
...
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30246
git-svn-id: http://core.svn.wordpress.org/trunk@30246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 20:05:24 +00:00
d5a9d63114
Improve `wp.media` documentation.
...
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@30245
git-svn-id: http://core.svn.wordpress.org/trunk@30245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:39:22 +00:00
2d1080aed1
Improve `wp.Uploader` documentation.
...
Props ericlewis.
See #30260 .
Built from https://develop.svn.wordpress.org/trunk@30244
git-svn-id: http://core.svn.wordpress.org/trunk@30244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:37:23 +00:00
6ad06ca03d
Twenty Fifteen: "detach" widgets from the header in mobile views.
...
Props iamtakashi, fixes #30252 .
Built from https://develop.svn.wordpress.org/trunk@30243
git-svn-id: http://core.svn.wordpress.org/trunk@30243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 18:03:23 +00:00
c47552dc6d
Create new $wp_roles object in install_blog() to avoid protected _init() call
...
Our call to `$wp_roles->_init()` relied on the `__call()` method in `WP_Roles` to handle the link to the protected method. This works back to PHP 5.2.9, when a bug was fixed allowing access to protected methods through this exact approach.
`install_blog()` needs a fresh `$wp_roles` object after `populate_roles()` resets everything in its path. We can create this new object from scratch, effectively doing the same thing with the call to `_init()` via the constructor.
Fixes #29692 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30242
git-svn-id: http://core.svn.wordpress.org/trunk@30242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 05:12:22 +00:00
3706590afb
Split shared taxonomy terms during term update.
...
When updating an existing taxonomy term that shares its `term_id` with
another term, we generate a new row in `wp_terms` and associate the updated
term_taxonomy_id with the new term. This separates the terms, such that
updating the name of one term does not change the name of any others.
Note that this term splitting only occurs on installations whose database
schemas have been upgraded to version 30133 or higher. Note also that shared
terms are only split when run through `wp_update_term()`, as on edit-tags.php;
we will wait until a future release of WordPress to force the splitting of all
shared taxonomy terms.
Props boonebgorges, rmccue, greuben, garyc40, wonderboymusic, imath, jesin.
Fixes #5809 .
Built from https://develop.svn.wordpress.org/trunk@30241
git-svn-id: http://core.svn.wordpress.org/trunk@30241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 02:03:23 +00:00
32db3d1fe5
Do not create shared taxonomy terms.
...
A "shared" term occurs when two entries in the `wp_term_taxonomy` table share a
single `term_id`, and thereby correspond to the same row in `wp_terms`. This
changeset stops the practice of creating shared terms: each new row in
`wp_term_taxonomy` will receive its own row in `wp_terms`. The new strategy
for term creation depends on whether the installation's database schema is up
to date for 4.1:
* If so, terms are allowed to be created with the same slug as an existing term, as long as they are in different taxonomies and do not share a parent. Thus, a new tag with the slug 'wordpress' can exist alongside a category with the slug 'wordpress'.
* If not, new terms will be forced to have unique slugs. Thus, on an installation containing a category with the slug 'wordpress', a new tag 'WordPress' will get the slug 'wordpress-2'.
Fixes #21950 . See #5809 .
Built from https://develop.svn.wordpress.org/trunk@30240
git-svn-id: http://core.svn.wordpress.org/trunk@30240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:42:22 +00:00
ef13be6f27
Enforce ORDER BY and LIMIT clauses in `term_exists()` queries.
...
In case of edge cases where a duplicate term might exist in a replicated
database for a split second, these explicit query clauses ensure that
`term_exists()` will always recognize the oldest matched term as the
canonical one. See [30238] for background.
Props pento.
See #22023 , #5809 .
Built from https://develop.svn.wordpress.org/trunk@30239
git-svn-id: http://core.svn.wordpress.org/trunk@30239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:09:21 +00:00
4ce9db9ce8
In `wp_insert_term()`, clean up accidental duplicate terms after insert.
...
In [30056], the UNIQUE index was removed from the 'slug' column of `wp_terms`.
While we have numerous checks in place to avoid the creation of unwanted
duplicate term+term_taxonomy pairs, it's possible that in certain edge cases -
such as during the lag caused by database replication, or a race condition
involving near-simultaneous creation of more than one term - we'll end up
unwittingly inserting two identical rows.
The current changeset minimizes this risk by introducing a failsafe mechanism
into `wp_insert_term()`. After a term and term_taxonomy are INSERTed, we check
to see whether the term just created is a duplicate of an existing term; if so,
we delete the new one and keep the old one. This prevents problems caused by
replication lag, because SELECT queries that take place after an INSERT will
hit the master database; it mitigates race conditions by enforcing that the
term that was created first (ie, the one with the lowest `term_id`) is
always the "canonical" one.
Props nacin, markjaquith.
See #22023 , #5809 .
Built from https://develop.svn.wordpress.org/trunk@30238
git-svn-id: http://core.svn.wordpress.org/trunk@30238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:00:24 +00:00
1483e80848
Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders.
...
Props davidakennedy, kraftbj, fixes #30135 .
Built from https://develop.svn.wordpress.org/trunk@30237
git-svn-id: http://core.svn.wordpress.org/trunk@30237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:19:22 +00:00
2047ff9e5a
Twenty Fifteen: Use the new archive template tags and make archive template titling way simpler!
...
Props obenland, fixes #30246 .
Built from https://develop.svn.wordpress.org/trunk@30236
git-svn-id: http://core.svn.wordpress.org/trunk@30236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:01:23 +00:00
0952952ef7
Twenty Fifteen: adding licensing info for the image used in the screenshot.
...
Props sakinshrestha, fixes #30156 .
Built from https://develop.svn.wordpress.org/trunk@30235
git-svn-id: http://core.svn.wordpress.org/trunk@30235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:55:22 +00:00
8fa0755584
Add some docs to `wp.media.view.EditorUploader`.
...
Props ericlewis.
See #29951 .
Built from https://develop.svn.wordpress.org/trunk@30234
git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:48:23 +00:00
d21ea0a251
Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees.
...
Props lancewillett, MikeHansenMe, fixes #30149 .
Built from https://develop.svn.wordpress.org/trunk@30233
git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:26:23 +00:00
e2d03edb0d
Twenty Fifteen: missing spaces for code standards.
...
Props Jayjdk, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30232
git-svn-id: http://core.svn.wordpress.org/trunk@30232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:16:22 +00:00
b519db9ffa
Twenty Fifteen: accessible alt text for post thumbnail links.
...
Props joedolson, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30231
git-svn-id: http://core.svn.wordpress.org/trunk@30231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:57:27 +00:00
17dbe26df9
Twenty Fifteen: Simplify the header, sidebar, background controls and make customization faster for users to do. This has the added benefit of fixing our bug where hidden header text wasn't being updated on color scheme switch. Nice.
...
Props celloexpressions, iamtakashi, fixes #30164 and #29980 .
Built from https://develop.svn.wordpress.org/trunk@30230
git-svn-id: http://core.svn.wordpress.org/trunk@30230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:42:22 +00:00
cc9c8edf83
Twenty Fifteen: Crashing chrome if you don't have Noto installed probably isn't the best experience -- removing font kerning.
...
Props iamtakashi, fixes #30195
Built from https://develop.svn.wordpress.org/trunk@30229
git-svn-id: http://core.svn.wordpress.org/trunk@30229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 17:41:21 +00:00
7d56be8521
Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files.
...
Props NikV for the initial patch.
Fixes #29111 .
Built from https://develop.svn.wordpress.org/trunk@30228
git-svn-id: http://core.svn.wordpress.org/trunk@30228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:32:22 +00:00
7081b906f4
Fix a couple of typos in the hook documentation for the `$option` filter in wp-admin/includes/class-wp-list-table.php.
...
Props bobbingwide.
Fixes #30229 .
Built from https://develop.svn.wordpress.org/trunk@30227
git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:05:22 +00:00
d19de136c6
Merge a multi-line comment into a single-line comment in wp-includes/link-template.php.
...
See [30166]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30226
git-svn-id: http://core.svn.wordpress.org/trunk@30226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:59:23 +00:00
256bea185d
Add parameter and return descriptions to the `WP_List_Table::get_pagination_arg()` DocBlock.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30225
git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:55:23 +00:00
784e162177
Cross reference `get_the_archive_title()` and `get_the_archive_description()` in the inline documentation for their corresponding template tags.
...
Also define the default values for `$before` and `$after` in the template tag documentation.
See [30223]. See #21995 .
Built from https://develop.svn.wordpress.org/trunk@30224
git-svn-id: http://core.svn.wordpress.org/trunk@30224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 06:52:23 +00:00
6a45f46937
Introduce some new template functions for archive titles and descriptions:
...
* `get_the_archive_title()` and `the_archive_title()` for returning/displaying the title of the current term, date, post type, post format, or author archive.
* `get_the_archive_description()` and `the_archive_description()` for returning/displaying the description associated with the current term archive.
Fixes #21995
Props obenland, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30223
git-svn-id: http://core.svn.wordpress.org/trunk@30223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 00:35:22 +00:00
7a6ea1e83d
Twenty Fifteen: correct image alignment for RTL.
...
Props iamtakashi, fixes #30239 .
Built from https://develop.svn.wordpress.org/trunk@30222
git-svn-id: http://core.svn.wordpress.org/trunk@30222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 23:12:22 +00:00
7dfb040dde
Twenty Fifteen: check if user-selected custom colors are the same as default so we're not duplicating styles.
...
Props iamtakashi, fixes #30234
Built from https://develop.svn.wordpress.org/trunk@30221
git-svn-id: http://core.svn.wordpress.org/trunk@30221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:59:22 +00:00
8a930c93a8
Twenty Fifteen: Remove a gap between content and footer when the sidebar is longer than the content.
...
Props iamtakashi, fixes #30228 .
Built from https://develop.svn.wordpress.org/trunk@30220
git-svn-id: http://core.svn.wordpress.org/trunk@30220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:44 +00:00
a17fd23e41
Customizer: Bind `input` and `propertychange` events for range input types.
...
props voldemortensen, westonruter.
fixes #30223 .
Built from https://develop.svn.wordpress.org/trunk@30219
git-svn-id: http://core.svn.wordpress.org/trunk@30219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:23 +00:00
9a3b7977fd
Twenty Fifteen: escaping for the HTML5 shiv call.
...
Props philiparthurmoore, fixes #30212
Built from https://develop.svn.wordpress.org/trunk@30218
git-svn-id: http://core.svn.wordpress.org/trunk@30218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:47:22 +00:00
3a0b05e5b1
Twenty Fifteen: kern everything -- it reads better.
...
Props afercia, fixes #30195 .
Built from https://develop.svn.wordpress.org/trunk@30217
git-svn-id: http://core.svn.wordpress.org/trunk@30217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:43:21 +00:00
6be421fb37
Twenty Fifteen: Use new core navigation tags.
...
Props obenland, iamtakashi, fixes #30189
Built from https://develop.svn.wordpress.org/trunk@30216
git-svn-id: http://core.svn.wordpress.org/trunk@30216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:40:23 +00:00
fe241e3fdc
Twenty Fifteen: Make sure that the edit link will always be right of it's icon.
...
Props iamtakashi, fixes #30171 .
Built from https://develop.svn.wordpress.org/trunk@30215
git-svn-id: http://core.svn.wordpress.org/trunk@30215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:36:23 +00:00
73b4f6f449
Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
...
props westonruter.
fixes #30225 .
Built from https://develop.svn.wordpress.org/trunk@30214
git-svn-id: http://core.svn.wordpress.org/trunk@30214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:35:23 +00:00
4b23645ad4
Twenty Fifteen: nicer styles for playlists.
...
Props iamtakashi, fixes #30163
Built from https://develop.svn.wordpress.org/trunk@30213
git-svn-id: http://core.svn.wordpress.org/trunk@30213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:33:23 +00:00
cdfbccddb2
Twenty Fifteen: add a fallback icon for social links where we don't have an icon
...
Props iamtakashi, fixes #30148
Built from https://develop.svn.wordpress.org/trunk@30212
git-svn-id: http://core.svn.wordpress.org/trunk@30212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:02:22 +00:00
c1b360a665
Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
...
Props mattwiebe, aferica, fixes #30056 .
Built from https://develop.svn.wordpress.org/trunk@30211
git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:58:23 +00:00
7919a6d812
Improve docblocks for `get_the_taxonomies()` and `the_taxonomies()`.
...
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.
Fixes #27238 .
Built from https://develop.svn.wordpress.org/trunk@30210
git-svn-id: http://core.svn.wordpress.org/trunk@30210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:45 +00:00
eec3eea392
Introduce `term_template` param to `get_the_taxonomies()`.
...
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.
Props hereswhatidid, dlh, davidjlaietta.
See #27238 .
Built from https://develop.svn.wordpress.org/trunk@30209
git-svn-id: http://core.svn.wordpress.org/trunk@30209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:24 +00:00
a46c99cf78
Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
...
Props morganestes, iamtakashi, fixes #30108
Built from https://develop.svn.wordpress.org/trunk@30208
git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 17:01:23 +00:00
89526ca7f1
Ignore case when checking string 'false' in `wp_validate_boolean()`.
...
Props TobiasBg, kitchin.
Fixes #30238 .
Built from https://develop.svn.wordpress.org/trunk@30207
git-svn-id: http://core.svn.wordpress.org/trunk@30207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:55:23 +00:00
99c5817822
Add unit tests for `wp_validate_boolean()`.
...
Props TobiasBg.
See #30238 .
Built from https://develop.svn.wordpress.org/trunk@30206
git-svn-id: http://core.svn.wordpress.org/trunk@30206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:52:21 +00:00
fc4b17a5d2
In `in_object_in_term()`, only check numeric string values against term_id.
...
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.
Props nobinobi, realloc.
Fixes #29467 .
Built from https://develop.svn.wordpress.org/trunk@30205
git-svn-id: http://core.svn.wordpress.org/trunk@30205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:44 +00:00
d2a8ae2544
Add some unit tests for `is_object_in_term()`.
...
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.
See #29467 .
Built from https://develop.svn.wordpress.org/trunk@30204
git-svn-id: http://core.svn.wordpress.org/trunk@30204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:22 +00:00
5e3a64e83d
Correct some types in `wp-admin/*`-location files' doc blocks.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30203
git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
7d7a8aa0eb
Correct all `@return unknown` instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
bd2521d5ee
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30201
git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
196d85a9f6
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30200
git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:01:24 +00:00
37f94bdfd0
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30199
git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:59:22 +00:00
64167f0845
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30198
git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
d9d825db72
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30197
git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:50:23 +00:00
06f49a43a1
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30196
git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:45:24 +00:00
5a3256c00b
Fill in the `@param` types for the args for `make_site_theme_from_default()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30195
git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:43:21 +00:00
ef944e8c19
Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function?
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30194
git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:41:23 +00:00
082a1d06ae
Fill in the `@param` types for the args for `dbDelta()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30193
git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:40:22 +00:00
150b4e5157
Fill in the `@param` types for the args in `WP_Text_Diff_Renderer_Table->interleave_changed_lines()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30192
git-svn-id: http://core.svn.wordpress.org/trunk@30192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:39:22 +00:00
3e4ca28eb9
Correct the `@param` type for the `$query` arg for `remove_query_arg()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30191
git-svn-id: http://core.svn.wordpress.org/trunk@30191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:29:22 +00:00
8eee18ec0e
Fill in types for the `@param`s for `wp_comment_reply()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30190
git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:21:22 +00:00
63c55ae93c
Correct type in the doc block for `get_theme_support()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30189
git-svn-id: http://core.svn.wordpress.org/trunk@30189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:18:22 +00:00
3535af5b77
Correct the return value doc block for `get_theme_support()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30188
git-svn-id: http://core.svn.wordpress.org/trunk@30188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:17:23 +00:00
0eb038d97b
In `Custom_Image_Header`:
...
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403].
* Declare `$updated` as a property.
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30187
git-svn-id: http://core.svn.wordpress.org/trunk@30187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:15:22 +00:00
a14a4fc9a5
In `Custom_Background`, declare `$updated` as a property.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30186
git-svn-id: http://core.svn.wordpress.org/trunk@30186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:08:22 +00:00
15c062eb79
In `wp_audio|video_shortcode()`, make sure that `autoplay` and `loop` are booleans. Passing `'false'` to them will force them to be active, which is bad.
...
Fixes #29825 .
Built from https://develop.svn.wordpress.org/trunk@30185
git-svn-id: http://core.svn.wordpress.org/trunk@30185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:03:21 +00:00
a587ebc946
In `WP_Tax_Query`, declare `$primary_table` and `$primary_id_column` as properties.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30184
git-svn-id: http://core.svn.wordpress.org/trunk@30184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:45:22 +00:00
2750f0cec7
In `WP_Locale`, declare `$number_format` as a property.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30183
git-svn-id: http://core.svn.wordpress.org/trunk@30183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:40:22 +00:00
a23c230c01
In `WP_Comment_Query`, declare `$query_vars` and `$comments` as properties.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30182
git-svn-id: http://core.svn.wordpress.org/trunk@30182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:08:22 +00:00
c598d35e41
Almost every method in `wp_xmlrpc_server` can also return `IXR_Error` and should be labeled as such. Rehabilitate some `return` syntax.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30181
git-svn-id: http://core.svn.wordpress.org/trunk@30181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:04:22 +00:00
e02c724249
`WP_Image_Editor_GD` and `WP_Image_Editor_Imagick` should specify type in a doc block for the `$image` property, instead of inferring `bool` and `null`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30180
git-svn-id: http://core.svn.wordpress.org/trunk@30180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:38:23 +00:00
a887301869
In `WP_HTTP_IXR_Client`:
...
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30179
git-svn-id: http://core.svn.wordpress.org/trunk@30179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:32:22 +00:00
68a67a9b0d
Fix the return docs for `WP_Embed->maybe_make_link()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30178
git-svn-id: http://core.svn.wordpress.org/trunk@30178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:27:23 +00:00
796ceebb25
Use common core syntax for checking DOING_AJAX
...
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.
props TobiasBg
Fixes #29891
Built from https://develop.svn.wordpress.org/trunk@30177
git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:24:23 +00:00
00c86aea63
Delete admin_created_user_subject() rather than deprecate
...
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.
Fixes #29915
Built from https://develop.svn.wordpress.org/trunk@30176
git-svn-id: http://core.svn.wordpress.org/trunk@30176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:07:23 +00:00
c3f51ce97a
Improve layout of test for cached invalid, then valid site details
...
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.
See #30080 , #23405
Built from https://develop.svn.wordpress.org/trunk@30175
git-svn-id: http://core.svn.wordpress.org/trunk@30175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 01:05:22 +00:00
132be9d66d
Split tests for wp_get_sites()
...
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30174
git-svn-id: http://core.svn.wordpress.org/trunk@30174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:40:22 +00:00
783f36f855
In `_WP_Editors::editor_settings()`, `$str1` and `$str2` don't need to be initialized empty.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30173
git-svn-id: http://core.svn.wordpress.org/trunk@30173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:22:22 +00:00
303d01869c
Declare the `$uploaded_headers` and `$default_headers` properties for `WP_Customize_Header_Image_Control`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30172
git-svn-id: http://core.svn.wordpress.org/trunk@30172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:18:23 +00:00
73c8e4cf10
Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30171
git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:07:23 +00:00
3fc8778359
Declare the `$options` property for `WP_Upgrader_Skin`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30170
git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:03:22 +00:00
4d0f66854a
Fix the return value doc for `WP_List_Table->get_pagination_arg()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30169
git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:00:23 +00:00
6a109700d0
In `wp_ajax_get_tagcloud()`, bail immediately if `$_POST['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30168
git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:54:22 +00:00
a786fb779c
In `wp_ajax_ajax_tag_search()`, bail immediately if `$_GET['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30167
git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:48:22 +00:00
a79b6fdde3
In `get_the_pagination()`, don't pass `$links` to `_navigation_markup()` if it is not a string - `paginate_links()` can return an `array`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30166
git-svn-id: http://core.svn.wordpress.org/trunk@30166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:41:23 +00:00
892be738b0
Make the docs type for `return` in `wpmu_create_user()` more specific.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30165
git-svn-id: http://core.svn.wordpress.org/trunk@30165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:33:21 +00:00
e41e38183d
In `customize.php`, check that `$autofocus` is an `array` after running `wp_unslash()` instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30164
git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00
106da1e9e6
In `WP_Meta_Query->get_sql_for_clause()`, the empty initialization of `$where` is dead code and can be removed.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30163
git-svn-id: http://core.svn.wordpress.org/trunk@30163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:03:22 +00:00
fbd6efdfb8
In `_wp_json_convert_string()`, when `$use_mb` is `false`, perhaps pass a variable that actually exists to `wp_check_invalid_utf8()`.
...
Introduced in [30055].
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30162
git-svn-id: http://core.svn.wordpress.org/trunk@30162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:00:24 +00:00
cd9bb04981
In `gallery_shortcode()`, when the `link` attribute is equal to `file`, make sure to pass `$attr` as the 6th (!) argument, not 5th, to `wp_get_attachment_link()`.
...
Props bradyvercher.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@30161
git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:47:24 +00:00
382d93ddf9
Remove failing unit test after [30090].
...
Fixes #30194 .
Built from https://develop.svn.wordpress.org/trunk@30160
git-svn-id: http://core.svn.wordpress.org/trunk@30160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:11:22 +00:00
878d074e84
Allow `get_pages()`, with `child_of` passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30159
git-svn-id: http://core.svn.wordpress.org/trunk@30159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:44:21 +00:00
d5e4583475
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30158
git-svn-id: http://core.svn.wordpress.org/trunk@30158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:37:24 +00:00
849a993269
Check `$_current_page` before using it in `Walker_Page->start_el()`.
...
Props jeremyfelt.
Fixes #26901 .
Built from https://develop.svn.wordpress.org/trunk@30157
git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:29:22 +00:00
60b73c589c
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
Built from https://develop.svn.wordpress.org/trunk@30156
git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:25:23 +00:00
Andrew Ozz
Dion Hulse
Boone Gorges
Drew Jaynes
John Blackbourn
Gary Pendergast
Dominik Schilling
Andrew Nacin
Mark Jaquith
Aaron Jorbin
Ian Stewart
Helen Hou-Sandí
Jeremy Felt
Scott Taylor