WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
30,025 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

1345 Commits

Author SHA1 Message Date
Ryan Boren 419fea1a16 Normalize the UTF-8 and ISO-8859-1 charset strings stored in blog_charset to make them friendlier with PHP functions that accept a charset such as htmlspecialchars(). 
fixes #23688


git-svn-id: http://core.svn.wordpress.org/trunk@24510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-25 19:03:17 +00:00
Andrew Nacin 96ee267343 Better validation of the URL used in core HTTP requests. 
git-svn-id: http://core.svn.wordpress.org/trunk@24480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 06:07:47 +00:00
Andrew Nacin 7addff9967 Use correct variable order in add_query_arg(). This had mostly just filled error logs; it also broke some obscure URL situations. see #23284. 
git-svn-id: http://core.svn.wordpress.org/trunk@24444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 08:33:10 +00:00
Andrew Nacin bb1234c4be Fall back to non-translated strings in _doing_it_wrong() if the translation function doesn't exist. This may be the case in sunrise, for example. 
props SergeyBiryukov.
fixes #23555.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@24439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 08:11:59 +00:00
Andrew Ozz b1009b33c4 Logged out warnings: fix same domain comparison in wp_auth_check_html() when FORCE_SSL_LOGIN && ! FORCE_SSL_ADMIN. See #23295 
git-svn-id: http://core.svn.wordpress.org/trunk@24266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-15 22:09:54 +00:00
Sergey Biryukov 74638ccb5a Fix typos in phpdoc. props TheLastCicada. fixes #24302. 
git-svn-id: http://core.svn.wordpress.org/trunk@24229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-10 01:39:30 +00:00
Andrew Ozz 19c3b4bfdc Logged out warnings: 
- Don't use <base> tag to set target="_blank". It can break form submission. Instead, set target only on links with JS.
- Fix same domain comparison in wp_auth_check_html() when FORCE_SSL_LOGIN == true.
- Properly show/hide the "Close" button when the dialog is shown multiple times.
See #23295

git-svn-id: http://core.svn.wordpress.org/trunk@24208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-08 22:45:58 +00:00
Mark Jaquith 0a49442e35 Multiple improvements to image post format insertion and display. 
* get_tag_regex() altered based on Unit Tests.
* Changes to post-formats.js to provide size and link context during image selection.
* Captions are now output in the_post_format_image() when present.
* The meta value for url is respected for the image post format when the HTML in the image meta doesn't include a link

props wonderboymusic. fixes #23965, #23964. see #24147, #24046.

git-svn-id: http://core.svn.wordpress.org/trunk@24066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 22:11:42 +00:00
Andrew Ozz bcb9eef7cd Logged out warnings: fix phpdoc, props ocean90, see #23295 
git-svn-id: http://core.svn.wordpress.org/trunk@23922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-05 23:28:40 +00:00
Andrew Ozz 04c5aefbea Logged out warnings: add fallback text dialog for: 
- The login page has "X-Frame-Options: DENY" header.
- Cross-domain when displaying on the front-end on multisite with domain mapping.
- The site forces ssl login but not ssl admin.

Add onbeforeunload prompt to counter (frame-busting) JS redirects. Move the JS and CSS into separate files. See #23295.

git-svn-id: http://core.svn.wordpress.org/trunk@23805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-27 08:43:11 +00:00
Ryan Boren 9f44cb4038 Remove old phpdoc that incorrectly marks wp_timezone_choice() as temporary. 
Props danielbachhuber
fixes #23804


git-svn-id: http://core.svn.wordpress.org/trunk@23738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-18 13:35:34 +00:00
Mark Jaquith 53d12e91bc Introduce [audio] and [video] shortcodes, and use MediaElement.js to play them. 
props wonderboymusic. see #23282.

git-svn-id: http://core.svn.wordpress.org/trunk@23729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-16 05:25:44 +00:00
Andrew Nacin af53edb696 Revert [23411] until encoding differences are worked out. see #20771. 
git-svn-id: http://core.svn.wordpress.org/trunk@23637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-07 06:57:56 +00:00
Andrew Nacin 7b47322e22 Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer(). 
Use wp_slash() instead of addslashes().

see #21767.



git-svn-id: http://core.svn.wordpress.org/trunk@23578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:58:43 +00:00
Ryan Boren 09d2c65970 Always wp_unslash() the return of wp_get_referer(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:20:32 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Andrew Ozz 99e168d1a2 Logged out warnings: restructure the PHP code (no need for a class), props nacin, see #23295 
git-svn-id: http://core.svn.wordpress.org/trunk@23543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 01:55:33 +00:00
Andrew Nacin 81080da6f2 Allow nonce name to be passed to wp_nonce_url(), as allowed by wp_nonce_field(). props MatthewRuddy, fixes #22423. 
git-svn-id: http://core.svn.wordpress.org/trunk@23519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-28 18:08:53 +00:00
Andrew Ozz 0910d5755e Improved logged out warnings, first run, props mintindeed, see #23295 
git-svn-id: http://core.svn.wordpress.org/trunk@23504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-28 08:57:17 +00:00
Sergey Biryukov 8fb830eeda Fix typos in phpdoc. props markmcwilliams. fixes #23481. 
git-svn-id: http://core.svn.wordpress.org/trunk@23434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-15 18:59:56 +00:00
Mark Jaquith 4ca36c6337 Update our Windows media file MIME types to the official Microsoft-recommended ones. 
props niallkennedy, wonderboymusic. fixes #14253

git-svn-id: http://core.svn.wordpress.org/trunk@23422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-15 16:12:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Sergey Biryukov 4e46d0045c Use correct escaping function. props jkudish. fixes #20771. 
git-svn-id: http://core.svn.wordpress.org/trunk@23411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 05:12:23 +00:00
Ryan Boren 57f65d2906 Try not to send Last-Modified, even with an empty value. Some servers interpret an empty value as the epoch. 
Props nacin, slene, SergeyBiryukov, andy
see #23021 for trunk


git-svn-id: http://core.svn.wordpress.org/trunk@23267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-04 19:51:31 +00:00
Dion Hulse 52c97f6b1a Correct an incorrect PHPDoc s/@see/@link/ introduced in r23254. See #22900 
git-svn-id: http://core.svn.wordpress.org/trunk@23256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-03 08:05:48 +00:00
Dion Hulse 50da2d8a9f HTTP API: Introduce wp_is_writable() to wrap win_is_writable() and is_writable() to work around PHP Windows ACL issues. See #22900 for trunk 
git-svn-id: http://core.svn.wordpress.org/trunk@23255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-03 08:04:11 +00:00
Dion Hulse a7bb4ac774 Clarify the Documentation in win_is_writable() and move an inline comment to the Docblock, reduces confusion about what the function actually does. See #22900 
git-svn-id: http://core.svn.wordpress.org/trunk@23254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-03 07:56:38 +00:00
Mark Jaquith dc4832131f Add .webm (video/webm) to wp_get_mime_types(). props wonderboymusic. fixes #14659 
git-svn-id: http://core.svn.wordpress.org/trunk@23229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-29 18:07:23 +00:00
Ryan Boren 20d9c165ee Properly set the base URL for the main site when ms-files rewriting is enabled for MU-era installs. 
Props nacin
fixes #22702


git-svn-id: http://core.svn.wordpress.org/trunk@23002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-03 22:24:06 +00:00
Mark Jaquith 4fcb87234b Remove trailing slashes from UPLOADS before trying a str_replace() in wp_upload_dir(). props jbrinley. fixes #22469 
* In 3.4.x, both $url and UPLOADS had trailing slashes
* Due to refactoring, $url is no longer expected to have a trailing slash
* Because of the mismatch, the str_replace() was not working, resulting in an incorrectly verbose upload dir URL

git-svn-id: http://core.svn.wordpress.org/trunk@22736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 07:08:38 +00:00
Ryan Boren 06ee370814 Pinking shears 
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-17 15:11:29 +00:00
Andrew Nacin e5c1d8d7af Account for unfiltered_upload cap in wp_upload_bits(). see #21292. 
git-svn-id: http://core.svn.wordpress.org/trunk@22471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-08 20:41:34 +00:00
Dion Hulse a24d651e0e Prevent an issue on windows systems which can cause the temporary directory from get_temp_dir() from returning a path containing \/. Props to SergeyBiryukov for the initial patch. Fixes #20778 
git-svn-id: http://core.svn.wordpress.org/trunk@22331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-30 20:58:35 +00:00
Andrew Ozz efbc9d2336 Buttons: 
- Update the install/initial configuration/repair screens buttons, props DrewAPicture
- Fix the welcome screen buttons and fine-tune the buttons css, props lessbloat

fixes #21598


git-svn-id: http://core.svn.wordpress.org/trunk@22314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-26 19:40:39 +00:00
Andrew Nacin 1773a06874 Avoid 'headers already sent' messages for header_remove() the same way we currently do with header(). props ryan. fixes #22258. 
git-svn-id: http://core.svn.wordpress.org/trunk@22303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-25 20:38:55 +00:00
Andrew Nacin a88114dd92 Do not issue a Last-Modified header when issuing no-cache headers to avoid aggressive (webkit) caching. Serve a blank header when header_remove() is not available (PHP < 5.3). props andy. fixes #22258. 
git-svn-id: http://core.svn.wordpress.org/trunk@22283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-23 15:45:44 +00:00
Ryan Boren 43a1c703e0 A more generic message for wp_upload_dir(). Props nacin. fixes #21796 
git-svn-id: http://core.svn.wordpress.org/trunk@22276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-23 13:49:00 +00:00
Andrew Nacin dc3fbf216f Have wp_upload_dir() account for blog switching, ms-files rewriting, and the UPLOADS constant properly. This type of logic needs a lot of code comments. 
Prevents wp_upload_dir() from obeying the UPLOADS constant when ms-files rewriting is enabled and a blog is switched.

Reverts [22106] thanks to [22108].

see #19235.



git-svn-id: http://core.svn.wordpress.org/trunk@22222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-12 22:05:02 +00:00
Ryan Boren 7a86de87fb Reduce use of global. Use get_blog_details() instead. fixes #22090 
git-svn-id: http://core.svn.wordpress.org/trunk@22108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-04 12:40:09 +00:00
Andrew Nacin 8451f7e987 Pass the current blog id to is_main_site() in wp_upload_dir(), because is_main_site() without arguments does not respond correctly on switch. see #19235. 
git-svn-id: http://core.svn.wordpress.org/trunk@22106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-03 18:57:36 +00:00
Ryan Boren b4d0be2d1a Introduce WP_Image_Editor, WP_Image_Editor_Imagick, and WP_Image_Editor_GD. Abstracts image editing API and adds support for ImageMagick. 
Props DH-Shredder, kurtpayne, markoheijnen
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 20:59:06 +00:00
Dion Hulse 19c7ca7729 Silence a PHP Warning in Safe Mode from get_temp_dir(). Props ocean90. Fixes #20778 
git-svn-id: http://core.svn.wordpress.org/trunk@22082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-29 01:22:25 +00:00
Andrew Nacin 143f4da6a6 If a pre-3.0 (MU era) network disables ms-files manually, they don't need /sites/ in their wp-content/uploads directory. see #19235. 
git-svn-id: http://core.svn.wordpress.org/trunk@22038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 04:56:58 +00:00
Dion Hulse a41af6219a Move win_is_writable() from wp-admin/includes to wp-includes so that it's always available for get_temp_dir(). Fixes #20778 
git-svn-id: http://core.svn.wordpress.org/trunk@22009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 05:08:26 +00:00
Dion Hulse 079afa8ce2 Rearrange the order that we check for temporary directories in get_temp_dir(). This change causes us to use System temporary directories in preference to WP_CONTENT_DIR, for better windows compatibility, we use win_is_writable() as well. Props simonwheatley and kurtpayne for initial patches, See #20778 
git-svn-id: http://core.svn.wordpress.org/trunk@22008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 05:02:58 +00:00
Andrew Nacin 557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987. 
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-25 05:26:19 +00:00
Peter Westwood fa8a509ff3 Posting: Improve the invalid date protection code based on feedback from nacin. 
* Introduce a wp_checkdate() function with a single filter to centralise the code that validates dates.
 * Improve the error message
 * Correctly handle the return value of wp_insert_post which is not always a WP_Error on failure

Fixes #17180


git-svn-id: http://core.svn.wordpress.org/trunk@21922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-20 10:46:50 +00:00
Andrew Nacin 749c06e91f Simplify protocol stripping in add_query_arg() by avoiding a regular expression. Don't cast a known array to an array. fixes #21332. 
git-svn-id: http://core.svn.wordpress.org/trunk@21865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-16 16:16:26 +00:00
Andrew Nacin e4c21210aa Add xmpp to allowed protocols. props ethitter, fixes #21604. 
git-svn-id: http://core.svn.wordpress.org/trunk@21826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-12 15:47:34 +00:00
Andrew Nacin 9f6fe3c4ff Don't show Appearance > Widgets if the theme has no sidebars defined. props SergeyBiryukov for the initial patch. fixes #21761. 
git-svn-id: http://core.svn.wordpress.org/trunk@21825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-12 02:16:46 +00:00
Andrew Nacin dc49f24a6c Remove ms-files.php rewriting from WordPress multisite. fixes #19235. 
Keep existing networks compatible with a ms_files_rewriting network option.



git-svn-id: http://core.svn.wordpress.org/trunk@21823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 22:22:20 +00:00
Andrew Nacin bc6087bc98 Always return upload directory information from wp_upload_dir(), even if there is an error. Append the error to the array. see #19235. 
git-svn-id: http://core.svn.wordpress.org/trunk@21822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 22:06:49 +00:00
Andrew Nacin 9d204841ee Remove AtomPub from core. 
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 20:11:39 +00:00
Ryan Boren 8f1f88a82a Don't use set_url_scheme() in wp_guess_url(). wp_guess_url() is used during install before set_url_scheme() is loaded. Props SergeyBiryukov. fixes #20759 
git-svn-id: http://core.svn.wordpress.org/trunk@21797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-10 19:37:08 +00:00
Andrew Nacin 75052955cc Add get-attachment and query-attachments Ajax handlers. props koopersmith. see #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@21681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-31 02:58:51 +00:00
Andrew Nacin c8a328f100 Introduce wp_send_json() to json-encode a variable, print it, and die, for Ajax requests. Effectively replaces WP_Ajax_Response, which was an XML-based response. 
Introduce wp_send_json_success() and wp_send_json_error(), which will allow us to fire appropriate done() or fail() callbacks in JS.

props koopersmith. see #21390.



git-svn-id: http://core.svn.wordpress.org/trunk@21679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-31 01:56:00 +00:00
Ryan Boren c55cf716da Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759 
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-30 13:33:00 +00:00
Ryan Boren 02dc348b57 Introduce wp_get_mime_types() for fetching the complete list of mime types. Remove the static caching of the types so that filters other than the first filter work. Use wp_get_mime_types() in do_enclose(). fixes #21299 #21594 
git-svn-id: http://core.svn.wordpress.org/trunk@21541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-17 17:25:19 +00:00
Ryan Boren 2394b77094 Fix MS Office mime types. Group the mime list in get_allowed_mime_types() by type. Props hebbet, markel, SergeyBiryukov. fixes #17117 
git-svn-id: http://core.svn.wordpress.org/trunk@21527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-15 16:48:36 +00:00
ryan d286875515 switch_to_blog() and restore_current_blog() housekeeping. 
wp-includes/admin-bar.php:

* Replace get_admin_url() and get_home_url() with admin_url() and home_url() and place them inside a switch/restore. Likewise replace current_user_can_for_blog() with current_user_can(). This avoids doing multiple switch restores.

wp-includes/ms-blogs.php:

* Deprecate the $validate argument to switch_to_blog(). This avoids a not very necessary call to get_blog_details(), possibly saving a few queries.
* Use $_wp_switched and $_wp_switched_stack instead of $switched and $switched_stack to make it less likely these globals will be stomped.
* Use GLOBALS to access blog_id and other globals. I've preferred this style lately since it makes it obvious a global is being used and avoids global blog_id being stomped by a local variable.
* Lose some is_object() checks. wp_get_current_user() always returns an object, for example.
* Call the new WP_Roles::reinit() method.

wp-includes/class-wp-xmlrpc-server.php:

* Replace current_user_can_for_blog() with current_user_can() and move it inside the switch/restore pair. This eliminates a switch/restore.

wp-includes/capabilities.php:

* Use array_keys() instead of $role => $data since $data is unused. I *think* this is a bit faster.
* Introduce WP_Roles::reinit(). This reinitializes WP_Roles and is used after switch_to_blog() has already update the blog ID in the wpdb object. If a global roles array is being used instead of the db, reinit is skipped.
* current_user_can_for_blog() now does a switch/restore. It didn't before meaning it could be reinitializing the user with the wrong role information for the current blog.

wp-includes/ms-settings.php:

* Define $_wp_switched_stack and $_wp_switched. This way switch_to_blog() and restore_current_blog() can rely on it being set.

wp-settings.php:

* Instantiate the WP_Roles global. This was it is always defined during init. To remove the WP_Roles checks from WP_Role and WP_User this would probably have to move before plugins are loaded, which might not be a good thing.

wp-includes/functions.php:

* Update wp_upload_dir() to reference _wp_switched.



git-svn-id: http://core.svn.wordpress.org/trunk@21485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-09 16:28:15 +00:00
ryan 4630ae82ce Call func_get_args() once in add_query_arg(). Props SergeyBiryukov. see #21332 
git-svn-id: http://core.svn.wordpress.org/trunk@21373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-31 15:28:10 +00:00
nacin 68c0beb079 Remove unnecessary error suppression operators from func_get_arg() and func_num_args(). see #21332. 
git-svn-id: http://core.svn.wordpress.org/trunk@21298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-21 06:07:39 +00:00
nacin 34c74ee8ce Check if array key exists in wp_list_filter(). props wpsmith. fixes #20929. 
git-svn-id: http://core.svn.wordpress.org/trunk@21184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-29 19:42:27 +00:00
nacin 8b8bf67e0a Add back an empty line removed in [21180]. 
git-svn-id: http://core.svn.wordpress.org/trunk@21181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-29 15:16:36 +00:00
nacin 9fb97afcdd Add note to get_allowed_mime_types() about the upload_mimes filter. props JustinSainton. fixes #20990. 
git-svn-id: http://core.svn.wordpress.org/trunk@21180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-29 15:13:53 +00:00
markjaquith 168cc20a42 Allow tel: and fax: protocols. Wrangle the last hardcoded protocol enumeration so that it uses wp_allowed_protocols(). fixes #21081 
git-svn-id: http://core.svn.wordpress.org/trunk@21170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-28 20:30:10 +00:00
nacin 138b38fd60 Add initial support for browser-based uploads in iOS 6. see #20923 for trunk. 
git-svn-id: http://core.svn.wordpress.org/trunk@21141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-26 20:39:04 +00:00
nacin 066794f548 Deprecate wp_explain_nonce(). fixes #21076. 
git-svn-id: http://core.svn.wordpress.org/trunk@21133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-26 06:10:07 +00:00
nacin b84c4c3686 Don't call debug_backtrace() with an argument for PHP 5.2.4, which is currently the lowest version we support. props swekitsune, kurtpayne. fixes #20953. 
git-svn-id: http://core.svn.wordpress.org/trunk@21113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-25 20:41:37 +00:00
ryan 8c114f0c54 Pinking shears 
git-svn-id: http://core.svn.wordpress.org/trunk@20715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-03 16:41:59 +00:00
nacin 6d87a96c85 Properly extract file headers via get_file_data() when CR line endings are used. props solarissmoke for the initial patch. fixes #19854. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-30 01:25:29 +00:00
nacin c2422f4596 Fix typo in filter name for wp_die() APP request handler. props benbalter, fixes #20457. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-16 16:15:18 +00:00
ryan 27630a4286 Schedule auto-draft deletion from post-new.php instead of from admin.php. This provides better throttling for large multisite installs and reduces the risk of a delete avalanche. 
fixes #19663


git-svn-id: http://svn.automattic.com/wordpress/trunk@20453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-12 18:49:48 +00:00
azaozz 817b932ed1 Don't hide links to the upload form and show an error for mobile devices that cannot upload, see #20410 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-12 00:16:37 +00:00
ryan 28f8e7a63d Move deletion of auto-draft posts to the wp_scheduled_delete cron function. Props mgolawala. fixes #19663 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-11 20:39:09 +00:00
nacin c7cf0927fc Use the metadata API rather than raw queries and direct do_action calls. see #20417. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-11 20:02:39 +00:00
dd32 990cf273c7 Restore the h1 styling for wp_die(), primarily affects database down messages. See #17975 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-18 11:51:25 +00:00
nacin c8a4cb1112 Use array_combine() in get_file_data() and avoid variable variables when an array is just fine. fixes #20126. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-02 21:07:31 +00:00
nacin db15a20fb1 New wp_die_app_handler context in wp_die() for APP requests. Introduces _scalar_wp_die_handler() as a generic handler that wraps die(), for use by plugins. Move deprecated function to the end of the wp-app.php file (same as xmlrpc.php). see #20042. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-01 21:35:15 +00:00
ryan d910c26182 Pinking shears 6-20000 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-27 19:46:52 +00:00
duck_ 5e653b76ed Overhaul mysql2date() documentation and parameter names. See #20056. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-21 20:03:11 +00:00
duck_ ebc8ed6395 Remove obsolete mysql2date documentation. Props Viper007Bond. Fixes #20056. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-21 19:55:18 +00:00
nacin aefde50081 Deprecate ancient "debugging" tools. 
* logIO() and the global $xmlrpc_logging in XML-RPC.
 * log_app() and the global $app_logging in APP.
 * debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051.



git-svn-id: http://svn.automattic.com/wordpress/trunk@19935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-17 00:02:42 +00:00
ryan f5e4af9b53 Properly redirect to install.php when visiting wp-login.php with a config file but no db. Props SergeyBiryukov. fixes #18397 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-14 18:08:45 +00:00
ryan 6aedd9d0f0 Split the main WP_Query posts query into two queries to avoid temp tables. Leverage cache to avoid second query in persistent cache environments. Props scribu, cheald, prettyboymp. see #18536 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-14 15:09:35 +00:00
duck_ 6025a35ccf Prevent undefined index notices in do_enclose(). Props jeremyclarke. Fixes #19865. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-08 20:55:18 +00:00
nacin 81bb2f7ed7 Use is_rtl() for html direction when possible. In sites.php, language_attributes() will always exist (MU vestige). When the DB is dead, language_attributes() is worse than a simple is_rtl() check. is_rtl() exists here due to wp_load_translations_early(). see #18180. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-08 06:05:35 +00:00
nacin acd0f7c375 Re-purpose wp_die() for ajax responses. 
* Allows unit testing of core ajax actions.
 * wp_die() now has separate filters to choose a handler depending on the context (ajax, XML-RPC, else).
 * wp_die) in ajax context does not need to be called with a string. Conversion takes place before die().
props kurtpayne, see #15327.



git-svn-id: http://svn.automattic.com/wordpress/trunk@19801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-31 22:12:58 +00:00
westi 85a5ede786 Correct the datatype for the skip_frames argument in the phpDoc props Rarst. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-28 14:36:16 +00:00
duck_ cd4b65c7eb Separated into 3 commits for good luck. See r19775. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-28 12:37:08 +00:00
westi f94f228013 Separating my commits so that my spelling mistakes are plain for everyone to see. Fix another mistake props duck_. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-28 12:32:55 +00:00
westi 62bf836878 Fix my spelling mistakes and typos in the wp_debug_backtrace_summary() phpDoc props duck_ see #19589. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-28 12:25:58 +00:00
westi cff0e266a4 Refactor WPDB::get_caller() into wp_debug_backtrace_summary() and improve the functionality to provide enhanced context and a standardised default pretty format. Fixes #19589 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-28 11:56:50 +00:00
nacin 81ed9a7563 Introduce wp_load_translations_early(), which can be used before the locale is properly loaded in order to translate early error strings. Internationalize setup-config.php -- translators no longer have a reason to modify this file. fixes #18180. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-26 20:34:27 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:50:54 +00:00
ryan d76cd7d965 One newline is enough. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:13:03 +00:00
ryan 616c35e71c One newline is enough. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:10:39 +00:00
azaozz fd53358005 Replace background image with CSS3 gradient in wp_die(), fixes #19701 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-30 22:25:53 +00:00
nacin 20be787163 Disable the 8) smiley as it breaks regular text more than all of the others. props sksmatt. fixes #17122. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-20 21:46:19 +00:00
nacin 0fd8ef6b71 Update since. see #18845. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-20 20:59:03 +00:00
nacin bf1ff3c7e6 Add `__return_null()` to complement the existing true, false, zero, and empty array methods. props johnbillion, fixes #18845. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-20 20:58:30 +00:00
ryan 24ab16bc4e Move option, setting, and transient functions from functions.php to option.php. see #19552 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-19 23:15:32 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
westi 61219dc009 Add button styles to the inline styles in _default_wp_die_handler so that the Create a Config button is styled again. Fixes #17975. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-23 17:29:49 +00:00
ryan 45ddf08e07 Introduce wp_no_robots(). Call it for pages that should never be indexed, regardless of blog privacy settings. Props nacin. fixes #19251 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-15 20:44:48 +00:00
azaozz 52b5e282bd Fix styling for the installation screens, props chexee, fixes #18576 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-15 15:47:07 +00:00
ryan 0ec7ae44ca Fix edit.php row action redirects when referrers are not sent. Return false from wp_get_referer() when no referrer found. Props mitchoyoshitaka. fixes #17628 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-14 16:59:45 +00:00
nacin 3a3c7e2334 Remove old vendor prefixes. props andrewryno, ocean90, fixes #18700. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-07 17:32:24 +00:00
ryan 62afab8db3 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-24 19:13:23 +00:00
nacin ffcb6aba46 In _doing_it_wrong(), don't append the Debugging_in_WordPress message until we go to print a message. Send a clean message to the action. see #18453. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-23 17:51:14 +00:00
ryan 7a3fc7d36c Don't use unbounded SHOW TABLES in is_blog_installed(). Do a more targeted DESCRIBE loop over the blog table list. fixes #19026 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-21 22:16:33 +00:00
duck_ 148a9e8039 Don't cache default value in get_site_option() for non-existent options. Fixes #18955. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-19 21:06:50 +00:00
azaozz 821a38fcbc Add link to the codex in the doing_it_wrong notices, see #18453 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-08 22:48:05 +00:00
dd32 15920fc45b Document that add_query_arg() expects encoded data. See #18086 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-05 11:03:56 +00:00
duck_ 4171ea192b Introduce wp_allowed_protocols() for use in wp_kses() and esc_url(). See #18268. 
This allows plugins to filter the list of protocols used for esc_url() too, and helps us keep the list of protocols in sync.


git-svn-id: http://svn.automattic.com/wordpress/trunk@18826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-29 22:33:51 +00:00
ryan 44029b1ef1 Disallow indexing wp-admin and wp-includes in robots.txt. Props SergeyBiryukov. fixes #18465 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-29 21:47:04 +00:00
markjaquith 58e0851786 Add note about why double-serialization is done. props SergeyBiryukov. fixes #16597 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-29 02:23:26 +00:00
westi b816f54124 Revert [18747] until we can discuss it further. See #18453. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-22 09:15:45 +00:00
westi 19f46502c0 Add support for rar and 7x file uploading. Fixes #16412 props Caspie. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-22 08:29:35 +00:00
azaozz 95e8b34104 Postpone warnings when WP_DEBUG and WP_DEBUG_DISPLAY are set, see #18453 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-22 02:27:00 +00:00
ryan bad1132fdf Mark some string in dead_db() for translation. Props mako09, SergeyBiryukov. fixes #17815 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-19 20:21:39 +00:00
dd32 085ba95a60 Fix wp_list_filter() OR operator. Props kevinB. Fixes #18092 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-19 03:59:52 +00:00
duck_ cda68f14f9 Introduce wp_suspend_cache_addition() to allow reduced memory usage when cache additions aren't useful. Fixes #5389. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-15 20:23:00 +00:00
nacin 01073d5f3c Add phpdoc for default arg for get_option(). props amereservant, solarissmoke, fixes #17819. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-09 17:53:41 +00:00
nacin db6765354d s/robot/robots/. props madjax, fixes #18612. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-07 13:45:06 +00:00
duck_ e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-03 16:02:41 +00:00
ryan 978a5984b4 Properly handle nested arrays in wp_list_filter(). Props scribu, SergeyBiryukov. fixes #16137 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-25 19:50:29 +00:00
ryan 8edc944b01 wp_list_pluck() performance improvement. Props Otto42. fixes #18230 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-25 18:22:17 +00:00
duck_ c06290958b Allow update_site_option to add false-y values. Fixes #15497 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-23 21:12:14 +00:00
duck_ 7213d24276 Use get_site_option in add/update_site_option for caching and filtering benefits. fixes #18478 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-23 20:45:48 +00:00
duck_ 56f6f97125 add_site_option should not update existing options, should return a boolean and should only run actions on success. fixes #18422 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-23 20:24:35 +00:00
duck_ 48974fa6e2 add_option() should always return a boolean, see #18422 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-18 18:17:37 +00:00
westi ec3476720e Fix html for back link in _default_wp_die_handler. Fixes #18459 props tenpura. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-17 10:54:48 +00:00
duck_ 7abbb42d7e Replace regex in path_is_absolute() with simpler equality checks. props coffee2code. fixes #17754 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-16 00:21:56 +00:00
nacin 2bdadbcc52 Break HTML comment up into two lines to prevent phpxref from choking on the rest of functions.php. props trepmal, fixes #18409. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-15 04:51:41 +00:00
nacin 31e6144688 Pedantic whitespace in validate_file(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-13 06:10:02 +00:00
westi e8f9ea22eb Move the CSS inline to wp_die so that it is always available. Fixes #17975, props kawauso for the style type update. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-11 19:06:59 +00:00
nacin c3c4ced486 Pass old value to update_site_option hooks. props westi, fixes #17974. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-10 18:59:50 +00:00
azaozz 5256d7951f <!DOCTYPE html> for all, fixes #18202 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-22 00:25:41 +00:00
ryan f0fc1f3e48 Strip trailing slashes form WP_HOME and WP_SITEURL. Props xknown. fixes #17898 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-21 21:35:23 +00:00
ryan 62f427a096 phpdoc typo fixes for functions.php. Props coffee2code. fixes #17752 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-21 17:48:25 +00:00
nacin 55ddb508e1 Remove undiscussed FIXME from add_option. fixes #16813. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-19 21:37:47 +00:00
ryan e91971979b Properly return referrer when referer = true and echo = false. Props scribu, webduo. fixes #11953 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-03 18:23:41 +00:00
westi 15fe54e3e0 Add .ics / text/calendar to the whitelist of allowed file types. Fixes #15916 props SergeyBiryukov 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-01 15:08:48 +00:00
ryan 4da684cf9a Update @since 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-25 15:47:17 +00:00
nacin da2732c7de Use wp_remote_retrieve_* helper functions instead of the raw HTTP response array. props aaroncampbell, fixes #17416. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-14 19:45:07 +00:00
westi da5ca1d1c6 Restore the functionality of date_i18n to pre [17747] so that is works without a provided timestamp again. Fixes #17278. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-08 17:14:36 +00:00
ryan b58636e914 Send X-Frame-Options: SAMEORIGIN for admin and login pages. see #12293 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-06 21:28:53 +00:00
markjaquith ce344a28da Speed optimizations for is_serialized_string(). fixes #17129 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-30 04:41:56 +00:00
nacin 59446cff1d Remove default-embeds.php. fixes #17112. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 17:03:23 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 15:24:49 +00:00
nacin 97c39c24a2 Remove PHP 5.1/Windows code from date_i18n. Allows timestamps from pre-1970. props DH-Shredder, fixes #10332. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 15:13:30 +00:00
westi eed35967cc Introduce a special wp_die handler for XMLRPC requests to ensure we send an XML response. 
Props koke for the original patch. See #16748.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-17 08:35:51 +00:00
westi 9c0a5cd498 Don't do SSL discovery for every RSD request. APP endpoint already respects the SSLness of the site. Fixes #15960. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-17 07:48:34 +00:00
ryan 8f8b8d16a7 Remove PHP4 timezone support. Props hakre. fixes #16970 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-13 17:30:02 +00:00
ryan e3895262ef Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-06 17:44:29 +00:00
ryan 91dc365567 Take out unnecessary compat functions from compat.php. Props hakre, ptahdunbar. see #16918 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-05 17:13:04 +00:00
dd32 00dc7a57d6 First run of introducing Stream-To-File for the WP_HTTP API. Reduces memory consumption during file downloads. Implemented in download_url() for upgraders. Props sivel. See #16236 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-25 02:42:20 +00:00
markjaquith acb3938c8a Make plugin header parsing slightly more liberal (like it was in 3.0), to allow for PHPdoc style headers. props miqrogroove. fixes #16751 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-09 05:46:58 +00:00
ryan f63ccddadb Pink the whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-02-09 17:35:36 +00:00
ryan 6fbe3c685d Return early if list is not an array. Props nacin. fixes #16499 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-02-09 17:06:22 +00:00
ryan 1e7b49cece Set tag_id for tag queries. Add NOT support to wp_list_filter(). Props scribu. fixes #16170 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-11 18:56:59 +00:00
ryan 58e65d1855 Admin bar visibility prefs. Props duck_. see #15829 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-17 21:48:30 +00:00
westi a97dcfe8a7 -- bad white space 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-17 08:40:15 +00:00
westi ea07e29db6 Ensure show_admin_bar( false ) works after init. Fixes #15856. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-17 08:34:36 +00:00
ryan 2cc6b2e7ff phpdoc notation fixes. Props demetris. fixes #15852 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 22:46:13 +00:00
ryan 7e25e3b363 Add like_escape() to some queries. fixes #15764 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 14:22:41 +00:00
nacin a5ae036374 Grammar and spelling. see #15824. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-15 12:09:53 +00:00
nacin f0b562c861 Move _doing_it_wrong to other debug functions. Modify docs and the output message. see #15824. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-15 12:06:39 +00:00
westi 465026255f Better message text to reflect that it might not just be an incorrect argument but maybe your calling something way too early. See #15824 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-15 11:39:23 +00:00
westi 4207e8fa19 Zap the extra * props duck_ 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-15 11:34:52 +00:00
westi ed33168add Introduce _doing_it_wrong(). See #15824. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-15 11:29:50 +00:00
dd32 20e1171ae8 Fix fatal error on IIS after r16797. props peaceablewhale. Limit variable string searching when possible. See #10187 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-14 08:31:33 +00:00
ryan 3949ce12d0 Pink trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-13 21:21:50 +00:00
scribu 7af05b685c Correct get_file_data() inline doc. Fixes #14071 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-09 03:30:23 +00:00
markjaquith 5cfe6c81cc Fix up the PHPdoc for get_file_data(). props hakre. fixes #14071 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-06 03:44:36 +00:00
markjaquith df1887a81a Standardize around "Update" instead of "Upgrade." props RanYanivHartstein. props latz. fixes #14107 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-02 21:45:47 +00:00
ryan 3f72e340d6 Update since phpdoc. Props demetris. fixes #15445 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-01 19:24:38 +00:00
scribu 6e2eae9736 Minor code beautification. Props hakre. Fixes #15569 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-25 02:14:33 +00:00
scribu 3230b44f63 Make get_file_data() regex even more precise. Props hakre. See #15193 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-23 19:37:31 +00:00
nacin b8ce0261df More param fixes, props duck_. see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-18 19:12:48 +00:00
ryan 847499e531 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 18:47:34 +00:00
nbachiyski 27200382fa Fallback to only RTL attributes in wp_die()'s HTML tag if it's very early in the execution. Fixes #6132. Props RanYanivHartstein and nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-15 20:13:05 +00:00
nacin 478186859b Properly check, initialize, or cast a number of variables. props ChenHui. see #14642. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-15 06:38:10 +00:00
scribu 03dd41a0d2 Improve hook readability via curly brackets. Props jjj for initial patch. Fixes #15422 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-14 15:50:02 +00:00
nacin 81a8f2d3ce Use square brackets instead of braces for string access. props hakre, fixes #13900. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 09:53:55 +00:00
ryan 3a4671f530 Prevent stomping of global. Props prettyboymp. fixes #13945 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-11 16:22:18 +00:00
ryan 6ea5924298 Faster is_serialized(). Props duck_, hakre, Denis-de-Bernardy. see #14429 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-11 16:10:16 +00:00
scribu a1d7b0f945 Make get_file_data() regex more precise. Fixes #15193 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-05 22:22:28 +00:00
westi 93bb73ea88 Restore the functionality of some of the other timezone format modifiers in date_i18n props nbachiyski. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-05 11:19:06 +00:00
nacin 63d8410bfa Move an array cast further down the stack. props filosofo, fixes #13965. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 22:39:53 +00:00
westi 00cfb6bd82 Fix some notices when pinging 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 07:07:28 +00:00
westi 1237f25dc6 Add a TODO to review this code later. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 22:00:53 +00:00
westi 717ef94b9b Missing part of the admin bar rework. See #14772 props filosofo. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 11:48:22 +00:00
nacin 7c92b4ca0d Use esc_html. Ancient, deprecated functions, but a valid fix nonetheless. fixes #14199. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 06:30:59 +00:00
nacin 71815b682c Use call_user_func for wpnique_filename callback. fixes #14627. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 22:27:06 +00:00
nacin 81f2d8b405 Don't show the admin bar in the plugin/theme installers. Inserts condition directly into iframe_header(). Allows show_admin_bar() to be called after init by unsetting wp_admin_bar, thus preventing render once those hooks are fired. see #14772. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-23 19:49:25 +00:00
westi eb3d1dd7c8 Fix variable mis-name. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-20 13:38:50 +00:00
ryan a002cfdc7f Equal equal equal. see #14772 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-20 13:27:55 +00:00