WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
50,440 Commits 50 Branches 749 Tags 992 MiB
Commit Graph

41 Commits

Author SHA1 Message Date
Sergey Biryukov 49ed36d717 Twenty Fourteen: Fix various PHPCS issues. 
* Inline comments must end in full stops, exclamation marks, or question marks.
* There must be exactly one blank line after the file comment.

Follow-up to [24832], [25023], [25088], [25090], [25213], [51045].

Props pitamdey, dhruvang21, aristath.
Fixes #62098.
Built from https://develop.svn.wordpress.org/trunk@59158


git-svn-id: http://core.svn.wordpress.org/trunk@58553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2024-10-02 19:03:19 +00:00
hellofromTonya 234877c9c3 Coding Standards: Add `public` visibility to methods in `src` directory. 
This commit adds the `public` visibility keyword to each method which did not have an explicit visibility keyword.

Why `public`?

With no visibility previously declared, these methods are implicitly `public` and available for use. Changing them to anything else would be a backwards-compatibility break.

Props costdev, jrf.
See #54177.
Built from https://develop.svn.wordpress.org/trunk@51919


git-svn-id: http://core.svn.wordpress.org/trunk@51512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2021-10-18 17:52:58 +00:00
hellofromTonya 68e0c5e520 Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Widget::update()`. 
In each child class, renames the parameter to match the parent's method signature.
Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

Adds @since to clearly specify why the change happened.

Replaces the original with the variable name with within each method.
Why? The new name is more specific and descriptive, which improves readability.

Follow-up to [10782], [25090], [26556], [40640].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.
Built from https://develop.svn.wordpress.org/trunk@51789


git-svn-id: http://core.svn.wordpress.org/trunk@51396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2021-09-09 20:13:57 +00:00
Sergey Biryukov 38676936ba Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:02:11 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation. 
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-03 00:41:05 +00:00
Sergey Biryukov ac10f9b9e4 Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article. 
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45675


git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:46:55 +00:00
Gary Pendergast c71bc1513e Coding Standards: Add missing translator comments to the default themes. 
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:10:00 +00:00
Sergey Biryukov 37f04694d5 Bundled Themes: Use consistent HTML comments after closing HTML tags. 
Props iamdmitrymayorov.
Fixes #46871.
Built from https://develop.svn.wordpress.org/trunk@45209


git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 01:30:53 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Sergey Biryukov 510feac5bb Twenty Fourteen: Remove redundant `@access` and `@static` notations from classes. 
Props birgire.
See #41452, #42803, #42505.
Built from https://develop.svn.wordpress.org/trunk@42749


git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 20:49:30 +00:00
Gary Pendergast aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Weston Ruter 7af3b92736 Media: Upgrade MediaElement.js from 2.22.0 to 4.2.3. 
Props rafa8626, grosbouff, westonruter, azaozz, Plastikschnitzer for testing.
See #39686.

Built from https://develop.svn.wordpress.org/trunk@41198


git-svn-id: http://core.svn.wordpress.org/trunk@41038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-08-01 04:43:51 +00:00
Weston Ruter f3f84d2f21 Customize: Require opt-in for selective refresh of widgets. 
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.

Built from https://develop.svn.wordpress.org/trunk@37040


git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-21 21:59:29 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Sergey Biryukov 31c11b1f0d Bundled themes: After [31453], replace `current()` with `reset()`, which is guaranteed to be the first item. 
see #31259, #31260.
Built from https://develop.svn.wordpress.org/trunk@31842


git-svn-id: http://core.svn.wordpress.org/trunk@31824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-20 02:04:27 +00:00
Lance Willett 86a133a79a Bundled themes: replace `array_shift()` with `current()` for performance. 
Props SergeyBiryukov, fixes #31260.
Built from https://develop.svn.wordpress.org/trunk@31453


git-svn-id: http://core.svn.wordpress.org/trunk@31434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 17:52:27 +00:00
Lance Willett 17f69a89d4 Twenty Fourteen: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31250


git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 19:03:23 +00:00
Sergey Biryukov 9998560152 Twenty Fourteen: Avoid a PHP notice in Ephemera widget. 
props jartes.
fixes #28055.
Built from https://develop.svn.wordpress.org/trunk@28248


git-svn-id: http://core.svn.wordpress.org/trunk@28076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 18:46:17 +00:00
Lance Willett a46e7ca3dc Twenty Fourteen: remove doc block comments for `@return void`. See #27098, props philiparthurmoore. 
Built from https://develop.svn.wordpress.org/trunk@27595


git-svn-id: http://core.svn.wordpress.org/trunk@27438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 22:44:14 +00:00
Lance Willett 589709bc3a Twenty Fourteen: improve i18n in Ephemera widget for better translation of plurals for post format archives. Fixes #27069, props Chouby, SergeyBiryukov, lancewillett. 
Built from https://develop.svn.wordpress.org/trunk@27589


git-svn-id: http://core.svn.wordpress.org/trunk@27432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 18:50:13 +00:00
John Blackbourn 79d274f2f6 Add context and a missing period to widget descriptions. Fixes #26668. Props pavelevap, Hanni 
Built from https://develop.svn.wordpress.org/trunk@27412


git-svn-id: http://core.svn.wordpress.org/trunk@27259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 17:26:17 +00:00
Lance Willett 27097dea2c Twenty Fourteen: fix Ephemera Widget to avoid showing full post content when displayed in single post or page. Restore the global `$more` to its original value after the widget output to avoid any issues caused by changing a global variable. 
Props obenland, mor10, Frank Klein. See #26961.
Built from https://develop.svn.wordpress.org/trunk@27124


git-svn-id: http://core.svn.wordpress.org/trunk@26991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-07 18:03:13 +00:00
Lance Willett 3e24cf1636 Twenty Fourteen: remove redundant parentheses and translation wrapper, see #25946. 
Built from https://develop.svn.wordpress.org/trunk@26698


git-svn-id: http://core.svn.wordpress.org/trunk@26588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 22:47:10 +00:00
Lance Willett dd6d39ba9d Twenty Fourteen: remove trailing slashes on void elements such as meta and link, and remove type attribute from script element. See #24499. 
Built from https://develop.svn.wordpress.org/trunk@26672


git-svn-id: http://core.svn.wordpress.org/trunk@26562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 17:54:09 +00:00
Lance Willett 8858b43027 Twenty Fourteen: remove more widget cache code, props obenland. See #26210. 
Built from https://develop.svn.wordpress.org/trunk@26580


git-svn-id: http://core.svn.wordpress.org/trunk@26470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 18:54:09 +00:00
Lance Willett c2bf2c73c6 Twenty Fourteen: remove transient usage in Ephemera widget to fix caching issues. Props obenland, closes #26210 and #26335. 
Built from https://develop.svn.wordpress.org/trunk@26577


git-svn-id: http://core.svn.wordpress.org/trunk@26468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 18:47:09 +00:00
Lance Willett e46662b6ae Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837. 
Built from https://develop.svn.wordpress.org/trunk@26556


git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 17:06:11 +00:00
Lance Willett b385a108ed Twenty Fourteen: remove redundant gettext call, props defries. See #25946. 
Built from https://develop.svn.wordpress.org/trunk@26355


git-svn-id: http://core.svn.wordpress.org/trunk@26256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-24 15:19:11 +00:00
Lance Willett 9e201fadff Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093. 
Built from https://develop.svn.wordpress.org/trunk@26260


git-svn-id: http://core.svn.wordpress.org/trunk@26166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-18 23:11:10 +00:00
Lance Willett a52f3ebb7b Twenty Fourteen: limit back compat to 3.6 and later versions. See #26055, props obenland. 
Built from https://develop.svn.wordpress.org/trunk@26225


git-svn-id: http://core.svn.wordpress.org/trunk@26132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-15 21:15:10 +00:00
Lance Willett 2b1c6c8ba4 Twenty Fourteen: fix tabs to spaces in two files. See #25946. 
Built from https://develop.svn.wordpress.org/trunk@26154


git-svn-id: http://core.svn.wordpress.org/trunk@26065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-14 04:57:10 +00:00
Lance Willett c8cfe17a02 Twenty Fourteen: simplify and prefix post thumbnail sizes, props obenland. See #25946. 
Built from https://develop.svn.wordpress.org/trunk@26152


git-svn-id: http://core.svn.wordpress.org/trunk@26063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-14 04:50:11 +00:00
Lance Willett c1b0fa9039 Twenty Fourteen: add Audio post format support. Props celloexpressions, closes #25807. 
Built from https://develop.svn.wordpress.org/trunk@26020


git-svn-id: http://core.svn.wordpress.org/trunk@25951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-05 21:52:09 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit. 
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-30 14:39:10 +00:00
Lance Willett 07b4a0a1bc Twenty Fourteen: fix typo that prevented author name display in Ephemera widget. Props iamtakashi, fixes #25641. 
Built from https://develop.svn.wordpress.org/trunk@25855


git-svn-id: http://core.svn.wordpress.org/trunk@25855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:57:25 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Lance Willett 74a2b63958 Twenty Fourteen: fix typo that prevented author name display in Ephemera widget. Props iamtakashi, fixes #25641. 
Built from https://develop.svn.wordpress.org/trunk@25855


git-svn-id: http://core.svn.wordpress.org/trunk@25767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-21 16:34:09 +00:00
Lance Willett eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257. 
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-11 22:02:11 +00:00
Lance Willett 66be5edfb5 Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054. 
Built from https://develop.svn.wordpress.org/trunk@25743


git-svn-id: http://core.svn.wordpress.org/trunk@25656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-09 19:07:09 +00:00
Lance Willett be1ff0f752 Twenty Fourteen: more Genericons fixes, merging exact files with latest Genericons 3.0 files for consistency and future ease of merging. Props obenland and georgestephanis, fixes #25085. 
Built from https://develop.svn.wordpress.org/trunk@25506


git-svn-id: http://core.svn.wordpress.org/trunk@25427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-19 18:05:12 +00:00
Lance Willett 945b12bfcf Twenty Fourteen: widgetize the Post Format front page so other widgets can be used there, and the special Post Format content can be used in other widget areas. Props obenland, see #25028. 
Built from https://develop.svn.wordpress.org/trunk@25090


git-svn-id: http://core.svn.wordpress.org/trunk@25074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-22 18:06:09 +00:00