Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
laurelfulford
78a71b94bf
Twenty Seventeen: Correct date in changelog for 4.9.8 release.
...
Props pbiron, laurelfulford.
Fixes #44646 .
Built from https://develop.svn.wordpress.org/trunk@43550
git-svn-id: http://core.svn.wordpress.org/trunk@43379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-02 15:33:24 +00:00
laurelfulford
7063c45879
Twenty Seventeen: Bump version number and update changelog for 4.9.8 release.
...
Props pbiron.
Fixes #44646 .
Built from https://develop.svn.wordpress.org/trunk@43541
git-svn-id: http://core.svn.wordpress.org/trunk@43370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-27 18:37:25 +00:00
Sergey Biryukov
5d4df64715
Twenty Seventeen: Correct list item style for nested unordered lists.
...
Props macbookandrew, audrasjb.
Fixes #44109 .
Built from https://develop.svn.wordpress.org/trunk@43493
git-svn-id: http://core.svn.wordpress.org/trunk@43320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 16:35:24 +00:00
laurelfulford
12737b798b
Bundled Themes: Bump version numbers and update changelogs for 4.9.6 release
...
* Also, updates POT files for Twenty Ten and Twenty Eleven.
Props earnjam, laurelfulford.
Fixes #43915 .
Built from https://develop.svn.wordpress.org/trunk@43293
git-svn-id: http://core.svn.wordpress.org/trunk@43122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 17:07:22 +00:00
iandunn
aa01cbe691
Comments: Move comment consent `input` outside the `label` for a11y.
...
Non-wrapping `label`s are more widely supported by assitive technologies. The CSS changes account for the element re-ordering, and tweak the formatting for improved readability.
Props afercia, xkon, laurelfulford, azaozz.
Fixes #43436 .
Built from https://develop.svn.wordpress.org/trunk@43125
git-svn-id: http://core.svn.wordpress.org/trunk@42954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:00:49 +00:00
iandunn
b4290211f4
Bundled Themes: Add link to privacy policy page in footer.
...
If a privacy policy has been set, then a link to it will automatically be shown in the footer.
The element containing the "Proudly powered by WordPress" link was chosen for the new policy link, in order to minimize visual conflicts with custom CSS that was written before the new link existed. Unfortunately, some minor conflicts are expected and unavoidable. Adding this link is required as part of GDPR compliance, and the benefits outweigh the downsides.
To further mitigate the conflicts, a new `imprint` class was added to the "Proudly powered..." link, in order to facilitate targeting each link invididually with custom styles.
Props xkon, laurelfulford, birgire, azaozz, iandunn.
See #43715 .
Built from https://develop.svn.wordpress.org/trunk@43051
git-svn-id: http://core.svn.wordpress.org/trunk@42880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 06:28:21 +00:00
Sergey Biryukov
2f0f413aa5
Twenty Ten: Restore `max-width` on `.wp-caption`.
...
[42837] fixed the compatibility issue caused by [41724], returning the caption shortcode to the pre-4.9.0 behavior.
Reverts [42386].
Fixes #42604 .
Built from https://develop.svn.wordpress.org/trunk@42886
git-svn-id: http://core.svn.wordpress.org/trunk@42716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-28 01:51:29 +00:00
Sergey Biryukov
fa47925a9a
Twenty Seventeen: Bump version and update the changelog.
...
Props audrasjb.
Fixes #43572 .
Built from https://develop.svn.wordpress.org/trunk@42881
git-svn-id: http://core.svn.wordpress.org/trunk@42711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-27 21:06:30 +00:00
Joe McGill
0a02c87b48
Update Hello Dolly lyrics.
...
This updates the Hello Dolly plugin to remove lines which could be objectionable when shown in the admin out of context, and brings the lyrics more in line with Louis Armstrong's recording.
Props sebastienthivinfocom, birgire, audrasjb, joemcgill.
Fixes #43555 .
Built from https://develop.svn.wordpress.org/trunk@42839
git-svn-id: http://core.svn.wordpress.org/trunk@42669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-17 20:23:32 +00:00
Sergey Biryukov
510feac5bb
Twenty Fourteen: Remove redundant `@access` and `@static` notations from classes.
...
Props birgire.
See #41452 , #42803 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42749
git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:49:30 +00:00
Sergey Biryukov
7d2cd516d1
Twenty Seventeen: Underline links in comments.
...
Props jainnidhi, larrach, audrasjb.
Fixes #43317 .
Built from https://develop.svn.wordpress.org/trunk@42713
git-svn-id: http://core.svn.wordpress.org/trunk@42541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-15 03:34:30 +00:00
Sergey Biryukov
351d71d7ea
Twenty Seventeen: Remove unnecessary comment in `front-page.php`.
...
Props hardik-amipara, poena.
Fixes #42820 .
Built from https://develop.svn.wordpress.org/trunk@42437
git-svn-id: http://core.svn.wordpress.org/trunk@42267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:01:51 +00:00
atimmer
f6a37e7d39
Docs: Remove `@summary` tags from JSDoc.
...
As decided in the JavaScript core chat. With a few reasons:
* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.
The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.
Props herregroen.
Fixes #42901 .
Built from https://develop.svn.wordpress.org/trunk@42411
git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
Konstantin Obenland
d6ffe16606
Twenty Ten: Use global img contraint for captions
...
Fixes an incompatibility with the way caption width is set since 4.9, where the caption element would cover the whole content width.
Props slilley, Clorith, hardeepasrani.
Fixes #42604 .
Built from https://develop.svn.wordpress.org/trunk@42386
git-svn-id: http://core.svn.wordpress.org/trunk@42215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 23:32:46 +00:00
Sergey Biryukov
216441356a
Twenty Seventeen: Correct the number of recent posts in a comment in `template-parts/page/content-front-page-panels.php`.
...
Props skostadinov, marcelo2605.
Fixes #42621 .
Built from https://develop.svn.wordpress.org/trunk@42348
git-svn-id: http://core.svn.wordpress.org/trunk@42177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:47:52 +00:00
Sergey Biryukov
82e5b30939
Twenty Seventeen: Use consistent wording when referring to the front page in inline docs.
...
Props chetan200891.
Fixes #42666 .
Built from https://develop.svn.wordpress.org/trunk@42347
git-svn-id: http://core.svn.wordpress.org/trunk@42176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:44:47 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast
c90cfa3b50
General: Fix some precision alignment formatting warnings.
...
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42228
git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
Gary Pendergast
a779284c00
General: Reformat inline `if ()` statements inside HTML tags.
...
This pattern occurs a handful of times across the codebase:
`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`
Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42217
git-svn-id: http://core.svn.wordpress.org/trunk@42046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 04:09:49 +00:00
David A. Kennedy
7b74056cf5
Bundled Themes: Bump version numbers and update changelogs for 4.9 release
...
* Also, updates POT files for Twenty Ten and Twenty Eleven.
Props lemacarl, maedahbatool, mrahmadawais, davidakennedy.
Fixes #42090 .
Built from https://develop.svn.wordpress.org/trunk@42105
git-svn-id: http://core.svn.wordpress.org/trunk@41934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 22:43:47 +00:00
David A. Kennedy
750098da21
Bundled Themes: Make sure new gallery widgets look good in themes
...
Twenty Ten: Reduces image size and removes image borders for galleries in widget areas.
Twenty Eleven: Reduces image size and removes image borders for galleries in widget areas.
Twenty Twelve: Reduces image size for some gallery sizes in widget areas.
Twenty Thirteen: Ensure proper clearing for images, hide captions for some gallery column combos and ensure good display for galleries in widget areas.
Twenty Fourteen: Ensure proper clearing for images and hide captions for some gallery column combos for galleries in widget areas.
Twenty Seventeen: Hide captions for some gallery column combos for galleries in widget areas.
Props joyously, williampatton, davidakennedy, melchoyce, crunnells.
Fixes #41969 .
Built from https://develop.svn.wordpress.org/trunk@42019
git-svn-id: http://core.svn.wordpress.org/trunk@41853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 02:17:47 +00:00
David A. Kennedy
55c8978f1f
Twenty Seventeen: Make gallery link styles consistent in all widget areas
...
Removes the box shadow on gallery links in footer widget areas so they're consistent with the sidebar widget area.
Props transl8or, sami.keijonen, davidakennedy.
Fixes #42302 .
Built from https://develop.svn.wordpress.org/trunk@42004
git-svn-id: http://core.svn.wordpress.org/trunk@41838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:53:51 +00:00
David A. Kennedy
b6539fb5a0
Twenty Seventeen: Fix double bottom-margins below embeds
...
Corrects an issue where both the containing paragraph and embed had bottom margins, causing unwanted extra space.
Props westonruter.
Fixes #42118 .
Built from https://develop.svn.wordpress.org/trunk@41888
git-svn-id: http://core.svn.wordpress.org/trunk@41722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 22:50:51 +00:00
Weston Ruter
da565a20b9
Twenty Seventeen: Fix positioning of edit shortcuts when partials are nested inside a frontpage panel.
...
Fixes #41557 .
Built from https://develop.svn.wordpress.org/trunk@41842
git-svn-id: http://core.svn.wordpress.org/trunk@41676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-12 04:44:45 +00:00
Sergey Biryukov
0b39f4c99d
Twenty Seventeen: Add missing `@return` tag for `twentyseventeen_video_controls()`.
...
Props ndoublehwp, audrasjb.
Fixes #41927 .
Built from https://develop.svn.wordpress.org/trunk@41780
git-svn-id: http://core.svn.wordpress.org/trunk@41614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-06 01:35:47 +00:00
Sergey Biryukov
2c5a378291
Twenty Fourteen: Add missing singular placeholder in `comments.php`.
...
Uses the recommended pattern for better compatibility with languages that use the singular form for other numbers. Also adds translator comments.
Props bplv, xkon.
See #39660 .
Built from https://develop.svn.wordpress.org/trunk@41762
git-svn-id: http://core.svn.wordpress.org/trunk@41596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 00:42:46 +00:00
Sergey Biryukov
0a2c1d7749
Twenty Fifteen: Add missing singular placeholder in `comments.php`.
...
Uses the recommended pattern for better compatibility with languages that use the singular form for other numbers. Also adds translator comments.
Props bplv, xkon.
See #39660 .
Built from https://develop.svn.wordpress.org/trunk@41761
git-svn-id: http://core.svn.wordpress.org/trunk@41595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 00:41:46 +00:00
Sergey Biryukov
9319a9cec9
Bundled Themes: Restore double line breaks before media queries.
...
See #40138 .
Built from https://develop.svn.wordpress.org/trunk@41757
git-svn-id: http://core.svn.wordpress.org/trunk@41591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 00:02:48 +00:00
Sergey Biryukov
203b275658
Bundled Themes: Change tag cloud format to a list (`<ul>`) for better semantics and accessibility.
...
List markup allows screen reader users to know in advance how many tags are within the list.
Props xkon, davidakennedy.
Fixes #40138 .
Built from https://develop.svn.wordpress.org/trunk@41756
git-svn-id: http://core.svn.wordpress.org/trunk@41590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:53:47 +00:00
Sergey Biryukov
821004b1a6
Twenty Seventeen: After [41703], adjust RTL styles for tag cloud widget.
...
Props davidakennedy.
Fixes #40184 .
Built from https://develop.svn.wordpress.org/trunk@41754
git-svn-id: http://core.svn.wordpress.org/trunk@41588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:35:50 +00:00
Sergey Biryukov
44e23c2dab
Twenty Sixteen: Make sure comment number comparison in `comments.php` works as expected.
...
`get_comments_number()` returns a numeric string, not an integer.
See #39660 .
Built from https://develop.svn.wordpress.org/trunk@41729
git-svn-id: http://core.svn.wordpress.org/trunk@41563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 13:22:48 +00:00
Sergey Biryukov
f67678b59a
Twenty Seventeen: Change tag cloud format to a list (`<ul>`) for better semantics and accessibility.
...
List markup allows screen reader users to know in advance how many tags are within the list.
Props sami.keijonen.
Fixes #40184 .
Built from https://develop.svn.wordpress.org/trunk@41703
git-svn-id: http://core.svn.wordpress.org/trunk@41537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-03 12:17:46 +00:00
Sergey Biryukov
c5c5fb1cd3
Twenty Seventeen: Add missing labels for `<aside role="complementary">` widget areas.
...
Props sami.keijonen.
Fixes #42056 .
Built from https://develop.svn.wordpress.org/trunk@41687
git-svn-id: http://core.svn.wordpress.org/trunk@41521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-02 22:04:46 +00:00
Sergey Biryukov
9597082ec9
Twenty Seventeen: Add Docker Hub icon to supported social links.
...
Props xkon.
Fixes #41529 .
Built from https://develop.svn.wordpress.org/trunk@41593
git-svn-id: http://core.svn.wordpress.org/trunk@41426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-25 13:49:43 +00:00
Sergey Biryukov
01efcd51a6
Twenty Seventeen: Add Periscope icon to supported social links.
...
Props xkon.
Fixes #40959 .
Built from https://develop.svn.wordpress.org/trunk@41592
git-svn-id: http://core.svn.wordpress.org/trunk@41425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-25 13:14:45 +00:00
Sergey Biryukov
29fa55f71d
Twenty Sixteen: After [41343], add missing space to `if` condition in `twentysixteen_content_image_sizes_attr()`.
...
Fixes #38468 .
Built from https://develop.svn.wordpress.org/trunk@41580
git-svn-id: http://core.svn.wordpress.org/trunk@41413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-23 12:25:45 +00:00
Sergey Biryukov
6918752529
Twenty Seventeen: Document the type of `$item` argument in `twentyseventeen_dropdown_icon_to_menu_link()` more accurately.
...
Props ndoublehwp.
Fixes #41923 .
Built from https://develop.svn.wordpress.org/trunk@41548
git-svn-id: http://core.svn.wordpress.org/trunk@41381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-20 18:15:46 +00:00
Sergey Biryukov
ca92da1dcc
Twenty Fifteen: Add missing comma in `ie.css`.
...
Props lalitpendhare.
Fixes #41890 .
Built from https://develop.svn.wordpress.org/trunk@41382
git-svn-id: http://core.svn.wordpress.org/trunk@41215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-16 05:12:48 +00:00
Sergey Biryukov
9da1dd552d
Twenty Fifteen: Remove "called called" dittography, missed in [41349].
...
Props birgire.
See #41841 , #41836 .
Built from https://develop.svn.wordpress.org/trunk@41357
git-svn-id: http://core.svn.wordpress.org/trunk@41190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-09 14:48:44 +00:00
Sergey Biryukov
6bea951e7a
Bundled Themes: Remove "called called" and "can can" dittography.
...
Props johnpgreen.
Fixes #41836 .
Built from https://develop.svn.wordpress.org/trunk@41349
git-svn-id: http://core.svn.wordpress.org/trunk@41182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-08 18:13:43 +00:00
Sergey Biryukov
8cfe233137
Twenty Sixteen: Replace inline control structureв to improve code readability.
...
Fixes #38468 .
Built from https://develop.svn.wordpress.org/trunk@41343
git-svn-id: http://core.svn.wordpress.org/trunk@41176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-08 06:04:44 +00:00
Sergey Biryukov
6880400dd5
Twenty Seventeen: Correct the `@return` value for `twentyseventeen_post_thumbnail_sizes_attr()`.
...
Props truongwp.
Fixes #41830 .
Built from https://develop.svn.wordpress.org/trunk@41342
git-svn-id: http://core.svn.wordpress.org/trunk@41175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-08 04:27:44 +00:00
Sergey Biryukov
15c38a8068
Twenty Sixteen: Correct the `@return` value for `twentysixteen_post_thumbnail_sizes_attr()`.
...
Props truongwp.
See #41830 .
Built from https://develop.svn.wordpress.org/trunk@41341
git-svn-id: http://core.svn.wordpress.org/trunk@41174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-08 04:26:45 +00:00
Weston Ruter
7af3b92736
Media: Upgrade MediaElement.js from 2.22.0 to 4.2.3.
...
Props rafa8626, grosbouff, westonruter, azaozz, Plastikschnitzer for testing.
See #39686 .
Built from https://develop.svn.wordpress.org/trunk@41198
git-svn-id: http://core.svn.wordpress.org/trunk@41038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-01 04:43:51 +00:00
Drew Jaynes
07f01a2e10
Docs: Replace a variety of http links referenced in inline docs with their https counterparts (where possible).
...
Props johnpgreen.
Fixes #40732 .
Built from https://develop.svn.wordpress.org/trunk@40948
git-svn-id: http://core.svn.wordpress.org/trunk@40798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 22:06:41 +00:00
Sergey Biryukov
0990313c25
Twenty Sixteen: Allow category display in post preview even when there is only one category.
...
Props lancewillett, davidakennedy.
Fixes #39531 .
Built from https://develop.svn.wordpress.org/trunk@40908
git-svn-id: http://core.svn.wordpress.org/trunk@40758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 12:06:41 +00:00
Dominik Schilling
6a3be0ea29
Twenty Seventeen: Remove/merge unused variables in content-front-page.php.
...
#wceu2017
Props dingo_bastard, mariusvetrici.
Fixes #39771 .
Built from https://develop.svn.wordpress.org/trunk@40904
git-svn-id: http://core.svn.wordpress.org/trunk@40754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 10:20:42 +00:00
Aaron Jorbin
efc146a3ca
Bundled Themes - Bump themes in preparation for 4.8
...
Change version numbers in stylesheets, fix typo in Twenty Fourteen readme and update copyright dates for themes. Twentysixteen wasn't updated this cycle.
See #40745 for changes that helped push this along.
Fixes #40905 .
Props davidakennedy, mrahmadawais, maedahbatool.
Built from https://develop.svn.wordpress.org/trunk@40883
git-svn-id: http://core.svn.wordpress.org/trunk@40733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-08 04:40:43 +00:00
Konstantin Obenland
fd77b45b57
Twenty Sixteen: Add missing binary files
...
They slipped through the cracks when applying/creating patches.
See [40851], #36497 .
Built from https://develop.svn.wordpress.org/trunk@40852
git-svn-id: http://core.svn.wordpress.org/trunk@40703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-30 21:53:40 +00:00