WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
38,532 Commits 50 Branches 749 Tags 983 MiB
Commit Graph

17173 Commits

Author SHA1 Message Date
Andrew Ozz 3266b10d04 Privacy: add "Mine" filter for media similarly to posts and comments. 
Props audrasjb.
See #43820.
Built from https://develop.svn.wordpress.org/trunk@43056


git-svn-id: http://core.svn.wordpress.org/trunk@42885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 15:43:22 +00:00
Andrew Ozz c77a8ed2fc Privacy: add attachments to the personal data export file. 
Props allendav.
See #43883.
Built from https://develop.svn.wordpress.org/trunk@43054


git-svn-id: http://core.svn.wordpress.org/trunk@42883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 13:45:21 +00:00
Andrew Ozz 5133e5131b Privacy: fix and improve the help text about adding a privacy policy page. 
Props idea15, xkon.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@43053


git-svn-id: http://core.svn.wordpress.org/trunk@42882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 11:43:22 +00:00
Andrew Ozz 237df3367b Privacy: only fold the sections in the privacy policy poxtbox when more than one. 
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43052


git-svn-id: http://core.svn.wordpress.org/trunk@42881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-05-01 09:48:21 +00:00
Andrew Ozz d1ab641d16 Privacy: edits and improvements for the default text for a privacy policy. 
Props idea15, allendav.
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43048


git-svn-id: http://core.svn.wordpress.org/trunk@42877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 21:06:21 +00:00
iandunn 9abc0fe73e Privacy: Add `wp_privacy_personal_data_export_file_created` filter. 
This runs immediately after the data export file has been successfully created, allowing plugins to introduce some workflow customizations. For example, a plugin could password-protect the export file, for peace of mind, even though the CSPRN in the filename makes brute force attacks nearly impossible.

See #43546.

Built from https://develop.svn.wordpress.org/trunk@43047


git-svn-id: http://core.svn.wordpress.org/trunk@42876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 21:04:22 +00:00
iandunn 23bf0c7535 Privacy: Add cron to delete expired export files to protect privacy. 
The primary means of protecting the files is the CSPRN appended to the filename, but there is no reason to keep the files after the data subject has downloaded them, so deleting them provides an additional layer of protection. Previously this was done from `wp_privacy_generate_personal_data_export_file()`, but that does not guarantee that it will be run regularly, and on smaller sites that could result in export files being exposed for much longer than necessary.

`wp_privacy_delete_old_export_files()` was moved to a front end file, so that it can be called from `cron.php`.

This introduces the `wp_privacy_export_expiration` filter, which allows plugins to customize how long the exports are kept before being deleted.

`index.html` was added to the `$exclusions` parameter of `list_files()` to make sure that it isn't deleted. If it were, then poorly-configured servers would allow the directory to be traversed, exposing all of the exported files.

Props iandunn, desrosj.
See #43546.

Built from https://develop.svn.wordpress.org/trunk@43046


git-svn-id: http://core.svn.wordpress.org/trunk@42875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 20:09:23 +00:00
iandunn 5b4aa26436 Privacy: Use a CSPRNG in export filenames for more security. 
`rand()` is deterministic and therefore offers much less protection in this context. `wp_generate_password()` is a convenient wrapper around `wp_rand()`, which uses `random_int()` to generate cryptographically-secure psuedorandom numbers.

See #43546.

Built from https://develop.svn.wordpress.org/trunk@43045


git-svn-id: http://core.svn.wordpress.org/trunk@42874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 18:53:25 +00:00
Andrew Ozz c21c4e25b3 Privacy: add default text for a privacy policy. First run. 
Props xkon, idea15, allendav, azaozz.
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43044


git-svn-id: http://core.svn.wordpress.org/trunk@42873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 14:47:21 +00:00
Sergey Biryukov 70a214c186 Help/About: Move "Get involved" link on Credits screen to the top of the page for better visibility. 
Props bridgetwillard, desrosj.
See #23348.
Built from https://develop.svn.wordpress.org/trunk@43032


git-svn-id: http://core.svn.wordpress.org/trunk@42861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-30 03:16:22 +00:00
Sergey Biryukov 00ae0a1097 Docs: Remove backtick-escaping around a core function in the hook docs for the `pre_prepare_themes_for_js` filter. 
This allows the function to be auto-linked in the Developer Reference. Added in [42877].

See #42505.
Built from https://develop.svn.wordpress.org/trunk@43024


git-svn-id: http://core.svn.wordpress.org/trunk@42853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 21:47:22 +00:00
Andrea Fercia e663af477a Coding standards: Change one occurrence of font weight 700 to 600. 
Props chetan200891.
Amends [43018].
See #43897.

Built from https://develop.svn.wordpress.org/trunk@43021


git-svn-id: http://core.svn.wordpress.org/trunk@42850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 18:04:21 +00:00
Andrea Fercia 2e8149064e Accessibility: Improve the Themes Installer navigation buttons accessibility. 
- really disables buttons when they look disabled (when navigation is at the first or last theme)
- when navigation is at the first or last theme, moves focus to the other navigation button, to avoid a focus loss
- improves the buttons visually hidden accessibility text

Props walbo, afercia.
Fixes #36627.

Built from https://develop.svn.wordpress.org/trunk@43020


git-svn-id: http://core.svn.wordpress.org/trunk@42849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 17:04:22 +00:00
Andrea Fercia 8d9f1ae0d5 Accessibility: Better color contrast for the tables pagination links. 
By making the pagination links use the default style for buttons, color contrast
is improved and the CSS is simplified. Improves consistency with other UI controls.
Also, slightly increases the white space below the pagination links.

Props benoitchantre, afercia.
Fixes #41858.

Built from https://develop.svn.wordpress.org/trunk@43019


git-svn-id: http://core.svn.wordpress.org/trunk@42848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 16:25:21 +00:00
Andrea Fercia 26e91765eb Coding standards: Use numeric font weights instead of keywords. 
Fixes #43897.

Built from https://develop.svn.wordpress.org/trunk@43018


git-svn-id: http://core.svn.wordpress.org/trunk@42847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-29 11:37:21 +00:00
Andrew Ozz b044b4053e Privacy: add means to export personal data by username or email address. Generate a zipped export file containing all data. First run. 
Props allendav.
See #43546.
Built from https://develop.svn.wordpress.org/trunk@43012


git-svn-id: http://core.svn.wordpress.org/trunk@42841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-27 19:54:21 +00:00
Andrew Ozz e9eb7518c0 Privacy: update and enhance the method to confirm user requests by email. Introduce WP_User_Request to hold all request vars similarly to WP_Post. 
Props mikejolley.
See #43443.

Built from https://develop.svn.wordpress.org/trunk@43011


git-svn-id: http://core.svn.wordpress.org/trunk@42840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-27 17:31:22 +00:00
Andrew Ozz f1703c0e70 Privacy: update the method to confirm user requests by email. Use a single CPT to store the requests and to allow logging/audit trail. 
Props mikejolley.
See #43443.

Built from https://develop.svn.wordpress.org/trunk@43008


git-svn-id: http://core.svn.wordpress.org/trunk@42837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-27 10:12:22 +00:00
Felix Arntz 6b2e34f703 General: Implement editorial, design and accessibility feedback for the PHP version nag. 
The updated version of the nag is shorter, more on point and less aggressive than the previous one. It integrates better with the other dashboard widgets and fixes several accessibility concerns. A yellow warning color is used when the current PHP version is outdated, a red error color is used when it is also insecure.

Props afercia, birgire, danieltj, flixos90, johnjamesjacoby, karmatosed, Luciano Croce, nerrad, pento, schlessera, SergeyBiryukov, sonjaleix.

Fixes #41191.

Built from https://develop.svn.wordpress.org/trunk@43006


git-svn-id: http://core.svn.wordpress.org/trunk@42835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-26 14:31:24 +00:00
Andrew Ozz 41a82d6078 Privacy: add better docs for `wp_add_privacy_policy_content()` and `WP_Privacy_Policy_Content::add()`. 
See #43620.
Built from https://develop.svn.wordpress.org/trunk@43003


git-svn-id: http://core.svn.wordpress.org/trunk@42832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-25 18:10:21 +00:00
Andrew Ozz 13875fbddb Privacy: fix styling of counts on the list tables for user requests. 
Props allendav.
Fixes #43846.
Built from https://develop.svn.wordpress.org/trunk@43000


git-svn-id: http://core.svn.wordpress.org/trunk@42829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-24 21:35:21 +00:00
Andrew Ozz 11e315ca23 Make the string `WordPress` translatable. 
Props mnelson4.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42999


git-svn-id: http://core.svn.wordpress.org/trunk@42828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-24 21:23:21 +00:00
Felix Arntz c1efc2519b Plugins: Show the required PHP version in the plugin details view, if specified. 
Props xkon.
Fixes #43650.

Built from https://develop.svn.wordpress.org/trunk@42998


git-svn-id: http://core.svn.wordpress.org/trunk@42827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-24 11:41:25 +00:00
Andrew Ozz 81668f8312 Privacy: add functionality to anonymize commenters. 
Props xkon, fclaussen, allendav, birgire, azaozz.
See #43442.
Built from https://develop.svn.wordpress.org/trunk@42994


git-svn-id: http://core.svn.wordpress.org/trunk@42823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-20 12:19:21 +00:00
Andrew Ozz 891deab7c5 Privacy: make the sections in the suggested privacy policy text postbox foldable. Add Read More/Read Less buttons. Fix copying of the suggested text by pressing the button. 
Props melchoyce, xkon, azaozz.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42992


git-svn-id: http://core.svn.wordpress.org/trunk@42821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-19 12:39:21 +00:00
Aaron Jorbin 1da2fdb891 Privacy: Fix JSHint errors 
Introduced in [42986].

See #43440.

Built from https://develop.svn.wordpress.org/trunk@42989


git-svn-id: http://core.svn.wordpress.org/trunk@42818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-19 00:23:20 +00:00
Andrew Ozz b4fdb9ebf2 Privacy: add means to erase personal data by username or email address. First run. 
Props allendav, coreymckrill, ericdaams, azaozz.
See #43637, #43602.
Built from https://develop.svn.wordpress.org/trunk@42986


git-svn-id: http://core.svn.wordpress.org/trunk@42815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-18 22:30:22 +00:00
Andrew Ozz 8d9e4937f8 Fix typo in 'wp_get_default_privacy_policy_content' filter. 
Props claudiu.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42985


git-svn-id: http://core.svn.wordpress.org/trunk@42814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-17 21:09:20 +00:00
Sergey Biryukov acd3f4cb10 I18N: Use consistent pattern for placeholder references in a translator comment in `media_upload_max_image_resize()`. 
See #43523.
Built from https://develop.svn.wordpress.org/trunk@42984


git-svn-id: http://core.svn.wordpress.org/trunk@42813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 18:37:20 +00:00
Sergey Biryukov 3957635dfb I18N: Correct placeholder references in a translator comment in `wp_print_file_editor_templates()`. 
Props afercia.
See #43523.
Built from https://develop.svn.wordpress.org/trunk@42983


git-svn-id: http://core.svn.wordpress.org/trunk@42812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 18:36:24 +00:00
Andrew Ozz 280aeff5d2 Fix typo (missing `!`). 
See #43491.
Built from https://develop.svn.wordpress.org/trunk@42982


git-svn-id: http://core.svn.wordpress.org/trunk@42811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 10:14:21 +00:00
Andrew Ozz f1e065b13b Privacy: automatically create a Privacy Policy page when installing WordPress. 
Props fclaussen, azaozz.

Fixes #43491.
Built from https://develop.svn.wordpress.org/trunk@42981


git-svn-id: http://core.svn.wordpress.org/trunk@42810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 09:00:20 +00:00
Andrew Ozz 3108d2ffb2 Privacy: add a postbox that is shown when editing the privacy policy page, and where plugins and core will output suggested content and additional privacy info. First run. 
Props melchoyce, azaozz.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42980


git-svn-id: http://core.svn.wordpress.org/trunk@42809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 08:53:20 +00:00
Peter Wilson fc20505750 Upgrade/Install: Use high-dpi plugin icons on update dashboard. 
Reorder the `$preferred_icons` array for plugins to prefer high-dpi icons (2x) over standard-dpi icons (1x).

Props dd32.
Fixes #43727.


Built from https://develop.svn.wordpress.org/trunk@42979


git-svn-id: http://core.svn.wordpress.org/trunk@42808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-16 00:13:20 +00:00
Andrew Ozz 4b2587abda Privacy: improve the screen for setting a privacy policy page. 
Props melchoyce, xkon, azaozz.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42978


git-svn-id: http://core.svn.wordpress.org/trunk@42807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-13 17:56:20 +00:00
Andrew Ozz 600c5082a3 Privacy: fix error message and list table sorting errors on the Export Personal Data and Remove Personal Data screens. 
See #43481.
Built from https://develop.svn.wordpress.org/trunk@42977


git-svn-id: http://core.svn.wordpress.org/trunk@42806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-13 16:15:21 +00:00
Dominik Schilling 3b76937ec8 Administration: Avoid an extra space in the admin body class. 
Props jainnidhi, rhetorical, birgire, mathieuhays.
Fixes #43465.
Built from https://develop.svn.wordpress.org/trunk@42974


git-svn-id: http://core.svn.wordpress.org/trunk@42803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-13 14:03:20 +00:00
Andrew Ozz 5493d8b253 Privacy: add helper function for anonymizing data in a standardized way. 
Props jesperher, allendav, iandunn, birgire, azaozz.
Fixes #43545.
Built from https://develop.svn.wordpress.org/trunk@42971


git-svn-id: http://core.svn.wordpress.org/trunk@42800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-12 21:20:23 +00:00
iandunn 057cef802a Dashboard: Strip more extraneous IP parts to prevent PHP warnings. 
This iterates on earlier versions of the code, in order to handle more edge cases. An arbitrary string like `or=\"` will now be stripped, as well as reachability scopes like `%eth0`.

Props eamax, soulseekah, iandunn.
Fixes #41083.

Built from https://develop.svn.wordpress.org/trunk@42968


git-svn-id: http://core.svn.wordpress.org/trunk@42797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-10 23:19:30 +00:00
Andrew Ozz 108578a8ec Privacy: add new wp-admin screens for exporting and removing of personal data. 
Props @melchoyce, @mikejolley, @allendav, @xkon.
See #43481.
Built from https://develop.svn.wordpress.org/trunk@42967


git-svn-id: http://core.svn.wordpress.org/trunk@42796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-10 18:02:30 +00:00
Adam Silverstein d1d6e8864e Revisions: improve show_split_view=false support for title. 
* When show_split_view argument false, show title changes in a single column and only show title once if title is unchanged.

Props johnbillion, mbelchev.
Fixes #42402.  


Built from https://develop.svn.wordpress.org/trunk@42966


git-svn-id: http://core.svn.wordpress.org/trunk@42795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-10 16:12:30 +00:00
atimmer f111796282 Docs: Improve JSDoc for `wp-admin/js/tags-box.js`. 
Props carolinegeven, andizer, ireneyoast, herregroen, jjcomack.
Fixes #43499.

Built from https://develop.svn.wordpress.org/trunk@42963


git-svn-id: http://core.svn.wordpress.org/trunk@42792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-06 07:47:32 +00:00
atimmer 0c37fe30ac Docs: Fix JS Docs for `custom-header.js`. 
Amends [42385].

Props herregroen.
See #42678.

Built from https://develop.svn.wordpress.org/trunk@42962


git-svn-id: http://core.svn.wordpress.org/trunk@42791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-05 13:40:30 +00:00
Felix Arntz 921e131eae General: Improve wording for PHP version nag. 
This changeset adjusts the tone of the message to fit the usual core voice better and addresses accessibility concerns.

Props schlessera.
See #41191.

Built from https://develop.svn.wordpress.org/trunk@42891


git-svn-id: http://core.svn.wordpress.org/trunk@42721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-04-02 10:15:33 +00:00
Andrew Ozz a4beb40d0b Privacy: add support for exporting multiple pages of personal data. 
Props allendav.
See #43438.
Built from https://develop.svn.wordpress.org/trunk@42889


git-svn-id: http://core.svn.wordpress.org/trunk@42719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-28 19:28:31 +00:00
Sergey Biryukov ff314fd156 Media: Pass EXIF data to the `wp_read_image_metadata` filter. 
Props desrosj.
Fixes #43624.
Built from https://develop.svn.wordpress.org/trunk@42879


git-svn-id: http://core.svn.wordpress.org/trunk@42709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-25 20:45:29 +00:00
Sergey Biryukov 079cfd60a9 Media: In `wp_read_image_metadata()`, rename `$sourceImageType` variable to `$image_type` to match coding standards. 
See #43624.
Built from https://develop.svn.wordpress.org/trunk@42878


git-svn-id: http://core.svn.wordpress.org/trunk@42708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-25 20:41:29 +00:00
John Blackbourn bbcb4300a3 Docs: Correct and improve various inline documentation. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42877


git-svn-id: http://core.svn.wordpress.org/trunk@42707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-25 19:35:29 +00:00
John Blackbourn b13e73d05c Docs: Document more parameters and properties using typed array notation. 
See #41756

Built from https://develop.svn.wordpress.org/trunk@42875


git-svn-id: http://core.svn.wordpress.org/trunk@42705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-25 18:10:32 +00:00
Sergey Biryukov 0895f04705 Docs: Correct method reference in a comment for `Bulk_Plugin_Upgrader_Skin::$plugin_info`. 
See [42677] for `Bulk_Theme_Upgrader_Skin::$theme_info`.

See #42505.
Built from https://develop.svn.wordpress.org/trunk@42873


git-svn-id: http://core.svn.wordpress.org/trunk@42703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-23 00:34:29 +00:00
John Blackbourn 18169f0ae1 Docs: Revert some sneaky debugging code. 
See #41756

Built from https://develop.svn.wordpress.org/trunk@42872


git-svn-id: http://core.svn.wordpress.org/trunk@42702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-22 20:29:30 +00:00
John Blackbourn 1b5d6c6971 Docs: Document many more parameters and properties using typed array notation. 
See #41756

Built from https://develop.svn.wordpress.org/trunk@42871


git-svn-id: http://core.svn.wordpress.org/trunk@42701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-22 20:27:32 +00:00
Sergey Biryukov 61a0745df8 Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens. 
Make `<br />` tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Fixes #42724. See #34539.
Built from https://develop.svn.wordpress.org/trunk@42864


git-svn-id: http://core.svn.wordpress.org/trunk@42694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-20 22:44:31 +00:00
Andrea Fercia d0e1b54105 Accessibility: Menus screen: Improve headings and instructions for better accessibility. 
Props audrasjb, melchoyce, juliemoynat.
Fixes #43397.

Built from https://develop.svn.wordpress.org/trunk@42857


git-svn-id: http://core.svn.wordpress.org/trunk@42687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-20 17:48:21 +00:00
Dominik Schilling 80c9ed8bfa Users: Don't show roles dropdown on user-edit.php if current user cannot promote user. 
Fixes #43580.
Built from https://develop.svn.wordpress.org/trunk@42856


git-svn-id: http://core.svn.wordpress.org/trunk@42686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-19 20:56:32 +00:00
Dominik Schilling 61ba57abb7 Users: Use `promote_users` for role updates in `edit_user()`. 
`edit_user()` can also update user roles but was still using the `edit_users` capability instead of the newer `promote_users` capability introduced in [14176].
This makes the role handling consistent with the bulk dropdown menu for role changes.

Props flixos90, johnjamesjacoby, ocean90.
Fixes #42564.
Built from https://develop.svn.wordpress.org/trunk@42855


git-svn-id: http://core.svn.wordpress.org/trunk@42685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-19 20:29:34 +00:00
Dominik Schilling 5c291d49de Pinking shears. 
See #41057.
Built from https://develop.svn.wordpress.org/trunk@42843


git-svn-id: http://core.svn.wordpress.org/trunk@42673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-18 14:23:33 +00:00
Felix Arntz 176a289050 Multisite: Introduce metadata for sites. 
A new global multisite table `wp_blogmeta` is added to the database schema, and a set of `*_site_meta()` API functions are introduced.

The implementation fails gracefully when the new table is not yet available, which may happen especially shortly after the core update, before the network has been upgraded to the new database schema. The presence of the table is detected once and stored as a global setting on the main network.

Core does not yet use site metadata, but there are several use-cases to be implemented or explored in the near future, and it allows plugins to extend sites with arbitrary data, which will come in particularly handy with the upcoming REST API endpoint for sites.

Props spacedmonkey, johnjamesjacoby, jeremyfelt, flixos90.
Fixes #37923.

Built from https://develop.svn.wordpress.org/trunk@42836


git-svn-id: http://core.svn.wordpress.org/trunk@42666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-16 02:15:31 +00:00
Felix Arntz ed1df81bba General: Introduce dashboard widget to inform administrators about outdated PHP versions. 
This new dashboard widget is shown on WordPress sites which are powered by a PHP version which WordPress considers outdated, in order to inform site owners about the resulting problems and to explain how to upgrade to a supported version. An education page for that purpose has been previously created that the widget links to. The link is translatable so that localized versions of the page can be referred to as they become available.

The nag follows the example of the Browse Happy dashboard widget and is only visible for administrators, or network administrators when using multisite. To determine whether it needs to be displayed, a new wordpress.org API introduced prior is called that handles the version logic in a centralized location.

Props flixos90, hedgefield, schlessera.
Fixes #41191.

Built from https://develop.svn.wordpress.org/trunk@42832


git-svn-id: http://core.svn.wordpress.org/trunk@42662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-12 16:43:31 +00:00
John Blackbourn d7025e7787 Security: Loosen the admin referrer policy header value to allow the referring host to be sent from the admin area in all cases. 
This allows referrer-restricted content from third parties (such as images and fonts) to continue working in the admin area.

Props aranwer104, qcmiao

Fixes #43285

Built from https://develop.svn.wordpress.org/trunk@42830


git-svn-id: http://core.svn.wordpress.org/trunk@42660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-12 10:57:35 +00:00
Dion Hulse 42b03122b5 Plugins: Add support for plugins having an `active_installs` value larger than 1 million. 
WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future.

Fixes #43193.

Built from https://develop.svn.wordpress.org/trunk@42829


git-svn-id: http://core.svn.wordpress.org/trunk@42659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-12 01:57:31 +00:00
Sergey Biryukov 4848a09b35 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders. 
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.
Built from https://develop.svn.wordpress.org/trunk@42827


git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-11 16:44:34 +00:00
Sergey Biryukov fab939595d Docs: Fix typo in a comment in `WP_Community_Events::trim_events()`. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42826


git-svn-id: http://core.svn.wordpress.org/trunk@42656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-11 10:35:31 +00:00
Sergey Biryukov 15e969be8d Docs: Add missing brace in `auto_update_{$type}` filter DocBlock. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42825


git-svn-id: http://core.svn.wordpress.org/trunk@42655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-11 10:30:33 +00:00
Andrew Ozz ba7b8cd8a0 Accessibility improvements for the Privacy Tools screen. 
Propr afercia.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42823


git-svn-id: http://core.svn.wordpress.org/trunk@42653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-10 14:01:31 +00:00
Sergey Biryukov f700ac6075 Docs: Use `WP_Term` instead of generic `object` type for the `$tag` parameter in `wp-admin/edit-tag-form.php` hook docs. 
Props xhezairi, ocean90.
Fixes #43507.
Built from https://develop.svn.wordpress.org/trunk@42822


git-svn-id: http://core.svn.wordpress.org/trunk@42652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-10 02:01:29 +00:00
Adam Silverstein e70caa19a1 Media: Fix image cropping on touch screen devices. 
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.

Props yahil, alexgso, joemcgill.
Fixes #41242.

Built from https://develop.svn.wordpress.org/trunk@42818


git-svn-id: http://core.svn.wordpress.org/trunk@42648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-09 17:27:31 +00:00
Adam Silverstein 6751be3561 Customizer menus: correct oversized viewport after dragging menu items. 
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.

Props kwonye.
Fixes #36884.

Built from https://develop.svn.wordpress.org/trunk@42817


git-svn-id: http://core.svn.wordpress.org/trunk@42647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-09 17:06:30 +00:00
Andrew Ozz b93dfd3571 Add Privacy Tools admin page under the Tools menu. 
Props allendav, xkon, azaozz.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42814


git-svn-id: http://core.svn.wordpress.org/trunk@42644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-09 15:04:33 +00:00
Andrea Fercia 127ecc530c Accessibility: Underline the links in the Plugins descriptions and update notices. 
Links within blocks and lines of text should always be underlined.

Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647.

Built from https://develop.svn.wordpress.org/trunk@42810


git-svn-id: http://core.svn.wordpress.org/trunk@42640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 23:20:30 +00:00
Sergey Biryukov ef33f565b1 Docs: Improve documentation for `add_meta_boxes` and `do_meta_boxes` actions. 
Props danieltj, johnbillion, SergeyBiryukov.
Fixes #43229.
Built from https://develop.svn.wordpress.org/trunk@42796


git-svn-id: http://core.svn.wordpress.org/trunk@42626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 03:57:31 +00:00
Sergey Biryukov 24f43065b9 Docs: Document globals in `wp-admin/revision.php` as `@global` instead of `@param`. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42795


git-svn-id: http://core.svn.wordpress.org/trunk@42625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-08 03:53:34 +00:00
Andrea Fercia ffedf3d752 Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard. 
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.

- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget

See #40677.

Built from https://develop.svn.wordpress.org/trunk@42794


git-svn-id: http://core.svn.wordpress.org/trunk@42624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-07 22:27:31 +00:00
Andrea Fercia e34999f4aa Accessibility: Networks and Sites: mark the New Site required form fields as required. 
Also, adds an `aria-describedby` attribute to associate the Admin Email field with its description.

Props dipesh.kakadiya, jackreichert, rianrietveld.
Fixes #37331.

Built from https://develop.svn.wordpress.org/trunk@42793


git-svn-id: http://core.svn.wordpress.org/trunk@42623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-07 19:41:33 +00:00
Mike Schroder 51b0a3cd28 Media: Correctly allow changing PDF thumbnail crop value. 
Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.

Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226.
Built from https://develop.svn.wordpress.org/trunk@42792


git-svn-id: http://core.svn.wordpress.org/trunk@42622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-07 01:19:31 +00:00
Andrea Fercia 6a4b2a022a Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable. 
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.

Props chetan200891, antonioeatgoat.
Fixes #42778.

Built from https://develop.svn.wordpress.org/trunk@42790


git-svn-id: http://core.svn.wordpress.org/trunk@42620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-06 17:21:33 +00:00
John Blackbourn c9b07e6411 Docs: Standardise and correct documentation relating to parameters which accept plugin names. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42787


git-svn-id: http://core.svn.wordpress.org/trunk@42617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 21:50:31 +00:00
John Blackbourn 087b52dced Upgrade/Install: Fix the format of the `upgrader_process_complete` actions after [42343]. 
More info: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1323

See #41057, #42505

Built from https://develop.svn.wordpress.org/trunk@42786


git-svn-id: http://core.svn.wordpress.org/trunk@42616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 21:44:30 +00:00
Andrea Fercia 9842bd6d24 Accessibility: Change the "Show / Hide dismissed updates" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.

Props Cheffheid, audrasjb, afercia.
Fixes #38674.

Built from https://develop.svn.wordpress.org/trunk@42785


git-svn-id: http://core.svn.wordpress.org/trunk@42615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 15:50:30 +00:00
Andrea Fercia 64634898c2 Accessibility: Change the media upload "Dismiss error" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffheid, audrasjb.
Fixes #38671.

Built from https://develop.svn.wordpress.org/trunk@42784


git-svn-id: http://core.svn.wordpress.org/trunk@42614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 15:33:33 +00:00
Sergey Biryukov 084b48e1ba Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files. 
See #43472.
Built from https://develop.svn.wordpress.org/trunk@42783


git-svn-id: http://core.svn.wordpress.org/trunk@42613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 03:32:30 +00:00
Sergey Biryukov 24f13abf63 Help/About: Remove popular plugins feed reference from help text on Dashboard screen, no longer relevant since [40607]. 
Props denisco.
See #43472.
Built from https://develop.svn.wordpress.org/trunk@42782


git-svn-id: http://core.svn.wordpress.org/trunk@42612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 03:17:31 +00:00
Sergey Biryukov 31a3083c28 Help/About: Update "WordPress News" widget references in help text and inline documentation. 
Props monikarao, denisco.
Fixes #43400, #43472.
Built from https://develop.svn.wordpress.org/trunk@42781


git-svn-id: http://core.svn.wordpress.org/trunk@42611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 03:04:31 +00:00
Sergey Biryukov 5596017878 Media: Recognize `.ico` files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them. 
Props remyvv, Guido07111975.
Fixes #43458.
Built from https://develop.svn.wordpress.org/trunk@42780


git-svn-id: http://core.svn.wordpress.org/trunk@42610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 01:03:31 +00:00
Sergey Biryukov e451dfac9e Help/About: Correct the number of most recent drafts in help text on Dashboard screen. 
Props denisco.
Fixes #43471.
Built from https://develop.svn.wordpress.org/trunk@42779


git-svn-id: http://core.svn.wordpress.org/trunk@42609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-05 00:24:30 +00:00
Sergey Biryukov 3385d5b2de Docs: Expand `delete_theme()` return value, fix typo in `delete_plugins()` return value. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42778


git-svn-id: http://core.svn.wordpress.org/trunk@42608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-04 22:07:29 +00:00
Sergey Biryukov 58592b64dc Docs: Use consistent description for `$wp_filesystem` global. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42777


git-svn-id: http://core.svn.wordpress.org/trunk@42607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-04 21:58:30 +00:00
Sergey Biryukov 179bec1306 Docs: Clarify return values and improve DocBlock formatting for `verify_file_md5()`, `unzip_file()`, `_unzip_file_ziparchive()`, `_unzip_file_pclzip()`, `copy_dir()`, `WP_Filesystem()`. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42776


git-svn-id: http://core.svn.wordpress.org/trunk@42606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-04 21:43:30 +00:00
Sergey Biryukov 3c8ae81018 Docs: Clarify `download_url()` return value, improve DocBlock formatting. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42775


git-svn-id: http://core.svn.wordpress.org/trunk@42605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-04 19:50:31 +00:00
Sergey Biryukov 86c3c7e1c9 Filesystem API: Allow `download_url()` to return the response code and body on error as an additional `WP_Error` object data. 
The error response body size is limited to 1 KB by default to avoid taking up too much memory. The size can be increased using `download_url_error_max_body_size` filter.

Props soulseekah, campusboy1987, mihdan, SergeyBiryukov.
Fixes #43329.
Built from https://develop.svn.wordpress.org/trunk@42773


git-svn-id: http://core.svn.wordpress.org/trunk@42603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-04 17:14:31 +00:00
Dominik Schilling d950c75307 Import: Avoid counting an uncountable type when reading arguments passed to a script. 
Props josephscott.
Fixes #42898.
Built from https://develop.svn.wordpress.org/trunk@42771


git-svn-id: http://core.svn.wordpress.org/trunk@42601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-02 17:17:31 +00:00
Andrea Fercia d2d64f13c7 Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffeid, audrasjb, afercia.
See #43382, #38677.
Fixes #43376.

Built from https://develop.svn.wordpress.org/trunk@42767


git-svn-id: http://core.svn.wordpress.org/trunk@42597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-28 22:36:34 +00:00
Sergey Biryukov 0e802a627d General: Introduce `WP_Error::has_errors()` method and use it where appropriate. 
Props robdxw, DrewAPicture, SergeyBiryukov.
Fixes #42742.
Built from https://develop.svn.wordpress.org/trunk@42761


git-svn-id: http://core.svn.wordpress.org/trunk@42591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-27 02:31:31 +00:00
Sergey Biryukov 669f8bb750 Media: Remove unnecessary `aria-required` attribute from legacy (pre-3.5.0) media functions, added in [7888]. 
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.

Props shital-patel, afercia, audrasjb.
Fixes #43415.
Built from https://develop.svn.wordpress.org/trunk@42759


git-svn-id: http://core.svn.wordpress.org/trunk@42589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-26 23:10:31 +00:00
Dominik Schilling 666e203f31 Administration: Remove unnecessary capitalization when referencing to plugin/theme editors. 
Fixes #43072.
Built from https://develop.svn.wordpress.org/trunk@42757


git-svn-id: http://core.svn.wordpress.org/trunk@42587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-26 19:35:30 +00:00
Sergey Biryukov a018cdd4e3 Docs: Add missing `@since` entries for functions in `wp-admin/image-edit.php`. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42756


git-svn-id: http://core.svn.wordpress.org/trunk@42586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-26 18:38:31 +00:00
Sergey Biryukov b026fde152 Docs: Remove `@static` notations from property DocBlocks in `wp-admin/*` and `wp-includes/*` classes. 
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.
Built from https://develop.svn.wordpress.org/trunk@42747


git-svn-id: http://core.svn.wordpress.org/trunk@42577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 20:32:30 +00:00
Sergey Biryukov 0fea564b7d Docs: Remove `@static` notations from method DocBlocks in `wp-admin/*` classes. 
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.
Built from https://develop.svn.wordpress.org/trunk@42745


git-svn-id: http://core.svn.wordpress.org/trunk@42575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 20:06:30 +00:00
Adam Silverstein de6906a045 Customizer: in menus, reset results when closing the 'add items' panel. 
Trigger a keyup event when clearing the search field in response to closing the add item panel. The keyup event triggers a search and resets the results. Previously, the search field was cleared while the potentially blank search results were left in place making it impossible to select new menu items.

Props Blair jersyer, aranwer104, afercia.
Fixes #43333.


Built from https://develop.svn.wordpress.org/trunk@42744


git-svn-id: http://core.svn.wordpress.org/trunk@42574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 18:48:29 +00:00
Adam Silverstein 505c2ddb61 Taxonomy: restore TagSearch unit tests and correct deprecated version string. 
Reverts unit test removal, instead changing them to expect the function to be deprecated.
Correct the version the ajax callback was deprecated.

Amends [42614].

Props dlh, ocean90.
Fixes #38922.


Built from https://develop.svn.wordpress.org/trunk@42737


git-svn-id: http://core.svn.wordpress.org/trunk@42567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:28:30 +00:00
Sergey Biryukov fc5617e7fe Administration: Use HTTPS for `dashboard_primary_feed` URL. 
`dashboard_secondary_feed` is already using HTTPS since [29787].

Props iandunn.
Fixes #40416.
Built from https://develop.svn.wordpress.org/trunk@42731


git-svn-id: http://core.svn.wordpress.org/trunk@42561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-24 09:30:33 +00:00
Aaron Jorbin f4f64377b7 Community Events Dashboard: Use wp_list_pluck rather than array_columns 
array_columns is only available in PHP 5.5+

Introduced in [42726]

See: #41112.


Built from https://develop.svn.wordpress.org/trunk@42728


git-svn-id: http://core.svn.wordpress.org/trunk@42558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:27:31 +00:00
Andrea Fercia 54a45f6d77 Accessibility: Change the terms "Quick Edit" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].

Fixes #43382.

Built from https://develop.svn.wordpress.org/trunk@42727


git-svn-id: http://core.svn.wordpress.org/trunk@42557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:04:31 +00:00
Aaron Jorbin 9f8d1ab69d Community Events Dashboard: Always show a WordCamp if one is coming up 
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.

Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Fixes #41112.


Built from https://develop.svn.wordpress.org/trunk@42726


git-svn-id: http://core.svn.wordpress.org/trunk@42556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:01:31 +00:00
Andrea Fercia 4767e7736c Accessibility: Change the posts "Quick Edit" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation. Also,
adds an `aria-expanded` attribute to the button to communicate to assistive
technologies the expanded / collapsed status of the Quick Edit form.

Props Cheffheid, audrasjb, afercia.
Fixes #38677.

Built from https://develop.svn.wordpress.org/trunk@42725


git-svn-id: http://core.svn.wordpress.org/trunk@42555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 22:31:32 +00:00
Sergey Biryukov dcf5eb07de Docs: Correct documentation for Heartbeat filters. 
`$response` parameter is documented as an array or object, but only array is actually supported.

See #42777, #42505.
Built from https://develop.svn.wordpress.org/trunk@42720


git-svn-id: http://core.svn.wordpress.org/trunk@42548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-19 21:46:33 +00:00
Peter Wilson e6ccdf161f General: Further improve error messages following [42648]. 
Props kristastevens, melchoyce.
Fixes #38332 for trunk.


Built from https://develop.svn.wordpress.org/trunk@42719


git-svn-id: http://core.svn.wordpress.org/trunk@42547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-19 02:13:32 +00:00
Konstantin Obenland 3f7a8aac6b Docs: Add filter docs for wp_refresh_nonces 
Props chetan200891, slushman, dlh, netweb.
Fixes #42777.


Built from https://develop.svn.wordpress.org/trunk@42717


git-svn-id: http://core.svn.wordpress.org/trunk@42545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-17 04:42:33 +00:00
atimmer e17e29d4ea Docs: Improve JSDoc for for `wp-admin/js/xfn.js`. 
Props kapteinbluf, igorsch.
Fixes #43204.

Built from https://develop.svn.wordpress.org/trunk@42715


git-svn-id: http://core.svn.wordpress.org/trunk@42543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 13:35:31 +00:00
atimmer 34c6523a0d Docs: Improve JSDoc for `wp-admin/js/user-suggest.js`. 
Amend r42708 by fixing the 80 character wrap around.

Props timhavinga.
See #43270.

Built from https://develop.svn.wordpress.org/trunk@42714


git-svn-id: http://core.svn.wordpress.org/trunk@42542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 13:26:33 +00:00
Sergey Biryukov d9f222f740 Customize: Correct closing tags in `customize_themes_print_templates()`. 
Props johnpgreen, nandorsky.
Fixes #43307.
Built from https://develop.svn.wordpress.org/trunk@42711


git-svn-id: http://core.svn.wordpress.org/trunk@42539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 22:15:32 +00:00
Drew Jaynes 6e665d1f15 Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions. 
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.

Notations been added for the following functions:

* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()

Props janalwin.
Fixes #43254.

Built from https://develop.svn.wordpress.org/trunk@42710


git-svn-id: http://core.svn.wordpress.org/trunk@42538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 16:54:31 +00:00
atimmer 87130f0e20 Docs: Improve JSDoc for `wp-admin/js/user-suggest.js`. 
Props timhavinga.
Fixes #43270.

Built from https://develop.svn.wordpress.org/trunk@42708


git-svn-id: http://core.svn.wordpress.org/trunk@42536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 15:38:31 +00:00
Sergey Biryukov b2411e9e3f Administration: Make sure `wp.updates.addAdminNotice` is displayed after the page header and does not unexpectedly push down "Add New" and other buttons. 
Props shivapoudel.
Fixes #41221.
Built from https://develop.svn.wordpress.org/trunk@42700


git-svn-id: http://core.svn.wordpress.org/trunk@42528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 17:28:30 +00:00
Sergey Biryukov 7a8e4bcb1b Administration: Remove erroneous `transition-delay` values from CSS files. 
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.
Built from https://develop.svn.wordpress.org/trunk@42689


git-svn-id: http://core.svn.wordpress.org/trunk@42517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 12:55:30 +00:00
Sergey Biryukov e97d2c0407 Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed. 
Props dilipbheda.
Fixes #43106. See #16470.
Built from https://develop.svn.wordpress.org/trunk@42688


git-svn-id: http://core.svn.wordpress.org/trunk@42516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 12:23:31 +00:00
Sergey Biryukov 12f854b6e8 Build/Test Tools: Update prefixed CSS properties in `about.css`. 
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.

Props netweb, afercia.
Fixes #43190.
Built from https://develop.svn.wordpress.org/trunk@42687


git-svn-id: http://core.svn.wordpress.org/trunk@42515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 23:47:31 +00:00
Sergey Biryukov 903224cce4 Plugins: Use correct variable name in `install_plugin_information()`. 
Props afragen.
Fixes #43282. See #43192, #29274.
Built from https://develop.svn.wordpress.org/trunk@42686


git-svn-id: http://core.svn.wordpress.org/trunk@42514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 22:08:30 +00:00
Sergey Biryukov b1f48870d7 Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity. 
Props xkon, karmatosed.
Fixes #43072.
Built from https://develop.svn.wordpress.org/trunk@42685


git-svn-id: http://core.svn.wordpress.org/trunk@42513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 08:43:32 +00:00
John Blackbourn ee24b48106 Comments: Add a "Mine" link to the list of filters on the comment listing screen. 
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.

Props Iceable

Fixes #42379

Built from https://develop.svn.wordpress.org/trunk@42684


git-svn-id: http://core.svn.wordpress.org/trunk@42512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 18:46:31 +00:00
John Blackbourn fc6ba86b80 Docs: First pass at switching some array parameter documentation to typed notation. 
Props janak007

See #41756

Built from https://develop.svn.wordpress.org/trunk@42679


git-svn-id: http://core.svn.wordpress.org/trunk@42507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 17:26:31 +00:00
John Blackbourn 91464bce65 Docs: Add missing code formatting to various `@since` entries. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42678


git-svn-id: http://core.svn.wordpress.org/trunk@42506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 16:55:31 +00:00
John Blackbourn 823cac40df Docs: Update the hook docs for `update_bulk_theme_complete_actions`. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42677


git-svn-id: http://core.svn.wordpress.org/trunk@42505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 16:22:45 +00:00
John Blackbourn 332b9844a9 Posts, Post Types: Add a new `add_inline_data` action which allows extra fields to be added to the inline editing fields. 
Props mensmaximus, NathanAtmoz

Fixes #36085

Built from https://develop.svn.wordpress.org/trunk@42676


git-svn-id: http://core.svn.wordpress.org/trunk@42504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 15:55:32 +00:00
Sergey Biryukov b9944def27 Posts, Post Types: Remove extra tabs around `page_attributes_meta_box_template` action in `page_attributes_meta_box()`. 
Props chetan200891.
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42674


git-svn-id: http://core.svn.wordpress.org/trunk@42502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 11:24:32 +00:00
Sergey Biryukov a5958a289b Upgrade/Install: Avoid extra line breaks in a textarea in `wp-admin/setup-config.php`. 
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42672


git-svn-id: http://core.svn.wordpress.org/trunk@42500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:59:00 +00:00
Sergey Biryukov a65ce4e34b Options: Avoid extra tabs in a textarea in `wp-admin/options.php`. 
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42671


git-svn-id: http://core.svn.wordpress.org/trunk@42499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:58:31 +00:00
Sergey Biryukov cceab04984 Comments: Avoid extra tabs in a textarea in `WP_Comments_List_Table::column_comment()`. 
Props chetan200891, jrf.
Fixes #43252.
Built from https://develop.svn.wordpress.org/trunk@42670


git-svn-id: http://core.svn.wordpress.org/trunk@42498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:57:32 +00:00
Peter Wilson 0d39b35c11 General: Replace `Cheatin’ uh?` with friendlier error messages. 
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332.


Built from https://develop.svn.wordpress.org/trunk@42648


git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-05 02:30:34 +00:00
Andrea Fercia 8a664edcab Administration: Make the Screen Options available on small screens. 
Previously, the Screen Options toggle and the related panel content 
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.

Props chetan200891.
Fixes #40985.

Built from https://develop.svn.wordpress.org/trunk@42644


git-svn-id: http://core.svn.wordpress.org/trunk@42473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 16:58:30 +00:00
Sergey Biryukov 430a724a03 Help/About: Correct outdated media icons reference in help text on Edit Post screen. 
Props thrijith, transl8or.
Fixes #42378.
Built from https://develop.svn.wordpress.org/trunk@42643


git-svn-id: http://core.svn.wordpress.org/trunk@42472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:58:30 +00:00
Sergey Biryukov 4951b2897e Media: Remove checkered background for icons in Attachment Details. 
Props BandonRandon.
Fixes #42535. See #41948.
Built from https://develop.svn.wordpress.org/trunk@42642


git-svn-id: http://core.svn.wordpress.org/trunk@42471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:54:31 +00:00
Andrea Fercia a7c89d5761 Administration: CSS coding standards: use double quotes for values that require quotes. 
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.

Built from https://develop.svn.wordpress.org/trunk@42641


git-svn-id: http://core.svn.wordpress.org/trunk@42470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:19:32 +00:00
Sergey Biryukov 2f54a93369 Posts, Post Types: Don't count pending comments in `WP_Posts_List_Table::_display_rows()` if the post type does not support comments. 
Props seanchayes.
Fixes #43212.
Built from https://develop.svn.wordpress.org/trunk@42638


git-svn-id: http://core.svn.wordpress.org/trunk@42467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-02 07:38:32 +00:00
Dion Hulse 1e5629d1f1 Themes: Use `api.wordpress.org/themes/info/1.2/` to query theme information. 
See #43192.

Built from https://develop.svn.wordpress.org/trunk@42632


git-svn-id: http://core.svn.wordpress.org/trunk@42461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-01 05:19:30 +00:00
Dion Hulse 7abfd84c75 Plugins: Use `api.wordpress.org/plugins/info/1.2/` for querying plugins & plugin information. 
See #43192.
Fixes #29274.

Built from https://develop.svn.wordpress.org/trunk@42631


git-svn-id: http://core.svn.wordpress.org/trunk@42460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-01 05:17:33 +00:00
Adam Silverstein 35a20d8f50 Remove unused var after r42614, fixing a jshint error. 
Built from https://develop.svn.wordpress.org/trunk@42618


git-svn-id: http://core.svn.wordpress.org/trunk@42447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-30 00:34:59 +00:00
Adam Silverstein 86434ebca4 Taxonomy: Use REST API for ajax tag search. 
Deprecate wp_ajax_ajax_tag_search and switch to using the REST API when searching tags in the tags meta box.

Props nacin, chriscct7, afercia, swissspidy, jnylen0, rmccue, ryelle.
Fixes #38922.


Built from https://develop.svn.wordpress.org/trunk@42614


git-svn-id: http://core.svn.wordpress.org/trunk@42443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-30 00:17:31 +00:00
Weston Ruter b32df8f64e Customize: Ensure heartbeat keeps changeset locked when in branching mode. 
Props dlh.
See #42024.
Fixes #42658.

Built from https://develop.svn.wordpress.org/trunk@42612


git-svn-id: http://core.svn.wordpress.org/trunk@42441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-29 23:05:31 +00:00
Sergey Biryukov 1cda7b9667 Role/Capability: Make `install_languages` capability check less restrictive. 
A user should still be able to have the capability, even when language packs cannot be automatically installed. The automatic installation part is separate from that now.

Props flixos90.
Fixes #42697.
Built from https://develop.svn.wordpress.org/trunk@42606


git-svn-id: http://core.svn.wordpress.org/trunk@42435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-24 22:42:30 +00:00
Sergey Biryukov ea6f648401 Upgrade/Install: In `postMessage` events handler, check for `message` object existence before checking its `action` property. 
Props manikmist09.
Fixes #43005.
Built from https://develop.svn.wordpress.org/trunk@42604


git-svn-id: http://core.svn.wordpress.org/trunk@42433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-24 22:31:30 +00:00
Andrew Ozz 5878c6c83a Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup. 
Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42574


git-svn-id: http://core.svn.wordpress.org/trunk@42403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 17:34:32 +00:00
Sergey Biryukov d9d841b807 Media: Restore white background of the content area in media modal. 
Props afercia, chetan200891.
Fixes #43088.
Built from https://develop.svn.wordpress.org/trunk@42572


git-svn-id: http://core.svn.wordpress.org/trunk@42401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 14:01:31 +00:00
Sergey Biryukov 9a1066c90e Taxonomy: Don't display an empty edit link in taxonomy list table if the user doesn't have permissions to edit the term. 
Props grapplerulrich.
Fixes #43146.
Built from https://develop.svn.wordpress.org/trunk@42565


git-svn-id: http://core.svn.wordpress.org/trunk@42394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 11:34:31 +00:00
Aaron Jorbin 9efeb545c0 Remove JSHint due to license compatibility 
JSHint inherits a license from JSLint that includes the clause  "The Software shall be used for Good, not Evil." WordPress's license specifically allows grants the freedom to run the program, for any purpose. Please note, this is not an encouragement of evil. Rather than doing something evil, how about learning to love those around you. Instead of tweeting lies and saying people are "Not Good!", help your neighbor. In the words of Lin Manual Miranda, "Love is love is love is love is love is love is love is love, cannot be killed or swept aside." 

This replaces JSHint with esprima, a part of the larger jQuery project, and a custom wrapper for some basic error checking within codemirror.

The existing JSHint configuration is kept in place in case someone wants to use that, but they can only do so for Good.

Fixes #42850
Props netweb for a spelling fix on a comment.


Built from https://develop.svn.wordpress.org/trunk@42547


git-svn-id: http://core.svn.wordpress.org/trunk@42376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-23 01:29:32 +00:00
Weston Ruter 94d178dd31 Customize: Let default status for Customizer be `draft` if user does not have capability to `publish`. 
Amends [41626].
Props sayedwp, westonruter.
See #30937.
Fixes #42686.

Built from https://develop.svn.wordpress.org/trunk@42543


git-svn-id: http://core.svn.wordpress.org/trunk@42372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-22 19:10:34 +00:00
Weston Ruter cd9f48b54f Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes. 
Props flixos90.
See #37661, #42184.
Fixes #42674.

Built from https://develop.svn.wordpress.org/trunk@42536


git-svn-id: http://core.svn.wordpress.org/trunk@42365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-22 06:15:30 +00:00
atimmer d268976255 Docs: Improve JSDoc for `password-strength-meter.js`. 
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066.

Built from https://develop.svn.wordpress.org/trunk@42528


git-svn-id: http://core.svn.wordpress.org/trunk@42357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-18 13:39:33 +00:00
Sergey Biryukov 0eb2581c67 Media: In `_wp_handle_upload()`, check if the file was properly uploaded before checking its size. 
Props achbed, dglingren.
Fixes #39522.
Built from https://develop.svn.wordpress.org/trunk@42525


git-svn-id: http://core.svn.wordpress.org/trunk@42354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-17 07:16:30 +00:00
Weston Ruter 443594dd00 Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar. 
Amends [41352].
See #23120.
Fixes #43003 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42521


git-svn-id: http://core.svn.wordpress.org/trunk@42350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-17 01:24:30 +00:00
Andrea Fercia fc51a83ed8 Plugins: Fix the plugin details modal "Close" button after [42443]. 
Props rinkuyadav999.
Fixes #43082.

Built from https://develop.svn.wordpress.org/trunk@42491


git-svn-id: http://core.svn.wordpress.org/trunk@42320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 17:15:32 +00:00
Dion Hulse 3fe9cb61ee External Libraries: Remove unnecessary / obsoleted MediaElement.js files. 
Props joemcgill.
Fixes #42720 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42462


git-svn-id: http://core.svn.wordpress.org/trunk@42291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 06:28:43 +00:00
Dion Hulse ceaaed6604 Build: Use Node 8.x for trunk. 
Props netweb.
See #35105.

Built from https://develop.svn.wordpress.org/trunk@42461


git-svn-id: http://core.svn.wordpress.org/trunk@42290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 03:58:49 +00:00
Sergey Biryukov bee0136037 Plugins: Update review filter links in Details modal. 
Props darko-a7, afercia.
Fixes #43016. See #meta3379.
Built from https://develop.svn.wordpress.org/trunk@42459


git-svn-id: http://core.svn.wordpress.org/trunk@42288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-16 00:15:46 +00:00
Sergey Biryukov 589395347a Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button. 
`toggleClass()` expects a boolean as a second argument, not an integer.

Props iCaleb.
Fixes #42867.
Built from https://develop.svn.wordpress.org/trunk@42457


git-svn-id: http://core.svn.wordpress.org/trunk@42286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 23:47:47 +00:00
Sergey Biryukov 35653f0432 Media: Bring consistency to `getimagesize()` error suppression. 
Props chasewg, joemcgill, jeremyfelt.
Fixes #42480.
Built from https://develop.svn.wordpress.org/trunk@42449


git-svn-id: http://core.svn.wordpress.org/trunk@42279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 19:44:47 +00:00
Sergey Biryukov 9cb44f5f2f Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer. 
Props chetan200891 for initial patch.
Fixes #42871.
Built from https://develop.svn.wordpress.org/trunk@42447


git-svn-id: http://core.svn.wordpress.org/trunk@42277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-15 19:27:53 +00:00
Andrea Fercia 239da4c1e6 Plugins: Fix the plugin details modal in the install plugin search tab after [41356]. 
Fixes #43082

Built from https://develop.svn.wordpress.org/trunk@42443


git-svn-id: http://core.svn.wordpress.org/trunk@42273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-13 18:53:51 +00:00
Dion Hulse 1d59873ace Upgrade: When deleting old files, if deletion fails attempt to empty the file instead. 
Props joemcgill, dd32.
Fixes #42963 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42433


git-svn-id: http://core.svn.wordpress.org/trunk@42263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-10 06:10:47 +00:00
Andrew Ozz 4a3faae0e8 Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element. 
Props johnschulz, azaozz.

Fixes #43012 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42430


git-svn-id: http://core.svn.wordpress.org/trunk@42260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-08 20:20:53 +00:00
atimmer d1c58e7850 Docs: Improve JSDoc for `js/media-upload.js`. 
Props terwdan, diedeexterkate, andizer, ireneyoast.
Fixes #42956.

Built from https://develop.svn.wordpress.org/trunk@42426


git-svn-id: http://core.svn.wordpress.org/trunk@42257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-01-04 14:37:49 +00:00
Rachel Baker 386a5c397f Comments: Introduce filter for the arguments for the comment query in the comments list table. 
Add `comments_list_table_query_args` filter to the Comments List Table.

Props soulseekah, birgire.
Fixes #42997.
Built from https://develop.svn.wordpress.org/trunk@42420


git-svn-id: http://core.svn.wordpress.org/trunk@42251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-29 18:21:52 +00:00
Dion Hulse 1caa918dbc i18n: Don't use `esc_attr_e()` on a variable. 
Props yoavf.
Fuxes #42935.

Built from https://develop.svn.wordpress.org/trunk@42413


git-svn-id: http://core.svn.wordpress.org/trunk@42244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-20 05:35:50 +00:00
John Blackbourn a5e2908bbd Docs: Improve the function and parameter descriptions for `do_meta_boxes()`. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42412


git-svn-id: http://core.svn.wordpress.org/trunk@42243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-19 15:03:52 +00:00
atimmer f6a37e7d39 Docs: Remove `@summary` tags from JSDoc. 
As decided in the JavaScript core chat. With a few reasons:

* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.

The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.

Props herregroen.
Fixes #42901.

Built from https://develop.svn.wordpress.org/trunk@42411


git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-18 14:14:53 +00:00
John Blackbourn cb53982d1f Media: Pass the attachment ID to the `intermediate_image_sizes_advanced` filter. 
Props drywallbmb, robbie505
Fixes 42745

Built from https://develop.svn.wordpress.org/trunk@42407


git-svn-id: http://core.svn.wordpress.org/trunk@42236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-16 13:47:47 +00:00
Adam Silverstein d82e2b02be Media: improve flows for cropping on attachment details screen. 
On the "Attachment Details" screen:
* The crop button is always 'enabled'.
* Clicking the crop button with no selection selects the entire image.
* Clicking the crop button with the entire image selected doesn't do anything.
* Clicking the crop button with a selection crops as expected.

Props sonjanyc, afercia, mikeschroder.
Fixes #30155.

Built from https://develop.svn.wordpress.org/trunk@42404


git-svn-id: http://core.svn.wordpress.org/trunk@42233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-15 22:03:50 +00:00
atimmer 1f707de9dd Docs: Improve wp-admin JSDoc structural data globally. 
JSDoc takes it structural data from `@namespace`, `@lends` and `@memberOf`. This change fixes these tags for all JavaScript files in the wp-admin folder.

* Add jsdoc configuration to parse wp-admin/js files. Use `jsdoc -c jsdoc.conf.json` to generate JSDoc.
* Define all used namespaces using `@namespace`.
* Define each usage of the extend function as a prototype assignment using `@lends`.
* Add `@alias` if JSDoc cannot detect the correct name automatically.

This has previously been corrected for all `wp-includes` JavaScript files: [41351].

Props herregroen.
Fixes #42485.

Built from https://develop.svn.wordpress.org/trunk@42403


git-svn-id: http://core.svn.wordpress.org/trunk@42232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-15 13:42:46 +00:00
Sergey Biryukov 7c77266b9b Docs: Remove extra dot from some `@since` tags. 
Props hardik-amipara.
Fixes #42899.
Built from https://develop.svn.wordpress.org/trunk@42400


git-svn-id: http://core.svn.wordpress.org/trunk@42229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-15 05:16:47 +00:00
Sergey Biryukov 986e46d2c0 Docs: Add missing `@since` tags for add menu page functions. 
Props keesiemeijer.
Fixes #42882.
Built from https://develop.svn.wordpress.org/trunk@42394


git-svn-id: http://core.svn.wordpress.org/trunk@42223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-15 00:15:52 +00:00
atimmer f544da9b38 Docs: Improve JS Docs for `wp-admin/js/dashboard.js`. 
Props jipmoors, andizer, ireneyoast, boblinthorst.
Fixes #42831.

Built from https://develop.svn.wordpress.org/trunk@42393


git-svn-id: http://core.svn.wordpress.org/trunk@42222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-14 14:11:51 +00:00
atimmer 46cbfc405f Docs: Improve JS Docs for `custom-header.js`. 
The `custom-header.js` file is only used on the `wp-admin/themes.php?page=custom-header` page. As that page is no longer linked from the UI the functions in the file are marked deprecated.

Props nicollle, jipmoors, diedeexterkate.
Fixes #42678.

Built from https://develop.svn.wordpress.org/trunk@42385


git-svn-id: http://core.svn.wordpress.org/trunk@42214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-11 16:27:51 +00:00
Dion Hulse 078b842c60 Docs: Correct some typos in the docs for `wp_ajax_get_community_events()`. 
Props Presskopp.
Fixes #42861.

Built from https://develop.svn.wordpress.org/trunk@42384


git-svn-id: http://core.svn.wordpress.org/trunk@42213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-11 08:49:48 +00:00
Aaron Jorbin 73aca50ff0 CODING STANDARDS: Fix single/double quotation mark 
Broken in [42351].
Unprops adamsilverstein.
Fixes 42679.

Built from https://develop.svn.wordpress.org/trunk@42357


git-svn-id: http://core.svn.wordpress.org/trunk@42186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-03 21:19:48 +00:00
Adam Silverstein 5b4c7c4fab Docs: Improve JSDocs for common.js. 
Props andizer, rensw90, benvaassen, jipmoors, ireneyoast and nicollle.
Fixes 42679.


Built from https://develop.svn.wordpress.org/trunk@42351


git-svn-id: http://core.svn.wordpress.org/trunk@42180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-03 18:12:41 +00:00
Drew Jaynes 36b3f1707c Hooks: Standardize naming of dynamic hooks using values derived from superglobals to use interpolation vs concatenation. 
This is a continuation of the work that happened in [38307] for #37748.

Props ramiy.
Fixes #42698.

Built from https://develop.svn.wordpress.org/trunk@42349


git-svn-id: http://core.svn.wordpress.org/trunk@42178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-12-01 11:36:50 +00:00
Gary Pendergast aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
John Blackbourn eaf1cfdc1f Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring. 
Built from https://develop.svn.wordpress.org/trunk@42258


git-svn-id: http://core.svn.wordpress.org/trunk@42087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-29 15:52:50 +00:00
Sergey Biryukov ca6f54cfce Users: After [42256], remove unnecessary double quotes around `first_name` and `last_name` properties. 
See #42713.
Built from https://develop.svn.wordpress.org/trunk@42257


git-svn-id: http://core.svn.wordpress.org/trunk@42086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-29 15:28:53 +00:00
Dion Hulse 05d60f74ed Users: Display partial names in the user listing tables. 
This allows showing a name when only the first or last name is provided.

Props shital-patel, antipole.
Fixes #42713.

Built from https://develop.svn.wordpress.org/trunk@42256


git-svn-id: http://core.svn.wordpress.org/trunk@42085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-29 03:41:46 +00:00
Gary Pendergast 882db52bdd General: Add inline PHPCS options to leave regex indentation. 
We have a handful of super long regexen that are written over multiple lines, as a collection of strings concatenated together. Each string is indented appropriately for the regex, but PHPCS doesn't recognised this, so defaults to removing the extra whitespace.

Disabling the `Squiz.Strings.ConcatenationSpacing.PaddingFound` rule for these blocks stops the extra whitespace from being removed.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42249


git-svn-id: http://core.svn.wordpress.org/trunk@42078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-28 04:24:57 +00:00
Dion Hulse 58a904e893 Theme Editor: Translate the URL to the Child Themes Codex page. 
Props odysseygate, johnpgreen.
Fixes #42454.

Built from https://develop.svn.wordpress.org/trunk@42247


git-svn-id: http://core.svn.wordpress.org/trunk@42076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:52:47 +00:00
Dion Hulse 271e08a26e Theme Editior: Base the nonce on a simpler combination of fields, for easier debugging & reading. 
See #42609.
Fixes #42705.

Built from https://develop.svn.wordpress.org/trunk@42246


git-svn-id: http://core.svn.wordpress.org/trunk@42075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:44:47 +00:00
Dion Hulse daacc37405 Theme Editor: Validate files are editable based on their relative filenames, rather than full file path. 
This fixes theme editing on Windows platforms where `validate_file()` will return `2` on a full file path.

Fixes #42609.

Built from https://develop.svn.wordpress.org/trunk@42244


git-svn-id: http://core.svn.wordpress.org/trunk@42073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 03:28:48 +00:00
Dion Hulse 28677d382d Theme/Plugin Editor: Remove the caching added in [41806] as it causes more problems than it fixes. 
While caching here seemed like a good idea in theory, in practice the cache would be often stale causing development issues.
We exclude common folders (such as `node_modules`) from the scanning to avoid directories which are not useful to the end-user, so as long as those exclusion lists are held up this shouldn't cause too much of a degredation in the future.
We may consider adding caching here again in the future if it's determined that it is really needed.

Props precies, ibenic, mariovalney, schlessera, and all the others who commented on the ticket(s).
This partually reverts [41806].
See #6531.
Fixes #42573.

Built from https://develop.svn.wordpress.org/trunk@42242


git-svn-id: http://core.svn.wordpress.org/trunk@42071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-27 02:59:47 +00:00
Gary Pendergast c90cfa3b50 General: Fix some precision alignment formatting warnings. 
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-26 23:57:55 +00:00
Dion Hulse 4073743527 Filesystem: Use a more unique filename in `wp_tempnam()` and `get_filesystem_method()`. 
Using a filename which was generated from `time()` could cause two processes to try to use the same filename, causing unexpected behaviour.

Props jrchamp, bikecrazyy.
Fixes #42265.

Built from https://develop.svn.wordpress.org/trunk@42224


git-svn-id: http://core.svn.wordpress.org/trunk@42053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-24 03:05:50 +00:00
Weston Ruter e0b4933fdb Themes: Prevent JS error on Themes admin screen when only one theme is installed. 
Amends [42029].
Props chetan200891, afercia.
See #42348.
Fixes #42673.

Built from https://develop.svn.wordpress.org/trunk@42222


git-svn-id: http://core.svn.wordpress.org/trunk@42051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-23 19:29:46 +00:00
Gary Pendergast 871c6d2b45 Setup: Allow for `wp-config-sample.php` to be formatted according to coding standards. 
When the setup process reads `wp-config-sample.php`, it assumes that there are no spaces inside the brackes of the `define()`s. Unfortunately, this doesn't match our coding standards, so will no longer work correctly once we start enforcing them.

This also improves coding standards of the generated `wp-config.php` file.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42218


git-svn-id: http://core.svn.wordpress.org/trunk@42047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-23 05:23:50 +00:00
Gary Pendergast a779284c00 General: Reformat inline `if ()` statements inside HTML tags. 
This pattern occurs a handful of times across the codebase:

`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`

Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42217


git-svn-id: http://core.svn.wordpress.org/trunk@42046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-23 04:09:49 +00:00
Dion Hulse 27116397c5 Upgrade: Fix updating plugins which include a numeric file/folder names. 
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).

Props edo888.
See #41524.
Fixes #42628 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42214


git-svn-id: http://core.svn.wordpress.org/trunk@42043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-21 04:15:47 +00:00
Boone Gorges 2322b40358 Introduce `meta_box_sanitize_cb` taxonomy argument. 
The `meta_box_cb` argument was introduced in [25572] to allow plugin
authors to provide a custom callback for rendering their taxonomy's meta
box on the post edit screen. However, the routine used to handle the saving
of these custom taxonomy meta boxes was not customizable, but was instead
based simply on whether the taxonomy was hierarchicaly. See [13535].

The new `meta_box_sanitize_cb` argument defaults to the "tag" routine for
non-hierarchical taxonomies and the "category" routine for hierarchical ones,
thereby maintaining the current default behavior. Developers can override this
when the data passed from their `meta_box_cb` differs.

Props boonebgorges, ZaneMatthew, stephenharris.
Fixes #36514.
Built from https://develop.svn.wordpress.org/trunk@42211


git-svn-id: http://core.svn.wordpress.org/trunk@42040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-21 03:15:50 +00:00
Felix Arntz d14a2988e7 Multisite: Fix broken update `blog_versions` query after [41661]. 
Props Mista-Flo, lenasterg.
Fixes #42641.

Built from https://develop.svn.wordpress.org/trunk@42210


git-svn-id: http://core.svn.wordpress.org/trunk@42039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-20 23:46:48 +00:00
Dion Hulse 71bdb1635b DB Repair: Only allow non-falsey values of `WP_ALLOW_REPAIR` to access the DB repair functionality. 
This allows defining the constant as `false` to prevent access (rather than requiring the constant to be removed entirely).

Props tiagohillebrandt, munklefish.
See #11717.
Fixes #42622.

Built from https://develop.svn.wordpress.org/trunk@42205


git-svn-id: http://core.svn.wordpress.org/trunk@42034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-20 06:21:52 +00:00
John Blackbourn 4ef018df2b Docs: Correct the `@since` property for the `page_attributes_misc_attributes` action. 
Props jeremyescott, jfarthing84

Fixes #42607

Built from https://develop.svn.wordpress.org/trunk@42203


git-svn-id: http://core.svn.wordpress.org/trunk@42033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-19 11:52:52 +00:00
Felix Arntz d9e4fc273d Multisite: Do not show edit links in network users table for users that cannot be edited. 
Props ocean90.
Fixes #42552.

Built from https://develop.svn.wordpress.org/trunk@42202


git-svn-id: http://core.svn.wordpress.org/trunk@42032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-17 21:35:51 +00:00
Sergey Biryukov 1a5adcf722 Rewrite Rules: Correct the logic in `extract_from_markers()` after [41928]. 
Props stodorovic.
Fixes #42579. See #39920.
Built from https://develop.svn.wordpress.org/trunk@42199


git-svn-id: http://core.svn.wordpress.org/trunk@42029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-16 13:25:50 +00:00
Weston Ruter 5cab65edab Editor: Disable `wp_keep_scroll_position` in IE11 since buggy; fix `matches` polyfill conflict with ME.js by doing runtime feature detection in context window. 
Props westonruter, SergeyBiryukov, Clorith for testing.
See #41962, #42029.
Fixes #42553 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42191


git-svn-id: http://core.svn.wordpress.org/trunk@42021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 18:59:47 +00:00
Weston Ruter f4e974057e File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes. 
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423.
Fixes #42554 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42189


git-svn-id: http://core.svn.wordpress.org/trunk@42019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 18:29:46 +00:00
Weston Ruter 9fabdfb212 Customize: Prevent themes panel from auto-expanding in IE11. 
In IE11 the `input` event erroneously gets triggered initially without any user input.

Amends [41648].
See #37661.
Fixes #42556 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42187


git-svn-id: http://core.svn.wordpress.org/trunk@42017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-15 18:12:53 +00:00