Commit Graph

32563 Commits

Author SHA1 Message Date
Helen Hou-Sandí 28c77bec72 RIP `#21759b`, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.

Built from https://develop.svn.wordpress.org/trunk@35340


git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Drew Jaynes f954194a1c Comments: Introduce two new filters, `notify_moderator` and `notify_post_author`, both of which make it possible to selectively override site notification email settings for new comments.
The `notify_moderator` filter makes it possible to override the value for the `moderation_notify` option, which controls whether to send new comment emails to "site moderators", that is to say, the owner of the admin email for the site and the post author if they have the ability to modify the comment.

The `notify_post_author` filter likewise makes it possible to override the value for the `comments_notify` option, which controls whether to send new comment emails to the post author. If the post author is the comment author, default behavior is not to send the notification. Note: enabling or disabling notifications via this hook could also affect other recipients added via the 'comment_notification_recipients' filter in `wp_notify_postauthor()`, if hooked.

Passing a falsey value to either of the new filters will prevent notifications from being sent, regardless of their corresponding option values.

Adds tests.

Props coffee2code, adamsilverstein, DrewAPicture.
Fixes #761.

Built from https://develop.svn.wordpress.org/trunk@35339


git-svn-id: http://core.svn.wordpress.org/trunk@35305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:35:31 +00:00
Andrea Fercia 223afd7e04 Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.
Built from https://develop.svn.wordpress.org/trunk@35338


git-svn-id: http://core.svn.wordpress.org/trunk@35304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:34:26 +00:00
Dominik Schilling 253646fcd1 Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.
Built from https://develop.svn.wordpress.org/trunk@35337


git-svn-id: http://core.svn.wordpress.org/trunk@35303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 17:39:25 +00:00
Dominik Schilling 46a115de61 WP Locale: Add a `start_of_week` property to store the start of the week per locale.
Props swissspidy.
See #28344.
Built from https://develop.svn.wordpress.org/trunk@35336


git-svn-id: http://core.svn.wordpress.org/trunk@35302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 17:28:29 +00:00
Aaron Jorbin 5a7bb070da Update grunt-browserify
upstream changes https://github.com/jmreidy/grunt-browserify/compare/v4.0.0...v4.0.1

See #34177

Built from https://develop.svn.wordpress.org/trunk@35335


git-svn-id: http://core.svn.wordpress.org/trunk@35301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:59:25 +00:00
Konstantin Obenland d7bb9d8254 Tests: Use most specific function for document titles.
Adds tests specific to `_wp_render_title_tag()`.

See #31078.


Built from https://develop.svn.wordpress.org/trunk@35334


git-svn-id: http://core.svn.wordpress.org/trunk@35300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:55:25 +00:00
Boone Gorges 9088df3fee Prevent non-public taxonomies from registering aquery var.
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.
Built from https://develop.svn.wordpress.org/trunk@35333


git-svn-id: http://core.svn.wordpress.org/trunk@35299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:54:24 +00:00
Aaron Jorbin 3fcb37a831 Replace Autoprefixer Core with Autoprefixer
Autoprefixer Core 5.2.1 -> Autoprefixer 6.0.3 https://github.com/postcss/autoprefixer/releases/tag/6.0.0
Package autoprefixer-core is deprecated in favour of autoprefixer as part of the 6.0.0 release:
Packages autoprefixer and autoprefixer-core were merged in 6.0 release.
Autoprefixer 6.0.0 requires PostCSS 5.0.10 or greater
PostCSS 0.5.4 -> 0.6.0 https://github.com/nDmitry/grunt-postcss/compare/v0.5.4...v0.6.0

You will need to update your dev dependencies after this change.

Props netweb
See #34177


Built from https://develop.svn.wordpress.org/trunk@35332


git-svn-id: http://core.svn.wordpress.org/trunk@35298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:48:38 +00:00
Boone Gorges 3eab09a694 Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@35331


git-svn-id: http://core.svn.wordpress.org/trunk@35297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:26:42 +00:00
Helen Hou-Sandí 3df1d2abde Media: Update colors to match the times.
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.

Built from https://develop.svn.wordpress.org/trunk@35330


git-svn-id: http://core.svn.wordpress.org/trunk@35296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:18:26 +00:00
Boone Gorges cc0bf494a4 Document title tests should expect dynamic blogname.
Fixes #31078.
Built from https://develop.svn.wordpress.org/trunk@35329


git-svn-id: http://core.svn.wordpress.org/trunk@35295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:15:26 +00:00
Drew Jaynes aef5b20ee3 Docs: Add documentation in the form of a hash notation for default arguments accepted by `wp_login_form()`.
Props ramiy for the initial patch.
Fixes #34364.

Built from https://develop.svn.wordpress.org/trunk@35328


git-svn-id: http://core.svn.wordpress.org/trunk@35294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 15:38:26 +00:00
Helen Hou-Sandí 8803c05db5 `wp_die()`: Update colors and button styling.
see #34388, #31459.

Built from https://develop.svn.wordpress.org/trunk@35327


git-svn-id: http://core.svn.wordpress.org/trunk@35293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 15:23:26 +00:00
Dominik Schilling 4d0759afae List Tables: Replace the hyphen separator for titles and post/media states with a `—`.
Props McGuive7.
Fixes #23230.
Built from https://develop.svn.wordpress.org/trunk@35326


git-svn-id: http://core.svn.wordpress.org/trunk@35292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:33:27 +00:00
Drew Jaynes 81524f3bfc Filesystem: Following the introduction of the `KB|MB|GB|TB_IN_BYTES` constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.

Built from https://develop.svn.wordpress.org/trunk@35325


git-svn-id: http://core.svn.wordpress.org/trunk@35291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:03:25 +00:00
Drew Jaynes 6a51505a23 Docs: Improve the return description in the DocBlock for `rest_send_allow_header()`.
Props danielbachhuber.
Fixes #34374.

Built from https://develop.svn.wordpress.org/trunk@35324


git-svn-id: http://core.svn.wordpress.org/trunk@35290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 13:48:27 +00:00
Sergey Biryukov 116f59af60 REST API: Change nonce name to `_wpnonce`.
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.
Built from https://develop.svn.wordpress.org/trunk@35323


git-svn-id: http://core.svn.wordpress.org/trunk@35289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:14:24 +00:00
Sergey Biryukov da157f16b1 Add `get_terms_defaults` filter for the default arguments of `get_terms()`.
Fixes #33369.
Built from https://develop.svn.wordpress.org/trunk@35322


git-svn-id: http://core.svn.wordpress.org/trunk@35288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:08:25 +00:00
Sergey Biryukov d1dea6e6cf Reorder default arguments in `get_terms()` for consistency with the hash notation added in [29128].
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35321


git-svn-id: http://core.svn.wordpress.org/trunk@35287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:01:25 +00:00
Sergey Biryukov 6b5e523996 Docs: Correct function name in `get_terms_args` parameter description.
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35320


git-svn-id: http://core.svn.wordpress.org/trunk@35286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 07:42:24 +00:00
Sergey Biryukov 1025e22303 Docs: Correct duplicate hook reference for `get_terms`.
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35319


git-svn-id: http://core.svn.wordpress.org/trunk@35285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 07:40:27 +00:00
Andrew Ozz de881c4a97 Precommit cleanup, see r35313.
Built from https://develop.svn.wordpress.org/trunk@35318


git-svn-id: http://core.svn.wordpress.org/trunk@35284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:33:24 +00:00
Andrew Ozz 71ac079074 Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.
Built from https://develop.svn.wordpress.org/trunk@35317


git-svn-id: http://core.svn.wordpress.org/trunk@35283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:23:26 +00:00
Scott Taylor 47879dc83a Export: add missing labels and improvement accessibility of the Export screen.
Props afercia.
Fixes #33046.

Built from https://develop.svn.wordpress.org/trunk@35316


git-svn-id: http://core.svn.wordpress.org/trunk@35282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:57:24 +00:00
Scott Taylor 85d21feca6 Plugins/Updates: in `request_filesystem_credentials()`, alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.

Built from https://develop.svn.wordpress.org/trunk@35315


git-svn-id: http://core.svn.wordpress.org/trunk@35281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:51:24 +00:00
Scott Taylor 8eb3de46c9 Formatting: move `url_shorten()` from `wp-admin/includes/misc.php` to `wp-includes/formatting.php` for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.

Built from https://develop.svn.wordpress.org/trunk@35314


git-svn-id: http://core.svn.wordpress.org/trunk@35280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:48:24 +00:00
Scott Taylor e525ab849d Administration: the current admin menu item should have an `aria-haspopup` attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.

Built from https://develop.svn.wordpress.org/trunk@35313


git-svn-id: http://core.svn.wordpress.org/trunk@35279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:41:24 +00:00
Scott Taylor e6015a31ab Site Icon: make the default value for the `site_icon` option `0` in `schema.php`.
Props swissspidy, sebastian.pisula.
Fixes #34339.

Built from https://develop.svn.wordpress.org/trunk@35312


git-svn-id: http://core.svn.wordpress.org/trunk@35278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:28:25 +00:00
Scott Taylor 97c75b5f07 AJAX UNIT TESTS: Have you ever wondered why these take 600 forevers to run? They all eventually call `do_action( 'admin_init' )`, which has `_maybe_update_core`, `_maybe_update_plugins`, and `_maybe_update_themes` hooked to it. REMOVE THEM, and AJAX unit tests run like the wind. `Tests_Ajax_Response` is still slow.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35311


git-svn-id: http://core.svn.wordpress.org/trunk@35277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:18:25 +00:00
Sergey Biryukov 9fa88a7f27 Autoprefixer for [35281].
See #33322.
Built from https://develop.svn.wordpress.org/trunk@35310


git-svn-id: http://core.svn.wordpress.org/trunk@35276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:02:24 +00:00
Scott Taylor fc850bf274 Unit Tests: consolidate the many separate implementations of `_make_attachment()` into a helper method on `WP_UnitTestCase`.
Fixes #34075.

Built from https://develop.svn.wordpress.org/trunk@35309


git-svn-id: http://core.svn.wordpress.org/trunk@35275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 01:59:26 +00:00
Weston Ruter d7e13544ea Customizer: Prevent `nav_menu_item` settings from becoming dirty when their controls are set up.
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.

Built from https://develop.svn.wordpress.org/trunk@35308


git-svn-id: http://core.svn.wordpress.org/trunk@35274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:45:29 +00:00
Weston Ruter bee05e0cdc Customizer: Introduce `customize_loaded_components` filter to allow core components to be disabled.
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.

Built from https://develop.svn.wordpress.org/trunk@35307


git-svn-id: http://core.svn.wordpress.org/trunk@35273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:16:25 +00:00
Andrew Ozz 3451251548 TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887.
Fixes #34331.
Built from https://develop.svn.wordpress.org/trunk@35306


git-svn-id: http://core.svn.wordpress.org/trunk@35272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:06:24 +00:00
Weston Ruter c77bb38b3d Customizer: Allow new `option` settings to not be saved as autoloaded by passing an `autoload` arg value of `false`.
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].

Props westonruter, dlh.
See #26394.
Fixes #33499.

Built from https://develop.svn.wordpress.org/trunk@35305


git-svn-id: http://core.svn.wordpress.org/trunk@35271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 21:19:25 +00:00
Andrea Fercia 1e1e7a9fc9 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.
Built from https://develop.svn.wordpress.org/trunk@35304


git-svn-id: http://core.svn.wordpress.org/trunk@35270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 20:15:26 +00:00
Drew Jaynes 8549e76d56 Docs: Add translator comments for two `_deprecated_argument()` calls added to `get_wp_title_rss()` and `wp_title_rss()` in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35303


git-svn-id: http://core.svn.wordpress.org/trunk@35269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:20:25 +00:00
Weston Ruter 6d9d18315d Customizer: Implement indicators for invalid nav menu items.
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.

Built from https://develop.svn.wordpress.org/trunk@35302


git-svn-id: http://core.svn.wordpress.org/trunk@35268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:08:25 +00:00
Drew Jaynes 0715dc8a4f Docs: Adjust syntax in the hook doc summaries for the `document_title_separator` and `document_title_parts` filters, introduced in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35301


git-svn-id: http://core.svn.wordpress.org/trunk@35267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:37:54 +00:00
Drew Jaynes 7c538033dd Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in `wp_get_document_title()`.
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35300


git-svn-id: http://core.svn.wordpress.org/trunk@35266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:32:00 +00:00
Konstantin Obenland f6941fddf4 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.


Built from https://develop.svn.wordpress.org/trunk@35299


git-svn-id: http://core.svn.wordpress.org/trunk@35265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:23:44 +00:00
Drew Jaynes 0ea90a9174 Docs: Update the hook doc for the `pre_get_document_title` filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-)
The hook was introduced in [35294].

See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35298


git-svn-id: http://core.svn.wordpress.org/trunk@35264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:14:24 +00:00
Drew Jaynes 0a1026ac10 Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35297


git-svn-id: http://core.svn.wordpress.org/trunk@35263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:10:43 +00:00
Drew Jaynes 08f3a3b226 Docs: Fix up DocBlock syntax for the now-deprecated `wp_title()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35296


git-svn-id: http://core.svn.wordpress.org/trunk@35262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:53:24 +00:00
Konstantin Obenland 788cb75879 Tests: Use updated filter names and oembed title for UT sanity.
See [35294], #31078.

Built from https://develop.svn.wordpress.org/trunk@35295


git-svn-id: http://core.svn.wordpress.org/trunk@35261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:05:25 +00:00
Konstantin Obenland c69e96422b Themes: Improve document title output.
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:21:25 +00:00
Sergey Biryukov b8e250927f In `wp_list_categories()`, rewrite a long condition for clarity.
See #34363.
Built from https://develop.svn.wordpress.org/trunk@35293


git-svn-id: http://core.svn.wordpress.org/trunk@35259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:13:26 +00:00
Sergey Biryukov e0af554638 Tags: Avoid a double trailing space after tags separator in auto-suggest.
Props afercia.
Fixes #33881.
Built from https://develop.svn.wordpress.org/trunk@35292


git-svn-id: http://core.svn.wordpress.org/trunk@35258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:00:30 +00:00
Boone Gorges b285b3002a Correct inline comment in `wp_list_categories()`.
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.
Built from https://develop.svn.wordpress.org/trunk@35291


git-svn-id: http://core.svn.wordpress.org/trunk@35257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 12:55:27 +00:00