Commit Graph

28 Commits

Author SHA1 Message Date
omarreiss bdbaccce37 General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 13:33:24 +00:00
atimmer bde558be2f Docs: Add file doc `@output` annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer f6a37e7d39 Docs: Remove `@summary` tags from JSDoc.
As decided in the JavaScript core chat. With a few reasons:

* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.

The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.

Props herregroen.
Fixes #42901.

Built from https://develop.svn.wordpress.org/trunk@42411


git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
atimmer 1f707de9dd Docs: Improve wp-admin JSDoc structural data globally.
JSDoc takes it structural data from `@namespace`, `@lends` and `@memberOf`. This change fixes these tags for all JavaScript files in the wp-admin folder.

* Add jsdoc configuration to parse wp-admin/js files. Use `jsdoc -c jsdoc.conf.json` to generate JSDoc.
* Define all used namespaces using `@namespace`.
* Define each usage of the extend function as a prototype assignment using `@lends`.
* Add `@alias` if JSDoc cannot detect the correct name automatically.

This has previously been corrected for all `wp-includes` JavaScript files: [41351].

Props herregroen.
Fixes #42485.

Built from https://develop.svn.wordpress.org/trunk@42403


git-svn-id: http://core.svn.wordpress.org/trunk@42232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 13:42:46 +00:00
Peter Wilson 395ff7aebe Docs: Add `wp-admin/js/media.js` documentation.
Props jipmoors, jjcomack, diedeexterkate.
Fixes #41072.

Built from https://develop.svn.wordpress.org/trunk@40915


git-svn-id: http://core.svn.wordpress.org/trunk@40765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 15:37:53 +00:00
Jeremy Felt 6f3f00ea97 Multisite: Change `WP_Network` `id` property to an integer.
For consistency and developer sanity.

Props flixos90.
Fixes #37050.

Built from https://develop.svn.wordpress.org/trunk@37870


git-svn-id: http://core.svn.wordpress.org/trunk@37811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-26 14:26:29 +00:00
Helen Hou-Sandí 3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Helen Hou-Sandí fe47177a65 Media library: Revert [31582], as it introduces navigation difficulties for many users.
see #30333.

Built from https://develop.svn.wordpress.org/trunk@31692


git-svn-id: http://core.svn.wordpress.org/trunk@31673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 21:17:29 +00:00
Scott Taylor 6ffa051689 Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Built from https://develop.svn.wordpress.org/trunk@31690


git-svn-id: http://core.svn.wordpress.org/trunk@31671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 19:44:26 +00:00
Scott Taylor 39dabbb8b1 When viewing media in List mode, auto-submit the form for attachment filters when the value of a `<select>` changes. This makes it behave similar to Grid mode and "feels" more performant, even though it is a full page load.
Fixes #30333.

Built from https://develop.svn.wordpress.org/trunk@31582


git-svn-id: http://core.svn.wordpress.org/trunk@31563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 21:27:25 +00:00
Scott Taylor c5f9a7c26a Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
Fixes #30584.

Built from https://develop.svn.wordpress.org/trunk@31037


git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Sergey Biryukov 7dcabd849a Make sure we're on the media grid page before calling wp.media().
props azaozz.
fixes #29520 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29725


git-svn-id: http://core.svn.wordpress.org/trunk@29499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 10:14:17 +00:00
Dominik Schilling 448422f8ae Media Grid improvements:
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.
Built from https://develop.svn.wordpress.org/trunk@29136


git-svn-id: http://core.svn.wordpress.org/trunk@28920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 16:16:15 +00:00
Helen Hou-Sandí b5ef672c6b Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
props ericlewis, shaunandrews, wonderboymusic.
see #24716.

Built from https://develop.svn.wordpress.org/trunk@28682


git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 22:01:18 +00:00
Andrew Ozz 7121bb490d Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952.
Built from https://develop.svn.wordpress.org/trunk@27403


git-svn-id: http://core.svn.wordpress.org/trunk@27250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 03:54:15 +00:00
Andrew Ozz 19efb78b48 Restyles the modal for attaching media to posts, props avryl, see #26952
Built from https://develop.svn.wordpress.org/trunk@27401


git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-04 23:11:13 +00:00
Andrew Nacin 6292b4c519 Fix JSHint errors in 5 files.
props seanchayes.
fixes #26015, #26020, #26019, #26034, #26022.

Built from https://develop.svn.wordpress.org/trunk@26200


git-svn-id: http://core.svn.wordpress.org/trunk@26108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 05:16:09 +00:00
Andrew Nacin 3da5e3a7fc Fix up the 'Attach' dialog on upload.php.
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.

props lessbloat, helenyhou.
fixes #20164.



git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:50:15 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot 841ef3b24e Compress scripts/styles: 3.4-alpha-20339.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-01 22:58:18 +00:00
ryan 62003eb20f Fix media dialog keyPress handling. Props mdawaffe. fixes #14394
git-svn-id: http://svn.automattic.com/wordpress/trunk@15918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-22 19:23:00 +00:00
ryan 52f05426e0 Allow searching custom post types when attaching media. Props markoheijnen. fixes #13229
git-svn-id: http://svn.automattic.com/wordpress/trunk@14869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-25 02:18:07 +00:00
azaozz d1f60c88f0 Fix pagination on the Unattached tab in the media library, show Attach in the "Attached to" column for orphan attachments
git-svn-id: http://svn.automattic.com/wordpress/trunk@12196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-17 03:08:38 +00:00
azaozz 29f9a48eaa CSS cleanup and fixes
git-svn-id: http://svn.automattic.com/wordpress/trunk@10943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-16 04:41:05 +00:00
azaozz 1c9353ad2e Cleanup js files and prepare for concatenating, move most inline js to files
git-svn-id: http://svn.automattic.com/wordpress/trunk@10348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-12 13:43:17 +00:00
azaozz 7e200d589d Consolidate six more js files
git-svn-id: http://svn.automattic.com/wordpress/trunk@9631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-12 09:35:50 +00:00
ryan b10412eab9 Column hiding for comments. Settings box JS consolidation. Props Viper007Bond. see #7725
git-svn-id: http://svn.automattic.com/wordpress/trunk@8988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-26 01:05:52 +00:00
ryan cb6611d1f0 Column hiding for media library. see #7725
git-svn-id: http://svn.automattic.com/wordpress/trunk@8894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-15 17:53:30 +00:00