Commit Graph

209 Commits

Author SHA1 Message Date
Andrew Nacin cfc20a5f64 Accept nooped plurals in wp_generate_tag_cloud() / wp_tag_cloud().
Renders topic_count_text_callback more or less obsolete. It can still be used, but passing a plural is easier.

fixes #27262. see #7989, #14424.

Built from https://develop.svn.wordpress.org/trunk@27376


git-svn-id: http://core.svn.wordpress.org/trunk@27225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 17:29:15 +00:00
Mark Jaquith fb56a9942b Eliminate some of our last remaining `create_function()` instances
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373


git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 16:21:16 +00:00
John Blackbourn 412ea898c0 Add some missing number i18n in `Walker_Category` and `Walker_CategoryDropdown`. Fixes #22745.
Built from https://develop.svn.wordpress.org/trunk@27329


git-svn-id: http://core.svn.wordpress.org/trunk@27181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 21:48:13 +00:00
Andrew Nacin 08a1d44ba5 Add arguments to the wp_dropdown_cats filter, and docs.
props olivM.
fixes #24103.

Built from https://develop.svn.wordpress.org/trunk@27065


git-svn-id: http://core.svn.wordpress.org/trunk@26938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 05:33:13 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Andrew Nacin 974625d962 wp_list_categories(): Add cat-item-none and cat-item-all classes to the none/all options.
props SergeyBiryukov.
fixes #24428.

Built from https://develop.svn.wordpress.org/trunk@26588


git-svn-id: http://core.svn.wordpress.org/trunk@26478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 20:51:19 +00:00
Andrew Nacin 73ee71a239 3.7 regression from [25119]: Have in_category() return false when the first argument is empty.
Adds unit tests.

props ericlewis.
fixes #25706 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25923


git-svn-id: http://core.svn.wordpress.org/trunk@25882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 02:54:10 +00:00
Scott Taylor 6a5d2f8fb0 Rather than adding a `taxonomy` arg to `get_category()`, convert all uses of `get_category()` in core to `get_term()`. By doing so, we negate the need to call `_make_cat_compat()` in a few places that are only looking for a single property.
Fixes #8722.


Built from https://develop.svn.wordpress.org/trunk@25662


git-svn-id: http://core.svn.wordpress.org/trunk@25578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 19:59:10 +00:00
Drew Jaynes c2111b33bf Inline documentation improvements for `Walker_Category` and `Walker_CategoryDropdown`.
Also covers previously undocumented parameters.

See #23406, #19249.

Built from https://develop.svn.wordpress.org/trunk@25641


git-svn-id: http://core.svn.wordpress.org/trunk@25558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 18:02:10 +00:00
Scott Taylor d24a3940de Make sure the queried object is non-null before accessing its properties.
Props markoheijnen, ryan.
Fixes #21394.


Built from https://develop.svn.wordpress.org/trunk@25310


git-svn-id: http://core.svn.wordpress.org/trunk@25272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 02:28:11 +00:00
Sergey Biryukov 503f867e1d Make in_category() an alias of has_category(). fixes #16718.
Built from https://develop.svn.wordpress.org/trunk@25119


git-svn-id: http://core.svn.wordpress.org/trunk@25099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-24 22:54:10 +00:00
Sergey Biryukov 58c364947f PHPDoc fixes and additions. fixes #24616.
git-svn-id: http://core.svn.wordpress.org/trunk@24490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 12:45:11 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Andrew Nacin 18b07129c9 Pass the tag object instead of just the tag ID to topic_count_text_callback. see [23741]. see #21198.
git-svn-id: http://core.svn.wordpress.org/trunk@23888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 03:55:05 +00:00
Ryan Boren 1638f8f59e Pass tag ID and args array to topic_count_text_callback from wp_generate_tag_cloud().
Props najamelan, toscho
fixes #21198


git-svn-id: http://core.svn.wordpress.org/trunk@23741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:17:55 +00:00
Ryan Boren a2edda4b6a Don't bail from get_the_terms() if the post type is not registed for the taxonomy. This can break back compat when add_post_type_support( 'page', 'post-formats' ) is called but register_taxonomy_for_object_type( 'postr_-format', 'page' ) is not.
Props SergeyBiryukov
fixes #22473


git-svn-id: http://core.svn.wordpress.org/trunk@22722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:31:06 +00:00
Andrew Nacin 3a8a6471e3 Check for WP_Error in get_the_category(). props batmoo. fixes #21155.
git-svn-id: http://core.svn.wordpress.org/trunk@22412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:47:14 +00:00
Ryan Boren 1f9d02abc6 Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:37:43 +00:00
Ryan Boren 70edf4111b Fetch full terms for the post_category and tags_input queries and then wp_list_pluck() the desired fields. Fetching full terms primes the cache and reduces overall queries. Add cache invalidation to wp_set_post_terms(). Props scribu. see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 20:35:56 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
nacin 886ee992be Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.
In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.



git-svn-id: http://core.svn.wordpress.org/trunk@20675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 22:09:55 +00:00
ryan d744cbfb0c Escape term links output in category-template.php functions. Props SergeyBiryukov, solarissmoke, alex-ye. fixes #20106
git-svn-id: http://svn.automattic.com/wordpress/trunk@20656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 21:36:43 +00:00
nacin dd8b4816fb Don't call get_the_category() in get_the_category_list() unless the post type supports categories. props niallkennedy. fixes #19671.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 19:23:57 +00:00
duck_ 6d13f920fd Add $id parameter to get_the_tag_list() for consistency with get_the_(category|term)_list(). Props kawauso. Fixes #20072.
Also remove 'default' value of 0 for $id parameter in generic taxonomy functions
as it is a required parameter, and fix a notice when get_the_terms() is called
when $id = 0 and the $post global is not an object.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-20 10:06:05 +00:00
duck_ a395e06896 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 20:29:33 +00:00
duck_ 0f26dd5fa8 Remove old show_last_update/include_last_update_time/show_date code from category template functions. Props solarissmoke. Fixes #19953.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-15 16:46:01 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
duck_ 65b840b565 Fix mistakes in parameter documentation and add some missing param docs. See #19756.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-06 18:31:43 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan bcc6275b3a Link show_option_all in wp_list_categories() to the posts page if one is set. Props solarissmoke. fixes #18610
git-svn-id: http://svn.automattic.com/wordpress/trunk@19273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 17:24:14 +00:00
nacin 008beac918 Make the sort-by-object-property functions generic. see #14424.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 17:20:34 +00:00
ryan 476b3d9a65 Use _wp_tag_cloud_count_sort_cb instead of an anonymous function. Props ocean90. see #14424
git-svn-id: http://svn.automattic.com/wordpress/trunk@18814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 17:09:04 +00:00
ryan 6665f90911 Fix notice in wp_tag_cloud. Props greuben. fixes #17213
git-svn-id: http://svn.automattic.com/wordpress/trunk@18326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-22 19:37:05 +00:00
nacin 2571545ec0 @since s/3.2/3.2.0/
git-svn-id: http://svn.automattic.com/wordpress/trunk@18268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 04:40:18 +00:00
ryan 4c1c3af0d6 Remove misleading phpdoc. Props mfields. fixes #17558
git-svn-id: http://svn.automattic.com/wordpress/trunk@18081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-31 15:54:48 +00:00
ryan 55c2425b3b Don't allow passing slugs to get_tag_link() and get_category_link(); they are too ambiguous. Restore WP_Error return to get_term_link(). fixes #16521 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-10 21:48:40 +00:00
ryan 6a8ff66305 Return empty strings instead of WP_Errro from get_category_link(), get_term_link(), and get_tag_link() when passed an invalid term. Clarify phpdoc. Props nacin. fixes #16521 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-10 20:17:54 +00:00
ryan 587ea006b5 Translations in title attributes require esc_attr().
git-svn-id: http://svn.automattic.com/wordpress/trunk@17102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-21 17:17:58 +00:00
ryan 3949ce12d0 Pink trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
scribu 244ad8dd17 Re-index categories in get_the_category(). Props greuben. Fixes #15442
git-svn-id: http://svn.automattic.com/wordpress/trunk@16888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-12 20:32:29 +00:00
ryan 0b37bd0b6d Populate post term relationship cache in get_the_terms(). Restores caching lost when we moved away from get_the_category(). see #15407
git-svn-id: http://svn.automattic.com/wordpress/trunk@16487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 17:09:21 +00:00
ryan 7cb2ad6d3a Return false if empty cat passed. Restores old behavior.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 05:06:48 +00:00
nacin b8ce0261df More param fixes, props duck_. see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:12:48 +00:00
nacin 4beb3ab36e get_tag_link and get_category_link can also return WP_Error. fixes #15449.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:10:50 +00:00
nacin d042642802 Properly force variable to an array. props Viper007Bond, fixes #15407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-16 00:19:51 +00:00
nacin 134adb6ec1 Move cast to within array_keys to prevent warning when get_the_terms returns false. see #15407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 15:32:20 +00:00
scribu e56413ae33 Add 'get_the_terms' filter. Props filosofo. Fixes #15410
git-svn-id: http://svn.automattic.com/wordpress/trunk@16342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 14:08:27 +00:00
nacin 7b010efc77 Escape the class arg in wp_list_categories. props hakre, fixes #11514.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 11:06:26 +00:00
westi 435c4c2dbf Revert most of [16332] - renaming and deprecating a commonly used function is silly. Improving it is good. Fixes #15407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 21:53:15 +00:00