Andrew Nacin
12c4b9bae9
Do not unslash variables reset by wp_reset_vars(). Remove variables that have never been used in plugin-editor.php. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 02:01:36 +00:00
Bot (Assets)
123ef6ad57
Compress scripts/styles: 3.6-alpha-23417.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:58:42 +00:00
Mark Jaquith
88f17f77c4
Refactor the Customizer accordion so that it can be used in other locations.
...
fixes #23449 . props lessbloat, aaroncampbell
git-svn-id: http://core.svn.wordpress.org/trunk@23417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:58:04 +00:00
Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Sergey Biryukov
7a77f47f55
Use correct escaping function. fixes #23334 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:52:23 +00:00
Sergey Biryukov
08269aa6b0
Remove unused error string. props pavelevap. fixes #22107 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:36:28 +00:00
Helen Hou-Sandí
767f34de86
Restore the following:
...
* Box shadow for screen options/help tabs focus state.
* Text shadow on the about screen badge to match the text shadow in the graphic itself.
* Border for credits screen gravatars, in place of the previous box shadow.
props nacin. see #23415 .
git-svn-id: http://core.svn.wordpress.org/trunk@23409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 23:50:55 +00:00
Bot (Assets)
b05107c526
Compress scripts/styles: 3.6-alpha-23408.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:58:44 +00:00
Helen Hou-Sandí
32562f25e9
Begin simplifying some of the visual elements in the admin, starting with gradients. White space purposefully not currently altered. props lessbloat, melchoyce, aaroncampbell, sabreuse. see #23415 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:43:48 +00:00
Peter Westwood
f8cc93b62e
Revisions: Pass the whole revision being filtered along with context about which side it is to the _wp_post_revision_field_$field filters.
...
Fixes #19932 props pollett, ethitter.
git-svn-id: http://core.svn.wordpress.org/trunk@23404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 21:42:03 +00:00
Bot (Assets)
7d2eeb5aed
Compress scripts/styles: 3.6-alpha-23400.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 22:58:42 +00:00
Mark Jaquith
c2f837a3b4
Allow Backround Image's "select a file" link to be activated by pressing return on the keyboard.
...
props adamsilverstein. fixes #22606
git-svn-id: http://core.svn.wordpress.org/trunk@23399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:51:19 +00:00
Mark Jaquith
00dbfdf89e
Document the mysterious seventh parameter of add_meta_box().
...
props wonderboymusic, markjaquith. fixes #17515
git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith
ddd1b94184
Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:34:51 +00:00
Mark Jaquith
dab5a6ef7d
Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
...
props adamsilverstein. fixes #23195 and #22933
git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Helen Hou-Sandí
1c816c795b
Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Mark Jaquith
da5c7a7c62
"Lookup" is a noun. "Look up" is the verb form. If you doubt me, you should have lookuped in a dictionary.
...
props johnbillion, SergeyBiryukov. fixes #22386
git-svn-id: http://core.svn.wordpress.org/trunk@23393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:19:04 +00:00
Mark Jaquith
2fb915f860
Display post formats in the posts list table.
...
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.
fixes #16047
git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Bot (Assets)
b1adfbb54a
Compress scripts/styles: 3.6-alpha-23386.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 14:38:03 +00:00
Andrew Ozz
6c41e93fec
Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-03 07:03:27 +00:00
Helen Hou-Sandí
f452214f24
Maintain theme screenshot aspect ratio on the update screen. props cochran. fixes #23164 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 17:02:01 +00:00
Andrew Nacin
55ba72f46e
Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Sergey Biryukov
2967871d34
Return WP_Error from wp_crop_image() if saving has failed. props macbrink. fixes #23325 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:59 +00:00
Andrew Nacin
91e3f2b866
Clean up rendering of the title column in the posts list table. Simplify branching. Use get_userdata() rather than get_user_by( 'id' ). Change string to '%s is currently editing'. see #23312 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:54:06 +00:00
Andrew Ozz
0674bbfa8a
Posts screen: show when a post is "locked", hide the checkbox, Quick Edit and Trash links, props dh-shredder, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:31:06 +00:00
Andrew Ozz
3911ebded5
New icons: make the .icon32 container larger to prevent clipping, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:01:35 +00:00
Andrew Ozz
855e0d8f3a
New icons take one, props empireoflight, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 00:22:40 +00:00
Sergey Biryukov
6cb5f510b8
Select "Attribute all posts to..." radio button automatically when selecting a username from the dropdown. fixes #23224 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 18:43:23 +00:00
Sergey Biryukov
e9eb36face
Only show "There is a pending change of your e-mail..." message on the current user's profile page. fixes #23146 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 01:50:19 +00:00
Andrew Ozz
98bf511b56
Heartbeat API: first run, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-29 06:15:25 +00:00
Helen Hou-Sandí
28f6c5bcf4
Remove the long-broken and questionably useful [more]/[less] toggle for hierarchical taxonomies in Quick/Bulk Edit. Nobody seems to have noticed in the nearly 3 years it's been broken. fixes #23006
...
git-svn-id: http://core.svn.wordpress.org/trunk@23354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 22:36:15 +00:00
Sergey Biryukov
72784ad6c2
Consistently use a helper function instead of directly printing the disabled attribute.
...
Remove an erroneous esc_attr() call.
fixes #23194 .
git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 03:23:01 +00:00
Sergey Biryukov
3e917ac75f
Make sure the post exists before checking its ID. fixes #23026 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:55:06 +00:00
Sergey Biryukov
3d8a1289d2
Add missing inline descriptions.
...
props momo360modena, aaronholbrook.
see #20494 , fixes #23304 .
git-svn-id: http://core.svn.wordpress.org/trunk@23350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:20:47 +00:00
Sergey Biryukov
428e9baba7
Correct return value for WP_Filesystem_Base::gethchmod(). props bananastalktome. fixes #23121 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 01:55:39 +00:00
Sergey Biryukov
2366239798
Prevent an unintended visibility change from "Password protected" to "Public" when updating the post.
...
props thomasvanderbeek. fixes #23065 .
git-svn-id: http://core.svn.wordpress.org/trunk@23338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-23 03:30:04 +00:00
Sergey Biryukov
8e32770793
Define the variable before using it. fixes #23181 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-23 03:00:20 +00:00
Andrew Ozz
50ceba1323
Autop: <samp> is not a block tag, props toscho, fixes #18807
...
git-svn-id: http://core.svn.wordpress.org/trunk@23327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 19:05:21 +00:00
Helen Hou-Sandí
b538d6163f
Make sure .widefat border and background coloring only applies to tables. props MikeHansenMe. fixes #21936 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 14:44:04 +00:00
Mark Jaquith
a24c40fb00
Consistently use $wp_rewrite->index instead of hardcoding "index.php".
...
props wonderboymusic. fixes #7337
git-svn-id: http://core.svn.wordpress.org/trunk@23305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-18 13:44:22 +00:00
Andrew Ozz
b59edea3cb
Main editor: when setting or saving the height, look only at elements that have style="height:..." set. Reset a previously saved erroneous "ed_size" value (over 5000px) to the default height of 360px. Fixes #23042 for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-16 19:10:38 +00:00
Dion Hulse
33d913220b
Core Update: Fix a issue which caused automatic upgrades from 2.7 to 3.5+ to fail. Pre-2.7 WP_Filesystem::wp_content_dir() returned unslashed paths. Introduced in [22227]. See #23177
...
git-svn-id: http://core.svn.wordpress.org/trunk@23297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-11 10:16:45 +00:00
Mark Jaquith
e841b1f3cf
Resolve DOCUMENT_ROOT symlinks and standardize Windows slashing for various paths related to Multisite rewrite rule generation. props SergeyBiryukov, nacin, wpewill. fixes #23104 and #23073 for trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-10 08:08:14 +00:00
Andrew Nacin
1fa8476425
Ensure we wp_die() at the end of an ajax action. see #23055 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-07 03:59:44 +00:00
Andrew Nacin
5d980a8e8e
Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-05 03:50:28 +00:00
Bot (Assets)
d64b1cfa34
Compress scripts/styles: 3.6-alpha-23279.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 22:34:43 +00:00
Andrew Ozz
cc834e52bf
Taxonomy postbox: fix toggling with "Choose from the most used tags" when several postboxes are shown, props SergeyBiryukov, fixes #23112 for trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 20:54:11 +00:00
Peter Westwood
f683fc7677
Tighten our braces. Fixes #23118 props evansolomon.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 10:13:51 +00:00
Bot (Assets)
ed9743d358
Compress scripts/styles: 3.6-alpha-23257.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 22:58:37 +00:00
Dion Hulse
9f6638747d
Upgrade: When upgrading from WordPress 3.5, if an empty twentytwelve theme directory exists, remove it to allow the installation of Twenty Twelve. See #22856 . For trunk
...
git-svn-id: http://core.svn.wordpress.org/trunk@23253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 07:42:16 +00:00