9b8169bd30
Move widget classes to their own files in `wp-includes/widgets`:
...
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded`
See #33413 , #23012 .
Built from https://develop.svn.wordpress.org/trunk@33843
git-svn-id: http://core.svn.wordpress.org/trunk@33811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 13:49:21 +00:00
1413f2edd5
Customizer: Collapse any expanded panel/sections before expanding other panel/sections
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Props celloexpressions, westonruter.
Fixes #33396 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33837
git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:42 +00:00
50d0f8f1ae
`WP_Widget_Pages::widget()` has no reason to set `$comment` and `$comments` globals.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33824
git-svn-id: http://core.svn.wordpress.org/trunk@33792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:31:22 +00:00
b35b167cfc
Improve/update escaping in default widgets:
...
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs
Props welcher.
See #23012 .
Built from https://develop.svn.wordpress.org/trunk@33814
git-svn-id: http://core.svn.wordpress.org/trunk@33782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 05:38:21 +00:00
42f915273d
Improve/update escaping in `WP_Widget_Pages`.
...
Props welcher.
See #23012 .
Built from https://develop.svn.wordpress.org/trunk@33813
git-svn-id: http://core.svn.wordpress.org/trunk@33781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 04:47:22 +00:00
bf9d1485ee
Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown.
...
* Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
* Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
* Send all dirty Customized settings in `update-widget` Ajax request and `preview()` them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
* Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
* Fix an issue with extra space at top immediately after creating new menu.
* Fix doubled `update-widget` Ajax requests when changing select dropdown; prevent initial from being aborted.
* Add missing `wp_get_nav_menus()` hooks to preview Customizer updates/inserts for `nav_menu` settings; includes tests.
* Update `wp_get_nav_menu_object()` to allow a menu object to be passed in (and thus passed through).
Props westonruter, adamsilverstein.
Fixes #32814 .
Built from https://develop.svn.wordpress.org/trunk@33488
git-svn-id: http://core.svn.wordpress.org/trunk@33455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 16:03:24 +00:00
994881d211
Add a label to the content field in the Text Widget for screen readers.
...
Props afercia.
Fixes #32736 .
Built from https://develop.svn.wordpress.org/trunk@32907
git-svn-id: http://core.svn.wordpress.org/trunk@32878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 21:22:26 +00:00
c502a281bb
After [32656], add `@access` annotations to methods that have no doc block in `wp-includes/*`.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32657
git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:37:24 +00:00
19a3aacc94
Add `@static*` annotations where they are missing.
...
Initialize all static vars that are not, most to `null`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32650
git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
19b8ef0c92
`get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32600
git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
4c37f68b79
Fix inline documentation syntax in `wp_xmlrpc_server`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32591
git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
29907e5f8b
Text Widget: Use `!empty()` for checking if the filter setting is set.
...
props westonruter.
fixes #31690 .
Built from https://develop.svn.wordpress.org/trunk@31886
git-svn-id: http://core.svn.wordpress.org/trunk@31865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 17:34:28 +00:00
c6522e3c93
Add missing labels to Archives and Categories dropdown widgets.
...
props joedolson, jlevandowski, DrewAPicture, SergeyBiryukov.
fixes #18650 .
Built from https://develop.svn.wordpress.org/trunk@31520
git-svn-id: http://core.svn.wordpress.org/trunk@31501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 16:32:25 +00:00
7690d9b1aa
Add `'widget_nav_menu_args'` filter for Custom Menu widget arguments.
...
props cyman, DrewAPicture.
fixes #29463 .
Built from https://develop.svn.wordpress.org/trunk@31325
git-svn-id: http://core.svn.wordpress.org/trunk@31306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 02:56:23 +00:00
eff3b8925b
Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter.
...
props floriansimeth for initial patch.
fixes #31024 .
Built from https://develop.svn.wordpress.org/trunk@31241
git-svn-id: http://core.svn.wordpress.org/trunk@31222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:26:24 +00:00
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
e7b465046a
Cross-reference `WP_Comment_Query::query()` as the location for finding information on default arguments for `WP_Comment_Query`.
...
Also updates the return types on `get_comments()` and `get_approved_comments()`, as an integer can also be returned if the `$count` argument is true.
Fixes #30111 .
Built from https://develop.svn.wordpress.org/trunk@30281
git-svn-id: http://core.svn.wordpress.org/trunk@30281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:35:22 +00:00
15a1e0731e
Use proper functions for escaped translations.
...
pros jcastaneda.
fixes #30012 .
Built from https://develop.svn.wordpress.org/trunk@29961
git-svn-id: http://core.svn.wordpress.org/trunk@29708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-18 20:11:18 +00:00
504d4ad5eb
Change the default orderby value in wp_get_nav_menus() to 'name'.
...
props voldemortensen, igmoweb.
fixes #29460 .
Built from https://develop.svn.wordpress.org/trunk@29792
git-svn-id: http://core.svn.wordpress.org/trunk@29564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 15:45:16 +00:00
23905f1616
Remove remaining title attributes from default-widgets.php, with the exception of the one on the link to WordPress.org. fixes #26552 .
...
Built from https://develop.svn.wordpress.org/trunk@29338
git-svn-id: http://core.svn.wordpress.org/trunk@29118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 17:05:16 +00:00
fdd0756e5a
Add a class for get_comment_author_link() in Recent Comments widget.
...
props DrewAPicture, dannydehaan, 5um17.
fixes #27944 .
Built from https://develop.svn.wordpress.org/trunk@29241
git-svn-id: http://core.svn.wordpress.org/trunk@29025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 02:44:14 +00:00
b930c3a6fe
Cleanup `wp_widget_rss_form()` after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
...
Props kovshenin.
Fixes #27881 .
Built from https://develop.svn.wordpress.org/trunk@28787
git-svn-id: http://core.svn.wordpress.org/trunk@28600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-20 17:29:14 +00:00
ecf0e4702f
Don't use a variable variable in `wp_widget_rss_form()`. Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28734
git-svn-id: http://core.svn.wordpress.org/trunk@28548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 16:18:17 +00:00
f4a6632200
Clean up wp_widget_rss_output():
...
* Fix appending […] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.
fixes #28356 .
Built from https://develop.svn.wordpress.org/trunk@28586
git-svn-id: http://core.svn.wordpress.org/trunk@28411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 11:08:14 +00:00
49af14fde0
`WP_Date_Query` was only missing one access modifier.
...
Add access modifier (`public`) to all default widgets' class methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28532
git-svn-id: http://core.svn.wordpress.org/trunk@28358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:30:17 +00:00
fdaea6b7f2
Eliminate use of `extract()` in `wp_widget_rss_form()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28449
git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:38:14 +00:00
6e8e30bb1e
Eliminate use of `extract()` in `wp_widget_rss_output()`.
...
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback).
Every other default arg has a default value of `0`.
`items` is expected to always be passed to this function.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28440
git-svn-id: http://core.svn.wordpress.org/trunk@28267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:42:13 +00:00
157f811a5e
Eliminate use of `extract()` in `WP_Widget_RSS::widget()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28439
git-svn-id: http://core.svn.wordpress.org/trunk@28266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:36:15 +00:00
67c51361d6
Eliminate use of `extract()` in `default-widgets.php`.
...
Props rzen, wonderboymusic.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28433
git-svn-id: http://core.svn.wordpress.org/trunk@28260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 16:33:15 +00:00
a43313fe12
Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
...
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205
git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 00:35:25 +00:00
8c830cef80
Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX
...
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.
fixes #27878 for trunk. props westonruter
Built from https://develop.svn.wordpress.org/trunk@28197
git-svn-id: http://core.svn.wordpress.org/trunk@28027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 20:45:31 +00:00
77beef348d
Recent Posts Widget: Use `ob_end_flush()` instead of `ob_flush()`.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28195
git-svn-id: http://core.svn.wordpress.org/trunk@28025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 19:48:19 +00:00
598907559c
WP_Widget: Introduce `is_preview()` method.
...
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.
`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.
For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279
props westonruter.
fixes #27538 .
Built from https://develop.svn.wordpress.org/trunk@27966
git-svn-id: http://core.svn.wordpress.org/trunk@27796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 18:48:16 +00:00
e6d9f04bcc
Inline documentation for hooks in wp-includes/default-widgets.php.
...
Props janw.oostendorp and kpdesign.
Fixes #25638 .
Built from https://develop.svn.wordpress.org/trunk@27697
git-svn-id: http://core.svn.wordpress.org/trunk@27536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 08:53:14 +00:00
3ffc6dd559
RSS widgets: Omit the title attribute when the summary is shown.
...
Trim the title attribute to ensure whitespace isn't rendered.
props SergeyBiryukov.
fixes #26520 . see #26552 .
Built from https://develop.svn.wordpress.org/trunk@27691
git-svn-id: http://core.svn.wordpress.org/trunk@27530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 21:08:15 +00:00
e1fde8d510
In Recent Posts widget set default number to 5.
...
props afercia.
fixes #27417 .
Built from https://develop.svn.wordpress.org/trunk@27561
git-svn-id: http://core.svn.wordpress.org/trunk@27404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 17:01:14 +00:00
79d274f2f6
Add context and a missing period to widget descriptions. Fixes #26668 . Props pavelevap, Hanni
...
Built from https://develop.svn.wordpress.org/trunk@27412
git-svn-id: http://core.svn.wordpress.org/trunk@27259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 17:26:17 +00:00
0c16c0477b
Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
...
props Ipstenu, markjaquith.
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@27369
git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:27 +00:00
db074f8e65
Widgets: improve the help text on the Widgets screen, props siobhan, props Hanni, fixes #26244 .
...
Built from https://develop.svn.wordpress.org/trunk@26505
git-svn-id: http://core.svn.wordpress.org/trunk@26399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 18:29:09 +00:00
791e807f08
More dash updates.
...
* Shuffle around some pixels.
* Rename some things that weren't caught in [26220].
* Revert default-widgets.php change from [26144].
props lessbloat.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26230
git-svn-id: http://core.svn.wordpress.org/trunk@26137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 22:23:09 +00:00
809b335f7a
Merge the new dashboard design into core.
...
Merges https://github.com/growthdesigner/wp-dash .
props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26144
git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
ce637bdcb3
Remove redundant title attributes.
...
props sabreuse.
see #24766 .
Built from https://develop.svn.wordpress.org/trunk@25675
git-svn-id: http://core.svn.wordpress.org/trunk@25591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 22:51:10 +00:00
569bcc5dad
Use `wp_get_nav_menus()` instead of `get_terms('nav_menu')` in `WP_Nav_Menu_Widget` to preserve use of `wp_get_nav_menus' filter.
...
Props Frank Klein.
Fixes #25263 .
Built from https://develop.svn.wordpress.org/trunk@25332
git-svn-id: http://core.svn.wordpress.org/trunk@25294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 23:30:10 +00:00
05d55a400b
Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250 .
...
Built from https://develop.svn.wordpress.org/trunk@25298
git-svn-id: http://core.svn.wordpress.org/trunk@25261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 18:17:10 +00:00
79fffba674
Flush the cache in Recent Comments widget on edit_comment. props pento, fixes #24779 .
...
Built from https://develop.svn.wordpress.org/trunk@25049
git-svn-id: http://core.svn.wordpress.org/trunk@25036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-17 09:30:09 +00:00
98d6c31f84
Avoid an undefined index notice in WP_Widget_Recent_Posts::update(). props jrf. fixes #24577 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-23 08:20:08 +00:00
633a6fb400
Don't append ellipsis in RSS widget if the entire content is shown. props kovshenin. fixes #21702 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 23:23:05 +00:00
13c93f4dd5
Simplify logic in WP_Widget_Recent_Posts and WP_Widget_Recent_Comments. fixes #23089 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 02:14:23 +00:00
43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
7b62637af7
Add a missing closing tag. fixes #23510 . see #14358 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-19 02:06:21 +00:00
Scott Taylor
Weston Ruter
Drew Jaynes
Dominik Schilling
Sergey Biryukov
Helen Hou-Sandí
Mark Jaquith
Andrew Nacin
John Blackbourn
Andrew Ozz
Ryan Boren