ceaec85751
Press This: Rewrite `WP_Press_This::fetch_source_html()` to utilise the HTTP API better without the need for a local temporary file.
...
This reverts [33061] but keeps it's custom UA string.
See #32864
Built from https://develop.svn.wordpress.org/trunk@33062
git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 12:01:25 +00:00
fc8c36eb97
Press This: Set explicit user agent.
...
props kraftbj.
fixes #32864 .
Built from https://develop.svn.wordpress.org/trunk@33061
git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 11:17:24 +00:00
36de491d68
Don't upgrade global tables to utf8mb4 when `wp_should_upgrade_global_tables()` says not to.
...
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.
See #32154
Built from https://develop.svn.wordpress.org/trunk@33058
git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 05:44:24 +00:00
d651de0dac
Introduce `wp_should_upgrade_global_tables()` to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
...
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk
Built from https://develop.svn.wordpress.org/trunk@33057
git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 04:34:24 +00:00
cbacb92dae
Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
...
This change does the following things
* Allows utf8mb4 for the MySQL extension
* Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
* Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
* Removes upgrade_420() calling as upgrade_430() will perform those changes now instead
The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again.
Props kovshenin, pento, dd32
Fixes #32127 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33055
git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:26:24 +00:00
a4e803fbd4
Use `get_default_comment_status()` globally.
...
Also makes the filter name static and passes the post type for context.
Props valendesigns.
Fixes #31168 .
Built from https://develop.svn.wordpress.org/trunk@33054
git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 22:32:25 +00:00
cd7a40bdc7
Site Icon: Improve responsiveness for small screen devices.
...
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.
Props tyxla for initial patch.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33053
git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:16:24 +00:00
3fb3d2a762
Replace `@returns` with `@return` in PHP docblocks.
...
props kraftbj.
fixes #32865 .
Built from https://develop.svn.wordpress.org/trunk@33052
git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:05:24 +00:00
0d270f67c2
Site Icon: Skip cropping if image has the correct size.
...
Props jipmoors for initial patch.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33051
git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 20:40:25 +00:00
423a1a7ca4
New password change/set UI.
...
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords
see #32589
props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023
git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
ebb6aa1d4a
Split `upgrade_430()` into two so that `split_all_shared_terms()` runs when `upgrade_430_fix_comments()` bails early.
...
See [32814], #30261 , [32364], #32165
Built from https://develop.svn.wordpress.org/trunk@33020
git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 07:35:24 +00:00
8eb7f71e6b
List tables: A better responsive view.
...
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.
Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.
props Michael Arestad, helen.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33016
git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
f18fabc300
Site Icon: Move admin icon filter to its rightful place.
...
The action is unrelated to `WP_Site_Icon` itself.
Props kraftbj.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33011
git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 23:26:25 +00:00
7cc9a4c092
Plugins list table: Sort plugins by `Name` by default so translated plugin names get correctly sorted.
...
props swissspidy.
fixes #32735 .
Built from https://develop.svn.wordpress.org/trunk@33010
git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:31:25 +00:00
86ebc13446
Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`.
...
fixes #32021 .
Built from https://develop.svn.wordpress.org/trunk@33008
git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:32:25 +00:00
38e4211efb
Use existing nomenclature pattern for Site Icon class.
...
Props kraftbj.
Fixes #32834 .
Built from https://develop.svn.wordpress.org/trunk@33001
git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 14:37:27 +00:00
b092defb17
Press This:
...
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706 .
Built from https://develop.svn.wordpress.org/trunk@32999
git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 03:58:27 +00:00
c56a8ae0f7
Introducing Site Icon, favicon management for WordPress.
...
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.
Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@32994
git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 12:58:25 +00:00
83e33a2ca0
List tables: Bring screen reader text for comments column title to media.
...
see #32152 , [31513].
Built from https://develop.svn.wordpress.org/trunk@32991
git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:44:25 +00:00
1525010f74
Deprecate php4 style constructors
...
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).
This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."
Upstream: https://wiki.php.net/rfc/remove_php4_constructors
Props jdgrimes, netweb, jorbin
See #31982
Built from https://develop.svn.wordpress.org/trunk@32990
git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
b26accf35a
List tables: Select All should not be a column header.
...
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.
props afercia, valendesigns.
see #31654 .
Built from https://develop.svn.wordpress.org/trunk@32984
git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 05:46:25 +00:00
275fc220ef
Press This:
...
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32983
git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:59:24 +00:00
7dc1d06e64
Proper heading for admin screens.
...
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.
Props joedolson, afercia.
Fixes #31650 .
Built from https://develop.svn.wordpress.org/trunk@32974
git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
8b1286417e
`ob_get_contents()` followed by `ob_end_clean()` can be replaced by `ob_get_clean()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32965
git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:12:24 +00:00
a0e373ef80
For doc block types, favor `bool` over the few remaining `boolean`s
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32964
git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
642af1f3f4
Some doc blocks should use `bool` instead of `true|false`
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32963
git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:45:24 +00:00
60b8e86b36
In `WP_Filesystem_Base::chdir|chgrp|chmod()` (all mock `abstract` methods), modify `@return` to include `string` so that subclass `@return`s match.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32962
git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:43:24 +00:00
7537240d37
List tables: when post navigation links point to the current page, use `<span>`s and text instead of `<a>`s.
...
Props afercia.
Fixes #32253 .
Built from https://develop.svn.wordpress.org/trunk@32948
git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 20:32:26 +00:00
587c570efa
After [32796], improve the accessibility and markup for instances of `touch_time()`.
...
Props rianrietveld, afercia.
Fixes #31714 .
Built from https://develop.svn.wordpress.org/trunk@32945
git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:30:25 +00:00
7142248743
Press This: better screen reader text for the arrow part of the split button.
...
Props afercia. See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32944
git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:24:25 +00:00
7453d12390
Remove unused code from `WP_Press_This::html()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32939
git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:38:25 +00:00
d9bd43c702
Remove unused code from `WP_MS_Sites_List_Table::display_rows()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32938
git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:36:29 +00:00
d3ee649cb9
Press This: support passing `i` parameter to add an image src.
...
Props stephdau, azaozz. Fixes #32173 .
Built from https://develop.svn.wordpress.org/trunk@32936
git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 03:06:25 +00:00
d4f3428d5f
Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
...
Props afercia. See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32934
git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 01:55:30 +00:00
b5973e92ec
Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
...
Fixes #32150
Props afercia
Built from https://develop.svn.wordpress.org/trunk@32933
git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 00:16:27 +00:00
e9758d4e48
Fix a typo in the DocBlock for `get_plugins()`.
...
Props onnimonni, swissspidy.
Fixes #32758 .
Built from https://develop.svn.wordpress.org/trunk@32927
git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 12:22:27 +00:00
42fbb6568e
WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
...
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548
Built from https://develop.svn.wordpress.org/trunk@32924
git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:52:25 +00:00
8f47efe7dc
WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
...
Props mnelson4 for initial patch.
Fixes #29548
Built from https://develop.svn.wordpress.org/trunk@32923
git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:49:25 +00:00
f8cf80e9b1
Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32921
git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 03:23:27 +00:00
f4109b0c5d
Press This: convert the Preview | Save | Publish buttons to a split button.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32920
git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 02:46:27 +00:00
00de0e6341
In `unregister_setting()`, search for `$option_name` in a segment of `$new_whitelist_options` keyed by `$option_group`.
...
Props nofearinc.
Fixes #26479 .
Built from https://develop.svn.wordpress.org/trunk@32905
git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:51:26 +00:00
b8f49cebee
List table views: fix missing current class for "All" when logged in as an author.
...
Props afercia.
Fixes #32015 .
Built from https://develop.svn.wordpress.org/trunk@32903
git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:39:27 +00:00
5a07e4bba4
Add "Scheduled" to post states.
...
props rclations.
fixes #32131 .
Built from https://develop.svn.wordpress.org/trunk@32902
git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 16:07:26 +00:00
4332d8dfc0
Avoid a PHP notice in `WP_Press_This::get_suggested_content()` after [32828].
...
props kraftbj.
fixes #32751 .
Built from https://develop.svn.wordpress.org/trunk@32901
git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 15:20:28 +00:00
92d67bf395
Use valid markup in `Walker_Nav_Menu_Edit::start_el()` - replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.
...
Props sagarjadhav.
Fixes #31817 .
Built from https://develop.svn.wordpress.org/trunk@32879
git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:22:26 +00:00
032ea5b132
Add access modifier to `WP_Upgrader::clear_destination()`
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32871
git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:53:25 +00:00
86beb35f6d
Use `<button>` instead of `<a>` for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
Built from https://develop.svn.wordpress.org/trunk@32869
git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:42:27 +00:00
cfe78e0e95
Cleanup `(ms-)?admin-filters.php`
...
Props johnjamesjacoby.
Fixes #32529 .
Built from https://develop.svn.wordpress.org/trunk@32865
git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:18:25 +00:00
8593dc3172
When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
...
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921
Built from https://develop.svn.wordpress.org/trunk@32854
git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:49:25 +00:00
a21f890abb
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk
Built from https://develop.svn.wordpress.org/trunk@32852
git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:18:26 +00:00
c1a9c4b7b8
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
Built from https://develop.svn.wordpress.org/trunk@32844
git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
d872f38c31
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
Built from https://develop.svn.wordpress.org/trunk@32842
git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
c9e1e2be9b
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
Built from https://develop.svn.wordpress.org/trunk@32833
git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
bc2630e099
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
Built from https://develop.svn.wordpress.org/trunk@32828
git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
b77a3a33f5
Press This: show error message when the user is attempting to add a category that already exists.
...
Fixes #32339 .
Built from https://develop.svn.wordpress.org/trunk@32827
git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:13:26 +00:00
f62bf61b2c
Bail out of 4.3 term splitting routine when no shared terms are found.
...
Props dd32.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32819
git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 11:40:24 +00:00
290044ef15
Split all shared taxonomy terms on upgrade to 4.3.
...
Dear Shared Terms, Welcome to Splitsville. Population: You.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32814
git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 01:53:26 +00:00
d159cc2272
Media list table: Avoid PHP notices by using the proper variables.
...
Also visually tightens up the row actions.
props tyxla.
fixes #32657 . see #29881 .
Built from https://develop.svn.wordpress.org/trunk@32805
git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
5c6b63d3a6
`if` is a statment, not a function.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32800
git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
a49c192f37
Media list table: Restore row actions.
...
see #29881 , #32657 .
Built from https://develop.svn.wordpress.org/trunk@32798
git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:47:24 +00:00
faf6383ebd
Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
...
Props mordauk. Fixes #31784
Built from https://develop.svn.wordpress.org/trunk@32784
git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 06:26:25 +00:00
c6bb637f89
Updats: Add a filter for the options params for the update being performed.
...
Props nofearinc. Fixes #27754
Built from https://develop.svn.wordpress.org/trunk@32783
git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:35:26 +00:00
b881a541bb
Updates: Remove redundant title tags from update outputs.
...
Props afercia. Fixes #32530
Built from https://develop.svn.wordpress.org/trunk@32781
git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:09:25 +00:00
0eb8bfc464
Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32778
git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:32:27 +00:00
e7f618d86e
Tweak the first post/page content to get with the times.
...
props chriscct7.
fixes #22474 .
Built from https://develop.svn.wordpress.org/trunk@32768
git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:50 +00:00
4348074f3a
In `WP_MS_Users_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32757
git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 17:11:26 +00:00
3855cfbffd
In `WP_MS_Themes_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32756
git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:54:26 +00:00
2bdcc71bc0
In `WP_MS_Sites_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32755
git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:23:25 +00:00
ba8cfcab71
In `WP_Media_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32754
git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
a56576edfe
In `WP_Links_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32753
git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:33:25 +00:00
b8eb353590
In `WP_Posts_List_Table`, move the `<th>` markup out of `->column_cb()`.
...
See #29881 , [32740].
Built from https://develop.svn.wordpress.org/trunk@32752
git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:14:24 +00:00
18827ed337
In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string.
...
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.
This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.
Props afercia, wonderboymusic.
Fixes #32466 .
Built from https://develop.svn.wordpress.org/trunk@32751
git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
da0400e273
In `WP_Posts_List_Table::column_title()`, use `is_post_type_hierarchical()` instead of `$this->hierarchical_display` in the logic to determine whether `the_excerpt()` should be called.
...
Fixes #32187 .
Built from https://develop.svn.wordpress.org/trunk@32749
git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:42:26 +00:00
c11e433858
After [32740], in `WP_Posts_List_Table::single_row()` - `$lock_holder` is checked but unused, so the call to `get_userdata()` is unnecessary.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32742
git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:48:26 +00:00
c1c7a7c14c
After [32740], correct doc block typo.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32741
git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:29:26 +00:00
3f4cadf4aa
Override `->single_row_columns()` in `WP_Posts_List_Table`.
...
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.
This list table class is now easier to subclass.
Props joehoyle, wonderboymusic.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32740
git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:18:24 +00:00
d0aa8e4a6e
In `WP_Terms_List_Table::display_rows_or_placeholder()`:
...
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32739
git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:55:25 +00:00
da4c3d0fe4
In `WP_Posts_List_Table::single_row()`:
...
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32738
git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:50:25 +00:00
4835310a18
In `WP_Media_List_Table::display_rows()`, `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32737
git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:45:25 +00:00
f88b42be94
In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32736
git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:39:25 +00:00
d2a00338f6
Don't loosely compare functions that return `bool` against a literal `bool`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32730
git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
c445d60a00
SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
...
See #32345
Built from https://develop.svn.wordpress.org/trunk@32726
git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 06:31:28 +00:00
cb39d03501
Improve non-visual feedback for list table items without terms.
...
Props karpstrucking, afercia.
Fixes #32150 .
Built from https://develop.svn.wordpress.org/trunk@32725
git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-11 09:28:31 +00:00
c87224eaf6
List tables: Use a class instead of inline styles for hidden columns.
...
fixes #32608 .
Built from https://develop.svn.wordpress.org/trunk@32724
git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
06ebd0a2aa
List tables:
...
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32723
git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:31:25 +00:00
51b5ed9fa4
List tables: Better primary column back-compat.
...
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.
props kovshenin.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32722
git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:59:30 +00:00
3562ac028d
List tables: Consolidate `<td>` output for posts.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32721
git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:01:28 +00:00
ce16fd8dca
More semantic markup for the post formats metabox.
...
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.
Props joedolson, afercia.
Fixes #26160 .
Built from https://develop.svn.wordpress.org/trunk@32720
git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 09:09:25 +00:00
0e76a2c570
Additional improvement to sites list table display
...
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.
See #32434 .
Built from https://develop.svn.wordpress.org/trunk@32719
git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 07:28:26 +00:00
93ff65e677
Improve information displayed in a network's sites list table
...
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.
Props @ocean90.
Fixes #32434 .
Built from https://develop.svn.wordpress.org/trunk@32718
git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
005d937ce2
List tables:
...
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.
props georgestephanis, stephdau.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32717
git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 01:46:27 +00:00
6d56231da3
Sort screen options for meta boxes according to the meta box's priority.
...
Props swissspidy.
Fixes #32582 .
Built from https://develop.svn.wordpress.org/trunk@32707
git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 12:35:26 +00:00
c20edc4df5
Remove title attributes in user list tables.
...
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.
Props afercia.
Fixes #32535 .
Built from https://develop.svn.wordpress.org/trunk@32694
git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 08:40:26 +00:00
5daf12dba4
Text improvements for screen readers in list table paginations.
...
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.
Props afercia, rianrietveld.
Fixes #32028 .
Built from https://develop.svn.wordpress.org/trunk@32693
git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00
0e77b693ac
Nav menus: hide the title attribute field by default for new users and installs.
...
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.
props paulwilde.
fixes #32218 .
Built from https://develop.svn.wordpress.org/trunk@32691
git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:38:25 +00:00
6f6788c4af
Media list view: ensure thumbnails are appropriately sized and constrained.
...
see #29993 .
Built from https://develop.svn.wordpress.org/trunk@32688
git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
40fca44c89
Media: move the thumbnail into the title column in list view.
...
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.
props bradt for the initial patch.
fixes #29993 and #32255 . see #32509 and #32395 .
Built from https://develop.svn.wordpress.org/trunk@32687
git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
2d3a637598
List tables: tighten up primary column handling for plugins and multisite themes.
...
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.
props stephdau.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32686
git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:08:28 +00:00
b3d04247b7
Editor:
...
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949 .
Built from https://develop.svn.wordpress.org/trunk@32677
git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
02192cb53f
Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
...
Props johnbillion, mordauk, valendesigns.
Fixes #19257 .
Built from https://develop.svn.wordpress.org/trunk@32673
git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Dion Hulse
Sergey Biryukov
Konstantin Obenland
Mark Jaquith
Helen Hou-Sandí
Dominik Schilling
Andrew Ozz
Aaron Jorbin
Scott Taylor
John Blackbourn
Drew Jaynes
Boone Gorges
Andrew Nacin
Jeremy Felt