Commit Graph

896 Commits

Author SHA1 Message Date
Ryan Boren 469d1a3099 Escape form action urls with esc_url() rather than esc_attr().
Props SergeyBiryukov
fixes #23266


git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 14:01:25 +00:00
Sergey Biryukov 099c3c6422 Remove unused variable. props DrewAPicture. fixes #23782.
git-svn-id: http://core.svn.wordpress.org/trunk@23710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 16:23:36 +00:00
Mark Jaquith 83bb916b81 Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming.
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion

props DrewAPicture, lessbloat, jkudish. fixes #23450. see #23449

git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 13:16:38 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Andrew Nacin 401e88e387 Ignore protected meta keys in meta_form(). see #18786.
git-svn-id: http://core.svn.wordpress.org/trunk@23534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:51:29 +00:00
Sergey Biryukov b5c34dc411 Fix typo in phpdoc. see #17515.
git-svn-id: http://core.svn.wordpress.org/trunk@23457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-19 23:40:03 +00:00
Sergey Biryukov bc2ff9d342 Deprecate wp_convert_bytes_to_hr() in favor of size_format(). props F J Kaiser. fixes #19067.
git-svn-id: http://core.svn.wordpress.org/trunk@23439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 03:07:56 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Mark Jaquith 00dbfdf89e Document the mysterious seventh parameter of add_meta_box().
props wonderboymusic, markjaquith. fixes #17515

git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith 2fb915f860 Display post formats in the posts list table.
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.

fixes #16047

git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Sergey Biryukov 72784ad6c2 Consistently use a helper function instead of directly printing the disabled attribute.
Remove an erroneous esc_attr() call.

fixes #23194.

git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 03:23:01 +00:00
Sergey Biryukov 3e917ac75f Make sure the post exists before checking its ID. fixes #23026.
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:55:06 +00:00
Ryan Boren d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin fe3ace4f05 Feature pointers:
* Finalize the text for the media pointer. Offer it for translation.
 * Remove the favorites pointer.
fixes #22454.



git-svn-id: http://core.svn.wordpress.org/trunk@22874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 18:58:07 +00:00
Andrew Nacin 67b5e59b68 Two initial feature pointers for WordPress 3.5: plugin favorites and the media dialog. One offered for translation. props nacin, lessbloat, DrewAPicture. see #22454.
git-svn-id: http://core.svn.wordpress.org/trunk@22815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:24:11 +00:00
Andrew Nacin 3da5e3a7fc Fix up the 'Attach' dialog on upload.php.
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.

props lessbloat, helenyhou.
fixes #20164.



git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:50:15 +00:00
Andrew Nacin b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 23:54:03 +00:00
Andrew Ozz cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Ryan Boren 3eabc7db5a Use esc_attr() for attributes. Props johnjamesjacoby. fixes #22327
git-svn-id: http://core.svn.wordpress.org/trunk@22373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 18:04:50 +00:00
Daryl Koopersmith a918ec9135 Refine button styles, notably the gray buttons.
* Crisper edges, fewer outer shadows.
* Higher contrast borders on the gray buttons.
* Separates `button-large` from `button-primary`, and removes the `regular` override class.

props hugobaeta, helenyhou, lessbloat. see #21598.


git-svn-id: http://core.svn.wordpress.org/trunk@22099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-02 23:38:21 +00:00
Ryan Boren 21d38d35d4 Initialize to avoid notice. Props bradyvercher. fixes #22050
git-svn-id: http://core.svn.wordpress.org/trunk@22091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 16:09:16 +00:00
Daryl Koopersmith eb54ac6373 Move wp_max_upload_size and dependencies to wp-includes. props johnjamesjacoby. see #21390, fixes #21867.
git-svn-id: http://core.svn.wordpress.org/trunk@22073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 20:59:57 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin 76bc5c7c21 Better alignment in the ustom fields metabox. props SergeyBiryukov, ocean90, fixes #21847.
git-svn-id: http://core.svn.wordpress.org/trunk@21955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-23 17:42:46 +00:00
Andrew Nacin c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Andrew Nacin 0d43250e2d Move the Cancel button for replying and quick-editing a comment to after the primary update/reply button so tabbing from the comment field takes you to the primary action. see #21340.
git-svn-id: http://core.svn.wordpress.org/trunk@21883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-17 22:13:53 +00:00
Andrew Nacin 7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
Ryan Boren daa6757a9b Check for an empty post in wp_popular_terms_checklist(). _wp_ajax_add_hierarchical_term() doesn't set up global post info. Props SergeyBiryukov. see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 16:45:49 +00:00
Daryl Koopersmith 67894a3407 New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 04:58:34 +00:00
Andrew Nacin aa543734b8 Fix adding and updating from the Custom Fields meta box. Broken in [21205]. props SergeyBiryukov. see #21829 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-07 15:49:20 +00:00
Ryan Boren 999d31c237 Make the callback optional for add_settings_section(). Props lightningspirit. fixes #21630
git-svn-id: http://core.svn.wordpress.org/trunk@21742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 20:55:20 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
Andrew Nacin 3331a345bc Update some code comments from .dev.js to .js. props georgestephanis. see #21633.
git-svn-id: http://core.svn.wordpress.org/trunk@21659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 02:15:57 +00:00
Ryan Boren f56d8278bb Remove return ref from all calls to get_post()
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Ryan Boren 65f5267604 Send Content-Type with charset for iframe_header(). Props SergeyBiryukov, sergey.s.betke@novgaro.ru. fixes #19454
git-svn-id: http://core.svn.wordpress.org/trunk@21538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-17 14:19:03 +00:00
ryan e02ea8023e Remove debug cruft. Props ocean90. fixes #21315
git-svn-id: http://core.svn.wordpress.org/trunk@21349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 15:01:44 +00:00
ryan 91ab52d443 For get_settings_errors(), make sure errors from transient get added to the global variable and not unset when checking for an error of a specific setting. Also always return an array, as noted in the documentation. Props obenland. fixes #20833
git-svn-id: http://core.svn.wordpress.org/trunk@21315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 15:13:46 +00:00
azaozz 34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 00:15:15 +00:00
duck_ ea548d7891 Hide pointers introduced in 3.4 from new users. Fixes #20941.
git-svn-id: http://core.svn.wordpress.org/trunk@21075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-13 17:38:42 +00:00
nacin 08c3cb242a Prevent a scrollbar in the admin caused by padding given to the toolbar. props SergeyBiryukov, ocean90. fixes #19196.
git-svn-id: http://core.svn.wordpress.org/trunk@21025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 22:05:01 +00:00
azaozz c4942fae11 Pointers: fix check for defer_loading, fixes #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 22:50:30 +00:00
azaozz 7729e3742e Pointers: center pointer on Themes screen, fixes #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 16:34:51 +00:00
azaozz 453ab841d0 s/deffer/defer, see #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 07:02:25 +00:00
azaozz b0e634031f Pointers: add arg to pointer options to load at window.loaded (after all images have been loaded and the layout is finalized) and use it on the custom header screen, see #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 06:45:49 +00:00
ryan 2f97993537 Updated text for Customize pointer. Props jane. see #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-23 19:49:14 +00:00
ryan 17f9635a45 Feature pointers for choosing an image from the library on the custom header and background pages. see #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-21 20:34:20 +00:00
ryan e44a0c3930 First pass at 3.4 pointers. Add pointer to the customize link for the current theme on themes.php. Support multiple pointers per page. Props scribu. see #20554
git-svn-id: http://core.svn.wordpress.org/trunk@20774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-11 20:29:08 +00:00
nacin 1963cc8070 Add a filter to wp_terms_checklist() that wraps the function's arguments.
Mainly designed to allow checked_ontop to be turned off.

props husobj.
fixes #20054.



git-svn-id: http://core.svn.wordpress.org/trunk@20710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 01:15:18 +00:00
duck_ 457d2db64b Add some missing documentation and fix a couple of typos. Props roscius. Fixes #19756.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-04 17:32:03 +00:00
azaozz 47feb0640f Revert type="number" for the date/time fields as it introduces UI/styling issues, fixes #20217, see #17863
git-svn-id: http://svn.automattic.com/wordpress/trunk@20217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 19:30:07 +00:00
nacin 8c841df86d Revert type="email" (HTML5) as some browsers that do validation on these fields do not work for IDN domains yet. Core does not support these well either, but server-side validation can at least be dealt with by a plugin. see #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-15 18:09:14 +00:00
azaozz f3b63e4537 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
azaozz 52f321913a Add new comment from post edit screen, partial props: garyc40, see #15527
git-svn-id: http://svn.automattic.com/wordpress/trunk@20164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-09 01:30:11 +00:00
duck_ b7dd19a963 Display menu_order value in quick edit for non-hierarchical post types. Props nikolay.yordanov. Fixes #19911, see #18352.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-15 17:19:59 +00:00
nacin bfeb575df9 Use relative paths for admin-ajax.php to avoid cross-domain issues with IDN domains in IE and Opera. props SergeyBiryukov, fixes #18952.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 16:12:11 +00:00
nacin 72c995441a Allow localized commas to be used as tag separators. see #7897.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 18:06:12 +00:00
nacin cb3b946d8c Initial import of localized CSS, for Chinese and Hebrew. see #19603.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-04 00:54:42 +00:00
nacin dad0c4ed9f Translate the monthnum/month abbreviation construct in the Publish box. see #19598.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-03 00:23:25 +00:00
duck_ cd43f96110 Prevent "Undefined index: settings-updated" notice in settings_errors(). Props garyc40. Fixes #19377.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-13 18:15:55 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
nacin 5372ac002b Fix tabbing for comment reply and edit. see #19727, for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-03 20:18:31 +00:00
nacin 54016f80f2 Add a space.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-03 18:06:03 +00:00
nacin 7bfc537c54 Remove esc_js() as this content now gets json encoded rather than a straight echo. props ocean90. see #19644, for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-03 18:04:56 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
nacin 247dc83ecb Don't show new feature pointers for new installs and users. fixes #19382.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-08 21:55:39 +00:00
nacin 532d1561f4 Allow scratch beta/RC installs to experience pointers. Uncomment this before release. see #19360, #19382.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 16:08:29 +00:00
nacin 31c8813108 Don't show pointers for new users. Works for new installs, too. fixes #19360.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 16:05:59 +00:00
nacin 63b2f4c6e7 Cap checks for pointers. see #19360.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 15:59:55 +00:00
nacin 6e648d2356 Bump final db_version for 3.3, otherwise no new beta installs will see the pointers.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 17:47:26 +00:00
nacin 572dcb6205 Use class_exists() rather than is_admin() as otherwise the unit tests won't work without a WP_ADMIN hack. see #19342.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-25 05:15:28 +00:00
ryan ff358379c9 Move convert_to_screen() back to template.php to avoid fatal errors with plugins and themes that direct include template.php into the front end. Flag this bad behavior with _doing_it_wrong(). Props nacin. fixes #19342
git-svn-id: http://svn.automattic.com/wordpress/trunk@19428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:29:33 +00:00
koopersmith 689dade993 RTL styles for pointers. props helenyhou, fixes #19335.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 18:53:11 +00:00
markjaquith a1fb35ca98 Introduce initial_db_version and leverage it so that pointers only get shown to updated installs, not new 3.3 installs. props nacin. see #18693
git-svn-id: http://svn.automattic.com/wordpress/trunk@19410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 21:50:50 +00:00
nacin 00823b1deb Remove old dismissed pointers as the IDs have changed. Switch to underscores that way we don't need to translate them for method names. Avoid an empty pointer in the array. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 23:04:35 +00:00
koopersmith f00103b488 Add new 3.3 pointer content, encapsulate 3.3 internal pointers in a final class. props ocean90, see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 22:39:48 +00:00
ryan 66388c185e Don't fallback to default post type or taxonomy if given an invalid post type or taxonomy. Use typenow as the canonical post type. Props nacin. see #19131
git-svn-id: http://svn.automattic.com/wordpress/trunk@19321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-17 18:01:08 +00:00
nacin c657c79258 Use REQUEST rather than GET to check the current post status page in _post_states(). Addresses a Quick Edit display issue. fixes #18611.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 03:51:28 +00:00
koopersmith 8740d2c65d New pointer styles. Arrows are currently optimized to point upward. props georgestephanis, chexee. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 10:30:14 +00:00
nacin f6368c50c4 Use get_current_screen() rather than a $current_screen global reference. Remove unused global reference. see #14886.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-23 18:01:33 +00:00
duck_ 424cd58652 Correct @param text ordering to put "Optional." in description, see r19019 and #18958. Also remove empty docblock tag.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 15:53:57 +00:00
nacin 51657715c1 Make $screen argument for add_meta_box() (previously $page) optional. see #18958.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 23:01:55 +00:00
nacin db86ea12d4 Strip out the show_wp_pointer_admin_bar for now. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 21:52:14 +00:00
ryan d0d8eb2aaf Update meta box functions to handle WP_Screen objects and pass objects instead of IDs to them in core files. Allow passing emptiness to get the current screen. see #18958
git-svn-id: http://svn.automattic.com/wordpress/trunk@19013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 21:43:02 +00:00
azaozz e849d3b270 Use IE conditionals when adding the ie8 class, introduce _wp_admin_html_begin(), props scribu, fixes #18966
git-svn-id: http://svn.automattic.com/wordpress/trunk@18982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-17 20:57:32 +00:00
duck_ 6926503ebf Fix notices in wp_iframe() and iframe_header() by referencing $wp_htmltag_class as a global. See r18975 and #18314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-15 10:43:55 +00:00
azaozz 0f2431e25a RTL, IE7 and IE7 RTL fixes, add class="ie8" to the html tag, see #18314
git-svn-id: http://svn.automattic.com/wordpress/trunk@18975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-15 07:33:01 +00:00
koopersmith c47765dedb Simplify pointer API with smarter positioning. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-14 03:33:46 +00:00
nacin 24d7c61eb5 Use AJAX request and usermeta rather than user settings for dismissing admin bar pointers. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-10 23:31:36 +00:00
dd32 5ad995f089 Fix admin_body_class filter for Menu's and Widgets pages, Include the filter in Iframe's. Props SergeyBiryukov & johnbillion. Fixes #18853
git-svn-id: http://svn.automattic.com/wordpress/trunk@18882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 07:09:51 +00:00
azaozz 9e37d9490d Change month dropdown display in date pickers to include month number, fixes #18838
git-svn-id: http://svn.automattic.com/wordpress/trunk@18860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 20:50:08 +00:00
azaozz 7be002d642 Fix unfiltered_html_comment nonce, props nacin, fixes #18319
git-svn-id: http://svn.automattic.com/wordpress/trunk@18852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 00:19:07 +00:00
azaozz d58e337d24 Use WP_Editor when editing or replying to comments, props ocean90, remove vendor specific selectors from editor-buttons.css, fixes #18348, see #17144
git-svn-id: http://svn.automattic.com/wordpress/trunk@18803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-28 21:07:08 +00:00
nacin 49fae8d60b Move WP_Screen and friends (15 functions) into admin/includes/screen.php. see #18690.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 21:32:10 +00:00
nacin 95087c5947 And fix this variable. props ocean90.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 21:15:57 +00:00
nacin 1a70603eb2 Use correct variable. see #18690.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 21:11:46 +00:00
koopersmith d417524b4a Introduce help tabs and WP_Screen. props mbijon, goldenapples, natebedortha, ryan. see #18690.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 21:03:38 +00:00
azaozz ffca93b1f2 Responsive admin improvements for the dashboard, new/write screens and links screens, see #18198
git-svn-id: http://svn.automattic.com/wordpress/trunk@18736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-21 06:16:24 +00:00
duck_ 698957e40e Add post formats to quick edit and bulk edit. Fixes #18083.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-19 17:02:58 +00:00
nacin 5f3f71c0f2 Don't burden translators with a few strings we'll be changing.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-18 21:45:23 +00:00
koopersmith 7efa3a5df8 Add pointers feature, and pointer to admin bar, props nacin for PHP bits, see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-18 21:17:09 +00:00
koopersmith 834dc9ff5e Admin bar UX improvements. First pass, see #18197
git-svn-id: http://svn.automattic.com/wordpress/trunk@18683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-16 05:01:54 +00:00
duck_ c1d1590171 Fix typos in documentation (wp-admin/). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
azaozz 4e323dd08f Improve auto column switching for post.php, see #18198
git-svn-id: http://svn.automattic.com/wordpress/trunk@18607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-25 22:55:39 +00:00
azaozz 18fd646bc3 Auto column switching (post.php only for now), see #18198
git-svn-id: http://svn.automattic.com/wordpress/trunk@18581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-22 19:41:11 +00:00
azaozz 1cdec6ff6e Merge most admin css files, first run, see #18314
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-21 03:46:43 +00:00
azaozz 5256d7951f <!DOCTYPE html> for all, fixes #18202
git-svn-id: http://svn.automattic.com/wordpress/trunk@18460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-22 00:25:41 +00:00
ryan 4ad0954961 Introduce register_meta(), get_metadata_by_mid(), and *_post_meta capabilities. fixes #17850
git-svn-id: http://svn.automattic.com/wordpress/trunk@18445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-20 22:04:35 +00:00
nacin 916a1c943c Don't echo empty <h3>s if we don't pass a section title to add_settings_section(). see #18045.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 20:22:24 +00:00
nacin c774b1b42d Don't push dashboard_browser_nag into 'sorted' in do_meta_boxes. see #17781.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-18 15:05:46 +00:00
nacin e169b152bd Anchor the Browse Happy dashboard widget to the top. Reverts [18295], [18296]. Fixes #17781, #17323.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-15 19:23:35 +00:00
azaozz 626fa3b3d3 Always use curly brackets with foreach, see [18295]
git-svn-id: http://svn.automattic.com/wordpress/trunk@18296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-13 01:03:55 +00:00
azaozz 8416d1c0e0 Make sure the browser nag in shown first on the dashboard no matter what! See #17323
git-svn-id: http://svn.automattic.com/wordpress/trunk@18295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-13 00:24:47 +00:00
azaozz 12dd9113cb Add context to _e('Name'), props valentinas, fixes #16531
git-svn-id: http://svn.automattic.com/wordpress/trunk@18247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 22:13:26 +00:00
ryan 81a5f821fb Sanitize guid on save and display. Sanitize mime type on save. Don't allow changing mime type via edit form handlers. Protect hidden meta.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 23:19:42 +00:00
markjaquith 33aba110ee Prevent the browser-out-of-date dashboard nag from being minimized and hide minimization arrow. props aaroncampbell. fixes #17441. see #17323.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 17:06:04 +00:00
azaozz de88c22a6c Allow plugins to disable screen options with filter, props yoavf, fixes #17187
git-svn-id: http://svn.automattic.com/wordpress/trunk@17884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 03:12:41 +00:00
ryan d55f5b35af Denote images that are headers or backgrounds in the media ui. Props ocean90. fixes #17291
git-svn-id: http://svn.automattic.com/wordpress/trunk@17793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 18:28:31 +00:00
ryan 5fc53472ce Introduce get_screen_icon(). Props aaroncampbell. fixes #15377
git-svn-id: http://svn.automattic.com/wordpress/trunk@17656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 21:51:54 +00:00
nacin adcc961d69 Send an associative array to the display_post_states filter. props greenshady, kawauso, fixes #15421.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-23 18:57:12 +00:00
markjaquith dff3130153 A little escaping paranoia, just to be safe. (Already sanitized, higher up). for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-07 19:11:17 +00:00
ryan 687c69d009 Properly encode the post title. Props koopersmith, nacin. For trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-05 18:26:46 +00:00
markjaquith 7cb71c46d5 Make sure we don't double-add -user or -network suffixes in convert_to_screen(). props SergeyBiryukov. fixes #16348
git-svn-id: http://svn.automattic.com/wordpress/trunk@17356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-24 04:16:55 +00:00
nacin cda05de396 Don't allow the 'Path' column on sites.php to be hidden. see #16322.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-20 22:09:01 +00:00
nacin 37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
markjaquith e5a88166a9 Append -network or -user suffix in convert_to_screen(). props kawauso. fixes #16238
git-svn-id: http://svn.automattic.com/wordpress/trunk@17318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 05:38:44 +00:00
westi 035b3fb22a Switch _admin_search_query to use $_REQUEST so as to work for no-js searches sent over POST as well as url based searches over GET. See #14927
git-svn-id: http://svn.automattic.com/wordpress/trunk@17309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 03:40:52 +00:00
nacin 7a38616d0f Hide the many extraneous meta boxes for pages by default too. see #14212.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-14 01:02:15 +00:00
ryan 85f1feed84 Bring out the shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-06 04:11:14 +00:00
nacin a18f529d6e Small visual improvements to post formats on edit.php. see #16047.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-31 04:49:27 +00:00
ryan 476e468faf Fix comment reply colspan. Props garyc40. fixes #15876
git-svn-id: http://svn.automattic.com/wordpress/trunk@17124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-23 17:21:29 +00:00
ryan 587ea006b5 Translations in title attributes require esc_attr().
git-svn-id: http://svn.automattic.com/wordpress/trunk@17102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-21 17:17:58 +00:00
ryan edd8ffdb68 Consistently use edit_posts_per_page. Props sorich87. fixes #14135
git-svn-id: http://svn.automattic.com/wordpress/trunk@17082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 16:18:13 +00:00
westi 08576ca317 Give the screen options Apply button an id so it validates.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 21:08:37 +00:00
nacin 6f607d4046 Revert [16645]. see #15625.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 18:50:39 +00:00
scribu 87c95d40f8 Limit height only to iframe body. Fixes #15679
git-svn-id: http://svn.automattic.com/wordpress/trunk@16937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 10:39:50 +00:00
ryan 3949ce12d0 Pink trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
dd32 4d74379c6b Add missing global for r16881 See #15781
git-svn-id: http://svn.automattic.com/wordpress/trunk@16882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-12 06:40:52 +00:00
dd32 3615a69edd Include Javascript Global variables in iframe_header(); Add extra style/script actions which are missing from iframe_header() to bring it inline with admin-header.php. Fixes #15781
git-svn-id: http://svn.automattic.com/wordpress/trunk@16881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-12 05:43:35 +00:00
markjaquith 7aa5cb911e Backwards compat for plugin use of updated=1. fixes #15660
git-svn-id: http://svn.automattic.com/wordpress/trunk@16706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 10:59:20 +00:00
scribu ecb7457627 Fix compression test 404. Props duck_. Fixes #15496
git-svn-id: http://svn.automattic.com/wordpress/trunk@16689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 14:15:25 +00:00
ryan 3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
westi e8471af340 Don't show the Post Format if the current theme doesn't support them. Fixes #15625.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 12:31:27 +00:00
markjaquith 02e9501c47 Do not double up on id attribute for submit_button() if id is provided in other attributes param. props duck_. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-24 16:30:40 +00:00
nacin b306f9f9c6 Indent a foreach.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-20 19:20:32 +00:00
ryan 847499e531 Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 18:47:34 +00:00
markjaquith 6482610f9a esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: http://svn.automattic.com/wordpress/trunk@16431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:12:01 +00:00
scribu b4674ec053 Remove drag_drop_help() and plugins_search_help(). Fixes #15451
git-svn-id: http://svn.automattic.com/wordpress/trunk@16426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 16:41:26 +00:00