f88b42be94
In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32736
git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:39:25 +00:00
d2a00338f6
Don't loosely compare functions that return `bool` against a literal `bool`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32730
git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
c445d60a00
SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
...
See #32345
Built from https://develop.svn.wordpress.org/trunk@32726
git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 06:31:28 +00:00
cb39d03501
Improve non-visual feedback for list table items without terms.
...
Props karpstrucking, afercia.
Fixes #32150 .
Built from https://develop.svn.wordpress.org/trunk@32725
git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-11 09:28:31 +00:00
c87224eaf6
List tables: Use a class instead of inline styles for hidden columns.
...
fixes #32608 .
Built from https://develop.svn.wordpress.org/trunk@32724
git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
06ebd0a2aa
List tables:
...
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32723
git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:31:25 +00:00
51b5ed9fa4
List tables: Better primary column back-compat.
...
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.
props kovshenin.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32722
git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:59:30 +00:00
3562ac028d
List tables: Consolidate `<td>` output for posts.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32721
git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:01:28 +00:00
ce16fd8dca
More semantic markup for the post formats metabox.
...
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.
Props joedolson, afercia.
Fixes #26160 .
Built from https://develop.svn.wordpress.org/trunk@32720
git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 09:09:25 +00:00
0e76a2c570
Additional improvement to sites list table display
...
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.
See #32434 .
Built from https://develop.svn.wordpress.org/trunk@32719
git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 07:28:26 +00:00
93ff65e677
Improve information displayed in a network's sites list table
...
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.
Props @ocean90.
Fixes #32434 .
Built from https://develop.svn.wordpress.org/trunk@32718
git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
005d937ce2
List tables:
...
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.
props georgestephanis, stephdau.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32717
git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 01:46:27 +00:00
6d56231da3
Sort screen options for meta boxes according to the meta box's priority.
...
Props swissspidy.
Fixes #32582 .
Built from https://develop.svn.wordpress.org/trunk@32707
git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 12:35:26 +00:00
c20edc4df5
Remove title attributes in user list tables.
...
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.
Props afercia.
Fixes #32535 .
Built from https://develop.svn.wordpress.org/trunk@32694
git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 08:40:26 +00:00
5daf12dba4
Text improvements for screen readers in list table paginations.
...
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.
Props afercia, rianrietveld.
Fixes #32028 .
Built from https://develop.svn.wordpress.org/trunk@32693
git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00
0e77b693ac
Nav menus: hide the title attribute field by default for new users and installs.
...
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.
props paulwilde.
fixes #32218 .
Built from https://develop.svn.wordpress.org/trunk@32691
git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:38:25 +00:00
6f6788c4af
Media list view: ensure thumbnails are appropriately sized and constrained.
...
see #29993 .
Built from https://develop.svn.wordpress.org/trunk@32688
git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
40fca44c89
Media: move the thumbnail into the title column in list view.
...
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.
props bradt for the initial patch.
fixes #29993 and #32255 . see #32509 and #32395 .
Built from https://develop.svn.wordpress.org/trunk@32687
git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
2d3a637598
List tables: tighten up primary column handling for plugins and multisite themes.
...
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.
props stephdau.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32686
git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:08:28 +00:00
b3d04247b7
Editor:
...
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949 .
Built from https://develop.svn.wordpress.org/trunk@32677
git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
02192cb53f
Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
...
Props johnbillion, mordauk, valendesigns.
Fixes #19257 .
Built from https://develop.svn.wordpress.org/trunk@32673
git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
42d51a4f89
Add doc blocks to functions that are missing them.
...
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32672
git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 03:18:25 +00:00
9cb1017b3c
Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
...
See #32529 .
Built from https://develop.svn.wordpress.org/trunk@32671
git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 02:00:26 +00:00
0df0e0bf36
Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_Users_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32670
git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:45:27 +00:00
65f31bc52e
Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Terms_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32669
git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:44:26 +00:00
a69f867738
Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Posts_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32668
git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:42:25 +00:00
5e2983a77e
Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Plugins_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32667
git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:40:29 +00:00
d7428fc35d
Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Users_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32666
git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:38:26 +00:00
5e84c7004d
Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_MS_Themes_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32665
git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:36:27 +00:00
88569734d8
Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Sites_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32664
git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:34:25 +00:00
42afe1d373
Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Media_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32663
git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:32:26 +00:00
8bcf53cc68
Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for `WP_List_Table`.
...
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32662
git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:29:26 +00:00
2a0048b1fb
Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Links_List_Table`.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32661
git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:23:26 +00:00
5457eb4933
Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32660
git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:18:26 +00:00
6a08b00632
Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32656
git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
b3e0cfd25d
Add (more) missing doc blocks to `wp-admin/includes/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32655
git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
c6a4512b1b
Add missing doc blocks to `wp-admin/includes/*`.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32654
git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
a51dfa3971
In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`:
...
`admin-filters.php`
`ms-admin-filters.php`
There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.
See #32529 .
Built from https://develop.svn.wordpress.org/trunk@32653
git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
9a29d8ac7b
Add missing` annotations to `ajax-actions.php`
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32652
git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 16:01:27 +00:00
f5646cd9e5
Define a primary column for `WP_Post_Comments_List_Table`.
...
props boonebgorges.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32651
git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:52:25 +00:00
19a3aacc94
Add `@static*` annotations where they are missing.
...
Initialize all static vars that are not, most to `null`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32650
git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
4c0c7fd7ba
List tables: introduce the concept of a "primary" column.
...
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.
props stephdau, DaveAl, jesin.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32644
git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:41:25 +00:00
282e28ad81
Add `@global` annotations to (the rest of the?) `wp-admin/*` files.
...
Does not include list table file changes.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32643
git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:06:31 +00:00
b56b9b3e5c
Add `@global` annotations for `wp-admin/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
a5c688e817
Use site objects rather than get_blog_status() in MS list tables.
...
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.
Fixes #32512 .
Built from https://develop.svn.wordpress.org/trunk@32630
git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 23:14:29 +00:00
19b8ef0c92
`get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32600
git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
4c37f68b79
Fix inline documentation syntax in `wp_xmlrpc_server`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32591
git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
af7a017f46
When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32545
git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
a69b8b3b91
In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32517
git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
5a3dc2a371
In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32516
git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:46:25 +00:00
2ba7f3da75
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
Built from https://develop.svn.wordpress.org/trunk@32504
git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 06:58:27 +00:00
f9e1c18698
List Table: Add placeholder to a plural string.
...
props SergeyBiryukov.
fixes #32034 .
Built from https://develop.svn.wordpress.org/trunk@32473
git-svn-id: http://core.svn.wordpress.org/trunk@32443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:22:24 +00:00
5268a77a80
Sites List Table: Replace context with a translators comment for the site name and tagline.
...
props ramiy.
fixes #31849 .
Built from https://develop.svn.wordpress.org/trunk@32472
git-svn-id: http://core.svn.wordpress.org/trunk@32442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:18:27 +00:00
c37bdc3c9e
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
Built from https://develop.svn.wordpress.org/trunk@32471
git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 18:27:26 +00:00
02621f2a14
Upgrades: If a table has already been converted to `utf8mb4`, there's no need to try and convert it again.
...
Props gabrielperezs for the initial patch.
See #32310 .
Built from https://develop.svn.wordpress.org/trunk@32456
git-svn-id: http://core.svn.wordpress.org/trunk@32426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 12:22:25 +00:00
a3807c1d34
Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
...
Props jorbin, et alii.
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32440
git-svn-id: http://core.svn.wordpress.org/trunk@32410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-07 01:11:29 +00:00
26c3c6d9cb
Upgrade: `$wpdb->get_col_length()` sanity check: bail on unexpected return value.
...
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32429
git-svn-id: http://core.svn.wordpress.org/trunk@32399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 23:11:26 +00:00
0640526e72
Upgrade: Ensure unintelligible DB schemas don't result in content loss.
...
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32417
git-svn-id: http://core.svn.wordpress.org/trunk@32387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 21:46:26 +00:00
2d189ef812
When upgrading WordPress remove genericons example.html files
...
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin
--This line,build.wordpress-develop.dea and those below, will be ignored--
M src/wp-admin/includes/update-core.php
Built from https://develop.svn.wordpress.org/trunk@32385
git-svn-id: http://core.svn.wordpress.org/trunk@32355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 18:37:25 +00:00
77572cf024
Multisite: Add translator comments to default email messages with non-typical placeholders.
...
props yoavf.
fixes #32263 .
Built from https://develop.svn.wordpress.org/trunk@32381
git-svn-id: http://core.svn.wordpress.org/trunk@32351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 09:12:25 +00:00
4e615fb9ff
Fix an incorrect version number check in [32378].
...
See #32099 .
Built from https://develop.svn.wordpress.org/trunk@32379
git-svn-id: http://core.svn.wordpress.org/trunk@32349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:41:24 +00:00
3a6e79c409
Upgrades: When converting to `utf8mb4`, we were trying to change the wrong index on `wp_signups`, causing the conversion to later fail.
...
Props kovshenin, pento.
See #32099 .
Built from https://develop.svn.wordpress.org/trunk@32378
git-svn-id: http://core.svn.wordpress.org/trunk@32348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:34:24 +00:00
364886a5be
WPDB: When checking that a string can be sent to MySQL, we shouldn't use `mb_convert_encoding()`, as it behaves differently to MySQL's character encoding conversion.
...
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32364
git-svn-id: http://core.svn.wordpress.org/trunk@32335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 03:00:25 +00:00
a452927c39
Fix documentation syntax and formatting for the `media_sideload_image()` DocBlock.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32352
git-svn-id: http://core.svn.wordpress.org/trunk@32323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:20:25 +00:00
cbd07f213d
Add two changelog entries for functional changes introduced in 4.2.0.
...
Props dimadin.
See #31925 .
Built from https://develop.svn.wordpress.org/trunk@32350
git-svn-id: http://core.svn.wordpress.org/trunk@32321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:16:25 +00:00
08e3572b7c
Add a missing DocBlock for `wp_caption_input_textarea()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32341
git-svn-id: http://core.svn.wordpress.org/trunk@32312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:13:25 +00:00
e7e93f50cf
Add a missing `@return` tag to the DocBlock for `uninstall_plugin().
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32340
git-svn-id: http://core.svn.wordpress.org/trunk@32311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:08:27 +00:00
87e149a19f
Add a missing `@return` tag to the DocBlock for `site_admin_notice()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32339
git-svn-id: http://core.svn.wordpress.org/trunk@32310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:06:25 +00:00
cdbecf201b
Clarify accepted types for the `$args` and `$context` parameters in `WP_Filesystem()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32338
git-svn-id: http://core.svn.wordpress.org/trunk@32309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:04:25 +00:00
ed0da72d97
Replace `echo __()` with `_e()`.
...
props marsjaninzmarsa.
fixes #32239 .
Built from https://develop.svn.wordpress.org/trunk@32333
git-svn-id: http://core.svn.wordpress.org/trunk@32304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 16:18:28 +00:00
2807b7146f
After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
...
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
See #31139 .
Built from https://develop.svn.wordpress.org/trunk@32330
git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 21:40:25 +00:00
aaafb3113a
Bulk Edit: Properly associate the Format select with its label.
...
props afercia.
fixes #32210 .
Built from https://develop.svn.wordpress.org/trunk@32329
git-svn-id: http://core.svn.wordpress.org/trunk@32300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 16:04:24 +00:00
610e34c215
When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop.
...
Props hnle, taka2. Fixes #32135 . See #31811
Built from https://develop.svn.wordpress.org/trunk@32322
git-svn-id: http://core.svn.wordpress.org/trunk@32293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-29 03:17:31 +00:00
44b56d9393
When deleting suspicious comments, do so permanently.
...
Built from https://develop.svn.wordpress.org/trunk@32310
git-svn-id: http://core.svn.wordpress.org/trunk@32281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:11:26 +00:00
b89fc65951
[32308] was for 4.3, not 4.2.1.
...
Built from https://develop.svn.wordpress.org/trunk@32309
git-svn-id: http://core.svn.wordpress.org/trunk@32280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:08:27 +00:00
51402dc520
When upgrading to 4.2.1, delete suspicious comments.
...
Built from https://develop.svn.wordpress.org/trunk@32308
git-svn-id: http://core.svn.wordpress.org/trunk@32279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:04:25 +00:00
89e45feb4c
Don't focus input fields outside of the request filesystem credentials form.
...
props valendesigns.
fixes #32055 .
Built from https://develop.svn.wordpress.org/trunk@32266
git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:24:26 +00:00
e0657e6904
Don't return empty themes in `wp_prepare_themes_for_js()`.
...
see #32002 .
Built from https://develop.svn.wordpress.org/trunk@32264
git-svn-id: http://core.svn.wordpress.org/trunk@32235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:11:25 +00:00
60706015e1
Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
...
Props iseulde. Fixes #31139 , fixes #32006 .
Built from https://develop.svn.wordpress.org/trunk@32258
git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
1d1c026e8e
Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`.
...
props DrewAPicture.
fixes #31789 .
Built from https://develop.svn.wordpress.org/trunk@32246
git-svn-id: http://core.svn.wordpress.org/trunk@32217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:23:27 +00:00
e3f1f8fed1
Ensure post titles are correctly escaped on the Dashboard.
...
Props helen, ocean90, dd32, pento.
Built from https://develop.svn.wordpress.org/trunk@32175
git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
7f48138743
Press This: Update documentation for `press_this_save_redirect` filter after [31992].
...
props kraftbj.
fixes #31996 .
Built from https://develop.svn.wordpress.org/trunk@32143
git-svn-id: http://core.svn.wordpress.org/trunk@32123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-19 01:34:28 +00:00
786bce5b9c
Customizer: Escape theme preview URLs.
...
props johnbillion, ocean90.
see #31896 .
Built from https://develop.svn.wordpress.org/trunk@32134
git-svn-id: http://core.svn.wordpress.org/trunk@32113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 16:33:25 +00:00
5e4616039c
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
Built from https://develop.svn.wordpress.org/trunk@32125
git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
fe150b9ef2
Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
...
Props kraftbj. Fixes #31968 .
Built from https://develop.svn.wordpress.org/trunk@32122
git-svn-id: http://core.svn.wordpress.org/trunk@32101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 05:45:28 +00:00
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
0179958273
When `dbDelta()` is checking whether an index is defined in a `CREATE TABLE` statement, don't worry if MySQL has a subpart defined on an index, but the `CREATE TABLE` doesn't.
...
Fixes #31869 .
Built from https://develop.svn.wordpress.org/trunk@32108
git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-11 10:40:31 +00:00
ad475b3c69
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32106
git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 21:08:29 +00:00
0d4b29ffb9
Press This: add ARIA attributes to the `alerts` container.
...
Props afercia. Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32102
git-svn-id: http://core.svn.wordpress.org/trunk@32081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 23:45:27 +00:00
9db5bac3c4
Press This: change the link text to Standard Editor.
...
Props Michael-Arestad. See #31923 .
Built from https://develop.svn.wordpress.org/trunk@32093
git-svn-id: http://core.svn.wordpress.org/trunk@32072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:28:25 +00:00
33a0022773
Press This:
...
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923 .
Built from https://develop.svn.wordpress.org/trunk@32092
git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:14:28 +00:00
54a6a8e137
Don't allow whitespace-only image captions from the Media modal.
...
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.
Fixes #21848 .
Built from https://develop.svn.wordpress.org/trunk@32079
git-svn-id: http://core.svn.wordpress.org/trunk@32058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:11:27 +00:00
abfddb8f3e
Update placeholder for FTP credentials
...
Two changes:
* Remove superfluous __ function call
* Update domain used
Fixes #31922
Props Tmeister
Built from https://develop.svn.wordpress.org/trunk@32077
git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:50:27 +00:00
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
42028327a2
Insert from URL: Make sure the link text is actually used.
...
Turns out there were more pieces to renaming the field.
props iseulde.
fixes #29476 .
Built from https://develop.svn.wordpress.org/trunk@32055
git-svn-id: http://core.svn.wordpress.org/trunk@32034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 18:25:27 +00:00
bfda508c18
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@32051
git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
443760252b
`wp_install_maybe_enable_pretty_permalinks()` should have a consistent `@return` value.
...
props DrewAPicture.
fixes #6481 . see #31888 .
Built from https://develop.svn.wordpress.org/trunk@32027
git-svn-id: http://core.svn.wordpress.org/trunk@32006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:49:53 +00:00
ba1e7a7243
Correct grammar when referring to "a user" vs "an user" in several places.
...
Props ocean90.
Fixes #31894 .
Built from https://develop.svn.wordpress.org/trunk@32025
git-svn-id: http://core.svn.wordpress.org/trunk@32004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:44:27 +00:00
7c3e469326
Clarify the DocBlock summary and parameter description for `wp_edit_attachments_query_vars()`.
...
See [31037]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32019
git-svn-id: http://core.svn.wordpress.org/trunk@31998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:52:25 +00:00
6ccba88ea5
Add proper descriptions for the `@global` and `@param` tags in the `wp_media_attach_action()` DocBlock.
...
See [31619]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32018
git-svn-id: http://core.svn.wordpress.org/trunk@31997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:35:25 +00:00
02810a305f
Clarify the DocBlock description for `wp_print_request_filesystem_credentials_modal()`.
...
See [31811]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32016
git-svn-id: http://core.svn.wordpress.org/trunk@31995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:13:26 +00:00
654ee78c93
Clarify 4.2.0 changelog entry, add global description to the DocBlock for `WP_Users_List_Table->single_row()`.
...
See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32015
git-svn-id: http://core.svn.wordpress.org/trunk@31994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:09:27 +00:00
e82de7ef27
Add missing `@since` versions from a variety of methods in `WP_Press_This`.
...
See [31693]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32014
git-svn-id: http://core.svn.wordpress.org/trunk@31993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 19:46:26 +00:00
7b89119eee
Add missing DocBlocks for the `_limit_array()`, `_limit_string()`, `_limit_url()`, `_limit_img()`, `_limit_embed()`, and `_process_meta_entry()` utility methods in `WP_Press_This`.
...
See [31609]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32013
git-svn-id: http://core.svn.wordpress.org/trunk@31992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 18:23:26 +00:00
0306f2c011
Fix filter doc vernacular for the `quick_edit_show_taxonomy` filter.
...
See [31308]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32011
git-svn-id: http://core.svn.wordpress.org/trunk@31990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:08:26 +00:00
4239756a47
Fix syntax for the `$to_display` parameter description in the DocBlock for `WP_Posts_List_Table->_page_rows()`.
...
See [31730]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32010
git-svn-id: http://core.svn.wordpress.org/trunk@31989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:04:28 +00:00
8a3b21aad5
Add a return description to the DocBlock for `WP_Posts_List_Table->is_base_request()`.
...
See [31828]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32009
git-svn-id: http://core.svn.wordpress.org/trunk@31988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:01:27 +00:00
b500d3e978
Fix typos in the function summaries for `wp_ajax_press_this_save_post()` and `wp_ajax_press_this_add_category()`.
...
See [31534]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32007
git-svn-id: http://core.svn.wordpress.org/trunk@31986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:38:26 +00:00
05fa6879ce
Add an `@see` mention for `Plugin_Upgrader`, plus spacing to the `wp_ajax_update_plugin()` delcaration.
...
See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32006
git-svn-id: http://core.svn.wordpress.org/trunk@31985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:19:27 +00:00
62450e9f0f
After [31114] and [31323], 'View Post' generated in `get_sample_permalink_html()` should go to pretty permalink.
...
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@32002
git-svn-id: http://core.svn.wordpress.org/trunk@31981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 01:27:28 +00:00
247fdbfe19
Remove hidden `user_id` input from `wp_comment_reply()`.
...
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.
See [31776] for Edit Comment screen.
props dllh.
fixes #30307 .
Built from https://develop.svn.wordpress.org/trunk@31999
git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 13:28:26 +00:00
05a549723c
Press This:
...
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875 .
Built from https://develop.svn.wordpress.org/trunk@31992
git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
d05236f756
Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
...
See #31770 .
Built from https://develop.svn.wordpress.org/trunk@31991
git-svn-id: http://core.svn.wordpress.org/trunk@31970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 00:18:27 +00:00
02403eadd1
Plugins Browser: Replace the download count with the number of Active installs of the plugin.
...
Fixes #31865
Built from https://develop.svn.wordpress.org/trunk@31990
git-svn-id: http://core.svn.wordpress.org/trunk@31969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 23:49:27 +00:00
3ac2f91922
Update aria-label when doing a shiny plugin update
...
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails
props mehulkaklotar, afercia
Fixes #31722
Built from https://develop.svn.wordpress.org/trunk@31982
git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
d85f8fe326
Admin notices: Make (most) core notices dismissible.
...
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.
props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233 . see #23367 .
Built from https://develop.svn.wordpress.org/trunk@31973
git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
62279ae07d
In `WP_Posts_List_Table::get_views()`, don't add the `current` class to the `all` status link if `->user_posts_count` has a value, which triggers the additional `mine` status.
...
See [31828].
Fixes #24869 .
Built from https://develop.svn.wordpress.org/trunk@31959
git-svn-id: http://core.svn.wordpress.org/trunk@31938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:17:28 +00:00
8ab7c076d6
Customizer Theme Switcher: Switch the details/live preview buttons.
...
props celloexpressions, ocean90.
fixes #31791 .
Built from https://develop.svn.wordpress.org/trunk@31954
git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
8f99fbeb8d
Refine UI for FTP modal and shiny updates
...
Numerous changes to make the FTP modal experience a good one. These include:
* Update HTML used by both the form here and the form on the standalone screen
* Allow users to cancel FTP install
* Focus locking in the modal
* Focus on modal form on load
* ARIA Attributes
* Style Enhancements
* Add low screen height (such as phone and some tablets) friendly experience for entering credentials
Props ericlewis, afercia
Fixes #31608
Built from https://develop.svn.wordpress.org/trunk@31949
git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
efb2740e88
Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`.
...
props mattwiebe, DrewAPicture.
fixes #31789 .
Built from https://develop.svn.wordpress.org/trunk@31943
git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 20:04:25 +00:00
5fae37471a
Media Library: Add a label for attachment type select in list mode.
...
props afercia.
fixes #31795 .
Built from https://develop.svn.wordpress.org/trunk@31942
git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
36643388ef
Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
...
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.
fixes #28502 .
Built from https://develop.svn.wordpress.org/trunk@31941
git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
7e1e32909e
Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
...
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811
Built from https://develop.svn.wordpress.org/trunk@31936
git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:26 +00:00
289db2d37b
Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother.
...
see #31782 .
Built from https://develop.svn.wordpress.org/trunk@31933
git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
e70e4e74fa
Press This: Use the error message returned by `wp_update_post()` instead of a generic one.
...
props stephdau.
fixes #31808 .
Built from https://develop.svn.wordpress.org/trunk@31930
git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
43a99e0f1b
Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
...
props SergeyBiryukov, afercia, tyxla.
fixes #30766 .
Built from https://develop.svn.wordpress.org/trunk@31928
git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
6cd9c9645e
Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
...
Part props afercis, joedolson. Fixes #31575 .
Built from https://develop.svn.wordpress.org/trunk@31925
git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
f663dc73d4
Press This: remove `role="application"` from the Categories list wrapper. This doesn't make it work better in screen readers.
...
See #31443 .
Built from https://develop.svn.wordpress.org/trunk@31907
git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:49:32 +00:00
8daaa09c9b
Improve newly added strings for i18n:
...
* Add context to "Format" string.
* Use "Format" with context for "Post format".
see #31776 .
Built from https://develop.svn.wordpress.org/trunk@31906
git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:19:26 +00:00
9b23faef07
Remove Shiny Plugin Installs
...
See #31773 , #29820
Built from https://develop.svn.wordpress.org/trunk@31897
git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
60c26865f9
Check that `$_POST` array index is set before comparing it in `post_preview()`.
...
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.
Props tyxla.
Fixes #31760 .
Built from https://develop.svn.wordpress.org/trunk@31896
git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:45:26 +00:00
6cc20e7095
Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
...
Props stephdau. Fixes #31763 .
Built from https://develop.svn.wordpress.org/trunk@31894
git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:17:26 +00:00
51854c53b4
Improve alignment of labels and inputs in Quick Edit.
...
props mattheu, valendesigns.
fixes #31408 .
Built from https://develop.svn.wordpress.org/trunk@31890
git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:25:26 +00:00
5ef13b688e
Comments List: Don't let "Quick Edit" break on smaller screens.
...
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.
props kraftbj.
fixes #31482 .
Built from https://develop.svn.wordpress.org/trunk@31889
git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:15:27 +00:00
1ad0eaf416
Clean up DocBlock information and syntax for `get_filesystem_method()`.
...
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267 .
Built from https://develop.svn.wordpress.org/trunk@31884
git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 16:32:28 +00:00
7b5ae90225
When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL.
...
Fixes #31758 . See #23367
Built from https://develop.svn.wordpress.org/trunk@31882
git-svn-id: http://core.svn.wordpress.org/trunk@31861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 04:32:26 +00:00
f5e6f92174
Do not output empty name and id HTML attributes in get_submit_button().
...
Props afercia. Fixes #31749 .
Built from https://develop.svn.wordpress.org/trunk@31880
git-svn-id: http://core.svn.wordpress.org/trunk@31859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 03:23:27 +00:00
ce6c00f140
Fix a typo in [31872].
...
see #31738 .
Built from https://develop.svn.wordpress.org/trunk@31873
git-svn-id: http://core.svn.wordpress.org/trunk@31852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:33:27 +00:00
9c409e31f2
Fill `$plugins['upgrade']` with extra info for use in list table
...
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.
Fixes #31738 .
Built from https://develop.svn.wordpress.org/trunk@31872
git-svn-id: http://core.svn.wordpress.org/trunk@31851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:30:26 +00:00
0329852941
Press This:
...
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745 .
Built from https://develop.svn.wordpress.org/trunk@31868
git-svn-id: http://core.svn.wordpress.org/trunk@31847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 01:33:29 +00:00
3dc53770b7
Upgrader: When creating a temporary working directory, strip off `.tmp` as well as `.zip` incase we end up using that directory as the items main directory.
...
Fixes #30945
Built from https://develop.svn.wordpress.org/trunk@31863
git-svn-id: http://core.svn.wordpress.org/trunk@31842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 04:40:27 +00:00
cc903c3422
Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
...
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`
These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`
Props iseulde. Fixes #31121
Built from https://develop.svn.wordpress.org/trunk@31862
git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 02:14:27 +00:00
bc54176af0
Media: Show filename instead of extension in the list table.
...
This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.
fixes #30943 .
Built from https://develop.svn.wordpress.org/trunk@31857
git-svn-id: http://core.svn.wordpress.org/trunk@31836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-22 11:02:29 +00:00
42b9557137
Remove leading newlines from two translatable strings.
...
fixes #29480 .
Built from https://develop.svn.wordpress.org/trunk@31844
git-svn-id: http://core.svn.wordpress.org/trunk@31826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:42:26 +00:00
e838ab315d
After [31730], replace one more instance of `array_shift()` with `reset()` for better performance.
...
see #31259 , #15459 .
Built from https://develop.svn.wordpress.org/trunk@31841
git-svn-id: http://core.svn.wordpress.org/trunk@31823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 01:57:27 +00:00
b568da1997
Make a comment clearer (without implying inversed logic) and fix a typo.
...
see #31645 .
Built from https://develop.svn.wordpress.org/trunk@31837
git-svn-id: http://core.svn.wordpress.org/trunk@31819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:45:27 +00:00
1666eb5616
Press This: small clean-up when generating the suggested content. Ensure all keys are always set in the array that is passed through the filter.
...
See #31637 .
Built from https://develop.svn.wordpress.org/trunk@31836
git-svn-id: http://core.svn.wordpress.org/trunk@31818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:18:26 +00:00
22476bf617
Fix notice that exists for plugins with no slug
...
Not all plugins have a slug, especially plugins not from the WordPress.org repository.
Props imath for initial patch.
Fixes #31694
Built from https://develop.svn.wordpress.org/trunk@31834
git-svn-id: http://core.svn.wordpress.org/trunk@31816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 17:48:29 +00:00
a18118ed7c
Make dates in multisite site and user list tables translatable.
...
Props pavelevap.
Fixes #22302 .
Built from https://develop.svn.wordpress.org/trunk@31833
git-svn-id: http://core.svn.wordpress.org/trunk@31815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 16:22:28 +00:00
a836a32fb4
Ensure that we target the correct plugin row for update updates
...
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.
Props ericlewis
Fixes #31621
Built from https://develop.svn.wordpress.org/trunk@31831
git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 05:26:28 +00:00
55fd3fa791
In the "Send Trackbacks" meta box, the description of how pingbacks work was missing a comma after the introductory clause.
...
Props cfinke.
Fixes #31668 .
Built from https://develop.svn.wordpress.org/trunk@31830
git-svn-id: http://core.svn.wordpress.org/trunk@31812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 04:06:27 +00:00
bce851dcf2
Replace `array_shift()` with `reset()` where appropriate for performance.
...
Props SergeyBiryukov.
Fixes #31259 .
Built from https://develop.svn.wordpress.org/trunk@31829
git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 03:56:27 +00:00
55ae3f9ea0
Add `WP_Posts_List_Table::is_base_request()` to determine if the current "view" is the "All" (default) view.
...
Fixes #24869 .
Built from https://develop.svn.wordpress.org/trunk@31828
git-svn-id: http://core.svn.wordpress.org/trunk@31810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 02:26:26 +00:00
40ebc2784f
Press This: check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content.
...
Fixes #31637 .
Built from https://develop.svn.wordpress.org/trunk@31827
git-svn-id: http://core.svn.wordpress.org/trunk@31809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 00:52:26 +00:00
4303ea5379
Press This: prepend the site domain to root-relative URLs. Reject other relative URLs.
...
Part props stephdau, kraftbj. Fixes #31645 .
Built from https://develop.svn.wordpress.org/trunk@31818
git-svn-id: http://core.svn.wordpress.org/trunk@31800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 20:43:27 +00:00
9b79c36713
WP_Filesystem: Change `WP_Filesystem_FTPext::exists()` and `WP_Filesystem_ftpsockets::exists()` to return true for empty directories.
...
Both methods are using *nlist() which returns a list of files in a given directory or the file itself for a given file. If the result was an empty list we assumed that the file doesn't exists. This includes also cases where $file is actually an empty directory. To prevent this we now check if $file is a directory before returning the result of an empty list.
Other filesystem methods are using `file_exists()` which already checks whether a file or directory exists.
fixes #30815 .
Built from https://develop.svn.wordpress.org/trunk@31815
git-svn-id: http://core.svn.wordpress.org/trunk@31797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 19:22:27 +00:00
2d64637ff8
Request FTP and SSH credentials when needed during shiny updates
...
This is a restoration of [31749] which was reverted in [31755].
It includes a number of enhancements from the original version. Namely:
* Not doing a credential check in src/wp-includes/script-loader.php
* Add new function `wp_print_request_filesystem_credentials_modal`
* update the version number in the list table when a plugin is updated
UI still needs further work, but this basic version should enable more testing
Props ericlewis, jorbin
See #31528
Built from https://develop.svn.wordpress.org/trunk@31811
git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
f26a2e8113
Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated.
...
Props kraftbj. Fixes #31639 .
Built from https://develop.svn.wordpress.org/trunk@31810
git-svn-id: http://core.svn.wordpress.org/trunk@31792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:51:27 +00:00
b00ae388c6
Press This: add `aria-describedby` to the new tag field.
...
Props afercia. Fixes #31546 .
Built from https://develop.svn.wordpress.org/trunk@31808
git-svn-id: http://core.svn.wordpress.org/trunk@31790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:18:27 +00:00
441e1e6ab9
Press This: fix the header styling and add a logo.
...
Props Michael-Arestad. Fixes #31472 .
Built from https://develop.svn.wordpress.org/trunk@31807
git-svn-id: http://core.svn.wordpress.org/trunk@31789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:09:27 +00:00
c04a1affd1
Press This: bump bookmarklet's version. See #31657 .
...
Built from https://develop.svn.wordpress.org/trunk@31800
git-svn-id: http://core.svn.wordpress.org/trunk@31782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 01:19:27 +00:00
9e1d17ad36
Press This:
...
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660 .
Built from https://develop.svn.wordpress.org/trunk@31799
git-svn-id: http://core.svn.wordpress.org/trunk@31781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 00:47:28 +00:00
bf34e504dc
Press This: change the Publish button text to Submit for Review for contributors (like on the Edit Post screen).
...
Props stephdau, DrewAPicture. Fixes #31658 .
Built from https://develop.svn.wordpress.org/trunk@31798
git-svn-id: http://core.svn.wordpress.org/trunk@31780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 21:07:27 +00:00
c1c29782c9
Press This:
...
- Test image sizes from JS after Press This loads, before adding them to "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561 .
Built from https://develop.svn.wordpress.org/trunk@31797
git-svn-id: http://core.svn.wordpress.org/trunk@31779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:51:26 +00:00
634df7e4a4
PressThis: add a wrapped with role = application to the categories section.
...
Props: afercia. See #31443 .
Built from https://develop.svn.wordpress.org/trunk@31775
git-svn-id: http://core.svn.wordpress.org/trunk@31755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 23:41:27 +00:00
805c530cf0
PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form.
...
Part prop: Michael-Arestad. Fixes #31443 .
Built from https://develop.svn.wordpress.org/trunk@31765
git-svn-id: http://core.svn.wordpress.org/trunk@31745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 16:57:26 +00:00
474f001c42
Revert [31749], see #31528 .
...
Built from https://develop.svn.wordpress.org/trunk@31755
git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 17:51:26 +00:00
e8a600ac94
Shiny Updates: Don't translate an error code string.
...
props ericlewis.
fixes #31606 .
Built from https://develop.svn.wordpress.org/trunk@31751
git-svn-id: http://core.svn.wordpress.org/trunk@31732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 13:09:27 +00:00
5b658df402
Request FTP and SSH credentials when needed during shiny updates
...
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates. There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates.
Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528
Built from https://develop.svn.wordpress.org/trunk@31749
git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 08:53:26 +00:00
296dba2804
Nav menus: Return to calling links "Custom Links".
...
It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI.
props tyxla.
fixes #31344 .
Built from https://develop.svn.wordpress.org/trunk@31748
git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 06:15:27 +00:00
1581ca7092
PressThis: add inline comments and some cleanup for the images and embeds regex.
...
Props stephdau. Fixes #31373 .
Built from https://develop.svn.wordpress.org/trunk@31739
git-svn-id: http://core.svn.wordpress.org/trunk@31720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:37:28 +00:00
ce297a7227
PressThis: update _limit_url(), use esc_url_raw(). Fixes checking of urlencoded strings.
...
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31737
git-svn-id: http://core.svn.wordpress.org/trunk@31718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:23:25 +00:00
4cc85f4da2
Administration: Remove single-use URL parameters and create canonical link based on new URL.
...
The default removable query args are 'message', 'settings-updated', 'saved', 'update', 'updated','activated', 'activate', 'deactivate', 'locked', 'deleted', 'trashed', 'untrashed', 'enabled', 'disabled', and 'skipped'.
props morganestes.
fixes #23367 .
Built from https://develop.svn.wordpress.org/trunk@31736
git-svn-id: http://core.svn.wordpress.org/trunk@31717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:09:26 +00:00
bb99536bf5
Introduce a new algorithm for displaying a hierarchical list of post objects in the `WP_Posts_List_Table`. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages.
...
Props nofearinc, rodrigosprimo, nacin, johnbillion.
Fixes #15459
Built from https://develop.svn.wordpress.org/trunk@31730
git-svn-id: http://core.svn.wordpress.org/trunk@31711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 20:46:27 +00:00
50c2cee32d
Merge three similar strings.
...
props pavelevap.
see #31013 .
Built from https://develop.svn.wordpress.org/trunk@31717
git-svn-id: http://core.svn.wordpress.org/trunk@31698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 15:25:28 +00:00
13ad2d4e16
Screen Options: Improve items per page option label.
...
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.
props afercia.
fixes #31349 , #15576 .
Built from https://develop.svn.wordpress.org/trunk@31696
git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 15:32:27 +00:00
19f1d4f402
EXIF/IPTC captions should populate Caption (`post_excerpt`) on upload, not Description (`post_content`).
...
Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set.
props beaulebens, ericlewis, bendoh, SergeyBiryukov.
fixes #22768 .
Built from https://develop.svn.wordpress.org/trunk@31694
git-svn-id: http://core.svn.wordpress.org/trunk@31675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 05:07:28 +00:00
be24bc3a97
PressThis:
...
- Filter and select the content on the PHP side. Then pass only the needed data to JS.
- Add the suggested post title and contend directly to the HTML.
- Standardise the data type names.
- Some cleanup/reduction of the code in the bookmarklet.
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31693
git-svn-id: http://core.svn.wordpress.org/trunk@31674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 21:49:28 +00:00
8a9181d8d4
SSH2 Upgrade transport: Trim the trailing newline character from the ouput of `pwd` to avoid a PHP Segfault.
...
Fixes #30802 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31686
git-svn-id: http://core.svn.wordpress.org/trunk@31667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 04:32:27 +00:00
0ec87e4584
There are a few functions that have the ability to return `false` instead of a string, so the return value should be checked before being passed to functions that expect string.
...
These are trivial, but they clear out some Scrutinizer issues.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31681
git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 02:11:28 +00:00
dccf5ceb90
Empty `return` statements are unnecessary at the end of functions.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31679
git-svn-id: http://core.svn.wordpress.org/trunk@31660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 23:09:27 +00:00
c1cab11ceb
Use `$this->` instead of `parent::` when calling `tablenav()` in `WP_Theme_Install_List_Table`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31672
git-svn-id: http://core.svn.wordpress.org/trunk@31653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 23:03:27 +00:00
be207e6550
PressThis: make the Preview button "subtle".
...
See #31458 .
Built from https://develop.svn.wordpress.org/trunk@31655
git-svn-id: http://core.svn.wordpress.org/trunk@31636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:50:26 +00:00
9716d171c7
PressThis: add preview functionality. Opens the preview in a new window or a tab next to the source tab.
...
Fixes #31458 .
Built from https://develop.svn.wordpress.org/trunk@31654
git-svn-id: http://core.svn.wordpress.org/trunk@31635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:17:26 +00:00
a27967aa05
PressThis:
...
- Close the sidebar on moving the focus outside of it (by clicking or by "tabbing").
- Fix a (weird) structural CSS problem where clicks go through the sidebar when it is open.
- Clean up the JS a bit.
Fixes #31457 .
Built from https://develop.svn.wordpress.org/trunk@31651
git-svn-id: http://core.svn.wordpress.org/trunk@31632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 22:57:26 +00:00
8f0b626d13
Introduce a function, `wp_attachment_is( $type, $post = 0 )`, to collapse the logic for determining whether an attachment is an `image`, `audio`, or `video`.
...
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.
See #25275 .
Built from https://develop.svn.wordpress.org/trunk@31645
git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 20:26:26 +00:00
5abac389fa
PressThis: when server-side parsing, filter small images by the width and height attributes if set.
...
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31637
git-svn-id: http://core.svn.wordpress.org/trunk@31618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 02:03:27 +00:00
bcad925af4
PressThis:
...
- Fix error when checking for empty array keys.
- Add better DailyMotion embed support.
Props stephdau, see #31373 .
Built from https://develop.svn.wordpress.org/trunk@31635
git-svn-id: http://core.svn.wordpress.org/trunk@31616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 01:17:24 +00:00
da7359b060
After [31620], when checking for HTTP URLs, make sure we are checking the shortcode body instead of an indexed attribute.
...
See #31139 .
Built from https://develop.svn.wordpress.org/trunk@31626
git-svn-id: http://core.svn.wordpress.org/trunk@31607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 16:26:25 +00:00
f9c138b4c4
`detached` affects the `wp()` call for the media list table, so switch our new `$_GET` key to `detach`.
...
See #6820 .
Built from https://develop.svn.wordpress.org/trunk@31624
git-svn-id: http://core.svn.wordpress.org/trunk@31605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 15:59:27 +00:00
cc953717b7
Allow inline editing of `width` and `height` parameters while previewing an embed in the media modal:
...
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
This is a first pass to allow broad testing with recent MCE view changes.
See #31139 .
Built from https://develop.svn.wordpress.org/trunk@31620
git-svn-id: http://core.svn.wordpress.org/trunk@31601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 06:00:26 +00:00
d3471e9850
Allow attachments to be Detached from their parent in media grid and list modes.
...
See #6820 .
Built from https://develop.svn.wordpress.org/trunk@31619
git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 05:35:28 +00:00
df08581656
List tables: Display front and posts page indicators.
...
fixes #30190 .
Built from https://develop.svn.wordpress.org/trunk@31610
git-svn-id: http://core.svn.wordpress.org/trunk@31591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:45:25 +00:00
f53199487d
PressThis:
...
- Improve handling of the data, both from the bookmarklet and from server-side parsing.
- Standardize on processing the data in PHP and remove duplicate code from JS.
- Improve the bookmarklet code and remove pre-filtering of the data.
Part props stephdau, see #31373 .
Built from https://develop.svn.wordpress.org/trunk@31609
git-svn-id: http://core.svn.wordpress.org/trunk@31590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:29:25 +00:00
513a038159
Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.
...
It's not particularly useful, and adds visual noise when in place.
props welcher.
fixes #31485 .
Built from https://develop.svn.wordpress.org/trunk@31607
git-svn-id: http://core.svn.wordpress.org/trunk@31588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:53:25 +00:00
5567d03278
Nav menus: Better JS performance on initial load of edit screen.
...
The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus.
Also simplifies a redundant set of click event handlers down to one, which further enhances performance.
props atimmer, sevenspark.
fixes #25698 .
Built from https://develop.svn.wordpress.org/trunk@31604
git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:14:25 +00:00
a9f165915f
Press This:
...
- Remove classes from suggested HTML for the editor.
- Improve the filter, pass an associative array as param.
- Use <em> instead of <cite>.
Props Michael-Arestad, kraftbj. Fixes #31493 .
Built from https://develop.svn.wordpress.org/trunk@31601
git-svn-id: http://core.svn.wordpress.org/trunk@31582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 23:41:27 +00:00
0b3c3092fc
Clean up and refine DocBlocks for a variety of functions and methods in wp-admin/includes/template.php.
...
* Also documents the default arguments of `wp_terms_checklist()` as a hash notation.
Props ipm-frommen, DrewAPicture.
Fixes #31248 .
Built from https://develop.svn.wordpress.org/trunk@31599
git-svn-id: http://core.svn.wordpress.org/trunk@31580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 06:11:40 +00:00
c22307fd9a
PressThis: make sure buttons.css is loaded before press-this.css. Use (int) $post_ID instead of $post->ID.
...
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31597
git-svn-id: http://core.svn.wordpress.org/trunk@31578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 00:58:25 +00:00
3a124ac2f4
PressThis:
...
- Replace all `%1$s` and `%2$s` in suggestedHTML in case plugins repeat them.
- Fix docs typo, props kraftbj.
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31596
git-svn-id: http://core.svn.wordpress.org/trunk@31577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 23:28:26 +00:00
4e8138cea5
PressThis:
...
- Simplify `getSuggestedContent()` and helpers. No need to override the global `data`.
- Replace the `press_this_source_string` and `press_this_source_link` filters with `press_this_suggested_html` that allows filtering of the link and the wrapper HTML tags.
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31595
git-svn-id: http://core.svn.wordpress.org/trunk@31576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 22:44:25 +00:00
a337c34c4e
Fix a typo in the `$args` parameter hash notation description for `add_settings_field()`.
...
See #28975 , [31592].
Built from https://develop.svn.wordpress.org/trunk@31593
git-svn-id: http://core.svn.wordpress.org/trunk@31574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:57:32 +00:00
82fd5e33dd
Add a hash notation for the optional `$args` parameter in `add_settings_field()`, which includes a description for the new `$class` argument added in [31560].
...
Also adds a changelog entry to `add_settings_field()` DocBlock for the new `$class` argument.
See [31560].
Fixes #28975 .
Built from https://develop.svn.wordpress.org/trunk@31592
git-svn-id: http://core.svn.wordpress.org/trunk@31573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:53:25 +00:00
8164f8fe0e
PressThis:
...
- Remove unneeded passing of post formats strings to JS.
- Set the currently selected post format name with jQuery.
See #31373 .
Built from https://develop.svn.wordpress.org/trunk@31589
git-svn-id: http://core.svn.wordpress.org/trunk@31570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 20:08:27 +00:00
8ecb7f5d1e
Press This: Backwards compatibility enhancements.
...
* Add missing actions for printing styles/scripts.
* Since `$hook_suffix` is null, hardcode `press-this.php`.
* Restore body classes, add filter.
* Use boolean value instead of `__return_false()`.
* Use `wp_json_encode()`.
* Update docs for filters in script-loader.php.
* Make `<a href="%1$s">%2$s</a>` not translatable.
see #31373 .
Built from https://develop.svn.wordpress.org/trunk@31588
git-svn-id: http://core.svn.wordpress.org/trunk@31569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 10:36:25 +00:00
c7dba8b015
Press This: RTL improvements.
...
* Load the RTL version of press-this-editor.css.
* Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478 .
see #31474 .
Built from https://develop.svn.wordpress.org/trunk@31577
git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:44:24 +00:00
f6b1b01ecd
Make a new function, `wp_delete_file()`. Use it.
...
Props scribu, wonderboymusic.
Fixes #17864 .
Built from https://develop.svn.wordpress.org/trunk@31575
git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 16:51:25 +00:00
5e47a1f633
Press This: Use boolean value instead of __return_true(). Add missing hook docs.
...
see #31373 .
Built from https://develop.svn.wordpress.org/trunk@31571
git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 11:15:25 +00:00
4593319ea7
PressThis: accessibility enhancements:
...
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449 .
Built from https://develop.svn.wordpress.org/trunk@31566
git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 02:50:25 +00:00
b95d99d1c1
Settings API: Allow passing a class to `add_settings_field()` via the `$args` array.
...
While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168 .
props valendesigns.
fixes #28975 . see #30168 .
Built from https://develop.svn.wordpress.org/trunk@31560
git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 19:59:25 +00:00
49dd31506f
Press This: Use correct URL for update bookmarklet link.
...
props kraftbj.
fixes #31461 .
Built from https://develop.svn.wordpress.org/trunk@31556
git-svn-id: http://core.svn.wordpress.org/trunk@31537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 08:48:25 +00:00
7cb45f2402
Don't call the size function `count()` as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
...
Scrutinizer added a Performance label: these are the only violations.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31554
git-svn-id: http://core.svn.wordpress.org/trunk@31535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:48:24 +00:00
4310147e54
Add missing access modifiers to `WP_Press_This`.
...
See #31456 .
Built from https://develop.svn.wordpress.org/trunk@31552
git-svn-id: http://core.svn.wordpress.org/trunk@31533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:18:25 +00:00
50bb433c66
Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference.
...
See #17470 .
Built from https://develop.svn.wordpress.org/trunk@31551
git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 03:08:28 +00:00
ae3baa7c5b
Hide irrelevant UI and display a message when editing the page for posts.
...
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.
Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.
props alexkingorg for the initial, long-suffering patch.
fixes #17470 .
Built from https://develop.svn.wordpress.org/trunk@31550
git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 02:47:25 +00:00
1857055bb8
PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373 .
...
Built from https://develop.svn.wordpress.org/trunk@31534
git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 01:50:26 +00:00
8b180b9a46
Add theme browsing and theme switching to the Customizer
...
* Brings into core the Customizer Theme Switcher feature plugin
* You can now browse, preview, and activate themes right from the Customizer
fixes #31303 .
props celloexpressions, afercia, westonruter, folletto, designsimply
Built from https://develop.svn.wordpress.org/trunk@31533
git-svn-id: http://core.svn.wordpress.org/trunk@31514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 20:31:24 +00:00
4743843323
Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php.
...
Props NikV for the initial patch.
Fixes #31353 .
Built from https://develop.svn.wordpress.org/trunk@31529
git-svn-id: http://core.svn.wordpress.org/trunk@31510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 06:07:26 +00:00
7644e68119
Provide proper label associations and descriptions throughout the network admin
...
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.
Props cfoellmann, afercia, rianrietveld.
Fixes #38406 .
Built from https://develop.svn.wordpress.org/trunk@31517
git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:29:26 +00:00
19dbf7b998
Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914 .
...
Built from https://develop.svn.wordpress.org/trunk@31513
git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:48:26 +00:00
678982ee7e
Do not activate plugins on initial installation in multisite.
...
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.
Props ianmjones.
Fixes #31327 .
Built from https://develop.svn.wordpress.org/trunk@31511
git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:30:25 +00:00
8eb25609e9
Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
...
props danielbachhuber.
fixes #29374 .
Built from https://develop.svn.wordpress.org/trunk@31508
git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
4b21c67738
Remove untranslatable period from a successful update message in `Bulk_Upgrader_Skin::add_strings()`.
...
props mako09, DrewAPicture.
fixes #30793 .
Built from https://develop.svn.wordpress.org/trunk@31506
git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:07:24 +00:00
19a43125cd
Don't try to read a non-existent Exif:Title tag in `wp_read_image_metadata()`, as it's not a part of the Exif standard.
...
props tyxla.
fixes #31043 .
Built from https://develop.svn.wordpress.org/trunk@31462
git-svn-id: http://core.svn.wordpress.org/trunk@31443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 09:14:28 +00:00
e2f5a8094e
Avoid a PHP notice in `wp_install_language_form()` and `wp_dropdown_languages()` if the language doesn't have a ISO 639-1 code.
...
props barrykooij.
fixes #31319 .
Built from https://develop.svn.wordpress.org/trunk@31447
git-svn-id: http://core.svn.wordpress.org/trunk@31428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 11:23:26 +00:00
7b9d981a54
Use correct default values for some admin template functions.
...
props ipm-frommen.
fixes #31308 .
Built from https://develop.svn.wordpress.org/trunk@31446
git-svn-id: http://core.svn.wordpress.org/trunk@31427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 06:51:25 +00:00
5a0b01edf1
Rename unused argument and remove obsolete global in `iframe_header()`.
...
props ipm-frommen.
fixes #31309 .
Built from https://develop.svn.wordpress.org/trunk@31443
git-svn-id: http://core.svn.wordpress.org/trunk@31424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 05:31:26 +00:00
268d79cb77
`_list_meta_row()` should always return a string.
...
props ipm-frommen.
fixes #31310 .
Built from https://develop.svn.wordpress.org/trunk@31442
git-svn-id: http://core.svn.wordpress.org/trunk@31423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:22:26 +00:00
6fd67ad80e
Correct parameter types for `Plugin_Upgrader::bulk_upgrade()` and `Theme_Upgrader::bulk_upgrade()`.
...
props ipm-frommen.
fixes #31312 .
Built from https://develop.svn.wordpress.org/trunk@31441
git-svn-id: http://core.svn.wordpress.org/trunk@31422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:19:27 +00:00
43583a1b9e
Terminate JS statements in two admin files.
...
props ipm-frommen.
fixes #31311 .
Built from https://develop.svn.wordpress.org/trunk@31440
git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:09:27 +00:00
2a1f3c4c1f
Posts list table: Add a filter to disable the months dropdown.
...
It was previously possible to prevent it from displaying by filtering everything out from the results, but if one really doesn't want it, they should be able to short-circuit before the query even runs.
props norcross, SergeyBiryukov.
fixes #30254 .
Built from https://develop.svn.wordpress.org/trunk@31438
git-svn-id: http://core.svn.wordpress.org/trunk@31419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-12 18:38:29 +00:00
3cec3655e9
Prevent IE9 and lower displaying the download file dialogue when attempting to upload using the `html4` Plupload handler.
...
The HTML4 Plupload handler uses a hidden iframe to POST the upload form,
Unfortunately Internet Explorer 9 doesn't support the `application/json`
content-type which `wp_send_json_success()` and requires `text/html` instead.
This partially reverts [30354], keeping the better error messages.
Fixes #31037 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31429
git-svn-id: http://core.svn.wordpress.org/trunk@31410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-12 01:15:29 +00:00
6cb16f7a21
Remove unused media JS files.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31405
git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:45:28 +00:00
0e65ae6176
Remove redundant string with a typo introduced in [25481].
...
see #31217 .
Built from https://develop.svn.wordpress.org/trunk@31404
git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:53:28 +00:00
12f4004989
Replace generic "Dear user" greeting in email notifications with a more personalized one.
...
props Ipstenu.
fixes #31217 .
Built from https://develop.svn.wordpress.org/trunk@31403
git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:47:27 +00:00
f166a51809
Update body class when switching between admin color schemes.
...
props valendesigns.
fixes #30488 .
Built from https://develop.svn.wordpress.org/trunk@31400
git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 02:23:28 +00:00
72f18cb067
Don't parse empty 'tax_input' keys in `edit_post()`.
...
This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.
See #30615 .
Built from https://develop.svn.wordpress.org/trunk@31392
git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 22:54:28 +00:00
1e0905793c
Avoid inadvertent stomping of the original `$args` parameter passed to `plugins_api_result` and `themes_api_result` filters in `plugins_api()` and `themes_api()`, respectively.
...
Fixes a regression introduced in [25956].
props Corphi, obenland.
fixes #29079 .
Built from https://develop.svn.wordpress.org/trunk@31363
git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 06:21:22 +00:00
b9e661dcae
Parse non-hierarchical tag input into term IDs before sending to `wp_insert_post()`.
...
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.
Props boonebgorges, ArminBraun.
Fixes #30615 .
Built from https://develop.svn.wordpress.org/trunk@31359
git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 20:32:22 +00:00
d7c6ac95bc
Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31358
git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 13:41:22 +00:00
7444799a82
Upgrades: When upgrading a table to utf8mb4, we should run the `ALTER TABLE` query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31354
git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:59:23 +00:00
555a9f0912
Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation.
...
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.
See #21212
Built from https://develop.svn.wordpress.org/trunk@31351
git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:26:21 +00:00
b2cf823105
WPDB: If a site is using the `utf8` charset, and their version of MySQL supports `utf8mb4`, auto-upgrade them to `utf8mb4`.
...
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.
See #21212
Built from https://develop.svn.wordpress.org/trunk@31349
git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 04:51:22 +00:00
5e4d135411
Shiny Updates: Fix a PHP warning when installing new plugins.
...
Props lgladdy for the initial patch.
See #29820
Built from https://develop.svn.wordpress.org/trunk@31345
git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 00:34:21 +00:00
27aa3e92d7
Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31335
git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:16:23 +00:00
b7926a518a
Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31334
git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:05:22 +00:00
9c69213f2b
Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
...
This also includes JS architecture that can be expanded to support theme, core and language pack updates.
Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture
See #29820
Built from https://develop.svn.wordpress.org/trunk@31333
git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
62e65c3a35
Accessibility: remove remaining instances of accesskey.
...
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.
props afercia.
fixes #29715 .
Built from https://develop.svn.wordpress.org/trunk@31331
git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-04 03:46:24 +00:00
e8f032c747
WP_Upgrader: Remove references to non-existant variables that have never existed.
...
Props jdgrimes. Fixes #29087
Built from https://develop.svn.wordpress.org/trunk@31327
git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:18:24 +00:00
92cb5936f1
Remove an unused parameter on install_plugins_upload().
...
Props michalzuber. Fixes #28964
Built from https://develop.svn.wordpress.org/trunk@31326
git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:14:22 +00:00
Scott Taylor
Dion Hulse
Konstantin Obenland
Helen Hou-Sandí
Jeremy Felt
Andrew Ozz
John Blackbourn
Drew Jaynes
Dominik Schilling
Gary Pendergast
Michael Adams
Aaron Jorbin
Sergey Biryukov
Boone Gorges
Mark Jaquith