Dominik Schilling
51671afc0a
List Table: Improve `WP_Plugins_List_Table::search_box()` which was added in [38033].
...
* Update DocBlock to use third-person singular verb and to include a period at the end.
* Use `submit_button()` for the submit button.
* Escape the ID attribute.
* Apply the same to `WP_List_Table::search_box()`.
See #37230 .
Built from https://develop.svn.wordpress.org/trunk@38146
git-svn-id: http://core.svn.wordpress.org/trunk@38087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-23 11:00:36 +00:00
Sergey Biryukov
995dc513a4
Docs: Update the description of the `$box` argument of `wp_nav_menu_item_taxonomy_meta_box()` for consistency with [38129].
...
Missed in [38130].
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38142
git-svn-id: http://core.svn.wordpress.org/trunk@38083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 16:50:28 +00:00
Dominik Schilling
50ca05f8cd
Plugins: Make search field placeholder translatable.
...
See #37230 .
Built from https://develop.svn.wordpress.org/trunk@38141
git-svn-id: http://core.svn.wordpress.org/trunk@38082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 14:51:28 +00:00
Dominik Schilling
06c71ee6ec
Docs: Fix minor formatting issue for a comment added in [38113].
...
See #32171 .
Built from https://develop.svn.wordpress.org/trunk@38139
git-svn-id: http://core.svn.wordpress.org/trunk@38080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 13:46:28 +00:00
Dominik Schilling
3a3828c396
Filesystem API: Change the default value for the `$context` parameter of `get_filesystem_method()` and `request_filesystem_credentials()` to an empty string.
...
`$context` is a full path to the directory that is tested for being writable. A path shouldn't be a boolean value.
This also updates `WP_Upgrader_Skin::request_filesystem_credentials()` and `Automatic_Upgrader_Skin::request_filesystem_credentials()` and adds missing docs.
Props DrewAPicture, ocean90.
Fixes #37412 .
Built from https://develop.svn.wordpress.org/trunk@38138
git-svn-id: http://core.svn.wordpress.org/trunk@38079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 12:10:27 +00:00
Dominik Schilling
eb0ee24750
Post Thumbnails: Remove an unused nonce in `_wp_post_thumbnail_html()`.
...
See #12922 .
Built from https://develop.svn.wordpress.org/trunk@38137
git-svn-id: http://core.svn.wordpress.org/trunk@38078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 11:44:28 +00:00
Dominik Schilling
c4dfc0adba
Media: Remove global import for `$content_width` in `_wp_post_thumbnail_html()`.
...
`$content_width` is unused since [35023].
See #28512 .
Built from https://develop.svn.wordpress.org/trunk@38136
git-svn-id: http://core.svn.wordpress.org/trunk@38077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 11:40:28 +00:00
Dominik Schilling
a20e16d3c6
Docs: Change type of `WP_Upgrader_Skin::$result` to 'string|bool|WP_Error'.
...
`$result` can be `true` too, see `Language_Pack_Upgrader::bulk_upgrade()`.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@38134
git-svn-id: http://core.svn.wordpress.org/trunk@38075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-22 10:43:29 +00:00
Sergey Biryukov
db523ad623
Editor: Improve styling of "Add Media" button on mobile and make it more consistent with media buttons added by plugins.
...
Props FolioVision.
Fixes #36999 .
Built from https://develop.svn.wordpress.org/trunk@38132
git-svn-id: http://core.svn.wordpress.org/trunk@38073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 21:54:32 +00:00
Sergey Biryukov
0a9bfead1c
Docs: In meta box functions, clarify that "Meta box ID" refers to the `id` attribute of the meta box and not a numeric ID.
...
Fixes #37211 .
Built from https://develop.svn.wordpress.org/trunk@38131
git-svn-id: http://core.svn.wordpress.org/trunk@38072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:24:28 +00:00
Sergey Biryukov
97fd7d829f
Menus: In `wp_nav_menu_item_taxonomy_meta_box()`:
...
* Rename the `$taxonomy` parameter to `$box` for clarity and consistency with other meta box functions.
* Make the docs more consistent with `post_categories_meta_box()` and other meta box functions.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38130
git-svn-id: http://core.svn.wordpress.org/trunk@38071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:21:28 +00:00
Sergey Biryukov
5fd308db50
Menus: In `wp_nav_menu_item_post_type_meta_box()`:
...
* Rename the `$post_type` parameter to `$box` for clarity and consistency with other meta box functions.
* Make the docs more consistent with `post_format_meta_box()` and other meta box functions.
* Correct type and description for the third argument of `nav_menu_items_{$post_type_name}_recent` filter.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38129
git-svn-id: http://core.svn.wordpress.org/trunk@38070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 19:19:29 +00:00
Sergey Biryukov
550bc85e06
Docs: Correct and expand the docs for the `$taxonomy` argument of `wp_nav_menu_item_taxonomy_meta_box()`.
...
Props mehulkaklotar for initial patch.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38128
git-svn-id: http://core.svn.wordpress.org/trunk@38069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 18:01:29 +00:00
Sergey Biryukov
6bcbeb858d
Docs: Correct and expand the docs for the `$post_type` argument of `wp_nav_menu_item_post_type_meta_box()`.
...
Props mehulkaklotar for initial patch.
See #37211 .
Built from https://develop.svn.wordpress.org/trunk@38127
git-svn-id: http://core.svn.wordpress.org/trunk@38068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 18:00:32 +00:00
Andrew Ozz
04319a7898
TinyMCE, link check:
...
- Use `wp.a11y.speak()` to announce bad URLs.
- Do not add a title to the link toolbar.
- Better error message.
Props afercia, azaozz.
See #36638 .
Built from https://develop.svn.wordpress.org/trunk@38126
git-svn-id: http://core.svn.wordpress.org/trunk@38067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-21 03:42:34 +00:00
Dominik Schilling
868804db15
Plugins: Improve Ajax search of new plugins.
...
Fixes a few accessibility issues, restores the "Search Results" tab and the search type selector, and improves compatibility with older browsers.
Props rahulsprajapati, swissspidy, adamsilverstein, ocean90
See #37233 .
Built from https://develop.svn.wordpress.org/trunk@38119
git-svn-id: http://core.svn.wordpress.org/trunk@38060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-20 16:32:31 +00:00
Joe McGill
3dbba0fff3
Post Thumbnails: Only update featured images when saving a post.
...
Previously, changing the post thumbnail of a published post in the edit screen
would immediately apply the change, rather than waiting for the post to be
saved before applying the update. This could lead to someone unintentionally
editing the post thumbnail on a published post, and made it impossible to
preview changes to post thumbnails on published posts before saving the change.
This introduces a new Ajax handler, `wp_ajax_get_post_thumbnail_html()` to
retrieve the HTML for the post thumbnail meta box without updating the post
meta value for `_thumbnail_id`. It also allows post thumbnail changes to be
previewed by passing the `_thumbnail_id` as a query variable to the preview
screen and adding a new filter, `_wp_preview_post_thumbnail_filter()`, which
gets applied to `get_post_metadata` during the post preview process.
Props flixos90.
Fixes #12922 .
Built from https://develop.svn.wordpress.org/trunk@38118
git-svn-id: http://core.svn.wordpress.org/trunk@38059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-20 16:24:28 +00:00
Mike Schroder
1736b7b29c
Media: Clean up prior image edits if `IMAGE_EDIT_OVERWRITE` is true.
...
When `IMAGE_EDIT_OVERWRITE` is set to true, edited image files are
supposed to be deleted when an image is restored to the original.
However, when an image was edited more than once, and then restored,
files created during previous edits were left behind.
Fixes this behavior by updating `wp_save_image()` to clean up
leftover images after each edit when `IMAGE_EDIT_OVERWRITE` is true.
Props bradt, chriscct7, joemcgill.
Fixes #32171 .
Built from https://develop.svn.wordpress.org/trunk@38113
git-svn-id: http://core.svn.wordpress.org/trunk@38054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-20 07:35:28 +00:00
Sergey Biryukov
6c7a60ffb4
Permalinks: In `wp_install_maybe_enable_pretty_permalinks()`:
...
* Use `get_page_by_path()` instead of a hardcoded ID, which may not always exist.
* Remove the "test against a random 404 page" part, which is no longer relevant after [34442].
Fixes #36628 .
Built from https://develop.svn.wordpress.org/trunk@38109
git-svn-id: http://core.svn.wordpress.org/trunk@38050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-19 23:12:32 +00:00
Dominik Schilling
f645178391
Filesystem API: Ensure memory limit calculations by PclZip are using integers.
...
This prevents a warning in PHP trunk, see https://wiki.php.net/rfc/invalid_strings_in_arithmetic .
See #36435 .
Built from https://develop.svn.wordpress.org/trunk@38101
git-svn-id: http://core.svn.wordpress.org/trunk@38042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-19 11:55:30 +00:00
Dominik Schilling
d59bcc98df
Filesystem API: Cleanup temporary file when the temporary file couldn't be opened.
...
Props ruud@joyo.
See #34772 .
Fixes #36942 , #36943 .
Built from https://develop.svn.wordpress.org/trunk@38094
git-svn-id: http://core.svn.wordpress.org/trunk@38035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-18 19:43:30 +00:00
Dominik Schilling
a320320ea0
Plugins: Use the correct admin screen when searching for plugins via Ajax.
...
Both list tables provide different actions based on where they are loaded, regular admin or network admin. Since there is only one Ajax handler for both screens we have to set the current screen before using the list tables.
Props swissspidy, ocean90.
Fixes #37373 .
Built from https://develop.svn.wordpress.org/trunk@38091
git-svn-id: http://core.svn.wordpress.org/trunk@38032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-18 14:00:34 +00:00
Andrea Fercia
bf24773fc6
Accessibility: Improve keyboard navigation on the themes browser modal window.
...
Improves the `containFocus()` function to always get the correct first and last
focusable elements, even when the theme browser shows the active theme details.
Also, when on the first and last theme, adds a `disabled` attribute on the
previous and next navigation buttons to make them not focusable.
Fixes #37383 .
Built from https://develop.svn.wordpress.org/trunk@38084
git-svn-id: http://core.svn.wordpress.org/trunk@38025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 22:19:30 +00:00
Sergey Biryukov
fd2d9ef63b
I18N: Remove non-translatable link attributes from translatable strings in `wp_plugin_update_row()`, `wp_theme_update_row()`, and `get_theme_update_available()`.
...
The resulting strings are much easier to translate.
See #36048 .
Built from https://develop.svn.wordpress.org/trunk@38082
git-svn-id: http://core.svn.wordpress.org/trunk@38023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 21:03:31 +00:00
Sergey Biryukov
2d19f94fac
Text Changes: Change `Network deactivate %s` to upper case, for consistency with `Network Activate %s`.
...
See #37290 .
Built from https://develop.svn.wordpress.org/trunk@38081
git-svn-id: http://core.svn.wordpress.org/trunk@38022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 17:04:32 +00:00
Sergey Biryukov
7d421dbe42
Text Changes: Add a full stop to "Invalid taxonomy" and "Invalid term ID" strings, for consistency with similar post-related messages.
...
See #18218 , #32329 .
Built from https://develop.svn.wordpress.org/trunk@38077
git-svn-id: http://core.svn.wordpress.org/trunk@38018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 16:15:34 +00:00
Sergey Biryukov
866bd39813
I18N: Combine two duplicate "Invalid post type" strings.
...
Props @ramiy.
See #18218 .
Built from https://develop.svn.wordpress.org/trunk@38076
git-svn-id: http://core.svn.wordpress.org/trunk@38017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 16:05:31 +00:00
Dominik Schilling
d5cb80dd7f
Import: Enhance accessibility on the Import screen.
...
* Remove title attributes.
* Show "Install Now" and "Details" links if the importer isn't installed yet.
* Show a "Run Importer" link if the importer is installed. It also handles activation if the plugin isn't activated.
* Add `aria-label` attributes to each link.
* Unify the importer descriptions to make them independent from the plugin state. The API was changed in [meta3690].
* Adjust JavaScript callbacks for ajaxified importer installs.
Props afercia, swissspidy, ocean90.
See #24766 .
Fixes #35191 .
Built from https://develop.svn.wordpress.org/trunk@38075
git-svn-id: http://core.svn.wordpress.org/trunk@38016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 15:32:30 +00:00
Sergey Biryukov
48f9940cfc
I18N: Change unnecessary uppercased words in `WP_Upgrader::generic_strings()` to lower case.
...
See #18218 .
Built from https://develop.svn.wordpress.org/trunk@38074
git-svn-id: http://core.svn.wordpress.org/trunk@38015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 13:29:29 +00:00
Sergey Biryukov
f429056194
I18N: Combine two duplicate "Unable to locate WordPress Theme directory" strings.
...
See #18218 .
Built from https://develop.svn.wordpress.org/trunk@38073
git-svn-id: http://core.svn.wordpress.org/trunk@38014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 12:58:28 +00:00
Sergey Biryukov
cbd59fdfd0
Text Changes: After [37297], replace two more instances of "WordPress.org Plugin Directory" with "WordPress Plugin Directory".
...
See #35938 .
Built from https://develop.svn.wordpress.org/trunk@38072
git-svn-id: http://core.svn.wordpress.org/trunk@38013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 12:50:43 +00:00
Sergey Biryukov
0be3a84ad0
I18N: After [38057], consistently use a context for other instances of `Activate %s`, `Network Activate %s`, and `Delete %s` strings.
...
See #37290 .
Built from https://develop.svn.wordpress.org/trunk@38071
git-svn-id: http://core.svn.wordpress.org/trunk@38012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 23:20:29 +00:00
Boone Gorges
40741408ec
On term.php, use `$taxnow` when fetching currently edited term.
...
[36874] changed the `get_term()` call so that no `$taxonomy` parameter
was passed, as 4.4 made the parameter optional. This change made it
impossible to access a shared term that has not yet been splitr, since
passing an ambiguous `$term_id` to `get_term()` results in an error.
Restoring the `$taxonomy` parameter fixes the regression.
Props alleynoah, dlh.
Fixes #37205 .
Built from https://develop.svn.wordpress.org/trunk@38069
git-svn-id: http://core.svn.wordpress.org/trunk@38010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 18:37:30 +00:00
Sergey Biryukov
5cce706f3d
Permalinks: Rename `$usingpi` to `$using_index_permalinks` for clarity.
...
See #37380 .
Built from https://develop.svn.wordpress.org/trunk@38067
git-svn-id: http://core.svn.wordpress.org/trunk@38008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 12:46:29 +00:00
Sergey Biryukov
07c9671cac
Permalinks: After [37747], make sure `$usingpi`, `$writable`, and `$update_required` are defined before checking them on permalinks update.
...
Props Clorith.
Fixes #37380 .
Built from https://develop.svn.wordpress.org/trunk@38066
git-svn-id: http://core.svn.wordpress.org/trunk@38007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 12:44:32 +00:00
Dominik Schilling
a8ccd1ce23
Users: Update help text for `user-new.php` to remove reference to sending passwords via email.
...
Props anneschmidt.
Fixes #36763 .
Built from https://develop.svn.wordpress.org/trunk@38064
git-svn-id: http://core.svn.wordpress.org/trunk@38005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-14 21:51:32 +00:00
Dominik Schilling
98d03cb738
Update/Install: Give context to some install/update strings to allow for differentiation between theme and plugin translations.
...
Props swissspidy, SergeyBiryukov.
Fixes #37290 .
Built from https://develop.svn.wordpress.org/trunk@38057
git-svn-id: http://core.svn.wordpress.org/trunk@37998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 17:32:29 +00:00
Drew Jaynes
60de6917fb
Docs: Add and clarify changelog entries for elements that can now accept, use, or return `WP_Post_Type` objects.
...
Also adds a missing initial `@since` version for `wp_xmlrpc_server::_prepare_post_type()`.
See [37890]. See #36217 .
Built from https://develop.svn.wordpress.org/trunk@38051
git-svn-id: http://core.svn.wordpress.org/trunk@37992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 15:24:28 +00:00
Dominik Schilling
c73c23c423
Resource Hints: Increase priority of `wp_resource_hints()` so hints get printed before scripts and styles.
...
Also run `wp_resource_hints()` on the login screen and in the customizer.
Props swissspidy.
Fixes #37317 .
Built from https://develop.svn.wordpress.org/trunk@38046
git-svn-id: http://core.svn.wordpress.org/trunk@37987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 12:54:28 +00:00
Andrew Ozz
532e8f0204
TinyMCE: preserve `<script>` and `<style>` tags inside the editor.
...
Uses image placeholders for the tags and makes then visible. That way the tags can also be deleted from inside the editor.
Props iseulde, azaozz.
Fixes #32923 .
Built from https://develop.svn.wordpress.org/trunk@38039
git-svn-id: http://core.svn.wordpress.org/trunk@37980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-12 22:09:31 +00:00
Pascal Birchler
e4eee7ef5c
Plugins: Improve Ajax search of installed plugins.
...
Fixes a few accessibility issues, tweaks the design of the search form to match other Ajax search fields and improves compatibility with older browsers.
See #37230 .
Built from https://develop.svn.wordpress.org/trunk@38033
git-svn-id: http://core.svn.wordpress.org/trunk@37974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-11 21:50:31 +00:00
Dominik Schilling
f8e7680cd6
Multisite: Use `hash_equals()` when comparing hashes to mitigate timing attacks.
...
Fixes #37324 .
Built from https://develop.svn.wordpress.org/trunk@38032
git-svn-id: http://core.svn.wordpress.org/trunk@37973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 19:43:28 +00:00
Dominik Schilling
02424959e4
Accessibility: Add `aria-button-if-js` class to links in the media list table that behave like buttons when JavaScript is on.
...
Props joedolson, afercia.
See #26504 .
Fixes #36555 .
Built from https://develop.svn.wordpress.org/trunk@38031
git-svn-id: http://core.svn.wordpress.org/trunk@37972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 19:31:31 +00:00
Drew Jaynes
31f150080a
Docs: Standardize references to "meta box" or "meta boxes" as two distinct words throughout core documentation per the core spelling guide.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@38029
git-svn-id: http://core.svn.wordpress.org/trunk@37970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 00:56:28 +00:00
Drew Jaynes
6c7148943b
Docs: Standardize capitalization of Ajax throughout core documentation per the core spelling guide.
...
Ajax, while considered an acronym for Asynchronous JavaScript and XML, is most commonly capitalized only in the first character.
Part props ocean90.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@38028
git-svn-id: http://core.svn.wordpress.org/trunk@37969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 00:51:30 +00:00
Dominik Schilling
559c6637bf
Docs: Fix a typo in the DocBlock for `themes_api()`, `themes_api`, `plugins_api()`, and `plugins_api`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@38025
git-svn-id: http://core.svn.wordpress.org/trunk@37966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 14:39:33 +00:00
Drew Jaynes
7eb6471461
Docs: Fix minor formatting and syntax for wp-admin/* elements introduced in 4.6.
...
See #37318 .
Built from https://develop.svn.wordpress.org/trunk@38024
git-svn-id: http://core.svn.wordpress.org/trunk@37965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 14:00:31 +00:00
Drew Jaynes
a13164355f
Docs: Cross-reference parent classes in DocBlocks for upgrader classes moved to their own files in 4.6
...
See #36618 . See #37318 .
Built from https://develop.svn.wordpress.org/trunk@38023
git-svn-id: http://core.svn.wordpress.org/trunk@37964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 13:45:33 +00:00
Drew Jaynes
2ee0027bc1
Docs: Improve usefulness of DocBlocks for ajax-actions.php functions introduced in 4.6.
...
See #37318 .
Built from https://develop.svn.wordpress.org/trunk@38022
git-svn-id: http://core.svn.wordpress.org/trunk@37963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 13:23:30 +00:00
Pascal Birchler
aa4334cc50
Upgrade/Install: Do not remove event handlers when trying to update a theme.
...
Previously, when clicking "Update now" the callbacks were erroneously removed. This prevented opening the filesystem credentials modal for a second time.
Fixes #37285 .
Built from https://develop.svn.wordpress.org/trunk@38019
git-svn-id: http://core.svn.wordpress.org/trunk@37960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-09 11:43:43 +00:00