Commit Graph

30 Commits

Author SHA1 Message Date
audrasjb 30a77d5fa4 i18n: Define List item separator as a WP_Locale property.
The list item separator is a locale property, and it doesn't make much sense to translate it separately in multiple projects. This changeset implements the following modifications:

- Define list item separator as a new WP_Locale property
- Add `wp_get_list_item_separator()` as a wrapper for `WP_Locale::get_list_item_separator`
- Replace `$wp_locale->get_list_item_separator()` calls with `wp_get_list_item_separator()`
- Added a compatibility layer for bundled themes

Props SergeyBiryukov, swissspidy, rsiddharth, johnbillion, audrasjb.
Fixes #39733.

Built from https://develop.svn.wordpress.org/trunk@52929


git-svn-id: http://core.svn.wordpress.org/trunk@52518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-03-13 20:03:01 +00:00
Sergey Biryukov 30b61fc9e8 Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.
Built from https://develop.svn.wordpress.org/trunk@47886


git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
Sergey Biryukov 7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast 28a8f31ffa Coding Standards: Add missing translator comments.
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Lance Willett 25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:50:11 +00:00
Lance Willett a738cc3c83 Bundled themes: remove `the_title_attribute()` title attributes where it duplicates `the_title()` in anchor text. Props nacin, fixes #24203.
git-svn-id: http://core.svn.wordpress.org/trunk@24131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 16:57:30 +00:00
Lance Willett 9886963778 Twenty Eleven: escape i18n attributes as late as possible, props mfields. See #21756.
git-svn-id: http://core.svn.wordpress.org/trunk@22199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 21:30:42 +00:00
Lance Willett bbfab9b4cb Twenty Eleven: show categories and tags only when supported by post type, using `is_object_in_taxonomy()` instead of only checking for 'post' post types. Props obenland, fixes #20922.
git-svn-id: http://core.svn.wordpress.org/trunk@22193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 19:53:35 +00:00
lancewillett 1f592e5cef Twenty Eleven: fix typo, s/#entry-meta/.entry-meta/ props zeo. See #21418.
git-svn-id: http://core.svn.wordpress.org/trunk@21368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 19:45:58 +00:00
nacin 0d9f4a7495 Twenty Eleven: Don't call comments_popup_link() if post_password_required(). That'll result in double password messages. props helenyhou, fixes #17962 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 17:58:43 +00:00
azaozz 1a50d6ee95 Simplify some Twenty-Eleven strings for i18n, props nbachiyski, fixes #17777
git-svn-id: http://svn.automattic.com/wordpress/trunk@18348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-27 20:24:23 +00:00
azaozz d41f756348 TwentyEleven Theme H1 Priority, props iandstewart, fixes #17611
git-svn-id: http://svn.automattic.com/wordpress/trunk@18335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-23 23:03:46 +00:00
dd32 ee1bb15914 Consistently wrap the "Pages:" text in <span> tags, Combine the 2 identical translations for the Pages text (one with, and one without, span tags). See #17744
git-svn-id: http://svn.automattic.com/wordpress/trunk@18312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-14 15:14:24 +00:00
dd32 27ec6b7e00 Remove debug comments & more housecleaning. See #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 03:44:42 +00:00
azaozz 3a29a3d893 Twenty Eleven code review and cleanup, props dd32, fixes #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 23:01:16 +00:00
nacin 53cd4287e1 Twenty Eleven: escaping frenzy, hide authors if a single author blog. props DH-Shredder, props iandstewart, see #17385, fixes #17563.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 21:57:18 +00:00
azaozz 853d1ab1a2 Implement rel="author" in Twenty Eleven and Twenty Ten, props joostdevalk, fixes #17722
git-svn-id: http://svn.automattic.com/wordpress/trunk@18189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-08 02:02:09 +00:00
iandstewart b8ef6fbbdf Twenty Eleven: prevent notices in taxonomy archives using custom post types; Props mfields; Fixes #17566
git-svn-id: http://svn.automattic.com/wordpress/trunk@18186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-08 01:30:18 +00:00
iandstewart ef03662627 Twenty Eleven: make categories and tags i18n friendly; Props dimadin; Fixes #17531
git-svn-id: http://svn.automattic.com/wordpress/trunk@18029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 15:19:33 +00:00
nacin 7f98b9beaf Fix Twenty Eleven phpdoc subpackage names. props zeo, fixes #17444.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 19:06:09 +00:00
nacin 7f16795c70 the_excerpt() doesn't take an argument. props coffee2code. fixes #17489. see #13883.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 17:26:40 +00:00
lancewillett ac33e2df00 Twenty Eleven updates and fixes, see #17198
* Add explanatory comments in all templates, following Twenty Ten's example
 * Stick with twentyeleven_ for prefixing filter names
 * Use post format content templates in search results
 * First pass at adding a template for adding a sidebar to pages
 * Add a featured post header to standard sticky posts
 * Style fixes: print media, comment styles for pages with sidebars, color of meta links on image post format

git-svn-id: http://svn.automattic.com/wordpress/trunk@17802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 22:54:50 +00:00
lancewillett 32fd5672a4 Twenty Eleven fixes - see #17198
* RTL tweaks and fixes
* Misc style fixes
* Fix tags output, comment links, and remove trailing spaces from translatable strings


git-svn-id: http://svn.automattic.com/wordpress/trunk@17791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 00:45:50 +00:00
iandstewart ff4d0e5249 Twenty Eleven: updated DocBlock comments following Twenty Ten's example; See #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-02 21:04:44 +00:00
lancewillett 972a41501e Twenty Eleven: strip trailing spaces, props kawauso - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:34:52 +00:00
matt 7d581043df Importing Duster theme, first pass at a candidate for twentyeleven theme.
Nice to have, but optional, improvements it'd be nice to have:

* Ability to have random rotating headers. (Core improvement to custom header functionality.)
* Color and layout options.
* More post formats. (Currently supporst  Asides, Links, and Galleries.)
* CMS-style slider home page option.

Welcome, TwentyEleven née Duster. :) Track at #17198.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 21:46:33 +00:00