Commit Graph

19 Commits

Author SHA1 Message Date
Sergey Biryukov 803426a023 Coding Standards: Use strict comparison in bundled themes' PHP files.
This addresses all the remaining WPCS warnings in bundled themes.

Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.

Follow-up to [41285], [44562], [47941].

Props aristath, poena, afercia, SergeyBiryukov.
See #56791.
Built from https://develop.svn.wordpress.org/trunk@55420


git-svn-id: http://core.svn.wordpress.org/trunk@54953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-24 06:23:23 +00:00
joedolson a3a61c5a3e General: Remove role="navigation" from nav elements.
Role="navigation" was required for assistive technology to recognize HTML5 element's native ARIA roles while HTML5 and ARIA were being introduced. With the deprecation of IE11, the role attribute is only required when mapping elements that don't have native role.

Props costdev, mukesh27.
Fixes #54054.
Built from https://develop.svn.wordpress.org/trunk@51967


git-svn-id: http://core.svn.wordpress.org/trunk@51556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-01 21:47:13 +00:00
Sergey Biryukov 4811dad603 I18N: Use consistent pattern for placeholder references in translator comments for some bundled theme strings.
Follow-up to [42827], [44562], [50234].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@51157


git-svn-id: http://core.svn.wordpress.org/trunk@50766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-15 15:38:57 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast c008959e9e Coding Standards: Fix the minor `WordPress.WP.I18n` violations.
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360.

See #45934.


Built from https://develop.svn.wordpress.org/trunk@44562


git-svn-id: http://core.svn.wordpress.org/trunk@44393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:04:49 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 4a9b21226c Twenty Twelve: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25521


git-svn-id: http://core.svn.wordpress.org/trunk@25441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:24:09 +00:00
Lance Willett e31f46e731 Twenty Twelve: remove extraneous comment. See #20469.
git-svn-id: http://core.svn.wordpress.org/trunk@22620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 22:04:57 +00:00
Lance Willett dee2ec4779 Twenty Twelve: better fix for #20469 and comments closed messages, also load the comments template in single.php template regardless of whether comments are open or closed (consistent with page.php). Both props kovshenin.
git-svn-id: http://core.svn.wordpress.org/trunk@22615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:28:47 +00:00
Lance Willett 29d5523b23 Twenty Twelve: better closed comments notes. Check only for "comment" type comments when deciding whether to show the message.
git-svn-id: http://core.svn.wordpress.org/trunk@22587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-15 00:43:43 +00:00
Lance Willett b3711fba97 Twenty Twelve: comments.php, cleanup and better indentation. Props obenland, see #21685.
git-svn-id: http://core.svn.wordpress.org/trunk@21621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 17:41:32 +00:00
lancewillett 1d9662043e Twenty Twelve: CSS and markup improvements for better child theme support, part 3. See #21379.
* Add classes like `.site` and `.site-content` in addition to the set of IDs already present, making things much better for child themes to have more than one generic element like `nav` inside the content container.
 * Bump JS version after selector change.
 * Move `image-attachment` to `post_class()` output

More exhaustive notes in the ticket on each id and class change.


git-svn-id: http://core.svn.wordpress.org/trunk@21404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 19:12:11 +00:00
nacin 741876a148 The Twenty Twelve for WordPress.
props drewstrojny, lancewillett.

also props corvannoorloos, jeffsebring, kobenland, iandstewart, mfields,
mtdesign, op12no2, philiparthurmoore, sixhours, mamaduka.

see #19978.



git-svn-id: http://core.svn.wordpress.org/trunk@21261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-12 04:20:46 +00:00
nacin edb6c96b9f Remove Twenty Twelve from 3.4. see #19978. see http://wp.me/pbNCB-yA.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 18:41:54 +00:00
lancewillett 240242aa06 Twenty Twelve: better comment markup and styles, props drewstrojny. See #19978.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 05:24:57 +00:00
lancewillett 02ea26c01f Twenty Twelve: add ARIA role of "navigation" to the all nav elements. Props iandstewart, see #19978.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 06:34:36 +00:00
matt a577a1faf8 Initial import of the Twenty Twelve theme, by Drew Strojny. This time around we're trying something different than the previous twenty-something themes, a much more minimalist approach that affords easy use as a CMS in addition to being blog-forward. More information will be on wpdevel soon. Props drewstrojny and lancewillett.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-06 22:23:41 +00:00