Scott Taylor
aef35fe6a2
Eliminate use of `extract()` in `WP_List_Table::pagination()`:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28389
git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:27:14 +00:00
Scott Taylor
530a107ec9
Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28388
git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:17:14 +00:00
Scott Taylor
192e235672
Eliminate use of `extract()` in `WP_List_Table::ajax_response()`:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28387
git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:14:14 +00:00
Scott Taylor
08d73b9e23
Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28386
git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:08:13 +00:00
Scott Taylor
f617b8669a
Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28385
git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:04:14 +00:00
Scott Taylor
6bbc5b570c
Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass.
...
Props MikeHansenMe.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28374
git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 03:27:13 +00:00
Scott Taylor
2bea9fcc0b
In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
Built from https://develop.svn.wordpress.org/trunk@28368
git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
Scott Taylor
88b96dc036
In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty.
...
Props SergeyBiryukov.
Fixes #23706 .
Built from https://develop.svn.wordpress.org/trunk@28367
git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 05:54:15 +00:00
Scott Taylor
e9f87b2688
Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it.
...
Props MikeHansenMe.
Fixes #17736 .
Built from https://develop.svn.wordpress.org/trunk@28366
git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 03:42:14 +00:00
Scott Taylor
0b6729c3f9
In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`).
...
Props oso96_2000, c3mdigital, scribu.
It takes a village.
Fixes #16864 .
Built from https://develop.svn.wordpress.org/trunk@28360
git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:05:15 +00:00
Scott Taylor
f22beb987c
First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
Built from https://develop.svn.wordpress.org/trunk@28358
git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:36:18 +00:00
Drew Jaynes
81cfb9427a
Fix mid-file section header style in wp-admin/includes/ajax-actions.php.
...
See #28200 .
Built from https://develop.svn.wordpress.org/trunk@28356
git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:02:13 +00:00
Drew Jaynes
0ef7244ce7
Add baseline doc blocks for all ajax handlers in ajax-actions.php.
...
Fixes #28200 .
Built from https://develop.svn.wordpress.org/trunk@28355
git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:00:19 +00:00
Drew Jaynes
f609524261
Minor phpDoc fixes for the `got_rewrite`, `got_url_rewrite`, and `documentation_ignore_functions` hooks.
...
Props GaryJ.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28352
git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:13:14 +00:00
Drew Jaynes
32e674f44e
Use interpolation instead of concatenation for the `manage_{$screen->id}_columns` hook name.
...
Props Otto42.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28348
git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 09:58:14 +00:00
Drew Jaynes
8906f83802
Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly.
...
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.
Props Otto42 for the initial patch.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28347
git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 08:16:15 +00:00
Scott Taylor
1daa7d6723
Leverage `size_format()` when displaying `max_upload_size`:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
Built from https://develop.svn.wordpress.org/trunk@28343
git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor
c2d44c5736
In `wp-admin/includes/upgrade.php`, remove dead code:
...
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28305
git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:27:15 +00:00
Scott Taylor
aaa3eb07ad
In `wp-admin/includes/update.php`, remove dead code:
...
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28304
git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:21:14 +00:00
Scott Taylor
b80cda5d17
In `WP_Screen::render_screen_options()`, remove dead code:
...
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28303
git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:14:15 +00:00
Scott Taylor
2e417f0ca4
In `get_sample_permalink_html()`, `$view_link` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28302
git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:11:14 +00:00
Scott Taylor
44e2d48a3c
In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28301
git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:00:18 +00:00
Scott Taylor
e57fa7300d
In `wp-admin/includes/nav-menu.php`, remove dead code:
...
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it.
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28300
git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:55:14 +00:00
Scott Taylor
85bdc64173
In `update_option_new_admin_email()`, `$email` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28299
git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:48:14 +00:00
Scott Taylor
6066f85853
In `attachment_submit_meta_box()`, remove dead code:
...
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28298
git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:45:14 +00:00
Scott Taylor
71ac0f21c2
In `get_media_item()`, `$tags` and `$_tags` are set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28297
git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
Scott Taylor
3054b924a3
In `WP_Users_List_Table::get_views()`, `$current_role` is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28296
git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:33:15 +00:00
Scott Taylor
209f008d77
In `WP_MS_Users_List_Table::get_views()`, remove dead code:
...
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28295
git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:30:14 +00:00
Scott Taylor
970477d25e
In `WP_Media_List_Table`, remove dead code:
...
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28293
git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:33 +00:00
Scott Taylor
28d98a89f3
In `ajax-actions.php`, remove dead code:
...
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28292
git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:19:14 +00:00
Sergey Biryukov
527a1ea6e3
Use a consistent context to remove duplicate strings.
...
props pavelevap.
fixes #28123 .
Built from https://develop.svn.wordpress.org/trunk@28287
git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:34:14 +00:00
Scott Taylor
ded4871368
In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28279
git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:15 +00:00
Scott Taylor
dd73ad4299
In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28271
git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
Scott Taylor
644024dfc4
Dead code in `wp-admin/includes/file.php`:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28268
git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:22:14 +00:00
Scott Taylor
3d7a4e6798
Remove unused variable setting for `$revisions` in `wp_prepare_revisions_for_js()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28264
git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:45:14 +00:00
Scott Taylor
21379dcde0
Remove a dead variable, `$start`, from `wp_dashboard_recent_comments()`.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28263
git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:35:14 +00:00
Andrew Nacin
f44e4226fa
Move 'home' option to the top of populate_options().
...
fixes #28141 .
Built from https://develop.svn.wordpress.org/trunk@28260
git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 21:57:14 +00:00
Sergey Biryukov
751e624ff7
Deprecate unused argument of delete_plugins(). Clarify @return value.
...
props jdgrimes for initial patch.
fixes #28111 .
Built from https://develop.svn.wordpress.org/trunk@28256
git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:24:15 +00:00
Sergey Biryukov
997cbaa03c
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
Built from https://develop.svn.wordpress.org/trunk@28253
git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 08:26:24 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
Drew Jaynes
029dd247be
Ensure the `wp_edit_nav_menu_walker` filter is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28213
git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:50:15 +00:00
Drew Jaynes
a9b74e2088
Ensure the `nav_menu_meta_box_object` filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28207
git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:14:15 +00:00
Andrew Nacin
b89775445e
Theme Installer: Proper redirection and action links post-install in multisite.
...
fixes #27869 .
Built from https://develop.svn.wordpress.org/trunk@28163
git-svn-id: http://core.svn.wordpress.org/trunk@27994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:18:16 +00:00
Andrew Nacin
2bc282957c
Translate a string added in 3.7.1 but never translated previously.
...
props SergeyBiryukov.
fixes #27819 .
Built from https://develop.svn.wordpress.org/trunk@28145
git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:38:14 +00:00
Dion Hulse
ca0b5c9859
Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815
...
Built from https://develop.svn.wordpress.org/trunk@28137
git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 10:57:14 +00:00
Andrew Nacin
fa3900168e
Allow the API to add text to auto update emails.
...
fixes #27812 .
Built from https://develop.svn.wordpress.org/trunk@28134
git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 08:52:15 +00:00
Andrew Nacin
9f81d0526e
Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
...
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639 , #27581 , #27055 ).
A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.
props ocean90.
fixes #27798 .
Built from https://develop.svn.wordpress.org/trunk@28126
git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:16:14 +00:00
Andrew Nacin
cb4eb9c13f
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
Reverts [27990] which did not fix it for authors and comment/ping status.
props dd32, DrewAPicture.
fixes #27792 .
Built from https://develop.svn.wordpress.org/trunk@28113
git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 07:48:14 +00:00
Andrew Ozz
c9f5ed0801
Plupload: restore the settings in media_upload_form(), see #27763
...
Built from https://develop.svn.wordpress.org/trunk@28110
git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:41:15 +00:00
Andrew Nacin
55b0cd935e
Fix feature pointer RTL placement.
...
props SergeyBiryukov, ocean90.
fixes #27778 .
Built from https://develop.svn.wordpress.org/trunk@28107
git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:00:14 +00:00
Andrew Nacin
eca26bc5ae
The widgets pointer requires the edit_theme_options capability.
...
(It's hypothetically possible to have only switch_themes.)
see #27777 .
Built from https://develop.svn.wordpress.org/trunk@28093
git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 20:53:15 +00:00
Andrew Nacin
497b0df4a5
Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4.
...
see #27777 .
Built from https://develop.svn.wordpress.org/trunk@28090
git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 20:48:15 +00:00
Andrew Nacin
c87ac82d7b
Update $_old_files for 3.9. see #27775 .
...
Built from https://develop.svn.wordpress.org/trunk@28085
git-svn-id: http://core.svn.wordpress.org/trunk@27916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 18:27:17 +00:00
Drew Jaynes
5e51ea9940
Priority fixes for various existing hook documentation.
...
Props kpdesign.
See #26869
Built from https://develop.svn.wordpress.org/trunk@28083
git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Andrew Nacin
51412f2e9b
Account for new cropping settings in the image editor.
...
props Otto42, SergeyBiryukov.
fixes #19393 .
Built from https://develop.svn.wordpress.org/trunk@28072
git-svn-id: http://core.svn.wordpress.org/trunk@27903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 03:10:14 +00:00
Drew Jaynes
252a5434ff
Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php.
...
Fixes #27711 .
Built from https://develop.svn.wordpress.org/trunk@28040
git-svn-id: http://core.svn.wordpress.org/trunk@27870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 06:26:16 +00:00
Andrew Nacin
e7fc009f7c
Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns.
...
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@28037
git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:30:15 +00:00
Drew Jaynes
f6df2c6921
Use the correct parameter variables in the hook docs for `wp_upgrade`.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27998
git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:13:15 +00:00
Drew Jaynes
181fe84d47
Align parameters in the hook docs for the `attachment_thumbnail_args` filter.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27997
git-svn-id: http://core.svn.wordpress.org/trunk@27827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:10:16 +00:00
Drew Jaynes
bf75eebfa7
Add missing parameter descriptions to the PHPDocs for `WP_Upgrader_Skin::decrement_update_count()` and `Bulk_Upgrader_Skin::decrement_update_count()`.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@27996
git-svn-id: http://core.svn.wordpress.org/trunk@27826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:02:15 +00:00
Andrew Nacin
2d710c6fad
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
props kovshenin.
see [27964], see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27990
git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 17:59:14 +00:00
Andrew Nacin
2f80a1c72f
Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation.
...
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27975
git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 22:08:15 +00:00
Drew Jaynes
a11553eafe
Inline documentation for remaining hooks in wp-admin/includes/upgrade.php.
...
Props jackreichert, vancoder.
Fixes #27646 .
Built from https://develop.svn.wordpress.org/trunk@27965
git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 22:30:14 +00:00
Andrew Nacin
1ec9b44673
Better checks for contributors when saving posts.
...
props dd32, kovshenin, plocha.
see #27452 .
Built from https://develop.svn.wordpress.org/trunk@27964
git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 21:19:14 +00:00
Sergey Biryukov
b48021f65f
Clarify tooltips on Edit Image screen.
...
props siobhan.
fixes #27651 .
Built from https://develop.svn.wordpress.org/trunk@27939
git-svn-id: http://core.svn.wordpress.org/trunk@27769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:03:28 +00:00
Sergey Biryukov
2cb849fc52
Fix typo in verify_file_md5() description. see [25541].
...
props siobhan.
see #27651 .
Built from https://develop.svn.wordpress.org/trunk@27938
git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:03:14 +00:00
Sergey Biryukov
f8c39d6186
Use multiplication sign instead of a colon for selection size when editing an image.
...
props siobhan.
fixes #27652 .
Built from https://develop.svn.wordpress.org/trunk@27931
git-svn-id: http://core.svn.wordpress.org/trunk@27761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 09:46:17 +00:00
Andrew Nacin
803d4ff54d
Remove old links_recently_updated_* DB options that never had a UI.
...
fixes #27649 .
Built from https://develop.svn.wordpress.org/trunk@27916
git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 03:10:15 +00:00
Dion Hulse
50a7503c2e
Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633
...
Built from https://develop.svn.wordpress.org/trunk@27905
git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 13:05:15 +00:00
Drew Jaynes
4af2840a47
Clarify PHPDoc return description for `media_handle_upload()`.
...
Props jdgrimes.
Fixes #27519 .
Built from https://develop.svn.wordpress.org/trunk@27880
git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 22:33:15 +00:00
Scott Taylor
01d2062af3
Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
...
Props nacin.
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27869
git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
Andrew Nacin
8acf74fe7b
Use correct formatting function. see [27864], see #27574 .
...
Built from https://develop.svn.wordpress.org/trunk@27866
git-svn-id: http://core.svn.wordpress.org/trunk@27697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 22:12:29 +00:00
Andrew Nacin
c95f232727
Cleanups for audio/video metadata, see [27862].
...
see #27574 .
Built from https://develop.svn.wordpress.org/trunk@27864
git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 21:08:14 +00:00
Scott Taylor
7eb24edf4e
In `wp_generate_attachment_metadata()`, when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a `_cover_hash` value in post meta that matches the `md5` representation of the bits.
...
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.
Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573 .
Built from https://develop.svn.wordpress.org/trunk@27863
git-svn-id: http://core.svn.wordpress.org/trunk@27694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 20:54:15 +00:00
Scott Taylor
d947a55495
Metadata for audio and video files:
...
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27862
git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 19:28:16 +00:00
Andrew Nacin
3c1cdaa362
Restyle the image editor so it looks way less hideous.
...
props avryl.
see #27544 .
Built from https://develop.svn.wordpress.org/trunk@27842
git-svn-id: http://core.svn.wordpress.org/trunk@27676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-29 08:51:14 +00:00
Drew Jaynes
5613b40981
The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates.
...
See #25374 , #25501 , #27531 .
Built from https://develop.svn.wordpress.org/trunk@27823
git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 19:47:15 +00:00
Dominik Schilling
c707faa639
Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets.
...
see #27504 .
props westonruter.
Built from https://develop.svn.wordpress.org/trunk@27816
git-svn-id: http://core.svn.wordpress.org/trunk@27650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 14:07:14 +00:00
Andrew Nacin
c3ca81ba94
Always decode special characters for email subjects.
...
props tlovett1, jeremyfelt.
fixes #25346 .
Built from https://develop.svn.wordpress.org/trunk@27801
git-svn-id: http://core.svn.wordpress.org/trunk@27636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 02:44:15 +00:00
Andrew Nacin
bec78b5e11
Proper IDs for the custom fields box.
...
props SergeyBiryukov.
fixes #14376 .
Built from https://develop.svn.wordpress.org/trunk@27776
git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 06:56:14 +00:00
Andrew Nacin
f9964e361c
Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189 , #27188 .
...
Built from https://develop.svn.wordpress.org/trunk@27769
git-svn-id: http://core.svn.wordpress.org/trunk@27606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:02:14 +00:00
Scott Taylor
fd0e34ec9f
The bulk editor and post format meta box should use the same checks for available post formats.
...
Props eightface.
Fixes #27187 .
Built from https://develop.svn.wordpress.org/trunk@27762
git-svn-id: http://core.svn.wordpress.org/trunk@27599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 00:06:15 +00:00
Andrew Nacin
b5d0471fef
Merge some theme update strings.
...
props pavelevap, yoavf.
fixes #25083 .
Built from https://develop.svn.wordpress.org/trunk@27748
git-svn-id: http://core.svn.wordpress.org/trunk@27585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 20:08:15 +00:00
Andrew Nacin
2fd8b60c22
Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon.
...
props aubreypwd.
fixes #24741 .
Built from https://develop.svn.wordpress.org/trunk@27747
git-svn-id: http://core.svn.wordpress.org/trunk@27584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 18:53:15 +00:00
Andrew Nacin
8c3925760f
Upgrader skins: Strip tags before displaying error data.
...
fixes #25394 .
Built from https://develop.svn.wordpress.org/trunk@27737
git-svn-id: http://core.svn.wordpress.org/trunk@27574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 14:39:16 +00:00
Andrew Nacin
dd70d0e30b
Don't allow the image editor thumbnail to be dragged. see #21811 .
...
Built from https://develop.svn.wordpress.org/trunk@27712
git-svn-id: http://core.svn.wordpress.org/trunk@27551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 16:21:16 +00:00
Andrew Nacin
fbd1443a0b
Restore the update message in the dashboard, removed in 3.8.
...
props obenland.
fixes #26664 .
Built from https://develop.svn.wordpress.org/trunk@27711
git-svn-id: http://core.svn.wordpress.org/trunk@27550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 14:36:15 +00:00
Andrew Nacin
156a5a234f
Multisite: Don't set the $super_admins global in grant_super_admin(), revoke_super_admin().
...
Adds tests and docs.
props jdgrimes.
see #27205 .
Built from https://develop.svn.wordpress.org/trunk@27706
git-svn-id: http://core.svn.wordpress.org/trunk@27545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 12:14:14 +00:00
Drew Jaynes
7dc9b02577
Correct misleading verbiage in 'print' hook docs.
...
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.
Props ericlewis for the initial patch.
Fixes #26924 .
Built from https://develop.svn.wordpress.org/trunk@27695
git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 08:05:15 +00:00
Scott Taylor
4eadc109f8
In `wp_create_post_autosave()`, intersect the `$new_autosave`'s keys with the keys from `_wp_post_revision_fields()` to ensure that all expected fields are present.
...
Props kovshenin.
Fixes #25416 .
Built from https://develop.svn.wordpress.org/trunk@27690
git-svn-id: http://core.svn.wordpress.org/trunk@27529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 20:32:14 +00:00
Andrew Nacin
c08ff58b13
Plugin Installer: Disable 'Latest Version Installed' buttons.
...
props paulwilde.
see #26952 .
Built from https://develop.svn.wordpress.org/trunk@27677
git-svn-id: http://core.svn.wordpress.org/trunk@27520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:41:15 +00:00
Andrew Nacin
9babc32900
Use correct variable. see [27373].
...
props TobiasBg.
fixes #14424 .
Built from https://develop.svn.wordpress.org/trunk@27675
git-svn-id: http://core.svn.wordpress.org/trunk@27518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:25:16 +00:00
Drew Jaynes
cb58f19135
Inline documentation for hooks in wp-admin/includes/taxonomy.php.
...
Props kpdesign for the initial patch.
Fixes #27433 .
Built from https://develop.svn.wordpress.org/trunk@27674
git-svn-id: http://core.svn.wordpress.org/trunk@27517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:14:15 +00:00
Drew Jaynes
0cee31065e
Inline documentation for wp-admin/includes/class-wp-upgrader.php.
...
Props kpdesign for some minor cleanup.
Fixes #27436 .
Built from https://develop.svn.wordpress.org/trunk@27673
git-svn-id: http://core.svn.wordpress.org/trunk@27516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:00:15 +00:00
Drew Jaynes
8efd225e4d
Inline documentation for hooks in wp-admin/includes/file.php.
...
Fixes #27429 .
Built from https://develop.svn.wordpress.org/trunk@27672
git-svn-id: http://core.svn.wordpress.org/trunk@27515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:45:15 +00:00
Drew Jaynes
b4903834cf
Remove some debug cruft accidentally committed in [27670].
...
See #27430 .
Built from https://develop.svn.wordpress.org/trunk@27671
git-svn-id: http://core.svn.wordpress.org/trunk@27514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:38:17 +00:00
Drew Jaynes
1a0881f341
Inline documentation for hooks in wp-admin/includes/menu.php.
...
Also fixes syntax for a few unrelated multi-line comments in the file.
Props kpdesign for some minor cleanup.
Fixes #27430 .
Built from https://develop.svn.wordpress.org/trunk@27670
git-svn-id: http://core.svn.wordpress.org/trunk@27513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:35:14 +00:00
Drew Jaynes
0b8798684b
Inline documentation for hooks in wp-admin/includes/dashboard.php.
...
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752 .
Built from https://develop.svn.wordpress.org/trunk@27669
git-svn-id: http://core.svn.wordpress.org/trunk@27512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:21:15 +00:00
Drew Jaynes
155746131f
Inline documentation for hooks in wp-admin/includes/post.php.
...
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.
Props kpdesign for some cleanup.
Fixes #27431 .
Built from https://develop.svn.wordpress.org/trunk@27667
git-svn-id: http://core.svn.wordpress.org/trunk@27510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 01:49:14 +00:00
Andrew Ozz
69b74a75cd
Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle.
...
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.
Built from https://develop.svn.wordpress.org/trunk@27662
git-svn-id: http://core.svn.wordpress.org/trunk@27505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-23 23:45:19 +00:00
Scott Taylor
38d1fb971f
Turn on thumbnail support for `attachment:audio` and `attachment:video`. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.
...
Fixes #27460 .
Built from https://develop.svn.wordpress.org/trunk@27657
git-svn-id: http://core.svn.wordpress.org/trunk@27500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-23 02:35:14 +00:00
Dominik Schilling
d1f3abe55c
Remove "Show" prefix from filter dropdowns, see #26743 .
...
Built from https://develop.svn.wordpress.org/trunk@27626
git-svn-id: http://core.svn.wordpress.org/trunk@27469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 22:13:14 +00:00
Andrew Nacin
111e6a73be
Skipping placeholders in a string will only catch translators off guard.
...
see #27453 , #27132 .
Built from https://develop.svn.wordpress.org/trunk@27613
git-svn-id: http://core.svn.wordpress.org/trunk@27456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:53:14 +00:00
Andrew Nacin
ecab3c3535
Remove two new strings from post_preview().
...
see #25272 , #27453 .
Built from https://develop.svn.wordpress.org/trunk@27612
git-svn-id: http://core.svn.wordpress.org/trunk@27455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:49:14 +00:00
Andrew Nacin
064f3d7191
Improve the autosave error message on nonce failure.
...
see #27453 , #25272 .
Built from https://develop.svn.wordpress.org/trunk@27611
git-svn-id: http://core.svn.wordpress.org/trunk@27454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:47:22 +00:00
John Blackbourn
80fe1b0e79
Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132 . Props mattheu.
...
Built from https://develop.svn.wordpress.org/trunk@27596
git-svn-id: http://core.svn.wordpress.org/trunk@27439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:44:27 +00:00
John Blackbourn
181c2d091e
Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614 .
...
Built from https://develop.svn.wordpress.org/trunk@27583
git-svn-id: http://core.svn.wordpress.org/trunk@27426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 12:56:14 +00:00
Andrew Nacin
b0188044a2
Heartbeat: Hooks should always receive unslashed data.
...
This affects the privileged hooks; the unprivileged hooks already received unslashed data.
props johnbillion, TobiasBg.
fixes #27260 .
Built from https://develop.svn.wordpress.org/trunk@27576
git-svn-id: http://core.svn.wordpress.org/trunk@27419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 00:15:15 +00:00
Andrew Nacin
3c3e9a530b
Filesystem: Fix getchmod() for direct and ssh2 transports, for directories.
...
props DavidAnderson.
fixes #26598 .
Built from https://develop.svn.wordpress.org/trunk@27566
git-svn-id: http://core.svn.wordpress.org/trunk@27409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 20:17:15 +00:00
Andrew Nacin
6c03a28512
Cap and theme support checks for the welcome panel.
...
props MikeHansenMe.
fixes #26276 .
Built from https://develop.svn.wordpress.org/trunk@27563
git-svn-id: http://core.svn.wordpress.org/trunk@27406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 19:47:15 +00:00
Sergey Biryukov
bfef727df3
Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
...
props wpsmith.
fixes #27439 .
Built from https://develop.svn.wordpress.org/trunk@27560
git-svn-id: http://core.svn.wordpress.org/trunk@27403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 15:33:15 +00:00
Andrew Ozz
513b6992e5
Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952
...
Built from https://develop.svn.wordpress.org/trunk@27559
git-svn-id: http://core.svn.wordpress.org/trunk@27402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-16 18:28:17 +00:00
Sergey Biryukov
ab03c0db64
Fix .comment-grey-bubble markup and remove a stray </h5> tag.
...
props avryl.
fixes #27408 .
Built from https://develop.svn.wordpress.org/trunk@27548
git-svn-id: http://core.svn.wordpress.org/trunk@27391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 04:32:15 +00:00
Dion Hulse
87c6791a41
WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265
...
Built from https://develop.svn.wordpress.org/trunk@27546
git-svn-id: http://core.svn.wordpress.org/trunk@27389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 03:09:16 +00:00
Dominik Schilling
f46a085f7c
Widget Customizer: Use ?wp_customize=on.
...
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.
props westonruter.
fixes #27291 .
Built from https://develop.svn.wordpress.org/trunk@27524
git-svn-id: http://core.svn.wordpress.org/trunk@27367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 18:38:14 +00:00
Scott Taylor
00e63d2d2c
The Image Editor should apply changes to custom image sizes by checking `$_wp_additional_image_sizes` for `$size` in `wp_save_image()` before arbitrarily going to the options table.
...
Props Otto42, SergeyBiryukov.
Fixes #19889 .
Built from https://develop.svn.wordpress.org/trunk@27522
git-svn-id: http://core.svn.wordpress.org/trunk@27365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 04:18:14 +00:00
John Blackbourn
cc7f0b61ec
Correct the "View Post" button link when changing a post slug. Fixes #16477 . Props aubreypwd.
...
Built from https://develop.svn.wordpress.org/trunk@27508
git-svn-id: http://core.svn.wordpress.org/trunk@27351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 23:00:16 +00:00
John Blackbourn
75b86ecfb0
Avoid searching HTML tags when searching plugins and themes. Fixes #27136 . Props enej.
...
Built from https://develop.svn.wordpress.org/trunk@27507
git-svn-id: http://core.svn.wordpress.org/trunk@27350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 22:24:15 +00:00
Sergey Biryukov
f29df4f74c
Remove duplicate description of WP_List_Table class.
...
props bravokeyl.
fixes #27346 .
Built from https://develop.svn.wordpress.org/trunk@27502
git-svn-id: http://core.svn.wordpress.org/trunk@27345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 16:23:15 +00:00
Andrew Nacin
fe260c6a15
Assign correct variable.
...
props nendeb55.
fixes #27351 . see #14424 , [27373].
Built from https://develop.svn.wordpress.org/trunk@27501
git-svn-id: http://core.svn.wordpress.org/trunk@27344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 13:24:14 +00:00
Andrew Nacin
9aca2a65f8
Bring the theme browsing experience from 3.8 to the theme installer. First pass.
...
props matveb with assists from me and gcorne.
see #27055 .
Built from https://develop.svn.wordpress.org/trunk@27499
git-svn-id: http://core.svn.wordpress.org/trunk@27341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 07:47:15 +00:00
Drew Jaynes
a271ca696b
Fix docs for the `deactivate_$plugin` and `deactivated_plugin` hooks.
...
Props wpsmith for the original patch.
Fixes #27189
Built from https://develop.svn.wordpress.org/trunk@27491
git-svn-id: http://core.svn.wordpress.org/trunk@27335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-10 21:34:17 +00:00
Andrew Nacin
de769c267f
Editor: Show 'View Post' for any post the author can read.
...
This expands it to private posts and matches the logic in the toolbar.
props mordauk, SergeyBiryukov.
fixes #27059 .
Built from https://develop.svn.wordpress.org/trunk@27483
git-svn-id: http://core.svn.wordpress.org/trunk@27327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 13:53:14 +00:00
Dominik Schilling
3e356d7bdf
Admin Menu: Set default value of `$icon_url` in `add_menu_page()` to `dashicons-admin-generic`, fixes #26630 .
...
Built from https://develop.svn.wordpress.org/trunk@27482
git-svn-id: http://core.svn.wordpress.org/trunk@27326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-09 11:13:13 +00:00
Andrew Nacin
fabb6d4898
Allow $crop in add_image_size() to receive crop anchors (top, left, right, bottom, center).
...
This also applies to set_post_thumbnail_size() and image_resize_dimensions().
props bradt, wonderboymusic, DH-Shredder.
fixes #19393 .
Built from https://develop.svn.wordpress.org/trunk@27472
git-svn-id: http://core.svn.wordpress.org/trunk@27317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 06:14:15 +00:00
Andrew Nacin
17ccbc86c9
Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context.
...
see #13265 .
Built from https://develop.svn.wordpress.org/trunk@27470
git-svn-id: http://core.svn.wordpress.org/trunk@27315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:19:16 +00:00
Andrew Nacin
edfe443afc
Remove lame debugging. see #23057 .
...
Built from https://develop.svn.wordpress.org/trunk@27467
git-svn-id: http://core.svn.wordpress.org/trunk@27312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 03:16:27 +00:00
Andrew Nacin
60953e88fd
Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values.
...
fixes #23057 .
Built from https://develop.svn.wordpress.org/trunk@27466
git-svn-id: http://core.svn.wordpress.org/trunk@27311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 03:16:14 +00:00
Sergey Biryukov
0a0589414e
Fix docblock formatting in [27462]. see #23057 .
...
Built from https://develop.svn.wordpress.org/trunk@27463
git-svn-id: http://core.svn.wordpress.org/trunk@27308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 01:26:13 +00:00
Sergey Biryukov
9c6504120f
Pass $reassign parameter to 'delete_user' and 'deleted_user' actions.
...
props genkisan.
fixes #23057 .
Built from https://develop.svn.wordpress.org/trunk@27462
git-svn-id: http://core.svn.wordpress.org/trunk@27307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 01:23:15 +00:00
Andrew Nacin
449ffedfb9
maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata().
...
props kovshenin.
fixes #26825 .
Built from https://develop.svn.wordpress.org/trunk@27441
git-svn-id: http://core.svn.wordpress.org/trunk@27288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 19:34:14 +00:00
Drew Jaynes
c64dc20146
Inline documentation for hooks in wp-admin/includes/class-wp-theme-install-list-table.php.
...
Props kpdesign for the cleanup.
Fixes #27293 .
Built from https://develop.svn.wordpress.org/trunk@27430
git-svn-id: http://core.svn.wordpress.org/trunk@27277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 13:44:14 +00:00
Andrew Nacin
e853a9cc57
Add widget management to the customizer.
...
This brings in the Widget Customizer plugin: https://wordpress.org/plugins/widget-customizer/ .
props westonruter, shaunandrews, michael-arestad, johnregan3, akeda, topher1kenobe, topquarky, bobbravo2, ricardocorreia. And for good measure, props westonruter.
see #27112 .
Built from https://develop.svn.wordpress.org/trunk@27419
git-svn-id: http://core.svn.wordpress.org/trunk@27266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 20:41:14 +00:00
Andrew Nacin
39fcb291fe
Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata().
...
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.
see #25272 .
Built from https://develop.svn.wordpress.org/trunk@27405
git-svn-id: http://core.svn.wordpress.org/trunk@27252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 06:26:14 +00:00
Andrew Ozz
7121bb490d
Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952 .
...
Built from https://develop.svn.wordpress.org/trunk@27403
git-svn-id: http://core.svn.wordpress.org/trunk@27250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 03:54:15 +00:00
Andrew Ozz
19efb78b48
Restyles the modal for attaching media to posts, props avryl, see #26952
...
Built from https://develop.svn.wordpress.org/trunk@27401
git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-04 23:11:13 +00:00
Andrew Nacin
2c68373c83
Convert the post lock icon to a dashicon.
...
props melchoyce, DH-Shredder.
fixes #26796 .
Built from https://develop.svn.wordpress.org/trunk@27392
git-svn-id: http://core.svn.wordpress.org/trunk@27240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-04 06:53:14 +00:00
Dominik Schilling
00f224624e
"At a Glance" widget: Move `get_avatar()` line out of if-block.
...
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.
props zodiac1978.
fixes #26944 .
Built from https://develop.svn.wordpress.org/trunk@27384
git-svn-id: http://core.svn.wordpress.org/trunk@27232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 20:14:14 +00:00
Drew Jaynes
690481f8e8
Generalize the hook documentation for the `set-screen-option` filter.
...
The filter covers more than [items]_per_page screen options.
Fixes #26186 .
Built from https://develop.svn.wordpress.org/trunk@27379
git-svn-id: http://core.svn.wordpress.org/trunk@27228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 17:51:14 +00:00
Drew Jaynes
849ce35cb9
Inline documentation for hooks in wp-admin/includes/misc.php.
...
Props JoshuaAbenazer.
Fixes #26186
Built from https://develop.svn.wordpress.org/trunk@27375
git-svn-id: http://core.svn.wordpress.org/trunk@27224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 17:20:16 +00:00
Andrew Nacin
cc7a2e29f5
Slight renaming in our callback in [27373]. see #14424 .
...
Built from https://develop.svn.wordpress.org/trunk@27374
git-svn-id: http://core.svn.wordpress.org/trunk@27223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 17:09:14 +00:00
Mark Jaquith
fb56a9942b
Eliminate some of our last remaining `create_function()` instances
...
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore
props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373
git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 16:21:16 +00:00
Andrew Nacin
0c16c0477b
Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
...
props Ipstenu, markjaquith.
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@27369
git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:27 +00:00
Andrew Nacin
ffc4ca7b01
Introduce get_site_by_path() and further rewrite the site detection process for multisite.
...
This is the first big step to supporting arbitrary domains and paths. In this new approach, sites are detected first where possible, then the network is inferred. Allows filtering for arbitrary path segments, smooths out some weirdness, and removes various restrictions. A sunrise plugin could do much of its work by adding filters, if those are even needed.
see #27003 .
Built from https://develop.svn.wordpress.org/trunk@27359
git-svn-id: http://core.svn.wordpress.org/trunk@27209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 22:25:14 +00:00
Drew Jaynes
c0e436d3d3
Inline documentation for hooks in wp-admin/includes/image-edit.php.
...
Props theorboman. Props kpdesign for the cleanup.
Fixes #26149 .
Built from https://develop.svn.wordpress.org/trunk@27357
git-svn-id: http://core.svn.wordpress.org/trunk@27208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 20:56:15 +00:00
Drew Jaynes
5da89414a8
Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php.
...
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957 .
Built from https://develop.svn.wordpress.org/trunk@27356
git-svn-id: http://core.svn.wordpress.org/trunk@27207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 20:48:14 +00:00
Drew Jaynes
16941beac1
Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php.
...
Props kpdesign.
Fixes #26203 .
Built from https://develop.svn.wordpress.org/trunk@27355
git-svn-id: http://core.svn.wordpress.org/trunk@27206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 20:32:15 +00:00
Drew Jaynes
15068e1cd4
Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php.
...
Props leewillis77.
Fixes #26203 .
Built from https://develop.svn.wordpress.org/trunk@27342
git-svn-id: http://core.svn.wordpress.org/trunk@27194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 15:00:15 +00:00
Dion Hulse
d5775c8b6c
Upgrader: Remove more debug from r27336. See #25860
...
Built from https://develop.svn.wordpress.org/trunk@27339
git-svn-id: http://core.svn.wordpress.org/trunk@27191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 06:06:14 +00:00
Dion Hulse
487efa7957
Upgrader: Remove some debug from r27336. See #25860
...
Built from https://develop.svn.wordpress.org/trunk@27338
git-svn-id: http://core.svn.wordpress.org/trunk@27190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 06:04:14 +00:00
Dion Hulse
6b280a820e
Upgrader: Remove two stray spaces. See #25860
...
Built from https://develop.svn.wordpress.org/trunk@27337
git-svn-id: http://core.svn.wordpress.org/trunk@27189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 06:02:15 +00:00
Dion Hulse
c94a32b0ad
Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860
...
Built from https://develop.svn.wordpress.org/trunk@27336
git-svn-id: http://core.svn.wordpress.org/trunk@27188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-01 06:01:16 +00:00
Scott Taylor
e92770ba93
* Videos should always render at the same aspect ratio.
...
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page
See #27243 .
Built from https://develop.svn.wordpress.org/trunk@27328
git-svn-id: http://core.svn.wordpress.org/trunk@27180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 21:28:14 +00:00
John Blackbourn
44e34f826b
Don't filter out network-only plugins from the Plugins screen if they're individually active on the current site. Add some code comments for clarity. Props mordauk
...
Built from https://develop.svn.wordpress.org/trunk@27326
git-svn-id: http://core.svn.wordpress.org/trunk@27178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 20:22:14 +00:00
Sergey Biryukov
5f0f676199
Use a consistent format for translator comments.
...
props GaryJ.
fixes #27228 .
Built from https://develop.svn.wordpress.org/trunk@27325
git-svn-id: http://core.svn.wordpress.org/trunk@27177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 08:09:13 +00:00
Sergey Biryukov
e7467f9b44
Remove temporary hooks added in [26865].
...
fixes #26661 .
Built from https://develop.svn.wordpress.org/trunk@27324
git-svn-id: http://core.svn.wordpress.org/trunk@27176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 00:45:16 +00:00
Sergey Biryukov
f291730aec
Avoid an undefined index notice in wp_doc_link_parse().
...
props pross for initial patch.
fixes #27214 .
Built from https://develop.svn.wordpress.org/trunk@27323
git-svn-id: http://core.svn.wordpress.org/trunk@27175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 23:16:13 +00:00
Sergey Biryukov
bc036d0843
Avoid an undefined index notice in wp_handle_upload().
...
props tivnet.
fixes #27225 .
Built from https://develop.svn.wordpress.org/trunk@27319
git-svn-id: http://core.svn.wordpress.org/trunk@27171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 21:16:15 +00:00
Andrew Ozz
d896fa2487
Upgrade Plupload to 2.1.1, props kovshenin, see #25663
...
Built from https://develop.svn.wordpress.org/trunk@27316
git-svn-id: http://core.svn.wordpress.org/trunk@27168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 20:01:16 +00:00
Andrew Nacin
bee73edb62
Unslash in the time-format and date-format ajax endpoints.
...
props GregLone.
fixes #27216 .
Built from https://develop.svn.wordpress.org/trunk@27305
git-svn-id: http://core.svn.wordpress.org/trunk@27158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 00:05:14 +00:00
Drew Jaynes
8dc5888cfa
Improve inline documentation for `WP_Users_List_Table`.
...
Props leewillis77 for the initial patch.
Fixes #26564 .
Built from https://develop.svn.wordpress.org/trunk@27301
git-svn-id: http://core.svn.wordpress.org/trunk@27154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 22:20:17 +00:00
Andrew Nacin
13e868ac55
Decrement update count bubbles as plugins/themes are updated, live.
...
props gcorne, mitchoyoshitaka.
fixes #17703 .
Built from https://develop.svn.wordpress.org/trunk@27280
git-svn-id: http://core.svn.wordpress.org/trunk@27136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 06:55:14 +00:00
Andrew Nacin
9c9c824de2
Clarify return values for get_preferred_from_update_core() and get_core_updates().
...
props SergeyBiryukov.
fixes #20251 .
Built from https://develop.svn.wordpress.org/trunk@27264
git-svn-id: http://core.svn.wordpress.org/trunk@27121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:20:13 +00:00
Drew Jaynes
cb8951b0b3
Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
...
See #27200 .
Built from https://develop.svn.wordpress.org/trunk@27262
git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Andrew Nacin
bf028ce1e3
Remove _relocate_children(), which has had no purpose for some time.
...
props SergeyBiryukov, scribu.
fixes #19367 .
Built from https://develop.svn.wordpress.org/trunk@27261
git-svn-id: http://core.svn.wordpress.org/trunk@27118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:10:14 +00:00
Andrew Nacin
c102fd5a9d
Make the user arguments for get_edit_profile_url() and get_dashboard_url() optional, defaulting to the current user.
...
props garyc40.
fixes #16686 .
Built from https://develop.svn.wordpress.org/trunk@27260
git-svn-id: http://core.svn.wordpress.org/trunk@27117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:08:13 +00:00
Drew Jaynes
94549c1a4a
Inline documentation for hooks in wp-admin/includes/screen.php.
...
Props enej, kpdesign.
Fixes #26821 .
Built from https://develop.svn.wordpress.org/trunk@27256
git-svn-id: http://core.svn.wordpress.org/trunk@27113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 10:05:14 +00:00
Drew Jaynes
0ab444cd42
Inline documentation for hooks in wp-admin/includes/class-wp-posts-list-table.php.
...
Props nicolealleyinteractivecom, kpdesign.
Fixes #26397 .
Built from https://develop.svn.wordpress.org/trunk@27255
git-svn-id: http://core.svn.wordpress.org/trunk@27112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 06:12:13 +00:00
Sergey Biryukov
0cbdf53b18
Fix theme preview URL for themes loaded via AJAX on Install Themes screen.
...
props ocean90.
fixes #27128 .
Built from https://develop.svn.wordpress.org/trunk@27247
git-svn-id: http://core.svn.wordpress.org/trunk@27104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 00:01:14 +00:00
Drew Jaynes
ad3861242d
Inline documentation for hooks in wp-admin/includes/template.php.
...
Props shelob9 for the initial patch. Props kpdesign.
Fixes #26089 .
Built from https://develop.svn.wordpress.org/trunk@27237
git-svn-id: http://core.svn.wordpress.org/trunk@27094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-23 22:44:13 +00:00
Sergey Biryukov
f9d5020cb5
Use filtered per_page value in WP_Plugin_Install_List_Table and WP_Theme_Install_List_Table.
...
props brasofilo.
fixes #25675 .
Built from https://develop.svn.wordpress.org/trunk@27221
git-svn-id: http://core.svn.wordpress.org/trunk@27078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 18:30:14 +00:00
Andrew Nacin
912379a022
Simplify error in validate_file_to_edit().
...
props MattyRob for initial patch.
fixes #25924 .
Built from https://develop.svn.wordpress.org/trunk@27219
git-svn-id: http://core.svn.wordpress.org/trunk@27076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 14:46:14 +00:00
Drew Jaynes
61538d3f5e
Inline documentation for hooks in wp-admin/includes/image.php.
...
Props theorboman, kpdesign.
Fixes #25832 .
Built from https://develop.svn.wordpress.org/trunk@27202
git-svn-id: http://core.svn.wordpress.org/trunk@27059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-20 06:27:13 +00:00
John Blackbourn
32114a645d
Add screen-reader friendly variations of some short text links in the Publish meta box. Fixes #25459 .
...
Built from https://develop.svn.wordpress.org/trunk@27196
git-svn-id: http://core.svn.wordpress.org/trunk@27055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-19 22:44:16 +00:00
Helen Hou-Sandí
ab31bf8683
Once upon a time not long ago,
...
The admin CSS was merged in #18314 .
After a couple years as it stood,
The mess it had become just was no good.
One day we realized Grunt is pretty cool,
And said "we should use this as our build tool!"
Now we can maintain separate files with ease,
Using @import and cssmin meets all our needs.
Welcome to the future of the WordPress stylesheets,
And thanks to Slick Rick for the beats.
props jorbin for the initial patch.
fixes #26669 .
Built from https://develop.svn.wordpress.org/trunk@27195
git-svn-id: http://core.svn.wordpress.org/trunk@27054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-19 21:43:14 +00:00
Sergey Biryukov
6919d9f197
Use correct variable. props avryl. fixes #27153 .
...
Built from https://develop.svn.wordpress.org/trunk@27194
git-svn-id: http://core.svn.wordpress.org/trunk@27053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-19 15:29:14 +00:00
Scott Taylor
ca4045ce76
Use `selected()` where appropriate in `touch_time()`, `page_template_dropdown()`, and `parent_dropdown()`. Also, add proper docs.
...
Props meloniq, DrewAPicture.
Fixes #25889 .
Built from https://develop.svn.wordpress.org/trunk@27188
git-svn-id: http://core.svn.wordpress.org/trunk@27047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-17 22:27:15 +00:00
Andrew Nacin
5f0981788d
Detect and handle symlinking of plugins in plugin_basename().
...
props rmccue, MikeSchinkel, jdgrimes.
see #16953 .
Built from https://develop.svn.wordpress.org/trunk@27158
git-svn-id: http://core.svn.wordpress.org/trunk@27024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 23:00:15 +00:00
Drew Jaynes
30c7a12aa2
Fix docs spacing missed in [27136].
...
See #27070 .
Built from https://develop.svn.wordpress.org/trunk@27137
git-svn-id: http://core.svn.wordpress.org/trunk@27004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 22:19:11 +00:00
Drew Jaynes
8b3c9c6b97
Improve inline documentation for `submit_button()`.
...
See #27070 .
Built from https://develop.svn.wordpress.org/trunk@27136
git-svn-id: http://core.svn.wordpress.org/trunk@27003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 22:14:12 +00:00
Drew Jaynes
de97319ad8
Clarify `submit_button()` `$type` parameter docs to mention that the value doubles as the CSS class attribute.
...
See #27070
Built from https://develop.svn.wordpress.org/trunk@27135
git-svn-id: http://core.svn.wordpress.org/trunk@27002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 22:11:15 +00:00
Andrew Nacin
dbea669271
Improve parameter documentation of add_meta_box().
...
props philiparthurmoore, DrewAPicture.
fixes #26698 .
Built from https://develop.svn.wordpress.org/trunk@27132
git-svn-id: http://core.svn.wordpress.org/trunk@26999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 00:55:12 +00:00
Scott Taylor
03dda3b273
Introduce `maybe_regenerate_attachment_metadata( $attachment )`. On the Edit Media screen, call it for Audio and Video files.
...
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.
This is the minimum viable product for #26825 , but leaving the ticket open unless this function needs to be called in other places.
See #26825 .
Built from https://develop.svn.wordpress.org/trunk@27127
git-svn-id: http://core.svn.wordpress.org/trunk@26994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 22:41:12 +00:00
Helen Hou-Sandí
0100dd772a
Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include:
...
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.
1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380 .
Built from https://develop.svn.wordpress.org/trunk@27106
git-svn-id: http://core.svn.wordpress.org/trunk@26973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 06:25:18 +00:00
Drew Jaynes
68f9370ae9
Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.
...
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.
Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608 .
Built from https://develop.svn.wordpress.org/trunk@27090
git-svn-id: http://core.svn.wordpress.org/trunk@26962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 08:25:13 +00:00
Drew Jaynes
771f8dc244
Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php.
...
Props Ajay, kpdesign.
Fixes #26209 .
Built from https://develop.svn.wordpress.org/trunk@27089
git-svn-id: http://core.svn.wordpress.org/trunk@26961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 07:56:12 +00:00
Andrew Ozz
87c3c8adc0
Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233 .
...
Built from https://develop.svn.wordpress.org/trunk@27079
git-svn-id: http://core.svn.wordpress.org/trunk@26952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 23:50:13 +00:00
Andrew Nacin
39e32ed1eb
Consistently trim and unslash search queries for the users list tables.
...
props aubreypwd.
fixes #26115 .
Built from https://develop.svn.wordpress.org/trunk@27077
git-svn-id: http://core.svn.wordpress.org/trunk@26950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:10:12 +00:00
Drew Jaynes
0715a1d551
Inline documentation for hooks in wp-admin/includes/export.php.
...
Props cmmarslender, kpdesign.
Fixes #26894 .
Built from https://develop.svn.wordpress.org/trunk@27048
git-svn-id: http://core.svn.wordpress.org/trunk@26922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:10:12 +00:00
Drew Jaynes
b977d778b2
Inline documentation for hooks in wp-admin/includes/update-core.php.
...
Props JoshuaAbenazer, kpdesign.
Fixes #25998 .
Built from https://develop.svn.wordpress.org/trunk@27047
git-svn-id: http://core.svn.wordpress.org/trunk@26921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:02:14 +00:00
Helen Hou-Sandí
291ed370b4
Autocomplete for the new site admin email. Better than trying to remember which email address you used.
...
fixes #25348 .
Built from https://develop.svn.wordpress.org/trunk@27046
git-svn-id: http://core.svn.wordpress.org/trunk@26920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 23:10:12 +00:00
Andrew Nacin
d39d60e841
Add wp_install and wp_upgrade hooks to the respective functions.
...
props Denis-de-Bernardy.
fixes #25762 .
Built from https://develop.svn.wordpress.org/trunk@27045
git-svn-id: http://core.svn.wordpress.org/trunk@26919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 16:32:12 +00:00
Andrew Ozz
ced6e2a428
Remove one more valign, props neoxx, fixes #22712 .
...
Built from https://develop.svn.wordpress.org/trunk@27037
git-svn-id: http://core.svn.wordpress.org/trunk@26913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:38:11 +00:00
Andrew Ozz
87589dd445
Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086 .
...
Built from https://develop.svn.wordpress.org/trunk@27036
git-svn-id: http://core.svn.wordpress.org/trunk@26912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:28:12 +00:00
Dominik Schilling
496c05f1e9
Remove unused code. props nofearinc. fixes #26205 .
...
Built from https://develop.svn.wordpress.org/trunk@27033
git-svn-id: http://core.svn.wordpress.org/trunk@26909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:12:11 +00:00
Andrew Ozz
eb1d21d782
Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712 .
...
Built from https://develop.svn.wordpress.org/trunk@27029
git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 19:06:15 +00:00
Andrew Nacin
06efe8130d
Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.
...
props mattheu.
see #26574 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26999
git-svn-id: http://core.svn.wordpress.org/trunk@26876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 16:52:11 +00:00
Andrew Ozz
335add2573
Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272 .
...
Built from https://develop.svn.wordpress.org/trunk@26995
git-svn-id: http://core.svn.wordpress.org/trunk@26872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 04:56:16 +00:00
Drew Jaynes
5ee0b5641e
Hook docs spacing and standards fixes for wp-admin/includes/ajax-actions.php.
...
See #25374 .
Built from https://develop.svn.wordpress.org/trunk@26981
git-svn-id: http://core.svn.wordpress.org/trunk@26858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-18 17:06:12 +00:00
Matt Thomas
5b327853e4
The comment screen hides the author column at narrow screen sizes; this adds back the author info above the comment content. Fixes #26618 , props SergeyBiryukov, nacin.
...
Built from https://develop.svn.wordpress.org/trunk@26961
git-svn-id: http://core.svn.wordpress.org/trunk@26840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-16 20:34:10 +00:00
Sergey Biryukov
1db81755ac
Remove unnecessary sprintf(). props jdgrimes. fixes #25489 .
...
Built from https://develop.svn.wordpress.org/trunk@26943
git-svn-id: http://core.svn.wordpress.org/trunk@26823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-14 11:18:12 +00:00
Helen Hou-Sandí
60f3e98d51
Pass the $user_id to the `admin_color_scheme_picker` hook for context. props nacin. see #26607 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@26924
git-svn-id: http://core.svn.wordpress.org/trunk@26805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:49:10 +00:00
Drew Jaynes
f5213d39d0
Inline documentation for hooks in wp-admin/includes/meta-boxes.php.
...
Props SpencerFinnell for the initial patch.
Fixes #26092 .
Built from https://develop.svn.wordpress.org/trunk@26918
git-svn-id: http://core.svn.wordpress.org/trunk@26799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 04:06:12 +00:00
Drew Jaynes
76ad336c2c
Inline documentation for hooks in wp-admin/includes/class-wp-media-list-table.php.
...
Props theorboman for the initial patch. Props kpdesign.
Fixes #25839 .
Built from https://develop.svn.wordpress.org/trunk@26916
git-svn-id: http://core.svn.wordpress.org/trunk@26797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 03:53:14 +00:00
Drew Jaynes
f51b1f8def
Inline documentation for hooks in wp-admin/includes/media.php.
...
Props kpdesign, DrewAPicture.
Fixes #25375 .
Built from https://develop.svn.wordpress.org/trunk@26908
git-svn-id: http://core.svn.wordpress.org/trunk@26791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-06 05:48:12 +00:00
Sergey Biryukov
3a7ce85b4f
Change 'Width' to 'Layout' to match the hard-coded list of translatable theme features in get_theme_feature_list().
...
props janrenn.
fixes #26777 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26905
git-svn-id: http://core.svn.wordpress.org/trunk@26788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-05 17:16:11 +00:00
Sergey Biryukov
0ddaa76f3e
Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs.
...
props Rarst.
fixes #26617 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26884
git-svn-id: http://core.svn.wordpress.org/trunk@26767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-31 10:33:11 +00:00
Sergey Biryukov
a25d9ae3ba
Make sure "UPDATE LOG" in debug emails matches the underlining when translated.
...
fixes #26621 .
Built from https://develop.svn.wordpress.org/trunk@26883
git-svn-id: http://core.svn.wordpress.org/trunk@26766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-31 10:27:10 +00:00
Andrew Ozz
855889f7aa
TinyMCE 4.0.12, first run.
...
- Removes wp-tinymce-schema.js and mark-loaded.js, no longer needed.
- Removes the inlinepopups and most of the wpdialogs plugins; wpdialog.js is moved to wp-includes/js.
- Adds charmap, compat3x, image, link and textcolor plugins, previously contained in /themes/advanced.
- Updates the wordpress, wpeditimage, wpfullscreen, wpgallery and wplink plugins.
- Updates DFW, wp-admin/js/wp-fullscreen.js.
See #24067 .
Built from https://develop.svn.wordpress.org/trunk@26876
git-svn-id: http://core.svn.wordpress.org/trunk@26759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-28 23:53:15 +00:00
Sergey Biryukov
cdba99d3b3
Being consistent is the gist, no single @since should have been missed.
...
see #26713 .
Built from https://develop.svn.wordpress.org/trunk@26869
git-svn-id: http://core.svn.wordpress.org/trunk@26755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-25 02:00:11 +00:00
Drew Jaynes
cd8cedc40d
First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
...
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713 .
Built from https://develop.svn.wordpress.org/trunk@26868
git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Sergey Biryukov
cce9d251a4
Add comments for temporary hooks. see #26661 .
...
Built from https://develop.svn.wordpress.org/trunk@26866
git-svn-id: http://core.svn.wordpress.org/trunk@26752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-23 00:48:11 +00:00
Sergey Biryukov
507b595c2b
Add temporary hooks for the widgets feature team to wp_widget_control().
...
props westonruter.
see #26661 .
Built from https://develop.svn.wordpress.org/trunk@26865
git-svn-id: http://core.svn.wordpress.org/trunk@26751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-23 00:45:11 +00:00
Ryan Boren
07c16fd23c
The Pinking Shears stir from their slumber, awakened by what may seem, to those
...
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!
One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.
Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.
Built from https://develop.svn.wordpress.org/trunk@26851
git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 19:49:11 +00:00
Andrew Nacin
fc7a4e3f3c
On update, delete files removed in 3.8.
...
props JPry.
fixes #26535 .
Built from https://develop.svn.wordpress.org/trunk@26846
git-svn-id: http://core.svn.wordpress.org/trunk@26733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 17:38:10 +00:00
Matt Thomas
4fb4588829
Style the Add Comment button as a button. Fixes #26500 , props SergeyBiryukov.
...
Built from https://develop.svn.wordpress.org/trunk@26834
git-svn-id: http://core.svn.wordpress.org/trunk@26721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 19:14:11 +00:00
Andrew Nacin
659334bd59
Introduce dashboard_glance_items filter which replaces 3.7 right_now_* hooks that were tied to table markup.
...
fixes #26495 .
Built from https://develop.svn.wordpress.org/trunk@26832
git-svn-id: http://core.svn.wordpress.org/trunk@26719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 19:12:10 +00:00
Helen Hou-Sandí
eaec1347f2
Remove many of the now-unused images in core. Some images have been left for now, notably our previous style icons, action indicators, and images that see a higher frequency of use in plugins to allow them more time to adapt to the new design. props ocean90, Ipstenu, coffee2code. fixes #26036 .
...
Built from https://develop.svn.wordpress.org/trunk@26821
git-svn-id: http://core.svn.wordpress.org/trunk@26708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 03:21:12 +00:00
Andrew Nacin
1fb828504e
Avoid notices when default and light are not registered color schemes. see #26468 .
...
Built from https://develop.svn.wordpress.org/trunk@26814
git-svn-id: http://core.svn.wordpress.org/trunk@26701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:49:09 +00:00
Matt Thomas
cd465575f1
Expand the Quick Draft section by default. Fixes #26463 , props bassgang.
...
Built from https://develop.svn.wordpress.org/trunk@26813
git-svn-id: http://core.svn.wordpress.org/trunk@26700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:43:11 +00:00
Andrew Nacin
7dbfca1778
Nonces are already per-user. see #22862 .
...
Built from https://develop.svn.wordpress.org/trunk@26793
git-svn-id: http://core.svn.wordpress.org/trunk@26680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 07:05:10 +00:00
Andrew Nacin
c09252b950
Core updates for the new color schemes.
...
* Update about page, there's now 8.
* Display them four wide, not three, and ensure adequate spacing.
* Use a dedicated nonce.
* Push Light to the front in addition to Default.
* Use user-profile.js on about.php. A few extra things are initialized but they are harmless.
see #26468 , #26387 .
Built from https://develop.svn.wordpress.org/trunk@26776
git-svn-id: http://core.svn.wordpress.org/trunk@26663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:46:21 +00:00
Andrew Nacin
7e1431aac1
Use wp_specialchars_decode() in the upgrade debugging email subject, same as the production email.
...
props markoheijnen.
fixes #26471 .
Built from https://develop.svn.wordpress.org/trunk@26762
git-svn-id: http://core.svn.wordpress.org/trunk@26650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 01:15:10 +00:00
Andrew Nacin
17e3271415
Translator's comment for a date_i18n() string.
...
props netweb.
fixes #26470 .
Built from https://develop.svn.wordpress.org/trunk@26758
git-svn-id: http://core.svn.wordpress.org/trunk@26646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 00:38:13 +00:00
Andrew Nacin
61b7831f56
Dashboard: Restore a line that vanished from my editor to print recently published posts. Also fix an off-by-one error.
...
see [26704]. see #26066 .
Built from https://develop.svn.wordpress.org/trunk@26741
git-svn-id: http://core.svn.wordpress.org/trunk@26630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 20:13:11 +00:00
Drew Jaynes
7bf5470bab
Inline documentation fixes for hooks and functions introduced in 3.8.0.
...
Built from https://develop.svn.wordpress.org/trunk@26736
git-svn-id: http://core.svn.wordpress.org/trunk@26625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:18:11 +00:00
Andrew Nacin
a41e7e8b9b
Core updates: Explicitly call wp_cache_delete() after a DB upgrade, as not all cache backends allow the entire backend to be flushed.
...
props dd32.
fixes #26173 .
Built from https://develop.svn.wordpress.org/trunk@26734
git-svn-id: http://core.svn.wordpress.org/trunk@26623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:00:10 +00:00
Drew Jaynes
fdbc44ff48
Inline documentation fixes for `wp_heartbeat_set_suspension()`.
...
See #25073 .
Built from https://develop.svn.wordpress.org/trunk@26732
git-svn-id: http://core.svn.wordpress.org/trunk@26621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 18:43:10 +00:00
Andrew Nacin
df48cebeb4
No-JavaScript and no-Customizer support for the new Themes screen.
...
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.
This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.
No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.
The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.
fixes #25964 .
Built from https://develop.svn.wordpress.org/trunk@26726
git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 16:11:10 +00:00
Matt Mullenweg
ba93d95af0
Add and display new tags to highlight the ever-growing number of responsive themes available. Fixes #21442 .
...
Props Otto42 and lancewillett.
Built from https://develop.svn.wordpress.org/trunk@26711
git-svn-id: http://core.svn.wordpress.org/trunk@26600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 01:07:11 +00:00
Andrew Nacin
8a2accaa41
Fix various i18n issues on the dashboard. Limits it to posts and pages only for 3.8.
...
props SergeyBiryukov, dimadin.
fixes #26066 .
Built from https://develop.svn.wordpress.org/trunk@26704
git-svn-id: http://core.svn.wordpress.org/trunk@26594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:34:11 +00:00
Andrew Nacin
8de0c10bb9
Restore "Search Engines Discouraged" to the dashboard.
...
props JustinSainton.
fixes #26431 .
Built from https://develop.svn.wordpress.org/trunk@26700
git-svn-id: http://core.svn.wordpress.org/trunk@26590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:05:10 +00:00
Andrew Nacin
4a3e2f84b9
Dashboard: Rename the Site Content widget (née Right Now) to At a Glance.
...
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26697
git-svn-id: http://core.svn.wordpress.org/trunk@26587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:38:11 +00:00
Andrew Nacin
8b8c8e96e7
Deactivate MP6 on update to 3.8.
...
If left on, it introduces a lot of weird issues not easily diagnosed. MP6 will be updated before release to prevent itself from functioning 3.8+, but this will cut down on support requests by people who update core but not MP6, which was a fairly popular plugin.
fixes #26334 .
Built from https://develop.svn.wordpress.org/trunk@26692
git-svn-id: http://core.svn.wordpress.org/trunk@26582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 21:30:11 +00:00
Andrew Nacin
1788d5840f
Dashboard backwards compatibility updates.
...
* Restore missing wp_dashboard_rss_control() helper.
* Restore all original 3.7 functions, deprecating many, reusing others.
* Rename and remove functions so as not to clash with the original dash plugin.
* Filter cleanup/restoration.
see #25824 , #26334 .
Built from https://develop.svn.wordpress.org/trunk@26690
git-svn-id: http://core.svn.wordpress.org/trunk@26580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 21:23:10 +00:00
Andrew Nacin
08430e2684
Theme: When showing an author in the grid (during a search), don't include the author's link.
...
fixes #26433 .
Built from https://develop.svn.wordpress.org/trunk@26684
git-svn-id: http://core.svn.wordpress.org/trunk@26574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:08:10 +00:00
Andrew Nacin
9b29ad0529
Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
...
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.
To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.
props helen.
fixes #25147 .
Built from https://develop.svn.wordpress.org/trunk@26664
git-svn-id: http://core.svn.wordpress.org/trunk@26554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 06:38:09 +00:00
Matt Mullenweg
e20a684463
Create a new tag for themes that have passed the theme check guidelines for accessibility. Fixes #26157
...
Props lancewillett.
Built from https://develop.svn.wordpress.org/trunk@26658
git-svn-id: http://core.svn.wordpress.org/trunk@26548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 03:49:10 +00:00
Drew Jaynes
b3bc78df8f
Hook docs fixes following [26645].
...
See #25721 .
Built from https://develop.svn.wordpress.org/trunk@26648
git-svn-id: http://core.svn.wordpress.org/trunk@26538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 23:32:11 +00:00
Drew Jaynes
087289b6a4
Hook docs pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@26631
git-svn-id: http://core.svn.wordpress.org/trunk@26521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 20:03:09 +00:00
Andrew Nacin
bd17d08545
Add wp_prepare_themes_for_js filter to wp_prepare_themes_for_js().
...
props kovshenin.
fixes #25948 .
Built from https://develop.svn.wordpress.org/trunk@26625
git-svn-id: http://core.svn.wordpress.org/trunk@26515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:21:10 +00:00
Andrew Nacin
757a470708
Include columns-# CSS class in wp_dashboard() for when the screen supports it.
...
props westi.
fixes #26354 .
Built from https://develop.svn.wordpress.org/trunk@26617
git-svn-id: http://core.svn.wordpress.org/trunk@26507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 17:28:11 +00:00
Andrew Nacin
7e5b2a013a
Restore original properties of the right now (activity) and primary (news) dashboard widgets.
...
This avoids issues with those trying to remove/disable core meta boxes.
fixes #26392 .
Built from https://develop.svn.wordpress.org/trunk@26611
git-svn-id: http://core.svn.wordpress.org/trunk@26501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 16:56:10 +00:00
Matt Thomas
baefdf5bf8
Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327 , props nacin.
...
Built from https://develop.svn.wordpress.org/trunk@26608
git-svn-id: http://core.svn.wordpress.org/trunk@26498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 16:31:10 +00:00
Andrew Ozz
e6dd5fbf48
Svg-painter:
...
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333 .
Built from https://develop.svn.wordpress.org/trunk@26601
git-svn-id: http://core.svn.wordpress.org/trunk@26491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 04:13:11 +00:00
Matt Thomas
26a22db98e
Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327 , props MikeHansenMe.
...
Built from https://develop.svn.wordpress.org/trunk@26593
git-svn-id: http://core.svn.wordpress.org/trunk@26483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:32:10 +00:00
Andrew Nacin
c4f7821a16
Use current_user_can('manage_network_plugins') in validate_active_plugins() instead of is_super_admin().
...
props jdgrimes.
fixes #26068 .
Built from https://develop.svn.wordpress.org/trunk@26590
git-svn-id: http://core.svn.wordpress.org/trunk@26480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:12:10 +00:00
Andrew Nacin
a3fba0096d
In dbDelta(), ensure we are not running CREATE TABLE queries for global tables we wish to not upgrade.
...
props fliespl.
fixes #22134 .
Built from https://develop.svn.wordpress.org/trunk@26566
git-svn-id: http://core.svn.wordpress.org/trunk@26457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:44:10 +00:00
Helen Hou-Sandí
725eb939d7
Better Dashboard treatment when in no-JS, especially Quick Draft. props georgestephanis, helen. fixes #26376 .
...
Built from https://develop.svn.wordpress.org/trunk@26563
git-svn-id: http://core.svn.wordpress.org/trunk@26454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:32:19 +00:00
Andrew Ozz
0f20e57329
Heartbeat:
...
- Bring back heartbeat.interval().
- Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension().
- Rename the option for disabling suspension from options.suspend to options.suspension.
Fixes #25073 .
Built from https://develop.svn.wordpress.org/trunk@26549
git-svn-id: http://core.svn.wordpress.org/trunk@26441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 00:45:10 +00:00
Andrew Nacin
3fe7726bd4
Remove @uses from get_screen_icon() / screen_icon(). see #26119 .
...
Built from https://develop.svn.wordpress.org/trunk@26541
git-svn-id: http://core.svn.wordpress.org/trunk@26433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 21:59:10 +00:00
Drew Jaynes
201306f5da
Inline documentation for hooks in wp-admin/includes/update.php.
...
Props stevenkword for the initial patches.
Fixes #26252 .
Built from https://develop.svn.wordpress.org/trunk@26540
git-svn-id: http://core.svn.wordpress.org/trunk@26432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 21:55:10 +00:00
Andrew Nacin
4728680f8f
Only informally deprecate get_screen_icon() and screen_icon(). fixes #26119 .
...
Built from https://develop.svn.wordpress.org/trunk@26537
git-svn-id: http://core.svn.wordpress.org/trunk@26429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 20:00:11 +00:00
Andrew Nacin
710803793b
Simplify the color scheme profile saving JS. see #25858 .
...
Built from https://develop.svn.wordpress.org/trunk@26535
git-svn-id: http://core.svn.wordpress.org/trunk@26427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 19:45:10 +00:00
Andrew Nacin
c6ddea79d1
Themes: Always include the current theme in the list, even if it is not allowed.
...
see #25948 .
Built from https://develop.svn.wordpress.org/trunk@26529
git-svn-id: http://core.svn.wordpress.org/trunk@26422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 18:46:11 +00:00
Andrew Ozz
8d6059b383
Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
...
Built from https://develop.svn.wordpress.org/trunk@26518
git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Dion Hulse
578469fb12
Add braces around a conditional hook. This wasn't causing an issue as `if ( conditional ) /* multiline comment */ command();` is perfectly OK, but left open doubt and potential future bugs. See #25229
...
Built from https://develop.svn.wordpress.org/trunk@26509
git-svn-id: http://core.svn.wordpress.org/trunk@26403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 23:13:09 +00:00
Andrew Ozz
a6ac0bea23
Improve the admin color scheme picker:
...
- Easier to extend.
- Remove the "drop-down" look, show all choices inline.
- Some PHP and JS cleanup.
Props ryelle, fixes #26336 .
Built from https://develop.svn.wordpress.org/trunk@26506
git-svn-id: http://core.svn.wordpress.org/trunk@26400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 19:50:09 +00:00
Drew Jaynes
c9077348ee
Inline documentation for hooks in wp-admin/includes/user.php.
...
Props aaronholbrook for the initial patch.
Fixes #26099 .
Built from https://develop.svn.wordpress.org/trunk@26503
git-svn-id: http://core.svn.wordpress.org/trunk@26397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 17:54:10 +00:00
Dion Hulse
8ad620e51f
Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26470
git-svn-id: http://core.svn.wordpress.org/trunk@26368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 09:01:09 +00:00
Dion Hulse
c8b13eaa35
Themes: When the user doesn't have switch_themes capabilities, and we've passed the current theme, detect the theme slug/stylesheet correctly so that the flags are set properly. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26469
git-svn-id: http://core.svn.wordpress.org/trunk@26367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 08:38:09 +00:00
Helen Hou-Sandí
99f969df3c
Add remove_option(), remove_options(), and get_options() methods to WP_Screen, along with unit tests. props ocean90, DrewAPicture. fixes #25799 .
...
Built from https://develop.svn.wordpress.org/trunk@26456
git-svn-id: http://core.svn.wordpress.org/trunk@26354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-28 05:10:09 +00:00
Dion Hulse
d4d7ec693b
Core Updates: Fix a case where options (db_version specifically) can end up with stale values in the cache after a update is performed. Fixes #26173 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@26448
git-svn-id: http://core.svn.wordpress.org/trunk@26346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-28 02:16:09 +00:00
Andrew Ozz
162037903d
Heartbeat: introduce "suspend" functionality and enable it after 20 min. of inactivity, see #25073 .
...
Built from https://develop.svn.wordpress.org/trunk@26428
git-svn-id: http://core.svn.wordpress.org/trunk@26328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-27 01:56:10 +00:00
Andrew Ozz
f46e743343
Widgets: drop onto closed sidebars.
...
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952 .
Built from https://develop.svn.wordpress.org/trunk@26426
git-svn-id: http://core.svn.wordpress.org/trunk@26326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-27 01:30:10 +00:00
Sergey Biryukov
f0a4d5a991
Rename mp6_color_scheme JS global to wp_color_scheme.
...
props kovshenin.
see #26263 .
Built from https://develop.svn.wordpress.org/trunk@26406
git-svn-id: http://core.svn.wordpress.org/trunk@26306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 13:58:10 +00:00
Drew Jaynes
73f42e01a2
Inline documentation for hooks in wp-admin/includes/class-wp-list-table.php.
...
Props miyauchi, kpdesign.
Fixes 25848.
Built from https://develop.svn.wordpress.org/trunk@26401
git-svn-id: http://core.svn.wordpress.org/trunk@26301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 08:12:09 +00:00
Helen Hou-Sandí
e6a98258be
Add some deleted images to the `$_old_files` array. see [26391], [26395], #26232 , #26178 .
...
Built from https://develop.svn.wordpress.org/trunk@26397
git-svn-id: http://core.svn.wordpress.org/trunk@26297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:42:09 +00:00
Helen Hou-Sandí
236f388d6d
Don't show the Activity widget on the Network Admin Dashboard. props ocean90. fixes #26184 .
...
Built from https://develop.svn.wordpress.org/trunk@26394
git-svn-id: http://core.svn.wordpress.org/trunk@26294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:29:10 +00:00
Helen Hou-Sandí
2c9af1367e
Dashboard columns:
...
* Improve responsive breakpoints for.
* Remove obsolete network admin option.
* Remove unnecessary JS.
props SergeyBiryukov, kraftbj, lessbloat. fixes #26074 .
Built from https://develop.svn.wordpress.org/trunk@26392
git-svn-id: http://core.svn.wordpress.org/trunk@26292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:09:10 +00:00
Matt Thomas
1163eaeb7c
Remove button-secondary class from Collapse link in theme installer; unify Collapse button styles in theme installer and Customize screen; add a border around the Collapse icon so it remains visible on dark backgrounds; move the color styles to colors-fresh. Fixes #26230 .
...
Built from https://develop.svn.wordpress.org/trunk@26389
git-svn-id: http://core.svn.wordpress.org/trunk@26289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 04:14:09 +00:00
Dion Hulse
89dfee993d
Replace the Star ratings in the dashboard with dashicons ratings.
...
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170
Built from https://develop.svn.wordpress.org/trunk@26380
git-svn-id: http://core.svn.wordpress.org/trunk@26280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 02:25:21 +00:00
Sergey Biryukov
95ff70fcc0
Remove redundant translation function calls.
...
props markoheijnen.
see #26187 .
Built from https://develop.svn.wordpress.org/trunk@26349
git-svn-id: http://core.svn.wordpress.org/trunk@26250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 12:42:09 +00:00
Dominik Schilling
df6010446a
Don't use esc_attr_e() function for a non-translatable context.
...
props yoavf, mattheu.
fixes #26187 .
Built from https://develop.svn.wordpress.org/trunk@26347
git-svn-id: http://core.svn.wordpress.org/trunk@26248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 12:04:09 +00:00
Dion Hulse
5624f82c38
Use numbered string replacements in 2 new strings. Props dimadin. Fixes #25667
...
Built from https://develop.svn.wordpress.org/trunk@26346
git-svn-id: http://core.svn.wordpress.org/trunk@26247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 06:10:10 +00:00
Drew Jaynes
e90e224cbd
Inline documentation for hooks in wp-admin/includes/class-wp-ms-users-list-table.php.
...
Props ShinichiN, kpdesign.
Fixes #25612 .
Built from https://develop.svn.wordpress.org/trunk@26342
git-svn-id: http://core.svn.wordpress.org/trunk@26243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 22:25:10 +00:00
Drew Jaynes
ff0ace6fe1
Inline documentation for hooks in wp-admin/includes/class-wp-ms-sites-list-table.php.
...
Props ShinichiN, kpdesign.
Fixes #25607 .
Built from https://develop.svn.wordpress.org/trunk@26341
git-svn-id: http://core.svn.wordpress.org/trunk@26242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 21:58:10 +00:00
Drew Jaynes
f82f00a453
Inline documentation for hooks in wp-admin/includes/class-wp-links-list-table.php.
...
Props JoshuaAbenazer, kpdesign.
Fixes #26052 .
Built from https://develop.svn.wordpress.org/trunk@26340
git-svn-id: http://core.svn.wordpress.org/trunk@26241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 21:28:11 +00:00
Dominik Schilling
06b4f99e18
Dashboard: Use `_draft_or_post_title()` to display `(no title)` if no post title is set. see #25824 .
...
Built from https://develop.svn.wordpress.org/trunk@26337
git-svn-id: http://core.svn.wordpress.org/trunk@26238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 14:13:09 +00:00
Dion Hulse
f392843074
Theme Installer: Fix the Theme Preview function, and bring the button handling/styling inline with the Customizer. Fixes #26129
...
Built from https://develop.svn.wordpress.org/trunk@26317
git-svn-id: http://core.svn.wordpress.org/trunk@26221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 04:03:10 +00:00
Dion Hulse
61ed60c619
Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100 . See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26316
git-svn-id: http://core.svn.wordpress.org/trunk@26220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:34:10 +00:00
Dion Hulse
b7872fd70a
Use static strings instead of a impossible-to-translate string in the Automatic updates debug email. Props SergeyBiryukov. Fixes #25667
...
Built from https://develop.svn.wordpress.org/trunk@26313
git-svn-id: http://core.svn.wordpress.org/trunk@26217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:00:10 +00:00
Dion Hulse
893262f742
Themes: Add a get_theme_update_available() function to retrieve an update link and use it on the Themes page. See #26078
...
Built from https://develop.svn.wordpress.org/trunk@26282
git-svn-id: http://core.svn.wordpress.org/trunk@26187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:57:10 +00:00
Dion Hulse
0755f5a2dc
Translate the debug update email for development installs. Props Nao for initial patch. See #25667
...
Built from https://develop.svn.wordpress.org/trunk@26279
git-svn-id: http://core.svn.wordpress.org/trunk@26184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:04:10 +00:00
Dion Hulse
5862ddbd8f
Appearance: Fix a PHP Notice when the update transient isn't available (for example, due to a timeout or being used offline). See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26278
git-svn-id: http://core.svn.wordpress.org/trunk@26183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 01:40:09 +00:00
Andrew Nacin
ad52b4ddd4
Remove whitespace from the inside of a <textarea> element, added in [26138] with inline documentation.
...
see #25662 .
Built from https://develop.svn.wordpress.org/trunk@26273
git-svn-id: http://core.svn.wordpress.org/trunk@26178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 19:35:10 +00:00
Dion Hulse
f29b2e02ac
Plugin Deletion: Properly clear the cache when multiple plugins are deleted. Props jdgrimes. Fixes #26065
...
Built from https://develop.svn.wordpress.org/trunk@26262
git-svn-id: http://core.svn.wordpress.org/trunk@26168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 04:08:09 +00:00
Scott Taylor
da05f7435b
For unit tests that call `wpmu_create_blog()`, Blog factory, or installation code that attempts to clear transients: suppress database errors on `setUp` and restore on `tearDown`.
...
There are a few places in core that were preventing this from working by explicity setting `$wpdb->suppress_errors` to `false`. Instead, they should inherit the value that existed before errors were suppressed.
This allows Multisite unit tests to run without explosive database errors, and allows `$wpdb->suppress_errors` to be overridden all the way down the chain.
Fixes #26102 .
Built from https://develop.svn.wordpress.org/trunk@26252
git-svn-id: http://core.svn.wordpress.org/trunk@26158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 20:45:11 +00:00
Sergey Biryukov
0df020b516
Remove unused global reference. props jeremyfelt. fixes #26103 .
...
Built from https://develop.svn.wordpress.org/trunk@26251
git-svn-id: http://core.svn.wordpress.org/trunk@26157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 20:19:09 +00:00
Matt Thomas
7fe71ffe81
Style and positioning fixes to form elements in the Publish box:
...
- Make select element text #555 to match others
- Make Cancel links vertically align with buttons
- Make sure the spacing between buttons and cancel links is always consistent
- Override active button styles for responsive states so button size doesn't change when active
- Reduce font size of date select element to match date text inputs
Fixes #26082 , props aubreypwd.
Built from https://develop.svn.wordpress.org/trunk@26247
git-svn-id: http://core.svn.wordpress.org/trunk@26153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 18:53:10 +00:00
Sergey Biryukov
83adea3986
Remove debug cruft. props nbachiyski. see #25791 .
...
Built from https://develop.svn.wordpress.org/trunk@26245
git-svn-id: http://core.svn.wordpress.org/trunk@26152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 13:18:09 +00:00
Andrew Nacin
89005c8b31
Add level-X classes to the posts list table rows.
...
props jhned.
fixes #25791 .
Built from https://develop.svn.wordpress.org/trunk@26244
git-svn-id: http://core.svn.wordpress.org/trunk@26151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 20:40:09 +00:00
Sergey Biryukov
35ec8405f0
Fix date comparison in dashboard_relative_date(). fixes #26033 .
...
Built from https://develop.svn.wordpress.org/trunk@26242
git-svn-id: http://core.svn.wordpress.org/trunk@26149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:30:09 +00:00
Sergey Biryukov
ecd594b5a6
PHPDoc and i18n fixes for dashboard widgets.
...
props dimadin for initial patch.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26241
git-svn-id: http://core.svn.wordpress.org/trunk@26148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:21:10 +00:00
Andrew Nacin
963b2aa574
Merge wp_dashboard_recent_quickdrafts() into wp_dashboard_quick_press(). see #25824 .
...
Built from https://develop.svn.wordpress.org/trunk@26221
git-svn-id: http://core.svn.wordpress.org/trunk@26129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:40:15 +00:00
Andrew Nacin
2cc8ed1594
Dash cleanup.
...
* Use wp_add_dashboard_widget() rather than add_meta_box().
* Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
* Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
* Remove some debug cruft that was preventing caching and invalidation.
* Simplify lots of things where possible.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26220
git-svn-id: http://core.svn.wordpress.org/trunk@26128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:15:10 +00:00
Andrew Nacin
1832d880a5
Sort themes by name on the new themes.php page. see #25948 .
...
Built from https://develop.svn.wordpress.org/trunk@26216
git-svn-id: http://core.svn.wordpress.org/trunk@26124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 16:42:10 +00:00
Andrew Nacin
52ecbebba3
Remove debug cruft. props dimadin. see #25948 .
...
Built from https://develop.svn.wordpress.org/trunk@26215
git-svn-id: http://core.svn.wordpress.org/trunk@26123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 16:40:09 +00:00
Dion Hulse
8d65f7dc7c
Updates: When a failed Background Update occurs, only show the failed update nag if the user hasn't yet updated if it was an early abort. Props SergeyBiryukov. Fixes #25887 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@26186
git-svn-id: http://core.svn.wordpress.org/trunk@26095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 02:31:11 +00:00
Andrew Ozz
188fce6c9b
Heartbeat: clean up code style, better naming, better code structure. Props carldanley, props evansolomon.
...
Changes:
- Add connectNow() public method to trigger a connection immediately.
- Remove the "skipping" when no data to send.
- Change the default interval to 60 sec.
- Fix resetting the next connection time when changing the interval.
See #25073 .
Built from https://develop.svn.wordpress.org/trunk@26169
git-svn-id: http://core.svn.wordpress.org/trunk@26078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 18:41:10 +00:00
Dion Hulse
9109f107c4
Bacground Updates: Move the 'automatic_updates_complete' hook to only fire when some updates have actually been completed. Props nacin. Fixes #25841
...
Built from https://develop.svn.wordpress.org/trunk@26164
git-svn-id: http://core.svn.wordpress.org/trunk@26075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 06:29:09 +00:00
Dion Hulse
4fbc450f52
Background Updates: Add a 'automatic_updates_complete' hook that fires after any updates have run. Props pento. Fixes #25841
...
Built from https://develop.svn.wordpress.org/trunk@26155
git-svn-id: http://core.svn.wordpress.org/trunk@26066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:08:09 +00:00
Dion Hulse
a71cd00cdb
Background Updates: Spread them over the hour. Props Pento. Fixes #25833 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@26149
git-svn-id: http://core.svn.wordpress.org/trunk@26060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:04:10 +00:00
Dion Hulse
02841470a1
Background Updates: Fix a PHP Fatal error which could be encountered on some systems when using FTP. Fixes #25817 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@26148
git-svn-id: http://core.svn.wordpress.org/trunk@26059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 02:02:09 +00:00
Andrew Nacin
809b335f7a
Merge the new dashboard design into core.
...
Merges https://github.com/growthdesigner/wp-dash .
props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26144
git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
Andrew Nacin
dce9327f2a
Update the Themes screen, merging THX into core.
...
* Name: THX38
* Description: Update the Themes screen with a new design and experience.
* Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
* Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
* URI: http://wordpress.org/plugins/thx38/
fixes #25948
Built from https://develop.svn.wordpress.org/trunk@26141
git-svn-id: http://core.svn.wordpress.org/trunk@26052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:58:05 +00:00
Matt Thomas
87ce6cc5c3
Bring in the widgets component of MP6. See #25858 .
...
* A cleaner UI, with a simpler design for available and inactive widgets, and more emphasis on your sidebars.
* Available widgets and sidebars expand to two columns at larger screen sizes making it easier to manage sites with lots of sidebars.
* New dropzone indicator for empty sidebars.
Props shaunandrews, joen, iammattthomas.
Built from https://develop.svn.wordpress.org/trunk@26140
git-svn-id: http://core.svn.wordpress.org/trunk@26051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:06:06 +00:00
Sergey Biryukov
9119d189dd
Inline documentation for hooks in wp-admin/includes/class-wp-comments-list-table.php.
...
props siobhyb, kpdesign.
fixes #25662 .
Built from https://develop.svn.wordpress.org/trunk@26138
git-svn-id: http://core.svn.wordpress.org/trunk@26049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:47:10 +00:00
Helen Hou-Sandí
603c1aff6d
Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
...
Color scheme selection on your own profile page gives you a preview and autosaves the selection.
Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.
Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.
props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858 , #22862 .
Built from https://develop.svn.wordpress.org/trunk@26137
git-svn-id: http://core.svn.wordpress.org/trunk@26048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:38:38 +00:00
Sergey Biryukov
74f77b85a6
Use get_current_site() instead of the $current_site global when possible.
...
props jeremyfelt.
fixes #25158 .
Built from https://develop.svn.wordpress.org/trunk@26120
git-svn-id: http://core.svn.wordpress.org/trunk@26032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 03:23:10 +00:00
Sergey Biryukov
eae4e5936f
Use case-insensitive comparison for email addresses. fixes #25779 .
...
Built from https://develop.svn.wordpress.org/trunk@26115
git-svn-id: http://core.svn.wordpress.org/trunk@26027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 02:41:09 +00:00
Andrew Ozz
541d22e18d
Fix the X-UA-Compatible header for IE8, fixes #25575
...
Built from https://develop.svn.wordpress.org/trunk@26089
git-svn-id: http://core.svn.wordpress.org/trunk@26007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 18:02:10 +00:00
Sergey Biryukov
8d659b278c
Fix docblock formatting. fixes #25893 .
...
Built from https://develop.svn.wordpress.org/trunk@26081
git-svn-id: http://core.svn.wordpress.org/trunk@26001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 13:32:10 +00:00
Sergey Biryukov
e15b51efa3
Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader.
...
props bamadesigner.
fixes #25882 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26049
git-svn-id: http://core.svn.wordpress.org/trunk@25974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 17:04:09 +00:00
Andrew Ozz
0743625aed
Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575 .
...
Built from https://develop.svn.wordpress.org/trunk@26029
git-svn-id: http://core.svn.wordpress.org/trunk@25959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 23:49:09 +00:00
Sergey Biryukov
23de998e29
Fix inverted logic for displaying the 'Broken Theme' string. props pavelevap. fixes #25465 .
...
Built from https://develop.svn.wordpress.org/trunk@26027
git-svn-id: http://core.svn.wordpress.org/trunk@25957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 22:40:08 +00:00
Sergey Biryukov
72d4b140fb
Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702 .
...
Built from https://develop.svn.wordpress.org/trunk@26024
git-svn-id: http://core.svn.wordpress.org/trunk@25955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 20:02:09 +00:00
Dion Hulse
c9683257db
Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772
...
Built from https://develop.svn.wordpress.org/trunk@26017
git-svn-id: http://core.svn.wordpress.org/trunk@25948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:23:10 +00:00
Dion Hulse
9d011a0556
Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@26016
git-svn-id: http://core.svn.wordpress.org/trunk@25947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:20:09 +00:00
Dion Hulse
38a69e4ccc
Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470
...
Built from https://develop.svn.wordpress.org/trunk@26015
git-svn-id: http://core.svn.wordpress.org/trunk@25946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 05:48:10 +00:00
Dion Hulse
b511346319
When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@26014
git-svn-id: http://core.svn.wordpress.org/trunk@25945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 05:43:09 +00:00
Dion Hulse
21a3164b3b
Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
...
Built from https://develop.svn.wordpress.org/trunk@26013
git-svn-id: http://core.svn.wordpress.org/trunk@25944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 02:15:10 +00:00
Scott Taylor
ba3f75b3c3
Pass `$args` to the `export_wp` action in `export_wp()`, which is currently passed no arguments.
...
Props nickdaugherty.
Fixes #25574 .
Built from https://develop.svn.wordpress.org/trunk@26011
git-svn-id: http://core.svn.wordpress.org/trunk@25942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 01:27:08 +00:00
Sergey Biryukov
cd45adaa0b
Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
...
props drozdz.
fixes #25814 .
Built from https://develop.svn.wordpress.org/trunk@26001
git-svn-id: http://core.svn.wordpress.org/trunk@25934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-04 11:00:11 +00:00
Andrew Nacin
d0cfa40983
Add jshintrc to qunit.
...
props jorbin.
see #25187 .
Built from https://develop.svn.wordpress.org/trunk@25992
git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Andrew Nacin
a8ef13972c
When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
...
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.
see #25716 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25956
git-svn-id: http://core.svn.wordpress.org/trunk@25915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-27 21:09:10 +00:00
Drew Jaynes
4cf7175d6f
Inline documentation for hooks in wp-admin/includes/schema.php.
...
Props johnafish, kpdesign.
Fixes #25498 .
Built from https://develop.svn.wordpress.org/trunk@25938
git-svn-id: http://core.svn.wordpress.org/trunk@25897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 20:29:10 +00:00
Drew Jaynes
94a3ee8d68
Inline documentation for hooks in wp-admin/includes/nav-menu.php.
...
Props Faison.
Fixes #25474 .
Built from https://develop.svn.wordpress.org/trunk@25935
git-svn-id: http://core.svn.wordpress.org/trunk@25894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 17:48:11 +00:00
Andrew Nacin
1a2f89d5d0
Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7.
...
props GaryJ.
fixes #25689 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25915
git-svn-id: http://core.svn.wordpress.org/trunk@25878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 20:15:10 +00:00
Andrew Nacin
70fd806759
Revert r25824:25875 from the core.svn.wordpress.org repository.
...
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin
ac2e70227f
Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
...
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.
This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.
fixes #25654 .
Built from https://develop.svn.wordpress.org/trunk@25873
git-svn-id: http://core.svn.wordpress.org/trunk@25873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 23:00:01 +00:00
Andrew Nacin
d680f71d91
Show the nag we show for a stuck .maintenance file when an auto update failed.
...
see #25654 .
Built from https://develop.svn.wordpress.org/trunk@25872
git-svn-id: http://core.svn.wordpress.org/trunk@25872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:53 +00:00
Andrew Nacin
ff711dba63
"some files" instead of "certain files". Less stuffy.
...
props markjaquith.
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25871
git-svn-id: http://core.svn.wordpress.org/trunk@25871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:45 +00:00
Andrew Nacin
bed7a78426
New, better error message when we realize we won't be able to copy a file and continue with the update.
...
fixes #25652 .
Built from https://develop.svn.wordpress.org/trunk@25870
git-svn-id: http://core.svn.wordpress.org/trunk@25870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:37 +00:00
Andrew Nacin
d61e188f23
Only enforce disk free space checks when doing background updates.
...
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25869
git-svn-id: http://core.svn.wordpress.org/trunk@25869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:29 +00:00
Andrew Nacin
5361a8abca
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
4b559801ae
Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
...
props dd32.
fixes #25655 .
Built from https://develop.svn.wordpress.org/trunk@25866
git-svn-id: http://core.svn.wordpress.org/trunk@25866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:05 +00:00
Andrew Nacin
3b7e540f00
Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
...
props dd32 for initial patch.
fixes #25657 .
Built from https://develop.svn.wordpress.org/trunk@25863
git-svn-id: http://core.svn.wordpress.org/trunk@25863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:40 +00:00
Andrew Nacin
de7977d66c
Move upgrader_process_complete for core to its proper place in Core_Upgrader.
...
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.
props dd32.
fixes #25659 .
Built from https://develop.svn.wordpress.org/trunk@25861
git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Andrew Nacin
b134f540e2
Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
...
fixes #25653 . Also:
* Fully document all new hooks, methods, and classes in the upgrader.
* Rename 'language' to 'translation' inside the upgrader.
* Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.
Built from https://develop.svn.wordpress.org/trunk@25859
git-svn-id: http://core.svn.wordpress.org/trunk@25859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:58 +00:00
Andrew Nacin
04bbb52c7c
Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
...
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25851
git-svn-id: http://core.svn.wordpress.org/trunk@25851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:54 +00:00
Andrew Nacin
aea50d4b4c
Use correct variable. fixes #10787 .
...
Built from https://develop.svn.wordpress.org/trunk@25843
git-svn-id: http://core.svn.wordpress.org/trunk@25843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:46 +00:00
Andrew Nacin
83b20ee7f9
Notify administrators of successful, failed, and pending core updates.
...
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.
fixes #10787 .
Built from https://develop.svn.wordpress.org/trunk@25841
git-svn-id: http://core.svn.wordpress.org/trunk@25841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:30 +00:00
Andrew Nacin
27d04f9e5e
Delete expired transients on database upgrades.
...
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.
props dartiss, pento.
fixes #20316 .
Built from https://develop.svn.wordpress.org/trunk@25838
git-svn-id: http://core.svn.wordpress.org/trunk@25838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:02 +00:00
Andrew Nacin
fa4f4033f7
Introduce email templates for automatic background updates.
...
The four templates are:
1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
2. We are not configured to update their site, so we notify them of the new release. ('notify')
3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2 , plus one sentence. ('fail')
4. We tried to update their site, and failed while copying files. ('critical')
With assistance from markjaquith.
see #10787 .
Built from https://develop.svn.wordpress.org/trunk@25837
git-svn-id: http://core.svn.wordpress.org/trunk@25837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:54 +00:00
Andrew Nacin
93eefa2af3
set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
...
fixes #25622 .
Built from https://develop.svn.wordpress.org/trunk@25836
git-svn-id: http://core.svn.wordpress.org/trunk@25836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:46 +00:00
Andrew Nacin
a3561e7e07
In automatic background updates, standardize on 'update'.
...
New, final filter names:
* auto_update_{$type} (plugin, theme, core, language)
* automatic_updates_is_vcs_checkout
* automatic_updates_disabled
New class name is WP_Automatic_Updater. Method names include update() and should_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25835
git-svn-id: http://core.svn.wordpress.org/trunk@25835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:38 +00:00
Dion Hulse
8abd2f86d5
Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
...
See #25576 , #22704
Built from https://develop.svn.wordpress.org/trunk@25831
git-svn-id: http://core.svn.wordpress.org/trunk@25831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:05 +00:00
Dion Hulse
66f01957a0
For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
...
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704
Built from https://develop.svn.wordpress.org/trunk@25828
git-svn-id: http://core.svn.wordpress.org/trunk@25828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:40 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
564b008f67
Add editimage.min.js to $_old_files. see #24999 .
...
Built from https://develop.svn.wordpress.org/trunk@25897
git-svn-id: http://core.svn.wordpress.org/trunk@25809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 19:27:09 +00:00
Andrew Nacin
0ceb189b7b
Confirm delete_site_option() exists before calling it during an update.
...
This function won't yet exist when updating from 2.7 [sic].
fixes #25682 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25893
git-svn-id: http://core.svn.wordpress.org/trunk@25805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 18:18:12 +00:00
Andrew Nacin
0976999929
Remove debug code from WP_Automatic_Updater::send_email().
...
props markmcwilliams for initial patch.
see #25678 .
Built from https://develop.svn.wordpress.org/trunk@25891
git-svn-id: http://core.svn.wordpress.org/trunk@25803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 01:51:09 +00:00
Andrew Nacin
7b772e5c58
Introduce a send_core_update_notification_email filter to control whether to send update notifications.
...
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.
This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.
see #25603 .
Built from https://develop.svn.wordpress.org/trunk@25882
git-svn-id: http://core.svn.wordpress.org/trunk@25794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:47:09 +00:00
Ryan Boren
b87d4b77e5
Pinking shears
...
Built from https://develop.svn.wordpress.org/trunk@25880
git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin
a387c3bef9
Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
...
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.
This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.
fixes #25654 .
Built from https://develop.svn.wordpress.org/trunk@25873
git-svn-id: http://core.svn.wordpress.org/trunk@25785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:19:09 +00:00
Andrew Nacin
58c18f0c32
Show the nag we show for a stuck .maintenance file when an auto update failed.
...
see #25654 .
Built from https://develop.svn.wordpress.org/trunk@25872
git-svn-id: http://core.svn.wordpress.org/trunk@25784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:15:09 +00:00
Andrew Nacin
13dd29126a
"some files" instead of "certain files". Less stuffy.
...
props markjaquith.
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25871
git-svn-id: http://core.svn.wordpress.org/trunk@25783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:41:10 +00:00
Andrew Nacin
fabf119cf3
New, better error message when we realize we won't be able to copy a file and continue with the update.
...
fixes #25652 .
Built from https://develop.svn.wordpress.org/trunk@25870
git-svn-id: http://core.svn.wordpress.org/trunk@25782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:21:10 +00:00
Andrew Nacin
d5fdd66f9d
Only enforce disk free space checks when doing background updates.
...
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25869
git-svn-id: http://core.svn.wordpress.org/trunk@25781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:18:09 +00:00
Andrew Nacin
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
a160441c81
Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
...
props dd32.
fixes #25655 .
Built from https://develop.svn.wordpress.org/trunk@25866
git-svn-id: http://core.svn.wordpress.org/trunk@25778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:20:10 +00:00
Andrew Nacin
097c0fd0b6
Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
...
props dd32 for initial patch.
fixes #25657 .
Built from https://develop.svn.wordpress.org/trunk@25863
git-svn-id: http://core.svn.wordpress.org/trunk@25775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 09:49:09 +00:00
Andrew Nacin
64bd5aa564
Move upgrader_process_complete for core to its proper place in Core_Upgrader.
...
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.
props dd32.
fixes #25659 .
Built from https://develop.svn.wordpress.org/trunk@25861
git-svn-id: http://core.svn.wordpress.org/trunk@25773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 04:37:09 +00:00
Andrew Nacin
5a0b227316
Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
...
fixes #25653 . Also:
* Fully document all new hooks, methods, and classes in the upgrader.
* Rename 'language' to 'translation' inside the upgrader.
* Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.
Built from https://develop.svn.wordpress.org/trunk@25859
git-svn-id: http://core.svn.wordpress.org/trunk@25771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 22:29:09 +00:00
Andrew Nacin
ee489a2e81
Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
...
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25851
git-svn-id: http://core.svn.wordpress.org/trunk@25763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 21:24:10 +00:00
Andrew Nacin
c00bba9e8b
Use correct variable. fixes #10787 .
...
Built from https://develop.svn.wordpress.org/trunk@25843
git-svn-id: http://core.svn.wordpress.org/trunk@25755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 17:16:10 +00:00
Andrew Nacin
ee20af1fad
Notify administrators of successful, failed, and pending core updates.
...
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.
fixes #10787 .
Built from https://develop.svn.wordpress.org/trunk@25841
git-svn-id: http://core.svn.wordpress.org/trunk@25753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 16:30:11 +00:00
Andrew Nacin
859da01c4a
Delete expired transients on database upgrades.
...
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.
props dartiss, pento.
fixes #20316 .
Built from https://develop.svn.wordpress.org/trunk@25838
git-svn-id: http://core.svn.wordpress.org/trunk@25750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 07:48:09 +00:00
Andrew Nacin
5f3e90a112
Introduce email templates for automatic background updates.
...
The four templates are:
1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
2. We are not configured to update their site, so we notify them of the new release. ('notify')
3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2 , plus one sentence. ('fail')
4. We tried to update their site, and failed while copying files. ('critical')
With assistance from markjaquith.
see #10787 .
Built from https://develop.svn.wordpress.org/trunk@25837
git-svn-id: http://core.svn.wordpress.org/trunk@25749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 06:33:10 +00:00
Andrew Nacin
325ccd0a14
set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
...
fixes #25622 .
Built from https://develop.svn.wordpress.org/trunk@25836
git-svn-id: http://core.svn.wordpress.org/trunk@25748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:24:09 +00:00
Andrew Nacin
a65661abee
In automatic background updates, standardize on 'update'.
...
New, final filter names:
* auto_update_{$type} (plugin, theme, core, language)
* automatic_updates_is_vcs_checkout
* automatic_updates_disabled
New class name is WP_Automatic_Updater. Method names include update() and should_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25835
git-svn-id: http://core.svn.wordpress.org/trunk@25747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:21:10 +00:00
Dion Hulse
924e35d66a
Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
...
See #25576 , #22704
Built from https://develop.svn.wordpress.org/trunk@25831
git-svn-id: http://core.svn.wordpress.org/trunk@25743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 18:40:10 +00:00
Dion Hulse
1c8d882e13
For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
...
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704
Built from https://develop.svn.wordpress.org/trunk@25828
git-svn-id: http://core.svn.wordpress.org/trunk@25740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 05:24:09 +00:00
Andrew Nacin
9432acde4e
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 04:02:09 +00:00
Andrew Nacin
191efaef61
Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
...
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25823
git-svn-id: http://core.svn.wordpress.org/trunk@25735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:55:09 +00:00
Dion Hulse
640f73ecd2
Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25822
git-svn-id: http://core.svn.wordpress.org/trunk@25734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:12:10 +00:00
Dion Hulse
376a0a55c7
Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25818
git-svn-id: http://core.svn.wordpress.org/trunk@25730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 22:27:09 +00:00
Dion Hulse
ed07bab4b4
When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25817
git-svn-id: http://core.svn.wordpress.org/trunk@25729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:48:10 +00:00
Andrew Nacin
bccefbbd83
Merge the should_auto_update() and can_auto_update() methods. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25815
git-svn-id: http://core.svn.wordpress.org/trunk@25727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:35:09 +00:00
Dion Hulse
085f5c5fb9
Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25812
git-svn-id: http://core.svn.wordpress.org/trunk@25724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 17:07:08 +00:00
Dion Hulse
8c35982ae8
Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath.
...
See #18201
Built from https://develop.svn.wordpress.org/trunk@25811
git-svn-id: http://core.svn.wordpress.org/trunk@25723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 15:20:10 +00:00
Andrew Nacin
ba0ebf3736
Include translations in the update bubbles (as +1 if there are any). see #18200 .
...
Built from https://develop.svn.wordpress.org/trunk@25810
git-svn-id: http://core.svn.wordpress.org/trunk@25722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 14:34:10 +00:00
Dion Hulse
84cec7b526
Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin.
...
See #18200 , [25806]
Built from https://develop.svn.wordpress.org/trunk@25807
git-svn-id: http://core.svn.wordpress.org/trunk@25719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:19:09 +00:00
Dion Hulse
1c8e79353a
Language Packs: Many many fixes such as:
...
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200 , #22704
Built from https://develop.svn.wordpress.org/trunk@25806
git-svn-id: http://core.svn.wordpress.org/trunk@25718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:15:09 +00:00
Andrew Nacin
9fe39c464a
Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value.
...
Warnings included current(), filestat(), and md5_file().
see #18201 . see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25805
git-svn-id: http://core.svn.wordpress.org/trunk@25717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:02:09 +00:00
Andrew Nacin
4542fbb2ae
Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief.
...
Make sure we only do our pre-flight is_writable check when the file exists.
see #18201 . see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25801
git-svn-id: http://core.svn.wordpress.org/trunk@25713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:03:10 +00:00
Andrew Nacin
9507d22243
Use correct variable. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25800
git-svn-id: http://core.svn.wordpress.org/trunk@25712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 22:07:09 +00:00
Andrew Nacin
95831a8a67
Remove accidental debug cruft in [25780]. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25799
git-svn-id: http://core.svn.wordpress.org/trunk@25711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 21:24:09 +00:00
Andrew Nacin
2100fa65fd
Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet.
...
Thus, it will not work for 3.6 => 3.7, only 3.7+.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25798
git-svn-id: http://core.svn.wordpress.org/trunk@25710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:35:10 +00:00
Andrew Nacin
a6188bc84a
Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied.
...
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25797
git-svn-id: http://core.svn.wordpress.org/trunk@25709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:01:09 +00:00
Andrew Nacin
82547b21b6
In show_message(), only print error data if it is a string.
...
see #25576 , [25775].
Built from https://develop.svn.wordpress.org/trunk@25796
git-svn-id: http://core.svn.wordpress.org/trunk@25708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:51:10 +00:00
Andrew Nacin
26c03ea5fb
Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport.
...
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25794
git-svn-id: http://core.svn.wordpress.org/trunk@25706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:18:10 +00:00
Andrew Nacin
eeaad19a26
Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
...
This occurs when we can't copy a file. We chmod it and try again.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25793
git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:14:10 +00:00
Dion Hulse
592123951b
Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/.
...
My bad. See #22704 , [25781].
Built from https://develop.svn.wordpress.org/trunk@25787
git-svn-id: http://core.svn.wordpress.org/trunk@25699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 14:55:09 +00:00
Andrew Nacin
e503d0e2ec
Hide auto updates from update-core.php directly in get_core_updates(). see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25783
git-svn-id: http://core.svn.wordpress.org/trunk@25696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:07:10 +00:00
Andrew Nacin
957df34182
Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback.
...
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25782
git-svn-id: http://core.svn.wordpress.org/trunk@25695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 02:59:10 +00:00
Andrew Nacin
cdede88a23
Automatic updates: Include error data in the follow-up API request.
...
props dd32.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25781
git-svn-id: http://core.svn.wordpress.org/trunk@25694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 23:33:10 +00:00
Andrew Nacin
9b56d4d11f
Parse absolute paths out of error data. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25780
git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 22:25:08 +00:00
Dion Hulse
4dcca90887
Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
...
See #22704
Built from https://develop.svn.wordpress.org/trunk@25779
git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:55:09 +00:00