Commit Graph

43470 Commits

Author SHA1 Message Date
joedolson 7b5e14e987 Media: Associate upload errors and field with controls.
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.

Props afercia, anevins, antpb, adamsilverstein, poena
Fixes #47120
Built from https://develop.svn.wordpress.org/trunk@50352


git-svn-id: http://core.svn.wordpress.org/trunk@49963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 04:05:07 +00:00
Peter Wilson 147852757c Twenty Twenty-One: Display inline-images inline.
Remove `display: block` property from inline images and display them center aligned vertically.

Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes #52287.


Built from https://develop.svn.wordpress.org/trunk@50351


git-svn-id: http://core.svn.wordpress.org/trunk@49962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 02:26:08 +00:00
Peter Wilson 49f0fc9e53 Twenty Twenty-One: Match bullets between editor and frontend.
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.

Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes #52412.


Built from https://develop.svn.wordpress.org/trunk@50350


git-svn-id: http://core.svn.wordpress.org/trunk@49961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:52:04 +00:00
Peter Wilson 3ed24991ba Bundled Themes: Synchronise `.gitignore` with themes' svn ignore property.
Add `node_modules` directories within Twenty Twenty-One, Twenty Twenty and Twenty Nineteen to the `.gitignore` file.

Fixes #52502.

Built from https://develop.svn.wordpress.org/trunk@50349


git-svn-id: http://core.svn.wordpress.org/trunk@49960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:19:07 +00:00
Peter Wilson 8665ca27cc Twenty Twenty-One: Add CSS source map files to committed files.
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.

Props poena, peterwilsoncc.
Fixes #52377.


Built from https://develop.svn.wordpress.org/trunk@50348


git-svn-id: http://core.svn.wordpress.org/trunk@49959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:11:07 +00:00
ryelle 0e7386521b Bundled Themes: Support font size option for code block.
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.

Props poena, paaljoachim, peterwilsoncc.
Fixes #52431.


Built from https://develop.svn.wordpress.org/trunk@50347


git-svn-id: http://core.svn.wordpress.org/trunk@49958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:56:04 +00:00
ryelle ec38e1434a Twenty Thirteen: Fix alignment of child blocks within the Cover block.
Props kjellr, melchoyce.
Fixes #51224.


Built from https://develop.svn.wordpress.org/trunk@50346


git-svn-id: http://core.svn.wordpress.org/trunk@49957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:33:05 +00:00
Sergey Biryukov 18a16e0a91 Tests: Rename two classes in `phpunit/tests/http/` to match the function names.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50345


git-svn-id: http://core.svn.wordpress.org/trunk@49956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:07:06 +00:00
Sergey Biryukov 0bbe650e69 Tests: Add missing `@covers` tags for files in `phpunit/tests/http/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50344


git-svn-id: http://core.svn.wordpress.org/trunk@49955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:02:07 +00:00
youknowriad e276187b9a Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
The updated packages are:

@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7

Props isabel_brison.
Fixes #52525.

Built from https://develop.svn.wordpress.org/trunk@50343


git-svn-id: http://core.svn.wordpress.org/trunk@49954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 08:29:31 +00:00
Sergey Biryukov f1d362a2f3 Tests: Rename classes in `phpunit/tests/hooks/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292].
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50342


git-svn-id: http://core.svn.wordpress.org/trunk@49953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:22:02 +00:00
Sergey Biryukov 2d9dc11508 Tests: Add missing `@covers` tags for files in `phpunit/tests/hooks/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50341


git-svn-id: http://core.svn.wordpress.org/trunk@49952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:11:08 +00:00
Dominik Schilling 4491708fd1 Docs: Improve parameter types for various URL functions and filters that also accept `null`.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@50340


git-svn-id: http://core.svn.wordpress.org/trunk@49951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 15:16:08 +00:00
Sergey Biryukov 96edb89edb Tests: Add missing `@covers` tags for files in `phpunit/tests/general/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50339


git-svn-id: http://core.svn.wordpress.org/trunk@49950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:49:03 +00:00
Sergey Biryukov 8fdd713cb2 Tests: Simplify `@covers` tags in `editor/wpEditors.php` using `@coversDefaultClass` annotation.
Follow-up to [50288].

See #39265.
Built from https://develop.svn.wordpress.org/trunk@50338


git-svn-id: http://core.svn.wordpress.org/trunk@49949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:47:11 +00:00
Sergey Biryukov e56a6d1a71 Tests: Use `@ticket` annotation for ticket numbers, for clarity.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50337


git-svn-id: http://core.svn.wordpress.org/trunk@49948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 12:19:06 +00:00
gziolo fde749f4e4 Tests: Fix failing unit test for block settings
Follow-up to [50297].

Fixes #52512.



Built from https://develop.svn.wordpress.org/trunk@50300


git-svn-id: http://core.svn.wordpress.org/trunk@49945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:41:03 +00:00
desrosj 00e80bf777 Build/Test Tools: Run xDebug tests on PHP 8.0.
The PHP 8 Docker container for the local WordPress environment now contains xDebug 3.x (the version required for running on PHP 8), so the `xdebug` test group can now be run.

See #50401, #51802.
Built from https://develop.svn.wordpress.org/trunk@50299


git-svn-id: http://core.svn.wordpress.org/trunk@49944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:38:04 +00:00
desrosj 741e056ed7 Build/Test Tools: Run automated testing when tags are created.
This expands the list of events that triggers automated testing to include tags.

It also refines the matched version ranges for several workflows.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@50298


git-svn-id: http://core.svn.wordpress.org/trunk@49943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:03:10 +00:00
gziolo 135a35fd04 Blocks: Add missing apiVersion field when preparing server-registered blocks for the block editor
When working on changes to @wordpress/create-block tool (https://github.com/WordPress/gutenberg/pull/28883) to use register_block_type_from_metadata with block.json file in the templates for scaffolded blocks I run into this issue where apiVersion wasn't exposed from the server.

Fixes #52512.


Built from https://develop.svn.wordpress.org/trunk@50297


git-svn-id: http://core.svn.wordpress.org/trunk@49942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:00:06 +00:00
Sergey Biryukov 463df820f8 Block Editor: Remove extra quotes from the default font stack for editor styles.
Follow-up to [50155].

Props dd32, Joen, kafleg.
Fixes #46169.
Built from https://develop.svn.wordpress.org/trunk@50295


git-svn-id: http://core.svn.wordpress.org/trunk@49940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 07:55:06 +00:00
Peter Wilson d0cf9db65c Site Health: Update `site-health` script dependencies.
Add `wp-hooks` and `wp-i18n` to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes #52483.

Built from https://develop.svn.wordpress.org/trunk@50294


git-svn-id: http://core.svn.wordpress.org/trunk@49939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 00:10:04 +00:00
Peter Wilson 95fb827816 Twenty Twenty-One: Correct accent marks in block pattern alt text.
Correct accents in "Roses Trémières" for block patterns and starter content.

Props audrasjb, geekzebre, kjellr, SergeyBiryukov.
Fixes #52500.


Built from https://develop.svn.wordpress.org/trunk@50293


git-svn-id: http://core.svn.wordpress.org/trunk@49938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 00:03:04 +00:00
Sergey Biryukov 29574d526d Tests: Rename some files and classes in `phpunit/tests/general/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291].

See #51802.
Built from https://develop.svn.wordpress.org/trunk@50292


git-svn-id: http://core.svn.wordpress.org/trunk@49937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 21:40:11 +00:00
Sergey Biryukov 2553af179d Tests: Rename some classes in `phpunit/tests/date/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327].

See #51802.
Built from https://develop.svn.wordpress.org/trunk@50291


git-svn-id: http://core.svn.wordpress.org/trunk@49936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 21:22:04 +00:00
Sergey Biryukov cfacfa87c4 Tests: Add missing `@covers` tags for files in `phpunit/tests/external-http/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50290


git-svn-id: http://core.svn.wordpress.org/trunk@49935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:57:08 +00:00
Sergey Biryukov eebc1705a8 Tests: Add missing `@covers` tags for files in `phpunit/tests/error-protection/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50289


git-svn-id: http://core.svn.wordpress.org/trunk@49934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:56:05 +00:00
Sergey Biryukov 9d739f6be3 Tests: Add missing `@covers` tags for files in `phpunit/tests/editor/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50288


git-svn-id: http://core.svn.wordpress.org/trunk@49933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:54:16 +00:00
Sergey Biryukov 7034111a38 Tests: Add missing `@covers` tags for files in `phpunit/tests/dependencies/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50287


git-svn-id: http://core.svn.wordpress.org/trunk@49932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 15:17:07 +00:00
Sergey Biryukov 262234df8d Tests: Add missing `@covers` tags for files in `phpunit/tests/db/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50286


git-svn-id: http://core.svn.wordpress.org/trunk@49931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 14:04:09 +00:00
desrosj 1cfa0a1370 Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.
The WordPress Importer plugin is now downloaded to the `tests/phpunit/data/plugins` directory when running `npm run env:install`.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new `WP_IMPORTER_REVISION` variable to the `.env` file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes #49720.
Built from https://develop.svn.wordpress.org/trunk@50285


git-svn-id: http://core.svn.wordpress.org/trunk@49930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 16:54:07 +00:00
Sergey Biryukov fc8e180035 Tests: Use `assertSame()` in some newly introduced tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [49904], [49925], [49992], [50012], [50013], [50065], [50075], [50131], [50150], [50157].

See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50284


git-svn-id: http://core.svn.wordpress.org/trunk@49929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:27:02 +00:00
Sergey Biryukov 24dbafaba5 Tests: Replace most instances of `assertEquals()` in `phpunit/includes/` with `assertSame()`.
Follow-up to [48937], [48939], [48940], [48944].

Props johnbillion, jrf, SergeyBiryukov.
See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50283


git-svn-id: http://core.svn.wordpress.org/trunk@49928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:25:09 +00:00
Peter Wilson 0f251cdd90 Canonical: Rename `wp_force_plain_ugly_permalink()` to match UI terminology.
Rename `wp_force_plain_ugly_permalink()` to `wp_force_plain_post_permalink()` to match terminology used in the WordPress dashboard.

Follow up to [50132].
Props SergeyBiryukov.
Fixes #5272.


Built from https://develop.svn.wordpress.org/trunk@50282


git-svn-id: http://core.svn.wordpress.org/trunk@49927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 05:40:07 +00:00
desrosj 30da2b425d Post WordPress 5.7 Beta 2 version bump.
Built from https://develop.svn.wordpress.org/trunk@50281


git-svn-id: http://core.svn.wordpress.org/trunk@49926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:40:04 +00:00
desrosj bcbad3aef8 WordPress 5.7 Beta 2.
Built from https://develop.svn.wordpress.org/trunk@50280


git-svn-id: http://core.svn.wordpress.org/trunk@49925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:26:05 +00:00
Sergey Biryukov 38696a7290 Tests: Add missing `@covers` tags for files in `phpunit/tests/date/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50279


git-svn-id: http://core.svn.wordpress.org/trunk@49924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:57:02 +00:00
ryelle 10d1280ff3 Administration: Update color contrast on UI elements.
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.

Follow-up to [50025].
Props audrasjb, joedolson.
Fixes #52402.


Built from https://develop.svn.wordpress.org/trunk@50278


git-svn-id: http://core.svn.wordpress.org/trunk@49923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:47:03 +00:00
desrosj ac126c1062 Build/Test Tools: Synchronize `svn:ignore` with `.gitignore`.
Some files ignored within the `.gitignore` file were not included in the `svn:ignore` property.

This also removed `wp-config.php` and `wp-tests-config.php` from the `svn:ignore` property. It’s already specified in `svn:global-ignores`.

Props johnbillion.
Fixes #49784.
Built from https://develop.svn.wordpress.org/trunk@50277


git-svn-id: http://core.svn.wordpress.org/trunk@49922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:42:05 +00:00
Sergey Biryukov 7cae8b1c02 Tests: Correct the test for `NOT BETWEEN` comparison operator in `WP_Date_Query`.
Follow-up to [29793].

Props patopaiar, jrf.
See #39265, #51802.
Built from https://develop.svn.wordpress.org/trunk@50276


git-svn-id: http://core.svn.wordpress.org/trunk@49921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:10:04 +00:00
Sergey Biryukov 8212925c11 Twenty Twenty: Make ordered list styling in classic editor match the front-end style.
Props sabernhardt, sebastienserre, hareesh-pillai.
Fixes #50454.
Built from https://develop.svn.wordpress.org/trunk@50275


git-svn-id: http://core.svn.wordpress.org/trunk@49920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:54:04 +00:00
antpb 0c5a3fa2ed Media: Make `adjacent_image_link()` include alt text when returning an image.
When using the `adjacent_image_link()` function there is a condition that will return a linked image. Previously, the returned image was sent without alt attributes.

Now, `adjacent_image_link()` will include alt attributes of the image's title when an image is returned.

Props joedolson, Mista-Flo, sabernhardt.
Fixes #52387.

Built from https://develop.svn.wordpress.org/trunk@50274


git-svn-id: http://core.svn.wordpress.org/trunk@49919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:27:05 +00:00
Sergey Biryukov 8bd0709dba Twenty Twenty-One: Use correct value for the global `line-height` CSS variable.
Props acerempel, mukesh27, dd32, poena.
Fixes #52477.
Built from https://develop.svn.wordpress.org/trunk@50273


git-svn-id: http://core.svn.wordpress.org/trunk@49918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:10:05 +00:00
Sergey Biryukov 2fdd20da49 Site Health: Link to the support article on troubleshooting in "There has been a critical error" message.
This page is more geared towards users than the one on debugging, which is more developer-oriented.

Props audrasjb, Clorith, Ipstenu.
Fixes #52392.
Built from https://develop.svn.wordpress.org/trunk@50272


git-svn-id: http://core.svn.wordpress.org/trunk@49917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:59:04 +00:00
John Blackbourn 3e801fdb5d Comments: Extend the duration of the window within which unapproved comments are visible by their author.
This extension is necessary because the comment approval notification opt-in form introduced in [47887] uses the same mechanism, and the previous limit of one minute meant that users on a slow connection, using assistive technology, with limited motor skills, or who are generally indecisive may not complete the opt-in action within one minute, and therefore not see the confirmation message.

Props joedolson, imath, hellofromTonya, peterwilsoncc, alexstine, davidbaumwald 

Fixes #52406

Built from https://develop.svn.wordpress.org/trunk@50271


git-svn-id: http://core.svn.wordpress.org/trunk@49916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:57:04 +00:00
Sergey Biryukov 4fd440cd5c External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in the `image-edit.js` library and the `imgAreaSelect` jQuery plugin

Follow-up to [50001].

Props Clorith, poena, dariak, jeroenrotty.
See #51812.
Built from https://develop.svn.wordpress.org/trunk@50270


git-svn-id: http://core.svn.wordpress.org/trunk@49915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:45:06 +00:00
desrosj 34987fe903 Twenty Twenty-One: Prevent Dark Mode related JavaScript error.
This prevents an `Uncaught TypeError` in the block editor when scrolling caused by the absence of a `#dark-mode-toggler` element.

Props ocean90, mukesh27, justinahinon.
Fixes #52473.
Built from https://develop.svn.wordpress.org/trunk@50269


git-svn-id: http://core.svn.wordpress.org/trunk@49914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:56:04 +00:00
desrosj d0c1e2b97b Build/Test Tools: Correct some inline documentation within GitHub Action files.
This corrects several inaccuracies within the GitHub Action workflow files.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@50268


git-svn-id: http://core.svn.wordpress.org/trunk@49913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:18:03 +00:00
desrosj 5972493ca5 Build/Test Tools: Update NPM dependencies.
This updates two `devDependencies`:

- `uglify-js` from `3.12.6` to `3.12.7`.
- `check-node-version` from `4.0.3` to `4.1.0`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@50267


git-svn-id: http://core.svn.wordpress.org/trunk@49912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:16:19 +00:00
John Blackbourn ea252a7cba Posts, Post Types: Clarify the documentation about the return value of `get_post()` when a falsey value is passed.
Props Rahe, juliobox, peterwilsoncc, hellofromTonya, audrasjb

Fixes #33068

Built from https://develop.svn.wordpress.org/trunk@50266


git-svn-id: http://core.svn.wordpress.org/trunk@49911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 13:44:04 +00:00