Commit Graph

30932 Commits

Author SHA1 Message Date
Helen Hou-Sandí 6e73f1282e List tables: Better accessibility and design for the comments bubble.
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.

Built from https://develop.svn.wordpress.org/trunk@33155


git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:44:25 +00:00
Konstantin Obenland f29e5044cd Site Icon: Add Customizer UI.
Second part of the Site Icon feature after [32994] introduced it for Settings.

Props celloexpressions.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33154


git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:33:24 +00:00
Dominik Schilling 75d6c10b01 Customizer: Use a `<button>` for the collapse sidebar … button.
props afercia.
fixes #32819.
Built from https://develop.svn.wordpress.org/trunk@33153


git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:22:26 +00:00
Dominik Schilling f0db1e0bb7 Customizer: Replace the plus icon for `#available-menu-items .item-add` with a thinner one, see [33126].
fixes #32734.
Built from https://develop.svn.wordpress.org/trunk@33152


git-svn-id: http://core.svn.wordpress.org/trunk@33124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 22:09:25 +00:00
Dominik Schilling bff15bf681 Customizer: Improve markup for available menu items.
* Use lists for available menu items.
* Remove unused template for available item types.
* Hide the type label and title from screen readers and instead include them in the add button.

props celloexpressions, afercia.
fixes #32724.
Built from https://develop.svn.wordpress.org/trunk@33151


git-svn-id: http://core.svn.wordpress.org/trunk@33123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 22:00:25 +00:00
Dominik Schilling 106b0675b9 Customizer: Use the new dashicon for the Preview/Customize toggle in narrow screens.
see #30902, #28784.
Built from https://develop.svn.wordpress.org/trunk@33150


git-svn-id: http://core.svn.wordpress.org/trunk@33122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 21:05:25 +00:00
Dominik Schilling 41a8b24a8f List tables: Remove a black colored separator in Quick Edit for pages.
fixes #32842.
Built from https://develop.svn.wordpress.org/trunk@33149


git-svn-id: http://core.svn.wordpress.org/trunk@33121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 20:57:24 +00:00
Scott Taylor 6cc3a903d7 Revert [32851] and [32850] for now, tl;dr encoding issues.
See #17780.


Built from https://develop.svn.wordpress.org/trunk@33148


git-svn-id: http://core.svn.wordpress.org/trunk@33120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 20:56:24 +00:00
Helen Hou-Sandí 3e292a2426 Toolbar: Don't show the customize link in the admin.
props afragen.
fixes #32945.

Built from https://develop.svn.wordpress.org/trunk@33147


git-svn-id: http://core.svn.wordpress.org/trunk@33119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 19:19:24 +00:00
Helen Hou-Sandí 70a8c3e83d List tables: Better focus styling for the row toggle.
This circular focus styling could probably be expanded to other areas of the admin.

props hugobaeta.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33146


git-svn-id: http://core.svn.wordpress.org/trunk@33118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 19:12:25 +00:00
Helen Hou-Sandí e023d86c74 Update Akismet external to 3.1.3 in trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@33117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 17:03:19 +00:00
Jeremy Felt 8431399e2e Fix missing period in missing site error.
Props @ocean90.
See #32934.

Built from https://develop.svn.wordpress.org/trunk@33145


git-svn-id: http://core.svn.wordpress.org/trunk@33116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:33:25 +00:00
Jeremy Felt eb26a74073 Avoid PHP notice when attempting to edit a site that does not exist.
Show a more explicit error - "The requested site does not exist."

Fixes #32934.

Built from https://develop.svn.wordpress.org/trunk@33144


git-svn-id: http://core.svn.wordpress.org/trunk@33115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:29:24 +00:00
Jeremy Felt 0bc0b0c917 Do not allow deletion of a super admin user through `wpmu_delete_user()`.
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.

Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935.

Built from https://develop.svn.wordpress.org/trunk@33143


git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:16:25 +00:00
Dominik Schilling 6963767a7c Remove debug cruft from [33124].
see #28909.
Built from https://develop.svn.wordpress.org/trunk@33142


git-svn-id: http://core.svn.wordpress.org/trunk@33113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 07:56:24 +00:00
Andrew Ozz 7e51b698c6 TinyMCE: when deleting an image, ensure the wrapping link (if any) is deleted too. Fixes the erroneous showing of the link toolbar after deleting an image. Also small readability fix.
See #32604. 
Built from https://develop.svn.wordpress.org/trunk@33141


git-svn-id: http://core.svn.wordpress.org/trunk@33112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 00:25:25 +00:00
Konstantin Obenland d5de83fb6e 4.3-beta2-33140
Built from https://develop.svn.wordpress.org/trunk@33140


git-svn-id: http://core.svn.wordpress.org/trunk@33111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 22:06:25 +00:00
Konstantin Obenland 323eb2299b 4.3-beta2
Built from https://develop.svn.wordpress.org/trunk@33139


git-svn-id: http://core.svn.wordpress.org/trunk@33110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:39:24 +00:00
Weston Ruter 3e58b38b28 Customizer: Remove additional wrapper element around `wp_nav_menu()` which broke some theme designs.
Also includes these related changes:
* Export `oldContainer` and `newContainer` among the `customize-preview-menu-refreshed` event params for themes to be able to more easily re-initialize the DOM elements.
* Improve performance for partial refresh by only sending settings related to the menu being previewed.
* Fix previewing of menu assigned to Custom Menu by exporting a menu `term_id` as opposed to an object, as the former is more stable for comparing in in args hashes.
* Do full refresh of preview when nav menu unassigned so that the layout can be updated.
* Harden conditions for when partial refresh is eligible for a `wp_nav_menu()` instance.

Fixes #32841.

Built from https://develop.svn.wordpress.org/trunk@33138


git-svn-id: http://core.svn.wordpress.org/trunk@33109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:30:24 +00:00
Dominik Schilling 73d57e6c86 Add/Edit User: Move weak password label to the checkbox.
props paulwilde.
fixes #32908.
Built from https://develop.svn.wordpress.org/trunk@33137


git-svn-id: http://core.svn.wordpress.org/trunk@33108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:28:25 +00:00
Dominik Schilling 5fff9d1ef7 Customizer: Use `visibility` to hide available widgets and menu items panels from screen readers and to move them out of tab order.
props afercia.
fixes #32883.
Built from https://develop.svn.wordpress.org/trunk@33136


git-svn-id: http://core.svn.wordpress.org/trunk@33107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:21:25 +00:00
Boone Gorges e8c6340f67 Improvements to responsive styling on my-sites.php.
* Ensure that floated elements break to a new line at the end of a row.
* Allow enough vertical space for long site titles.
* Give more breathing room to cells at narrow widths.

Fixes #31685.
Built from https://develop.svn.wordpress.org/trunk@33135


git-svn-id: http://core.svn.wordpress.org/trunk@33106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:02:24 +00:00
Weston Ruter 3f64c0ee9e Customizer: Defer listening to nav menu setting changes until active.
Defer the preview starting to listen to setting changes until after the Customizer has synced settings into the preview. This ensures that any differences between the JS and PHP representations of the settings won't cause an infinite refresh.

See #32911.
Fixes #32894.

Built from https://develop.svn.wordpress.org/trunk@33134


git-svn-id: http://core.svn.wordpress.org/trunk@33105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:42:24 +00:00
Dominik Schilling 28ecfd83c6 Updates: Select All should not be a column header.
See #31654.

props tywayne.
fixes #32905.
Built from https://develop.svn.wordpress.org/trunk@33133


git-svn-id: http://core.svn.wordpress.org/trunk@33104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:38:25 +00:00
Helen Hou-Sandí 54428b546e Spinners: Ensure one appears in the lost connection notice.
fixes #32914.

Built from https://develop.svn.wordpress.org/trunk@33132


git-svn-id: http://core.svn.wordpress.org/trunk@33103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:20:24 +00:00
Weston Ruter 9e26f1db4c Customizer: Prevent loss of `walker` and `fallback_cb` args for `wp_nav_menu`.
These args only need to be cleared out when exported to JavaScript, when they are not JSON-serializable. So the filter now clears these when gathering args for exporting to JS, but otherwise now leaves the original values to be passed through to `wp_nav_menu()`.

Fixes #32781.

Built from https://develop.svn.wordpress.org/trunk@33131


git-svn-id: http://core.svn.wordpress.org/trunk@33102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:18:27 +00:00
Helen Hou-Sandí 28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:03:24 +00:00
Aaron Jorbin 4ec14ee206 Remove grunt-autoprefixer in favor of grunt-postcss with autoprefixer
grunt-autoprefixer was deprecated - e020f878d5
None of the autoprefixer tasks should have been called directly, so they are now removed.  `grunt precommit` and `grunt build` still work exactly as they should.  This change doesn't affect the output of our builds.

An NPM install is required after you have updated after this change.

See #31700
Props netweb


Built from https://develop.svn.wordpress.org/trunk@33129


git-svn-id: http://core.svn.wordpress.org/trunk@33100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:54:31 +00:00
Andrew Ozz 4cd790906f TinyMCE, Press This: add the `wptextpattern` plugin to the Press This editor.
See #31441.
Built from https://develop.svn.wordpress.org/trunk@33128


git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:53:25 +00:00
Andrew Ozz cacf51c3ec TinyMCE: add help for the text patterns to the shortcuts help popup.
See #31441.
Built from https://develop.svn.wordpress.org/trunk@33127


git-svn-id: http://core.svn.wordpress.org/trunk@33098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:43:24 +00:00
Dominik Schilling 34eb53b4e6 Dashicons: Update to the latest files.
Revert the updates to .dashicons-plus (f132) in [33108] and instead introduce a new icon, .dashicons-plus-alt2 (f543).

props liljimmi, melchoyce, empireoflight.
see #30902.
Built from https://develop.svn.wordpress.org/trunk@33126


git-svn-id: http://core.svn.wordpress.org/trunk@33097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:38:25 +00:00
John Blackbourn da3571f9ca Skip the `Tests_Option_Transient::test_nonexistent_key_old_timeout()` tests on multisite for now.
See #31130
Fixes #30380

Built from https://develop.svn.wordpress.org/trunk@33125


git-svn-id: http://core.svn.wordpress.org/trunk@33096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 18:24:25 +00:00
Dominik Schilling efda1aeb3a Update PHPMailer to 5.2.10 from 5.2.7.
Includes two modifications for WordPress:
* Removes support for NTLM in `class-smtp.php` since the required client (`extras/ntlm_sasl_client.php`) is not distributed as part of WordPress.
* Requires `class-smtp.php` for backwards compatibility with direct (non-wp_mail()) uses of PHPMailer, as the autoloader isn't used. See [27385].

This also includes a change to our `MockMailer` for unit tests. It now overrides `postSend() instead of `send()`, and `preSend()`.
`preSend()` resets `$this->Encoding` because PHPMailer doesn't clean up after itself / presets all variables. This becomes an issue when `PHPMailer::createBody()` sets `$this->Encoding = 'quoted-printable'` (away from it's default of 8bit) when it encounters a line longer than 998 characters. `Tests_Comment::test_comment_field_lengths` is such a case.

props MattyRob, dd32.
fixes #28909.
Built from https://develop.svn.wordpress.org/trunk@33124


git-svn-id: http://core.svn.wordpress.org/trunk@33095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 17:16:25 +00:00
Aaron Jorbin 0ec584c51f Remove PHP4 constructors from Unit Tests
If you are subclassing these classes in your own tests, you'll need to update your code.

Props johnbillion
See #31982


Built from https://develop.svn.wordpress.org/trunk@33123


git-svn-id: http://core.svn.wordpress.org/trunk@33094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 16:05:26 +00:00
Helen Hou-Sandí 30e478b1fb Move `get_default_comment_status()` to `wp-includes/comment.php` to sit alongside `get_comment_statuses()`.
props nacin.
see #31168.

Built from https://develop.svn.wordpress.org/trunk@33122


git-svn-id: http://core.svn.wordpress.org/trunk@33093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 15:44:28 +00:00
Sergey Biryukov 1276096e3a Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
props afercia.
fixes #32916.
Built from https://develop.svn.wordpress.org/trunk@33121


git-svn-id: http://core.svn.wordpress.org/trunk@33092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 06:48:24 +00:00
Weston Ruter 4f93c26f87 Customizer: Prevent preview from loading during QUnit tests and causing an XHR cross-domain error.
Fixes #32666.

Built from https://develop.svn.wordpress.org/trunk@33120


git-svn-id: http://core.svn.wordpress.org/trunk@33091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 05:38:25 +00:00
John Blackbourn e2cbf49a2c Introduce unit tests for `sanitize_option()`.
Props MikeHansenMe, welcher, johnbillion
See #32351

Built from https://develop.svn.wordpress.org/trunk@33119


git-svn-id: http://core.svn.wordpress.org/trunk@33090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 00:06:25 +00:00
John Blackbourn bc745f81a9 Allow shortcode parameter names (attributes) to contain dashes.
Props aaroncampbell, tyxla, izem
Fixes #9405

Built from https://develop.svn.wordpress.org/trunk@33118


git-svn-id: http://core.svn.wordpress.org/trunk@33089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:59:24 +00:00
Helen Hou-Sandí 9c3bc85649 Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.

Built from https://develop.svn.wordpress.org/trunk@33117


git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:11:24 +00:00
Scott Taylor 6c90a44828 After [32980], update the docs to reflect that `display_name` is now included when searching for users in some scenarios.
Fixes #27304.

Built from https://develop.svn.wordpress.org/trunk@33116


git-svn-id: http://core.svn.wordpress.org/trunk@33087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:39:25 +00:00
Scott Taylor 6b034b67f5 In `wp_insert_user()`, comparing an email address against the user's old email address should not be case-sensitive.
Adds unit tests.

Props tyxla.
Fixes #32158.

Built from https://develop.svn.wordpress.org/trunk@33115


git-svn-id: http://core.svn.wordpress.org/trunk@33086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:29:24 +00:00
Scott Taylor 0deed4b842 In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present.
Props tyxla.
Fixes #32889.

Built from https://develop.svn.wordpress.org/trunk@33114


git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:19:24 +00:00
Konstantin Obenland 2cc8269741 Hide notices introduced in [30505] on about page.
See #19237.

Props jadpm.
Fixes #32625.


Built from https://develop.svn.wordpress.org/trunk@33113


git-svn-id: http://core.svn.wordpress.org/trunk@33084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 18:47:25 +00:00
Konstantin Obenland 52c2567424 Menus: Respect context when linking to the Customizer.
`Manage in Customizer` will now link to menu locations or the menus panel in
the customizer, depending on whether the user is editing menus or managing
locations.

Props rabmalin for initial patch.
Fixes #32852.


Built from https://develop.svn.wordpress.org/trunk@33112


git-svn-id: http://core.svn.wordpress.org/trunk@33083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:49:24 +00:00
Konstantin Obenland ee9cb55e1a Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.


Built from https://develop.svn.wordpress.org/trunk@33111


git-svn-id: http://core.svn.wordpress.org/trunk@33082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:14:25 +00:00
Dominik Schilling 92fe9c9649 Transients: If `get_option( $transient_timeout )` returns false, don't bother trying to delete the transient in `get_transient()`.
props jamesgol, ericmann.
fixes #30380.
Built from https://develop.svn.wordpress.org/trunk@33110


git-svn-id: http://core.svn.wordpress.org/trunk@33081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:45:26 +00:00
Helen Hou-Sandí acad0e2008 Better styling for `.form-invalid` inputs.
props liljimmi.
fixes #32490.

Built from https://develop.svn.wordpress.org/trunk@33109


git-svn-id: http://core.svn.wordpress.org/trunk@33080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:41:25 +00:00
Dominik Schilling 7bbf64a2b9 Dashicons: Update to the latest files.
New icons:
* .dashicons-admin-customizer (f540)
* .dashicons-admin-multisite (f541)
* .dashicons-editor-table (f535)
* .dashicons-filter (f536)
* .dashicons-hidden (f530)
* .dashicons-image-filter (f533)
* .dashicons-image-rotate (f531)
* .dashicons-layout (f538)
* .dashicons-sticky (f537)
* .dashicons-thumbs-down (f542)
* .dashicons-thumbs-up (f529)
* .dashicons-unlock (f528)
* .dashicons-warning (f534)

Updated icons:
* .dashicons-plus (f132)
* .dashicons-yes (f147)

props liljimmi, melchoyce, empireoflight.
fixes #30902.
Built from https://develop.svn.wordpress.org/trunk@33108


git-svn-id: http://core.svn.wordpress.org/trunk@33079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:03:26 +00:00
Helen Hou-Sandí e5c6186dd4 Menu customizer: Ensure item type doesn't collide with the handle focus glow.
props andg, metodiew.
fixes #32813.

Built from https://develop.svn.wordpress.org/trunk@33107


git-svn-id: http://core.svn.wordpress.org/trunk@33078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:52:25 +00:00