Commit Graph

16335 Commits

Author SHA1 Message Date
Gary Pendergast 18bb886b22 When sanitizing a URL to redirect to, UTF-8 characters can be URL encoded, instead of being removed.
While RFC 3986 does not specify which character sets are allowed in URIs, Section 2.5 states that octects matching UTF-8 character encoding should be percent-encoded, then unreserved octets outside of the UTF-8 range should be percent-encoded. As browsers tend to only implement support for UTF-8 in URLs, this change only implements the UTF-8 encoding part. We may revisit the second part if it becomes an issue.

Fixes #31486


Built from https://develop.svn.wordpress.org/trunk@31587


git-svn-id: http://core.svn.wordpress.org/trunk@31568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 02:21:26 +00:00
Andrew Ozz 5aae51144d TinyMCE wpView: update the "update" method. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31586


git-svn-id: http://core.svn.wordpress.org/trunk@31567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 22:29:26 +00:00
Scott Taylor 7acfb7740b In the `Insert From URL` state of the `Post` frame, add the necessary CSS for focus styles for images.
Example image to insert: https://flic.kr/p/rnsm5M 

See #28820.

Built from https://develop.svn.wordpress.org/trunk@31585


git-svn-id: http://core.svn.wordpress.org/trunk@31566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 22:13:27 +00:00
Andrew Ozz 0b626ffea2 PressThis: when there is a protocol mismatch (http vs. https), use server-side media detection instead of submitting a form as it triggers "Unsafe data" warning in some browsers. Props stephdau. Fixes #31468.
Built from https://develop.svn.wordpress.org/trunk@31584


git-svn-id: http://core.svn.wordpress.org/trunk@31565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 22:06:25 +00:00
Andrew Ozz 9f86b1023b PressThis: fix selecting a post format (radio buttons) with the keyboard. Props afercia, Michael-Arestad. Fixes #31440.
Built from https://develop.svn.wordpress.org/trunk@31583


git-svn-id: http://core.svn.wordpress.org/trunk@31564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 21:53:25 +00:00
Scott Taylor 39dabbb8b1 When viewing media in List mode, auto-submit the form for attachment filters when the value of a `<select>` changes. This makes it behave similar to Grid mode and "feels" more performant, even though it is a full page load.
Fixes #30333.

Built from https://develop.svn.wordpress.org/trunk@31582


git-svn-id: http://core.svn.wordpress.org/trunk@31563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 21:27:25 +00:00
Boone Gorges 3db78d6a24 Introduce 'get_object_terms' filter in `wp_get_object_terms()`.
The existing 'wp_get_object_terms' filter accepts a parameter `$taxonomies`,
which is a list of taxonomy names formatted for direct use in a MySQL IN clause.
This formatting makes it difficult to make use of the taxonomy list in filter
callbacks. However, changing the parameters passed to the existing filter
raises backward compatibility concerns, so we introduce a new filter that
receives a structured `$taxonomy_array` parameter.

We also take this opportunity to correct and clean up some of the documentation
on the 'wp_get_object_terms' filter.

Props postpostmodern, doublesharp, wonderboymusic, nacin.
Fixes #18828.
Built from https://develop.svn.wordpress.org/trunk@31581


git-svn-id: http://core.svn.wordpress.org/trunk@31562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 20:31:26 +00:00
Andrew Ozz 848cd46e9a PressThis TinyMCE: set 'directionality' and add the LTR button when in RTL. Fixes #31474.
Built from https://develop.svn.wordpress.org/trunk@31580


git-svn-id: http://core.svn.wordpress.org/trunk@31561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 20:21:24 +00:00
Dominik Schilling 03a50ce509 Build: Let RTLCSS handle swapping the codes for right/left arrows from Dashicons.
Exclude `wp-includes/css/dashicons.css` from core task since we don't want/need a RTL version of it.

fixes #31478.
Built from https://develop.svn.wordpress.org/trunk@31579


git-svn-id: http://core.svn.wordpress.org/trunk@31560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 20:19:29 +00:00
Scott Taylor 7994009296 Support GIMP files in the Media Library. We already support Photoshop files.
Props MikeHansenMe.
Fixes #31146.

Built from https://develop.svn.wordpress.org/trunk@31578


git-svn-id: http://core.svn.wordpress.org/trunk@31559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:47:25 +00:00
Dominik Schilling c7dba8b015 Press This: RTL improvements.
* Load the RTL version of press-this-editor.css.
* Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.
Built from https://develop.svn.wordpress.org/trunk@31577


git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:44:24 +00:00
Scott Taylor dbc38ea246 In the `->multi_resize()` method of the `WP_Image_Editor` subclasses, when looping through potential crops, we need to make sure the crop isn't the exact same dimensions as the original image before copying it as a new crop.
This ensures that we don't save multiple copies of the same image.

Supposedly broke in [30639], but this logic was always missing. When I tested reverting [30639], there were still 2 files being created.

Fixes #31296.

Built from https://develop.svn.wordpress.org/trunk@31576


git-svn-id: http://core.svn.wordpress.org/trunk@31557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:38:27 +00:00
Scott Taylor f6b1b01ecd Make a new function, `wp_delete_file()`. Use it.
Props scribu, wonderboymusic.
Fixes #17864.

Built from https://develop.svn.wordpress.org/trunk@31575


git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 16:51:25 +00:00
Scott Taylor 295af37bd0 Improve `get_media_embedded_in_content()` so that it returns the media it finds in the same order that it appears in the content.
Adds unit test, updates another.

Props kopepasah.
See #26675.

Built from https://develop.svn.wordpress.org/trunk@31574


git-svn-id: http://core.svn.wordpress.org/trunk@31555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 16:11:25 +00:00
Dominik Schilling d2f0abf85f RTL CSS generation: Switch from CSSJanus to RTLCSS.
CSSJanus (introduced in [26107]), we had a great time with you, but sadly you don't like our fancy CSS.

RTLCSS is a framework for converting CSS from LTR to RTL, same as CSSJanus, with support for more CSS properties like `transform`, `transition` or multiple box and text shadows.

Changes:
* devDependencies: Remove `grunt-cssjanus`, add `grunt-rtlcss`.
* RTLCSS uses `/* rtl:ignore */` to ignore a rule, switch existing `/* @noflip */` to the new directive.
* RTLCSS supports the `transform` property, means we can remove some ignore rules.
* RTLCSS supports string maps for custom replace rules. This commit includes a rule `import-rtl-stylesheet` which replaces ".css" with "-rtl.css" in URLs.

Notes for core development:
* The file generation task is still `grunt rtl`.
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Remember the new directive `/* rtl:ignore */`.

fixes #31332.

Build: https://build.trac.wordpress.org/changeset/31554
Built from https://develop.svn.wordpress.org/trunk@31573


git-svn-id: http://core.svn.wordpress.org/trunk@31554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 13:41:30 +00:00
Dominik Schilling 043cf80e75 Press This: Add press-this to list of RTL styles.
see #31373.
Built from https://develop.svn.wordpress.org/trunk@31572


git-svn-id: http://core.svn.wordpress.org/trunk@31553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 11:22:25 +00:00
Dominik Schilling 5e47a1f633 Press This: Use boolean value instead of __return_true(). Add missing hook docs.
see #31373.
Built from https://develop.svn.wordpress.org/trunk@31571


git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 11:15:25 +00:00
Dominik Schilling 789cd2e824 Customize Widgets: Don't return undefined items in getWidgetFormControls method.
props westonruter.
fixes #31465.
Built from https://develop.svn.wordpress.org/trunk@31570


git-svn-id: http://core.svn.wordpress.org/trunk@31551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 10:35:24 +00:00
Dominik Schilling 8f44036ea7 Update jQuery UI to 1.11.3.
Changelog:
* http://jqueryui.com/changelog/1.11.3/
* https://github.com/jquery/jquery-ui/compare/1.11.2...1.11.3

fixes #31473.
Built from https://develop.svn.wordpress.org/trunk@31569


git-svn-id: http://core.svn.wordpress.org/trunk@31550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 10:21:26 +00:00
Dominik Schilling 4f19a4b613 JSHint: Remove an unused variable.
Built from https://develop.svn.wordpress.org/trunk@31568


git-svn-id: http://core.svn.wordpress.org/trunk@31549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 09:50:24 +00:00
Dominik Schilling d35ef1c5b1 Update jQuery to 1.11.2.
Changelog:
* https://github.com/jquery/jquery/issues?q=milestone%3A1.11.2%2F2.1.3
* https://github.com/jquery/jquery/compare/1.11.1...1.11.2

props HarishChaudhari.
fixes #31423.
Built from https://develop.svn.wordpress.org/trunk@31567


git-svn-id: http://core.svn.wordpress.org/trunk@31548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 09:41:27 +00:00
Andrew Ozz 4593319ea7 PressThis: accessibility enhancements:
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449.
Built from https://develop.svn.wordpress.org/trunk@31566


git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 02:50:25 +00:00
Andrew Ozz dd79f77b26 PressThis: enable scrollbars in Firefox, remove overflow-x: hidden from the html element. Part props Michael-Arestad. Fixes #31455.
Built from https://develop.svn.wordpress.org/trunk@31565


git-svn-id: http://core.svn.wordpress.org/trunk@31546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 01:55:26 +00:00
Helen Hou-Sandí 6d03323746 CSS: Move relevant `#sidemenu` rules into `deprecated-media.css` and remove the cruft.
fixes #27956.

Built from https://develop.svn.wordpress.org/trunk@31564


git-svn-id: http://core.svn.wordpress.org/trunk@31545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 23:24:27 +00:00
Scott Taylor c43fcec0e3 Fix the build file after [31562].
Built from https://develop.svn.wordpress.org/trunk@31563


git-svn-id: http://core.svn.wordpress.org/trunk@31544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 23:02:24 +00:00
Scott Taylor a8dcd7aced Persist search terms across grid/list modes:
* In `grid` mode, when the page loads and `s` is in the URL, all attachments are loaded and then the search value is set, which will filter the attachments. If the page loads with the attachments already filtered, the library will have to be requery'd to get the full set, which will require weirder code.
* When a user searches, the mode-switcher link for `list` view is updated dynamically to represent the current `location.href` in the proper `mode=` and `s=` context.

Fixes #30583.

Built from https://develop.svn.wordpress.org/trunk@31562


git-svn-id: http://core.svn.wordpress.org/trunk@31543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 23:01:25 +00:00
Scott Taylor e899c370a4 In `get_avatar_data()` and `get_avatar()`, allow `height` and `width` to be specified separately (both default to `size`). Also allow arbitrary attributes on the `<img>` via the `extra_attr` arg.
Props miqrogroove.
See #31469.

Built from https://develop.svn.wordpress.org/trunk@31561


git-svn-id: http://core.svn.wordpress.org/trunk@31542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 21:17:24 +00:00
Helen Hou-Sandí b95d99d1c1 Settings API: Allow passing a class to `add_settings_field()` via the `$args` array.
While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168.

props valendesigns.
fixes #28975. see #30168.

Built from https://develop.svn.wordpress.org/trunk@31560


git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 19:59:25 +00:00
Andrew Ozz a226da32d3 TinyMCE: wpView improvements: introduce getText() and remove() methods, improved getInstance(), better docs. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31559


git-svn-id: http://core.svn.wordpress.org/trunk@31540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 19:32:24 +00:00
Aaron Jorbin 38b6646b41 Run unit tests on Travis CI with php nightlies
With PHP7 in active development, this will help us identify issues there. Also will be fun to see how fast it is.

Fixes #31454


Built from https://develop.svn.wordpress.org/trunk@31558


git-svn-id: http://core.svn.wordpress.org/trunk@31539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 17:50:24 +00:00
Aaron Jorbin 4eefb02ebe Update grunt-patch-wordpress to 0.3.0
This new update includes the following changes:
 * The tools directory can now be patched along with a handful of other root level files that were failing
 * If patching fails  or otherwise issues a prompt, you can now interact with the prompt
 * Only save the watch file to your directory if you pass the --debug flag
 * Default to selecting the newest patch rather then the oldest patch

props ocean90 ntwb kadamwhite aaronjorbin
Fixes #31466


Built from https://develop.svn.wordpress.org/trunk@31557


git-svn-id: http://core.svn.wordpress.org/trunk@31538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 17:47:31 +00:00
Sergey Biryukov 49dd31506f Press This: Use correct URL for update bookmarklet link.
props kraftbj.
fixes #31461.
Built from https://develop.svn.wordpress.org/trunk@31556


git-svn-id: http://core.svn.wordpress.org/trunk@31537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 08:48:25 +00:00
Scott Taylor 4ce271ea86 Cleanup the `@property` annotations for `WP_User`.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31555


git-svn-id: http://core.svn.wordpress.org/trunk@31536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:54:24 +00:00
Scott Taylor 7cb45f2402 Don't call the size function `count()` as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
Scrutinizer added a Performance label: these are the only violations.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31554


git-svn-id: http://core.svn.wordpress.org/trunk@31535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:48:24 +00:00
Scott Taylor 94bd0f93b8 `wp_insert_comment()` should be checking and setting `$compacted`, not the non-existent `$post_data`.
See [31263], #21212.

Built from https://develop.svn.wordpress.org/trunk@31553


git-svn-id: http://core.svn.wordpress.org/trunk@31534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:38:24 +00:00
Scott Taylor 4310147e54 Add missing access modifiers to `WP_Press_This`.
See #31456.

Built from https://develop.svn.wordpress.org/trunk@31552


git-svn-id: http://core.svn.wordpress.org/trunk@31533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:18:25 +00:00
Drew Jaynes 50bb433c66 Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference.
See #17470.

Built from https://develop.svn.wordpress.org/trunk@31551


git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 03:08:28 +00:00
Helen Hou-Sandí ae3baa7c5b Hide irrelevant UI and display a message when editing the page for posts.
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.

Built from https://develop.svn.wordpress.org/trunk@31550


git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 02:47:25 +00:00
Andrew Ozz 9e7561a8d4 Press This: fix notices/errors classes. Props michael-arestad. Fixes #31456.
Built from https://develop.svn.wordpress.org/trunk@31549


git-svn-id: http://core.svn.wordpress.org/trunk@31530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 01:31:26 +00:00
Andrew Ozz 5f27c59f49 TinyMCE: wpView improvements: remove the (obsolete) get/setViewText methods. Update stopping/pausing of multiple ME media players. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31548


git-svn-id: http://core.svn.wordpress.org/trunk@31529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 00:31:31 +00:00
Andrew Ozz c30c705ec3 Press This: add press-this.css to the list of stylesheets that are minified. Bump wp_version. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31547


git-svn-id: http://core.svn.wordpress.org/trunk@31528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 23:49:24 +00:00
Andrew Ozz b799bd8e33 TinyMCE: wpView improvements:
- Better structure, simpler "view" registration, better extensibility.
- Better inline documentation.
- Don't show a placeholder for pasted link until we know the link is "embeddable'.
And many more improvements. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31546


git-svn-id: http://core.svn.wordpress.org/trunk@31527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 23:13:25 +00:00
Andrew Ozz 3146475ed8 PressThis: go back to loading the minified bookmarklet content with file_get_contents(). Add Grunt task to minify bookmarklet.js on precommit and update it in /src. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31545


git-svn-id: http://core.svn.wordpress.org/trunk@31526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 20:16:24 +00:00
Drew Jaynes 0c45c387be Add a missing file header to wp-includes/class-wp-customize-widgets.php, separate out the class DocBlock for `WP_Customize_Widgets`.
Fixes #31446.

Built from https://develop.svn.wordpress.org/trunk@31544


git-svn-id: http://core.svn.wordpress.org/trunk@31525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:20:26 +00:00
Drew Jaynes 26f8fbd705 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-setting.php.
* Adds a file header separate from the `WP_Customize_Setting` class block
* Fixes formatting for the `WP_Customize_Setting`, `WP_Customize_Filter_Setting`, `WP_Customize_Header_Image_Setting`, and `WP_Customize_Background_Image_Setting` class DocBlocks.

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31543


git-svn-id: http://core.svn.wordpress.org/trunk@31524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:18:26 +00:00
Drew Jaynes 2058532f43 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-section.php.
* Adds a file header separate from the `WP_Customize_Section` class block
* Fixes formatting for the `WP_Customize_Section`, `WP_Customize_Themes_Section`, and `WP_Customize_Sidebar_Section` class DocBlocks.

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31542


git-svn-id: http://core.svn.wordpress.org/trunk@31523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:13:26 +00:00
Drew Jaynes 6a899c6709 Add a missing file header to wp-includes/class-wp-customize-panel.php, separate out the class DocBlock for `WP_Customize_Panel`.
See #31446.

Built from https://develop.svn.wordpress.org/trunk@31541


git-svn-id: http://core.svn.wordpress.org/trunk@31522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:09:25 +00:00
Drew Jaynes 5c2c3a961d Add a missing file header to wp-includes/class-wp-customize-manager.php, separate out the class DocBlock for `WP_Customize_Manager`.
See #31446.

Built from https://develop.svn.wordpress.org/trunk@31540


git-svn-id: http://core.svn.wordpress.org/trunk@31521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:07:24 +00:00
Drew Jaynes 8ffc38ce7c Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-control.php.
* Adds a file header separate from the `WP_Customize_Control` class block
* Fixes formatting for the `WP_Customize_Control`, `WP_Customize_Color_Control`, `WP_Customize_Upload_Control`, `WP_Customize_Image_Control`, `WP_Customize_Background_Image_Control`, `WP_Customize_Theme_Control`, `WP_Customize_New_Theme_Control`, `WP_Widget_Area_Customize_Control`, and `WP_Widget_Form_Customize_Control` class DocBlocks.
* Adds a missing class DocBlock for `WP_Customize_Header_Image_Control`

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31539


git-svn-id: http://core.svn.wordpress.org/trunk@31520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 07:56:25 +00:00
Andrew Ozz d84eda9f35 Grunt precommit cleanup. See [31533], [31535].
Built from https://develop.svn.wordpress.org/trunk@31538


git-svn-id: http://core.svn.wordpress.org/trunk@31519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 04:17:27 +00:00
Andrew Ozz 64092c309d Press This: JSON encode the URL before appending it to the bookmarklet. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31537


git-svn-id: http://core.svn.wordpress.org/trunk@31518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:58:25 +00:00
Mark Jaquith bd2c067245 Make sure WP_Customize_Manager::theme() never returns null.
* Fixes issue in [31533] that caused unit test fatal error

fixes #31445
Built from https://develop.svn.wordpress.org/trunk@31536


git-svn-id: http://core.svn.wordpress.org/trunk@31517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:54:25 +00:00
Andrew Ozz ce8defbeb4 PressThis:
- Hard-code the minified bookmarklet js. Adding the non-minified bookmarklet to the browser bookmarks bar may have unexpected effect.
- Fix type juggling when checking the bookmarklet version.
Props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31535


git-svn-id: http://core.svn.wordpress.org/trunk@31516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:03:25 +00:00
Andrew Ozz 1857055bb8 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31534


git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 01:50:26 +00:00
Mark Jaquith 8b180b9a46 Add theme browsing and theme switching to the Customizer
* Brings into core the Customizer Theme Switcher feature plugin
* You can now browse, preview, and activate themes right from the Customizer

fixes #31303.
props celloexpressions, afercia, westonruter, folletto, designsimply
Built from https://develop.svn.wordpress.org/trunk@31533


git-svn-id: http://core.svn.wordpress.org/trunk@31514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 20:31:24 +00:00
Boone Gorges 0d9275930b Add 'orderby=description' support to `get_terms()`.
This fixes an interface inconsistency in edit-tags.php, where Description
appears as a sortable column header.

Props neil_pie.
Fixes #31364.
Built from https://develop.svn.wordpress.org/trunk@31532


git-svn-id: http://core.svn.wordpress.org/trunk@31513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 16:37:26 +00:00
Sergey Biryukov 7c8b6609ca Fix line endings after [31522].
fixes #31430.
Built from https://develop.svn.wordpress.org/trunk@31531


git-svn-id: http://core.svn.wordpress.org/trunk@31512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 10:06:24 +00:00
Drew Jaynes 46286070a5 Clarify a wide variety of function, parameter, and return descriptions in DocBlocks throughout wp-includes/media.php.
Props stevegrunwell, DrewAPicture.
Fixes #28408.

Built from https://develop.svn.wordpress.org/trunk@31530


git-svn-id: http://core.svn.wordpress.org/trunk@31511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 07:42:24 +00:00
Drew Jaynes 4743843323 Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php.
Props NikV for the initial patch.
Fixes #31353.

Built from https://develop.svn.wordpress.org/trunk@31529


git-svn-id: http://core.svn.wordpress.org/trunk@31510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 06:07:26 +00:00
Dion Hulse 90e85a70c4 Upgrades: Specifically pass the 'version' and 'locale' POST vars through the Core Update FTP credentials form.
This bug was introduced with [30384] / #30245
Fixes #31378 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31527


git-svn-id: http://core.svn.wordpress.org/trunk@31508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 03:01:25 +00:00
Andrew Ozz 481889c40b Load json2.js only in IE7 and older. Fixes #31276.
Built from https://develop.svn.wordpress.org/trunk@31526


git-svn-id: http://core.svn.wordpress.org/trunk@31507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 23:04:24 +00:00
Boone Gorges e89d237b86 Pass taxonomy name, not object, to 'edit_term_taxonomy' and 'edited_term_taxonomy' actions.
These actions are fired in a number of different places, and in some cases
the tax name is passed, while in others the taxonomy object is passed. This
inconsistency made it difficult for plugins to use the `$taxonomy` value.

Props ipm-frommen.
Fixes #30999.
Built from https://develop.svn.wordpress.org/trunk@31525


git-svn-id: http://core.svn.wordpress.org/trunk@31506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 21:08:26 +00:00
Sergey Biryukov ad30deda04 Menus: Remove fixed height from `.description-thin` fields.
props tyxla.
fixes #31426.
Built from https://develop.svn.wordpress.org/trunk@31524


git-svn-id: http://core.svn.wordpress.org/trunk@31505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 20:23:26 +00:00
Sergey Biryukov 132d65ef1e Menus: Prevent checkboxes and radio buttons from being stretched to full width on mobile.
props tyxla.
fixes #31425.
Built from https://develop.svn.wordpress.org/trunk@31523


git-svn-id: http://core.svn.wordpress.org/trunk@31504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 20:03:26 +00:00
Sergey Biryukov aade870f17 Add unit tests for `get_page_template_slug()`.
props tyxla.
fixes #31389.
Built from https://develop.svn.wordpress.org/trunk@31522


git-svn-id: http://core.svn.wordpress.org/trunk@31503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 18:47:27 +00:00
Sergey Biryukov 6221fc86a3 Fix a typo in `wp_update_nav_menu_item` hook documentation.
props tyxla.
fixes #31338.
Built from https://develop.svn.wordpress.org/trunk@31521


git-svn-id: http://core.svn.wordpress.org/trunk@31502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 16:51:25 +00:00
Sergey Biryukov c6522e3c93 Add missing labels to Archives and Categories dropdown widgets.
props joedolson, jlevandowski, DrewAPicture, SergeyBiryukov.
fixes #18650.
Built from https://develop.svn.wordpress.org/trunk@31520


git-svn-id: http://core.svn.wordpress.org/trunk@31501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 16:32:25 +00:00
Sergey Biryukov c6c5455d93 Themes: Use a darker color for "No themes found" message to increase contrast.
props joedolson.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31519


git-svn-id: http://core.svn.wordpress.org/trunk@31500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 15:49:27 +00:00
Jeremy Felt 646e643e5d Add `comment-author-is-site-member` class to comment output for site members.
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.

Built from https://develop.svn.wordpress.org/trunk@31518


git-svn-id: http://core.svn.wordpress.org/trunk@31499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:52:24 +00:00
Jeremy Felt 7644e68119 Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

Built from https://develop.svn.wordpress.org/trunk@31517


git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:29:26 +00:00
Jeremy Felt 754636aaf1 Avoid clearing stored capabilities for a user when removing their built in role in multisite.
Previously, if “No role on this site” was assigned to a user AND that user did not have an empty role array stored for the site, the `$blog_prefix . ‘capabilities’` meta for that user would be deleted completely after changes to the user were saved. Any custom capabilities stored (i.e. `$user->add_role()`) would be removed as well.

This removes the code controlling the old WPMU handling of “no role” and allows custom stored capabilities to remain. Users with no role and custom capabilities will now appear in the users list table with “None” as the role.

In the process we’re able to better clarify the multisite specific pieces that do occur.

Props PeteMall, jeremyfelt.

Fixes #18934.

Built from https://develop.svn.wordpress.org/trunk@31516


git-svn-id: http://core.svn.wordpress.org/trunk@31497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:34:24 +00:00
Boone Gorges 1b6bb2f183 Ensure that a request URL is always set in `WP_UnitTestCase::go_to()`.
Failure to set this variable meant that passing the home URL to `go_to()`
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.

Props joostdevalk.
Fixes #31417.
Built from https://develop.svn.wordpress.org/trunk@31515


git-svn-id: http://core.svn.wordpress.org/trunk@31496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:08:25 +00:00
Jeremy Felt 5ac75b3b0a Use response code 200 when an existing network user joins a site via invitation.
Pass a response code of 200 to `wp_die()` when a user is successfully added to an individual site after using the `/newbloguser/` URL from an invite email. This is a user facing success message.

Props MikeHansenMe.

Fixes #31224.

Built from https://develop.svn.wordpress.org/trunk@31514


git-svn-id: http://core.svn.wordpress.org/trunk@31495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 22:30:25 +00:00
Andrew Ozz 19dbf7b998 Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914.
Built from https://develop.svn.wordpress.org/trunk@31513


git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:48:26 +00:00
Boone Gorges 0cd7554f75 Use PHP 5.2 compatible syntax in image tests.
T_PAAMAYIM_NEKUDOTAYIM, HAKUNA_MATATA, YOLO.

See [31510], #31124.
Built from https://develop.svn.wordpress.org/trunk@31512


git-svn-id: http://core.svn.wordpress.org/trunk@31493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:42:24 +00:00
Jeremy Felt 678982ee7e Do not activate plugins on initial installation in multisite.
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.

Props ianmjones.

Fixes #31327.

Built from https://develop.svn.wordpress.org/trunk@31511


git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:30:25 +00:00
Boone Gorges 3ef981335d Better image-type support checks in image unit tests.
PHP can be compiled without support for certain image types. Our unit tests
should be sensitive to these configurations.

Fixes #31124.
Built from https://develop.svn.wordpress.org/trunk@31510


git-svn-id: http://core.svn.wordpress.org/trunk@31491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:07:25 +00:00
Sergey Biryukov 0231047071 Delegate `focusin` and `focusout` events for row actions to make sure the actions are always revealed on focus.
props afercia.
fixes #29765.
Built from https://develop.svn.wordpress.org/trunk@31509


git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov 8eb25609e9 Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
props danielbachhuber.
fixes #29374.
Built from https://develop.svn.wordpress.org/trunk@31508


git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
Sergey Biryukov 93e5bb3702 Quick Edit: Make date fields a bit wider.
props Ravindra Pal Singh, janhenckens.
fixes #27912.
Built from https://develop.svn.wordpress.org/trunk@31507


git-svn-id: http://core.svn.wordpress.org/trunk@31488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:24:25 +00:00
Sergey Biryukov 4b21c67738 Remove untranslatable period from a successful update message in `Bulk_Upgrader_Skin::add_strings()`.
props mako09, DrewAPicture.
fixes #30793.
Built from https://develop.svn.wordpress.org/trunk@31506


git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:07:24 +00:00
Dominik Schilling 2b9a79db8e Run Autoprefixer after [31504].
This removes media queries for Opera < 12 and `-ms-animation`/`@-ms-keyframes` which was never (dev versions excluded) supported by IE.

see #31337.
Built from https://develop.svn.wordpress.org/trunk@31505


git-svn-id: http://core.svn.wordpress.org/trunk@31486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:00:24 +00:00
Dominik Schilling 8f83a2e48c Update grunt-autoprefixer to 2.2.0
Upstream changes:
* grunt-autoprefixer: https://github.com/nDmitry/grunt-autoprefixer/compare/v1.0.1...v2.2.0
* autoprefixer-core: https://github.com/postcss/autoprefixer-core/compare/2.0.2...5.1.7

fixes #31337.
Built from https://develop.svn.wordpress.org/trunk@31504


git-svn-id: http://core.svn.wordpress.org/trunk@31485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 16:54:33 +00:00
Sergey Biryukov 1ab9aa255e Use correct closing tag for "Under the Hood" header on About screen.
props tyxla.
fixes #31402.
Built from https://develop.svn.wordpress.org/trunk@31503


git-svn-id: http://core.svn.wordpress.org/trunk@31484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 16:44:25 +00:00
Dominik Schilling bbbdee0e6d Adjust our QUnit test suite to show the QUnit toolbar.
props iseulde.
fixes #31413.
Built from https://develop.svn.wordpress.org/trunk@31502


git-svn-id: http://core.svn.wordpress.org/trunk@31483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 15:32:26 +00:00
Dominik Schilling 121d2ee4cb Update POT file for Twenty Fourteen.
props SergeyBiryukov.
see #30972, #30603.
Built from https://develop.svn.wordpress.org/trunk@31501


git-svn-id: http://core.svn.wordpress.org/trunk@31482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 15:16:24 +00:00
Dominik Schilling a748574c29 Revert [30790] and update POT file for Twenty Fifteen.
see #30972, #30603.
Built from https://develop.svn.wordpress.org/trunk@31500


git-svn-id: http://core.svn.wordpress.org/trunk@31481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 13:43:24 +00:00
Dominik Schilling 6f97715bea i18n tools: Delete `data/not-gettexted-0-work.php`.
In NotGettextedTest this file is a copy of `data/not-gettexted-0.php` which will be removed after the test has finished.
Built from https://develop.svn.wordpress.org/trunk@31499


git-svn-id: http://core.svn.wordpress.org/trunk@31480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 12:56:25 +00:00
Dominik Schilling a68ba4cd2d i18n tools: Improve support for multi-line comments in StringExtractor.
props SergeyBiryukov.
fixes #30972.
Built from https://develop.svn.wordpress.org/trunk@31498


git-svn-id: http://core.svn.wordpress.org/trunk@31479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 12:47:25 +00:00
Sergey Biryukov f7df99549a Themes: Add feedback for screen readers when search results are changed.
props obenland, joedolson.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31497


git-svn-id: http://core.svn.wordpress.org/trunk@31478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 10:15:26 +00:00
Sergey Biryukov 224cb89878 Remove a stray single quote in `wp_insert_post()` documentation.
see #31359.
Built from https://develop.svn.wordpress.org/trunk@31496


git-svn-id: http://core.svn.wordpress.org/trunk@31477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:50:25 +00:00
Sergey Biryukov 677d37753f Themes: Update the theme count when searching for installed themes, like we do on Add Themes screen.
props afercia.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31495


git-svn-id: http://core.svn.wordpress.org/trunk@31476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:41:24 +00:00
Scott Taylor d5b80a2be2 Make sure the `grid` build does not load files from the `views` build.
Fix the errant back-compat assignment for `wp.media.view.Frame`.

See #28510.

Built from https://develop.svn.wordpress.org/trunk@31494


git-svn-id: http://core.svn.wordpress.org/trunk@31475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 08:47:25 +00:00
Scott Taylor 7b8cdd61fd Make sure the `audio-video` build does not load files from the `views` build.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31493


git-svn-id: http://core.svn.wordpress.org/trunk@31474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 08:29:25 +00:00
Scott Taylor d9a2e85bfe Media JS files:
* specify globals in more files
* add missing `wp.media.*` namespace docs
* add doc blocks to files that had none

See #28510.

Built from https://develop.svn.wordpress.org/trunk@31492


git-svn-id: http://core.svn.wordpress.org/trunk@31473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 07:25:27 +00:00
Scott Taylor 9737acc1a5 Specify globals in media JS files - it is important to denote where we are diverging from dependency injection.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31491


git-svn-id: http://core.svn.wordpress.org/trunk@31472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:56:27 +00:00
Scott Taylor 8b54658f0c After [30120], in media JS files, move from `@constructor` to `@class` annotations as per JSDoc preferred nomenclature: http://usejsdoc.org/tags-class.html
See #28510, #30193.

Built from https://develop.svn.wordpress.org/trunk@31490


git-svn-id: http://core.svn.wordpress.org/trunk@31471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:28:26 +00:00
Scott Taylor 117a0518fd The `grid` build should not load `views/edit-image`, it already exists in the `views` build.
`views/edit-image.js` doesn't need to set a `render` method if it doesn't override its parent.

See #28510.

Built from https://develop.svn.wordpress.org/trunk@31489


git-svn-id: http://core.svn.wordpress.org/trunk@31470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 06:21:25 +00:00
Scott Taylor 8babe839e3 JSHint after [31487].
Built from https://develop.svn.wordpress.org/trunk@31488


git-svn-id: http://core.svn.wordpress.org/trunk@31469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 05:57:28 +00:00
Scott Taylor 6848035d1a Restore the changes I made in [31016] for chromeless Vimeo that were missed in [31373].
Make sure that the build file for `grid` doesn't load `views/media-details.js`, it already exists in the `audio-video` build.

See #29267, #28510.

Built from https://develop.svn.wordpress.org/trunk@31487


git-svn-id: http://core.svn.wordpress.org/trunk@31468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 05:38:27 +00:00