WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
39,018 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

17317 Commits

Author SHA1 Message Date
desrosj d83d8e1154 Docs: Update `since` annotation for `comments_list_table_query_args`. 
Introduced in [42420].

Fixes #42997.
Built from https://develop.svn.wordpress.org/trunk@44530


git-svn-id: http://core.svn.wordpress.org/trunk@44361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-10 01:40:51 +00:00
desrosj 13c66b1b18 Media: Store audio creation date in meta. 
In [41746], `wp_get_media_creation_timestamp()` was introduced to read the created timestamp for videos from `getID3` in meta whenever possible. This information is useful separately from the dates on the file itself.

This adds the same support audio files by utilizing `wp_get_media_creation_timestamp()` in `wp_read_audio_metadata()`.

Props blob folio, desrosj.
Fixes #42017.
Built from https://develop.svn.wordpress.org/trunk@44528


git-svn-id: http://core.svn.wordpress.org/trunk@44359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-10 01:32:50 +00:00
Felix Arntz 5bb4a5aa0e Upgrade/Install: Add missing call to clear site meta cache in `populate_site_meta()`. 
See #44896.

Built from https://develop.svn.wordpress.org/trunk@44526


git-svn-id: http://core.svn.wordpress.org/trunk@44357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 21:29:50 +00:00
Felix Arntz 83603991c6 Bootstrap/Load: Fix missing object argument for singular capability checks and support capability tests overlooked in [44524]. 
See #44458.

Built from https://develop.svn.wordpress.org/trunk@44525


git-svn-id: http://core.svn.wordpress.org/trunk@44356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 20:44:50 +00:00
Felix Arntz 1e4088fc98 Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 
This changeset introduces a `WP_Shutdown_Handler` class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.

Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.

The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.

Websites that have custom requirements in that regard can implement their own shutdown handler by adding a `shutdown-handler.php` drop-in that returns the handler instance to use, which must be based on a class that inherits `WP_Shutdown_Handler`. That handler will then be used in place of the default one.

Websites that would like to modify specifically the error template displayed in the frontend can add a `php-error.php` drop-in that works similarly to the existing `db-error.php` drop-in.

Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458.

Built from https://develop.svn.wordpress.org/trunk@44524


git-svn-id: http://core.svn.wordpress.org/trunk@44355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 20:05:49 +00:00
Boone Gorges 811be4779e Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg. 
Introduced in [42211].

Fixes #36514.
Built from https://develop.svn.wordpress.org/trunk@44519


git-svn-id: http://core.svn.wordpress.org/trunk@44350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 15:11:48 +00:00
Pascal Birchler 9bcdc25145 Build/Test Tools: Fix coding standards issues after [44515] and [44514]. 
See #44494, #43743.

Built from https://develop.svn.wordpress.org/trunk@44516


git-svn-id: http://core.svn.wordpress.org/trunk@44347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 12:37:49 +00:00
Pascal Birchler 8f5e0ae06c Taxonomy: Display term list table in full width if there is no edit form. 
Makes sure there is no empty space when a user can manage terms but lacks the capability to edit terms.

Props mathieuhays, marcwieland95.
Fixes #43743.

Built from https://develop.svn.wordpress.org/trunk@44515


git-svn-id: http://core.svn.wordpress.org/trunk@44346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 12:05:50 +00:00
Pascal Birchler d32d061a5e Upgrade/Install: Prevent possible JavaScript error when updating translations. 
Props Presskopp.
Fixes #39189.

Built from https://develop.svn.wordpress.org/trunk@44513


git-svn-id: http://core.svn.wordpress.org/trunk@44344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 11:26:50 +00:00
Gary Pendergast f88769fc3b Block Editor: Obey the `AUTOSAVE_INTERVAL` constant. 
Props youknowriad.
Fixes #45262.


Built from https://develop.svn.wordpress.org/trunk@44504


git-svn-id: http://core.svn.wordpress.org/trunk@44335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 06:54:49 +00:00
Gary Pendergast f9d879905d Docs: Document the `$page_hook` action. 
Props johnbillion.
Fixes #43643.


Built from https://develop.svn.wordpress.org/trunk@44501


git-svn-id: http://core.svn.wordpress.org/trunk@44332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 06:14:51 +00:00
Gary Pendergast 47e29ccba9 Privacy: Tweak the wording of the success notice when updating the privacy policy page setting. 
Props garrett-eclipse.
Fixes #44129.


Built from https://develop.svn.wordpress.org/trunk@44493


git-svn-id: http://core.svn.wordpress.org/trunk@44324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 04:19:49 +00:00
Gary Pendergast 099238e3a3 Privacy: Always show the privacy policy guide. 
Previously, the link to the privacy policy guide would only be displayed when a privacy policy page had been selected, but the guide is generally useful without that.

Props mukesh27, birgire.
Fixes #44871.


Built from https://develop.svn.wordpress.org/trunk@44492


git-svn-id: http://core.svn.wordpress.org/trunk@44323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 04:01:50 +00:00
Gary Pendergast fd7086bcdc Docs: Update the `@since` tag for the `comment_status_links` filter. 
Fixes #42379.


Built from https://develop.svn.wordpress.org/trunk@44487


git-svn-id: http://core.svn.wordpress.org/trunk@44318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 01:06:48 +00:00
Gary Pendergast 0888007275 Admin: Add a "Set up your homepage" link to the Welcome panel. 
As many WordPress sites use a static homepage rather than a blog, this link gives a natural next step for new sites owners wanting to configure their site in this manner.

Props professor44, joyously, nielslange, mukesh27, melchoyce.
Fixes #45019.


Built from https://develop.svn.wordpress.org/trunk@44485


git-svn-id: http://core.svn.wordpress.org/trunk@44316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 00:12:49 +00:00
desrosj 51155f3989 Docs: Specify missing `global` variables used in `wp_print_theme_file_tree()`. 
The `$relative_file` and `$stylesheet` variables are used in the `wp_print_theme_file_tree()` function but were not noted within the inline documentation.

Props mukesh27, desrosj,
Fixes #43682.
Built from https://develop.svn.wordpress.org/trunk@44477


git-svn-id: http://core.svn.wordpress.org/trunk@44308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 18:33:49 +00:00
Felix Arntz e08a12d020 General: Make Update PHP notice link customizable. 
After [42832], [42891] and [43006], this changeset refines the core notice informing about an outdated PHP version:

* The link to the Update PHP information page can now be adjusted using either a `WP_UPDATE_PHP_URL` environment variable, or a new `wp_update_php_url` filter.
* If that URL is different from the default one that points to https://wordpress.org/support/update-php/ or its localized equivalent, a note indicates that the linked resource has not been provided by WordPress itself, and the default URL is still linked to as an additional resource.
* The URL for the default information page has been updated to use the slug `update-php` instead of `upgrade-php`.
* `@since` annotations have been updated.

Going forward, admin areas that display information related to the PHP version should use the new function `wp_get_update_php_url()`.

Props afragen, fierevere, flixos90, markjaquith, miss_jwo, nerrad, pento, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #45686. See #41191.

Built from https://develop.svn.wordpress.org/trunk@44476


git-svn-id: http://core.svn.wordpress.org/trunk@44307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 17:27:50 +00:00
desrosj 1f6da37438 Docs: Fix order of parameter type and variable name. 
The order of the type and variable name in the `param` tags for the `wp_get_default_privacy_policy_content` filter is incorrectly reversed. This moves the two into the correct order.

Props ishitaka, mukesh27.
Fixes #45416.
Built from https://develop.svn.wordpress.org/trunk@44475


git-svn-id: http://core.svn.wordpress.org/trunk@44306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 17:03:48 +00:00
desrosj f1ea8f222f Widgets: Fix custom HTML widget editor content not updating after save. 
An integer comparison is performed against `control.currentErrorAnnotations`, but `control.currentErrorAnnotations` is actually an array. This fixes that comparison so the content saves correctly.

Props barryceelen.
Fixes #43657.
Built from https://develop.svn.wordpress.org/trunk@44474


git-svn-id: http://core.svn.wordpress.org/trunk@44305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 16:42:49 +00:00
Felix Arntz 0b15142c0b Multisite: Update `@since` tags for site management APIs. 
Fixes #40364. Fixes #41333.

Built from https://develop.svn.wordpress.org/trunk@44469


git-svn-id: http://core.svn.wordpress.org/trunk@44300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 08:58:49 +00:00
Felix Arntz 321bdfbacf Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions. 
This complements the work in [43729] and prepares site metadata for future REST API support.

Props spacedmonkey.
Fixes #45091. See #44467.

Built from https://develop.svn.wordpress.org/trunk@44468


git-svn-id: http://core.svn.wordpress.org/trunk@44299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 08:48:48 +00:00
Felix Arntz 035877708d Multisite: Update `@since` tags for site meta introduction. 
Fixes #37923. Fixes #40229.

Built from https://develop.svn.wordpress.org/trunk@44467


git-svn-id: http://core.svn.wordpress.org/trunk@44298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 08:18:50 +00:00
Gary Pendergast 952c7253d3 Comments: Improve the Author box in the Edit Comment screen. 
- Add a border below the heading, to match meta boxes.
- Remove the colons from the input labels.
- Tweak the padding and margins.

Props birgire, abdullahramzan, rhetorical, BODA1982, pento.
Fixes #43586.


Built from https://develop.svn.wordpress.org/trunk@44466


git-svn-id: http://core.svn.wordpress.org/trunk@44297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 06:19:50 +00:00
Gary Pendergast fe837d19a7 Docs: Fix the `@param` type for `wp_make_plugin_file_tree()`. 
`$plugin_editable_files` is an `array`, not a `string`.

Props subrataemfluence.
Fixes #45593.


Built from https://develop.svn.wordpress.org/trunk@44464


git-svn-id: http://core.svn.wordpress.org/trunk@44295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 06:02:51 +00:00
Gary Pendergast 12b800788e Docs: Improve the `@return` description of `network_domain_check()`. 
Props ishitaka, vaishalipanchal.
Fixes #45403.


Built from https://develop.svn.wordpress.org/trunk@44460


git-svn-id: http://core.svn.wordpress.org/trunk@44291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 05:27:50 +00:00
Gary Pendergast 363cfc4301 General: Replace "Happy blogging" with "Happy publishing". 
As of this commit, WordPress is no longer a simple blogging platform. It's now a comprehensive publishing solution.

This also replaces a couple of other "blog" references that were missed previously.

Props igmoweb, Valer1e, audrasjb, pento.
Fixes #41000.


Built from https://develop.svn.wordpress.org/trunk@44455


git-svn-id: http://core.svn.wordpress.org/trunk@44286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 04:30:50 +00:00
Gary Pendergast 7f67e235a7 Install/Upgrade: Link to HelpHub instead of the Codex. 
WordPress version links in the Codex (eg, https://codex.wordpress.org/Version_5.0) are redirected to their HelpHub equivalent.

Rather than relying on the redirect, Core and link directly to HelpHub.

Props swissspidy.
Fixes #45574.


Built from https://develop.svn.wordpress.org/trunk@44451


git-svn-id: http://core.svn.wordpress.org/trunk@44282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 03:29:48 +00:00
Gary Pendergast 308a544039 Docs: Update `@since` for `populate_site_meta()`. 
Fixes #44896.


Built from https://develop.svn.wordpress.org/trunk@44450


git-svn-id: http://core.svn.wordpress.org/trunk@44281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 03:18:50 +00:00
Gary Pendergast 1d25a903c4 Docs: Update `@since` for `populate_network_meta()`. 
Fixes #44895.


Built from https://develop.svn.wordpress.org/trunk@44449


git-svn-id: http://core.svn.wordpress.org/trunk@44280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 03:17:49 +00:00
Gary Pendergast eee2e5f1d8 Docs: Update `@since` for the optional `$options` parameter to `populate_options()`. 
Fixes #44893.


Built from https://develop.svn.wordpress.org/trunk@44448


git-svn-id: http://core.svn.wordpress.org/trunk@44279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 03:15:49 +00:00
desrosj f082806afa Block Editor: Display notice to the user when JavaScript is disabled. 
Currently, when viewing the block editor with JavaScript disabled, the user sees a blank admin page with the admin menu sidebar. This adds an admin notice informing the user that JavaScript is required for the new block editor.

Props mkaz, pento, azaozz, ocean90, desrosj.
Fixes #45453.
Built from https://develop.svn.wordpress.org/trunk@44437


git-svn-id: http://core.svn.wordpress.org/trunk@44268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-07 20:40:50 +00:00
Sergey Biryukov 6b2494ba10 Plugins: Use newer "Updating PHP" page URL in the notice displayed when a plugin requires a higher PHP version. 
Props afragen.
Fixes #43986. See #45686.
Built from https://develop.svn.wordpress.org/trunk@44420


git-svn-id: http://core.svn.wordpress.org/trunk@44250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-07 15:35:49 +00:00
Sergey Biryukov 9ac8b5b4f5 Importers: Use correct l10n variable in `wp.updates.installImporterError` and filesystem credentials dialog. 
Missed in [40034].

Props afercia, abhayvishwakarma.
Fixes #45765.
Built from https://develop.svn.wordpress.org/trunk@44417


git-svn-id: http://core.svn.wordpress.org/trunk@44247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-07 13:49:49 +00:00
desrosj f29dfe7b6d Docs: Update `since` tag for new `intermediate_image_sizes_advanced` filter parameter. 
Originally added in [42407].

Fixes #42745.
Built from https://develop.svn.wordpress.org/trunk@44385


git-svn-id: http://core.svn.wordpress.org/trunk@44215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-03 17:47:49 +00:00
Sergey Biryukov b7ddbe94e7 Taxonomy: Fix typo in `taxonomy_meta_box_sanitize_cb_checkboxes()` argument name. 
Props itowhid06.
Fixes #45756.
Built from https://develop.svn.wordpress.org/trunk@44367


git-svn-id: http://core.svn.wordpress.org/trunk@44197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-28 18:04:50 +00:00
desrosj 4818f7e3f7 Administration: Update default fallback color for SVG icons. 
Currently, when an SVG is used as a menu icon, the color is inconsistent with the other, default dashicons and the contrast ratio does not meet the minimum requirement for accessibility.

This updates the base color for the default `fresh` color scheme to ensure consistency and proper contrast.

Props swift, dschalk.
Fixes #44209.
Built from https://develop.svn.wordpress.org/trunk@44353


git-svn-id: http://core.svn.wordpress.org/trunk@44183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-20 19:01:48 +00:00
Sergey Biryukov b06701a167 Plugins: Colorize plugin card compatibility icons on Add Plugins screen. 
Props afragen, melchoyce, daniel-koskinen.
Fixes #44619.
Built from https://develop.svn.wordpress.org/trunk@44352


git-svn-id: http://core.svn.wordpress.org/trunk@44182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-20 18:15:47 +00:00
desrosj 921fd01582 Posts, Post Types: Correctly show hierarchical post type hierarchy in admin. 
In [44185], a bug was introduced where hierarchical post types would not display in the correct default order (hierarchically).

This was caused by a `! isset()` check, which returned `false` after [44185], causing the correct default value to not be applied. This switches that conditional to use an `empty()` check, ignoring the new empty string assignment that was added to prevent a PHP notice when `compact()` is called.

Props davidbinda.
Fixes #45711.
Built from https://develop.svn.wordpress.org/trunk@44338


git-svn-id: http://core.svn.wordpress.org/trunk@44168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 22:23:50 +00:00
Drew Jaynes 5b19e65c3b Docs: Add a missing DocBlock summary and `$action` parameter description for `wp_ajax_delete_page()`. 
Props abhijitrakas.
Fixes #44206.

Built from https://develop.svn.wordpress.org/trunk@44335


git-svn-id: http://core.svn.wordpress.org/trunk@44165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 17:00:50 +00:00
Drew Jaynes 92aa2f9e92 Docs: Fix a few minor inline documentation typos in a variety of files and contexts. 
Props ramizmanked.
Fixes #45463.

Built from https://develop.svn.wordpress.org/trunk@44331


git-svn-id: http://core.svn.wordpress.org/trunk@44161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 07:42:49 +00:00
Jeremy Felt 0cad45c7f8 Build: Update images following [43684]. 
`grunt-contrib-imagemin` was updated, which included some changes to image minification. Those changes are now applies.

Merges [43785] from the 5.0 branch to trunk.

Props netweb.
See #45080.

Built from https://develop.svn.wordpress.org/trunk@44320


git-svn-id: http://core.svn.wordpress.org/trunk@44150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 03:36:27 +00:00
desrosj 1a4d511696 Block Editor: Remove a deprecated notice being generated by the meta box compat functions. 
Props pento.

Merges [44248] into trunk.

Fixes #45456.
Built from https://develop.svn.wordpress.org/trunk@44315


git-svn-id: http://core.svn.wordpress.org/trunk@44145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 03:32:18 +00:00
desrosj 5a30da57c6 PHP 7.3 Compatibility: Fix compact related notices. 
In PHP 7.3, the `compact()` function has been changed to issue an `E_NOTICE` level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

See #44416.

Merges [44185] into trunk.

Fixes #45483.
Built from https://develop.svn.wordpress.org/trunk@44297


git-svn-id: http://core.svn.wordpress.org/trunk@44127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 03:17:37 +00:00
desrosj 43bdb0e193 Editor: Remove unwanted fields before saving posts. 
The meta_input, file, and guid fields are not intended to be updated through user input.

Merges [44047] to trunk.
Built from https://develop.svn.wordpress.org/trunk@44295


git-svn-id: http://core.svn.wordpress.org/trunk@44125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-18 21:32:48 +00:00
desrosj 38d1e7233d Block Editor: Show privacy help notice on Privacy Policy page. 
When editing a page set to be the Privacy Policy page, display a help notice
containing a link to the Privacy Policy guide.

Merges [43920] to trunk.

Fixes #45057.
Built from https://develop.svn.wordpress.org/trunk@44291


git-svn-id: http://core.svn.wordpress.org/trunk@44121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-18 16:14:49 +00:00
desrosj 7a97c31f4e Block Editor: Add a placeholder for meta boxes that don't work in the block editor. 
If a meta box is registered with the `__block_editor_compatible_meta_box` set to `false`, it's indicating that it doesn't work in the block editor. If that's the case, we can add a place holder to inform the user that they'll need to use the classic interface to work with this meta box.

Props pento, jorgefilipecosta, peterwilsoncc, karmatosed, noisysocks, dd32, ocean90.

Merges [43941] and [43945] to trunk.

Fixes #45217.
Built from https://develop.svn.wordpress.org/trunk@44280


git-svn-id: http://core.svn.wordpress.org/trunk@44110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 21:52:53 +00:00
desrosj e188e2d3a3 Block Editor: Fix the WordPress packages and vendor script registration. 
The version is set properly and the scripts are automatically loaded in the footer.

This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy, youknowriad.

Merges [43942] into trunk.

Fixes #45402.
See #45396.
Built from https://develop.svn.wordpress.org/trunk@44277


git-svn-id: http://core.svn.wordpress.org/trunk@44107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 19:34:52 +00:00
desrosj 03262a191f Block Editor: Refresh nonces used by `wp.apiFetch`. 
Adds heartbeat nonces refreshing support to `wp.apiFetch` requests.

Props pento, adamsilverstein, dd32, desrosj, youknowriad.

Merges [43939] into trunk.

Fixes #45113. 
Built from https://develop.svn.wordpress.org/trunk@44275


git-svn-id: http://core.svn.wordpress.org/trunk@44105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 19:28:51 +00:00
desrosj 54ab431046 Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page. 
This ensures the "import from JSON" and "export JSON" buttons are shown properly. The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.

Merges [43936] into trunk.

Fixes #45396.
Built from https://develop.svn.wordpress.org/trunk@44274


git-svn-id: http://core.svn.wordpress.org/trunk@44104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 19:08:51 +00:00
desrosj 36158d7909 Block Editor: Update `@wordpress` package dependencies. 
Update packages include:

- block-library
- components
- edit-post
- editor
- format-library
- list-reusable-blocks
- nux

Other changes:

- Fix a translator comment in `edit-form-blocks.php`.
- Rename the `gutenberg_` functions in `blocks/latest-comments.php`.

Props noisy socks, youknowriad, pinto, swissspidy.

Merges [43935] and [43949-43951] into trunk.

See #45145.
Built from https://develop.svn.wordpress.org/trunk@44273


git-svn-id: http://core.svn.wordpress.org/trunk@44103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 19:06:59 +00:00
desrosj 4b0f960b7c Block Editor: Fix PHP warning when loading editor styles while in RTL. 
In RTL languages, WordPress adds `style-editor-rtl.css` editor styles to the global `$editor_styles`.
This patch ignores handling these styles if the file is not preset.

Also, clarify the docs for the return value of the `block_version` function.

Props mostafa.s1990, desrosj, mukesh27.

Merges [43923] and [43924] to trunk.

Fixes #45288, #45342.
Built from https://develop.svn.wordpress.org/trunk@44270


git-svn-id: http://core.svn.wordpress.org/trunk@44100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 18:07:51 +00:00
desrosj e06611512c Block Editor: Expose value of `user_can_richedit()`. 
In order for the Block Editor to know whether to allow visual editing, it needs to know the value of `user_can_richedit()`.

Props youknowriad, danielbachhuber.

Merges [43916] into trunk.

Fixes #45375.
Built from https://develop.svn.wordpress.org/trunk@44267


git-svn-id: http://core.svn.wordpress.org/trunk@44097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 17:09:51 +00:00
desrosj 9cd64e1341 Help/About: WordPress 5.0 About Page. 
The About page describes all the great changes in WordPress 5.0.

Highlights:

- Warn users of Gutenberg plugin of its deactivation upon 5.0 upgrade.
- Added illustrations to the Four Freedoms page.
- Include a link to wporg user’s plugin favorites as a way to display only the classic plugin as a suggestion for install.
- Detail the Classic Editor plugin and the support timeline.

Props pixelverbieger, ocean90, karmatosed, pento, boemedia, lonelyvegan, sami.keijonen, TimothyBlynJacobs, xkon, afercia, laurelfulford, joostdevalk, ipstenu, matveb, joen, tinkerbelly, chanthaboune, kjellr, alexislloyd, melchoyce, mcsf, courtney0burton, Otto42, cathibosco, tobifjellner, helen, audrasjb, antpb, jjj, elrae, desrosj, azaozz, joemcgill, skithund, gziolo.

Merges [43913], [43921-43922], [43937-43938], [43946-43947], [43952-43953], [43967-43969] into trunk.

Fixes #45178.
Built from https://develop.svn.wordpress.org/trunk@44264


git-svn-id: http://core.svn.wordpress.org/trunk@44094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 16:36:59 +00:00
desrosj 4f86a03258 Block Editor: Update `@wordpress` dependencies to match Gutenberg 4.5.1. 
- Update the annotations, api-fetch, block-library, blocks, components, compose, core-data, data, date, dom, edit-post, editor, element, format-library, html-entities, i18n, jest-console, jest-preset-default, keycodes, list-reusable-blocks, notices, nux, plugins, rich-text, scripts, token-lists, url, viewport packages.
- Upgrades React from 16.5.2 to 16.6.3.
- Adds a missing `wp-date` dependency to the editor script.
- Updates changed dependencies in `script-loader.php`.
- Fixes undefined notices in some blocks.
- Removes incorrect `gutenberg` textdomain.

Merges [43891], [43903], and [43919] to trunk.

Props atimmer, aduth, youknowriad, danielbachhuber.
See #45145.
Built from https://develop.svn.wordpress.org/trunk@44262


git-svn-id: http://core.svn.wordpress.org/trunk@44092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 15:37:00 +00:00
desrosj 9d7aa3436e Block Editor: Update `@wordpress` dependencies. 
Changes of note:

- Includes the new Annotations API package.
- `wp-polyfill-ecmascript.js` is renamed to `wp-polyfill.js`.
- `strip_dynamic_blocks()` has been removed in favor of `excerpt_remove_blocks()`.
- The PHP block parser is now syncing from the `block-serialization-default-parser` package.
- `do_blocks()` uses the new parser.
- The `do_block` filter has been removed from `do_blocks()`, in favor of a `render_block` filter in `render_block()`.

Also, a little cleanup to `render_block()`. Always normalize `$block['attrs’]` to array in `’render_block’` filter.
Props pento, azaozz.

Merges [43884] and [43888] to trunk.

See #45145, #45190, #45264, #45282.
Built from https://develop.svn.wordpress.org/trunk@44261


git-svn-id: http://core.svn.wordpress.org/trunk@44091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 04:52:00 +00:00
desrosj bbe9a37b6c Editor: Add custom fields meta box support in the block editor. 
This brings support for the custom fields meta box into the new block editor.

The `webpack` and `copy-webpack-plugin` packages have also been updated.

This does not bump the `@wordpress` packages like in [43861] because of conflicts with package versions already installed in `trunk`. The packages will be brought up to date in a subsequent merge.

Merges [43861] and [43863] into trunk.

See #45145.
Fixes #45257.
Built from https://develop.svn.wordpress.org/trunk@44260


git-svn-id: http://core.svn.wordpress.org/trunk@44090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:52:51 +00:00
Sergey Biryukov dbc692fb84 Block Editor: Load TinyMCE inline scripts later. 
Previously, the TinyMCE inline scripts were added on the `init` action in the block editor. In the classic editor, however, these scripts are loaded when the TinyMCE window is printed, and some plugins rely on them being loaded later, so they can attach to the appropriate filters.

Props pento.
Merges [43901] to trunk.
Fixes #45338.
Built from https://develop.svn.wordpress.org/trunk@44251


git-svn-id: http://core.svn.wordpress.org/trunk@44081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:27:12 +00:00
Sergey Biryukov 8f1ed83852 Build Tools: Revert unrelated changes to `Gruntfile.js` added in [44245]. 
See #45156.
Built from https://develop.svn.wordpress.org/trunk@44246


git-svn-id: http://core.svn.wordpress.org/trunk@44076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:23:04 +00:00
Sergey Biryukov c6d8f995cd Build Tools: Add non-minified `@wordpress` scripts to the build output. 
Props atimmer.
Merges [43886] to trunk.
See #45156.
Built from https://develop.svn.wordpress.org/trunk@44245


git-svn-id: http://core.svn.wordpress.org/trunk@44075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:22:13 +00:00
Sergey Biryukov 6ef54307b1 Block Editor: Hide the Custom Fields meta box option if that meta box has been removed. 
Some plugins remove the Custom Fields meta box, particularly when they provide functionality that replaces it. The block editor would correctly not display this meta box in these circumstances, but it still showed the option to display or hide it.

Props pento, noisysocks.
Merges [43885] to trunk.
See #45282.
Built from https://develop.svn.wordpress.org/trunk@44244


git-svn-id: http://core.svn.wordpress.org/trunk@44074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:21:21 +00:00
Sergey Biryukov 223eb21b47 PHPCS: Fix errors introduced in [44241]. 
See #45283.
Built from https://develop.svn.wordpress.org/trunk@44243


git-svn-id: http://core.svn.wordpress.org/trunk@44073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:20:29 +00:00
Sergey Biryukov 659ca2bd1e Tests: Fix tests broken in PHP 5.x after [43879]. 
Props pento.
Merges [43883] to trunk.
See #45290.
Built from https://develop.svn.wordpress.org/trunk@44242


git-svn-id: http://core.svn.wordpress.org/trunk@44072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:19:38 +00:00
Sergey Biryukov 7f8d6eccd0 Meta Boxes: Add the `block_editor_meta_box_hidden_fields` action. 
Lacking an appropriate action in the classic editor, plugins that add meta boxes have historically hooked into various actions in order to add hidden input fields.

This change also adds backwards compatibility for two of the most common: `edit_form_after_title`, and `edit_form_advanced`.

Props pento, danielbachhuber.
Merges [43882] to trunk.
Fixes #45283.
Built from https://develop.svn.wordpress.org/trunk@44241


git-svn-id: http://core.svn.wordpress.org/trunk@44071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:18:47 +00:00
Sergey Biryukov eccc31aadf Block Editor: Prevent the meta box form from being accidentally submitted. 
Meta boxes are loaded inside a wrapper form, that the block editor submits as part of the saving process. It shouldn't be submitted manually.

Props pento.
Merges [43880] to trunk.
Fixes #45284.
Built from https://develop.svn.wordpress.org/trunk@44240


git-svn-id: http://core.svn.wordpress.org/trunk@44070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:17:56 +00:00
Sergey Biryukov 86bff28a19 Script Loader: Ensure default packages are registered when loaded via load-scripts.php. 
Props CantoThemes, ocean90.
Merges [43877] to trunk.
Fixes #45271.
Built from https://develop.svn.wordpress.org/trunk@44237


git-svn-id: http://core.svn.wordpress.org/trunk@44067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:15:20 +00:00
desrosj be0b403077 Docs: Future-proof comments referencing 5.0 TODOs. 
Some Customizer-related files contain inline comments referencing work to do for #42364 for 5.0. Those comments are now outdated as #42364 was moved to the 5.1 milestone.

Merges [43887] to trunk.

Props dlh, pento.
Fixes #45115.
Built from https://develop.svn.wordpress.org/trunk@44228


git-svn-id: http://core.svn.wordpress.org/trunk@44058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:07:55 +00:00
Jeremy Felt 7ffb7340f5 Editor: Cast the result of the `default_content`, `default_title`, and `default_excerpt` filters. 
If a plugin returns a non-string value (or returns `null`) on these filters, it can cause errors in the block editor. Casting them as a string prevents these errors.

Merges [43858] from the 5.0 branch to trunk.

Props dd32.
See #45236.

Built from https://develop.svn.wordpress.org/trunk@44224


git-svn-id: http://core.svn.wordpress.org/trunk@44054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:04:29 +00:00
Jeremy Felt 7b58ca24e3 Block Editor: Remove CodeMirror settings. 
CodeMirror is no longer used in the block editor, so we don't need to load the settings.

Merges [43857] from the 5.0 branch to trunk.

Props noisysocks.
Fixes #45248.

Built from https://develop.svn.wordpress.org/trunk@44223


git-svn-id: http://core.svn.wordpress.org/trunk@44053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:03:38 +00:00
Jeremy Felt c92118203b Block Editor: Don't show back compat or incompatible meta boxes in Options. 
Meta boxes that exist for back compat, or that are incompatible with the block editor aren't displayed, so they don't need an option to display or hide them in the Options dialog.

Merges [43856] from the 5.0 branch to trunk.

Props noisysocks.
Fixes #45249.

Built from https://develop.svn.wordpress.org/trunk@44222


git-svn-id: http://core.svn.wordpress.org/trunk@44052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:02:46 +00:00
Jeremy Felt 49418dbd7e Posts: Remove the slug from Quick Edit for posts that are not `is_post_type_viewable()`. 
This is a followup to [43728], which added the same check, but using the `publicly_queryable` option. This behaviour is incorrect for `_builtin` post types, which go by the logic in `is_post_type_viewable()`, instead.

Merges [43855] from the 5.0 branch to trunk.

Props pento.
See #43278.

Built from https://develop.svn.wordpress.org/trunk@44221


git-svn-id: http://core.svn.wordpress.org/trunk@44051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:01:56 +00:00
Jeremy Felt b93dd61e90 Blocks: Add "Export as JSON" action to the `wp_block` post list screen. 
Remove the "Quick Edit" for `wp_block`s, too, as they don't need any of that functionality.

Merges [43854] from the 5.0 branch to trunk.

Props noisysocks.
Fixes #45247.

Built from https://develop.svn.wordpress.org/trunk@44220


git-svn-id: http://core.svn.wordpress.org/trunk@44050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-17 03:01:05 +00:00
Jeremy Felt c9f8525211 Blocks: Include necessary labels for the 'wp_block' post type. 
Merges [43849] from the 5.0 branch to trunk.

Props danielbachhuber.
See #45098.

Built from https://develop.svn.wordpress.org/trunk@44215


git-svn-id: http://core.svn.wordpress.org/trunk@44045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-16 01:25:52 +00:00
Jeremy Felt ff7b1bfe48 Block Editor: Fix meta boxes not showing. 
The block editor needs to duplicate the classic meta box behaviour, so it can extract the registered meta boxes, and import them into the block editor.

To match the classic editor behaviour as closely as possible, this moves the relevant code from the classic editor, into a new function, so it can be called by both.

Merges [43837] from the 5.0 branch to trunk.

Props pento, peterwilsoncc.
Fixes #45172.

Built from https://develop.svn.wordpress.org/trunk@44214


git-svn-id: http://core.svn.wordpress.org/trunk@44044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-16 01:19:54 +00:00
atimmer 7616bf91af FTP/PemFTP Library: Fix some PHP notices. 
ftp_base::glob() used each(), which is deprecated as of PHP 7.2.
ftp_base::fget() was missing the decleration of its third parameter, $rest.

Props itowhid06, pento.
Merges [43848] to trunk.
Fixes #44489.

Built from https://develop.svn.wordpress.org/trunk@44184


git-svn-id: http://core.svn.wordpress.org/trunk@44014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-15 11:00:40 +00:00
atimmer cc13a1f3a0 General: Fix code formatting issues. 
Fix code formatting after [44174] and [44177].

Built from https://develop.svn.wordpress.org/trunk@44178


git-svn-id: http://core.svn.wordpress.org/trunk@44008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 11:02:53 +00:00
atimmer a603510b73 Build Tools: Upgrade @wordpress packages to the latest version. 
This also includes the new @wordpress/format-library and @wordpress/notices packages.

package-lock.json has been completely regenerated in this commit.

Props pento.
Merges [43840] to trunk.
See #45145.

Built from https://develop.svn.wordpress.org/trunk@44177


git-svn-id: http://core.svn.wordpress.org/trunk@44007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 10:55:01 +00:00
atimmer a409c41f62 Meta boxes: Don't show the block editor incompatiblity message when it doesn't apply. 
We should only be showing this message in the classic editor interface, for meta boxes that are marked as being incompatible with the block editor.

Props pento.
Merges [43839] to trunk.
Fixes #45207.

Built from https://develop.svn.wordpress.org/trunk@44175


git-svn-id: http://core.svn.wordpress.org/trunk@44005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 09:42:53 +00:00
atimmer 20992de206 Meta boxes: Don't assume that callback args are an array. 
While the documentation for add_meta_box() specifices that $callback_args should be an array, this has never been enforced, and we have workarounds in place for when it's passed as something other than an array.

Rather than break sites that are passing unexpected data, we can quietly just allow for it, instead.

Props johnjamesjacoby, birgire, pento.
Merges [43838] to trunk.
Fixes #45206.

Built from https://develop.svn.wordpress.org/trunk@44174


git-svn-id: http://core.svn.wordpress.org/trunk@44004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 09:39:51 +00:00
Gary Pendergast d8863244cb Block Editor: Preload `wp/v2/media` with OPTIONS for caps check. 
Also introduces a `block_editor_preload_paths` filter for plugins and themes to preload additional data.

Merges [43833] from the 5.0 branch to trunk.

Props imath, mattheu, danielbachhuber.
Fixes #45194.


Built from https://develop.svn.wordpress.org/trunk@44172


git-svn-id: http://core.svn.wordpress.org/trunk@44002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 06:02:52 +00:00
Gary Pendergast 3eafdad299 Meta Boxes: Fix error when a meta box is rendered with a static method callback. 
When `WP_DEBUG` is set, ensure that a static method callback is passed to `ReflectionMethod`, instead of `ReflectionFunction`.

Merges [43830] from the 5.0 branch to trunk.

Props DrewAPicture.
Fixes #45192.


Built from https://develop.svn.wordpress.org/trunk@44170


git-svn-id: http://core.svn.wordpress.org/trunk@44000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 05:55:53 +00:00
Gary Pendergast 4739b8147b Upgrade/Install: Convert `Sample Page`, `Hello World`, and `Privacy Policy` to block content. 
Merges [43820,43912] from the 5.0 branch to trunk.

Props desrosj, garrett-eclipse, danielbachhuber, dd32, ocean90.
Fixes #45151.


Built from https://develop.svn.wordpress.org/trunk@44168


git-svn-id: http://core.svn.wordpress.org/trunk@43998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 05:43:52 +00:00
Gary Pendergast 8464097ea4 Editor: Merge some minor bug fixes. 
There were some tweaks made to the post editor in WordPress 5.0 that hadn't been merged to `trunk`, this commit rectifies that.

Merges [43815,43816] from the 5.0 branch to trunk.

Props birgire, jorbin, abdullahramzan, adamsilverstein, mrahmadawais, airathalitov, ajitbohra, schlessera, albertomedina, aldavigdis, alexsanford1, xyfi, nitrajka, afercia, andreiglingeanu, euthelup, aduth, sumobi, anevins, azaozz, androb, andrewserong, kallehauge, nosolosw, apeatling, atimmer, arnaudban, asvinballoo, b-07, benlk, blowery, caxco93, benjamin_zekavica, kau-boy, bernhard-reiter, bcolumbia, bph, boblinthorst, bradyvercher, bpayton, brentswisher, bronsonquick, burhandodhy, icaleb, chouby, ehg, chrisvanpatten, butimnoexpert, christophherr, chriskmnds, claudiosanches, danielbachhuber, mrmadhat, danielhw, danieltj, goldsounds, dfangstrom, daniloercoli, dannycooper, nerrad, dsawardekar, davemoran118, davidherrera, dryanpress, davidsword, davisshaver, dmsnell, dlocc, diegoreymendez, dd32, dency, ocean90, donnapep, chopinbach, electricfeet, eliorivero, sewmyheadon, ericnmurphy, foobar4u, circlecube, fabs_pim, flixos90, floriansimeth, gma992, garrett-eclipse, garyj, pento, doomwaxer, revgeorge, gziolo, bordoni, hardeepasrani, helen, luehrsen, herbmiller, toro_unit, ianbelanger, iandunn, igorsch, ipstenu, ireneyoast, israelshmueli, sisanu, jd55, copons, jnylen0, jamestryon, ephoxjames, jamiehalvorson, jsnajdr, jagnew, dciso, octalmage, vengisss, jhoffm34, shenkj, audrasjb, jblz, jeremyfelt, motleydev, jipmoors, sephsekla, joemaller, joemcgill, joen, johndyer, johnjamesjacoby, joshuawold, johnny5, desrosj, jonsurrell, belcherj, sirjonathan, koke, jorgefilipecosta, shelob9, jvisick77, julienmelissas, kopepasah, kadamwhite, codebykat, ryelle, gwwar, kevinwhoffman, coderkevin, ixkaito, kjellr, obenland, lancewillett, postphotos, loicblascos, lucasstark, luigipulcini, lucaskowalski, lukepettway, mahdiyazdani, mahmoudsaeed, mkaz, tyxla, markjaquith, mapk, vindl, m-e-h, mboynes, mattheu, lonelyvegan, mtias, napy84, maurobringolf, maximebj, mayukojpn, woodent, michaelhull, mmtr86, stubgo, simison, mihai2u, mike-haydon-swo, mnelson4, mpheasant, mikeschroder, idpokute, mikeyarce, dimadin, gonzomir, milesdelliott, warmarks, munirkamal, nfmohit, nateconley, greatislander, njpanderson, notnownikki, nielslange, nikschavan, potbot, nshki, webmandesign, oskosk, pglewis, pareshradadiya-1, swissspidy, pbearne, pauldechov, psealock, paulstonier, paulwilde, pedromendonca, ptasker, peterwilsoncc, tyrannous, strategio, piersb, delawski, prtksxna, presskopp, rachelbaker, rachelmcr, rakshans1, rahmon, lamosty, youknowriad, riddhiehta02, noisysocks, deviodigital, sanchothefat, robertsky, _dorsvenabili, rohittm, magicroundabout, rmccue, welcher, ryo511, sagarprajapati, samikeijonen, scottmweaver, kluny, sharaz, giventofly76, designsimply, sstoqnov, hypest, netweb, stevehenty, stuartfeldt, sergioestevao, soean, tammie_l, karmatosed, thrijith, timgardner, timmydcrawford, tjnowell, mirucon, travislopes, truongwp, tjfunke001, vishalkakadiya, vtrpldn, walterebert, westonruter, skorasaurus, somtijds, earnjam, williampatton, willybahuaud, yoavf, zebulan, ziyaddin, abhijitrakas, andreamiddleton, csabotta, dixitadusara, etoledom, faishal, hideokamoto, imath, iseulde, j-falk, jaswrks, johnwatkins0, jomurgel, notlaura, leahkoerper, mcsf, meetjey, 0mirka00, mitogh, ephoxmogran, tacrapo, mzorz, nagayama, omarreiss, ramonopoly, rileybrook, tinkerbelly, shaileesheth, sikander, ssousa, tfrommen, yahil.

Fixes #45037.


Built from https://develop.svn.wordpress.org/trunk@44165


git-svn-id: http://core.svn.wordpress.org/trunk@43995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 05:12:52 +00:00
desrosj dd7e2243fa Meta: Allow empty strings to be set by Custom Fields meta box. 
Because the REST API allows meta keys to have empty values, the Custom Fields meta box should permit the same behavior.

Props charlestonsw, soulseekah, danielbachhuber.

Merges [43811] to trunk.

Fixes #43559.
Built from https://develop.svn.wordpress.org/trunk@44153


git-svn-id: http://core.svn.wordpress.org/trunk@43983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 03:17:38 +00:00
Gary Pendergast 5e62e6b203 Bundled Themes: Make twentynineteen the default theme. 
After [44149], we can now make twentynineteen the default theme. Twentyseventeen has been a great default, but 5.0 and twentynineteen is guten.

Merges [43809,43954] from the 5.0 branch to trunk.

Fixes #45152.
Props jorbin, SergeyBiryukov, pento, mcsf.


Built from https://develop.svn.wordpress.org/trunk@44151


git-svn-id: http://core.svn.wordpress.org/trunk@43981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 02:49:38 +00:00
Jeremy Felt 3af9743b81 Blocks: Add the reusable block post type, `wp_block`. 
Merges [43804] from the 5.0 branch to trunk.

See #45098.

Built from https://develop.svn.wordpress.org/trunk@44146


git-svn-id: http://core.svn.wordpress.org/trunk@43976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 02:15:37 +00:00
Jeremy Felt fe31e0adc5 Meta Boxes: Sync checks for valid meta boxes from `do_meta_boxes()` to `the_block_editor_meta_boxes()`. 
Merges [43792] from the 5.0 branch to trunk.

Props ocean90.
See #45112.

Built from https://develop.svn.wordpress.org/trunk@44141


git-svn-id: http://core.svn.wordpress.org/trunk@43971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 01:56:17 +00:00
Gary Pendergast 313bc3fc73 Block Editor: Add extra body classes when the block editor is loaded. 
Merges [43780] from the 5.0 branch to trunk.

See #45037.


Built from https://develop.svn.wordpress.org/trunk@44133


git-svn-id: http://core.svn.wordpress.org/trunk@43963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 01:21:38 +00:00
Gary Pendergast daaf15cb09 Meta Boxes: Add `__back_compat_meta_box` and `__block_editor_compatible_meta_box` flags to meta boxes. 
When meta boxes are registered, they can use the `__back_compat_meta_box` and `__block_editor_compatible_meta_box` flags, to show whether this registration just exists for if the classic editor is loaded, and whether this meta box is compatible with the block editor.

When a meta box marks itself as incompatible with the block editor, and `WP_DEBUG` is enabled, a warning will show inside that meta box in the classic editor.

As all core meta boxes have been recreated in the block editor, they can be marked with the `__back_compat_meta_box` flag.

Merges [43779] from the 5.0 branch to trunk.

See #45112.


Built from https://develop.svn.wordpress.org/trunk@44132


git-svn-id: http://core.svn.wordpress.org/trunk@43962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 01:18:38 +00:00
Gary Pendergast a119d4561e Block Editor: Add helper functions to collect meta box information. 
To allow the block editor to render meta boxes, it needs to collect information about how those meta boxes are registered, and format it for the block editor to make use of.

Merges [43778] from the 5.0 branch to trunk.

See #45112.


Built from https://develop.svn.wordpress.org/trunk@44131


git-svn-id: http://core.svn.wordpress.org/trunk@43961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 01:11:37 +00:00
Gary Pendergast 74e7094bd0 Block Editor: Add an `is_block_editor()` method to `WP_Screen`. 
This method allows checking (or setting) whether the block editor is loading on the current screen.

Merges [43777] from the 5.0 branch to trunk.

See #45037.

Built from https://develop.svn.wordpress.org/trunk@44130


git-svn-id: http://core.svn.wordpress.org/trunk@43960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 01:08:38 +00:00
desrosj e125a29326 Upgrade/Install: Deactivate Gutenberg plugin on update to 5.0. 
Props mcsf.

Merges [43765] to trunk.

Fixes #45123.
Built from https://develop.svn.wordpress.org/trunk@44125


git-svn-id: http://core.svn.wordpress.org/trunk@43955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 22:27:04 +00:00
desrosj 85eb073748 i18n: Remove some translation domains accidentally included in [43762], [44122]. 
Moves [43764] to trunk.

Fixes #45110.
Built from https://develop.svn.wordpress.org/trunk@44124


git-svn-id: http://core.svn.wordpress.org/trunk@43954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 22:26:27 +00:00
desrosj 13226b445e Block Editor: Add helper functions for displaying the editor. 
`use_block_editor_for_post()` and `use_block_editor_for_post_type()` determine if the block editor should be loaded.

`get_block_categories()` and `get_block_editor_server_block_settings()` provide data be included while the block editor is loading.

Props pento.

Merges [43762] to trunk.

See #45110.
Built from https://develop.svn.wordpress.org/trunk@44122


git-svn-id: http://core.svn.wordpress.org/trunk@43952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 22:25:11 +00:00
Peter Wilson a2c890409b Multisite: Validate activation links. 
Built from https://develop.svn.wordpress.org/trunk@44048


git-svn-id: http://core.svn.wordpress.org/trunk@43878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 01:26:24 +00:00
atimmer 0a372b57d0 Build/Test: Update dependencies for 5.0 
Updates package dependencies to more modern versions, also adds .nvmrc and package-lock.json as followups to [43683] and [43571].

Merge notes: trunk already had an identical .nvmrc. package-lock.json exists in trunk, but has some changes based on the dependency updates.

Props jorbin.
Merges [43684], [43685] and [43686] to trunk.
See #44600.
Fixes #45064.

Built from https://develop.svn.wordpress.org/trunk@43977


git-svn-id: http://core.svn.wordpress.org/trunk@43809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-11 16:13:26 +00:00
Aaron Jorbin 99836a26c2 PHPCS: Fix errors 
Fix errors introduced in [43973] due to Jorbin not running the correct tag of wpcs.

Unprops jorbin.


Built from https://develop.svn.wordpress.org/trunk@43976


git-svn-id: http://core.svn.wordpress.org/trunk@43808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-11 04:45:23 +00:00
Aaron Jorbin 8169b49e75 REST API: Persist attributes for attachment links 
In [43437], the link definition implementation caused attachment links to be unexpectedly nested under an attributes key. This changeset restores the prior behavior.

Merges [43681] to trunk.

Props TimothyBlynJacobs, danielbachhuber.
Fixes #44750.

Built from https://develop.svn.wordpress.org/trunk@43973


git-svn-id: http://core.svn.wordpress.org/trunk@43805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-11 04:01:26 +00:00
Mel Choyce 0ec6056e40 List Table: Fix formatting issue introduced in r43671. 
Props dd32.
See #45028.

Built from https://develop.svn.wordpress.org/trunk@43672


git-svn-id: http://core.svn.wordpress.org/trunk@43501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-10-03 21:12:24 +00:00
Mel Choyce 4cee2ae135 List Table: Restore the List Table items property to allow Bulk Actions to be properly determined. 
This fixes the display of Bulk Actions where there exists only a single page of results.

Props shaneeckert, jobthomas, dd32.
Fixes #45028.

Built from https://develop.svn.wordpress.org/trunk@43671


git-svn-id: http://core.svn.wordpress.org/trunk@43500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-10-03 19:47:25 +00:00
Mel Choyce 7081f6c8fa List Tables: Arrange action items into a grid with extra space. 
On small screens, list table actions were cramped. This makes it easy to press the wrong action by mistake. The items are now arranged into a grid and given extra room to create a larger tap-target.

The plugins list table was excluded because it's current layout doesn't match the others, and we should add more space to this in a future commit.

Props jobthomas, ryelle.
Fixes #45024.

Built from https://develop.svn.wordpress.org/trunk@43670


git-svn-id: http://core.svn.wordpress.org/trunk@43499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-10-03 18:56:24 +00:00