Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Andrew Ozz
6bd203bb50
TinyMCE Classic Block: fix the Edit Image modal to work as in the Classic Editor.
...
Fixes #46085 .
Built from https://develop.svn.wordpress.org/trunk@44695
git-svn-id: http://core.svn.wordpress.org/trunk@44526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:11:51 +00:00
Sergey Biryukov
3b73ac9eb3
Editor: Use explicit context instead of a trailing space for `Edit` string in TinyMCE plugins.
...
Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543 .
Built from https://develop.svn.wordpress.org/trunk@42523
git-svn-id: http://core.svn.wordpress.org/trunk@42352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 06:28:30 +00:00
Andrew Ozz
c56801657a
TinyMCE: fix cases where an additional empty link is created while updating an image with a link.
...
Props spocke.
Fixes #41259 .
Built from https://develop.svn.wordpress.org/trunk@41319
git-svn-id: http://core.svn.wordpress.org/trunk@41150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-26 16:34:46 +00:00
Andrew Ozz
a798266ba3
TinyMCE: remove unused code from the `wpeditimage` plugin.
...
Fixes #41369 .
Built from https://develop.svn.wordpress.org/trunk@41092
git-svn-id: http://core.svn.wordpress.org/trunk@40932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-19 13:41:46 +00:00
Andrew Ozz
b398ccf2a1
TinyMCE: fix pasting while an image with caption is selected. The image and the caption should be replaced with the pasted content.
...
Fixes #40809 .
Built from https://develop.svn.wordpress.org/trunk@40786
git-svn-id: http://core.svn.wordpress.org/trunk@40644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 22:25:41 +00:00
Andrew Ozz
9c1d14b875
TinyMCE: preserve empty image alt attributes.
...
Props afercia.
Fixes #39912 for trunk.
Built from https://develop.svn.wordpress.org/trunk@40110
git-svn-id: http://core.svn.wordpress.org/trunk@40047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-02-24 20:41:43 +00:00
Andrew Ozz
e2e22580db
TinyMCE:
...
- Prevent applying Indent and Outdent while an image with a caption is selected. It doesn't do anything and breaks the caption elements.
- Keep all of the text when a caption `<dl>` was somehow changed.
Fixes #38313 .
Built from https://develop.svn.wordpress.org/trunk@38796
git-svn-id: http://core.svn.wordpress.org/trunk@38739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-14 21:38:28 +00:00
Andrew Ozz
470c5a1f2a
TinyMCE: Allow pasting in image captions. Remove blocks and insert `<br>` tags instead, also remove elements that would break the caption like other images, video, audio, etc.
...
See #36211 .
Built from https://develop.svn.wordpress.org/trunk@38756
git-svn-id: http://core.svn.wordpress.org/trunk@38699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-07 21:41:29 +00:00
Andrew Ozz
08d59c211c
TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image.
...
Props fomenkoandrey for reporting and testing.
Fixes #37467 .
Built from https://develop.svn.wordpress.org/trunk@38328
git-svn-id: http://core.svn.wordpress.org/trunk@38269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-23 04:43:31 +00:00
Andrew Ozz
b86015e78b
TinyMCE: fix selecting an image on touch in iOS Safari for TinyMCE 4.4.1.
...
Fixes #37427 .
Built from https://develop.svn.wordpress.org/trunk@38156
git-svn-id: http://core.svn.wordpress.org/trunk@38097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-26 21:51:27 +00:00
Andrew Ozz
8fda4ca0b2
TinyMCE: when dragging, prevent error when a range cannot be created at the drop location.
...
Fixes #36229 .
Built from https://develop.svn.wordpress.org/trunk@36983
git-svn-id: http://core.svn.wordpress.org/trunk@36950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 22:55:25 +00:00
Andrew Ozz
ca1906b159
TinyMCE: remove the `srcset` and `sizes` attributes (if any) after replacing or editing an image.
...
See #35434 .
Built from https://develop.svn.wordpress.org/trunk@36376
git-svn-id: http://core.svn.wordpress.org/trunk@36343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-22 01:19:25 +00:00
Andrew Ozz
6c3261d3da
TinyMCE: update to 4.3.3. Update the QUnit tests and revert back to testing the non-minified files in /src.
...
Fixes #35539 .
Built from https://develop.svn.wordpress.org/trunk@36352
git-svn-id: http://core.svn.wordpress.org/trunk@36319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-20 04:18:33 +00:00
Gary Pendergast
6381e168b7
Pinking Shears: Remove some errant non-breaking spaces from a few JavaScript files.
...
Props francoisb.
Fixes #34658 .
Built from https://develop.svn.wordpress.org/trunk@35627
git-svn-id: http://core.svn.wordpress.org/trunk@35591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 12:04:27 +00:00
Andrew Ozz
7e1c68ea78
TinyMCE:
...
- Fix the inline toolbar on images in iOS, move it out of the way so the default inline toolbar is not over it.
- Fix selecting images on touch in the editor (iOS Safari fails to select them most of the time).
Fixes #34557 .
Built from https://develop.svn.wordpress.org/trunk@35607
git-svn-id: http://core.svn.wordpress.org/trunk@35571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 03:27:25 +00:00
Ella Iseulde Van Dorpe
9845e08340
TinyMCE: Drag and drop link with image
...
Make sure images don't loose their link after drag and drop.
Fixes #28272 .
Built from https://develop.svn.wordpress.org/trunk@35261
git-svn-id: http://core.svn.wordpress.org/trunk@35227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 11:05:23 +00:00
Ella Iseulde Van Dorpe
3eb4a57c27
TinyMCE: make captioned images draggable
...
See #28003 .
Built from https://develop.svn.wordpress.org/trunk@35199
git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 15:20:25 +00:00
Andrew Ozz
a231303341
TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content.
...
Fixes #33477 .
Built from https://develop.svn.wordpress.org/trunk@33834
git-svn-id: http://core.svn.wordpress.org/trunk@33802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 22:07:21 +00:00
Andrew Ozz
25b0eedf2b
TinyMCE: ensure the `wordpress` plugin is loaded before calling `_createToolbar()`.
...
Props hauvong, azaozz. Fixes #33393 .
Built from https://develop.svn.wordpress.org/trunk@33728
git-svn-id: http://core.svn.wordpress.org/trunk@33696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 04:38:20 +00:00
Andrew Ozz
7e51b698c6
TinyMCE: when deleting an image, ensure the wrapping link (if any) is deleted too. Fixes the erroneous showing of the link toolbar after deleting an image. Also small readability fix.
...
See #32604 .
Built from https://develop.svn.wordpress.org/trunk@33141
git-svn-id: http://core.svn.wordpress.org/trunk@33112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 00:25:25 +00:00
Ella Iseulde Van Dorpe
6e0e924de9
TinyMCE: wpeditimage: trim class
...
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.
Fixes #31764 .
Built from https://develop.svn.wordpress.org/trunk@32592
git-svn-id: http://core.svn.wordpress.org/trunk@32562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:35:28 +00:00
Andrew Ozz
6c5dec8886
TinyMCE: remove the empty paragraph that sometimes is left over after adding an image caption.
...
Fixes #32003 .
Built from https://develop.svn.wordpress.org/trunk@32141
git-svn-id: http://core.svn.wordpress.org/trunk@32121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-18 21:56:27 +00:00
Scott Taylor
5855cb0e60
When editing an image from the editor, and the image has a value for alignment (but not for `width` or `caption`), don't bail without first checking that the alignment's value is not `alignnone`. If so, add the `class` to the `<a>` before bailing.
...
See #21848 .
Built from https://develop.svn.wordpress.org/trunk@31958
git-svn-id: http://core.svn.wordpress.org/trunk@31937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:04:27 +00:00
Andrew Ozz
8b53e5470d
TinyMCE: remove blocking of commands on placeholder images. Breaks some execCommand.
...
Props iseulde. Fixes #31571 .
Built from https://develop.svn.wordpress.org/trunk@31738
git-svn-id: http://core.svn.wordpress.org/trunk@31719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:33:28 +00:00
Andrew Ozz
7d2b380330
TinyMCE: initialize the floating toolbars on preinit so we can attach other events on init.
...
Props iseulde. Fixes #30619 .
Built from https://develop.svn.wordpress.org/trunk@31732
git-svn-id: http://core.svn.wordpress.org/trunk@31713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 22:41:26 +00:00
Andrew Ozz
6e14ff9234
TinyMCE:
...
- Abstract the code for creating floating toolbars.
- Introduce `editor.wp` namespace to hold exported methods from our plugins.
- Create the wpView toolbar(s) with the new method. This makes them work the same as the image toolbar: shortcuts, esc key, etc.
Props iseulde. See #30619 .
Built from https://develop.svn.wordpress.org/trunk@31725
git-svn-id: http://core.svn.wordpress.org/trunk@31706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 19:12:28 +00:00
Andrew Ozz
d08bb970ae
TinyMCE: when pasting an URL over a selection, insert a link with the URL instead of replacing the selection with it. Props iseulde. Fixes #31571 .
...
Built from https://develop.svn.wordpress.org/trunk@31691
git-svn-id: http://core.svn.wordpress.org/trunk@31672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 20:00:27 +00:00
Andrew Ozz
c8892dfaa2
TinyMCE: ensure the image toolbar stays visible when the image is much wider than the editor. Props iseulde, fixes #20696 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@31362
git-svn-id: http://core.svn.wordpress.org/trunk@31343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 23:00:23 +00:00
Andrew Ozz
00436f6886
TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028 .
...
Built from https://develop.svn.wordpress.org/trunk@31235
git-svn-id: http://core.svn.wordpress.org/trunk@31216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 17:56:23 +00:00
Andrew Ozz
a7dcd2d736
TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785 .
...
Built from https://develop.svn.wordpress.org/trunk@31180
git-svn-id: http://core.svn.wordpress.org/trunk@31161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 21:33:25 +00:00
Andrew Ozz
9f2fc255f8
TinyMCE: add another `Edit` translatable string for the tooltip of the Edit button on the image toolbar. Props pavelevap, see #30694 .
...
Built from https://develop.svn.wordpress.org/trunk@30839
git-svn-id: http://core.svn.wordpress.org/trunk@30829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-13 00:47:22 +00:00
Andrew Ozz
b90c024d38
TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation. Fixes #30670 .
...
Built from https://develop.svn.wordpress.org/trunk@30829
git-svn-id: http://core.svn.wordpress.org/trunk@30819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-12 00:10:25 +00:00
Andrew Ozz
498c5d719c
TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642 .
...
Built from https://develop.svn.wordpress.org/trunk@30775
git-svn-id: http://core.svn.wordpress.org/trunk@30765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:08:42 +00:00
Andrew Ozz
efe8fd4694
TinyMCE, improve accessibility:
...
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642 .
Built from https://develop.svn.wordpress.org/trunk@30757
git-svn-id: http://core.svn.wordpress.org/trunk@30747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 23:53:22 +00:00
Andrew Ozz
91b8617f29
TinyMCE: manually fire `ExecCommand` when aligning images as we do `preventDefault()` on `BeforeExecCommand` for them. Props avryl, fixes #30565 .
...
Built from https://develop.svn.wordpress.org/trunk@30748
git-svn-id: http://core.svn.wordpress.org/trunk@30738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:33:24 +00:00
Andrew Ozz
f3ba529c2f
TinyMCE: don't hide the image toolbar when the iframe window fires onresize. There is a bug in several browsers that triggers onresize when a tooltip is shown, only in RTL mode. Also use better variable name. Fixes #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30560
git-svn-id: http://core.svn.wordpress.org/trunk@30549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 04:31:23 +00:00
Andrew Ozz
20e753a8c7
TinyMCE: use the actual image node when calculating the position of the toolbar. Fixes a bug in old IE. See #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30558
git-svn-id: http://core.svn.wordpress.org/trunk@30547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 01:22:21 +00:00
Andrew Nacin
87023d64b4
TinyMCE: Verify HTML in captions. props azaozz
...
Built from https://develop.svn.wordpress.org/trunk@30435
git-svn-id: http://core.svn.wordpress.org/trunk@30430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 13:49:22 +00:00
Andrew Ozz
e5f57d2870
TinyMCE: fix the tooltip for 'alignnone' button on the image toolbar. Props johnbillion, see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30385
git-svn-id: http://core.svn.wordpress.org/trunk@30382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 17:27:22 +00:00
Andrew Ozz
69b529024a
Fix typo in [30361], see #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30362
git-svn-id: http://core.svn.wordpress.org/trunk@30361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 23:15:23 +00:00
Andrew Ozz
22b760088c
TinyMCE: don't show image toolbar for placeholder images. See #30147 .
...
Built from https://develop.svn.wordpress.org/trunk@30361
git-svn-id: http://core.svn.wordpress.org/trunk@30360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 23:12:22 +00:00
Andrew Ozz
69105d29e8
TinyMCE: enhance the inline toolbar for images:
...
- Add alignment (left, center, right, none) buttons.
- Position the menu above the image when possible, except on iOS.
- Fix selecting images on iOS.
First run, part props avryl. See #30147 .
Built from https://develop.svn.wordpress.org/trunk@30318
git-svn-id: http://core.svn.wordpress.org/trunk@30317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 00:56:22 +00:00
Andrew Ozz
4dfe796cd2
TinyMCE: update to 4.1.6+. Adds support for cache-busting when auto-loading JS and CSS. Change the tests to run in /build. Changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt .
...
Fixes #30079
Built from https://develop.svn.wordpress.org/trunk@29994
git-svn-id: http://core.svn.wordpress.org/trunk@29735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-23 02:08:20 +00:00
Andrew Ozz
6592e13cae
TinyMCE: fix image captions regexp when wpautop is disabled in wp_editor(). Fixes #29592 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29730
git-svn-id: http://core.svn.wordpress.org/trunk@29504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 23:03:18 +00:00
Andrew Ozz
228c77ca2f
TinyMCE: fix the keycode check when removing the Edit/Delete toolbar from images on keydown, see #28705
...
Built from https://develop.svn.wordpress.org/trunk@29541
git-svn-id: http://core.svn.wordpress.org/trunk@29317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 19:14:16 +00:00
Andrew Ozz
28bcbcb972
Fix typo in the 'wpeditimage' plugin, see #28705
...
Built from https://develop.svn.wordpress.org/trunk@29540
git-svn-id: http://core.svn.wordpress.org/trunk@29316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 18:43:20 +00:00
Andrew Ozz
aff2892646
TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes #29235 .
...
Built from https://develop.svn.wordpress.org/trunk@29521
git-svn-id: http://core.svn.wordpress.org/trunk@29297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 20:11:15 +00:00
Andrew Ozz
2f4bd918b2
TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595 , #29166
...
Built from https://develop.svn.wordpress.org/trunk@29471
git-svn-id: http://core.svn.wordpress.org/trunk@29249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 04:27:18 +00:00
Andrew Ozz
e75033f21b
TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595 , #29166
...
Built from https://develop.svn.wordpress.org/trunk@29463
git-svn-id: http://core.svn.wordpress.org/trunk@29241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-10 04:22:15 +00:00