WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,739 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

18975 Commits

Author SHA1 Message Date
Drew Jaynes 5ec1077a38 Widgets: Introduce a `delete_widget` action, which fires after a widget has been marked for deletion. 
Props afercia for the initial patch.
Fixes #27444.

Built from https://develop.svn.wordpress.org/trunk@34714


git-svn-id: http://core.svn.wordpress.org/trunk@34678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:21:26 +00:00
Boone Gorges 67077ce72a Fix logical errors in some comment pagination tests. 
The tests included in [34669] contained a couple of problems:

* Comments were not always created in the expected order, due to the incorrect use of 'comment_date_gmt'.
* 'asc'/'desc' and 'older'/'newer' were confused.
* 'default_comments_page=newest' ('last') didn't properly account for the cpage=1 offset.

The code itself powering this pagination was correct; it's only the tests that
were wrong.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@34713


git-svn-id: http://core.svn.wordpress.org/trunk@34677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 03:07:26 +00:00
Drew Jaynes d25ac6bfec Docs: Mark a few optional parameters as such in wp-includes/rewrite-functions.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34712


git-svn-id: http://core.svn.wordpress.org/trunk@34676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 02:42:26 +00:00
Boone Gorges 654eeb3785 Improve lazyloading of comment meta in `WP_Query` loops. 
Lazy-loading logic is moved to a method on `WP_Query`. This makes it possible
for comment feeds to take advantage of metadata lazyloading, in addition to
comments loaded via `comments_template()`.

This new technique parallels the termmeta lazyloading technique introduced in
[34704].

Fixes #34047.
Built from https://develop.svn.wordpress.org/trunk@34711


git-svn-id: http://core.svn.wordpress.org/trunk@34675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:35:26 +00:00
Scott Taylor 21752923f0 List Tables: `.column-date` needs to become wider at smaller screen sizes, bump it from `10%` to `14%` at the breakpoint to prevent wrapping. 
Fixes #32691.

Built from https://develop.svn.wordpress.org/trunk@34710


git-svn-id: http://core.svn.wordpress.org/trunk@34674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:25:25 +00:00
Scott Taylor 41bc0aee88 Revert [34083], I was willing to try this out for the greater good. The good was not greater. There is too much baggage associated with this specific change as pertains to BC and expected layout. 
See #32691.

Built from https://develop.svn.wordpress.org/trunk@34709


git-svn-id: http://core.svn.wordpress.org/trunk@34673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:19:24 +00:00
Scott Taylor 619063b4e2 Rewrite: allow `add_rewrite_rule|WP_Rewrite::add_rule()` to accept an associative array for the value of `$redirect` instead of requiring a query string. 
Adds unit tests.

Props scribu, DrewAPicture.
Fixes #16840.

Built from https://develop.svn.wordpress.org/trunk@34708


git-svn-id: http://core.svn.wordpress.org/trunk@34672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 01:11:25 +00:00
Scott Taylor 882c34d555 List Tables: only hide bulk actions when there are no items, don't hide all of the extra table nav. 
Fixes #33824.

Built from https://develop.svn.wordpress.org/trunk@34707


git-svn-id: http://core.svn.wordpress.org/trunk@34671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-30 00:47:27 +00:00
Drew Jaynes 471a507dfd Docs: Add an `@see` reference for the "use-instead-of" function in the DocBlock for `force_ssl_login()`, deprecated in [34700]. 
See #34011. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34706


git-svn-id: http://core.svn.wordpress.org/trunk@34670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:46:25 +00:00
Drew Jaynes 492c11508a Users: Add the default arguments array as a second parameter to the `wp_dropdown_users_args` filter, introduced in [34692]. 
Adjust hook doc descriptions accordingly.

See #19867.

Built from https://develop.svn.wordpress.org/trunk@34705


git-svn-id: http://core.svn.wordpress.org/trunk@34669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:39:25 +00:00
Boone Gorges db880777f4 Improve lazyloading of term metadata in `WP_Query` loops. 
[34529] introduced lazyloading for the metadata belonging to terms matching
posts in the main `WP_Query`. The current changeset improves this technique
in the following ways:

* Term meta lazyloading is now performed on the results of all `WP_Query` queries, not just the main query.
* Fewer global variable touches and greater encapsulation.
* The logic for looping through posts to identify terms is now only performed once per `WP_Query`.

Props dlh, boonebgorges.
See #34047.
Built from https://develop.svn.wordpress.org/trunk@34704


git-svn-id: http://core.svn.wordpress.org/trunk@34668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 22:00:24 +00:00
John Blackbourn ae5f825093 `force_ssl_login()` has been functionally identical to `force_ssl_admin()` since 4.0 (#10267), so its test assertions can be removed as the function has been deprecated in [34700]. The remaining assertions suitably cover `force_ssl_admin()`. 
See #34011

Built from https://develop.svn.wordpress.org/trunk@34703


git-svn-id: http://core.svn.wordpress.org/trunk@34667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:44:33 +00:00
Scott Taylor addb8fe492 Customizer: make "Current header" clickable in the same way that "Background Image" is - will open the media modal. 
Props umesh.nevase.
Fixes #33586.

Built from https://develop.svn.wordpress.org/trunk@34702


git-svn-id: http://core.svn.wordpress.org/trunk@34666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:40:24 +00:00
Scott Taylor 84dbb036d1 Network Upgrade: switch `<h3>` to `<h2>`. 
Props afercia.
Fixes #34082.

Built from https://develop.svn.wordpress.org/trunk@34701


git-svn-id: http://core.svn.wordpress.org/trunk@34665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:29:13 +00:00
John Blackbourn a8728b987f Deprecate `force_ssl_login()`, which is simply a wrapper for `force_ssl_admin()` and is not used in core. 
Fixes #34011

Built from https://develop.svn.wordpress.org/trunk@34700


git-svn-id: http://core.svn.wordpress.org/trunk@34664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:28:50 +00:00
Drew Jaynes 25f5bf2389 Tests: Add two tests for the current behavior of the 'hierarchical' and 'child_of' arguments in `get_pages()`. 
See #18701.

Built from https://develop.svn.wordpress.org/trunk@34699


git-svn-id: http://core.svn.wordpress.org/trunk@34663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 21:28:26 +00:00
Drew Jaynes 504ff681d4 Tests: Add two tests for the current 'hierarchical' argument behavior in `get_pages()`. 
See #18701.

Built from https://develop.svn.wordpress.org/trunk@34698


git-svn-id: http://core.svn.wordpress.org/trunk@34662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 20:50:26 +00:00
Boone Gorges c36d4fb8a9 `WP_Query` should not ignore an offset of `0`. 
Props mazurstas.
Fixes #34060.
Built from https://develop.svn.wordpress.org/trunk@34697


git-svn-id: http://core.svn.wordpress.org/trunk@34661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 19:37:23 +00:00
Boone Gorges 5b32e27a00 Fix 'exclude_tree' in `wp_list_categories()`. 
The 'exclude_tree' parameter must be compatible with 'hierarchical';
previously, 'hierarchical' canceled it out. This changeset also makes it so
that 'exclude_tree' is compatible with 'exclude'. When both are passed, and
'hierarchical' is true, the descendant trees of terms in both parameters will
be excluded from matched terms.

Props tott, webord, MikeHansenMe.
Fixes #12981.
Built from https://develop.svn.wordpress.org/trunk@34696


git-svn-id: http://core.svn.wordpress.org/trunk@34660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 19:12:27 +00:00
Andrea Fercia 9bb09f0e08 Bump H3 headings to H2 on the Network Settings screen for better accessibility. 
Fixes #34078.
Built from https://develop.svn.wordpress.org/trunk@34695


git-svn-id: http://core.svn.wordpress.org/trunk@34659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 18:52:26 +00:00
Aaron Jorbin 0209b32d67 Cleanup image size in unit tests 
This helps prevent test leakage that can cause Tests_Media::test_add_image_size to break.

See #33968


Built from https://develop.svn.wordpress.org/trunk@34694


git-svn-id: http://core.svn.wordpress.org/trunk@34658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 17:48:26 +00:00
John Blackbourn 27646b7ee0 Revert the introduction of validation of the comment author's email address when sanity checking input in `wp-comments-post.php` (introduced in r34274). This allows a problematic email address to fall through to the correct validation routine and show the "Please enter a valid email address" as expected. 
Fixes #23416

Built from https://develop.svn.wordpress.org/trunk@34693


git-svn-id: http://core.svn.wordpress.org/trunk@34657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 17:27:26 +00:00
Drew Jaynes 7866772449 Users: Introduce the `wp_dropdown_users_args` filter, making it possible to filter the arguments for `wp_dropdown_users()` before the query is run. 
The 'name' argument (or the `WP_Screen` object if in the admin) can be used to help target specific instances of `wp_dropdown_users()` via this hook.

Props norcross.
See #19867.

Built from https://develop.svn.wordpress.org/trunk@34692


git-svn-id: http://core.svn.wordpress.org/trunk@34656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 15:40:27 +00:00
John Blackbourn 4d377dd4a1 On the Permalink Settings screen, add a link to the Nginx documentation when the current site is running Nginx. This is in lieu of showing actual Nginx configuration like we do for mod_rewrite or IIS. 
Fixes #18852

Built from https://develop.svn.wordpress.org/trunk@34691


git-svn-id: http://core.svn.wordpress.org/trunk@34655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 11:15:26 +00:00
Gary Pendergast cf173408cd Permalinks: Add pretty permalinks for unattached attachments. 
Previously, unattached attachments would have unsightly `/?attachment_id=1` URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.

We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.

Props SergeyBiryukov, wonderboymusic, pento.

Fixes #1914.


Built from https://develop.svn.wordpress.org/trunk@34690


git-svn-id: http://core.svn.wordpress.org/trunk@34654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 09:42:26 +00:00
Drew Jaynes 1d86c9c1ed Docs: Move the hook doc to once again directly precede the hook line for the `getarchives_where` filter following [34686]. 
See #21596.

Built from https://develop.svn.wordpress.org/trunk@34689


git-svn-id: http://core.svn.wordpress.org/trunk@34653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 06:39:25 +00:00
Drew Jaynes b69ef84a77 Tests: Relocate tests for general-template.php to a more logically-placed (and named) file, tests/general/template.php. 
See #34070.

Built from https://develop.svn.wordpress.org/trunk@34688


git-svn-id: http://core.svn.wordpress.org/trunk@34652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:52:26 +00:00
Drew Jaynes d38e2fe848 Tests: Consolidate author-template tests into a single, more logically-placed file, tests/user/author.php. 
See #34070.

Built from https://develop.svn.wordpress.org/trunk@34687


git-svn-id: http://core.svn.wordpress.org/trunk@34651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:37:24 +00:00
Scott Taylor eeb539e90f Allow `wp_get_archives()` to accept `post_type` as an arg. 
Adds unit test.

Fixes #21596.

Built from https://develop.svn.wordpress.org/trunk@34686


git-svn-id: http://core.svn.wordpress.org/trunk@34650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 05:11:24 +00:00
Gary Pendergast 1db89dd3bf Rewrite: Redirect attachment URLs when their slug changes. 
Using the same logic that we use to redirect posts when their slug changes, we can provide the same functionality for attachments. Attachment pages are posts, too.

Props swissspdy.

Fixes #34043.


Built from https://develop.svn.wordpress.org/trunk@34685


git-svn-id: http://core.svn.wordpress.org/trunk@34649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:58:25 +00:00
Scott Taylor 7efab8df3f Edit Media: wrap long filenames in the Publish meta box. 
Fixes #34069.

Built from https://develop.svn.wordpress.org/trunk@34684


git-svn-id: http://core.svn.wordpress.org/trunk@34648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:51:25 +00:00
Scott Taylor f77499ed22 RSS Widget: add a class, `rss-widget-icon`, to the RSS icon to allow devs to hide it. Not going to remove to not break visual BC. 
Fixes #22010.

Built from https://develop.svn.wordpress.org/trunk@34683


git-svn-id: http://core.svn.wordpress.org/trunk@34647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:32:25 +00:00
Scott Taylor f2bd17193d XML-RPC: add a unit test for `mw.editPost`. 
See #16980.

Built from https://develop.svn.wordpress.org/trunk@34682


git-svn-id: http://core.svn.wordpress.org/trunk@34646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:28:25 +00:00
Scott Taylor 111c05ba47 XML-RPC: calculate the proper offset for GMT in `wp.newPost`, `mw.newPost`, and `mw.editPost` when `post_date` is set, `wp.editComment` when `comment_date` is set. `post|comment_date` is assumed to be GMT. This is only true if the timezone string for the site matches GMT. 
Adds unit tests for each.

Props smerriman, justdaiv, wonderboymusic.
Fixes #30429.

Built from https://develop.svn.wordpress.org/trunk@34681


git-svn-id: http://core.svn.wordpress.org/trunk@34645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:05:24 +00:00
Boone Gorges f584a3debb Add unit tests for `post_exists()`. 
Props MikeHansenMe.
See #34012.
Built from https://develop.svn.wordpress.org/trunk@34680


git-svn-id: http://core.svn.wordpress.org/trunk@34644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 04:02:24 +00:00
Boone Gorges 061c536031 Don't require explicit taxonomy when getting terms by term_taxonomy_id. 
Props wonderboymusic.
Fixes #30620.
Built from https://develop.svn.wordpress.org/trunk@34679


git-svn-id: http://core.svn.wordpress.org/trunk@34643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 03:52:25 +00:00
Drew Jaynes e9cfe211bc Tests: Flush rewrite rules between tests in an attempt to avoid permalinks pollution in `Tests_Author_Template`. 
See #30355.

Built from https://develop.svn.wordpress.org/trunk@34678


git-svn-id: http://core.svn.wordpress.org/trunk@34642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 02:19:26 +00:00
Drew Jaynes d242d5bbfb Introduce `get_the_author_posts_link()`, which returns the HTML link to the author page for the current post's author. 
`the_author_posts_link()` has in-turn been converted into a wrapper, with most of its logic moved to the new function.

Adds tests for the new function.

Props chipbennett, zrothauser, wonderboymusic, DrewAPicture.
Fixes #30355.

Built from https://develop.svn.wordpress.org/trunk@34677


git-svn-id: http://core.svn.wordpress.org/trunk@34641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:49:25 +00:00
Jeremy Felt d5b2929dbb Docs: Clarify `$user` parameter documentation in `wpmu_validate_blog_signup`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34676


git-svn-id: http://core.svn.wordpress.org/trunk@34640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:33:27 +00:00
John Blackbourn 5f09357c21 Revert r34674 due to failures on PHP < 5.4. 
See #16859

Built from https://develop.svn.wordpress.org/trunk@34675


git-svn-id: http://core.svn.wordpress.org/trunk@34639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 01:01:24 +00:00
John Blackbourn eb352accc4 Avoid stripping square brackets from URLs, and instead correctly encode them. 
Square brackets must be encoded in the path, path parameters, query parameters, and fragment, but must not be encoded in anything up to the domain and port.

Adds a bunch of tests, including square brackets in query parameters, IPv6 URLs, and several other permutations.

See #16859

Built from https://develop.svn.wordpress.org/trunk@34674


git-svn-id: http://core.svn.wordpress.org/trunk@34638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-29 00:41:24 +00:00
Jeremy Felt ea03ecbe66 Fixes #33816. 
MS: Adjust formatting of code in `site-new.php` to improve readability.

Fixes #34066.

Built from https://develop.svn.wordpress.org/trunk@34673


git-svn-id: http://core.svn.wordpress.org/trunk@34637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 23:30:24 +00:00
Jeremy Felt 5397416276 MS: Delete `rewrite_rules` when updating a switched site's URL. 
Previously, rewrite rules could be flushed and regenerated in the context of another site. Deleting the rules when in a switched state allows for them to be generated properly on the next page view.

Fixes #33816.

Built from https://develop.svn.wordpress.org/trunk@34672


git-svn-id: http://core.svn.wordpress.org/trunk@34636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 23:24:27 +00:00
Helen Hou-Sandí 02703fae19 Sample permalink: Buttons still need the `.button` class. 
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.

see #18306.

Built from https://develop.svn.wordpress.org/trunk@34671


git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 22:07:25 +00:00
Helen Hou-Sandí e976f9b503 Edit: Remove the redundant "View Post" button-link and link the sample permalink. 
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.

Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.

props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306.

Built from https://develop.svn.wordpress.org/trunk@34670


git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 20:10:26 +00:00
Boone Gorges f7f4fb01ab Fix comment_order for single page comment threads. 
The old comment pagination logic had a separate block for comment threads that
appeared on a single page. After the refactoring in [34561], all comment
pagination logic is unified.

This change ensures that 'comment_order' is respected in all scenarios.

Fixes #8071.
Built from https://develop.svn.wordpress.org/trunk@34669


git-svn-id: http://core.svn.wordpress.org/trunk@34633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:30:26 +00:00
John Blackbourn 5bfa878fee Correctly slash post fields when trashing and untrashing posts. 
Fixes #27550
Props dmenard, Denis-de-Bernardy

Built from https://develop.svn.wordpress.org/trunk@34668


git-svn-id: http://core.svn.wordpress.org/trunk@34632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:26:25 +00:00
John Blackbourn 2571b6dcec Correct the logic used when determining whether to display the 'Mine' link on post list tables. It should only be shown when the count for the user's posts differs for the total count of posts. `is_multi_author()` cannot be used because it only considers Posts. 
Fixes #19609

Built from https://develop.svn.wordpress.org/trunk@34667


git-svn-id: http://core.svn.wordpress.org/trunk@34631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 19:15:24 +00:00
John Blackbourn 51667f882a Add a `nav_menu_item_title` filter for filtering nav menu item titles. 
Fixes #33447
Props paulwilde

Built from https://develop.svn.wordpress.org/trunk@34666


git-svn-id: http://core.svn.wordpress.org/trunk@34630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 18:41:26 +00:00
John Blackbourn 8d362918a8 Add a missing `@param` doc for `confirm_another_blog_signup()`. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@34665


git-svn-id: http://core.svn.wordpress.org/trunk@34629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 17:58:26 +00:00