Commit Graph

63 Commits

Author SHA1 Message Date
Scott Taylor 8879565c0a In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat.
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33958


git-svn-id: http://core.svn.wordpress.org/trunk@33927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 01:13:24 +00:00
Scott Taylor e73ee5ac98 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Scott Taylor a0e373ef80 For doc block types, favor `bool` over the few remaining `boolean`s
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
Scott Taylor d2a00338f6 Don't loosely compare functions that return `bool` against a literal `bool`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32730


git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
Scott Taylor b3e0cfd25d Add (more) missing doc blocks to `wp-admin/includes/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
John Blackbourn bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Scott Taylor be08f576df Improve some `post_status`-related documentation.
Props ericlewis.
See #30230.

Built from https://develop.svn.wordpress.org/trunk@30155


git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:20:23 +00:00
Andrew Nacin e32fc4df46 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter.
props cfinke.
fixes #28745.

Built from https://develop.svn.wordpress.org/trunk@29573


git-svn-id: http://core.svn.wordpress.org/trunk@29347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-22 01:48:17 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
John Blackbourn eb62aecbc3 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt.
Built from https://develop.svn.wordpress.org/trunk@28731


git-svn-id: http://core.svn.wordpress.org/trunk@28545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 19:15:13 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Drew Jaynes 0715a1d551 Inline documentation for hooks in wp-admin/includes/export.php.
Props cmmarslender, kpdesign.
Fixes #26894.

Built from https://develop.svn.wordpress.org/trunk@27048


git-svn-id: http://core.svn.wordpress.org/trunk@26922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:10:12 +00:00
Scott Taylor ba3f75b3c3 Pass `$args` to the `export_wp` action in `export_wp()`, which is currently passed no arguments.
Props nickdaugherty.
Fixes #25574.


Built from https://develop.svn.wordpress.org/trunk@26011


git-svn-id: http://core.svn.wordpress.org/trunk@25942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 01:27:08 +00:00
Andrew Nacin 5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Scott Taylor d39c01d30e Consistently wrap `author` and `excerpt` nodes with `CDATA` in feeds.
Fixes #18056.


Built from https://develop.svn.wordpress.org/trunk@25315


git-svn-id: http://core.svn.wordpress.org/trunk@25277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 16:55:09 +00:00
Sergey Biryukov 0bb47182a4 Remove redundant esc_url() call. props pauldewouters. fixes #23643.
git-svn-id: http://core.svn.wordpress.org/trunk@23553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:27:03 +00:00
Peter Westwood 8b9ab93511 Export: Ignore auto-drafts when building the list of users for the export file. Fixes #21960.
git-svn-id: http://core.svn.wordpress.org/trunk@21946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 21:48:52 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
duck_ 4d600fe454 Bump WXR_VERSION because of r19858 which affects the regex based importer. See #15203.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 21:51:14 +00:00
duck_ 6f343f700f Export valid XML by escaping the closing CDATA sequence "]]>". Props ceefour. See #15203.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 21:48:45 +00:00
nacin bdd70470e2 Use the site's locale for the feed language. Provides the same result as language_attributes(). Removes the rss_language option. fixes #13440. see #5517.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-29 19:56:33 +00:00
nacin 89c5a967d6 Add wxr_export_skip_postmeta filter for skipping postmeta in exports. props westi, fixes #18280.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-09 19:32:44 +00:00
nacin fad60afa23 Code readability improvements. props niallkennedy, fixes #17166, #17182, #17231, #16474.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 22:30:05 +00:00
ryan a5361b3b24 Export commentmeta. Props duck_. see #12871
git-svn-id: http://svn.automattic.com/wordpress/trunk@17700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-25 19:25:45 +00:00
markjaquith 3dabc4a39e Skip authors that no longer exist when doing an export. props nacin. fixes #16479
git-svn-id: http://svn.automattic.com/wordpress/trunk@17415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-07 19:58:41 +00:00
ryan 1fe263e46c Use term_taxonomy_id instead of term_id. Props duck_, nootron. fixes #15941
git-svn-id: http://svn.automattic.com/wordpress/trunk@17108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-22 17:38:22 +00:00
nacin 9722f6a8cb Export filtering JS and minor tweaks. props duck_, see #15197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-05 11:21:08 +00:00
ryan ce490df051 Export filtering. Props duck_. fixes #15197
git-svn-id: http://svn.automattic.com/wordpress/trunk@16652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 17:21:58 +00:00
nacin ee1ba7f2f3 Importer and exporter overhaul, mega props duck.
Exporter overhaul:
 * Add author information to export
 * Greater usage of slug identifiers
 * Don't export auto-drafts, spam comments, or edit lock/last meta keys
 * Inline documentation improvements
 * Remove filtering for now (@todo)
 * Bump WXR version to 1.1, but remain back compat in the importer

Importer overhaul (http://plugins.trac.wordpress.org/changeset/304249):
 * Use an XML parser where available (SimpleXML, XML Parser)
 * Proper import support for navigation menus
 * Many bug fixes, specifically improvements to category and custom taxonomy handling
 * Better author/user mapping

Fixes #5447 #5460 #7400 #7973 #8471 #9237 #10319 #11118 #11144 #11354 #11574 #12685 #13364 #13394 #13453 #13454 #13627 #14306 #14442 #14524 #14750 #15055 #15091 #15108.

See #15197.


git-svn-id: http://svn.automattic.com/wordpress/trunk@15961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 20:43:52 +00:00
nacin 23c773df72 Use correct variable in export. fixes #14213 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-06 20:24:38 +00:00
westi b54183ae4c Escape the guid urls when placing them in feeds and other xml locations. See #13555.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 17:01:21 +00:00
ryan 1a552dd029 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 02:42:15 +00:00
wpmuguru f77a0f2bfd more use get_blogaddress_by_name, see #12735
git-svn-id: http://svn.automattic.com/wordpress/trunk@14705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 23:00:48 +00:00
wpmuguru cea6004286 export improvements, props blepoxp, see #10317
git-svn-id: http://svn.automattic.com/wordpress/trunk@14444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 17:31:36 +00:00
ryan e25a65b36a Trim trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@13733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-17 16:27:25 +00:00
wpmuguru c4f0134808 add features to export, see #10317
git-svn-id: http://svn.automattic.com/wordpress/trunk@13573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 16:45:40 +00:00
ryan 51066760c6 Export post <-> term relationships for all taxonomies. fixes #12180
git-svn-id: http://svn.automattic.com/wordpress/trunk@13055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-11 19:17:00 +00:00
westi f05ee1844f Switch to passing arrays instead of query strings to functions. Fixes #6647 props filosofo and hakre.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-08 08:34:39 +00:00
ryan cedfa0181b Use array calling style. Props Denis-de-Bernardy. see #6647
git-svn-id: http://svn.automattic.com/wordpress/trunk@12515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-23 15:31:02 +00:00
westi 10a5ba6622 Wrap the content of <wp:meta_value></wp:meta_value> in CDATA for WXR exports. Fixes #9633 props hakre.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-23 13:03:34 +00:00
markjaquith 8f2d7720db Use esc_url_raw() on wp:comment_author_url in exports. fixes #9524
git-svn-id: http://svn.automattic.com/wordpress/trunk@12359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 08:42:45 +00:00
ryan 3fc2cea52e Export and import custom taxonomies. Props chrisscott. fixes #10012
git-svn-id: http://svn.automattic.com/wordpress/trunk@12109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-26 13:57:55 +00:00
westi 5188723e01 Fix some login typos. Fixes #11031 props filosofo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-25 09:28:20 +00:00
ryan 8e3808bce2 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-14 14:03:32 +00:00
westi d74205ae0a Add support for sticky posts to the WXR exporter and importer. Fixes #10462 props josephscott.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-04 21:46:42 +00:00
markjaquith 119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 15:11:07 +00:00