Sergey Biryukov
519f479887
Media: Fix JSHint error after [42595].
...
Merges [42599] to the 4.9 branch.
See #42646 .
Built from https://develop.svn.wordpress.org/branches/4.9@42600
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:53:38 +00:00
Aaron Jorbin
f0fd88a7f5
Query: Fix warning on counting non countable
...
Merges [42581], [42585], and [42594] to the 4.9 branch.
Adds tests to continue the behavior for both null and strings. Skip the tests on PHP 5.2 as they require ReflectionMethod.
See https://wiki.php.net/rfc/counting_non_countables for information on the PHP change.
Fixes #42860 .
Props dd32 for test skipping and janak007 and ayeshrajans for initial patches.
Built from https://develop.svn.wordpress.org/branches/4.9@42597
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:44:42 +00:00
Sergey Biryukov
4224f6e214
Media: Store and reuse image cropper ratio settings if available, instead of overwriting.
...
Props adamsilverstein.
Merges [42595] to the 4.9 branch.
Fixes #42646 .
Built from https://develop.svn.wordpress.org/branches/4.9@42596
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:41:41 +00:00
Sergey Biryukov
f29bf78748
Tests: Update emoji base URL in `Tests_Formatting_Emoji` after [42590].
...
Merges [42592] to the 4.9 branch.
See #42862 .
Built from https://develop.svn.wordpress.org/branches/4.9@42593
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 17:31:38 +00:00
Sergey Biryukov
4d2fabc973
Emoji: Update emoji base URL in `_print_emoji_detection_script()` and `wp_staticize_emoji()`.
...
Merges [42590] to the 4.9 branch.
Props pento.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/branches/4.9@42591
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 16:54:38 +00:00
Gary Pendergast
3cc1a69391
Canonical URLs: Redirect to the correct URL when the post date changes.
...
When a post slug is changed, we store a copy of the old slug, so that we can redirect visitors visiting the old URL to the new URL.
In the same way, this stores a copy of the old date, when the post date changes, so we can redirect visitors to the new URL.
Merge of [42401,42587,42588] to the 4.9 branch.
Props nickmomrik, frank-klein.
Fixes #15397 .
Built from https://develop.svn.wordpress.org/branches/4.9@42589
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 07:12:39 +00:00
Dion Hulse
366e0ada72
Updates: Only trigger Background Update processes from within the core update check when a core autoupdate is on offer.
...
This change reduces the number of API calls which WordPress makes to api.wordpress.org during release windows.
Previously the background updates would run upon every core update transient refresh, however now they'll only run if there's an update available.
The change also increases the cache period for plugin & theme checks when running via the cron, from never-cache to 2 hours, which should hopefully reduce the number of needless API calls.
Merges [42584] to the 4.9 branch.
Fixes #43103 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42586
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 04:32:41 +00:00
Sergey Biryukov
723d0f2669
Media: Introduce a custom error handler for MediaElement.js to display a download link if a FLV file cannot be rendered for any reason.
...
Props Clorith.
Merges [42582] to the 4.9 branch.
Fixes #42643 .
Built from https://develop.svn.wordpress.org/branches/4.9@42583
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 01:53:38 +00:00
Sergey Biryukov
5220bad266
Emoji: Update emoji regex for Twemoji to 2.4.0.
...
Build `src/wp-includes/formatting.php` following [42566].
Props peterwilsoncc.
Merges [42579] to the 4.9 branch.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/branches/4.9@42580
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 01:15:41 +00:00
Aaron Jorbin
4aee92bb1c
REST API: Add existing term_id to the error data object when attempting to create a duplicate term.
...
Merges [42350] into 4.9
Props shooper, coleh, rachelbaker.
Fixes #42597 . See #41370 .
Built from https://develop.svn.wordpress.org/branches/4.9@42578
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 20:22:39 +00:00
Andrew Ozz
bbb8a324c7
Merged revision(s) 42576 from trunk:
...
TinyMCE: backport bug fixes to `NotificationManager` and `WindowManager` from d1877933fa (diff-2e5c98d81ce2481aa1042b2320728b65)
and to `MultiRange` from 250675bb7b
.
Props peterwilsoncc, azaozz.
Fixes #42722 for 4.9.3, see #43012 .
Built from https://develop.svn.wordpress.org/branches/4.9@42577
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 19:41:42 +00:00
Andrew Ozz
bd00d61353
Merged revision 42574 from trunk:
...
Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup.
Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for 4.9.3.
Built from https://develop.svn.wordpress.org/branches/4.9@42575
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 17:48:41 +00:00
Sergey Biryukov
124bdbb0cd
Media: Restore white background of the content area in media modal.
...
Props afercia, chetan200891.
Merges [42572] to the 4.9 branch.
Fixes #43088 .
Built from https://develop.svn.wordpress.org/branches/4.9@42573
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 14:03:42 +00:00
Sergey Biryukov
8662725a4b
Email: Don't send notifications for site or network admin email address change to the default 'admin_email' value.
...
Props tigertech, MattyRob, seanchayes.
Merges [42570] to the 4.9 branch.
Fixes #42693 .
Built from https://develop.svn.wordpress.org/branches/4.9@42571
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 13:47:40 +00:00
Sergey Biryukov
54194f2ec6
Customize: Correct "Add Items" button reference in help text shown after creating a new menu.
...
Props dlh, munyagu, rishishah.
Merges [42568] to the 4.9 branch.
Fixes #42565 .
Built from https://develop.svn.wordpress.org/branches/4.9@42569
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 12:05:40 +00:00
Sergey Biryukov
83dc4c9339
Emoji: Update Twemoji to 2.4.0.
...
WordPress was already on 2.5.0, but Twemoji decided to break their versioning, so 2.4.0 is actually the latest release.
Merges [42566] to the 4.9 branch.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/branches/4.9@42567
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 11:51:41 +00:00
Sergey Biryukov
dd777e0e14
TinyMCE: on the toolbar drop-downs apply overflow style on the actual element with text.
...
Props abdullahramzan, azaozz.
Merges [42446] to the 4.9 branch.
Fixes #43090 .
Built from https://develop.svn.wordpress.org/branches/4.9@42552
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 08:31:40 +00:00
Sergey Biryukov
98764508db
Editor: change the test in `user_can_richedit()` to also detect when IE11 is in compatibility mode.
...
Props ndavison, azaozz.
Merges [42529] to the 4.9 branch.
Fixes #42503 .
Built from https://develop.svn.wordpress.org/branches/4.9@42551
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 08:18:41 +00:00
Dion Hulse
906bc34226
WPDB: Use a PCRE syntax which supports PCRE compiled between 2003 and 2006.
...
This fixes a PHP Warning in `wpdb::parse_db_host()` when WordPress is used with (sometimes a modern) PHP that's compiled against an ancient PCRE version.
Merges [42549] to the 4.9 branch.
Fixes #43109 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42550
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 03:40:42 +00:00
Aaron Jorbin
c4277abb33
Remove JSHint due to license compatibility
...
Backports [42547] without adding new files due to how minor updates work.
JSHint inherits a license from JSLint that includes the clause "The Software shall be used for Good, not Evil." WordPress's license specifically allows grants the freedom to run the program, for any purpose. Please note, this is not an encouragement of evil. Rather than doing something evil, how about learning to love those around you. Instead of tweeting lies and saying people are "Not Good!", help your neighbor. In the words of Lin Manual Miranda, "Love is love is love is love is love is love is love is love, cannot be killed or swept aside."
This replaces JSHint with esprima, a part of the larger jQuery project, and a custom wrapper for some basic error checking within codemirror.
The existing JSHint configuration is kept in place in case someone wants to use that, but they can only do so for Good.
Fixes #42850
Props netweb for a spelling fix on a comment.
Built from https://develop.svn.wordpress.org/branches/4.9@42548
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 03:38:41 +00:00
Weston Ruter
6ba9d07723
Widgets: Ensure media is explicitly enqueued from Text widget in case Media widgets are unregistered.
...
Amends [41344].
See #40854 .
Fixes #43125 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42546
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 19:28:42 +00:00
Weston Ruter
db02fcb8f8
Customize: Let default status for Customizer be `draft` if user does not have capability to `publish`.
...
Amends [41626].
Props sayedwp, westonruter.
See #30937 .
Fixes #42686 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42544
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 19:12:43 +00:00
Weston Ruter
385f70dc96
Customize: Prevent frontend previewing from causing a customization lock on the changeset.
...
Props dlh.
Amends [41839].
See #42024 .
Fixes #42975 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42542
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:51:40 +00:00
Weston Ruter
54d1631126
Customize: Use changeset-specific "locked" messages when branching is enabled.
...
Props dlh.
See #39896 .
Fixes #42655 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42539
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:32:41 +00:00
Weston Ruter
3ed6b9efd4
Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes.
...
Props flixos90.
See #37661 , #42184 .
Fixes #42674 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42537
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:16:41 +00:00
Weston Ruter
2441c3c3f1
Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.
...
Amends [38810].
Props dlh.
Fixes #42497 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42535
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 05:23:40 +00:00
Weston Ruter
2e8c881ff4
Widgets: Allow relative/partial URLs in Image Widget's link field.
...
Props audrasjb.
Amends [41252].
See #41274 .
Fixes #42740 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42534
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 04:53:43 +00:00
Weston Ruter
0685e3e2f3
Code Editor: Disable `attr-value-double-quotes` HTMLHint rule since too strict for user input.
...
Using single-quoted attribute values is not in any way invalid HTML.
Amends [41376].
Props sasiddiqui.
See #12423 .
Fixes #42802 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42532
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-21 08:04:43 +00:00
Sergey Biryukov
d9bf3e5e60
Plugins: Update review filter links in Details modal.
...
Props darko-a7, afercia.
Merges [42459] to the 4.9 branch.
Fixes #43016 . See #meta3379.
Built from https://develop.svn.wordpress.org/branches/4.9@42524
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 07:02:41 +00:00
Weston Ruter
4c4d1ecbe5
Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar.
...
Amends [41352].
See #23120 .
Fixes #43003 for 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42522
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 01:31:41 +00:00
Aaron Campbell
be9734cbee
Post 4.9.2 version bump for 4.9 branch
...
Built from https://develop.svn.wordpress.org/branches/4.9@42520
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 23:59:40 +00:00
Dion Hulse
4abf1b12c9
Bump the 4.9 branch to version 4.9.2.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42494
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 21:37:40 +00:00
Dion Hulse
e77f8257ea
External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
...
Props joemcgill.
Merges [42462] to the 4.9 branch.
Fixes #42720 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42465
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:41:51 +00:00
Sergey Biryukov
b6d9609fa9
WPDB: Always use `mysqli` when available.
...
This change makes WordPress use `mysqli` on PHP <5.5 when available, instead of only in PHP 5.5+ and development installs.
WPDB includes a fallback to `mysql` in the event that the database connection fails with `mysqli` so incompatibilities should be few and far between.
Props dd32.
Merges [42388] to the 4.9 branch.
Fixes #42812 .
Built from https://develop.svn.wordpress.org/branches/4.9@42455
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:50:39 +00:00
Sergey Biryukov
84bd75ea88
Media: Add `flac` to the list of allowed file types.
...
Props blobfolio.
Merges [42451] to the 4.9 branch.
Fixes #42225 .
Built from https://develop.svn.wordpress.org/branches/4.9@42452
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:24:41 +00:00
Sergey Biryukov
9026b41b3b
Media: Bring consistency to `getimagesize()` error suppression.
...
Props chasewg, joemcgill, jeremyfelt.
Merges [42449] to the 4.9 branch.
Fixes #42480 .
Built from https://develop.svn.wordpress.org/branches/4.9@42450
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 20:02:39 +00:00
Sergey Biryukov
77ce550e5c
Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
...
Props chetan200891 for initial patch.
Merges [42447] to the 4.9 branch.
Fixes #42871 .
Built from https://develop.svn.wordpress.org/branches/4.9@42448
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:30:40 +00:00
Dion Hulse
3c9f3effb0
Formatting: Do not run formatting and texturization on author bios.
...
Removes the formatting and texturization added to author bios in #40040 due to back-compatibility concerns.
Reverts [41172], [41173].
Props 0x6f0, rabmalin for review, peterwilsoncc.
Merges [42441] to the 4.9 branch.
Fixes #42578 .
Built from https://develop.svn.wordpress.org/branches/4.9@42445
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 00:10:42 +00:00
Sergey Biryukov
b8ebacbf82
Editor: Link suggestions: add fallback title for posts with no title.
...
Props afercia.
Merges [42425] to the 4.9 branch.
Fixes #42664 .
Built from https://develop.svn.wordpress.org/branches/4.9@42439
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:13:38 +00:00
Rachel Baker
25bfff959f
REST API: Return the proper status code for failed permission callbacks in WP_REST_Server->dispatch().
...
Use the rest_authorization_required_code() function to return a 401 status code when a permission callback fails due to a user not being logged in.
Merges [42421] to the 4.9 branch.
Props jaswrks.
Fixes #42828 .
Built from https://develop.svn.wordpress.org/branches/4.9@42422
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-30 20:49:40 +00:00
Boone Gorges
af4f4f860e
Taxonomy: Restore deprecated argument to `term_description()` signature.
...
This ensures that the parameter can't be reused for something else
in the future.
Merges [42417] to the 4.9 branch.
Props jorbin.
Fixes #42605 .
Built from https://develop.svn.wordpress.org/branches/4.9@42418
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 02:50:39 +00:00
Weston Ruter
160e61fddf
Editor: Fix determining TinyMCE editor width when in inline mode instead of iframe mode.
...
See #40854 .
Amends [41985].
Props aduth.
Fixes #42416 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42391
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-13 05:19:40 +00:00
Konstantin Obenland
0a429ab309
Widgets: Always try restoring widget assignments
...
For code-historic reasons, restoring widget assignments would not be attempted if there were no sidebars to map.
Restoring previous assignments is something unrelated to sidebar mappings however, so now it will be attempted on every theme switch.
Fixes #42719 .
Merges [42374] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42375
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-07 02:23:45 +00:00
Boone Gorges
030f429e78
`category_description()` should be taxonomy-agnostic.
...
This change reinstates the previous de facto behavior of `category_description()`.
See [40979], [42364]. Because `term_description()` no longer passes `$taxonomy` to
`get_term_field()`, the parameter is no longer needed and has been deprecated.
Merges [42368] to the 4.9 branch.
Fixes #42605 . See #42771 .
Built from https://develop.svn.wordpress.org/branches/4.9@42372
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 22:04:42 +00:00
Boone Gorges
c637f0c94f
`get_the_category_by_ID()` should be taxonomy-agnostic.
...
Prior to 4.9, this function was accidentally taxonomy-agnostic in most cases.
The fix in [40979] caused a regression in this function. For backward
compatibility, we make it explicit that the query is by ID only.
Merges [42367] to the 4.9 branch.
See #42771 .
Built from https://develop.svn.wordpress.org/branches/4.9@42371
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 22:00:41 +00:00
Boone Gorges
aedaea9209
Fix regression in `get_tag_link()` since 4.9.
...
See [42364] for description of the problem.
Because `get_category_link()` is now totally taxonomy-agnostic, `get_tag_link()`
can become a simple wrapper.
Merges [42366] to the 4.9 branch.
Props juiiee8487, markjaquith.
See #42771 .
Built from https://develop.svn.wordpress.org/branches/4.9@42370
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 21:58:42 +00:00
Boone Gorges
edb61cba2e
Don't do a strict taxonomy check in `get_category_link()`.
...
Prior to version 4.9, a quirk in the implementation of `get_term()` caused
`get_category_link( 123 )` to fetch the taxonomy archive link for term 123
even if 123 is not in the 'category' taxonomy. The quirk was fixed in [40979];
see #40671 . This bugfix introduced a regression for theme authors who were
expecting the old behavior.
By lifting the 'category' restriction, we allow the template function to work
in the old way.
Merges [42364], [42365] to the 4.9 branch.
Fixes #42717 . See #42771 .
Built from https://develop.svn.wordpress.org/branches/4.9@42369
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 21:55:40 +00:00
Konstantin Obenland
2afecbb253
Widgets: Don't try mapping empty sidebars.
...
Fixes a bug where the mapping logic would try mapping empty sidebars, resulting in PHP warnings.
Props ionvv, chetan200891 for initial patch.
See #42603 .
Merges [42362] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42363
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-04 20:17:42 +00:00
Dion Hulse
1fdfabf74c
Avoid PHP Linting errors in the Random_Compat library under PHP7.
...
The latest updates to the library are larger than preferred, so instead this modifies the library to lint properly.
Fixes #42439 for 4.9
Built from https://develop.svn.wordpress.org/branches/4.9@42344
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-01 03:07:42 +00:00
John Blackbourn
c4a15959f5
Bump 4.9 branch to version 4.9.1.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42316
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 18:55:42 +00:00
John Blackbourn
b4a3edc859
Hardening: Remove the ability to upload JavaScript files for users who do not have the `unfiltered_html` capability.
...
Merges [42261] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42267
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 16:12:18 +00:00
John Blackbourn
e75247a179
Hardening: Ensure the attributes of enclosures are correctly escaped in RSS and Atom feeds.
...
Merges [42260] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42266
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 16:11:38 +00:00
John Blackbourn
45874b5050
Hardening: Add escaping to the language attributes used on `html` elements.
...
Merges [42259] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42265
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 16:10:41 +00:00
John Blackbourn
ecd15e008a
Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring.
...
Merges [42258] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42264
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-29 16:08:41 +00:00
John Blackbourn
594456341d
Post WordPress 4.9.1 Beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42254
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 18:12:38 +00:00
John Blackbourn
ec63674dfc
WordPress 4.9.1 Beta 1.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42253
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 18:01:39 +00:00
John Blackbourn
4ae2ee9869
Media: Further improvements to the handling of language codes that get passed to MediaElement.
...
This change means that only the leading portion of a locale code gets passed to MediaElement, removing problems that arise from locales such as `de_DE_formal` and `pt_PT_ao90`.
Props erich_k4wp, blobfolio, flixos90, ocean90, joemcgill, SergeyBiryukov.
Fixes #42574
Merges [42251] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42252
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-28 14:54:42 +00:00
Dion Hulse
0236fd226e
Theme Editor: Translate the URL to the Child Themes Codex page.
...
Props odysseygate, johnpgreen.
Merges [42247] to the 4.9 branch.
Fixes #42454 .
Built from https://develop.svn.wordpress.org/branches/4.9@42248
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:53:40 +00:00
Dion Hulse
9fe3e9edf0
Theme Editor: Validate files are editable based on their relative filenames, rather than full file path.
...
This fixes theme editing on Windows platforms where `validate_file()` will return `2` on a full file path.
Merges [42244] to the 4.9 branch.
Fixes #42609 .
Built from https://develop.svn.wordpress.org/branches/4.9@42245
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:29:25 +00:00
Dion Hulse
e1095eeb9f
Theme/Plugin Editor: Remove the caching added in [41806] as it causes more problems than it fixes.
...
While caching here seemed like a good idea in theory, in practice the cache would be often stale causing development issues.
We exclude common folders (such as `node_modules`) from the scanning to avoid directories which are not useful to the end-user, so as long as those exclusion lists are held up this shouldn't cause too much of a degredation in the future.
We may consider adding caching here again in the future if it's determined that it is really needed.
Props precies, ibenic, mariovalney, schlessera, and all the others who commented on the ticket(s).
This partually reverts [41806].
Merges [42242] to the 4.9 branch.
See #6531 .
Fixes #42573 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42243
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 03:00:38 +00:00
Dion Hulse
68cb5b6f05
WPDB: Fix the parsing of sockets which contain colons within the socket name (used on some cloud providers).
...
Props natacado.
Merges [42226] to the 4.9 branch.
Fixes #42634 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42229
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-27 00:56:41 +00:00
Dion Hulse
6dc1dd28f5
Themes: Prevent JS error on Themes admin screen when only one theme is installed.
...
Amends [42029].
Props chetan200891, afercia.
See #42348 , westonruter.
Merges [42222] to the 4.9 branch.
Fixes #42673 .
Built from https://develop.svn.wordpress.org/branches/4.9@42223
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-24 02:56:42 +00:00
John Blackbourn
4cb8d10856
Users: Correct the value of the `lang` attribute in the admin area.
...
This corrects the value when the user's language is set to `English (United States)` but the site language is not.
Props ocean90, afercia
Fixes #42242
Merges [42220] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42221
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 19:06:42 +00:00
John Blackbourn
97ba6be232
Docs: Correct the `@since` property for the `page_attributes_misc_attributes` action.
...
Props jeremyescott, jfarthing84
Fixes #42607
Merges [42203] to the 4.9 branch.
Built from https://develop.svn.wordpress.org/branches/4.9@42219
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 18:03:43 +00:00
Dion Hulse
cee7720939
Upgrade: Fix updating plugins which include a numeric file/folder names.
...
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).
Props edo888.
See #41524 .
Merges [42214] to the 4.9 branch.
Fixes #42628 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42215
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 04:16:41 +00:00
Dion Hulse
b09cebf575
Rewrite Rules: Correct the logic in `extract_from_markers()` after [41928].
...
Props stodorovic, SergeyBiryukov.
Merges [42199] to the 4.9 branch.
Fixes #42579 . See #39920 .
Built from https://develop.svn.wordpress.org/branches/4.9@42213
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 03:47:38 +00:00
Dion Hulse
66a3d52431
Multisite: Fix broken update `blog_versions` query after [41661].
...
Props Mista-Flo, lenasterg, flixos90.
Merges [42210] to the 4.9 branch.
Fixes #42641 .
Built from https://develop.svn.wordpress.org/branches/4.9@42212
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-21 03:43:40 +00:00
Weston Ruter
85d9b63062
Bump package.json version to 4.9.1
...
Built from https://develop.svn.wordpress.org/branches/4.9@42197
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-16 01:16:37 +00:00
Weston Ruter
75ab7d2124
Bump version WordPress 4.9.1 alpha
...
Built from https://develop.svn.wordpress.org/branches/4.9@42196
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-16 01:02:39 +00:00
Weston Ruter
553d6fdbe0
Bump version for WordPress 4.9
...
Built from https://develop.svn.wordpress.org/branches/4.9@42195
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-16 00:12:39 +00:00
Weston Ruter
35b40d1001
Editor: Re-build `tinymce.min.js` after [42191].
...
See #42553 .
Built from https://develop.svn.wordpress.org/branches/4.9@42194
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 23:36:39 +00:00
Weston Ruter
a5f8e0917f
Editor: Disable `wp_keep_scroll_position` in IE11 since buggy; fix `matches` polyfill conflict with ME.js by doing runtime feature detection in context window.
...
Props westonruter, SergeyBiryukov, Clorith for testing.
See #41962 , #42029 .
Fixes #42553 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42192
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 19:00:38 +00:00
Weston Ruter
73615e0bc4
File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes.
...
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423 .
Fixes #42554 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42190
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:31:37 +00:00
Weston Ruter
567de560e9
Customize: Prevent themes panel from auto-expanding in IE11.
...
In IE11 the `input` event erroneously gets triggered initially without any user input.
Amends [41648].
See #37661 .
Fixes #42556 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42188
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:13:40 +00:00
Weston Ruter
ff85340727
Widgets: Set global `$post` to current queried object instead of nullifying when `is_singular()` while applying filters (and shortcodes) in Text widget and (via plugin) Custom HTML widget.
...
Also prevent `[gallery]` shortcode from dumping out every attachment on the site when a containing Text widget is shown on an archive template.
Props westonruter, bobbingwide, joemcgill for testing.
See #10457 .
Fixes #42548 , #42547 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42186
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 02:33:44 +00:00
Weston Ruter
ecf8680978
Editor: Improve scrolling behavior and prevent autosave logic from causing dirty state when just switching between Visual and Text tabs.
...
Props pento.
See #41962 , #42029 .
Fixes #42530 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42184
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 00:22:42 +00:00
Weston Ruter
36282a2a9c
About Page: Fix issue with overlapping images and text on IE11 and Edge 15.
...
Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42087 .
Fixes #42545 for 4.9
Built from https://develop.svn.wordpress.org/branches/4.9@42182
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 23:04:40 +00:00
Weston Ruter
44eb69904d
Post WordPress 4.9 RC3 bump.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42180
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 06:51:41 +00:00
Weston Ruter
ce6b628972
WordPress 4.9 RC3.
...
Built from https://develop.svn.wordpress.org/branches/4.9@42179
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 06:08:40 +00:00
Weston Ruter
0110751ddc
Editor: Cease adding paragraphs when switching editor tabs.
...
Fixes an error since [41783] in which extra paragraphs could be added to content when switching editor tabs.
Props pento, adamsilverstein, aduth.
Fixes #42531 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42178
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:28:41 +00:00
Gary Pendergast
5e736b62e0
Editor: When switching Editor tabs, don't scroll unnecessarily.
...
- When switching to the Text view, wait until after the Visual editor element has been hidden, before focussing the `<textarea>`.
- When switching to the Visual view, only scroll if the cursor is not visible on the current screen.
Merge of 52175 to the 4.9 branch.
Fixes #42530 .
Built from https://develop.svn.wordpress.org/branches/4.9@42176
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 05:21:39 +00:00
Weston Ruter
eb18399c10
About: Fix jumping behavior for titles and columns when scrolling.
...
Props ryelle.
See #42087 .
Fixes #42514 , #42526 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42174
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:48:36 +00:00
Weston Ruter
c268b2f28c
Customize: Allow notifications for linting errors in code editor control (for Additional CSS) to be overridden to allow saving.
...
Implements the same override that was implemented in [41721] for the theme/plugin editors.
See #41897 , #41887 .
Fixes #42528 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42172
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:47:12 +00:00
Weston Ruter
15b14c30c1
Customize: Prevent PHP notice on theme-switch dashboard welcome link (and link to themes admin screen) when user cannot `customize`.
...
Props skostadinov, ocean90.
Amends [41699].
See #42050 .
Fixes #42525 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42170
git-svn-id: http://core.svn.wordpress.org/branches/4.9@42000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:45:47 +00:00
Dominik Schilling
0d7f326477
Build: Add `npm-shrinkwrap.json`.
...
For compatibility with the build server `fsevent` has been manually removed.
Props netweb.
See #42483 .
Built from https://develop.svn.wordpress.org/branches/4.9@42168
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:44:24 +00:00
Dominik Schilling
062ab0b0c8
Revert [42166].
...
Due to running `npm install` an updated `npm-shrinkwrap.json` file was committed.
See #42483 .
Built from https://develop.svn.wordpress.org/branches/4.9@42167
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:43:42 +00:00
Weston Ruter
46c75fbaf7
I18N: Fix passing singular/plural strings to JS.
...
This is a temporary solution while waiting for full I18N support in JS.
Props ocean90, dd32, westonruter, Mirucon for testing.
Amends [41376], [41721], [41389].
See #20491 .
Fixes #42510 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42164
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 07:09:35 +00:00
Weston Ruter
11e007c502
About: Add vertical alignment for developer happiness sections.
...
Also run CSS autoprefixer to add `-ms-` prefixes for CSS grid identifiers for IE11.
Props Presskopp.
Amends [42121].
See #42087 .
Fixes #42524 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42162
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:49:36 +00:00
Weston Ruter
b0c557fbb2
About: Fix grammar typo with pluralization.
...
Props metodiew, westonruter.
Amends [42121].
See #42087 .
Fixes #42476 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42160
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:20:36 +00:00
Weston Ruter
277261edeb
About: Synchronize 4.9 tagline across about pages for credits, freedoms, and privacy.
...
Props dave.pullig.
Amends [41943].
See #42087 .
Fixes #42518 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42158
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-12 20:00:37 +00:00
Weston Ruter
1b39843b11
Theme Editor: Fix styling of child theme notice.
...
Props westonruter, melchoyce, ndiego.
See #24048 .
Fixes #42491 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42156
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-11 20:44:38 +00:00
Weston Ruter
6cc5d01d17
Customize: Restore ability to add Custom Link nav menu items for jump links and other URLs that were previously allowed.
...
Simplify regular expression for checking URL validity to just do basic checks to confirm the value looks like a URL. Leave the complete validation to the server-side logic in `WP_Customize_Nav_Menu_Item_Setting::sanitize()` to avoid having to maintain two separate codebases for validating URLs.
Props westonruter, SergeyBiryukov for testing.
Amends [41697].
See #32816 .
Fixes #42506 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42154
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:43:39 +00:00
Weston Ruter
523fcaca2e
Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).
...
Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721 , #34923 , #42220 .
Fixes #42489 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42149
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:45:38 +00:00
Weston Ruter
a647fbead2
Settings: Replace `count()` call with `empty()` in `get_settings_errors()` to prevent PHP 7.2 warnings when `$wp_settings_errors` is `null`.
...
Props pross, dd32, westonruter.
See #40109 .
Fixes #42498 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42147
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:32:47 +00:00
Weston Ruter
389166f9aa
Customize: Ensure autosave revision is dismissed immediately after implicit restoration notice dismissal as done with explicit notice dismissal.
...
Fixes issue where a drafted/scheduled changeset could inadvertently re-use the previous autosave revision in the preview while a user expects it to have been dismissed.
See #39896 , [41597].
Fixes #42502 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42145
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 21:45:38 +00:00
Weston Ruter
af74789be0
Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied.
...
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.
Amends [41252].
See #41274 .
Fixes #42488 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42141
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 01:29:40 +00:00
Weston Ruter
ca12fb6710
Customize: Fix reliability of just-in-time publishing for changesets that miss their schedule when visiting `customize.php`.
...
When just doing `wp_publish_post()` for the changeset from `customize.php`, any option-based settings will fail to get saved because `WP_Customize_Manager` would have already been loaded with `settings_previewed`, resulting in `update_option()` calls being short-circuited. So an admin-ajax request to `customize_save` is used to work around this.
Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for testing.
Amends [41626].
See #28721 , #39221 .
Fixes #42457 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42139
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:45:38 +00:00
Weston Ruter
707a3196f7
Customize: Ensure `autosaving` message gets sent to preview after initial change when `saved` state is first dirty.
...
Amends [41667].
Fixes #42475 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42137
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:21:40 +00:00
Weston Ruter
e6a91f7ccf
Settings: Fix date/time format previewing.
...
Props afercia.
Amends [41857].
Fixes #41603 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42135
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 03:57:36 +00:00
Weston Ruter
bbef4fd178
Customize: Restore search icon to available widgets pane incorrectly removed in [41893].
...
See #42215 .
Fixes #42472 for 4.9.
Built from https://develop.svn.wordpress.org/branches/4.9@42133
git-svn-id: http://core.svn.wordpress.org/branches/4.9@41964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 01:06:34 +00:00
Weston Ruter
59fdb7a220
Post WordPress 4.9 RC2 bump.
...
Built from https://develop.svn.wordpress.org/trunk@42125
git-svn-id: http://core.svn.wordpress.org/trunk@41956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 05:26:47 +00:00
Weston Ruter
f76b491135
WordPress 4.9 RC2.
...
Built from https://develop.svn.wordpress.org/trunk@42124
git-svn-id: http://core.svn.wordpress.org/trunk@41955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:54:47 +00:00
Konstantin Obenland
4eda9c7388
About: Hardcoded image sources.
...
We're committed to these images now.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42123
git-svn-id: http://core.svn.wordpress.org/trunk@41954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:26:48 +00:00
Weston Ruter
e4fe01e2b4
Customize: Fix logic inversion in [42113] which prevented themes from being installed in Customizer.
...
Also fix PHP notice related to parent themes and WordPress.org theme query results.
Props dd32, obenland, celloexpressions, westonruter, atachibana for testing.
See #42406 , #37661 .
Fixes #42442 .
Built from https://develop.svn.wordpress.org/trunk@42122
git-svn-id: http://core.svn.wordpress.org/trunk@41953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:17:47 +00:00
Mel Choyce
2382232692
About Page: Implement design.
...
Props ryelle, karmatosed, transl8or, obenland, melchoyce.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42121
git-svn-id: http://core.svn.wordpress.org/trunk@41952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:11:47 +00:00
Gary Pendergast
8255d04abb
WPDB: Check that `AUTH_SALT` is not empty.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` defaults to `AUTH_SALT`, but `hash_hmac()` will return an empty string if the key is empty.
This had the side effect of the string `{}` being incorrectly replaced with a `%` character in queries just about to be run on the database.
Props jsonfry.
Fixes #42431 .
Built from https://develop.svn.wordpress.org/trunk@42120
git-svn-id: http://core.svn.wordpress.org/trunk@41949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 01:09:47 +00:00
Gary Pendergast
002d65112f
WPDB: Fix a PHP notice when `AUTH_SALT` is undefined.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` falls back to `rand()` when `AUTH_SALT` is undefined. `hash_hmac()` requires the key to be a string, however, so we need to cast it as such.
Props mkomar.
Fixes #42401 .
Built from https://develop.svn.wordpress.org/trunk@42119
git-svn-id: http://core.svn.wordpress.org/trunk@41948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 00:30:46 +00:00
Weston Ruter
a74afff787
Customize: Prevent `customize_autosaved=on` from getting added to frontend preview URLs.
...
Amends [41969].
See #39896 , #42450 .
Fixes #42433 .
Built from https://develop.svn.wordpress.org/trunk@42118
git-svn-id: http://core.svn.wordpress.org/trunk@41947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 23:11:53 +00:00
Weston Ruter
c15b2a0908
Customize: Fall back to ISO date format for date/time control inputs if year, month, or day are missing from the `date_format` option.
...
Amends [42111].
Props dlh, westonruter.
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42117
git-svn-id: http://core.svn.wordpress.org/trunk@41946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 20:28:48 +00:00
John Blackbourn
b8de3548d3
Administration: Ensure the new Privacy Policy screen appears when within the Network Admin and User Admin.
...
Props hnle, dd32
Fixes #42443
Built from https://develop.svn.wordpress.org/trunk@42116
git-svn-id: http://core.svn.wordpress.org/trunk@41945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 18:17:54 +00:00
Konstantin Obenland
65c1468ff5
File Editors: Account for network admin use
...
Fixes a bug where files couldn't be accessed in multisite installs.
Props flixos90, westonruter.
Fixes #42420 .
Built from https://develop.svn.wordpress.org/trunk@42115
git-svn-id: http://core.svn.wordpress.org/trunk@41944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 18:51:49 +00:00
Weston Ruter
76e01c3562
Customize: Ensure `changeset_uuid` param for autosave auto-draft gets stripped from location after previewing theme switch when not in branching mode.
...
Amends [41597].
See #39896 .
Fixes #42415 .
Built from https://develop.svn.wordpress.org/trunk@42114
git-svn-id: http://core.svn.wordpress.org/trunk@41943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 17:37:52 +00:00
Weston Ruter
d0608c5585
Customize: Make sure theme switch blocking in the Customizer is consistently applied when changeset is drafted/scheduled.
...
* Consider both `selectedChangesetStatus` and `changesetStatus` states when deciding to disable.
* Factor out common logic into `canSwitchTheme` function on `ThemesPanel`.
* Keep Live Preview and Install buttons disabled in Themes controls and detail overlays when appropriate.
Props westonruter, dlh.
Amends [41788].
See #42126 , #37661 , #39896 .
Fixes #42406 .
Built from https://develop.svn.wordpress.org/trunk@42113
git-svn-id: http://core.svn.wordpress.org/trunk@41942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 00:59:47 +00:00
Weston Ruter
83c29a4d08
Theme Editor: Ensure files listed recursively can be both viewed and edited.
...
Prevent edits to 2-level deep theme files from returning a `disallowed_theme_file` error when attempting to save an edit. Aligns logic for gathering `$allowed_files` in `theme-editor.php` for listing files with the validation logic in `wp_edit_theme_plugin_file()`.
Amends [41806].
See #6531 .
Fixes #42425 .
Built from https://develop.svn.wordpress.org/trunk@42112
git-svn-id: http://core.svn.wordpress.org/trunk@41941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:05:48 +00:00
Weston Ruter
ef272167c4
Customize: Present the date/time control input fields in the same format (and order) as `date_format`.
...
Props westonruter, obenland, atachibana for testing, Mirucon for testing.
See #42373 , #28721 .
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42111
git-svn-id: http://core.svn.wordpress.org/trunk@41940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:00:49 +00:00
Konstantin Obenland
99c19a5a82
Codemirror: Unify line endings in csslint.js
...
This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in a future release.
Fixes #42424 .
Built from https://develop.svn.wordpress.org/trunk@42110
git-svn-id: http://core.svn.wordpress.org/trunk@41939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 22:31:47 +00:00
Weston Ruter
8902ddba18
Customize: Always use underlying changeset post date as initial date in scheduled date fields if date is future.
...
Prevent user from having to re-enter the previously-supplied future date if they had switched from schedule to draft but wanted to switch back again. Improves parity with behavior of post edit screen.
Props dlh, westonruter, obenland.
See #39896 , #28721 .
Fixes #42413 .
Built from https://develop.svn.wordpress.org/trunk@42109
git-svn-id: http://core.svn.wordpress.org/trunk@41938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 20:00:48 +00:00
Weston Ruter
fbee634ac7
Customize: Prevent `history.replaceState()` and `history.pushState()` calls from causing error in customize preview before DOM ready.
...
Amends [41597].
See #39896 .
Fixes #42414 .
Built from https://develop.svn.wordpress.org/trunk@42108
git-svn-id: http://core.svn.wordpress.org/trunk@41937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:27:47 +00:00
Weston Ruter
5f16c57782
Customize: Prevent re-importing starter content when changeset is saved as draft or scheduled.
...
Themes cannot currently be switched in Customizer after changeset is saved anyway.
Props dlh, westonruter.
See #40146 , #42411 , #42126 .
Fixes #42395 .
Built from https://develop.svn.wordpress.org/trunk@42107
git-svn-id: http://core.svn.wordpress.org/trunk@41936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:00:54 +00:00
Weston Ruter
7deb33b386
Bundled Themes: Fix fragile `update-theme` phpunit test which broke after version updates in [42105].
...
See #42090 .
Built from https://develop.svn.wordpress.org/trunk@42106
git-svn-id: http://core.svn.wordpress.org/trunk@41935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 01:26:48 +00:00
David A. Kennedy
7b74056cf5
Bundled Themes: Bump version numbers and update changelogs for 4.9 release
...
* Also, updates POT files for Twenty Ten and Twenty Eleven.
Props lemacarl, maedahbatool, mrahmadawais, davidakennedy.
Fixes #42090 .
Built from https://develop.svn.wordpress.org/trunk@42105
git-svn-id: http://core.svn.wordpress.org/trunk@41934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 22:43:47 +00:00
Weston Ruter
926f2114f0
Customize: Strip zero padding when setting month to prevent de-selection; add zero-padding for `number` input fields when blurring.
...
Amends [42042].
See #42373 .
Fixes #42392 .
Built from https://develop.svn.wordpress.org/trunk@42104
git-svn-id: http://core.svn.wordpress.org/trunk@41933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 21:04:53 +00:00
Gary Pendergast
a2693fd860
Database: Restore numbered placeholders in `wpdb::prepare()`.
...
[41496] removed support for numbered placeholders in queries send through `wpdb::prepare()`, which, despite being undocumented, were quite commonly used.
This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to `wpdb::prepare()`, given the number of placeholders.
See #41925 .
Built from https://develop.svn.wordpress.org/trunk@42056
git-svn-id: http://core.svn.wordpress.org/trunk@41885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 12:00:49 +00:00
Weston Ruter
6f2db8ea69
Post WordPress 4.9 RC1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@42050
git-svn-id: http://core.svn.wordpress.org/trunk@41884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 04:32:48 +00:00
Weston Ruter
84c6d74a8c
WordPress 4.9 RC1.
...
Built from https://develop.svn.wordpress.org/trunk@42049
git-svn-id: http://core.svn.wordpress.org/trunk@41883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 03:42:49 +00:00
Weston Ruter
8a1dc558a1
Customize: Consolidate sourcing of control `params`.
...
Prevent needlessly iterating over `controlConstructor` to find `type` when it is already supplied.
Amends [41750], [41726].
See #42083 .
Built from https://develop.svn.wordpress.org/trunk@42048
git-svn-id: http://core.svn.wordpress.org/trunk@41882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:59:47 +00:00
Adam Silverstein
274792f9cd
REST API: JS client - Enumerate endpoints supporting trash.
...
Improve the logic determining which endpoints support the trash by enumerating them. Endpoints that don't support the trash require `force=true` when deleting. The previous approach relied on the `force` argument description, which is a translated string and was fragile. In the future, we can expose whether an endpoint supports the trash as part of its schema and automate this logic.
Props Soean.
Fixes #40672 .
Built from https://develop.svn.wordpress.org/trunk@42047
git-svn-id: http://core.svn.wordpress.org/trunk@41881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:54:48 +00:00
Konstantin Obenland
b61de38e87
Customize: Spiff up theme updates
...
Fixes UI bugs around theme updates in the Customizer. Theme versions now get updated and users are no longer left alone after a successful update.
Props rinkuyadav999, celloexpressions for initial patch.
Fixes #42365 .
Built from https://develop.svn.wordpress.org/trunk@42046
git-svn-id: http://core.svn.wordpress.org/trunk@41880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 01:33:47 +00:00
Gary Pendergast
8981414082
About page: Tweak the privacy policy language, for clarity.
...
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@42045
git-svn-id: http://core.svn.wordpress.org/trunk@41879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 00:21:49 +00:00
Mel Choyce
f7aa0e24a7
About Page: Update the blurb in "Warning: Potential Danger Ahead!" to be more accurate.
...
Props transl8or, karmatosed, chanthaboune.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42044
git-svn-id: http://core.svn.wordpress.org/trunk@41878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 20:58:50 +00:00
Felix Arntz
82c6a301f2
Multisite: Pass network object instead of ID to `pre_get_main_site_id`.
...
In the original function introduced in [41380], and subsequently [41861], only the network ID was passed to the new `pre_get_main_site_id` filter. In order to make give quick access to other network properties, it was decided to pass the whole object instead. The changeset includes an additional test.
Fixes #29684 .
Built from https://develop.svn.wordpress.org/trunk@42043
git-svn-id: http://core.svn.wordpress.org/trunk@41877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 19:56:47 +00:00
Weston Ruter
ca84147401
Customize: Allow 0:00-0:59 in date/time control when 24-hour time used.
...
* Let min hour be 0 and max be 23 in 24-hour time; let min hour be 1 and max be 12 in 12-hour time.
* Show error notification when an invalid date value is provided, not just when not a future date.
* Fix translation of custom validity message.
* Start checking for validity after all inputs have been initially populated.
* Remove support for being able to enter 24:00.
* Cease forcing date input elements from being casted to integers, to allow for invalid inputs to be detected.
Props westonruter, Presskopp, peterwilsoncc, atachibana for testing.
See #39896 , #28721 .
Fixes #42373 .
Built from https://develop.svn.wordpress.org/trunk@42042
git-svn-id: http://core.svn.wordpress.org/trunk@41876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 16:40:47 +00:00
Weston Ruter
285c6a57c8
Tests: Remove references to deleted JS files in QUnit tests.
...
Amends [41570], [40584].
See #41755 , #40690 .
Built from https://develop.svn.wordpress.org/trunk@42041
git-svn-id: http://core.svn.wordpress.org/trunk@41875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 04:06:48 +00:00
Weston Ruter
fbb0b8bc8f
Customize: Debounce requests for theme searches and the updating of the resulting filter count.
...
Props celloexpressions.
See #37661 .
Fixes #42343 .
Built from https://develop.svn.wordpress.org/trunk@42040
git-svn-id: http://core.svn.wordpress.org/trunk@41874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-30 03:57:52 +00:00
Weston Ruter
9a18c87e0c
Customize: Fix phpdoc for params in `WP_Customize_Manager::add_section()`.
...
Amends [40804].
See #39671 .
Fixes #42372 .
Built from https://develop.svn.wordpress.org/trunk@42039
git-svn-id: http://core.svn.wordpress.org/trunk@41873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 03:22:49 +00:00
Weston Ruter
5fc9fddccc
Customize: Fix interface alignment between `Setting` and `Control`, adding `defaults` to `wp.customize.Setting` and using `wp.customize.previewer` as default `previewer` param.
...
Also move jsdoc from class to `initialize` method and correct the param types.
Amends [41726], [42037], [32681].
See #42083 , #30737 .
Built from https://develop.svn.wordpress.org/trunk@42038
git-svn-id: http://core.svn.wordpress.org/trunk@41872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 03:08:53 +00:00
Weston Ruter
35172737ef
Customize: Support instantiation of partials with flat/unwrapped params for parity with controls, sections, and panels in [41726].
...
* Passing `options.params` when constructing `Partial` is now deprecated in favor of just passing `options`.
* Improve usage of jsdoc in JS `Partial` class.
* Also add `defaults` property to `wp.customize.selectiveRefresh.Partial` class for parity with `Control`.
See #42083 .
Built from https://develop.svn.wordpress.org/trunk@42037
git-svn-id: http://core.svn.wordpress.org/trunk@41871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-29 00:15:53 +00:00
Weston Ruter
cb7483b595
Customize: Fix mobile placement of panes for available widgets and nav menu items.
...
Props Mahvash-Fatima.
Amends [41893].
See #42215 .
Fixes #42359 .
Built from https://develop.svn.wordpress.org/trunk@42036
git-svn-id: http://core.svn.wordpress.org/trunk@41870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 06:54:47 +00:00
Weston Ruter
84b969efea
Customize: Ensure `id` for section and panel is passed among `params` to respective templates.
...
Fixes issue where JS-added Publish Settings section failed to get container element ID set properly to hide its section-meta.
Amends [42025].
See #42337 , #42083 .
Built from https://develop.svn.wordpress.org/trunk@42035
git-svn-id: http://core.svn.wordpress.org/trunk@41869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 06:37:47 +00:00
Weston Ruter
685e3c1a67
Customize: Deprecate nav menu classes that are no longer used, instead of removing them immediately.
...
* Deprecate PHP classes `WP_Customize_New_Menu_Section` and `WP_Customize_New_Menu_Control`.
* Deprecate JS class `wp.customize.Menus.NewMenuControl`.
* Also introduce `wp.customize.Menus.createNavMenu()` for logic to create nav menus separately from the logic for handling UI interactions.
Amends [41768].
See #40104 , #42364 .
Fixes #42357 .
Built from https://develop.svn.wordpress.org/trunk@42034
git-svn-id: http://core.svn.wordpress.org/trunk@41868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 05:48:47 +00:00
Weston Ruter
9dca5ae189
Customize: Fix deep-linking to sections for themes via `autofocus[section]` query parameter.
...
* Expand containing panel when expanding themes section.
* Consolidate UI changes related to a section's expanded state change.
* Prevent collapsing current section when expanding.
* Auto-expand first themes section when expanding panel if one is not expanded already.
See #37661 , #42354 .
Fixes #42360 .
Built from https://develop.svn.wordpress.org/trunk@42033
git-svn-id: http://core.svn.wordpress.org/trunk@41867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 05:22:46 +00:00
Gary Pendergast
615a9afab8
Tests: Update `wp-api-generated.js`.
...
[41979] caused a change in `wp-api-generated.js`, so it needs to be updated.
See #39996 .
Built from https://develop.svn.wordpress.org/trunk@42032
git-svn-id: http://core.svn.wordpress.org/trunk@41866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 01:56:46 +00:00
Weston Ruter
d348f1624b
Customize: Improve Media control accessibility and compatibility for `settings` passed as arrays or as solitary `setting`.
...
* Eliminate Media control template from having dependency on `params.settings.default` for element ID, to fix compat with `params.settings` array or single `params.setting`. See #36167 .
* Move description out of label and add `aria-describedby` to Media control's Select button. See #30738 , #33085 .
* Obtain notification container whenever content is (re-)rendered (such as for Media control). See #38794 .
* Re-render notifications after control content is re-rendered, if control is in expanded section. See #38794 .
Amends [41390].
See #36167 , #38794 , #33085 , #30738 .
Built from https://develop.svn.wordpress.org/trunk@42031
git-svn-id: http://core.svn.wordpress.org/trunk@41865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 20:18:47 +00:00
Weston Ruter
cb877e10ba
Widgets: Prevent showing underlying attachment excerpt as caption when empty caption value is supplied in Image widget.
...
Allow underlying attachment to display if `caption` is `null`.
Props miyauchi, westonruter.
See #39993 .
Fixes #42350 .
Built from https://develop.svn.wordpress.org/trunk@42030
git-svn-id: http://core.svn.wordpress.org/trunk@41864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 05:05:51 +00:00
Weston Ruter
7b0de1f1b0
Themes: Switch back from throttling to debouncing in theme searches on admin screen.
...
Start debouncing after initial search performed when `search` query param is present to prevent initial "flash of unsearched themes".
Props afercia, westonruter.
Amends [41797].
See #40254 .
Fixes #42348 .
Built from https://develop.svn.wordpress.org/trunk@42029
git-svn-id: http://core.svn.wordpress.org/trunk@41863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-27 03:31:53 +00:00
John Blackbourn
c6fd6b0374
External Libraries: Remove usage of `each()` from the `Text_Diff_Engine_native` class.
...
This removes deprecated notices in PHP 7.2 but takes a different approach to the upstream class from Horde, which appears to be buggy.
Props SergeyBiryukov
Fixes #41526
Built from https://develop.svn.wordpress.org/trunk@42028
git-svn-id: http://core.svn.wordpress.org/trunk@41862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-26 12:52:53 +00:00
John Blackbourn
4550ef5b2c
External Libraries: Remove usage of text strings in `assert()` in the `Text_Diff_Engine_native` class.
...
See #41526
Built from https://develop.svn.wordpress.org/trunk@42027
git-svn-id: http://core.svn.wordpress.org/trunk@41861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-26 11:32:48 +00:00
Konstantin Obenland
db00af7cc2
Menus: Add `menu-$i` slugs to mapping groups
...
Helps to future proof the feature.
Also orders slugs by popularity to optimize mapping time.
See #39692 .
Built from https://develop.svn.wordpress.org/trunk@42026
git-svn-id: http://core.svn.wordpress.org/trunk@41860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 22:29:49 +00:00
Weston Ruter
a6af74ec32
Customize: Register the Publish Settings section in JS to ensure it does not get unregistered via PHP.
...
The `publish_settings` section is a fundamental dependency for Customizer, so it must be guaranteed to be registered.
Also unconditionally register core types for panels, sections, and controls in case plugin unhooks all `customize_register` actions.
See #39896 .
Fixes #42337 .
Built from https://develop.svn.wordpress.org/trunk@42025
git-svn-id: http://core.svn.wordpress.org/trunk@41859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 21:45:49 +00:00
Weston Ruter
3ed6bbf4a4
Customize: Link `elements` prior to embedding to prevent possible errors when a control is associated with a non-existent section.
...
Fixes issue specifically with attempting to access an orphaned control's `elements` immediately after it has been added. Normally this would not happen because a control would not be registered without a section, and also a control should only be interacted with once its `embedded` deferred has been resolved.
Also harden logic for gathering list of deferred setting IDs.
See #37964 .
Fixes #42330 .
Built from https://develop.svn.wordpress.org/trunk@42024
git-svn-id: http://core.svn.wordpress.org/trunk@41858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 16:49:49 +00:00
Sergey Biryukov
6b3b489a5d
Permalinks: Change mention of URI to URL in the description of `%category%` tag.
...
Props danieltj, tobifjellner.
Fixes #42147 .
Built from https://develop.svn.wordpress.org/trunk@42023
git-svn-id: http://core.svn.wordpress.org/trunk@41857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 11:11:45 +00:00
John Blackbourn
7fc62bbd4f
External Libraries: Revert [41633]. This causes warnings when editing and viewing certain revisions.
...
See #41526
Built from https://develop.svn.wordpress.org/trunk@42022
git-svn-id: http://core.svn.wordpress.org/trunk@41856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 09:56:53 +00:00
Weston Ruter
6794fd18ef
Post WordPress 4.9 Beta 4 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@42021
git-svn-id: http://core.svn.wordpress.org/trunk@41855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 07:08:52 +00:00
Weston Ruter
f6bf73792c
WordPress 4.9 Beta 4.
...
Built from https://develop.svn.wordpress.org/trunk@42020
git-svn-id: http://core.svn.wordpress.org/trunk@41854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 06:13:47 +00:00
David A. Kennedy
750098da21
Bundled Themes: Make sure new gallery widgets look good in themes
...
Twenty Ten: Reduces image size and removes image borders for galleries in widget areas.
Twenty Eleven: Reduces image size and removes image borders for galleries in widget areas.
Twenty Twelve: Reduces image size for some gallery sizes in widget areas.
Twenty Thirteen: Ensure proper clearing for images, hide captions for some gallery column combos and ensure good display for galleries in widget areas.
Twenty Fourteen: Ensure proper clearing for images and hide captions for some gallery column combos for galleries in widget areas.
Twenty Seventeen: Hide captions for some gallery column combos for galleries in widget areas.
Props joyously, williampatton, davidakennedy, melchoyce, crunnells.
Fixes #41969 .
Built from https://develop.svn.wordpress.org/trunk@42019
git-svn-id: http://core.svn.wordpress.org/trunk@41853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 02:17:47 +00:00
Weston Ruter
d19c79fa21
Customize: Remove `theme_installing` notification when installation fails.
...
Amends [41648].
Props celloexpressions.
See #42184 , #37661 .
Built from https://develop.svn.wordpress.org/trunk@42018
git-svn-id: http://core.svn.wordpress.org/trunk@41852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 01:14:46 +00:00
Gary Pendergast
3cd984f024
About page: The link URLs in the privacy policy shouldn't be translatable.
...
Both of these URLs live on the main wordpress.org site, not Rosetta sites.
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@42017
git-svn-id: http://core.svn.wordpress.org/trunk@41851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 01:07:47 +00:00
iandunn
2762709d2a
Dashboard: Strip ports from IPs to avoid PHP warnings.
...
Fixes #41083 .
Props pento, iandunn, EatonZ, birgire, dd32.
Built from https://develop.svn.wordpress.org/trunk@42016
git-svn-id: http://core.svn.wordpress.org/trunk@41850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 00:07:46 +00:00
Weston Ruter
12c626c82e
Update `$_old_files` to add the deleted MediaElement.js files when it was upgraded from 2.22.0 to 4.2.3.
...
Amends [41198].
See #39686 .
Fixes #42097 .
Built from https://develop.svn.wordpress.org/trunk@42015
git-svn-id: http://core.svn.wordpress.org/trunk@41849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 00:02:50 +00:00
Sergey Biryukov
116e4712cb
I18N: Use a consistent pattern for translator comments for placeholders in the string added in [42013].
...
See #41974 .
Built from https://develop.svn.wordpress.org/trunk@42014
git-svn-id: http://core.svn.wordpress.org/trunk@41848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:40:46 +00:00
Mel Choyce
7495a110cc
Code Editors: Add a persistent notification on CSS files, encouraging people to use the CSS panel in the Customizer instead of editing their CSS files directly.
...
Props helen, westonruter, nic.bertino, michelleweber.
Fixes #42100 .
Built from https://develop.svn.wordpress.org/trunk@42013
git-svn-id: http://core.svn.wordpress.org/trunk@41847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:35:46 +00:00
Weston Ruter
d96b7af890
Permalinks: Fix placement of structure tags based on last cursor position.
...
Props felipeelia, afercia.
See #29872 .
Fixes #42042 .
Built from https://develop.svn.wordpress.org/trunk@42012
git-svn-id: http://core.svn.wordpress.org/trunk@41846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:27:48 +00:00
John Blackbourn
2f3e91028a
Filesystem API: Add more specificity to the rules for valid files in `validate_file()`.
...
This now treats files containing `./` as valid, and also treats files containing a trailing `../` as valid due to widespread use of this pattern in theme and plugin zip files.
Adds tests.
Props Ipstenu, borgesbruno, DavidAnderson, philipjohn, birgire
Fixes #42016 , #36170
Built from https://develop.svn.wordpress.org/trunk@42011
git-svn-id: http://core.svn.wordpress.org/trunk@41845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:15:49 +00:00
John Blackbourn
16cfe96580
Filesystem API: Don't immediately return an error for invalid file names contained within a Zip while it's being extracted.
...
This allows the extraction of the rest of the valid files within the archive to continue.
See #42016
Built from https://develop.svn.wordpress.org/trunk@42010
git-svn-id: http://core.svn.wordpress.org/trunk@41844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:11:50 +00:00
Weston Ruter
48e726bbef
Embeds: Improve consistency of update and refresh logic for oEmbed caching between `oembed_cache` and post meta.
...
* Allow updating oEmbed cache during `parse-embed` requests for non-post editors (such as widgets).
* Update any existing `oembed_cache` post when `usecache` and TTL has passed.
* Do not overwrite a previously valid cache with `{{unknown}}`.
Props dlh.
See #34115 .
Fixes #42310 .
Built from https://develop.svn.wordpress.org/trunk@42009
git-svn-id: http://core.svn.wordpress.org/trunk@41843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:10:48 +00:00
Sergey Biryukov
5dd45b38c8
Transients: After [41963], add missing cron task for `delete_expired_transients()`.
...
Props dlh.
Fixes #41699 .
Built from https://develop.svn.wordpress.org/trunk@42008
git-svn-id: http://core.svn.wordpress.org/trunk@41842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 23:00:47 +00:00
John Blackbourn
4812370aab
Docs: Improve the docs for `validate_file()` and `validate_file_to_edit()`.
...
See #42016 , #36170 , #41017
Built from https://develop.svn.wordpress.org/trunk@42007
git-svn-id: http://core.svn.wordpress.org/trunk@41841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:50:49 +00:00
Sergey Biryukov
29d5ee851c
I18N: Use a consistent pattern for translator comments for placeholders in some more Customizer strings.
...
See #41974 .
Built from https://develop.svn.wordpress.org/trunk@42006
git-svn-id: http://core.svn.wordpress.org/trunk@41840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:47:46 +00:00
Sergey Biryukov
f156f90ff5
I18N: Add a context for remaining "Schedule" strings.
...
Props Mirucon.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@42005
git-svn-id: http://core.svn.wordpress.org/trunk@41839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 22:35:47 +00:00
David A. Kennedy
55c8978f1f
Twenty Seventeen: Make gallery link styles consistent in all widget areas
...
Removes the box shadow on gallery links in footer widget areas so they're consistent with the sidebar widget area.
Props transl8or, sami.keijonen, davidakennedy.
Fixes #42302 .
Built from https://develop.svn.wordpress.org/trunk@42004
git-svn-id: http://core.svn.wordpress.org/trunk@41838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:53:51 +00:00
Weston Ruter
a1ec65b695
Themes: Harmonize list of theme features on Theme Install screen with list in the Customizer.
...
Use the core list, rather than the .org API, due to inconsistencies and to ensure tags are translated.
Props celloexpressions.
See #37661 , #42306 .
Built from https://develop.svn.wordpress.org/trunk@42003
git-svn-id: http://core.svn.wordpress.org/trunk@41837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:46:47 +00:00
Sergey Biryukov
50c6a55fba
I18N: Give context to "Installed" string added in [41648].
...
Props dimadin.
Fixes #42325 .
Built from https://develop.svn.wordpress.org/trunk@42002
git-svn-id: http://core.svn.wordpress.org/trunk@41836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:43:47 +00:00
Weston Ruter
fd2e006968
Widgets: Limit container-constraining logic in Text widget to `video`, `iframe`, `object`, and `embed` elements.
...
Amends [41779].
See #40854 .
Built from https://develop.svn.wordpress.org/trunk@42001
git-svn-id: http://core.svn.wordpress.org/trunk@41835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:32:46 +00:00
Joe Hoyle
bebb0b0d82
REST API: Don’t remove unregistered properties from objects in schema.
...
In r41727 the ability to sanitise and validate objects from JSON schema was added, with a whitelist approach. It was decided we should pass through all non-registered properties to reflect the behaviour of the root object in register_rest_route. To prevent arbitrary extra data via setting objects, we force additionalProperties to false in the settings endpoint.
See #38583 .
Built from https://develop.svn.wordpress.org/trunk@42000
git-svn-id: http://core.svn.wordpress.org/trunk@41834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 21:05:49 +00:00
Mel Choyce
c0d0380baa
Code Editors: Tweak styles to work better on smaller screens.
...
See #42100 .
Built from https://develop.svn.wordpress.org/trunk@41999
git-svn-id: http://core.svn.wordpress.org/trunk@41833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 20:29:46 +00:00
Mel Choyce
9c7eb32fc2
Credits: Update "Contributing Developers" to "Noteworthy Contributors."
...
"Developers" excludes the various major contributors in non-developer roles, so let's update this term to be more inclusive.
See #41022 .
Built from https://develop.svn.wordpress.org/trunk@41998
git-svn-id: http://core.svn.wordpress.org/trunk@41832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 19:29:47 +00:00
Weston Ruter
6737643773
Customize: Prevent theme installation and deletion in Customizer while SFTP credentials need to be requested.
...
This is a temporary measure while we wait for credentials to be able to be supplied in the Customizer.
Amends [41788].
See #42184 , #37661 , #42126 .
Built from https://develop.svn.wordpress.org/trunk@41997
git-svn-id: http://core.svn.wordpress.org/trunk@41831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 19:06:47 +00:00
Mel Choyce
b008754486
Code Editors: Update copy in warning modals.
...
Props helen.
See #42100 .
Built from https://develop.svn.wordpress.org/trunk@41996
git-svn-id: http://core.svn.wordpress.org/trunk@41830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 18:47:47 +00:00
Konstantin Obenland
5aa45cd12e
Customize: Allow previewed menus to be customized
...
Fixes a bug where menu assignements couldn't be changed when previewing a theme.
Also removes an unnecessary call to menu mapping after a theme switch from the customizer and makes sure the locations option is always written, for good measure.
Props westonruter.
See #39692 .
Built from https://develop.svn.wordpress.org/trunk@41995
git-svn-id: http://core.svn.wordpress.org/trunk@41829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 18:35:48 +00:00
Weston Ruter
7e689f541d
Code Editor: Fix phpunit tests related to `gutters` after [41974].
...
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41994
git-svn-id: http://core.svn.wordpress.org/trunk@41828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:58:50 +00:00
Ella Iseulde Van Dorpe
abc1579a42
TinyMCE: Set undefined FloatPanel zIndex
...
See [40995] for the Customizer.
Fixes #42322 .
Built from https://develop.svn.wordpress.org/trunk@41993
git-svn-id: http://core.svn.wordpress.org/trunk@41827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:52:56 +00:00
Weston Ruter
226263bfec
Code Editor: Define default `gutters` and toggle lint markers based on changes to `lint` option.
...
Explicitly define `gutters` in base `defaultSettings` to improve merges of multiple calls to `wp_enqueue_code_editor()`.
Props westonruter, georgestephanis for testing.
Amends [41974].
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41992
git-svn-id: http://core.svn.wordpress.org/trunk@41826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 16:35:54 +00:00
Sergey Biryukov
9eb75432b6
Canonical: Strip trailing punctuation from permalinks.
...
Previously attempted in [40256], which caused the test for decoded curly quotes to fail in some environments.
`$_SERVER['REQUEST_URI']` contains the encoded URI, so this version removes the failing tests and only checks for encoded curly quotes.
Props joostdevalk, lancewillett, SergeyBiryukov.
Fixes #20383 .
Built from https://develop.svn.wordpress.org/trunk@41991
git-svn-id: http://core.svn.wordpress.org/trunk@41825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 14:18:48 +00:00
Sergey Biryukov
bcdedf7f4a
Formatting: Make sure `wp_allowed_protocols()` is filterable until `wp_loaded` has fired.
...
Fixes the issue with plugins not being able to use the `kses_allowed_protocols` filter if `esc_url()` was called too early.
Props turtlepod, SergeyBiryukov.
Fixes #36033 .
Built from https://develop.svn.wordpress.org/trunk@41990
git-svn-id: http://core.svn.wordpress.org/trunk@41824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 13:25:55 +00:00
John Blackbourn
2623caf8b0
Docs: Correct a class name in the docs for `WP_Customize_Manager::post_value()`.
...
See #41017
Built from https://develop.svn.wordpress.org/trunk@41989
git-svn-id: http://core.svn.wordpress.org/trunk@41823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 11:57:49 +00:00
Sergey Biryukov
4c16522bbe
Taxonomy: Use `keypress` instead of `keyup` for listening for Enter key to add a tag via Tags meta box.
...
Fixes issue with Japanese input.
Props miyauchi.
Fixes #42234 .
Built from https://develop.svn.wordpress.org/trunk@41988
git-svn-id: http://core.svn.wordpress.org/trunk@41822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 11:30:49 +00:00
Sergey Biryukov
654386a5b7
Taxonomy: After [40984], add the `most_used` label for non-hierarchical taxonomies too, and use it on the Menus screen.
...
Props johnbillion.
Fixes #41150 .
Built from https://develop.svn.wordpress.org/trunk@41987
git-svn-id: http://core.svn.wordpress.org/trunk@41821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 11:23:24 +00:00
Sergey Biryukov
ffddfb573b
I18N: Remove `<code>` and `<kbd>` tags from translatable strings on Settings screens.
...
Move URLs to separate strings.
Props ramiy.
Fixes #40763 .
Built from https://develop.svn.wordpress.org/trunk@41986
git-svn-id: http://core.svn.wordpress.org/trunk@41820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 10:51:52 +00:00
Weston Ruter
9093718b15
Editor: Specify `maxwidth` in `parse-embed` requests based on width of editor iframe so that TinyMCE view embeds fit, particularly in Text widgets.
...
See #40854 , #34115 .
Built from https://develop.svn.wordpress.org/trunk@41985
git-svn-id: http://core.svn.wordpress.org/trunk@41819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 04:07:50 +00:00
Helen Hou-Sandí
a7f2613fc7
Buttons: Ensure active styling applies to both `:active` and `.active`.
...
props sayedwp, helen.
fixes #42236 .
Built from https://develop.svn.wordpress.org/trunk@41984
git-svn-id: http://core.svn.wordpress.org/trunk@41818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 23:34:49 +00:00
Sergey Biryukov
a891bc6c92
Docs: Fix typo in `path_is_absolute()` description.
...
Props octalmage, birgire.
Fixes #42317 .
Built from https://develop.svn.wordpress.org/trunk@41983
git-svn-id: http://core.svn.wordpress.org/trunk@41817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:51:46 +00:00
Weston Ruter
fce310e744
Menus: Don't prime nav menu items cache if a persistent cache is being used.
...
Amends [14560].
Props david.binda.
See #12734 .
Fixes #41662 .
Built from https://develop.svn.wordpress.org/trunk@41982
git-svn-id: http://core.svn.wordpress.org/trunk@41816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:40:50 +00:00
Mel Choyce
94e74066e9
About Page: Revised strings to be easier to translate.
...
Props kristastevens, Presskopp, swissspidy.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@41981
git-svn-id: http://core.svn.wordpress.org/trunk@41815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:24:47 +00:00
Peter Wilson
339d838475
Comments: Check if `wp_new_comment()` returns an error.
...
Adds checks throughout to allow for `wp_new_comment()` returning a `WP_Error` instance.
Updates the docs for the `pre_comment_approved` filter to include that it can be passed an error.
Props enrico.sorcinelli, ryotsun.
Fixes #39730 .
Built from https://develop.svn.wordpress.org/trunk@41980
git-svn-id: http://core.svn.wordpress.org/trunk@41814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:12:51 +00:00
Weston Ruter
29d213cfbd
REST API: Allow passing existing template value for posts even when template no longer exists.
...
Also remove `enum` for validating allowed templates to allow plugins to dynamically supply their own templates for specific posts, even when they are not in the theme.
Props TimothyBlynJacobs, jnylen0, swissspidy.
Fixes #39996 .
Built from https://develop.svn.wordpress.org/trunk@41979
git-svn-id: http://core.svn.wordpress.org/trunk@41813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:11:46 +00:00
Aaron Jorbin
b8fc8cb59c
Dashboard: Remove "Try Gutenberg" callout.
...
Reverting this for 4.9. It will be added back in a future version of WordPress. This doesn't mean that you shouldn't be trying Gutenberg, just that it isn't ready for a call out to a larger audience. But if you are the type to read commit messages, https://github.com/WordPress/gutenberg could use your pull requests and comments on issues.
Reverts [41931] [41900] [41896] [41895]
See #41316
Built from https://develop.svn.wordpress.org/trunk@41978
git-svn-id: http://core.svn.wordpress.org/trunk@41812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:48:47 +00:00
Weston Ruter
c364743d35
Code Editor: Add `underscore` as a dependency for the `code-editor` script.
...
Amends [41376].
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41977
git-svn-id: http://core.svn.wordpress.org/trunk@41811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:38:47 +00:00
Pascal Birchler
74fc7efbae
Themes: Add files missed in [41975].
...
See #41717 .
Built from https://develop.svn.wordpress.org/trunk@41976
git-svn-id: http://core.svn.wordpress.org/trunk@41810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:23:49 +00:00
Pascal Birchler
8222b85aa2
Themes: Show templates from both parent and child theme when calling `WP_Theme::get_post_templates()`.
...
Props birgire for initial patch.
Fixes #41717 .
Built from https://develop.svn.wordpress.org/trunk@41975
git-svn-id: http://core.svn.wordpress.org/trunk@41809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:08:47 +00:00
Weston Ruter
0343b1a2c8
Code Editor: Keep linting and its error reporting configured when `lint` option is changed dynamically.
...
Also explicitly disable `lint` option for SCSS and LESS.
See #12423 .
Built from https://develop.svn.wordpress.org/trunk@41974
git-svn-id: http://core.svn.wordpress.org/trunk@41808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 19:55:46 +00:00
Konstantin Obenland
91ad9114d0
Customize: Ease extendability of filter drawer
...
By moving the `wporg` conditional inside the method body, the filter drawer can be overridden without having to also override the entire section template.
Props celloexpressions.
Closes #42212 .
Built from https://develop.svn.wordpress.org/trunk@41973
git-svn-id: http://core.svn.wordpress.org/trunk@41807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 18:58:46 +00:00
Andrea Fercia
69518459e6
Customize: Make sure the FTP credentials modal is visible.
...
The customizer and the theme installer use `visibility: hidden` on the body when
they open full-overlays screens. The FTP credentials modal needs a visibility
property set back to `visible` to be visible over those overlays.
Props purnendu.
Fixes #42205 .
Built from https://develop.svn.wordpress.org/trunk@41972
git-svn-id: http://core.svn.wordpress.org/trunk@41806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 17:54:53 +00:00
Sergey Biryukov
703713756a
Tests: Fix typo in `test_do_action_with_multiple_callbacks_on_different_priorities()`.
...
Props withinboredom.
Fixes #42311 .
Built from https://develop.svn.wordpress.org/trunk@41971
git-svn-id: http://core.svn.wordpress.org/trunk@41805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 13:04:49 +00:00
Peter Wilson
ca45ec136f
Build/Test tools: Move `wp_doing_ajax` defintion from class setup to test setup.
...
Moves defintion of ajax request in `WP_Ajax_UnitTestCase` to `setUp()` method to account for hooks being reset as part of `tearDown()`.
Props matthias.thiel for report.
Fixes #41561 .
Built from https://develop.svn.wordpress.org/trunk@41970
git-svn-id: http://core.svn.wordpress.org/trunk@41804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 05:11:47 +00:00
Weston Ruter
990c6d5a42
Customize: Keep frontend preview link updated to reflect the current state of previewed URL, active theme, and autosaved state.
...
See #39896 .
Built from https://develop.svn.wordpress.org/trunk@41969
git-svn-id: http://core.svn.wordpress.org/trunk@41803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 00:41:47 +00:00
Weston Ruter
5e7e44aba7
Customize: Update 'Save & Activate' reference to 'Publish & Activate' in themes help tab text.
...
See #39896 .
Fixes #42305 .
Built from https://develop.svn.wordpress.org/trunk@41968
git-svn-id: http://core.svn.wordpress.org/trunk@41802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-22 20:03:51 +00:00
John Blackbourn
74cf14cdf3
Docs: Correct docs introduced in [41965].
...
See #16778
Built from https://develop.svn.wordpress.org/trunk@41967
git-svn-id: http://core.svn.wordpress.org/trunk@41801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 22:42:51 +00:00
Dion Hulse
cb1b49bca5
Tests: Return an exit code of 1 in the event that the database server for tests is unavailable.
...
This allows for automated scripts & test suites to handle the failure of the test suite easier.
Props danielbachhuber
Fixes #41916
Built from https://develop.svn.wordpress.org/trunk@41966
git-svn-id: http://core.svn.wordpress.org/trunk@41800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 14:14:48 +00:00
Gary Pendergast
8608b710b7
Docs: Expand the docs for the `core_version_check_query_args` filter.
...
Add documentation for the parameters in the `$query` parameter.
Props MattyRob.
Fixes #16778 .
Built from https://develop.svn.wordpress.org/trunk@41965
git-svn-id: http://core.svn.wordpress.org/trunk@41799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:46:50 +00:00
Gary Pendergast
0847fab645
Media: Don't backdate media uploaded to pages.
...
When media is uploaded to a post, the upload directory is set according to the date of the post, so that the media URLs in the post match when the post was published.
A page is a slightly different beast, pages often live for years, and are regularly updated to stay relevant. This change causes media uploaded to pages to use the upload date to determine the upload directory.
Fixes #10752 .
Built from https://develop.svn.wordpress.org/trunk@41964
git-svn-id: http://core.svn.wordpress.org/trunk@41798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:27:48 +00:00
Dion Hulse
26f9c6b909
Transients: Clear expired transients from the database in a daily cron task.
...
Fixes #41699
Built from https://develop.svn.wordpress.org/trunk@41963
git-svn-id: http://core.svn.wordpress.org/trunk@41797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 13:22:49 +00:00
Gary Pendergast
f7fcb2cd5b
Updates: Add the `core_version_check_query_args` filter.
...
This filter allows the data being sent for core update checks to be controlled for privacy concerns.
Props toscho, MattyRob, swissspidy, pento.
Fixes #16778 .
Built from https://develop.svn.wordpress.org/trunk@41962
git-svn-id: http://core.svn.wordpress.org/trunk@41796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 11:55:47 +00:00
Weston Ruter
0c1c0980e7
Customize: Improve back-compat for `wp.customize.Control` subclasses that expect `options.params` to be present for direct manipulation before calling parent `initialize` method.
...
Fixes known incompatibility with Make theme.
Amends [41726].
See #30741 .
Built from https://develop.svn.wordpress.org/trunk@41961
git-svn-id: http://core.svn.wordpress.org/trunk@41795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 08:51:48 +00:00
Weston Ruter
1f735509af
Customize: Allow control subclasses to add to the `deferred` object before the base class initializes.
...
Update the `CodeEditorControl`'s `codemirror` deferred to be set before calling the parent class's `initialize` method. Since the `ready` method may be called directly by `initialize` it may be too late to add a new `Deferred` to the control's `deferred` property after calling the base control class's `initialize`.
Amends [41958].
See #41897 .
Built from https://develop.svn.wordpress.org/trunk@41960
git-svn-id: http://core.svn.wordpress.org/trunk@41794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-21 08:44:52 +00:00
Sergey Biryukov
45655bb928
Docs: Document `$wp_version` global in `wp_initial_constants()`.
...
Props mt8.biz.
Fixes #42259 .
Built from https://develop.svn.wordpress.org/trunk@41959
git-svn-id: http://core.svn.wordpress.org/trunk@41793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 22:04:56 +00:00
Weston Ruter
47c555f8ed
Customize: Add `codemirror` deferred object to `CodeEditorControl` which is resolved when CodeMirror is initialized.
...
CodeMirror gets initialized once the control's containing section is expanded. The deferred will be rejected if user preference for syntax highlighting is disabled.
Also move jsdoc from `wp.customize.Control` to intended `wp.customize.Control#initialize()`.
See #41897 , #12423 .
Built from https://develop.svn.wordpress.org/trunk@41958
git-svn-id: http://core.svn.wordpress.org/trunk@41792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 21:48:46 +00:00
Weston Ruter
81c87e7d5e
Code Editor: Improve ability to create Customizer `CodeEditorControl` instances in JS, lessening PHP dependencies.
...
Allow `CodeEditorControl` to be instantiated with a `editor_settings` param which is merged with `wp.codeEditor.defaultSettings`.
Also:
* Turn redundant "CSS Code" control label into screen reader text for Additional CSS.
* Remove `code-editor` as script dependency for `custom-html-widgets` since enqueueing is determined by `wp_enqueue_code_editor()`.
* Remove useless exporting of `code_type` param to JS in `WP_Customize_Code_Editor_Control`.
* Add `disabled` class to Custom HTML widget's Save button when linting errors are present.
* Remove redundant `span` inside CodeEditorControl's `label`.
See #41897 , #12423 , #41872 .
Built from https://develop.svn.wordpress.org/trunk@41957
git-svn-id: http://core.svn.wordpress.org/trunk@41791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 16:39:48 +00:00
Sergey Biryukov
33012ad740
Customize: Use typographic quotation marks in the strings added in [41768].
...
Props audrasjb, tobifjellner.
Fixes #42290 . See #40104 .
Built from https://develop.svn.wordpress.org/trunk@41956
git-svn-id: http://core.svn.wordpress.org/trunk@41790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 14:07:47 +00:00
Sergey Biryukov
f80db51d0f
Menus: Remove an extra space in the `<ul>` tag in `Walker_Nav_Menu::start_lvl()`.
...
Fixes #42289 .
Built from https://develop.svn.wordpress.org/trunk@41955
git-svn-id: http://core.svn.wordpress.org/trunk@41789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:40:46 +00:00
Mel Choyce
d31ab27d26
Customize Menus: Update capitalization of "next" to match case on the "Next" button.
...
Props hardeepasrani.
Fixes #42287 .
Built from https://develop.svn.wordpress.org/trunk@41954
git-svn-id: http://core.svn.wordpress.org/trunk@41788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:34:49 +00:00
Mel Choyce
4d41bf7127
Customization Locking: Update error message to use existing strings.
...
Props ramiy.
See #42024 .
Built from https://develop.svn.wordpress.org/trunk@41953
git-svn-id: http://core.svn.wordpress.org/trunk@41787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 10:32:53 +00:00
Weston Ruter
a402312a8d
Customize: Prevent using default template for a base control when it has content rendered on the server.
...
Also prevent invalid `type` attribute from being added to a `select` element.
See #30738 .
Fixes #42286 .
Built from https://develop.svn.wordpress.org/trunk@41952
git-svn-id: http://core.svn.wordpress.org/trunk@41786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-20 03:30:46 +00:00
Weston Ruter
6913ad9219
Widgets: Improve extensibility of the Gallery widget and of media widgets generally.
...
* Introduce a `widget_{$id_base}_instance_schema` filter for plugins to add new properties to a media widget's instance schema.
* Pass all of a gallery widget's instance props to the gallery media frame, not just the ones that core supports.
See #32417 , #41914 .
Fixes #42285 .
Built from https://develop.svn.wordpress.org/trunk@41951
git-svn-id: http://core.svn.wordpress.org/trunk@41785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 23:44:48 +00:00
Weston Ruter
ea21ad6cc1
Customize: Prevent re-highlighting "Add Items" button after available nav menu items pane has already been opened.
...
Amends [41930].
Props bpayton.
See #42114 .
Built from https://develop.svn.wordpress.org/trunk@41950
git-svn-id: http://core.svn.wordpress.org/trunk@41784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 18:38:47 +00:00
Weston Ruter
c8105f1460
Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen.
...
Amends [41893].
Props Mahvash-Fatima.
See #42215 .
Fixes #42275 .
Built from https://develop.svn.wordpress.org/trunk@41949
git-svn-id: http://core.svn.wordpress.org/trunk@41783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 18:10:47 +00:00
Weston Ruter
d695648084
Customize: Fix rendering issues in theme browsing when opening theme details or performing search in Safari.
...
Props sayedwp.
See #37661 .
Fixes #42052 .
Built from https://develop.svn.wordpress.org/trunk@41948
git-svn-id: http://core.svn.wordpress.org/trunk@41782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 17:57:47 +00:00
Weston Ruter
b1a9139b46
Customize: Prevent drawing attention to save button if status unchanged from publish; account for changes to status/date when alerting about unsaved changes.
...
Also fix malformed ESLint directive from [41933].
Amends [41932].
See #39896 , #42211 .
Built from https://develop.svn.wordpress.org/trunk@41947
git-svn-id: http://core.svn.wordpress.org/trunk@41781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 17:42:54 +00:00
Gary Pendergast
609da14d59
About page: Update the privacy policy dashes.
...
If one were to insert 1—3 dashes into a sentence - on purpose - they should use the correct da–
sh.
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@41946
git-svn-id: http://core.svn.wordpress.org/trunk@41780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:36:47 +00:00
John Blackbourn
06eba419fe
Build/Test tools: Document the return value of `WP_UnitTestCase::factory()`.
...
See #41017
Built from https://develop.svn.wordpress.org/trunk@41945
git-svn-id: http://core.svn.wordpress.org/trunk@41779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:33:48 +00:00
Gary Pendergast
31a3c8e744
About page: Update the privacy policy language.
...
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@41944
git-svn-id: http://core.svn.wordpress.org/trunk@41778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 15:26:48 +00:00
Mel Choyce
02ff01d331
About Page: Commit initial strings for 4.9.
...
Props kristastevens, dd32, hlashbrooke.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@41943
git-svn-id: http://core.svn.wordpress.org/trunk@41777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:57:48 +00:00
Sergey Biryukov
3aa0c23274
Docs: After [37329], update the documentation for `register_widget()` and `unregister_widget()`.
...
Both functions can accept a `WP_Widget` instance object instead of a `WP_Widget` subclass name, same as `WP_Widget_Factory::register()` and `::unregister()`.
Props behzod.
Fixes #42270 .
Built from https://develop.svn.wordpress.org/trunk@41942
git-svn-id: http://core.svn.wordpress.org/trunk@41776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:51:50 +00:00
Sergey Biryukov
1accb992f8
Menus: Pass `$recent_args` parameter to `nav_menu_items_{$post_type_name}_recent` filter.
...
Props welcher, eclev91.
Fixes #39849 .
Built from https://develop.svn.wordpress.org/trunk@41941
git-svn-id: http://core.svn.wordpress.org/trunk@41775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 13:05:55 +00:00
Sergey Biryukov
9c4fb24458
Docs: Reference `WP_Comment_Query::__construct()` as the source of information on accepted arguments in `get_comments()` and `get_approved_comments()`.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@41940
git-svn-id: http://core.svn.wordpress.org/trunk@41774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 08:49:47 +00:00
Weston Ruter
bdefa6bf34
Post WordPress 4.9 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@41939
git-svn-id: http://core.svn.wordpress.org/trunk@41773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 05:08:48 +00:00
Weston Ruter
0ae160dec1
WordPress 4.9 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@41938
git-svn-id: http://core.svn.wordpress.org/trunk@41772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 04:43:48 +00:00
Joe McGill
d21f6799a6
Customizer: Improve handling of crops in the media library.
...
This is a follow up on r41732, implementing the following improvements:
* Attachment parent info is now stored in attachment meta rather than a
separate post meta key.
* Attachments created from contextual crops (e.g. header, logos, etc.) are
filtered out of the media library using a new `_filterContext` method in
`wp.media.controller.Library`.
Props joemcgill, westonruter.
See #21819 .
Built from https://develop.svn.wordpress.org/trunk@41937
git-svn-id: http://core.svn.wordpress.org/trunk@41771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 04:18:47 +00:00
Weston Ruter
20aad6b5c5
Customize: Consistently use `input_attrs` as control param key in JS instead of `inputAttrs`.
...
See #30738 , #41897 .
Built from https://develop.svn.wordpress.org/trunk@41936
git-svn-id: http://core.svn.wordpress.org/trunk@41770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 03:25:47 +00:00
Weston Ruter
f8d16c8aed
Customize: Move control's fallback selection of default content template to `renderContent` method to align with sections and panels.
...
* Only use default control content template when a more specific template doesn't exist.
* Remove extraneous whitespace from being output in `WP_Customize_Control::render()` method.
* Move Custom Header template printing to `customize_controls_print_footer_scripts` action.
See #30738 .
Built from https://develop.svn.wordpress.org/trunk@41935
git-svn-id: http://core.svn.wordpress.org/trunk@41769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 03:04:49 +00:00
Sergey Biryukov
c81acd7cef
I18N: Unify permission error message in `wp-admin/ms-delete-site.php`.
...
Props ramiy.
Fixes #42268 .
Built from https://develop.svn.wordpress.org/trunk@41934
git-svn-id: http://core.svn.wordpress.org/trunk@41768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 00:48:50 +00:00
Weston Ruter
887998f7ed
Widgets: Harden logic for checking for valid media URLs.
...
* Update deprecated `isHostedVideo` method to always return `true` since all oEmbeds are now supported.
* Disable `scanImage` for non-image media widgets.
* Ensure embed URL field element is matched from current media frame instance due to bug where media frames are not destroyed upon closing.
* Update error message for invalid video URLs to ask user to check the URL for validity.
Props gk.loveweb, octalmage, westonruter.
See #42039 , #40935 .
Fixes #41052 .
Built from https://develop.svn.wordpress.org/trunk@41933
git-svn-id: http://core.svn.wordpress.org/trunk@41767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 00:07:54 +00:00
Weston Ruter
ed686152f5
Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.
...
Props bpayton, westonruter.
See #42114 , #39896 .
Fixes #42211 .
Built from https://develop.svn.wordpress.org/trunk@41932
git-svn-id: http://core.svn.wordpress.org/trunk@41766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 23:06:49 +00:00
Sergey Biryukov
15c8976cc4
Dashboard: Add missing URL to "Help with testing" link in Gutenberg callout.
...
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41931
git-svn-id: http://core.svn.wordpress.org/trunk@41765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 22:41:46 +00:00
Weston Ruter
b65d6eb680
Customize: Draw attention to "Add Items" button after creating a new menu.
...
Introduce `wp.customize.utils.highlightButton()` and `wp.customize.Menus.MenuSection#highlightNewItemButton()`.
Props bpayton, melchoyce, afercia, westonruter.
Fixes #42114 .
Built from https://develop.svn.wordpress.org/trunk@41930
git-svn-id: http://core.svn.wordpress.org/trunk@41764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 22:00:50 +00:00
Sergey Biryukov
71dca590dc
Build/Test Tools: Clean up `$_REQUEST` and `$GLOBALS` after modifying them in `_test_list_hierarchical_page()`.
...
Props birgire.
Fixes #42044 .
Built from https://develop.svn.wordpress.org/trunk@41929
git-svn-id: http://core.svn.wordpress.org/trunk@41763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:48:48 +00:00
Sergey Biryukov
0f06f90341
Rewrite Rules: Remove redundant `if` condition in `extract_from_markers()`.
...
Props Dency, yahil, appchecker.
Fixes #39920 .
Built from https://develop.svn.wordpress.org/trunk@41928
git-svn-id: http://core.svn.wordpress.org/trunk@41762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:28:46 +00:00
Sergey Biryukov
0afafb7a1b
I18N: Unify error messages in XML-RPC methods `wp_deleteCategory()` and `wp_deleteComment()`.
...
Props ramiy.
Fixes #39019 .
Built from https://develop.svn.wordpress.org/trunk@41927
git-svn-id: http://core.svn.wordpress.org/trunk@41761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:12:51 +00:00
Sergey Biryukov
50db4bceb0
Administration: After [41120], check for a registered action before sending a Bad Request HTTP response status code.
...
Props Clorith.
Fixes #42240 .
Built from https://develop.svn.wordpress.org/trunk@41926
git-svn-id: http://core.svn.wordpress.org/trunk@41760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:01:49 +00:00
Sergey Biryukov
469e37446e
Menus: Remove unnecessary top margin for menu item type on Menus screen for correct alignment with the dropdown icon.
...
Props punit5658.
Fixes #41521 .
Built from https://develop.svn.wordpress.org/trunk@41925
git-svn-id: http://core.svn.wordpress.org/trunk@41759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 20:52:49 +00:00
Sergey Biryukov
d2499c4212
Network Admin: After [41923], move the second `<p>` tag to a new line for better readability.
...
See #41652 .
Built from https://develop.svn.wordpress.org/trunk@41924
git-svn-id: http://core.svn.wordpress.org/trunk@41758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 20:51:48 +00:00
Sergey Biryukov
a749494900
I18N: Remove hardcoded constant from a translatable string in `network_step1()`.
...
Props ramiy.
Fixes #41652 .
Built from https://develop.svn.wordpress.org/trunk@41923
git-svn-id: http://core.svn.wordpress.org/trunk@41757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 20:02:50 +00:00
Sergey Biryukov
73dc2a45e3
Docs: Document `$ini_all` staticvar in `wp_is_ini_value_changeable()`.
...
Props nileshdudakiya94.
Fixes #41399 .
Built from https://develop.svn.wordpress.org/trunk@41922
git-svn-id: http://core.svn.wordpress.org/trunk@41756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 19:54:48 +00:00
Sergey Biryukov
106beec6a7
I18N: Combine two "Warning" strings in `network_step1()` and `network_step2()`.
...
Props ramiy.
Fixes #38570 .
Built from https://develop.svn.wordpress.org/trunk@41921
git-svn-id: http://core.svn.wordpress.org/trunk@41755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 19:50:47 +00:00
Sergey Biryukov
eac62c8da0
Date/Time: Use delta comparison in `get_gmt_from_date()` tests to avoid race conditions.
...
Props keesiemeijer.
Fixes #38815 .
Built from https://develop.svn.wordpress.org/trunk@41920
git-svn-id: http://core.svn.wordpress.org/trunk@41754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 19:42:48 +00:00
Weston Ruter
9cb9695104
Customize: Fix visibility of overlay notifications in Safari.
...
Props sayedwp, westonruter.
Amends [41390].
See #35210 , #42024 , #42052 .
Built from https://develop.svn.wordpress.org/trunk@41919
git-svn-id: http://core.svn.wordpress.org/trunk@41753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 18:14:37 +00:00
Felix Arntz
4cb1026757
Multisite: Document all return types in get_networks().
...
Adds more complete documentation to get_networks() and the corresponding methods in WP_Network_Query.
Fixes #42260 .
Built from https://develop.svn.wordpress.org/trunk@41918
git-svn-id: http://core.svn.wordpress.org/trunk@41752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 18:13:50 +00:00
Sergey Biryukov
0fc7597032
Docs: Document `$default_scripts` parameter in `_WP_Editors::enqueue_scripts()`.
...
Props danieltj, ajayghaghretiya1.
Fixes #41322 .
Built from https://develop.svn.wordpress.org/trunk@41917
git-svn-id: http://core.svn.wordpress.org/trunk@41751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 18:09:47 +00:00
Sergey Biryukov
a28bd1d36c
Plugins: Revert unintended change from [41915].
...
See #37430 .
Built from https://develop.svn.wordpress.org/trunk@41916
git-svn-id: http://core.svn.wordpress.org/trunk@41750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 18:01:49 +00:00
Sergey Biryukov
936bf3661f
Plugins: After [41608], make the markup in `WP_Plugin_Install_List_Table::no_items()` a bit more readable.
...
See #37430 .
Built from https://develop.svn.wordpress.org/trunk@41915
git-svn-id: http://core.svn.wordpress.org/trunk@41749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:58:48 +00:00
Sergey Biryukov
4dd637acde
Docs: Add `@since` entry for `WP_Automatic_Updater::after_core_update()`, introduced in [25841].
...
See #41017 , #29086 .
Built from https://develop.svn.wordpress.org/trunk@41914
git-svn-id: http://core.svn.wordpress.org/trunk@41748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:48:49 +00:00
Weston Ruter
ae538512c3
Widgets: Fix previewing embeds in Text widget by allowing `parse-embed` admin ajax requests with an empty `post_ID` just as `WP_oEmbed_Controller::get_proxy_item_permissions_check()` allows.
...
As of #34115 if there is no post context the oEmbed will be cached in an `oembed_cache` custom post type, so having a post as context is no longer a requirement for caching.
Props biskobe, westonruter.
See #34115 , #40450 .
Fixes #40854 .
Built from https://develop.svn.wordpress.org/trunk@41913
git-svn-id: http://core.svn.wordpress.org/trunk@41747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:40:49 +00:00
Jeremy Felt
548d8c2e0d
Multisite: Document all return types in `get_sites()`.
...
Adds more complete documentation to `get_sites()` and the corresponding methods in `WP_Site_Query`.
Fixes #41789 .
Built from https://develop.svn.wordpress.org/trunk@41912
git-svn-id: http://core.svn.wordpress.org/trunk@41746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:39:46 +00:00
Sergey Biryukov
53dba84ec7
I18N: Remove `<a>` tag from a translatable string in `confirm_another_blog_signup()`.
...
Props ramiy.
Fixes #41694 .
Built from https://develop.svn.wordpress.org/trunk@41911
git-svn-id: http://core.svn.wordpress.org/trunk@41745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:36:50 +00:00
Sergey Biryukov
3951984680
I18N: Remove `<b>` tag from a translatable string in `post_submit_meta_box()`.
...
Props ramiy.
Fixes #41681 .
Built from https://develop.svn.wordpress.org/trunk@41910
git-svn-id: http://core.svn.wordpress.org/trunk@41744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:31:48 +00:00
Sergey Biryukov
6b2a4c4574
I18N: Remove `<strong>` tag from a translatable string in `Theme_Upgrader::install_strings()`.
...
Props ramiy.
Fixes #41695 .
Built from https://develop.svn.wordpress.org/trunk@41909
git-svn-id: http://core.svn.wordpress.org/trunk@41743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:20:48 +00:00
Sergey Biryukov
2b9e8abd8f
I18N: Remove `<code>` tags from translatable strings in `Core_Upgrader`, `Language_Pack_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`.
...
Props ramiy.
Fixes #41705 .
Built from https://develop.svn.wordpress.org/trunk@41908
git-svn-id: http://core.svn.wordpress.org/trunk@41742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 17:15:47 +00:00
Sergey Biryukov
fb8d73a0f7
Docs: Correct type and description for the `$data` parameter in `WP_Http::browser_redirect_compatibility()`.
...
Fixes #41380 .
Built from https://develop.svn.wordpress.org/trunk@41907
git-svn-id: http://core.svn.wordpress.org/trunk@41741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 16:38:48 +00:00
Sergey Biryukov
f9ff030127
I18N: Replace hardcoded file name in a translatable string in `convert_to_screen()` with a placeholder.
...
Props ramiy.
Fixes #41668 .
Built from https://develop.svn.wordpress.org/trunk@41906
git-svn-id: http://core.svn.wordpress.org/trunk@41740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:46:52 +00:00
Sergey Biryukov
82dd23d36f
I18N: Make context for "Schedule" string added in [41898] more accurate.
...
Props ocean90.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@41905
git-svn-id: http://core.svn.wordpress.org/trunk@41739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:39:52 +00:00
Sergey Biryukov
16bee559d4
I18N: Replace hardcoded file name in translatable strings in `wp-admin/setup-config.php` with a placeholder.
...
Props ramiy, danieltj.
Fixes #42161 .
Built from https://develop.svn.wordpress.org/trunk@41904
git-svn-id: http://core.svn.wordpress.org/trunk@41738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:27:53 +00:00
Konstantin Obenland
d8f98b3649
Customize: Unstick filter pane in Theme selector
...
Prevents the filter pane from blocking the view of theme search results when it's open.
Users are now able to just scroll to view results.
Props rclations.
Fixes #42212 .
Built from https://develop.svn.wordpress.org/trunk@41903
git-svn-id: http://core.svn.wordpress.org/trunk@41737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:11:46 +00:00
Sergey Biryukov
ac5096d8bd
Embeds: Avoid "Division by zero" warning in `embed-content.php` template if a thumbnail has a zero height.
...
Props stevenlinx, aegis123.
Fixes #40931 .
Built from https://develop.svn.wordpress.org/trunk@41902
git-svn-id: http://core.svn.wordpress.org/trunk@41736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:09:48 +00:00
Sergey Biryukov
a859b46e92
I18N: Replace function name in error message in `WP_Http_Curl::request()` and `WP_Http_Streams::request()` with a placeholder.
...
Props ramiy.
Fixes #41666 .
Built from https://develop.svn.wordpress.org/trunk@41901
git-svn-id: http://core.svn.wordpress.org/trunk@41735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:04:51 +00:00
Gary Pendergast
a2bd3e23d1
Dashboard: Ensure the "Dismiss" button on the Gutenberg callout is clickable.
...
Who likes z-index? We like z-index!
Props joemcgill.
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41900
git-svn-id: http://core.svn.wordpress.org/trunk@41734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:55:48 +00:00
Konstantin Obenland
261f0d8ef2
Customize: Allow menu creation in locations pane
...
Adds a link to the menu creation workflow from the locations selector in the nav menu control.
Props bpayton, westonruter, Travel_girl, melchoyce, celloexpressions.
Fixes #36279 .
Built from https://develop.svn.wordpress.org/trunk@41899
git-svn-id: http://core.svn.wordpress.org/trunk@41733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:51:47 +00:00
Sergey Biryukov
97bab0459a
I18N: Add a context for "Schedule" string.
...
Props Mirucon.
Fixes #42165 .
Built from https://develop.svn.wordpress.org/trunk@41898
git-svn-id: http://core.svn.wordpress.org/trunk@41732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:45:51 +00:00
Mel Choyce
0c73d35816
Code Editors: Fix display of "help" cursor.
...
Props studionashvegas .
Fixes #42210 .
Built from https://develop.svn.wordpress.org/trunk@41897
git-svn-id: http://core.svn.wordpress.org/trunk@41731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 13:11:49 +00:00
Gary Pendergast
df8ab820ef
Dashboard: Remove a rogue comma introduced in [41895].
...
See #41316 .
Built from https://develop.svn.wordpress.org/trunk@41896
git-svn-id: http://core.svn.wordpress.org/trunk@41730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 12:39:46 +00:00
Gary Pendergast
3981736cd6
Dashboard: Introduce a "Try Gutenberg" callout.
...
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.
Props pento, melchoyce, joen, karmatosed.
Fixes #41316 .
Built from https://develop.svn.wordpress.org/trunk@41895
git-svn-id: http://core.svn.wordpress.org/trunk@41729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 10:04:47 +00:00
Weston Ruter
e914c0447c
Customize: Add missing filter docs in `WP_Customize_Nav_Menu_Item_Setting::sanitize()`.
...
Props dlh.
Fixes #42257 .
Built from https://develop.svn.wordpress.org/trunk@41894
git-svn-id: http://core.svn.wordpress.org/trunk@41728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 04:57:50 +00:00
Weston Ruter
43b4a2577d
Customize: Improve theme browsing UI on small screens.
...
Props Mahvash-Fatima, melchoyce, celloexpressions.
See #37661 .
Fixes #42215 .
Built from https://develop.svn.wordpress.org/trunk@41893
git-svn-id: http://core.svn.wordpress.org/trunk@41727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 04:06:47 +00:00
Weston Ruter
41bb2125b0
Customize: Remove incorrect test assertions for the `post_date` of customization drafts.
...
Amends [41887].
See #42220 .
Built from https://develop.svn.wordpress.org/trunk@41892
git-svn-id: http://core.svn.wordpress.org/trunk@41726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 02:41:49 +00:00
Weston Ruter
b4edf21599
Media: Add missing `mediaelement-migrate.js` script to get uglified.
...
Amends [41877].
See #42189 , #39686 .
Built from https://develop.svn.wordpress.org/trunk@41891
git-svn-id: http://core.svn.wordpress.org/trunk@41725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 02:26:48 +00:00
Weston Ruter
7ee77760af
Widgets: Use a `foreach` loop instead of The Loop to iterate over posts in Recent Posts widget to avoid needing to reset a polluted global `$post`.
...
Props welcher, westonruter.
Amends [14607].
See #12320 .
Fixes #37312 .
Built from https://develop.svn.wordpress.org/trunk@41890
git-svn-id: http://core.svn.wordpress.org/trunk@41724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 00:34:46 +00:00
Weston Ruter
dce5306603
Media: Use user locale as ME.js language in admin and add `mejsL10n` inline script before `mediaelement-core` so WP-exported translation strings are used.
...
See #39686 .
Fixes #42241 .
Built from https://develop.svn.wordpress.org/trunk@41889
git-svn-id: http://core.svn.wordpress.org/trunk@41723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 00:08:45 +00:00
David A. Kennedy
b6539fb5a0
Twenty Seventeen: Fix double bottom-margins below embeds
...
Corrects an issue where both the containing paragraph and embed had bottom margins, causing unwanted extra space.
Props westonruter.
Fixes #42118 .
Built from https://develop.svn.wordpress.org/trunk@41888
git-svn-id: http://core.svn.wordpress.org/trunk@41722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 22:50:51 +00:00
Weston Ruter
bd9d1d9178
Customize: Allow post/page stubs to be edited in WP Admin as "customization drafts" when changeset is saved as draft or scheduled.
...
* Update stubs to have draft status when changeset is saved as draft, instead of preventing auto-draft garbage collection by giving them a far-future `post_date`.
* Show notice in publish metabox when editing a customization draft indicating that it will be published automatically with its changeset; a link to Customizer is included.
* Include a new "Customization Draft" display post state in the post list table.
* Disconnect stubs from their changesets when they are updated with a status other than "Draft".
* Trash customization drafts when their related changeset is trashed or deleted.
* Add a `_customize_changeset_uuid` postmeta to stubs to link them with their associated changeset.
* Include `customize_changeset_uuid` as context when requesting to insert a new auto-draft.
Props westonruter, melchoyce.
See #39896 , #39752 , #34923 .
Fixes #42220 .
Built from https://develop.svn.wordpress.org/trunk@41887
git-svn-id: http://core.svn.wordpress.org/trunk@41721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 20:15:52 +00:00
Weston Ruter
955d5b0ab1
Widgets: Prevent MediaElement.js player from overflowing sidebar in Audio widget.
...
Props bradyvercher.
See #39686 .
Fixes #42244 .
Built from https://develop.svn.wordpress.org/trunk@41886
git-svn-id: http://core.svn.wordpress.org/trunk@41720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 23:02:47 +00:00
Felix Arntz
021afced82
Role/Capability: Prevent a fatal error when checking a language capability early or in the frontend.
...
The meta capabilities `install_languages` and `update_languages` rely on the admin function `wp_can_install_language_pack()`. That function in turn relies on `request_filesystem_credentials()`, so it needs to be ensured that this function is available as well.
Fixes #42230 .
Built from https://develop.svn.wordpress.org/trunk@41885
git-svn-id: http://core.svn.wordpress.org/trunk@41719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:54:57 +00:00
Felix Arntz
3f8621b632
Multisite: Revert [41698] and [41743].
...
In order for `get_site_by()` to be truly beneficial, caching in `WP_Site_Query` needs to be improved to account for common use-cases and have them be invalidated less aggressively.
See #40180 , #40228 , #42091 .
Built from https://develop.svn.wordpress.org/trunk@41884
git-svn-id: http://core.svn.wordpress.org/trunk@41718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:35:47 +00:00
Felix Arntz
18789739c1
Multisite: Revert [41719].
...
While `get_site_by()` makes sense as a more explicit and less complex replacement for `get_blog_details()`, it is not ready yet in terms of caching, where it currently falls short of the older function under specific circumstances.
See #40180 , #40228 .
Built from https://develop.svn.wordpress.org/trunk@41883
git-svn-id: http://core.svn.wordpress.org/trunk@41717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 22:29:48 +00:00
Helen Hou-Sandí
bb66a52a14
Code Editors: Minor style improvements.
...
props melchoyce.
see #42214 .
Built from https://develop.svn.wordpress.org/trunk@41882
git-svn-id: http://core.svn.wordpress.org/trunk@41716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 21:36:48 +00:00
Boone Gorges
af960204b6
Taxonomy: Add note about `$number` inconsistency to `WP_Term_Query` docs.
...
Fixes #41796 .
Built from https://develop.svn.wordpress.org/trunk@41881
git-svn-id: http://core.svn.wordpress.org/trunk@41715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:38:48 +00:00
Boone Gorges
9f73875705
Don't force distinct term queries when specifying `number` and `object_ids`.
...
This reverts [41377], which caused performance problems on sites with a large
number of terms.
See #41796 .
Built from https://develop.svn.wordpress.org/trunk@41880
git-svn-id: http://core.svn.wordpress.org/trunk@41714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:35:47 +00:00
John Blackbourn
24783cfc3e
Media: Allow the unminified mediaelement script to be enqueued when `SCRIPT_DEBUG` is true.
...
Props dsawardekar
Fixes #42229
Built from https://develop.svn.wordpress.org/trunk@41879
git-svn-id: http://core.svn.wordpress.org/trunk@41713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:15:47 +00:00
Andrea Fercia
575e60e96c
Administration: Improve consistency of the "not found" strings.
...
Partially reverts [41608] restoring the original strings without the word `query`.
See #37430 .
Fixes #42231 .
Built from https://develop.svn.wordpress.org/trunk@41878
git-svn-id: http://core.svn.wordpress.org/trunk@41712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:14:48 +00:00
Weston Ruter
2e602a8560
Media: Add MediaElement.js 2.2 back-compat for MediaElement.js 4.2
...
* Introduces `mediaelement-migrate.js`.
* Upgrades ME.js from 4.2.5-74e01a40 to 4.2.6-78496d1.
Props rafa8626, bradyvercher.
See #39686 .
Fixes #42189 .
Built from https://develop.svn.wordpress.org/trunk@41877
git-svn-id: http://core.svn.wordpress.org/trunk@41711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 18:07:52 +00:00
Andrea Fercia
4085a1b266
Accessibility: Improve the File Editors interstitial warning.
...
The warning displayed upon first visit on the File Editors introduced in [41774]
needs to be the only perceivable content in the page for users of assistive
technologies. It looks like a modal but it's not exactly an ARIA dialog, not an
ARIA alert either, and needs some special treatment.
- constrains tabbing within the modal
- uses `wp.a11y.speak()` to make screen readers announce the modal message
- hides all the other page content from assistive technologies using `aria-hidden="true"`
This way, even if users miss the speak message, the warning is actually the only
perceivable content in the page.
Fixes #42110 .
Built from https://develop.svn.wordpress.org/trunk@41876
git-svn-id: http://core.svn.wordpress.org/trunk@41710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 17:59:52 +00:00
Jeremy Felt
e362e61ae5
Multisite: Explicitly globalize global variables in `ms-settings.php`.
...
Explicitly globalize and document `$domain`, `$path`, `$site_id`, and `$public` in `ms-settings.php.
Props csloisel, danielbachhuber.
Fixes #39419 .
Built from https://develop.svn.wordpress.org/trunk@41875
git-svn-id: http://core.svn.wordpress.org/trunk@41709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 17:06:48 +00:00
Sergey Biryukov
a88704d026
Administration: Remove punctuation from the link text in "Site Address" option description.
...
Props Presskopp.
Fixes #42190 .
Built from https://develop.svn.wordpress.org/trunk@41874
git-svn-id: http://core.svn.wordpress.org/trunk@41708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 14:02:50 +00:00