Weston Ruter
7c6534fd4c
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Fixes #33695 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33939
git-svn-id: http://core.svn.wordpress.org/trunk@33908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:59:24 +00:00
Weston Ruter
274373afc6
Customize: Fix clearing of a color control's setting by using proper empty value.
...
Props stevehenty.
Fixes #30280 .
Built from https://develop.svn.wordpress.org/trunk@33938
git-svn-id: http://core.svn.wordpress.org/trunk@33907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:48:23 +00:00
Gary Pendergast
066c30b41e
Readme: Update the recommended PHP version to 5.6.
...
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.
Fixes #33758 .
Built from https://develop.svn.wordpress.org/trunk@33937
git-svn-id: http://core.svn.wordpress.org/trunk@33906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:23:24 +00:00
Dion Hulse
580ca68e26
Cron: Reject events when the provided `$timestamp` is not a valid timestamp.
...
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.
Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423 , Fixes #33475
Built from https://develop.svn.wordpress.org/trunk@33936
git-svn-id: http://core.svn.wordpress.org/trunk@33905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 02:39:23 +00:00
Dion Hulse
36bda54e88
Favicon: Do not specify a `Content-Length: 0` header for our "empty" response to fail more gracefully on environments with extra whitespace on output.
...
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.
Props swissspidy.
Fixes #33626
Built from https://develop.svn.wordpress.org/trunk@33935
git-svn-id: http://core.svn.wordpress.org/trunk@33904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 02:18:26 +00:00
Sergey Biryukov
a3f82f92f1
Widgets: Don't display sidebar description container if it's empty.
...
Props paulwilde.
Fixes #32448 .
Built from https://develop.svn.wordpress.org/trunk@33934
git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 07:59:24 +00:00
Sergey Biryukov
c177344508
Merge two permission error strings.
...
Props pavelevap.
Fixes #33745 .
Built from https://develop.svn.wordpress.org/trunk@33933
git-svn-id: http://core.svn.wordpress.org/trunk@33902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 06:42:26 +00:00
Sergey Biryukov
c65f37f892
Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response.
...
Props extendwings.
Fixes #33753 .
Built from https://develop.svn.wordpress.org/trunk@33932
git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 00:17:24 +00:00
Sergey Biryukov
0424d962e1
Update the parameter docs for `wp_add_post_tags()`, `wp_set_post_tags()`, and `wp_set_post_terms()`.
...
Props johnbillion.
Fixes #33749 .
Built from https://develop.svn.wordpress.org/trunk@33931
git-svn-id: http://core.svn.wordpress.org/trunk@33900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 00:12:26 +00:00
Sergey Biryukov
4b5ef333a0
Correct the docblock for `wp_list_widget_controls()`.
...
Props swissspidy.
Fixes #33751 .
Built from https://develop.svn.wordpress.org/trunk@33930
git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:38:25 +00:00
John Blackbourn
504cd3bf15
Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area.
...
See #25162
Built from https://develop.svn.wordpress.org/trunk@33929
git-svn-id: http://core.svn.wordpress.org/trunk@33898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:25:24 +00:00
Sergey Biryukov
48a41a6663
List tables: Adjust the styles for checkbox column to align better with longer column names.
...
Props swissspidy.
Fixes #32825 .
Built from https://develop.svn.wordpress.org/trunk@33928
git-svn-id: http://core.svn.wordpress.org/trunk@33897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:16:23 +00:00
John Blackbourn
f482b909e6
Introduce a new `$is_edge` global for the Microsoft Edge browser.
...
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.
See #33193
Props gregrickaby, johnbillion
Built from https://develop.svn.wordpress.org/trunk@33927
git-svn-id: http://core.svn.wordpress.org/trunk@33896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 22:33:23 +00:00
Scott Taylor
15b487b097
After [33925], rename the unit test class to `Tests_Comment_Meta_Cache` to avoid collisions on the PHP 5.2 superhighway.
...
See #16894 .
Built from https://develop.svn.wordpress.org/trunk@33926
git-svn-id: http://core.svn.wordpress.org/trunk@33895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 22:30:24 +00:00
Scott Taylor
c231add9fe
In `wp_list_comments()`, update the comment meta cache when the comments derive from `WP_Query` and the new `->comment_meta_cached` prop is `false`.
...
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.
Adds unit tests.
Props wonderboymusic, bradt.
Fixes #16894 .
Built from https://develop.svn.wordpress.org/trunk@33925
git-svn-id: http://core.svn.wordpress.org/trunk@33894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 22:25:24 +00:00
John Blackbourn
3361f90a1c
When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to.
...
See #25162
Built from https://develop.svn.wordpress.org/trunk@33924
git-svn-id: http://core.svn.wordpress.org/trunk@33893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 21:34:24 +00:00
John Blackbourn
bdde0261bc
Bail out early from `esc_url()` if the URL becomes empty after stripping out disallowed characters.
...
Fixes #28015
Props jesin for the unit test
Built from https://develop.svn.wordpress.org/trunk@33923
git-svn-id: http://core.svn.wordpress.org/trunk@33892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 21:29:25 +00:00
John Blackbourn
9e6f9a5d93
Function docs for the `tax_input` and `meta_input` parameters available for `wp_insert_post()`.
...
See #20451
Built from https://develop.svn.wordpress.org/trunk@33922
git-svn-id: http://core.svn.wordpress.org/trunk@33891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 21:02:24 +00:00
Jeremy Felt
af557379da
Multisite: Update help tab text for `site-info.php` to reference "site URL".
...
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.
Fixes #33748 . See #22383 .
Built from https://develop.svn.wordpress.org/trunk@33921
git-svn-id: http://core.svn.wordpress.org/trunk@33890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:53:24 +00:00
John Blackbourn
4d76ce2521
Implement a language chooser on the Network Admin -> Sites -> Add New screen.
...
Props DrewAPicture
Fixes #33528
Built from https://develop.svn.wordpress.org/trunk@33920
git-svn-id: http://core.svn.wordpress.org/trunk@33889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:47:24 +00:00
Sergey Biryukov
695d3ee98b
Merge two strings in `Walker_Comment::comment()` and `Walker_Comment::html5_comment()`.
...
Props pavelevap.
Fixes #33744 .
Built from https://develop.svn.wordpress.org/trunk@33919
git-svn-id: http://core.svn.wordpress.org/trunk@33888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:46:24 +00:00
Jeremy Felt
122862b570
Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action.
...
Props @swissspidy, @MikeHansenMe.
Fixes #32907 .
Built from https://develop.svn.wordpress.org/trunk@33918
git-svn-id: http://core.svn.wordpress.org/trunk@33887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:39:24 +00:00
Scott Taylor
9957d43e13
Bump H3 headings to H2 on the {Term} screens for better accessibility.
...
Props mrahmadawais.
Fixes #33658 .
Built from https://develop.svn.wordpress.org/trunk@33917
git-svn-id: http://core.svn.wordpress.org/trunk@33886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:17:25 +00:00
Scott Taylor
acc7f66cf9
Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33609 .
Built from https://develop.svn.wordpress.org/trunk@33916
git-svn-id: http://core.svn.wordpress.org/trunk@33885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:14:24 +00:00
Scott Taylor
941d65c462
Bump H3 headings to H2 on the Media Settings screen for better accessibility.
...
Props metodiew.
Fixes #33610 .
Built from https://develop.svn.wordpress.org/trunk@33915
git-svn-id: http://core.svn.wordpress.org/trunk@33884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:12:25 +00:00
Scott Taylor
2a3be365e3
Bump H3 headings to H2 on Export screen for better accessibility.
...
Props metodiew.
Fixes #33608 .
Built from https://develop.svn.wordpress.org/trunk@33914
git-svn-id: http://core.svn.wordpress.org/trunk@33883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:09:24 +00:00
Scott Taylor
fd21c92b22
Correct the param docs for `comment_guid()` and `get_comment_guid()`.
...
Props dimadin.
Fixes #32619 .
Built from https://develop.svn.wordpress.org/trunk@33913
git-svn-id: http://core.svn.wordpress.org/trunk@33882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:00:25 +00:00
Scott Taylor
f5c754bfed
Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
...
Props afercia.
Fixes #32866 .
Built from https://develop.svn.wordpress.org/trunk@33912
git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:57:25 +00:00
Scott Taylor
44dace3487
Add Customizer docs.
...
Props ericlewis.
See #33503 .
Built from https://develop.svn.wordpress.org/trunk@33911
git-svn-id: http://core.svn.wordpress.org/trunk@33880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:53:24 +00:00
Scott Taylor
102a8aecf8
Allow `wp_insert_post()` to accept a `meta_input` argument. Devs should use `register_meta()` to ensure that specific values specified by key are sanitized properly.
...
Adds unit test.
Props CoenJacobs, swissspidy.
Fixes #20451 .
Built from https://develop.svn.wordpress.org/trunk@33910
git-svn-id: http://core.svn.wordpress.org/trunk@33879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:50:24 +00:00
Andrea Fercia
47ceb6bb5c
Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens.
...
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].
Fix a typo in the DocBlock for the `additional_capabilities_display` filter.
Props metodiew.
Fixes #33606 . See #31650 .
Built from https://develop.svn.wordpress.org/trunk@33909
git-svn-id: http://core.svn.wordpress.org/trunk@33878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 18:30:24 +00:00
Sergey Biryukov
465e348c12
Fix closing div in `wp_print_request_filesystem_credentials_modal()`.
...
Props trepmal.
Fixes #33737 .
Built from https://develop.svn.wordpress.org/trunk@33908
git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 15:17:24 +00:00
Sergey Biryukov
1e90498102
Update `Tests_Sanitize_Option::test_sanitize_option()` after [33858].
...
See #23605 .
Built from https://develop.svn.wordpress.org/trunk@33907
git-svn-id: http://core.svn.wordpress.org/trunk@33876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 14:18:24 +00:00
Sergey Biryukov
3b2cf952e9
Update `Tests_Admin_includesPlugin::test_menu_page_url()` after [33858].
...
See #23605 .
Built from https://develop.svn.wordpress.org/trunk@33906
git-svn-id: http://core.svn.wordpress.org/trunk@33875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 14:16:24 +00:00
Sergey Biryukov
faaa9b9e98
Update `Tests_Formatting_GetUrlInContent::get_input_output()` after [33858].
...
Props gitlost.
Fixes #23605 .
Built from https://develop.svn.wordpress.org/trunk@33905
git-svn-id: http://core.svn.wordpress.org/trunk@33874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 14:06:26 +00:00
Boone Gorges
cc5eddda74
Allow `wp_terms_checklist()` to return markup rather than echoing it.
...
Props kevinlangleyjr.
Fixes #33720 .
Built from https://develop.svn.wordpress.org/trunk@33904
git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 21:25:25 +00:00
Boone Gorges
45e8bef3cd
In `get_terms()`, allow terms to be ordered by 'term_id'.
...
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.
Props ixkaito.
Fixes #33726 .
Built from https://develop.svn.wordpress.org/trunk@33903
git-svn-id: http://core.svn.wordpress.org/trunk@33872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 21:17:26 +00:00
Sergey Biryukov
f0ce1f06ea
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`.
...
fixes #33685 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33902
git-svn-id: http://core.svn.wordpress.org/trunk@33871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 03:40:25 +00:00
Drew Jaynes
d612c11ab0
Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751].
...
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33901
git-svn-id: http://core.svn.wordpress.org/trunk@33870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:52:24 +00:00
Drew Jaynes
bfe8b01ef2
Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API.
...
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33900
git-svn-id: http://core.svn.wordpress.org/trunk@33869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:47:25 +00:00
Drew Jaynes
f57d7527e6
Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750].
...
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33899
git-svn-id: http://core.svn.wordpress.org/trunk@33868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:42:24 +00:00
Drew Jaynes
a71ee9a0ea
Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750].
...
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33898
git-svn-id: http://core.svn.wordpress.org/trunk@33867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:38:24 +00:00
Drew Jaynes
5cf6c74499
Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.
...
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33897
git-svn-id: http://core.svn.wordpress.org/trunk@33866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:33:24 +00:00
Drew Jaynes
3be117216e
Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749].
...
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33896
git-svn-id: http://core.svn.wordpress.org/trunk@33865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:29:24 +00:00
Drew Jaynes
e1e98b04b9
Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749].
...
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33895
git-svn-id: http://core.svn.wordpress.org/trunk@33864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 01:26:25 +00:00
Scott Taylor
80a20e5c3d
Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table.
...
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291 .
Built from https://develop.svn.wordpress.org/trunk@33894
git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 23:23:24 +00:00
Drew Jaynes
54c2cabf66
Docs: Add complete file, class, property, and method documentation for the new `WP_Comment` class, introduced in [33891].
...
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.
See #32619 .
Built from https://develop.svn.wordpress.org/trunk@33893
git-svn-id: http://core.svn.wordpress.org/trunk@33862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 19:58:24 +00:00
Sergey Biryukov
9ffab31d8f
Add missing translation functions to the error messages added in [33889].
...
props kraftbj, GaryJ.
fixes #33684 .
Built from https://develop.svn.wordpress.org/trunk@33892
git-svn-id: http://core.svn.wordpress.org/trunk@33861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:37:23 +00:00
Scott Taylor
e73ee5ac98
Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
...
* Takes inspiration from `WP_Post` and adds sanity to comment caching.
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now
Props wonderboymusic, nacin.
See #32619 .
Built from https://develop.svn.wordpress.org/trunk@33891
git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Helen Hou-Sandí
89de754f0e
UI: Restrict textarea resizing to vertical to prevent ugliness.
...
props tyxla, MatheusFD.
fixes #33400 .
Built from https://develop.svn.wordpress.org/trunk@33890
git-svn-id: http://core.svn.wordpress.org/trunk@33859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:05:25 +00:00