2c4480958b
Site Health: Introduce Site Health Status dashboard widget.
...
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.
Props Clorith, hedgefield, guddu1315.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47063
git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 13:33:05 +00:00
26ce3c9f19
Cron API: Add a new cron schedule for `weekly` events.
...
Props Clorith.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47062
git-svn-id: http://core.svn.wordpress.org/trunk@46862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 11:20:04 +00:00
f8a5ae6b93
Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.
...
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.
Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242 .
Built from https://develop.svn.wordpress.org/trunk@47061
git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 02:24:03 +00:00
dd4d98a368
Docs: In various `@return` tags, list the expected type first, instead of `false`.
...
Follow-up to [46696].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47060
git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 18:32:05 +00:00
2294d65753
Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables.
...
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.
See #49170 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47059
git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:59:04 +00:00
d469aa8162
Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`.
...
Props pbiron.
Fixes #49170 .
Built from https://develop.svn.wordpress.org/trunk@47058
git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:57:03 +00:00
6a3deacf86
Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`.
...
Props diddledan.
Fixes #48570 .
Built from https://develop.svn.wordpress.org/trunk@47057
git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 02:46:05 +00:00
77aa5d1604
Docs: Remove a reference to WordPress 2.7 from `readme.html`.
...
Props afercia, donmhico.
Fixes #47963 .
Built from https://develop.svn.wordpress.org/trunk@47056
git-svn-id: http://core.svn.wordpress.org/trunk@46856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-10 14:05:05 +00:00
a94ed9baf3
Docs: Remove `@return void` from widget DocBlocks.
...
Per the documentation standards, it should not be used outside of the default bundled themes.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47055
git-svn-id: http://core.svn.wordpress.org/trunk@46855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-10 00:30:05 +00:00
d784ebbcb4
Coding Standards: Use strict comparison and Yoda conditions in the root directory files.
...
Props pikamander2.
Fixes #48965 .
Built from https://develop.svn.wordpress.org/trunk@47054
git-svn-id: http://core.svn.wordpress.org/trunk@46854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-09 00:55:05 +00:00
a24f5ccd1f
Bundled Themes: Remove duplicate `font-size` property in Twenty Twenty.
...
Props ankitmaru.
Fixes #49015 .
Built from https://develop.svn.wordpress.org/trunk@47053
git-svn-id: http://core.svn.wordpress.org/trunk@46853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-08 16:50:04 +00:00
cef48881f0
Docs: Correct alphabetic order of parameters in `WP_Query::parse_query()` DocBlock.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47052
git-svn-id: http://core.svn.wordpress.org/trunk@46852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-08 12:10:04 +00:00
80ce372761
Block Editor: Update WordPress Packages.
...
Updated packages:
@wordpress/annotations: 1.7.2 -> 1.9.0
@wordpress/api-fetch: 3.6.4 -> 3.8.0
@wordpress/block-directory: 1.0.5 -> 1.2.0
@wordpress/block-editor: 3.2.5 -> 3.4.0
@wordpress/block-library: 2.9.6 -> 2.11.0
@wordpress/blocks: 6.7.2 -> 6.9.0
@wordpress/components: 8.3.2 -> 8.5.0
@wordpress/compose: 3.7.2 -> 3.9.0
@wordpress/core-data: 2.7.5 -> 2.9.0
@wordpress/data: 4.9.2 -> 4.11.0
@wordpress/data-controls: 1.3.4 -> 1.5.0
@wordpress/date: 3.5.0 -> 3.7.0
@wordpress/dom: 2.5.2 -> 2.6.0
@wordpress/e2e-test-utils: 3.0.0 -> 4.0.0
@wordpress/edit-post: 3.8.6 -> 3.10.0
@wordpress/editor: 9.7.6 -> 9.9.0
@wordpress/element: 2.8.2 -> 2.10.0
@wordpress/escape-html: 1.5.1 -> 1.6.0
@wordpress/format-library: 1.9.5 -> 1.11.0
@wordpress/i18n: 3.6.1 -> 3.7.0
@wordpress/keycodes: 2.6.2 -> 2.7.0
@wordpress/list-reusable-blocks: 1.8.4 -> 1.10.0
@wordpress/media-utils: 1.2.4 -> 1.4.0
@wordpress/notices: 1.8.2 -> 1.10.0
@wordpress/nux: 3.7.2 -> 3.9.0
@wordpress/plugins: 2.7.2 -> 2.9.0
@wordpress/rich-text: 3.7.2 -> 3.9.0
@wordpress/scripts: 6.0.0 -> 6.1.1
@wordpress/server-side-render: 1.3.4 -> 1.5.0
@wordpress/shortcode: 2.4.1 -> 2.5.0
@wordpress/token-list: 1.6.1 -> 1.8.0
@wordpress/url: 2.8.2 -> 2.9.0
@wordpress/viewport: 2.8.2 -> 2.10.0
Props gziolo, youknowriad.
Fixes #49142 .
Built from https://develop.svn.wordpress.org/trunk@47051
git-svn-id: http://core.svn.wordpress.org/trunk@46851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-08 11:57:23 +00:00
ea6e0cc3ca
Coding Standards: Use Yoda conditions in `wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php`.
...
Props jenilk.
Fixes #49150 .
Built from https://develop.svn.wordpress.org/trunk@47050
git-svn-id: http://core.svn.wordpress.org/trunk@46850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-08 11:32:02 +00:00
967f43a6cb
Docs: Indicate that `load_script_textdomain_relative_path` filter value can be `false`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47049
git-svn-id: http://core.svn.wordpress.org/trunk@46849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-08 00:27:04 +00:00
572f1725d9
Build Tools: do not include assets for JS dependencies that do not exist.
...
This is a follow-up for #48154 , where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.
Props jeherve, swissspidy.
Fixes #49144 .
Built from https://develop.svn.wordpress.org/trunk@47048
git-svn-id: http://core.svn.wordpress.org/trunk@46848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-07 15:28:05 +00:00
d3d630c98a
Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.
...
Props garrett-eclipse.
Fixes #49139 .
Built from https://develop.svn.wordpress.org/trunk@47047
git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-07 00:09:04 +00:00
ce48d7502c
REST API: Display the actual conflicting value in addition to the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property.
...
Follow-up to [47037] and [47045].
Props TimothyBlynJacobs.
See #48401 .
Built from https://develop.svn.wordpress.org/trunk@47046
git-svn-id: http://core.svn.wordpress.org/trunk@46846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 17:09:04 +00:00
a540d748d3
REST API: Display the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property, to match the translator comment.
...
Follow-up to [47037].
See #48401 .
Built from https://develop.svn.wordpress.org/trunk@47045
git-svn-id: http://core.svn.wordpress.org/trunk@46845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 16:47:02 +00:00
28639fc8d5
I18N: Replace `rest_authentication_errors` filter name with a placeholder in a translatable string.
...
Follow-up to [38947] and [40038].
See #38446 .
Built from https://develop.svn.wordpress.org/trunk@47044
git-svn-id: http://core.svn.wordpress.org/trunk@46844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 16:21:04 +00:00
667f26b3af
I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message.
...
Props ramiy.
Fixes #48868 .
Built from https://develop.svn.wordpress.org/trunk@47043
git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 16:16:03 +00:00
918dead27e
Docs: Remove duplicate inline comment in `wp_mail()`.
...
See [5639].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47042
git-svn-id: http://core.svn.wordpress.org/trunk@46842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 14:51:05 +00:00
0be749362a
Docs: Improve documentation for `tests/phpunit/includes/testcase-ajax.php`.
...
Props andizer, SergeyBiryukov.
Fixes #47568 .
Built from https://develop.svn.wordpress.org/trunk@47041
git-svn-id: http://core.svn.wordpress.org/trunk@46841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-05 15:33:00 +00:00
c89dab8c98
Media: After [46375], enable JavaScript translations for the `media-views` script.
...
See #49134 .
Built from https://develop.svn.wordpress.org/trunk@47040
git-svn-id: http://core.svn.wordpress.org/trunk@46840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-05 13:11:04 +00:00
6a3a0b519c
Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description.
...
Props mukesh27.
Fixes #49131 .
Built from https://develop.svn.wordpress.org/trunk@47039
git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-04 18:00:06 +00:00
7ad56f1237
Coding Standards: Add missing braces to `if` conditions in `js/_enqueues/wp/customize/base.js`.
...
Props ankitmaru.
Fixes #49122 .
Built from https://develop.svn.wordpress.org/trunk@47038
git-svn-id: http://core.svn.wordpress.org/trunk@46838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-04 01:28:05 +00:00
08f53ef906
REST API: Issue doing_it_wrong if a taxonomy's specified rest_base is already in use by a different resource.
...
Props fgiannar, TimothyBlynJacobs, kingkool68, SergeyBiryukov.
Fixes #48401 .
Built from https://develop.svn.wordpress.org/trunk@47037
git-svn-id: http://core.svn.wordpress.org/trunk@46837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 19:24:03 +00:00
7660fcda61
REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist.
...
Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238 .
Built from https://develop.svn.wordpress.org/trunk@47036
git-svn-id: http://core.svn.wordpress.org/trunk@46836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 18:44:03 +00:00
355c05ea71
Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build.
...
This patch integrates DependencyExtractionWebpackPlugin which was battle-tested in Gutenberg.
This will greatly simplify the process of upgrading npm packages which change after every Gutenberg release. It might even useful during the WordPress release cycle as we might need to publish more often as we discover critical bugs and regressions.
Props jonsurrell, adamsilverstein, youknowriad, ocean90, netweb.
Fixes #48154 .
Built from https://develop.svn.wordpress.org/trunk@47035
git-svn-id: http://core.svn.wordpress.org/trunk@46835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 13:17:24 +00:00
9bec6f1e54
REST API: Synchronize permission checks in `::get_items_permissions_check()` methods for post types, post statuses, and users:
...
* Only query post types with `'show_in_rest' => true` instead of looping over all post types and checking the `show_in_rest` property separately.
* Return from the `foreach()` loop as soon as the permission check succeeded.
Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #49118 .
Built from https://develop.svn.wordpress.org/trunk@47034
git-svn-id: http://core.svn.wordpress.org/trunk@46834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 02:28:03 +00:00
ba033e96ef
Link Manager: Use a strict `in_array()` check in `wp-links-opml.php`.
...
Props dkarfa.
Fixes #49106 .
Built from https://develop.svn.wordpress.org/trunk@47033
git-svn-id: http://core.svn.wordpress.org/trunk@46833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 01:14:02 +00:00
523bf256ef
Docs: Synchronize "Default empty array" notes for `$args` parameter in `get_comment_text()` and `comment_text()`.
...
Props denisco.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47032
git-svn-id: http://core.svn.wordpress.org/trunk@46832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 19:22:03 +00:00
8ec3da8a25
Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`.
...
Props nickylimjj.
Fixes #49112 .
Built from https://develop.svn.wordpress.org/trunk@47031
git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 12:11:02 +00:00
9571033894
Coding Standards: Move assignment out of condition in `js/media/controllers/library.js`.
...
Props ankitmaru.
Fixes #49108 .
Built from https://develop.svn.wordpress.org/trunk@47030
git-svn-id: http://core.svn.wordpress.org/trunk@46830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 12:07:02 +00:00
d3a14b7719
Coding Standards: Move assignment out of condition in `js/media/views/settings.js`.
...
Props ankitmaru.
Fixes #49107 .
Built from https://develop.svn.wordpress.org/trunk@47029
git-svn-id: http://core.svn.wordpress.org/trunk@46829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 12:02:02 +00:00
f2e464f8c1
Coding Standards: Use strict comparison in `wp-comments-post.php`.
...
Props dkarfa.
Fixes #49105 .
Built from https://develop.svn.wordpress.org/trunk@47028
git-svn-id: http://core.svn.wordpress.org/trunk@46828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 11:42:01 +00:00
b9353dbf70
Coding Standards: Use strict comparison and Yoda conditions in `wp-includes/widgets.php`.
...
Props jenilk.
Fixes #49104 .
Built from https://develop.svn.wordpress.org/trunk@47027
git-svn-id: http://core.svn.wordpress.org/trunk@46827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 11:37:05 +00:00
3fe8bdfca7
Happy New Year!
...
Update copyright year to 2020 in bundled themes' `readme.txt`.
Built from https://develop.svn.wordpress.org/trunk@47026
git-svn-id: http://core.svn.wordpress.org/trunk@46826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-01 03:53:01 +00:00
c856ffcd0a
Happy New Year!
...
Update copyright year to 2020 in `license.txt`.
Built from https://develop.svn.wordpress.org/trunk@47025
git-svn-id: http://core.svn.wordpress.org/trunk@46825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-01 02:19:06 +00:00
6357cae029
Docs: Fix typo in `_crop_image_resource()` DocBlock.
...
Props mukesh27.
Fixes #49103 .
Built from https://develop.svn.wordpress.org/trunk@47024
git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-31 12:34:01 +00:00
a2f5c24d36
Docs: Add missing descriptions and `@return` tags for `_WP_Editors::get_mce_locale()` and `::get_baseurl()`.
...
Props adnan.limdi.
Fixes #41869 .
Built from https://develop.svn.wordpress.org/trunk@47023
git-svn-id: http://core.svn.wordpress.org/trunk@46823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-31 01:31:02 +00:00
7174c2a0c7
Docs: Add missing `@since` tags for `wp-includes/class-wp-editor.php`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47022
git-svn-id: http://core.svn.wordpress.org/trunk@46822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-31 01:25:03 +00:00
09e7a72ec2
Docs: Fix typo in `.env` file description.
...
Props mujuonly, dkarfa.
Fixes #49095 .
Built from https://develop.svn.wordpress.org/trunk@47021
git-svn-id: http://core.svn.wordpress.org/trunk@46821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-30 13:48:03 +00:00
fef26f8d1f
Coding Standards: Fix WPCS issue in [47019].
...
See #49091 .
Built from https://develop.svn.wordpress.org/trunk@47020
git-svn-id: http://core.svn.wordpress.org/trunk@46820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-29 22:32:00 +00:00
7590296984
Twenty Twenty: Remove extra space from `arrow-down-circled` icon name in `TwentyTwenty_SVG_Icons::$ui_icons`.
...
Props kitchin.
Fixes #49091 .
Built from https://develop.svn.wordpress.org/trunk@47019
git-svn-id: http://core.svn.wordpress.org/trunk@46819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-29 20:45:06 +00:00
d858656023
Bootstrap/Load: Make handling the `/favicon.ico` requests more flexible.
...
Previously, `wp_favicon_request()` was introduced in [13205] to avoid a performance hit of serving a full 404 page on every favicon request.
While working as intended, that implementation did not provide a way for theme or plugin authors to manage the behavior of favicon requests.
This changeset implements the following logic (only applied if WordPress is installed in the root directory):
* If there is a Site Icon set in Customizer, redirect `/favicon.ico` requests to that icon.
* Otherwise, use the WordPress logo as a default icon.
* If a physical `/favicon.ico` file exists, do nothing, let the server handle the request.
Handling `/favicon.ico` is now more consistent with handling `/robots.txt` requests.
New functions and hooks:
* Introduce `is_favicon()` conditional tag to complement `is_robots()`.
* Introduce `do_favicon` action to complement `do_robots` and use it in template loader.
* Introduce `do_favicon()` function, hooked to the above action by default, to complement `do_robots()`.
* Introduce `do_faviconico` action to complement `do_robotstxt`, for plugins to override the default behavior.
* Mark `wp_favicon_request()` as deprecated in favor of `do_favicon()`.
Props jonoaldersonwp, birgire, joostdevalk, mukesh27, SergeyBiryukov.
Fixes #47398 .
Built from https://develop.svn.wordpress.org/trunk@47018
git-svn-id: http://core.svn.wordpress.org/trunk@46818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-28 21:20:04 +00:00
c546aa36ec
Docs: Improve `@return` description for `wp_update_comment()` and `WP_UnitTest_Factory_For_Comment::update_object()`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47017
git-svn-id: http://core.svn.wordpress.org/trunk@46817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-27 00:30:02 +00:00
7970e62c06
Coding Standards: Fix WPCS issue in [47015].
...
See #49082 .
Built from https://develop.svn.wordpress.org/trunk@47016
git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 15:53:02 +00:00
7c2275dfe4
Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation.
...
Props mukesh27.
Fixes #49082 .
Built from https://develop.svn.wordpress.org/trunk@47015
git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 14:42:03 +00:00
a814d6e363
Tests: Set `network_id` instead of `site_id` in `WP_UnitTest_Factory_For_Blog` defaults.
...
Follow-up to [47011], [47013].
See #47195 .
Built from https://develop.svn.wordpress.org/trunk@47014
git-svn-id: http://core.svn.wordpress.org/trunk@46814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 00:27:03 +00:00
5e236248e4
Tests: Update legacy arguments passed to `WP_UnitTest_Factory_For_Blog::create_object()`.
...
This converts the arguments originally meant for `wpmu_create_blog()` to the ones used by `wp_insert_site()`.
Follow-up to [47011].
Fixes #47195 .
Built from https://develop.svn.wordpress.org/trunk@47013
git-svn-id: http://core.svn.wordpress.org/trunk@46813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-25 21:41:02 +00:00
cf54349cb7
Tests: Replace most instances of `wpmu_delete_blog()` not specifically testing that function with `wp_delete_site()`.
...
Follow-up to [47011].
See #47195 .
Built from https://develop.svn.wordpress.org/trunk@47012
git-svn-id: http://core.svn.wordpress.org/trunk@46812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-25 18:17:01 +00:00
e2231ec703
Tests: Switch `WP_UnitTest_Factory_For_Blog::create_object()` to use `wp_insert_site()`.
...
Map some arguments for backward compatibility with `wpmu_create_blog()` previously used there.
Props davidbaumwald, danielbachhuber, jeremyfelt, SergeyBiryukov.
See #47195 .
Built from https://develop.svn.wordpress.org/trunk@47011
git-svn-id: http://core.svn.wordpress.org/trunk@46811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-25 18:12:02 +00:00
8990cf9296
Media: Make sure `attachment_url_to_postid()` performs a case-sensitive search for the uploaded file name.
...
Previously, the first available match was returned, regardless of the case, which was not always the expected result.
Props archon810, ben.greeley, tristangemus, vsamoletov, SergeyBiryukov.
Fixes #39768 .
Built from https://develop.svn.wordpress.org/trunk@47010
git-svn-id: http://core.svn.wordpress.org/trunk@46810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-25 02:26:03 +00:00
8073fd3ec0
Docs: Use a third-person singular verb for comment template function descriptions, per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47009
git-svn-id: http://core.svn.wordpress.org/trunk@46809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-24 16:19:01 +00:00
9c68816a21
Docs: Improve documentation for `get_comment_author_url()`.
...
Props stevenlinx.
Fixes #49076 .
Built from https://develop.svn.wordpress.org/trunk@47008
git-svn-id: http://core.svn.wordpress.org/trunk@46808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-24 16:10:05 +00:00
bb70f4e530
Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description.
...
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.
Follow-up to [39064].
Props tomgreer, knutsp, crdunst.
See #49056 .
Built from https://develop.svn.wordpress.org/trunk@47007
git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 18:00:02 +00:00
246a035d99
Docs: Improve documentation for admin menu functions:
...
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`
Add missing descriptions and `@since` tags.
Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253 , #49067 .
Built from https://develop.svn.wordpress.org/trunk@47006
git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 14:36:04 +00:00
f501814eac
Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions.
...
Props rcutmore, dd32, i3anaan.
Fixes #40572 .
Built from https://develop.svn.wordpress.org/trunk@47005
git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-22 02:45:03 +00:00
9b3a895631
Shortcodes: Introduce `apply_shortcodes()` as an alias for `do_shortcode()`.
...
This better aligns with the semantics of applying filters to the input and returning a result, rather than performing an action and outputting to the current buffer.
Props ljasinskipl, thefarlilacfield.
Fixes #37422 .
Built from https://develop.svn.wordpress.org/trunk@47004
git-svn-id: http://core.svn.wordpress.org/trunk@46804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-21 20:12:03 +00:00
5e8fe89ef5
Shortcodes: Make sure `wp.shortcode.string()` accepts the `attrs` array keys in any order.
...
Props yale01, georgestephanis, adamsilverstein, zsusag, mircoraffinetti, SergeyBiryukov.
Fixes #36263 .
Built from https://develop.svn.wordpress.org/trunk@47003
git-svn-id: http://core.svn.wordpress.org/trunk@46803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-21 18:34:04 +00:00
27d9bac051
Administration: Add `doing_wp_cron` to `wp_removable_query_args()`.
...
It's a single-use URL parameter that does not need to be passed to canonical URLs in the admin.
Props dlh.
Fixes #49017 .
Built from https://develop.svn.wordpress.org/trunk@47002
git-svn-id: http://core.svn.wordpress.org/trunk@46802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-21 16:14:04 +00:00
7b70f584a7
Tests: Don't fail the test in `WP_UnitTestCase_Base::skipOnAutomatedBranches()` if Travis environment variables are unavailable, it prevents from running the test locally.
...
Follow-up to [47000].
See #49050 .
Built from https://develop.svn.wordpress.org/trunk@47001
git-svn-id: http://core.svn.wordpress.org/trunk@46801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-20 12:15:04 +00:00
01b91b2a0f
Tests: Correct the check for pull requests in `WP_UnitTestCase_Base::skipOnAutomatedBranches()`.
...
Mark the test as failed if the environment variables are unavailable.
Fixes #49050 .
Built from https://develop.svn.wordpress.org/trunk@47000
git-svn-id: http://core.svn.wordpress.org/trunk@46800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-20 01:12:01 +00:00
a5deda7083
Build/Test Tools: Pass the `TRAVIS_BRANCH` and `TRAVIS_PULL_REQUEST` environment variables along to the Docker container.
...
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables.
See #49050 , #47767 .
Built from https://develop.svn.wordpress.org/trunk@46999
git-svn-id: http://core.svn.wordpress.org/trunk@46799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-20 00:03:01 +00:00
d391a2633c
Tests: Skip external HTTP test for recommended PHP and MySQL versions on 503 errors.
...
Fixes #49049 .
Built from https://develop.svn.wordpress.org/trunk@46998
git-svn-id: http://core.svn.wordpress.org/trunk@46798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-19 20:29:01 +00:00
464615e876
Editor: Add unit tests for v5.3.1 block serialization functions
...
r46896 was intended to have included unit tests for the block serialization functions added as part of the changeset.
Props: @aduth.
Fixes : #49048
Built from https://develop.svn.wordpress.org/trunk@46997
git-svn-id: http://core.svn.wordpress.org/trunk@46797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-19 18:50:01 +00:00
5d5bf01d12
Tests: In `test_readme()`, if the HTTP request to `secure.php.net` or `dev.mysql.com` failed, include response code in the error message.
...
See #40533 , #44613 .
Built from https://develop.svn.wordpress.org/trunk@46996
git-svn-id: http://core.svn.wordpress.org/trunk@46796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-19 15:45:05 +00:00
c677634788
Tests: Remove unused cache keys from `data_get_site_caches()`.
...
Follow-up to [46990].
See #40363 .
Built from https://develop.svn.wordpress.org/trunk@46991
git-svn-id: http://core.svn.wordpress.org/trunk@46791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 03:22:02 +00:00
5f6a36ceb6
Networks and Sites: Remove invalidation of unused cache keys in `clean_blog_cache()`.
...
Props spacedmonkey, flixos90, thamaraiselvam.
Fixes #40363 .
Built from https://develop.svn.wordpress.org/trunk@46990
git-svn-id: http://core.svn.wordpress.org/trunk@46790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 02:59:02 +00:00
4edec193bc
Users: When creating the first user on installation, populate the Website profile field with the site URL.
...
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.
Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778 .
Built from https://develop.svn.wordpress.org/trunk@46989
git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 02:26:03 +00:00
694913d65f
I18N: Make the minimum input length to start searching posts in the "Insert/edit link" modal localizable.
...
Props Toro_Unit, birgire, miyauchi, swissspidy, ocean90.
Fixes #44662 .
Built from https://develop.svn.wordpress.org/trunk@46988
git-svn-id: http://core.svn.wordpress.org/trunk@46788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 01:15:03 +00:00
6e7080036f
Docs: Improve comments in `tests/formatting/redirect.php` per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46987
git-svn-id: http://core.svn.wordpress.org/trunk@46787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 00:28:01 +00:00
8c709ed78c
Docs: Add `@method` notation for `WP_UnitTest_Factory_For_Term::create_and_get()` for consistency with other factories.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46986
git-svn-id: http://core.svn.wordpress.org/trunk@46786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 00:26:02 +00:00
396647666f
Docs: Various documentation fixes for unit test factories.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46985
git-svn-id: http://core.svn.wordpress.org/trunk@46785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 00:19:02 +00:00
2cf3fb14ee
Tests: Use delta comparison in `test_should_fall_back_to_last_post_modified()` to avoid race conditions.
...
See #48957 .
Built from https://develop.svn.wordpress.org/trunk@46981
git-svn-id: http://core.svn.wordpress.org/trunk@46781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 21:33:02 +00:00
6403619f92
Upload: Run the final file name collision test in `wp_unique_filename()` for each existing file + 1.
...
Props pbiron.
See #48975 .
Built from https://develop.svn.wordpress.org/trunk@46976
git-svn-id: http://core.svn.wordpress.org/trunk@46776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 20:52:03 +00:00
da041582df
Date/Time: Ensure that `get_feed_build_date()` correctly handles a modified post object with invalid date.
...
* Clarify in the documentation that the function returns `false` on failure.
* Consistently pass the return value through the `get_feed_build_date` filter.
Props Rarst, dd32, azaozz, tellyworth.
Fixes #48957 .
Built from https://develop.svn.wordpress.org/trunk@46974
git-svn-id: http://core.svn.wordpress.org/trunk@46774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 20:43:03 +00:00
8eb278d19a
Docs: Clarify that `get_lastpostdate()` and `get_lastpostmodified()` can return `false` on failure.
...
The both use `_get_last_post_time()` internally.
Props Rarst.
See #48957 .
Built from https://develop.svn.wordpress.org/trunk@46973
git-svn-id: http://core.svn.wordpress.org/trunk@46773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 20:26:01 +00:00
bbd898b1dd
Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`.
...
Props adnan.limdi.
Fixes #41970 .
Built from https://develop.svn.wordpress.org/trunk@46972
git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 16:45:03 +00:00
d273235abd
Login/Registration: Pass the error data to the `wp_login_failed` action.
...
Props hamedmoodi, rixeo.
Fixes #49007 .
Built from https://develop.svn.wordpress.org/trunk@46971
git-svn-id: http://core.svn.wordpress.org/trunk@46771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 15:36:01 +00:00
a79636f82a
Docs: Correct `@type` for `timeout` argument in `WP_Http::request()`.
...
Props georgestephanis, benedictsinger.
Fixes #49005 .
Built from https://develop.svn.wordpress.org/trunk@46970
git-svn-id: http://core.svn.wordpress.org/trunk@46770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 15:25:01 +00:00
18b0cd4f7d
Date/Time: Add a unit test for [46968].
...
See #48145 .
Built from https://develop.svn.wordpress.org/trunk@46969
git-svn-id: http://core.svn.wordpress.org/trunk@46769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 14:37:02 +00:00
c0b6dffffc
Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use a proper delta comparison.
...
[3525] allowed a difference up to 59 seconds between the post date/time and the current time to consider the post published instead of scheduled, but that didn't take start of a new minute into account.
Rapidly creating post fixtures in unit tests could encounter a one-second discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s' )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`, respectively, and setting the post to a `future` status instead of `publish`.
[45851], while working as intended, made the issue somewhat more likely to occur.
This caused all sorts of occasional random failures in various tests on Travis, mostly on PHP 7.1.
Fixes #48145 .
Built from https://develop.svn.wordpress.org/trunk@46968
git-svn-id: http://core.svn.wordpress.org/trunk@46768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 02:25:03 +00:00
c67c3ee6a0
Fix the colors in all color schemes for the `.active` class for buttons.
...
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967
git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 00:15:03 +00:00
ef7326129f
Upload: Fix the final file name collision test in `wp_unique_filename()` when uploading a file with upper case extension. Add a unit test to catch that in the future.
...
Fixes #48975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46966
git-svn-id: http://core.svn.wordpress.org/trunk@46766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 23:44:04 +00:00
e0ace80488
Upload:
...
- Fix PHP warnings in `wp_unique_filename()` when the destination directory is unreadable.
- Run the final name collision test only for files that are saved to the uploads directory.
- Update the unit tests to match.
Props eden159, audrasjb, azaozz.
Fixes #48960 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46965
git-svn-id: http://core.svn.wordpress.org/trunk@46765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 23:23:06 +00:00
8894c0f1a2
Coding Standards: Use strict comparison in `wp-admin/widgets.php`.
...
Props jenilk.
Fixes #49000 .
Built from https://develop.svn.wordpress.org/trunk@46964
git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:55:03 +00:00
5b9fd2d7e7
Coding Standards: Use strict comparison in `wp-admin/includes/network.php`.
...
Props ataurr.
Fixes #48994 .
Built from https://develop.svn.wordpress.org/trunk@46963
git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:37:06 +00:00
6d40400756
Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`.
...
Props passoniate.
Fixes #48985 .
Built from https://develop.svn.wordpress.org/trunk@46962
git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 10:46:02 +00:00
087282e810
Coding Standards: Use strict comparison in `wp-admin/term.php`.
...
Props vinita29.
Fixes #48983 .
Built from https://develop.svn.wordpress.org/trunk@46961
git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 09:45:01 +00:00
35b29f11b3
Coding Standards: Add missing braces to `if` conditions in `js/_enqueues/wp/util.js`.
...
Props ankitmaru.
Fixes #48980 .
Built from https://develop.svn.wordpress.org/trunk@46960
git-svn-id: http://core.svn.wordpress.org/trunk@46760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 08:45:05 +00:00
1b675c6e4a
Formatting: Return early from `wp_kses_attr_check()` if the element is not in the list of allowed elements and attributes.
...
Props krynes, tristanleboss.
Fixes #48549 .
Built from https://develop.svn.wordpress.org/trunk@46959
git-svn-id: http://core.svn.wordpress.org/trunk@46759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-14 15:53:06 +00:00
8260786e64
Docs: Clarify descriptions for `get_gmt_from_date()` and `get_date_from_gmt()`.
...
Props johnbillion, Rarst.
Fixes #48650 .
Built from https://develop.svn.wordpress.org/trunk@46958
git-svn-id: http://core.svn.wordpress.org/trunk@46757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 21:45:02 +00:00
0b8438a6d2
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
...
Props ramiy.
Fixes #48863 .
Built from https://develop.svn.wordpress.org/trunk@46957
git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 21:27:05 +00:00
48692b6524
Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1.
...
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.
Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944 .
Built from https://develop.svn.wordpress.org/trunk@46902
git-svn-id: http://core.svn.wordpress.org/trunk@46702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:26:03 +00:00
317465e2fe
Prevent stored XSS in the block editor.
...
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.
Props: aduth, epiqueras,
Built from https://develop.svn.wordpress.org/trunk@46896
git-svn-id: http://core.svn.wordpress.org/trunk@46696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:02:03 +00:00
84e4c8531a
Update `wp_kses_bad_protocol()` to recognize `:` on uri attributes,
...
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.
Props: xknown, nickdaugherty, peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@46895
git-svn-id: http://core.svn.wordpress.org/trunk@46695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 17:55:05 +00:00
80eab318eb
Prevent stored XSS through wp_targeted_link_rel().
...
Props: vortfu, whyisjake, peterwilsoncc, xknown, SergeyBiryukov, flaviozavan.
Built from https://develop.svn.wordpress.org/trunk@46894
git-svn-id: http://core.svn.wordpress.org/trunk@46694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 17:54:02 +00:00
9e87c5b7b4
Ensure that a user can publish_posts before making a post sticky.
...
Props: danielbachhuber, whyisjake, peterwilson, xknown.
Built from https://develop.svn.wordpress.org/trunk@46893
git-svn-id: http://core.svn.wordpress.org/trunk@46693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 17:52:02 +00:00
99f11a6af2
Docs: Update description for `get_categories()` to avoid suggesting the deprecated `type` argument.
...
Follow-up to [13754].
Props dingo_d.
Fixes #48913 .
Built from https://develop.svn.wordpress.org/trunk@46891
git-svn-id: http://core.svn.wordpress.org/trunk@46691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 16:47:05 +00:00
db18e7d50b
Upgrade/Install: Improve the appearance of language selection on install:
...
* Remove a stray chevron.
* Improve focus and hover styles.
Props garrett-eclipse, audrasjb.
Fixes #48927 .
Built from https://develop.svn.wordpress.org/trunk@46887
git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:03:03 +00:00
c87fccd74f
Comments: Avoid a PHP notice in `comment_form()` if the `email` field is not set.
...
Follow-up to [46090].
Props mat-lipe.
Fixes #48943 .
Built from https://develop.svn.wordpress.org/trunk@46885
git-svn-id: http://core.svn.wordpress.org/trunk@46685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 22:14:02 +00:00
eb38423e22
Fixes in `admin-bar.js`:
...
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.
Props dinhtungdu, azaozz.
Fixes #47069 .
Built from https://develop.svn.wordpress.org/trunk@46883
git-svn-id: http://core.svn.wordpress.org/trunk@46683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 18:56:03 +00:00
f8964463c1
Tests: Docs: Correct `@param` formatting in `SpeedTrapListener` after [35226] and [45607].
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46882
git-svn-id: http://core.svn.wordpress.org/trunk@46682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 15:48:03 +00:00
c48b359227
Tests: Correct the `slowThreshold` option name for `SpeedTrapListener`.
...
The previous change in [45607] appears to be accidental.
Props Rarst.
Fixes #48933 .
Built from https://develop.svn.wordpress.org/trunk@46881
git-svn-id: http://core.svn.wordpress.org/trunk@46681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 15:42:06 +00:00
9b91ffde04
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
...
Props grapplerulrich.
Fixes #48932 .
Built from https://develop.svn.wordpress.org/trunk@46880
git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 10:59:05 +00:00
b639963d7a
TinyMCE: remove CSS map reference from `/tinymce/skins/lightgray/skin.min.css`.
...
Props AlexHolsgrove.
Fixes #48577 .
Built from https://develop.svn.wordpress.org/trunk@46879
git-svn-id: http://core.svn.wordpress.org/trunk@46679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 18:33:05 +00:00
aa919cd160
Comments: Optimize the query for pending comments count in `wp_notify_moderator()` for better performance on large tables.
...
Props sgoen.
Fixes #48514 .
Built from https://develop.svn.wordpress.org/trunk@46878
git-svn-id: http://core.svn.wordpress.org/trunk@46678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 13:47:00 +00:00
ee58f3f3d3
Coding Standards: Fix WPCS and JSHint issues in [46872].
...
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46874
git-svn-id: http://core.svn.wordpress.org/trunk@46674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:34:01 +00:00
d617011afd
Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package.
...
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069 .
Built from https://develop.svn.wordpress.org/trunk@46872
git-svn-id: http://core.svn.wordpress.org/trunk@46672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:03:02 +00:00
0524d9b781
Block Editor: Resolve `@wordpress/block-directory` to the expected version, 1.0.6.
...
Follow-up to [46860].
Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884 .
Built from https://develop.svn.wordpress.org/trunk@46870
git-svn-id: http://core.svn.wordpress.org/trunk@46670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 22:29:08 +00:00
6ddf02b188
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
...
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599 .
Built from https://develop.svn.wordpress.org/trunk@46868
git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 21:03:02 +00:00
a209908501
Administration: Standardize form control height and alignment across the admin.
...
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.
Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420 .
Built from https://develop.svn.wordpress.org/trunk@46866
git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:26:03 +00:00
1dcf3eef7a
Date/Time: XML-RPC: Сalculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.
...
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.
Add unit tests.
Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429 .
Built from https://develop.svn.wordpress.org/trunk@46864
git-svn-id: http://core.svn.wordpress.org/trunk@46664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 19:56:05 +00:00
098273f1d3
Date/Time: When determining whether to decline the month name in `wp_maybe_decline_date()`, take word boundaries into account.
...
Add more unit tests.
Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606 .
Built from https://develop.svn.wordpress.org/trunk@46862
git-svn-id: http://core.svn.wordpress.org/trunk@46662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 18:50:06 +00:00
a227c231a2
Block Editor: Bug fixes targeted for WordPress 5.3.1.
...
The list of included fixes:
- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591
Updated packages:
- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5
Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884 .
Built from https://develop.svn.wordpress.org/trunk@46860
git-svn-id: http://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 17:37:10 +00:00
d4ef90b236
Upgrade/Install: Update sodium_compat to v1.12.1.
...
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.
Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371 .
Built from https://develop.svn.wordpress.org/trunk@46858
git-svn-id: http://core.svn.wordpress.org/trunk@46658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:42:04 +00:00
dd47d5aa81
Media: Use consistent width for Scale and Crop inputs.
...
Follow-up to [46359].
Props sabernhardt, audrasjb.
Fixes #48907 .
Built from https://develop.svn.wordpress.org/trunk@46856
git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:23:02 +00:00
303180b392
Twenty Twenty: Adjust the comment in [46851] per the documentation standards.
...
See #48876 .
Built from https://develop.svn.wordpress.org/trunk@46854
git-svn-id: http://core.svn.wordpress.org/trunk@46654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:18:02 +00:00
9648c368f0
Help/About: Add a hover effect for links on About pages.
...
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.
Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582 .
Built from https://develop.svn.wordpress.org/trunk@46852
git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:31:05 +00:00
48fbea17d6
Bundled Themes: Misaligned input placeholder text Twenty Twenty.
...
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.
Props aljullu, subratamal.
Fixes #48876 .
Built from https://develop.svn.wordpress.org/trunk@46851
git-svn-id: http://core.svn.wordpress.org/trunk@46651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:10:00 +00:00
35985cbf38
Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`.
...
Props acosmin.
Fixes #48918 .
Built from https://develop.svn.wordpress.org/trunk@46849
git-svn-id: http://core.svn.wordpress.org/trunk@46649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:00:01 +00:00
dcf0cb68a2
Administration: Correct checkbox width in list tables on smaller screens.
...
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.
Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815 .
Built from https://develop.svn.wordpress.org/trunk@46845
git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:26:02 +00:00
b051b9a0d4
Bundled Themes: Make checkbox in comment form larger Twenty Twenty.
...
This makes the checkbox in the comment form larger and more consistent with other checkboxes.
Props kharisblank, audrasjb.
Fixes #48652 .
Built from https://develop.svn.wordpress.org/trunk@46844
git-svn-id: http://core.svn.wordpress.org/trunk@46644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:08:03 +00:00
ac690426eb
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
...
This ensures that the actual UI controls state matches the visually conveyed state.
Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409 .
Built from https://develop.svn.wordpress.org/trunk@46842
git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:49:03 +00:00
23f45f0346
Twenty Twenty: Correct alignment for embedded Instagram posts.
...
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688 .
Built from https://develop.svn.wordpress.org/trunk@46840
git-svn-id: http://core.svn.wordpress.org/trunk@46640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:39:03 +00:00
87a759b81c
Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen.
...
Props desrosj, birgire.
Fixes #48334 .
Built from https://develop.svn.wordpress.org/trunk@46838
git-svn-id: http://core.svn.wordpress.org/trunk@46638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:26:02 +00:00
adf1792adc
Docs: Correct DocBlock formatting for `admin_email_confirm` and `admin_email_confirm_form` hooks.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46837
git-svn-id: http://core.svn.wordpress.org/trunk@46637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:10:01 +00:00
4b333de597
Tests: Change `group` annotation for `test_unique_filename_with_dimension_like_filename()` to `ticket.
...
See #42437 .
Built from https://develop.svn.wordpress.org/trunk@46835
git-svn-id: http://core.svn.wordpress.org/trunk@46635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 12:18:01 +00:00
6c49066de7
Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
...
Props msaari, SergeyBiryukov.
Fixes #48906 .
Built from https://develop.svn.wordpress.org/trunk@46832
git-svn-id: http://core.svn.wordpress.org/trunk@46632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 11:49:02 +00:00
8da965a5b8
Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value.
...
See #48145 .
Built from https://develop.svn.wordpress.org/trunk@46831
git-svn-id: http://core.svn.wordpress.org/trunk@46631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 11:31:01 +00:00
e70c88213f
Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected.
...
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.
See #48145 .
Built from https://develop.svn.wordpress.org/trunk@46830
git-svn-id: http://core.svn.wordpress.org/trunk@46630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 10:41:05 +00:00
860fc16954
Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible.
...
See #30017 , #48145 .
Built from https://develop.svn.wordpress.org/trunk@46829
git-svn-id: http://core.svn.wordpress.org/trunk@46629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-08 18:02:07 +00:00
f11d28a779
Twenty Twenty: Use duplicate hook references for `page_css_class` and `page_menu_link_attributes` filters in `TwentyTwenty_Walker_Page`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46828
git-svn-id: http://core.svn.wordpress.org/trunk@46628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 14:03:03 +00:00
6677070a13
Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
...
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46827
git-svn-id: http://core.svn.wordpress.org/trunk@46627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:56:06 +00:00
d53103ed62
Docs: Further docblock corrections and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826
git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:23:01 +00:00
0f971e68ec
Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
...
The JS implementation had multiple issues and did not work as expected.
This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns
Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763 , #48551 , #48866 .
Built from https://develop.svn.wordpress.org/trunk@46824
git-svn-id: http://core.svn.wordpress.org/trunk@46624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 11:05:01 +00:00
f93ee2ca76
Docs: Increase the specificity of various docblock parameter types and return types.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823
git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:43:04 +00:00
15a566edef
Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests.
...
Props Viper007Bond, pbiron, azaozz.
Fixes #42437 .
Built from https://develop.svn.wordpress.org/trunk@46822
git-svn-id: http://core.svn.wordpress.org/trunk@46622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:28:00 +00:00
aa1fdcbd52
Docs: Correct various docblocks documentation.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821
git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:23:04 +00:00
7d84502589
Text Changes: Rename Comment Blacklist option to be more inclusive
...
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.
Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900 .
Built from https://develop.svn.wordpress.org/trunk@46820
git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 18:12:02 +00:00
c375d23ef5
Tests: Remove duplicate `test_get_page_by_path_priority()` test.
...
The test was moved into its own file in [37478], but never removed from its previous location.
See #36711 .
Built from https://develop.svn.wordpress.org/trunk@46819
git-svn-id: http://core.svn.wordpress.org/trunk@46619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 17:27:05 +00:00
2165eef44c
Accessibility: Administration: Correct active button color for the alternative color schemes.
...
Follow-up to [46815].
Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598 .
Built from https://develop.svn.wordpress.org/trunk@46817
git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:12:03 +00:00
20e18613d0
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
...
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585 .
Built from https://develop.svn.wordpress.org/trunk@46815
git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:32:03 +00:00
23abf27b1a
XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency.
...
Props ramiy, SergeyBiryukov.
Fixes #48883 .
Built from https://develop.svn.wordpress.org/trunk@46814
git-svn-id: http://core.svn.wordpress.org/trunk@46614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 13:48:03 +00:00
8d6912dd27
Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.
...
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.
Props williampatton, nielslange acosmin, dlh.
Fixes #48550 .
Built from https://develop.svn.wordpress.org/trunk@46813
git-svn-id: http://core.svn.wordpress.org/trunk@46613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-04 15:59:03 +00:00
38ad319fdf
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
...
Props ramiy.
Fixes #48875 .
Built from https://develop.svn.wordpress.org/trunk@46812
git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-04 10:36:01 +00:00
a5e52e04ee
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
...
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.
Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857 .
Built from https://develop.svn.wordpress.org/trunk@46811
git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-03 13:58:05 +00:00
6d1ed93c91
Taxonomy: Remove redundant caching from `get_all_category_ids()`, deprecated in favor of `get_terms()` in [28679].
...
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.
Props itowhid06, johnjamesjacoby.
Fixes #48176 .
Built from https://develop.svn.wordpress.org/trunk@46810
git-svn-id: http://core.svn.wordpress.org/trunk@46610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-02 14:49:01 +00:00
135e608b46
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
...
Fixes #48736 .
Built from https://develop.svn.wordpress.org/trunk@46809
git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-01 18:26:05 +00:00
221287f626
Widgets: Remove `WP_Widget_Factory::$hashed_class_counts` property, unused since [46220].
...
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].
See #48074 .
Built from https://develop.svn.wordpress.org/trunk@46808
git-svn-id: http://core.svn.wordpress.org/trunk@46608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-01 12:13:01 +00:00
0221a593b9
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
...
Props donmhico, jeremyfelt.
Fixes #48799 .
Built from https://develop.svn.wordpress.org/trunk@46807
git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-30 00:42:01 +00:00
585af17b7c
Tests: Merge [24251] from `_wp_filter_build_unique_id()` to `_test_filter_build_unique_id()`, for consistency.
...
See #47407 .
Built from https://develop.svn.wordpress.org/trunk@46806
git-svn-id: http://core.svn.wordpress.org/trunk@46606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:17:01 +00:00
3047531f6a
Plugins: In `_wp_filter_build_unique_id()`, remove `$wp_filter` global and `$filter_id_count` static variable, unused since [46220].
...
See #47407 , #48074 .
Built from https://develop.svn.wordpress.org/trunk@46805
git-svn-id: http://core.svn.wordpress.org/trunk@46605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:14:01 +00:00
1d1c74385f
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
...
See #48839 .
Built from https://develop.svn.wordpress.org/trunk@46804
git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:04:02 +00:00
86c441140b
REST API: Use a strict `in_array()` check in `WP_REST_Request::get_parameter_order()`.
...
See #48839 .
Built from https://develop.svn.wordpress.org/trunk@46803
git-svn-id: http://core.svn.wordpress.org/trunk@46603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:01:03 +00:00
d33571f7d5
REST API: Use a strict `in_array()` check in `WP_REST_Meta_Fields::get_registered_fields()`.
...
Props dkarfa.
Fixes #48839 .
Built from https://develop.svn.wordpress.org/trunk@46802
git-svn-id: http://core.svn.wordpress.org/trunk@46602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 21:59:03 +00:00
49401759f3
Docs: Correct `@param` type for the function parameter in `tests_add_filter()` and `_test_filter_build_unique_id()`.
...
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.
Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.
Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407 . See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46801
git-svn-id: http://core.svn.wordpress.org/trunk@46601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 21:42:01 +00:00
2a0489ec49
Docs: Replace `@returns` tags in JS docs with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46800
git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
4a4afbd68c
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
...
Props shital-patel, kalpshit.
Fixes #48305 .
Built from https://develop.svn.wordpress.org/trunk@46799
git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 16:56:02 +00:00
acd0a3ca99
Site Health: Add a test for PHP default timezone.
...
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692 .
Built from https://develop.svn.wordpress.org/trunk@46797
git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:48:03 +00:00
9d14355bf5
Date/Time: Make `get_permalink()` more resilient against PHP timezone changes.
...
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.
Add a unit test.
Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623 .
Built from https://develop.svn.wordpress.org/trunk@46795
git-svn-id: http://core.svn.wordpress.org/trunk@46595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 13:42:00 +00:00
7acfab22b8
KSES: Add support for gradient backgrounds.
...
Props jorgefilipecosta.
Fixes #48376 .
Built from https://develop.svn.wordpress.org/trunk@46793
git-svn-id: http://core.svn.wordpress.org/trunk@46593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 00:29:02 +00:00
0aef4faacd
Plugins: Correct default value of `$replacement` parameter in `do_action_deprecated()` and `apply_filters_deprecated()`.
...
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.
Props shaampk1, felipeelia.
Fixes #48817 .
Built from https://develop.svn.wordpress.org/trunk@46792
git-svn-id: http://core.svn.wordpress.org/trunk@46592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 23:55:01 +00:00
6f86cedb09
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
Built from https://develop.svn.wordpress.org/trunk@46791
git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 19:51:01 +00:00
d8b251f0af
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
Built from https://develop.svn.wordpress.org/trunk@46790
git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 16:52:02 +00:00
e2c2fb64bf
Users: Display admin email verification screen in user's locale instead of site locale.
...
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313 .
Built from https://develop.svn.wordpress.org/trunk@46788
git-svn-id: http://core.svn.wordpress.org/trunk@46588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 14:35:02 +00:00
c74c8cf5f1
Bundled Themes: Fixes JS TypeError in Twenty Twenty.
...
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.
Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601 .
Built from https://develop.svn.wordpress.org/trunk@46786
git-svn-id: http://core.svn.wordpress.org/trunk@46586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 18:21:03 +00:00
5af0c2989b
Tests: Add `feed` group for `get_feed_build_date()` test added in [46756].
...
See #48675 .
Built from https://develop.svn.wordpress.org/trunk@46785
git-svn-id: http://core.svn.wordpress.org/trunk@46585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 16:19:03 +00:00
f4165a697d
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
Built from https://develop.svn.wordpress.org/trunk@46784
git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 15:19:04 +00:00
63fefb540a
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
Built from https://develop.svn.wordpress.org/trunk@46782
git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:01:03 +00:00
e0830ac7bc
Options, Meta APIs: Update `@since` version for the `$force_cache` parameter added for `wp_load_alloptions()` in [46753] to 5.3.1.
...
See #31245 .
Built from https://develop.svn.wordpress.org/trunk@46779
git-svn-id: http://core.svn.wordpress.org/trunk@46579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 13:44:02 +00:00
012ddf095a
Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta.
...
Props Mte90, jrf, hareesh-pillai.
Fixes #48324 .
Built from https://develop.svn.wordpress.org/trunk@46772
git-svn-id: http://core.svn.wordpress.org/trunk@46572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:07:02 +00:00
2a85fe21d8
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
Built from https://develop.svn.wordpress.org/trunk@46770
git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 19:57:05 +00:00
a1ad168857
Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`.
...
Props manikmist09.
Fixes #48624 .
Built from https://develop.svn.wordpress.org/trunk@46765
git-svn-id: http://core.svn.wordpress.org/trunk@46565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 10:55:02 +00:00
c786eaa1df
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
Built from https://develop.svn.wordpress.org/trunk@46764
git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 19:21:03 +00:00
26a750e162
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
Built from https://develop.svn.wordpress.org/trunk@46763
git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 18:51:01 +00:00
0b5f3acd9f
Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
...
Props nielslange, Anlino.
Fixes #48619 .
Built from https://develop.svn.wordpress.org/trunk@46762
git-svn-id: http://core.svn.wordpress.org/trunk@46562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 14:54:04 +00:00
8e9c4a116a
Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
...
Props audrasjb, youknowriad.
Fixes #48696 .
Built from https://develop.svn.wordpress.org/trunk@46761
git-svn-id: http://core.svn.wordpress.org/trunk@46561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 10:15:03 +00:00
58aa1cc8c5
Docs: Adjust `wp_is_json_request()` and `wp_is_xml_request()` return value descriptions for consistency.
...
See #48771 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@46760
git-svn-id: http://core.svn.wordpress.org/trunk@46560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 18:28:04 +00:00
597b22c99c
Docs: Correct spelling and capitalization in `wp-includes/load.php`:
...
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.
Props stevegrunwell.
Fixes #48771 .
Built from https://develop.svn.wordpress.org/trunk@46759
git-svn-id: http://core.svn.wordpress.org/trunk@46559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 18:16:03 +00:00
56af5db74f
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
Built from https://develop.svn.wordpress.org/trunk@46758
git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 00:04:02 +00:00
882be65f94
Date/Time: Correct the time format in `get_feed_build_date()` to use 24-hour format.
...
Follow-up to [46756].
See #48675 .
Built from https://develop.svn.wordpress.org/trunk@46757
git-svn-id: http://core.svn.wordpress.org/trunk@46557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 16:27:03 +00:00
d13ce45ff6
Date/Time: Remove `mysql2date()` usage in `get_feed_build_date()` to ensure the output includes correct timezone offset.
...
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.
Add a unit test.
Props Rarst, lisota.
Fixes #48675 .
Built from https://develop.svn.wordpress.org/trunk@46756
git-svn-id: http://core.svn.wordpress.org/trunk@46556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 13:18:00 +00:00
44d5372825
I18N: Correct translator comment for `By %s` string in Plugins list table.
...
Follow-up to [44541].
See #45898 .
Built from https://develop.svn.wordpress.org/trunk@46755
git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 00:08:02 +00:00
d5434d7cc7
Customize: If the return URL for Close button is a page added to the Appearance menu by a deactivated theme, fall back to the Themes screen.
...
Props JarretC, Jean-David, SergeyBiryukov.
Fixes #46686 .
Built from https://develop.svn.wordpress.org/trunk@46754
git-svn-id: http://core.svn.wordpress.org/trunk@46554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 18:49:03 +00:00
285d38bd83
Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes.
...
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.
This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.
Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
See #31245 .
Built from https://develop.svn.wordpress.org/trunk@46753
git-svn-id: http://core.svn.wordpress.org/trunk@46553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 13:42:03 +00:00
b0a0f62727
Docs: Fix typo in `README.md`.
...
Props dkarfa.
Fixes #48737 .
Built from https://develop.svn.wordpress.org/trunk@46752
git-svn-id: http://core.svn.wordpress.org/trunk@46552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 08:33:01 +00:00
cca5c825ed
Docs: Clarify that `WP_Theme::get()`, `::display()`, and several related methods treat the `Tags` theme header as an array.
...
Props david.binda.
Fixes #48005 .
Built from https://develop.svn.wordpress.org/trunk@46751
git-svn-id: http://core.svn.wordpress.org/trunk@46551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 08:31:03 +00:00
8e4b0c2c45
XML-RPC: Pass correct variable as the URL parameter to `http_headers_useragent` filter in `wp_xmlrpc_server::pingback_ping()`.
...
Props wpgurudev, andreaitm.
Fixes #48721 . See #42186 .
Built from https://develop.svn.wordpress.org/trunk@46750
git-svn-id: http://core.svn.wordpress.org/trunk@46550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-19 11:07:03 +00:00
a6cecef42f
Login and Registration: Pass `$user_data` parameter to the `lostpassword_post` action in `retrieve_password()`.
...
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334 .
Built from https://develop.svn.wordpress.org/trunk@46749
git-svn-id: http://core.svn.wordpress.org/trunk@46549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-19 10:01:04 +00:00
c0950c1d50
Accessibility: Media: Add an `aria-pressed` attribute to active button within a button group.
...
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".
Fixes #48355 .
Built from https://develop.svn.wordpress.org/trunk@46748
git-svn-id: http://core.svn.wordpress.org/trunk@46548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 22:23:03 +00:00
06ab7e3f6b
Twenty Twenty: Fix typos in a variable name and inline comment in `assets/js/color-calculations.js`.
...
Props tanvirul.
Fixes #48704 .
Built from https://develop.svn.wordpress.org/trunk@46747
git-svn-id: http://core.svn.wordpress.org/trunk@46547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 17:07:01 +00:00
71725aeb95
Accessibility: Add an `aria-current` attribute to the Media Library switch links.
...
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Fixes #48271 .
Built from https://develop.svn.wordpress.org/trunk@46746
git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:51:02 +00:00
eec579dd86
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
...
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169 .
Props dufresnesteven.
See #43169 .
Fixes #48588 .
Built from https://develop.svn.wordpress.org/trunk@46745
git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:23:02 +00:00
306045277e
Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`.
...
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.
Props manikmist09.
Fixes #48629 .
Built from https://develop.svn.wordpress.org/trunk@46744
git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 13:18:03 +00:00
f32831bf6d
Taxonomy: Correct the initial value for `WP_Taxonomy::$labels` to match `get_taxonomy_labels()` return type.
...
Improve documentation for consistency with `WP_Post_Type::$labels`.
Props alpipego.
Fixes #48681 .
Built from https://develop.svn.wordpress.org/trunk@46743
git-svn-id: http://core.svn.wordpress.org/trunk@46543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 07:58:59 +00:00
5aa3a51264
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
96e163473e
Docs: Update broken source code link in `imgAreaSelect` jQuery plugin.
...
Props mryoga, finchps.
See #48467 .
Built from https://develop.svn.wordpress.org/trunk@46741
git-svn-id: http://core.svn.wordpress.org/trunk@46541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:14:03 +00:00
Sergey Biryukov
desrosj
jorgefilipecosta
gziolo
Dominik Schilling
K. Adam White
whyisjake
Andrew Ozz
ianbelanger
John Blackbourn
Aaron Jorbin
Andrea Fercia