Commit Graph

27845 Commits

Author SHA1 Message Date
Boone Gorges 8b18debcd0 Clean up 'post-thumbnail' theme support unit tests.
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].

See #18548.
Built from https://develop.svn.wordpress.org/trunk@30148


git-svn-id: http://core.svn.wordpress.org/trunk@30148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:01:21 +00:00
Lance Willett df455aa106 Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
Props slobodanmanic, fixes #28703.

Built from https://develop.svn.wordpress.org/trunk@30147


git-svn-id: http://core.svn.wordpress.org/trunk@30147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:47:21 +00:00
Lance Willett c604fd15b0 Twenty Fourteen: fix keyboard focus on Appearance > Header view.
Props florianziegler, fixes #29787.

Built from https://develop.svn.wordpress.org/trunk@30146


git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett 609335eef1 Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
Props kraftbj, fixes #30026.

Built from https://develop.svn.wordpress.org/trunk@30145


git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:40:25 +00:00
Boone Gorges c07582cb64 Improve default argument formatting in `WP_Date_Query::__construct()`.
Built from https://develop.svn.wordpress.org/trunk@30144


git-svn-id: http://core.svn.wordpress.org/trunk@30144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:29:21 +00:00
Lance Willett 6ddbf3c8bd Twenty Fourteen: Make featured content in Customizer contextual to the front page.
Props celloexpressions, fixes #29578.

Built from https://develop.svn.wordpress.org/trunk@30143


git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Boone Gorges 92536aae65 Introduced `dayofweek_iso` time param for `WP_Date_Query`.
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.

Props mboynes.
Fixes #28063.
Built from https://develop.svn.wordpress.org/trunk@30142


git-svn-id: http://core.svn.wordpress.org/trunk@30142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:24:21 +00:00
Boone Gorges 96b42c2fdc Allow resource_type to be specified in `get_ancestors()`.
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.
Built from https://develop.svn.wordpress.org/trunk@30141


git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:58:23 +00:00
Boone Gorges c27548265e Pass all updated meta IDs to filters in `update_metadata()`.
Props wonderboymusic.
Fixes #11683.
Built from https://develop.svn.wordpress.org/trunk@30140


git-svn-id: http://core.svn.wordpress.org/trunk@30140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:39:24 +00:00
Scott Taylor 65ab0a188e In `wp_xmlrpc_server->pingback_ping()`, remove the internal variable `$way` each time it is set and not used.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30139


git-svn-id: http://core.svn.wordpress.org/trunk@30139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:50:21 +00:00
Scott Taylor 4f6745e9aa In `wp_xmlrpc_server` methods, don't set `$blog_id` internally if it is never used, which is almost always. Updates the docs.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30138


git-svn-id: http://core.svn.wordpress.org/trunk@30138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:44:23 +00:00
Scott Taylor 0d3270282d In `wp_xmlrpc_server->_prepare_comment()`, `$comment_date` is set internally but never used.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30137


git-svn-id: http://core.svn.wordpress.org/trunk@30137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:29:24 +00:00
Scott Taylor fcbc7b5a78 In `Custom_Image_Header->step_2()`, `$type` is set internally but never used.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30136


git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:24:22 +00:00
Scott Taylor 02f3c92b39 Fix failing unit tests after [30096]: use `assertEqualSets()`.
Built from https://develop.svn.wordpress.org/trunk@30135


git-svn-id: http://core.svn.wordpress.org/trunk@30135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:44 +00:00
Boone Gorges e9f6ee53bb Fix database schema update introduced in [30121].
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30134


git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:22 +00:00
Scott Taylor 8d0e8942eb [28785] introduced a bug, where encoded query arguments were decoded by `parse_str()` inside of `wp_parse_str()` but never re-encoded later on.
This encodes them, adds unit test.

Props obenland.
Fixes #29636.

Built from https://develop.svn.wordpress.org/trunk@30133


git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:54:23 +00:00
Scott Taylor c19b3d1740 Fix unit test for video shortcode after [30082].
Fixes #30078.

Built from https://develop.svn.wordpress.org/trunk@30132


git-svn-id: http://core.svn.wordpress.org/trunk@30132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:49:21 +00:00
Scott Taylor 29deacc30c Revisions modules should not rely on global settings:
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.

Built from https://develop.svn.wordpress.org/trunk@30131


git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor d1d93b7cda Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
Props ericlewis.
Fixes #30218.

Built from https://develop.svn.wordpress.org/trunk@30130


git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor a4963672d6 Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`.
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.

Built from https://develop.svn.wordpress.org/trunk@30129


git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:15:24 +00:00
Scott Taylor 7cbb7552da Allow revision Backbone classes to be used on pages other than `revision.php`.
Props ericlewis.
Fixes #30221.

Built from https://develop.svn.wordpress.org/trunk@30128


git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor f1634f7c8f Add some JSDoc blocks to `revisions.js`.
Props ericlewis.
See #30222.


Built from https://develop.svn.wordpress.org/trunk@30127


git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling 461507452a Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.

props westonruter.
fixes #30031.
Built from https://develop.svn.wordpress.org/trunk@30126


git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Scott Taylor 7eefc4d1e1 JSHint after [30124].
Built from https://develop.svn.wordpress.org/trunk@30125


git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor a6cb067481 JSHint after [30120].
Built from https://develop.svn.wordpress.org/trunk@30124


git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling 2e76a697f6 Fix JSHint errors introduced in [30120].
see #30193.
Built from https://develop.svn.wordpress.org/trunk@30123


git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Drew Jaynes 66c47f29bb Correct references of `@uses $wpdb` in core documentation to use `@global`.
See #30191, [30105].
Fixes #30217.

Built from https://develop.svn.wordpress.org/trunk@30122


git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
Boone Gorges 70631df84a Bump db_version and add upgrade routine for schema change in [30056].
Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30121


git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 16:03:22 +00:00
Scott Taylor 999e0fbd99 Add verbose docs to `media-views.js`.
Props ericlewis.
See #30193.

Built from https://develop.svn.wordpress.org/trunk@30120


git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Drew Jaynes e8f68802c6 Correct two parameter types in the `wp_save_post_revision_check_for_changes` hook documentation.
Props johnbillion.
Fixes #30185.

Built from https://develop.svn.wordpress.org/trunk@30119


git-svn-id: http://core.svn.wordpress.org/trunk@30119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 23:50:22 +00:00
Boone Gorges 6745b8a870 Move `term_exists()` tests to their own file.
Built from https://develop.svn.wordpress.org/trunk@30118


git-svn-id: http://core.svn.wordpress.org/trunk@30118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:53:22 +00:00
Sergey Biryukov 94fa6e1615 Use correct file name in a hook comment.
props wedi.
fixes #30200.
Built from https://develop.svn.wordpress.org/trunk@30117


git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Sergey Biryukov b823b2f3c1 Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
fixes #30137.
Built from https://develop.svn.wordpress.org/trunk@30116


git-svn-id: http://core.svn.wordpress.org/trunk@30116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 11:57:22 +00:00
Boone Gorges 93ae51e801 Unserialize `get_metadata()` results when 'key' is omitted.
Props mattkeys, nacin.
Fixes #15030.
Built from https://develop.svn.wordpress.org/trunk@30115


git-svn-id: http://core.svn.wordpress.org/trunk@30115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 10:25:22 +00:00
Jeremy Felt 909aa4f1e7 Improve tests for domain_exists()
* Split existing tests for `domain_exists()` into many smaller tests.
* Make slightly fewer, more accurate assertions.
* Remove unnecessary site creation via factory.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30114


git-svn-id: http://core.svn.wordpress.org/trunk@30114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 05:44:23 +00:00
Boone Gorges caf4fec1f7 Streamline some `get_terms()` cache tests.
* Split large method into a number of smaller tests.
* Create fewer fixtures.

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30113


git-svn-id: http://core.svn.wordpress.org/trunk@30113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:16:22 +00:00
Boone Gorges 08ef5b6ec9 Clean up cache invalidation suspension global in unit tests.
This fixes a test that was introduced in [30073] which was polluting later
tests.

See #21760.
Built from https://develop.svn.wordpress.org/trunk@30112


git-svn-id: http://core.svn.wordpress.org/trunk@30112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:15:23 +00:00
Drew Jaynes 39a44f62ad Update the changelogs for the comment hook parameters added in [30092].
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.

Built from https://develop.svn.wordpress.org/trunk@30111


git-svn-id: http://core.svn.wordpress.org/trunk@30111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:52:22 +00:00
Drew Jaynes 8fcc2b3dc8 Update the changelog for `WP_Comment_Query::query()` to reflect two more new arguments added in [30096].
[30096] introduced the `type__in` and `type__not_in` arguments. See #30111 for documentation on those new arguments.

Fixes #12668.

Built from https://develop.svn.wordpress.org/trunk@30110


git-svn-id: http://core.svn.wordpress.org/trunk@30110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:06:24 +00:00
Drew Jaynes 54020268f7 Update the changelog for `get_approved_comments()` to reflect that the function was refactored to leverage `WP_Comment_Query` in [30098].
Also updates the `$args` parameter description with a reference to see `WP_Comment_Query` for argument information.

See #12668.

Built from https://develop.svn.wordpress.org/trunk@30109


git-svn-id: http://core.svn.wordpress.org/trunk@30109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:51:23 +00:00
Boone Gorges af026330c4 Clean up `get_term_by()` caching.
* Fix cache key/group modification that was missed in [30073].
* Update unit tests to reflect new key/group format.

Props tollmanz.
Fixes #21760.
Built from https://develop.svn.wordpress.org/trunk@30108


git-svn-id: http://core.svn.wordpress.org/trunk@30108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:50:23 +00:00
Boone Gorges 47742eae12 In `get_terms()`, do not override 'hierarchical' and 'pad_counts' when 'parent' is present.
The previous behavior resulted in descendant terms being improperly excluded
from the results when passing a 'parent', even when 'hierarchical' had been
set to true.

The patch also adds unit tests that demonstrate the various interactions
between the 'child_of', 'parent', and 'hierarchical' parameters of `get_terms()`.

Props landakram.
Fixes #29815.
Built from https://develop.svn.wordpress.org/trunk@30107


git-svn-id: http://core.svn.wordpress.org/trunk@30107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:12:22 +00:00
Jeremy Felt 3dcf418545 Expand tests around wpmu_delete_blog()
* Test cache after a site is deleted or flagged as deleted.
* Test tables after a site is deleted or flagged as deleted.
* Test tables and cache after the main site is deleted.
* Test site count after a site is deleted or flagged as deleted.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30106


git-svn-id: http://core.svn.wordpress.org/trunk@30106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:00:22 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Dominik Schilling 00845a6c3d Customizer: Fix missing newly added widgets in the preview after [29905].
props westonruter.
fixes #29983.
Built from https://develop.svn.wordpress.org/trunk@30104


git-svn-id: http://core.svn.wordpress.org/trunk@30104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:57:23 +00:00
Ian Stewart 27b88c350a Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.
See #30137.

Built from https://develop.svn.wordpress.org/trunk@30103


git-svn-id: http://core.svn.wordpress.org/trunk@30103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:52:22 +00:00
Dominik Schilling 3c962ee5d8 Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.

https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.

props westonruter, celloexpressions, ryankienstra.
see #28032, #28579, #28580, #28650, #28709, #29758.
fixes #29529.


Built from https://develop.svn.wordpress.org/trunk@30102


git-svn-id: http://core.svn.wordpress.org/trunk@30102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:51:22 +00:00
Mark Jaquith 63cf4db8ae Fix weird HiDPI screen rendering issue with theme install preview toolbar
fixes #28898
props ocean90
Built from https://develop.svn.wordpress.org/trunk@30101


git-svn-id: http://core.svn.wordpress.org/trunk@30101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:36:21 +00:00
Dominik Schilling 4df00e156d Improve body class for page templates.
* Convert slash to dash too.
* Add sub-folder name as a separate body class.
* New classes are additional classes, old syntax will persists for BC.

With this `/page-templates/full-width.php` will produce `page-template`, `page-template-page-templates`, `page-template-full-width` and `page-template-page-templatesfull-width-php`.

props obenland, Caspie, donutz.
fixes #23470.
Built from https://develop.svn.wordpress.org/trunk@30100


git-svn-id: http://core.svn.wordpress.org/trunk@30100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:20:23 +00:00
Ian Stewart 76876654ac Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress
Props iamtakashi, fixes #30137.


Built from https://develop.svn.wordpress.org/trunk@30099


git-svn-id: http://core.svn.wordpress.org/trunk@30099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:14:22 +00:00