WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
35,327 Commits 50 Branches 749 Tags 983 MiB
Commit Graph

955 Commits

Author SHA1 Message Date
Helen Hou-Sandí 5a07e4bba4 Add "Scheduled" to post states. 
props rclations.
fixes #32131.

Built from https://develop.svn.wordpress.org/trunk@32902


git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 16:07:26 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Scott Taylor a51dfa3971 In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`: 
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 17:04:26 +00:00
Scott Taylor 19a3aacc94 Add `@static*` annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:43:29 +00:00
Scott Taylor 282e28ad81 Add `@global` annotations to (the rest of the?) `wp-admin/*` files. 
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:06:31 +00:00
Gary Pendergast e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard. 
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-20 07:39:25 +00:00
Sergey Biryukov 247fdbfe19 Remove hidden `user_id` input from `wp_comment_reply()`. 
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31999


git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-03 13:28:26 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible. 
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 22:06:28 +00:00
Andrew Ozz f5e6f92174 Do not output empty name and id HTML attributes in get_submit_button(). 
Props afercia. Fixes #31749.
Built from https://develop.svn.wordpress.org/trunk@31880


git-svn-id: http://core.svn.wordpress.org/trunk@31859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 03:23:27 +00:00
Andrew Ozz 805c530cf0 PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form. 
Part prop: Michael-Arestad. Fixes #31443.
Built from https://develop.svn.wordpress.org/trunk@31765


git-svn-id: http://core.svn.wordpress.org/trunk@31745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-13 16:57:26 +00:00
Helen Hou-Sandí df08581656 List tables: Display front and posts page indicators. 
fixes #30190.

Built from https://develop.svn.wordpress.org/trunk@31610


git-svn-id: http://core.svn.wordpress.org/trunk@31591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-04 19:45:25 +00:00
Drew Jaynes 0b3c3092fc Clean up and refine DocBlocks for a variety of functions and methods in wp-admin/includes/template.php. 
* Also documents the default arguments of `wp_terms_checklist()` as a hash notation.

Props ipm-frommen, DrewAPicture.
Fixes #31248.

Built from https://develop.svn.wordpress.org/trunk@31599


git-svn-id: http://core.svn.wordpress.org/trunk@31580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-02 06:11:40 +00:00
Drew Jaynes a337c34c4e Fix a typo in the `$args` parameter hash notation description for `add_settings_field()`. 
See #28975, [31592].

Built from https://develop.svn.wordpress.org/trunk@31593


git-svn-id: http://core.svn.wordpress.org/trunk@31574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-01 07:57:32 +00:00
Drew Jaynes 82fd5e33dd Add a hash notation for the optional `$args` parameter in `add_settings_field()`, which includes a description for the new `$class` argument added in [31560]. 
Also adds a changelog entry to `add_settings_field()` DocBlock for the new `$class` argument.

See [31560].
Fixes #28975.

Built from https://develop.svn.wordpress.org/trunk@31592


git-svn-id: http://core.svn.wordpress.org/trunk@31573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-01 07:53:25 +00:00
Helen Hou-Sandí b95d99d1c1 Settings API: Allow passing a class to `add_settings_field()` via the `$args` array. 
While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168.

props valendesigns.
fixes #28975. see #30168.

Built from https://develop.svn.wordpress.org/trunk@31560


git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 19:59:25 +00:00
Drew Jaynes 50bb433c66 Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference. 
See #17470.

Built from https://develop.svn.wordpress.org/trunk@31551


git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 03:08:28 +00:00
Helen Hou-Sandí ae3baa7c5b Hide irrelevant UI and display a message when editing the page for posts. 
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.

Built from https://develop.svn.wordpress.org/trunk@31550


git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-26 02:47:25 +00:00
Sergey Biryukov 7b9d981a54 Use correct default values for some admin template functions. 
props ipm-frommen.
fixes #31308.
Built from https://develop.svn.wordpress.org/trunk@31446


git-svn-id: http://core.svn.wordpress.org/trunk@31427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 06:51:25 +00:00
Sergey Biryukov 5a0b01edf1 Rename unused argument and remove obsolete global in `iframe_header()`. 
props ipm-frommen.
fixes #31309.
Built from https://develop.svn.wordpress.org/trunk@31443


git-svn-id: http://core.svn.wordpress.org/trunk@31424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 05:31:26 +00:00
Sergey Biryukov 268d79cb77 `_list_meta_row()` should always return a string. 
props ipm-frommen.
fixes #31310.
Built from https://develop.svn.wordpress.org/trunk@31442


git-svn-id: http://core.svn.wordpress.org/trunk@31423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 04:22:26 +00:00
Sergey Biryukov 43583a1b9e Terminate JS statements in two admin files. 
props ipm-frommen.
fixes #31311.
Built from https://develop.svn.wordpress.org/trunk@31440


git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-13 04:09:27 +00:00
Scott Taylor 7f8b548df1 In HTML5, the `action` attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 04:16:24 +00:00
Scott Taylor fe6b5983df In PHP 5.0.0, `is_a()` became deprecated in favour of the `instanceof` operator. Calling `is_a()` would result in an `E_STRICT` warning. 
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.

Built from https://develop.svn.wordpress.org/trunk@31188


git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:06:24 +00:00
Helen Hou-Sandí 62a197d6bf List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

Built from https://develop.svn.wordpress.org/trunk@31181


git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 22:14:22 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Scott Taylor af0e5cc851 Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments. 
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 05:46:25 +00:00
Scott Taylor 5e4941023b `WP_List_Table`'s constructor registers an `'admin_footer'` callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when `wp_comment_reply()` invokes the class constructor without checking for the existing instance via the `$wp_list_table` global. 
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.

Built from https://develop.svn.wordpress.org/trunk@31019


git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 19:55:35 +00:00
Scott Taylor 786caa4d55 Correct the `@param` docs for arguments that are truthy/falsey. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30983


git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 23:04:23 +00:00
Scott Taylor 5eb5afac34 For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30982


git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 22:47:22 +00:00
Andrew Nacin 8c3027c3c7 Call it 'Distraction-free writing mode' and update the help string. fixes #30657. 
Built from https://develop.svn.wordpress.org/trunk@30890


git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-16 10:07:23 +00:00
Andrew Ozz bb67aa9d5a Improve text for the DFW admin pointer. Remove the concatenation. 
Props kpdesign, ianmjones.
See #30671.
Built from https://develop.svn.wordpress.org/trunk@30837


git-svn-id: http://core.svn.wordpress.org/trunk@30827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-12 22:12:22 +00:00
John Blackbourn bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference. 
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:32:24 +00:00
Andrew Ozz 5299e95360 Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30730


git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:18:23 +00:00
Andrew Ozz 71d0c1c977 Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30717


git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 23:11:24 +00:00
Andrew Ozz f1dcfa9712 Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568. 
Built from https://develop.svn.wordpress.org/trunk@30711


git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 20:40:22 +00:00
Drew Jaynes ad297dab6d Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.

Built from https://develop.svn.wordpress.org/trunk@30695


git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 00:31:22 +00:00
Scott Taylor 2c32752abd Improve various `@param` docs for `src/wp-admin/*`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30680


git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:00:22 +00:00
Andrew Ozz 760e3e5fbd Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass `$post_type` in the `wp_editor_expand` filter. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30641


git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:37:21 +00:00
Andrew Ozz 97c81c4507 Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30574


git-svn-id: http://core.svn.wordpress.org/trunk@30564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 02:54:25 +00:00
Drew Jaynes 4b6abbaff4 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30546


git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:31:21 +00:00
Helen Hou-Sandí 97b412af37 Admin notices: Add more variety and make more generically usable. 
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.

Built from https://develop.svn.wordpress.org/trunk@30505


git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:41:25 +00:00
Dominik Schilling f93a197089 Fix selector for the "Live Widget Previews" feature pointer. 
props rzen.
fixes #30158.
Built from https://develop.svn.wordpress.org/trunk@30332


git-svn-id: http://core.svn.wordpress.org/trunk@30331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:50:22 +00:00
Scott Taylor 06f49a43a1 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30196


git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:45:24 +00:00
Scott Taylor 8eee18ec0e Fill in types for the `@param`s for `wp_comment_reply()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30190


git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:21:22 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 01:05:24 +00:00
Gary Pendergast 007ec52958 Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8. 
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.


Built from https://develop.svn.wordpress.org/trunk@30055


git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-28 18:35:19 +00:00
Sergey Biryukov 3badb558f6 Remove one-time loop and redundant isset() checks in do_meta_boxes(). 
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.
Built from https://develop.svn.wordpress.org/trunk@30040


git-svn-id: http://core.svn.wordpress.org/trunk@30040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-27 12:58:19 +00:00
Sergey Biryukov 1bd594f033 Remove one-time loop and redundant isset() checks. 
props ipm-frommen.
fixes #30093.
Built from https://develop.svn.wordpress.org/trunk@30022


git-svn-id: http://core.svn.wordpress.org/trunk@30022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-25 16:34:18 +00:00
Drew Jaynes 3ad681b2ef Fix an invalid type for the `$section` parameter in the `do_settings_fields()` DocBlock. 
Props ipm-frommen.
See #30098.

Built from https://develop.svn.wordpress.org/trunk@30018


git-svn-id: http://core.svn.wordpress.org/trunk@30018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-25 13:38:23 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific. 
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 17:21:19 +00:00
Dominik Schilling 32030a073f RTL: Fix modal alignments. 
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.
Built from https://develop.svn.wordpress.org/trunk@29623


git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 12:55:16 +00:00
Sergey Biryukov 53c599563c Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute. 
props joedolson.
fixes #28866.
Built from https://develop.svn.wordpress.org/trunk@29239


git-svn-id: http://core.svn.wordpress.org/trunk@29023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-19 02:21:14 +00:00
Sergey Biryukov c09a48a915 Add screen reader text for star ratings on Install Plugins screen. 
props joedolson.
fixes #28852.
Built from https://develop.svn.wordpress.org/trunk@29232


git-svn-id: http://core.svn.wordpress.org/trunk@29016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 23:41:14 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 09:14:16 +00:00
Drew Jaynes d4dd02b4ae Remove backticks on `$post` variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28976


git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:28:14 +00:00
Sergey Biryukov ae0e22b61c Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.
Built from https://develop.svn.wordpress.org/trunk@28897


git-svn-id: http://core.svn.wordpress.org/trunk@28696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 16:06:14 +00:00
Scott Taylor 27523183bf Don't use variable variables in `touch_time()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 21:05:16 +00:00
John Blackbourn 03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:50:14 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Sergey Biryukov 4b14fe0593 Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.
Built from https://develop.svn.wordpress.org/trunk@28681


git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 18:29:14 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Scott Taylor 5b5b756edf In `get_terms_to_edit()`, call `get_object_term_cache()` before priming cache with `wp_get_object_terms()`. 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.


Built from https://develop.svn.wordpress.org/trunk@28561


git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:29:14 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Scott Taylor a7a6cb5bef Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28411


git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:14:14 +00:00
Scott Taylor 7ebab48f4c Eliminate use of `extract()` in `wp_terms_checklist()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28410


git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:09:15 +00:00
Scott Taylor a75f8137bc Eliminate use of `extract()` in `wp_star_rating()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28409


git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:57:14 +00:00
Andrew Nacin 55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Andrew Nacin eca26bc5ae The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.

Built from https://develop.svn.wordpress.org/trunk@28093


git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:53:15 +00:00
Andrew Nacin 497b0df4a5 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.

Built from https://develop.svn.wordpress.org/trunk@28090


git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:15 +00:00
Andrew Nacin bec78b5e11 Proper IDs for the custom fields box. 
props SergeyBiryukov.
fixes #14376.

Built from https://develop.svn.wordpress.org/trunk@27776


git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 06:56:14 +00:00
Drew Jaynes 7dc9b02577 Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

Built from https://develop.svn.wordpress.org/trunk@27695


git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 08:05:15 +00:00
Andrew Nacin 17ccbc86c9 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.

Built from https://develop.svn.wordpress.org/trunk@27470


git-svn-id: http://core.svn.wordpress.org/trunk@27315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:19:16 +00:00
Andrew Ozz 19efb78b48 Restyles the modal for attaching media to posts, props avryl, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27401


git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 23:11:13 +00:00
Drew Jaynes ad3861242d Inline documentation for hooks in wp-admin/includes/template.php. 
Props shelob9 for the initial patch. Props kpdesign.
Fixes #26089.

Built from https://develop.svn.wordpress.org/trunk@27237


git-svn-id: http://core.svn.wordpress.org/trunk@27094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-23 22:44:13 +00:00
Sergey Biryukov 6919d9f197 Use correct variable. props avryl. fixes #27153. 
Built from https://develop.svn.wordpress.org/trunk@27194


git-svn-id: http://core.svn.wordpress.org/trunk@27053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-19 15:29:14 +00:00
Scott Taylor ca4045ce76 Use `selected()` where appropriate in `touch_time()`, `page_template_dropdown()`, and `parent_dropdown()`. Also, add proper docs. 
Props meloniq, DrewAPicture.
Fixes #25889.


Built from https://develop.svn.wordpress.org/trunk@27188


git-svn-id: http://core.svn.wordpress.org/trunk@27047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-17 22:27:15 +00:00
Drew Jaynes 30c7a12aa2 Fix docs spacing missed in [27136]. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27137


git-svn-id: http://core.svn.wordpress.org/trunk@27004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:19:11 +00:00
Drew Jaynes 8b3c9c6b97 Improve inline documentation for `submit_button()`. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27136


git-svn-id: http://core.svn.wordpress.org/trunk@27003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:14:12 +00:00
Drew Jaynes de97319ad8 Clarify `submit_button()` `$type` parameter docs to mention that the value doubles as the CSS class attribute. 
See #27070

Built from https://develop.svn.wordpress.org/trunk@27135


git-svn-id: http://core.svn.wordpress.org/trunk@27002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:11:15 +00:00
Andrew Nacin dbea669271 Improve parameter documentation of add_meta_box(). 
props philiparthurmoore, DrewAPicture.
fixes #26698.

Built from https://develop.svn.wordpress.org/trunk@27132


git-svn-id: http://core.svn.wordpress.org/trunk@26999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 00:55:12 +00:00
Andrew Ozz eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-24 19:06:15 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 18:57:12 +00:00
Drew Jaynes 7bf5470bab Inline documentation fixes for hooks and functions introduced in 3.8.0. 
Built from https://develop.svn.wordpress.org/trunk@26736


git-svn-id: http://core.svn.wordpress.org/trunk@26625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 19:18:11 +00:00
Dion Hulse 89dfee993d Replace the Star ratings in the dashboard with dashicons ratings. 
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170

Built from https://develop.svn.wordpress.org/trunk@26380


git-svn-id: http://core.svn.wordpress.org/trunk@26280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-26 02:25:21 +00:00
Matt Thomas 7fe71ffe81 Style and positioning fixes to form elements in the Publish box: 
- Make select element text #555 to match others
- Make Cancel links vertically align with buttons
- Make sure the spacing between buttons and cancel links is always consistent
- Override active button styles for responsive states so button size doesn't change when active
- Reduce font size of date select element to match date text inputs

Fixes #26082, props aubreypwd.


Built from https://develop.svn.wordpress.org/trunk@26247


git-svn-id: http://core.svn.wordpress.org/trunk@26153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-18 18:53:10 +00:00
Andrew Ozz 541d22e18d Fix the X-UA-Compatible header for IE8, fixes #25575 
Built from https://develop.svn.wordpress.org/trunk@26089


git-svn-id: http://core.svn.wordpress.org/trunk@26007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-11 18:02:10 +00:00
Andrew Ozz 0743625aed Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575. 
Built from https://develop.svn.wordpress.org/trunk@26029


git-svn-id: http://core.svn.wordpress.org/trunk@25959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-06 23:49:09 +00:00
Andrew Nacin d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 10:56:09 +00:00
Drew Jaynes 858343ed71 Inline documentation for `Walker_Category_Checklist`. 
See #23406.

Built from https://develop.svn.wordpress.org/trunk@25642


git-svn-id: http://core.svn.wordpress.org/trunk@25559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-28 18:08:10 +00:00
Andrew Nacin 9cf6436ff3 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
Built from https://develop.svn.wordpress.org/trunk@25591


git-svn-id: http://core.svn.wordpress.org/trunk@25508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 01:31:10 +00:00
Sergey Biryukov 14db24911f Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340. 
Built from https://develop.svn.wordpress.org/trunk@25472


git-svn-id: http://core.svn.wordpress.org/trunk@25393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-17 09:08:08 +00:00
Scott Taylor ffe8f1b13a Remove unnecessary checks before setting `$wp_settings_*` arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional `array`. 
Props scribu.
Fixes #17884.


Built from https://develop.svn.wordpress.org/trunk@25240


git-svn-id: http://core.svn.wordpress.org/trunk@25210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-04 19:07:09 +00:00
Sergey Biryukov ca17a6161a Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@25117


git-svn-id: http://core.svn.wordpress.org/trunk@25097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-24 22:34:10 +00:00
Andrew Nacin d06c049d51 Fix various typos in inline documentation. props nofearinc, fixes #25119. 
Built from https://develop.svn.wordpress.org/trunk@25094


git-svn-id: http://core.svn.wordpress.org/trunk@25078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-22 22:01:08 +00:00
Helen Hou-Sandí eb44516e48 Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333. 
Built from https://develop.svn.wordpress.org/trunk@25083


git-svn-id: http://core.svn.wordpress.org/trunk@25068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-22 15:24:10 +00:00
Ryan Boren 3a5f483e14 Set RTL body class for iframes. 
Props mitchoyoshitaka
see #24149


git-svn-id: http://core.svn.wordpress.org/trunk@24994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-06 17:35:43 +00:00
Andrew Nacin e91002f4fb Remove unnecessary cap checks from [24854]. You need these capabilities (or equivalent) to access the screens for these feature pointers. see #24832. 
git-svn-id: http://core.svn.wordpress.org/trunk@24855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-29 06:43:30 +00:00
Mark Jaquith 8abd5bb815 Tooltips for 3.6 features: Revisions, Post Locking. 
Props siobhan. See #24832 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-29 06:17:01 +00:00
Andrew Nacin c2a543566c Move _local_storage_notice() to admin/includes/template.php. props azaozz, see #24756. 
git-svn-id: http://core.svn.wordpress.org/trunk@24762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-22 05:09:49 +00:00