Commit Graph

42339 Commits

Author SHA1 Message Date
Sergey Biryukov 722df60bcd Login and Registration: Hide the login form on the "check your email" step of new user registration or password reset.
This aims to reduce some confusion and make it clearer that the email should be checked before attempting to log in right away.

Props rianrietveld, pratik028, bdbch, johnbillion, hankthetank, yashrs, williampatton, audrasjb, bmartinent, florianatwhodunit, henry.wright, birgire, SergeyBiryukov.
Fixes #40605, #41514.
Built from https://develop.svn.wordpress.org/trunk@48304


git-svn-id: http://core.svn.wordpress.org/trunk@48073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 21:58:03 +00:00
Sergey Biryukov 324cd48507 Login and Registration: Remove `newpass` value handling in `wp-login.php`.
This value is never set as of [15710].

See #40605.
Built from https://develop.svn.wordpress.org/trunk@48303


git-svn-id: http://core.svn.wordpress.org/trunk@48072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 21:15:02 +00:00
Sergey Biryukov 6adad022e2 Docs: Correct spelling of "backward compatibility" per the Core Contributor Handbook glossary.
Follow-up to [45232].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48302


git-svn-id: http://core.svn.wordpress.org/trunk@48071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 20:42:06 +00:00
Sergey Biryukov db0e0ca245 Coding Standards: Wrap some long lines in `wp-admin/js/site-health.js` per the JS coding standards for better readability.
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48301


git-svn-id: http://core.svn.wordpress.org/trunk@48070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:56:07 +00:00
TimothyBlynJacobs 5ffac7cab7 REST API: Only validate the format keyword if the type is a string.
This allows for using multi-type support with a string that has a format. For backwards compatibility support, the format validation will still apply if the type is not specified, or it is invalid.

Two new doing it wrong notices are issued when omitting a type, or using an invalid type.

Props ryotsun.
Fixes #50189.

Built from https://develop.svn.wordpress.org/trunk@48300


git-svn-id: http://core.svn.wordpress.org/trunk@48069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:53:03 +00:00
Sergey Biryukov e3e45b6428 Customize: Correct the check for rendered widgets in `WP_Customize_Widgets::is_widget_rendered()`.
Make the structure of `::$rendered_sidebars` and `::$rendered_widgets` properties consistent.

This resolves an issue with every widget being marked as inactive by default on the Widgets panel.

Props dlh, afercia, SergeyBiryukov.
Fixes #50508.
Built from https://develop.svn.wordpress.org/trunk@48299


git-svn-id: http://core.svn.wordpress.org/trunk@48068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:35:01 +00:00
Sergey Biryukov d90213bf18 Docs: Replace `@returns` tag in `wp-admin/js/post.js` with `@return`.
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead.

Follow-up to [46800], [48232].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48298


git-svn-id: http://core.svn.wordpress.org/trunk@48067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:10:10 +00:00
Sergey Biryukov c65f40956e Coding Standards: Rename functions in `wp-admin/js/site-health.js` per the JS coding standards.
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48297


git-svn-id: http://core.svn.wordpress.org/trunk@48066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:09:07 +00:00
Sergey Biryukov 5fb7c090de Media: Add `heic` extension to `wp_get_ext_types()`, for consistency with `wp_get_mime_types()`.
Follow-up to [48288].

Props imath.
Fixes #50557. See #42775.
Built from https://develop.svn.wordpress.org/trunk@48296


git-svn-id: http://core.svn.wordpress.org/trunk@48065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 17:09:01 +00:00
TimothyBlynJacobs 633c453fcc Script Loader: Add id attributes to script assets.
This commit adds a unique ID attribute to script loader generated <script> tags as well as related <script> tags for inline JavaScript, translations, or parameters.

This is a first step in adding support for lazy loading scripts and styles, but for now is only used to assist in debugging generated output.

Props dd32, spacedmonkey.
See #48654.

Built from https://develop.svn.wordpress.org/trunk@48295


git-svn-id: http://core.svn.wordpress.org/trunk@48064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 16:54:02 +00:00
Dominik Schilling df320b33c2 Themes: Introduce `get_the_archive_title_prefix` filter for changing the prefix used for archive titles.
In `get_the_archive_title()` split the internal `$title` variable into `$title` and `$prefix`. By using the new `get_the_archive_title_prefix` filter the prefix can now wrapped with custom elements or removed completely by using

{{{
add_filter( 'get_the_archive_title_prefix', '__return_empty_string' );
}}}

Also, wrap the title part with a `span` element and pass the original title and prefix to the existing `get_the_archive_title` filter, allowing further customization to the archive titles.

Props Kaira, milindmore22, shireling, grapplerulrich, audrasjb, desrosj, Confridin, ramiy, ocean90.
Fixes #31237.
Fixes #38545.
Built from https://develop.svn.wordpress.org/trunk@48294


git-svn-id: http://core.svn.wordpress.org/trunk@48063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 14:45:01 +00:00
Andrea Fercia 2e992505ac Accessibility: Improve the focus style for Windows High Contrast mode in various parts of the admin interface.
Continues the introduction in core of new focus styles dedicated to Windows High Contrast mode. The new styles use a transparent CSS outline.
This change covers some parts of the interface for the meta boxes, Widgets, and the Customizer.

Props joedolson, kjellr, antpb, mikeschroder, Hareesh Pillai.
See #41286, #45910.
Fixes #47117.

Built from https://develop.svn.wordpress.org/trunk@48293


git-svn-id: http://core.svn.wordpress.org/trunk@48062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 10:44:03 +00:00
Sergey Biryukov 43cbe21a3e Administration: Use HTTPS for XHTML Friends Network URL.
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
Fixes #48002.
Built from https://develop.svn.wordpress.org/trunk@48292


git-svn-id: http://core.svn.wordpress.org/trunk@48061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 09:33:01 +00:00
TimothyBlynJacobs 5af864369c REST API: Introduce endpoint for editing images.
To facilitate inline image editing in Gutenberg, a new endpoint at wp/v2/media/<id>/edit has been introduced. This is functionally similar to the existing ajax image editor, however the REST API editor creates a new attachment record instead of updating an existing attachment.

Fixes #44405.
Props ajlende, ellatrix, spacedmonkey, azaozz.


Built from https://develop.svn.wordpress.org/trunk@48291


git-svn-id: http://core.svn.wordpress.org/trunk@48060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 04:15:05 +00:00
Sergey Biryukov 953868b3a3 Bundled Themes: Use HTTPS for XHTML Friends Network URL.
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002.
Built from https://develop.svn.wordpress.org/trunk@48290


git-svn-id: http://core.svn.wordpress.org/trunk@48059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:42:01 +00:00
Sergey Biryukov 07bce8970a General: Use HTTPS for the Web Address field example on Edit Link screen.
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002.
Built from https://develop.svn.wordpress.org/trunk@48289


git-svn-id: http://core.svn.wordpress.org/trunk@48058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:36:03 +00:00
Andrew Ozz 86317e3e85 Media: Show an error message when a `.heic` file is uploaded that this type of files cannot be displayed in a web browser and suggesting to convert to JPEG. The message is shown by using filters, plugins that want to handle uploading of `.heic` files can remove it.
Props mattheweppelsheimer, mikeschroder, jeffr0, andraganescu, desrosj, azaozz.
Fixes #42775.
Built from https://develop.svn.wordpress.org/trunk@48288


git-svn-id: http://core.svn.wordpress.org/trunk@48057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:15:03 +00:00
Sergey Biryukov 054610e276 Text Changes: Remove use of "normal" in user-facing output.
This clarifies some messages referring to Site Health checks and maintenance mode, and makes them more accurate.

Props dartiss.
Fixes #50549.
Built from https://develop.svn.wordpress.org/trunk@48287


git-svn-id: http://core.svn.wordpress.org/trunk@48056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 21:59:03 +00:00
Dominik Schilling 6a889c150d Build tools: After [48277], ignore CSS files in `src/wp-admin/css/colors/modern` when building WordPress to `src`.
See #50504.
Built from https://develop.svn.wordpress.org/trunk@48286


git-svn-id: http://core.svn.wordpress.org/trunk@48055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 19:18:02 +00:00
Dominik Schilling 718626a8ce I18N: Use `wp.i18n` for translatable strings in `wp-includes/js/wp-auth-check.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50553.
Built from https://develop.svn.wordpress.org/trunk@48285


git-svn-id: http://core.svn.wordpress.org/trunk@48054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 19:05:03 +00:00
Sergey Biryukov 8e43a329d4 Privacy: Hide views that have a count of 0 on privacy request tables, for consistency with other list tables.
Props pbiron, garrett-eclipse, mapk, melchoyce, estelaris.
Fixes #47495.
Built from https://develop.svn.wordpress.org/trunk@48284


git-svn-id: http://core.svn.wordpress.org/trunk@48053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 16:28:04 +00:00
Andrea Fercia 83c7b67c32 Accessibility: Themes: Use a default empty alt attribute for the non-linked custom logo on the home page.
After [48039] it became clear that the non-linked custom logo on the home page needs an empty alt attribute, as in most of the cases the logo is decorative and doesn't need its purpose to be described.

This change outputs an empty alt attribute by default for the custom logo on the home page. If necessary, it is possible to use the new 'get_custom_logo_image_attributes' filter to manipulate the default attributes for the logo image and set an alt attribute.

Props FlorianBrinkmann, Soean, sabernhardt, audrasjb, SergeyBiryukov, samful, knutsp.
See #36640.
Fixes #37011.

Built from https://develop.svn.wordpress.org/trunk@48283


git-svn-id: http://core.svn.wordpress.org/trunk@48052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 12:58:07 +00:00
Pascal Birchler 69e876747d Sitemaps: Do not unnecessarily call `WP_Query::get_posts()` in posts provider.
The posts have already been fetched at this point, no need to do it again.

Props Chouby.
Fixes #50463.
Built from https://develop.svn.wordpress.org/trunk@48282


git-svn-id: http://core.svn.wordpress.org/trunk@48051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 12:03:01 +00:00
Andrea Fercia b8e3d63fdd Accessibility: Plugins: Accessibility and CSS improvements for the Plugins pages.
- improves checkboxes alignment on the "Plugins" page table in the responsive view 
- improves spacing between form controls on the "Add Plugins" page in the responsive view 
- the layout of the "filter bar" on the "Add Plugins" page is now based on CSS Flexbox 
- removes italic type from a paragraph in the "Favorites" page

Props passoniate, garethgillman, maxpertici, audrasjb, sabernhardt, afercia.
See #47327.
Fixes #49231.

Built from https://develop.svn.wordpress.org/trunk@48281


git-svn-id: http://core.svn.wordpress.org/trunk@48050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 08:51:05 +00:00
Sergey Biryukov f665e823a5 Tests: Further fix some issues with indeterminate sort ordering in `Tests_List_Pages`:
* Make sure `test_wp_list_pages_number()` sorts by ID, as there are several pages with the same title.
* Limit `test_wp_list_pages_sort_column()` to one level, as the child page fixtures don't have an author and cannot be reliably sorted by `post_author`.

Follow-up to [48157].

Props afercia.
See #50466.
Built from https://develop.svn.wordpress.org/trunk@48280


git-svn-id: http://core.svn.wordpress.org/trunk@48049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 18:23:04 +00:00
gziolo 707cb4a35b Editor: Move core blocks registration to init hook
After working on support for register_block_type_args filter in #49615, it became clear that we need to use init action for core blocks to make it possible to use this filter.

Fixes #50263.


Built from https://develop.svn.wordpress.org/trunk@48279


git-svn-id: http://core.svn.wordpress.org/trunk@48048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 17:22:03 +00:00
desrosj f7d2a408d9 External Libraries: Update getID3 to version 1.9.20.
A full list of changes in this update can be found on GitHub: https://github.com/JamesHeinrich/getID3/compare/v1.9.19...v1.9.20.

Props hareesh-pillai, desrosj.
Previously [47601-47604].
Fixes #49945.
Built from https://develop.svn.wordpress.org/trunk@48278


git-svn-id: http://core.svn.wordpress.org/trunk@48047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 15:48:04 +00:00
youknowriad bbe8f41de2 Color schemes: Add new modern color scheme option.
This PR adds a new color scheme option, which uses a high luminosity blue spot color, almost-black menu, and pure white for menu items. 
This helps increase contrast, and bring more consistency with some of the higher contrast colors used in the block editor.

Props joen, ibdz, shaunandrews.
Fixes #50504.

Built from https://develop.svn.wordpress.org/trunk@48277


git-svn-id: http://core.svn.wordpress.org/trunk@48046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 14:55:05 +00:00
Sergey Biryukov 25fb9a9d3a Script Loader: Restore correct versions for Masonry and imagesLoaded.
These libraries were previously updated in [48038], but some changes were accidentally reverted in [48267].

Props kebbet.
See #50526.
Built from https://develop.svn.wordpress.org/trunk@48276


git-svn-id: http://core.svn.wordpress.org/trunk@48045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 13:10:08 +00:00
Sergey Biryukov ec571bdcf6 Docs: Spell "falsey" in a consistent way.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48275


git-svn-id: http://core.svn.wordpress.org/trunk@48044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 11:30:02 +00:00
Sergey Biryukov 07d2c8a4e9 I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/privacy-tools.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90, afercia.
See #20491.
Fixes #50535.
Built from https://develop.svn.wordpress.org/trunk@48274


git-svn-id: http://core.svn.wordpress.org/trunk@48043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 11:11:06 +00:00
TimothyBlynJacobs 8d11801c86 REST API: Link to the REST route for the currently queried resource.
This allows for programatically determining the REST version of the current page. The links also aid human discovery of the REST API in general.

Props dshanske, tfrommen, TimothyBlynJacobs.
Fixes #49116.

Built from https://develop.svn.wordpress.org/trunk@48273


git-svn-id: http://core.svn.wordpress.org/trunk@48042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 05:57:01 +00:00
Felix Arntz 1d010a49c7 Media: Improve support for opting out of lazy-loading for template images.
With this changeset, in addition to the already present `wp_lazy_loading_enabled` filter, developers can now opt out of lazy-loading template images via `wp_get_attachment_image()` by passing a `loading` attribute with boolean value `false`. This can be used e.g. by theme developers on images which are very likely to be in the initial viewport.

This changeset also improves related test coverage.

Props adamsilverstein, azaozz, joemcgill, johnbillion.
See #50425, #44427.

Built from https://develop.svn.wordpress.org/trunk@48272


git-svn-id: http://core.svn.wordpress.org/trunk@48041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 02:03:03 +00:00
whyisjake 55b80358a5 Bundled Themes: Update latest version for `Tested up to:` in readme.txt file.
Fixes #50503.
Props mukesh27, hareesh-pillai.


Built from https://develop.svn.wordpress.org/trunk@48271


git-svn-id: http://core.svn.wordpress.org/trunk@48040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 22:06:05 +00:00
Dominik Schilling 2fab13ae3e I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/user-profile.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50527.
Built from https://develop.svn.wordpress.org/trunk@48270


git-svn-id: http://core.svn.wordpress.org/trunk@48039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 20:38:01 +00:00
desrosj 4329bd950b External Libraries: Update Moment.js to version 2.27.0.
A full list of changes in this update can be found on GitHub: https://github.com/moment/moment/compare/2.26.0...2.27.0

Props hareesh-pillai, desrosj.
Previously [48075].
Fixes #50408.
Built from https://develop.svn.wordpress.org/trunk@48269


git-svn-id: http://core.svn.wordpress.org/trunk@48038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 20:29:19 +00:00
Andrea Fercia 87756494cc Media: Enable JavaScript translations for the media-views script after [48232].
See #48463.

Built from https://develop.svn.wordpress.org/trunk@48268


git-svn-id: http://core.svn.wordpress.org/trunk@48037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 20:21:06 +00:00
Dominik Schilling 77b2440f9f I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/common.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50526.
Built from https://develop.svn.wordpress.org/trunk@48267


git-svn-id: http://core.svn.wordpress.org/trunk@48036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 19:50:02 +00:00
Dominik Schilling d686fa266b I18N: Use `wp.i18n` for translatable strings in `wp-includes/js/wp-pointer.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50525.
Built from https://develop.svn.wordpress.org/trunk@48266


git-svn-id: http://core.svn.wordpress.org/trunk@48035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 19:30:02 +00:00
Andrea Fercia 45d19872fc Accessibility: Media: Fix the Image Editor mismatching keyboard focus order and visual reading order.
Swaps the DOM order of the two main columns within the admin Image Editor.

When the sequence in which content is presented affects its meaning and the navigation sequences affect meaning or operation, visual order and DOM order must match. See WCAG 2.1 Success Criterion 1.3.2 Meaningful Sequence and Success Criterion 2.4.3 Focus Order.

Props sabernhardt, anevins, audrasjb, afercia.
Fixes #47136.

Built from https://develop.svn.wordpress.org/trunk@48265


git-svn-id: http://core.svn.wordpress.org/trunk@48034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 14:29:01 +00:00
Sergey Biryukov 30e0cf9fcd Docs: Bundled Themes: Correct DocBlock placement for custom header and background argument filters.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48264


git-svn-id: http://core.svn.wordpress.org/trunk@48033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 13:52:01 +00:00
gziolo 9a9352da00 Editor: Support filtering arguments in block type registration
Adds possibility to filter the settings of a block type during its registration.

Props aduth, azaozz.
Fixes #49615.


Built from https://develop.svn.wordpress.org/trunk@48263


git-svn-id: http://core.svn.wordpress.org/trunk@48032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 13:10:02 +00:00
gziolo eafcf52d18 Editor: Register core blocks on the server
Exposes all core blocks (excluding embeds) on the server to be used with the REST API block types endpoint.

Props spacedmonkey, timothyblynjacobs.
Fixes #50263.


Built from https://develop.svn.wordpress.org/trunk@48262


git-svn-id: http://core.svn.wordpress.org/trunk@48031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 12:29:03 +00:00
gziolo eeb4d75c57 Editor: More strict checks for globals in render_block
Props kraftbj.
Fixes #49927.


Built from https://develop.svn.wordpress.org/trunk@48243


git-svn-id: http://core.svn.wordpress.org/trunk@48012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 06:08:06 +00:00
TimothyBlynJacobs 083134f694 REST API: Introduce plugin management and block directory endpoints.
These endpoints facilitate the Block Directory Inserter feature in Gutenberg. Users can now install, activate, deactivate, and delete plugins over the REST API. The block directoryendpoint allows searching for available blocks from the WordPress.org block directory.

Props cklee, talldanwp, noisysocks, joen, soean, youknowriad, dufresnesteven, gziolo, dd32, tellyworth, ryelle, spacedmonkey, TimothyBlynJacobs.
Fixes #50321.


Built from https://develop.svn.wordpress.org/trunk@48242


git-svn-id: http://core.svn.wordpress.org/trunk@48011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 04:24:03 +00:00
Sergey Biryukov 7ac100615f Administration: Pass the result of `set-screen-option` filter to the new `set_screen_option_{$option}` filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.

Props Chouby, sswells, SergeyBiryukov.
Fixes #50392.
Built from https://develop.svn.wordpress.org/trunk@48241


git-svn-id: http://core.svn.wordpress.org/trunk@48010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 21:53:03 +00:00
Sergey Biryukov e61075ad2a Administration: Always show the filters on media and post list tables.
Previously, the filters were hidden for single posts or attachments, which could only be achieved by editing the URL manually.

The `is_singular()` check was added long before the list tables were introduced, and appears to no longer serve any purpose in the current code.

As a side effect, this resolves an issue where a non-existing attachment ID in the URL would block further search in Media Library.

Props afercia, tomdude, audrasjb, bencroskery, desrosj, SergeyBiryukov.
Fixes #38221.
Built from https://develop.svn.wordpress.org/trunk@48240


git-svn-id: http://core.svn.wordpress.org/trunk@48009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 20:36:05 +00:00
Felix Arntz 70c8bd2333 Media: Only add `loading` attribute to `img` tags using double quotes.
Props azaozz.
Fixes #50367.

Built from https://develop.svn.wordpress.org/trunk@48239


git-svn-id: http://core.svn.wordpress.org/trunk@48008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 20:34:06 +00:00
Sergey Biryukov 6cb2f5491b Code Modernization: Introduce the spread operator in `WP_HTTP_IXR_Client`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This makes the signature of `WP_HTTP_IXR_Client::query()` compatible with the parent class method.

Follow-up to [48204].

Props ayeshrajans.
See #48267, #47678.
Built from https://develop.svn.wordpress.org/trunk@48238


git-svn-id: http://core.svn.wordpress.org/trunk@48007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 19:50:04 +00:00
Felix Arntz e92ab44880 Media: Introduce `wp_img_tag_add_width_and_height_attr()` to add dimension attributes to images.
Following up on [48170], this changeset moves the new logic to add missing `img` dimension attributes into a separate function that is run first within `wp_filter_content_tags()`. It also adds a utility function `wp_image_src_get_dimensions()` with logic reused from `wp_image_add_srcset_and_sizes()`, and it ensures that `width` and `height` attributes only get added if both of the attributes are missing on the original `img` tag.

This changeset furthermore improves test coverage and separates tests for the different aspects of `img` tag modification.

Props azaozz.
Fixes #50367. See #44427.

Built from https://develop.svn.wordpress.org/trunk@48237


git-svn-id: http://core.svn.wordpress.org/trunk@48006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 19:30:08 +00:00