Commit Graph

1007 Commits

Author SHA1 Message Date
nacin 64b9b4f940 Do not specify background-image: none when a user removes a custom background
on a theme that has a default background image.

The onus is on the theme to omit the default background-image from style.css,
to allow the user to remove the default background image. Or, the theme can
specify a background-image for the body selector, as long as they then zero
it out for body.custom-background, like so:

{{{
body {
	background-image: url( ... );
}
body.custom-background {
	background-image: none;
}
}}}

This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.

This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.

see #20132, which will now be marked as invalid.

Also, per previous changes in #20448, the custom-background class should not
be shown when only a default color is in use.

fixes #20448.



git-svn-id: http://core.svn.wordpress.org/trunk@21054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 21:25:05 +00:00
bumpbot 7812d7ba2f Compress scripts/styles: 3.4-RC2-21036.
git-svn-id: http://core.svn.wordpress.org/trunk@21036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-09 15:58:24 +00:00
ryan 4fbec0661f Fix comment hotkeys for FF and IE. Props azaozz, SergeyBiryukov. fixes #20885
git-svn-id: http://core.svn.wordpress.org/trunk@21035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-09 15:57:11 +00:00
bumpbot e04cfd76f5 Compress scripts/styles: 3.4-RC2-21034.
git-svn-id: http://core.svn.wordpress.org/trunk@21034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 23:02:40 +00:00
koopersmith 6c273ba9e4 Theme Customizer: Separate message url from preview url in customizer JS Previewer and PreviewFrame objects. fixes #20892.
git-svn-id: http://core.svn.wordpress.org/trunk@21033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 22:59:48 +00:00
bumpbot dce23895de Compress scripts/styles: 3.4-RC2-21030.
git-svn-id: http://core.svn.wordpress.org/trunk@21030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:58:24 +00:00
ryan f826e49a72 Customizer: fix stuck urls and preview white screens after repeated save and activates. Props koopersmith. fixes #20868
git-svn-id: http://core.svn.wordpress.org/trunk@21029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:52:44 +00:00
ryan 69ad7a68ff Customizer: Redirect back to referrer. If referrer is a front end page, load that page in the customizer preview. Props nacin, koopersmith. fixes #20877
git-svn-id: http://core.svn.wordpress.org/trunk@21028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:45:12 +00:00
bumpbot 3f729457f4 Compress scripts/styles: 3.4-RC2-21026.
git-svn-id: http://core.svn.wordpress.org/trunk@21026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 22:58:22 +00:00
ryan 6e0e62a063 Customizer: Add keyup events to sync textarea values. Props koopersmith. fixes #20879
git-svn-id: http://core.svn.wordpress.org/trunk@21024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 22:00:59 +00:00
bumpbot d356284803 Compress scripts/styles: 3.4-RC1-21017.
git-svn-id: http://core.svn.wordpress.org/trunk@21017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:31:49 +00:00
ryan 07140847b2 Namespace the customize request arg to prevent collision with plugins and themes. Props nacin. fixes #20862
git-svn-id: http://core.svn.wordpress.org/trunk@21016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:29:57 +00:00
bumpbot d15f104e4b Compress scripts/styles: 3.4-RC1-21015.
git-svn-id: http://core.svn.wordpress.org/trunk@21015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:51:13 +00:00
koopersmith 14f04132af Theme Customizer: Fix scrolling on iOS and Kindle Fire. props azaozz, helenyhou. fixes #20805.
Also fixes uploader UIs on iOS and Kindle Fire by improving wp.Uploader.
Adds mobile viewport specifications.
Moves scrollbar back to fixed positioning.


git-svn-id: http://core.svn.wordpress.org/trunk@21014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:45:17 +00:00
ryan d7a9a9a231 Don't resurrect a removed default image when changing colors in the Customizer. Props koopersmith, nacin. fixes #20448
git-svn-id: http://core.svn.wordpress.org/trunk@21013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:24:22 +00:00
bumpbot a17441a7e3 Compress scripts/styles: 3.4-RC1-21011.
git-svn-id: http://core.svn.wordpress.org/trunk@21011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 20:58:20 +00:00
nacin 98b61d9a17 Theme Customizer: Block non-existent or non-allowed themes, unless the non-allowed theme is the active theme. Support a user having edit_theme_options xor switch_themes. fixes #20852.
git-svn-id: http://core.svn.wordpress.org/trunk@21010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 20:34:24 +00:00
bumpbot d35556e69a Compress scripts/styles: 3.4-RC1-20989.
git-svn-id: http://core.svn.wordpress.org/trunk@20989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 15:58:26 +00:00
ryan e69299af51 Theme Customizer: Fix race condition in previewer and use message channels. Props koopersmith. fixes #20811
git-svn-id: http://core.svn.wordpress.org/trunk@20988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 15:51:46 +00:00
bumpbot 9b23e86b63 Compress scripts/styles: 3.4-RC1-20979.
git-svn-id: http://core.svn.wordpress.org/trunk@20979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-02 01:58:27 +00:00
azaozz cb71d2fe62 Fix notice in wp_read_image_metadata() when EXIF ISOSpeedRatings is array, props nacin, fixes #20807
git-svn-id: http://core.svn.wordpress.org/trunk@20978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-02 01:39:00 +00:00
bumpbot ba20e754d1 Compress scripts/styles: 3.4-RC1-20970.
git-svn-id: http://core.svn.wordpress.org/trunk@20970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 15:58:23 +00:00
ryan c4d5b1806e Theme Customizer: Reduce reliance on fixed positioning and make sidebar UI flexible. Props koopersmith, ocean90, helenyhou. fixes #20799
git-svn-id: http://core.svn.wordpress.org/trunk@20969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 15:48:09 +00:00
nacin b698913b10 Move customize-controls CSS and JS to wp-admin. fixes #20785.
git-svn-id: http://core.svn.wordpress.org/trunk@20960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-30 20:11:04 +00:00
bumpbot c8485f2a1b Compress scripts/styles: 3.4-beta4-20941.
git-svn-id: http://core.svn.wordpress.org/trunk@20941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 20:58:28 +00:00
koopersmith c2c3f2ba7f Theme Customizer: Don't expand theme title if there are no details to show. props nacin, fixes #20757, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 20:47:55 +00:00
bumpbot 78f3c9a8e6 Compress scripts/styles: 3.4-beta4-20937.
git-svn-id: http://core.svn.wordpress.org/trunk@20937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 18:58:28 +00:00
koopersmith 0df3218cc2 Theme Customizer: Ensure that JS color controls always use real color values, even if the server-side value is a hex value without a hash. fixes #20448, see #19910.
Adds WP_Customize_Setting->sanitize_js_callback and 'customize_sanitize_js_$settingID' filter, to filter values before they're passed to JS using WP_Customize_Setting->js_value().

Adds support for regular hex colors to the color picker.

Changes color methods:
* sanitize_hex_color() accepts 3 and 6 digit hex colors (with hashes) and the empty string.
* sanitize_hex_color_no_hash() accepts 3 and 6 digit hex colors (without hashes) and the empty string.
* maybe_hash_hex_color() ensures that a hex color has a hash, and otherwise leaves the value untouched.


git-svn-id: http://core.svn.wordpress.org/trunk@20936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 18:44:31 +00:00
bumpbot fd069c1819 Compress scripts/styles: 3.4-beta4-20931.
git-svn-id: http://core.svn.wordpress.org/trunk@20931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 07:58:28 +00:00
koopersmith 2d111e1c37 Theme Customizer: Fix preview background CSS creation to insert/remove style nodes (for IE8 compatibility). fixes #20582, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 07:02:28 +00:00
bumpbot 71b00f37aa Compress scripts/styles: 3.4-beta4-20929.
git-svn-id: http://core.svn.wordpress.org/trunk@20929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 05:58:26 +00:00
koopersmith 20f804ab8f Theme Customizer: Fix IE8 drag/drop uploader incompatibility. see #20582, #19910.
Bind drag/drop support checks to individual plupload instances.
Add drag-over classes to wp.Uploader and corresponding styles to customize image controls.


git-svn-id: http://core.svn.wordpress.org/trunk@20928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 05:55:40 +00:00
bumpbot e5a31ee0ad Compress scripts/styles: 3.4-beta4-20927.
git-svn-id: http://core.svn.wordpress.org/trunk@20927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 04:58:27 +00:00
koopersmith e178acf108 Theme Customizer: Add a signature to preview requests to be super-double-ultra-sure that the customizer generated the preview. Redirects can be sneaky. fixes #20507, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 04:08:44 +00:00
bumpbot 366ca788d5 Compress scripts/styles: 3.4-beta4-20921.
git-svn-id: http://core.svn.wordpress.org/trunk@20921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 22:58:24 +00:00
koopersmith 3c044eba6f Theme Customizer: Correctly use custom-background class in theme preview. See #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 22:43:11 +00:00
bumpbot fbcc2cb097 Compress scripts/styles: 3.4-beta4-20914.
git-svn-id: http://core.svn.wordpress.org/trunk@20914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 20:58:23 +00:00
koopersmith beb401b533 Theme Customizer: Improve background image control, add correct meta key to custom headers and backgrounds uploaded using the customizer. see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 20:26:25 +00:00
bumpbot f895adb49c Compress scripts/styles: 3.4-beta4-20911.
git-svn-id: http://core.svn.wordpress.org/trunk@20911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 18:58:23 +00:00
koopersmith a5ee470df7 Theme Customizer: Improve default background property handling. see #20600, #19910.
If the custom background default wp-head-callback (_custom_background_cb) is used, we use postMessage for all custom background properties. Otherwise, we use full refreshes.

When using postMessage, the preview recalculates the custom background CSS block, allowing it to omit CSS values when they are not present and fall back on the original CSS.


git-svn-id: http://core.svn.wordpress.org/trunk@20908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 18:41:22 +00:00
bumpbot f58b088cfd Compress scripts/styles: 3.4-beta4-20900.
git-svn-id: http://core.svn.wordpress.org/trunk@20900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 17:58:22 +00:00
koopersmith b3c12bada3 Theme Customizer: Improve activate and publish flow, make customizer states easier to track. fixes #20743, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 17:42:06 +00:00
bumpbot d05de3ad24 Compress scripts/styles: 3.4-beta4-20898.
git-svn-id: http://core.svn.wordpress.org/trunk@20898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 16:58:23 +00:00
koopersmith c71b8d0925 Theme Customizer: Prevent messengers from binding to the current window when a parent doesn't exist. see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 16:19:18 +00:00
bumpbot bff286c100 Compress scripts/styles: 3.4-beta4-20892.
git-svn-id: http://core.svn.wordpress.org/trunk@20892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 22:58:21 +00:00
koopersmith 2f09b8d0a6 Theme Customizer: Fix hash-based loader fallbacks. see #20736, #19910, [20886].
git-svn-id: http://core.svn.wordpress.org/trunk@20890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 22:45:27 +00:00
bumpbot 29eb5af53f Compress scripts/styles: 3.4-beta4-20889.
git-svn-id: http://core.svn.wordpress.org/trunk@20889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 21:40:40 +00:00
koopersmith c3e7ce5320 Theme Customizer: Check for CORS support when the preview and admin urls are cross-domain. Add a fallback to the customize control frame, and check support there as well. see #20582, #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 21:13:21 +00:00
bumpbot 878433583e Compress scripts/styles: 3.4-beta4-20883.
git-svn-id: http://core.svn.wordpress.org/trunk@20883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 19:58:22 +00:00
koopersmith 84cc00a6e8 Theme Customizer: Improve accuracy of identifying internal urls. see #20507, #19910.
The 'customize_preview_link' filter has been replaced by 'customize_allowed_urls'.
Improved accuracy when checking for wp-admin.
Improved accuracy when attempting to match the schemes of the control and preview frames.
Improved accuracy of internal link whitelist.


git-svn-id: http://core.svn.wordpress.org/trunk@20882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 19:17:49 +00:00