Commit Graph

10001 Commits

Author SHA1 Message Date
nacin 64b9b4f940 Do not specify background-image: none when a user removes a custom background
on a theme that has a default background image.

The onus is on the theme to omit the default background-image from style.css,
to allow the user to remove the default background image. Or, the theme can
specify a background-image for the body selector, as long as they then zero
it out for body.custom-background, like so:

{{{
body {
	background-image: url( ... );
}
body.custom-background {
	background-image: none;
}
}}}

This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.

This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.

see #20132, which will now be marked as invalid.

Also, per previous changes in #20448, the custom-background class should not
be shown when only a default color is in use.

fixes #20448.



git-svn-id: http://core.svn.wordpress.org/trunk@21054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 21:25:05 +00:00
nacin 2d07cd3fc5 Theme Customizer: Remove background_image_thumb when saving settings. fixes #20871.
This prevents the background_image and background_image_thumb settings from getting out of sync.
In 3.5 we can consider using background-size on Appearance > Background, eliminating _thumb.



git-svn-id: http://core.svn.wordpress.org/trunk@21053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 20:49:45 +00:00
westi cd8c0e74ab Restore the 'extra_theme_headers' filter in the deprecated get_theme_data function so that plugins/themes using this function can still access their extra headers.
Fixes #20897 props nacin, georgestephanis, SergeyBiryukov.


git-svn-id: http://core.svn.wordpress.org/trunk@21050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 17:30:57 +00:00
ryan 7351bce967 Escape editable_slug as a textarea.
git-svn-id: http://core.svn.wordpress.org/trunk@21049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 17:58:57 +00:00
ryan d4311fb73e Make read_post more useful. Map read_post to edit_post for posts with protected post states. This makes read_post work naturally for draft, future, and pending posts belonging to other users. If the current user cannot edit these non-public posts then the user should not be able to read them either.
git-svn-id: http://core.svn.wordpress.org/trunk@21046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 16:21:44 +00:00
bumpbot 8753c6739e Compress scripts/styles: 3.4-RC2-21043.
git-svn-id: http://core.svn.wordpress.org/trunk@21043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 14:38:44 +00:00
bumpbot 4e735c5227 Compress scripts/styles: 3.4-RC2-21038.
git-svn-id: http://core.svn.wordpress.org/trunk@21038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 00:32:52 +00:00
ryan 808ce796ae * Introduce remove_header_image(), reset_header_image(), set_header_image(), and get_header_image_data() for Custom_Image_Header.
* Handle all set/get of header theme mod through these methods.
* Use these methods in the customizer.

Props kovshenin, nacin, SergeyBiryukov, koopersmith.
fixes #20871


git-svn-id: http://core.svn.wordpress.org/trunk@21037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 00:32:19 +00:00
bumpbot 7812d7ba2f Compress scripts/styles: 3.4-RC2-21036.
git-svn-id: http://core.svn.wordpress.org/trunk@21036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-09 15:58:24 +00:00
ryan 4fbec0661f Fix comment hotkeys for FF and IE. Props azaozz, SergeyBiryukov. fixes #20885
git-svn-id: http://core.svn.wordpress.org/trunk@21035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-09 15:57:11 +00:00
bumpbot e04cfd76f5 Compress scripts/styles: 3.4-RC2-21034.
git-svn-id: http://core.svn.wordpress.org/trunk@21034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 23:02:40 +00:00
koopersmith 6c273ba9e4 Theme Customizer: Separate message url from preview url in customizer JS Previewer and PreviewFrame objects. fixes #20892.
git-svn-id: http://core.svn.wordpress.org/trunk@21033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 22:59:48 +00:00
bumpbot 82e9205d58 Compress scripts/styles: 3.4-RC2-21032.
git-svn-id: http://core.svn.wordpress.org/trunk@21032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 19:40:31 +00:00
ryan 9115435213 Customizer: Gravefully handle cookie expipration. Prompt for log in in the preview. Props ocean90, koopersmith, nacin. fixes #20876
git-svn-id: http://core.svn.wordpress.org/trunk@21031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 19:22:11 +00:00
bumpbot dce23895de Compress scripts/styles: 3.4-RC2-21030.
git-svn-id: http://core.svn.wordpress.org/trunk@21030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:58:24 +00:00
ryan f826e49a72 Customizer: fix stuck urls and preview white screens after repeated save and activates. Props koopersmith. fixes #20868
git-svn-id: http://core.svn.wordpress.org/trunk@21029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:52:44 +00:00
ryan 69ad7a68ff Customizer: Redirect back to referrer. If referrer is a front end page, load that page in the customizer preview. Props nacin, koopersmith. fixes #20877
git-svn-id: http://core.svn.wordpress.org/trunk@21028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-08 18:45:12 +00:00
nacin c819e450a1 Remove the set_theme_mods() method from customize manager. We ended up not using it. see #20871.
git-svn-id: http://core.svn.wordpress.org/trunk@21027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 23:33:00 +00:00
bumpbot 3f729457f4 Compress scripts/styles: 3.4-RC2-21026.
git-svn-id: http://core.svn.wordpress.org/trunk@21026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 22:58:22 +00:00
ryan 6e0e62a063 Customizer: Add keyup events to sync textarea values. Props koopersmith. fixes #20879
git-svn-id: http://core.svn.wordpress.org/trunk@21024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 22:00:59 +00:00
bumpbot 882813ef82 Compress scripts/styles: 3.4-RC2-21023.
git-svn-id: http://core.svn.wordpress.org/trunk@21023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 17:58:27 +00:00
nacin f70f85b6bb 3.4-RC2-21020
git-svn-id: http://core.svn.wordpress.org/trunk@21020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 15:26:37 +00:00
nacin 761273807a Call auth_redirect() for customize.php. props ocean90. fixes #20872.
git-svn-id: http://core.svn.wordpress.org/trunk@21019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 15:25:45 +00:00
ryan 39cfdaf149 RC2 bump
git-svn-id: http://core.svn.wordpress.org/trunk@21018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:52:53 +00:00
bumpbot d356284803 Compress scripts/styles: 3.4-RC1-21017.
git-svn-id: http://core.svn.wordpress.org/trunk@21017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:31:49 +00:00
ryan 07140847b2 Namespace the customize request arg to prevent collision with plugins and themes. Props nacin. fixes #20862
git-svn-id: http://core.svn.wordpress.org/trunk@21016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:29:57 +00:00
bumpbot d15f104e4b Compress scripts/styles: 3.4-RC1-21015.
git-svn-id: http://core.svn.wordpress.org/trunk@21015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:51:13 +00:00
koopersmith 14f04132af Theme Customizer: Fix scrolling on iOS and Kindle Fire. props azaozz, helenyhou. fixes #20805.
Also fixes uploader UIs on iOS and Kindle Fire by improving wp.Uploader.
Adds mobile viewport specifications.
Moves scrollbar back to fixed positioning.


git-svn-id: http://core.svn.wordpress.org/trunk@21014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:45:17 +00:00
ryan d7a9a9a231 Don't resurrect a removed default image when changing colors in the Customizer. Props koopersmith, nacin. fixes #20448
git-svn-id: http://core.svn.wordpress.org/trunk@21013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:24:22 +00:00
bumpbot a17441a7e3 Compress scripts/styles: 3.4-RC1-21011.
git-svn-id: http://core.svn.wordpress.org/trunk@21011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 20:58:20 +00:00
nacin 98b61d9a17 Theme Customizer: Block non-existent or non-allowed themes, unless the non-allowed theme is the active theme. Support a user having edit_theme_options xor switch_themes. fixes #20852.
git-svn-id: http://core.svn.wordpress.org/trunk@21010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 20:34:24 +00:00
bumpbot 53b7eae7dd Compress scripts/styles: 3.4-RC1-21007.
git-svn-id: http://core.svn.wordpress.org/trunk@21007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 20:58:24 +00:00
bumpbot e14451d9f6 Compress scripts/styles: 3.4-RC1-21005.
git-svn-id: http://core.svn.wordpress.org/trunk@21005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:58:25 +00:00
nacin 3ebea2f218 Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.
* Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
 * Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
 * Ties user suggestions to a single .wp-suggest-user class.

with help from markjaquith, helenyhou, wonderboymusic. 
fixes #20835.



git-svn-id: http://core.svn.wordpress.org/trunk@21003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:51:33 +00:00
nacin 5cba80ee25 Add some comments to _custom_background_cb() to explain the logic. see #20448.
git-svn-id: http://core.svn.wordpress.org/trunk@21002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:44:31 +00:00
ryan 64e6663569 Fix removing the default background image for themes that hard-code the default in css. Honor the default background image for themes that do not provide a fallback in css.
* <style> will appear if there is a default image registered. This is the same as 3.3.
* If only a default color is registered, it still assumes it is in the stylesheet, and no <style> will appear. This is a change from 3.3.
* <style> will continue to appear as before if there is a custom background color or image. This is the same as 3.3.
* This then allows for a default background image with background-image: none, overriding style.css. This is new.

Props nacin
see #20448


git-svn-id: http://core.svn.wordpress.org/trunk@21001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:35:31 +00:00
bumpbot 05393d38f0 Compress scripts/styles: 3.4-RC1-21000.
git-svn-id: http://core.svn.wordpress.org/trunk@21000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 17:58:23 +00:00
nacin 92efcbaf6d Combine 'Invalid term ID.' into the 'Invalid term ID' string. props pavelevap. fixes #20809.
git-svn-id: http://core.svn.wordpress.org/trunk@20996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 16:25:05 +00:00
koopersmith 1bfc2ee613 Theme Customizer: Add an inline html5 shiv to the preview to ensure html5 elements render properly. props SergeyBiryukov, fixes #20755.
git-svn-id: http://core.svn.wordpress.org/trunk@20995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 12:26:57 +00:00
bumpbot 14aacd2bca Compress scripts/styles: 3.4-RC1-20992.
git-svn-id: http://core.svn.wordpress.org/trunk@20992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 17:58:27 +00:00
ryan 8dfe243dd4 Update Fire browser detection. Handle silke mode. Props azaozz, nacin, georgestephanis. fixes #20014
git-svn-id: http://core.svn.wordpress.org/trunk@20990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 16:04:54 +00:00
bumpbot d35556e69a Compress scripts/styles: 3.4-RC1-20989.
git-svn-id: http://core.svn.wordpress.org/trunk@20989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 15:58:26 +00:00
ryan e69299af51 Theme Customizer: Fix race condition in previewer and use message channels. Props koopersmith. fixes #20811
git-svn-id: http://core.svn.wordpress.org/trunk@20988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 15:51:46 +00:00
bumpbot 811d4d517d Compress scripts/styles: 3.4-RC1-20985.
git-svn-id: http://core.svn.wordpress.org/trunk@20985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 14:58:23 +00:00
bumpbot 9b23e86b63 Compress scripts/styles: 3.4-RC1-20979.
git-svn-id: http://core.svn.wordpress.org/trunk@20979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-02 01:58:27 +00:00
azaozz cb71d2fe62 Fix notice in wp_read_image_metadata() when EXIF ISOSpeedRatings is array, props nacin, fixes #20807
git-svn-id: http://core.svn.wordpress.org/trunk@20978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-02 01:39:00 +00:00
ryan 01dd4131b8 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
git-svn-id: http://core.svn.wordpress.org/trunk@20974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:47:08 +00:00
ryan 0f1f59b092 Custom background fixes:
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.

Props nacin, kobenland
fixes #20448


git-svn-id: http://core.svn.wordpress.org/trunk@20973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:31:50 +00:00
ryan eaa419dba3 Consolodate some strings. Props pavelevap. fixes #20809
git-svn-id: http://core.svn.wordpress.org/trunk@20972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 19:05:30 +00:00
bumpbot ba20e754d1 Compress scripts/styles: 3.4-RC1-20970.
git-svn-id: http://core.svn.wordpress.org/trunk@20970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 15:58:23 +00:00