This change switches out sprintf for printf on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a <span aria-hidden="true"> to prevent both the button text and the screen reader text from being spoken.
Props mukesh27, SergeyBiryukov, sabernhardt, desrosj.
Merges [50585] to the 5.7 branch.
Fixes#52891.
Built from https://develop.svn.wordpress.org/branches/5.7@50609
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.
This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.
Merges [50596] to the 5.7 branch.
See #52704.
Built from https://develop.svn.wordpress.org/branches/5.7@50597
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.
On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.
This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.
Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.
Merges [50590] to the 5.7 branch.
See #52653.
Built from https://develop.svn.wordpress.org/branches/5.7@50591
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.
Follow-up to [50465].
Props joseeyoast, audrasjb, SergeyBiryukov.
Merges [50534] to the 5.7 branch.
Fixes#52816.
Built from https://develop.svn.wordpress.org/branches/5.7@50588
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.
This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.
Props Cybr, flixos90, SergeyBiryukov.
Merges [50566] to the 5.7 branch.
Fixes#52713.
Built from https://develop.svn.wordpress.org/branches/5.7@50587
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Merges [50568] to the 5.7 branch.
Fixes#52751.
Built from https://develop.svn.wordpress.org/branches/5.7@50574
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.
Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Merges [50567] to the 5.7 branch.
Fixes#52787.
Built from https://develop.svn.wordpress.org/branches/5.7@50573
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Merges [50535] to the 5.7 branch.
Fixes#52758.
Built from https://develop.svn.wordpress.org/branches/5.7@50536
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:
- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3
Reviewed by desrosj, williampatton.
Merges [50507] to the 5.7 branch.
Fixes#52704.
Built from https://develop.svn.wordpress.org/branches/5.7@50508
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.
This is a regression that was introduced in [49987].
Props hellofromTonya, poena, paaljoachim, ryelle.
Merges [50493] to the 5.7 branch.
Fixes#52702.
Built from https://develop.svn.wordpress.org/branches/5.7@50494
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [50478] to the 5.7 branch.
Fixes#52693. See #52347.
Built from https://develop.svn.wordpress.org/branches/5.7@50480
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changes the logic in `update_https_detection_errors()` to never store error messages from the actual request since they could use a different encoding, which would make storing them in an option potentially fail, leading WordPress to then falsely assume that HTTPS is supported.
While this doesn't actually fix the encoding issue, it is not crucial to do so anyway, since these messages are not used anywhere. A simple differentiation between whether the overall HTTPS request or only the SSL verification failed should be sufficient for the purpose of this function.
Props flixos90, tmatsuur, lukecarbis.
Reviewed by flixos90, SergeyBiryukov.
Merges [50471] to the 5.7 branch.
Fixes#52484.
Built from https://develop.svn.wordpress.org/branches/5.7@50472
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adjust the background color palette rules so they don't show up on inner containers when they're not supposed to:
- When an inner container block is present, it only applies them to direct children of the block with the background color assigned.
- Since the background color should only be applied to the Cover block's overlay, not to the inner container, it opts that specific block out of this rule.
Props dianeco, kjellr, paaljoachim.
Reviewed by ryelle, SergeyBiryukov.
Merges [50466] to the 5.7 branch.
Fixes#52676.
Built from https://develop.svn.wordpress.org/branches/5.7@50469
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.
Props antonlukin, paaljoachim, felipeelia.
Reviewed by ryelle, SergeyBiryukov.
Merges [50465] to the 5.7 branch.
Fixes#52646.
Built from https://develop.svn.wordpress.org/branches/5.7@50468
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
* Switch back to running the PHPUnit test suite against the `src` directory instead of `build`
* Increase the reliability of backing up the `mu-plugins` directory during tests
* Split the PHPUnit tests for PHP versions below 7.0 in half, allowing them to run in parallel and reduce the overall test run duration on GitHub Actions
Merges [50441-50444] to the 5.7 branch.
Fixes#51734, #51735, #52645
Built from https://develop.svn.wordpress.org/branches/5.7@50464
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, jQuery 1.12.4 was added to the WordPress SVN repo in order to backport an upstream security patch from jQuery 3.4.0.
Now that WordPress includes an unmodified version of jQuery 3.5.1 and no longer needs to maintain a fork, it can be removed from the SVN repo and installed via NPM again as part of the build.
Follow-up to [45342], [49101].
Props peterwilsoncc, SergeyBiryukov.
Merges [50445] to the 5.7 branch.
Fixes#52647.
Built from https://develop.svn.wordpress.org/branches/5.7@50457
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sergey Biryukov
davidbaumwald
desrosj
Peter Wilson
ryelle
noisysocks
Mike Schroder
John Blackbourn