Aaron Jorbin
6af8a5d48c
Set a whitelist for PHPUnit code coverage.
...
PHPUnit requires a whitelist as of version 5 in order to generate code coverage. See https://github.com/sebastianbergmann/phpunit-documentation/issues/335 .
Fixes #36867 .
Built from https://develop.svn.wordpress.org/trunk@37449
git-svn-id: http://core.svn.wordpress.org/trunk@37417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:23:28 +00:00
Pascal Birchler
eeadf35fa9
Bootstrap/Load: Silence `ini_set()` in `wp_debug_mode()`.
...
Props SergeyBiryukov.
Fixes #36708 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37448
git-svn-id: http://core.svn.wordpress.org/trunk@37416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:22:28 +00:00
Aaron Jorbin
c4752b1bf9
Correct usage of Covers for Tests_Update_Comment_Count_Now
...
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with ::. See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers
[37445] for trunk
See #35060 , #36867
Built from https://develop.svn.wordpress.org/trunk@37447
git-svn-id: http://core.svn.wordpress.org/trunk@37415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:20:27 +00:00
Ella Iseulde Van Dorpe
6e72bc4ec5
TinyMCE: use new non-editable implementation
...
Use TinyMCE's implementation of `contenteditable="false"` for views.
First pass.
See #36434 .
Built from https://develop.svn.wordpress.org/trunk@37446
git-svn-id: http://core.svn.wordpress.org/trunk@37414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 18:49:30 +00:00
Ryan McCue
691d445d68
REST API: Use prepared JSON data correctly.
...
This was modifying a variable that was never used. Oops.
Fixes #36358 .
Props jrf.
Built from https://develop.svn.wordpress.org/trunk@37444
git-svn-id: http://core.svn.wordpress.org/trunk@37412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 03:55:29 +00:00
Boone Gorges
1cfeaada73
Tests: Use factory method to generate fixtures for `wp_unique_post_slug()` tests.
...
Props mintindeed.
See #20419 .
Built from https://develop.svn.wordpress.org/trunk@37443
git-svn-id: http://core.svn.wordpress.org/trunk@37411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:49:28 +00:00
Helen Hou-Sandí
848501711a
System font: The stack does not work with the `font` shorthand property.
...
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37442
git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:45:27 +00:00
Dominik Schilling
693dfe3453
Editor: Merge two strings.
...
Props pavelevap.
See #27756 .
Built from https://develop.svn.wordpress.org/trunk@37441
git-svn-id: http://core.svn.wordpress.org/trunk@37407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 18:57:29 +00:00
Dominik Schilling
a673a71f94
I18N: In `get_translations_for_domain()` check if the global `$l10n` was set by `_load_textdomain_just_in_time()` before accessing it.
...
Props danielhuesken.
Fixes #34114 .
Built from https://develop.svn.wordpress.org/trunk@37440
git-svn-id: http://core.svn.wordpress.org/trunk@37406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 15:10:29 +00:00
Andrea Fercia
1ae8891261
Accessibility: make the tab order match the visual order in the Edit terms screens.
...
Fixes #35664 .
Built from https://develop.svn.wordpress.org/trunk@37439
git-svn-id: http://core.svn.wordpress.org/trunk@37405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 13:02:29 +00:00
Dominik Schilling
8c0c57b9f9
Version bump.
...
Fixes #36845 .
Built from https://develop.svn.wordpress.org/trunk@37438
git-svn-id: http://core.svn.wordpress.org/trunk@37404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 10:24:30 +00:00
Weston Ruter
dcf6cf3615
Customize: Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer.
...
Clicking on the Edit Menu button focuses on the corresponding nav menu section. Upon collapsing the nav menu section, the focus is returned to the Custom Menu widget instead of taking the user to the menus root panel. In this way, the back button behavior is modified once to serve as breadcrumb/history navigation. The Edit Menu button with the breadcrumb back button behavior greatly reduce the number of UI interactions needed to edit a menu referenced in a Custom Menu widget.
Props celloexpressions, westonruter.
Fixes #32683 .
Built from https://develop.svn.wordpress.org/trunk@37437
git-svn-id: http://core.svn.wordpress.org/trunk@37403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 07:22:30 +00:00
Ryan McCue
6da21bc4f4
HTTP API: Pass array-like object to http_api_debug.
...
This was mistakingly passing the Requests_Response object, which caused fatal errors with debugging tools.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37436
git-svn-id: http://core.svn.wordpress.org/trunk@37402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 06:12:29 +00:00
Joe McGill
bdfd58c8cf
Media: Remove medium_large size from `$whitelist_options['media']` in `options.php`.
...
The `medium_large_size_w` and `medium_large_size_h` options were added to the
$whitelist_options['media'] in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.
Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.
Fixes #36531 .
Built from https://develop.svn.wordpress.org/trunk@37435
git-svn-id: http://core.svn.wordpress.org/trunk@37401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-15 22:38:29 +00:00
Dominik Schilling
944a69df87
Credits: Add a missing closing tag.
...
Props ramiy for initial patch.
Fixes #35911 .
Built from https://develop.svn.wordpress.org/trunk@37434
git-svn-id: http://core.svn.wordpress.org/trunk@37400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-14 18:58:31 +00:00
Dominik Schilling
52d30beb3c
External Libraries: Update jQuery to 1.12.4-pre.
...
This version includes a fix for the media library which didn't open under certain conditions. The issue was tracked upstream as "Specific table CSS style breaks `.is(':visible')`", see https://github.com/jquery/jquery/issues/3065 .
Also fixed: "Element which is not in page is still :visible in IE8", see https://github.com/jquery/jquery/issues/3043 .
Changelog: https://github.com/jquery/jquery/compare/1.12.3...376caf4d
See #36533 .
Built from https://develop.svn.wordpress.org/trunk@37433
git-svn-id: http://core.svn.wordpress.org/trunk@37399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 21:15:27 +00:00
Dominik Schilling
f81b65688a
Upgrader: Add changelog entries for when the classes were moved to its own file.
...
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37432
git-svn-id: http://core.svn.wordpress.org/trunk@37398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 20:59:27 +00:00
Drew Jaynes
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Ryan McCue
1e40ba291e
HTTP API: Fix compatibility with cURL <7.22
...
Ensure connections are closed after usage to fix an issue with WP.com URLs used in the tests.
Resynched from GitHub at 95518ce.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37430
git-svn-id: http://core.svn.wordpress.org/trunk@37396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 11:15:29 +00:00
Ryan McCue
dee1d583a7
HTTP API: Add browser compatibility hook for 3xx redirects.
...
WordPress erroneously follows browser-style behaviour with 3xx redirects, where a POST to 302 becomes a GET. Requests instead follows the specification and keeps the same method. Requests also exposes a hook to allow changing the behaviour.
[37428] used the wrong method of adding this hook, now corrected.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37429
git-svn-id: http://core.svn.wordpress.org/trunk@37395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 05:11:27 +00:00
Ryan McCue
37f6e6813a
HTTP API: Replace internals with Requests library.
...
Requests is a library very similar to WP_HTTP, with a high level of unit test coverage, and has a common lineage and development team. It also supports parallel requests.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37428
git-svn-id: http://core.svn.wordpress.org/trunk@37394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 04:42:28 +00:00
Dominik Schilling
65f5fe6fb2
Widgets: Create `WP_Widget_Mock` as a mock of `WP_Widget` which can be used for widget tests.
...
You cannot instantiate an abstract class. Not even in WordPress world.
See #35981 .
Built from https://develop.svn.wordpress.org/trunk@37427
git-svn-id: http://core.svn.wordpress.org/trunk@37393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 21:25:27 +00:00
Weston Ruter
b036bf1012
Customize: Clean up media control CSS.
...
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.
Props celloexpressions.
Fixes #30618 .
Built from https://develop.svn.wordpress.org/trunk@37426
git-svn-id: http://core.svn.wordpress.org/trunk@37392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 20:23:54 +00:00
Dominik Schilling
97fc82a879
Widgets: Make `WP_Widget` a real abstract class.
...
This removes the `die()` call from `WP_Widget::widget()` and converts it to an abstract method.
`WP_Widgets` (later renamed to `WP_Widget`) was introduced in [10764] where the minimum PHP requirement was 4.3, thus no `abstract` was available.
Props johnbillion.
Fixes #35981 .
Built from https://develop.svn.wordpress.org/trunk@37425
git-svn-id: http://core.svn.wordpress.org/trunk@37391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 20:23:28 +00:00
Dominik Schilling
7f1abd441f
Posts: Fire a `post_action_{$action}` action for a custom post action request.
...
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056 .
Built from https://develop.svn.wordpress.org/trunk@37424
git-svn-id: http://core.svn.wordpress.org/trunk@37390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:44:28 +00:00
Rachel Baker
00adb457d2
Comments: Add `$data` parameter to include the comment data in the `edit_comment` action.
...
Props dshanske.
Fixes #36427 .
Built from https://develop.svn.wordpress.org/trunk@37423
git-svn-id: http://core.svn.wordpress.org/trunk@37389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:37:27 +00:00
Dominik Schilling
251274abf6
List Tables: Pass the `$which` parameter to `restrict_manage_posts` and `restrict_manage_users`.
...
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.
Props martin.krcho.
Fixes #35307 .
Built from https://develop.svn.wordpress.org/trunk@37422
git-svn-id: http://core.svn.wordpress.org/trunk@37388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:13:27 +00:00
Dominik Schilling
546b031453
Filesystem API: Don't add `'.'` to the list of directories which need to be checked/created when extracting a file.
...
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.
Props tfrommen.
Fixes #36570 .
Built from https://develop.svn.wordpress.org/trunk@37421
git-svn-id: http://core.svn.wordpress.org/trunk@37387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 12:40:28 +00:00
Helen Hou-Sandí
a726a9f51f
Admin font: Remove a redundant `sans-serif` declaration.
...
props samantha-miller.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37419
git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 02:14:28 +00:00
Jeremy Felt
283c367df7
Tests: Set `public` to `1` in the default blog factory
...
When no `$meta` arguments are passed to `wpmu_create_blog()`, `public` is set to `0` in the database for new sites. This is fine, but also does not match the default implied when most sites are created via `site-new.php`.
The only current use of the `$meta` argument in the tests is to (re)mark `public` as `0`. All existing tests pass with this change. Tests for `WP_Site_Query` can now rely on better default expectations.
See #36566 .
Built from https://develop.svn.wordpress.org/trunk@37418
git-svn-id: http://core.svn.wordpress.org/trunk@37384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-11 19:22:27 +00:00
Weston Ruter
b074113016
Customize: Remove use of reserved word `default` in Underscore template which breaks IE8.
...
Fixes regression introduced in r30712.
Props adamsilverstein.
Fixes #36793 .
Built from https://develop.svn.wordpress.org/trunk@37417
git-svn-id: http://core.svn.wordpress.org/trunk@37383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-11 19:07:30 +00:00
Pascal Birchler
64fb1a9e90
I18N: Add changes missed in [37415].
...
See #34114 .
Built from https://develop.svn.wordpress.org/trunk@37416
git-svn-id: http://core.svn.wordpress.org/trunk@37382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 20:31:27 +00:00
Pascal Birchler
751234a580
I18N: Remove the requirement to call `load_plugin_textdomain()` / `load_theme_textdomain()`.
...
By initially scanning the `wp-content/languages` directory and loading available MO files just-in-time, plugins and themes do not need to manually load text domains anymore.
Props swissspidy, ocean90.
Fixes #34114
Built from https://develop.svn.wordpress.org/trunk@37415
git-svn-id: http://core.svn.wordpress.org/trunk@37381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 20:05:29 +00:00
Pascal Birchler
3f6966907b
I18N: Reverse the order of loading plugin and theme translations.
...
`load_theme_textdomain()`, `load_plugin_textdomain()` and `load_muplugin_textdomain()` now try to load the .mo file from the `wp-content/languages` directory first. After the introduction of language packs, translation files are more likely to be located there.
Props swissspidy, sebastian.pisula.
Fixes #34213 .
Built from https://develop.svn.wordpress.org/trunk@37414
git-svn-id: http://core.svn.wordpress.org/trunk@37380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 18:50:27 +00:00
Dominik Schilling
1564bd2c1f
Upgrader: Remove debug cruft.
...
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37413
git-svn-id: http://core.svn.wordpress.org/trunk@37379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 18:32:28 +00:00
Dominik Schilling
a8525b1109
Upgrader: After [37409] move the hook docs for `upgrader_process_complete` to `WP_Upgrader::run()`.
...
Add changelog entry for [23912].
Part 7/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37412
git-svn-id: http://core.svn.wordpress.org/trunk@37378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 12:20:27 +00:00
Dominik Schilling
5844c585f6
Upgrader: Update `wp-admin/includes/class-wp-upgrader.php` to `require_once` the new files added in [37406] and [37409].
...
Part 6/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37411
git-svn-id: http://core.svn.wordpress.org/trunk@37377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:59:27 +00:00
Dominik Schilling
23e2a486ae
Upgrader: Update file headers for new files added in [37409].
...
Part 5/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37410
git-svn-id: http://core.svn.wordpress.org/trunk@37376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:52:28 +00:00
Dominik Schilling
14e5d77132
Upgrader: Copy `WP_Upgrader` subclasses into one file per class.
...
Part 4/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37409
git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:45:42 +00:00
Dominik Schilling
5f1ac9c96d
Upgrader: Update `wp-admin/includes/class-wp-upgrader-skins.php` to `require_once` the new files added in [37406].
...
Part 3/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37408
git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:42:26 +00:00
Dominik Schilling
4b846677ba
Upgrader: Update file headers and class DocBlocks for new files added in [37406].
...
Part 2/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37407
git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:31:28 +00:00
Dominik Schilling
bbecb1a485
Upgrader: Copy `WP_Upgrader_Skin` and its subclasses into one file per class.
...
Part 1/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37406
git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:11:30 +00:00
Weston Ruter
574be8f2a8
Customize: Ensure that `wp_setup_nav_menu_item` filter applies consistently on `nav_menu_item` setting values.
...
The filter was being applied in `WP_Customize_Nav_Menu_Item_Setting::value()` but not in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.
Props celloexpressions, westonruter.
Fixes #35203 .
Built from https://develop.svn.wordpress.org/trunk@37405
git-svn-id: http://core.svn.wordpress.org/trunk@37371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 06:41:29 +00:00
Dominik Schilling
096d0ccd63
Tests: Don't create unused users in `Tests_Ajax_DeleteComment`.
...
Fixes #36616 .
Built from https://develop.svn.wordpress.org/trunk@37404
git-svn-id: http://core.svn.wordpress.org/trunk@37370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-09 19:17:29 +00:00
Sergey Biryukov
ff37a3b730
Docs: Fix typo in a comment in `check_and_publish_future_post()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37403
git-svn-id: http://core.svn.wordpress.org/trunk@37369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-08 12:46:29 +00:00
Dominik Schilling
b5718124c3
External Libraries: Replace `split()` with `explode()` in the deprecated Atom and MagpieRSS files.
...
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.
Props achbed.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37402
git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-07 15:59:29 +00:00
Nikolay Bachiyski
c33e975f46
External Libraries: Update plupload from upstream
...
Built from https://develop.svn.wordpress.org/trunk@37383
git-svn-id: http://core.svn.wordpress.org/trunk@37349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:02:26 +00:00
Dominik Schilling
a493dc0ab5
External Libraries: Update MediaElement.js from upstream.
...
Built from https://develop.svn.wordpress.org/trunk@37370
git-svn-id: http://core.svn.wordpress.org/trunk@37336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 17:51:36 +00:00
Sergey Biryukov
b65cbd6003
Options: After [33738], consistently pass option name as the second parameter to the `'default_option_' . $option` filter in `add_option()` and `update_option()`.
...
Props dlh.
Fixes #36761 .
Built from https://develop.svn.wordpress.org/trunk@37367
git-svn-id: http://core.svn.wordpress.org/trunk@37333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:24:29 +00:00
Drew Jaynes
2459e4e880
Docs: Remove backticks from the DocBlock summary for `WP::$request`, added in [37356].
...
Markdown formatting is not supported in DocBlock summaries, per the inline documentation standards for PHP :-)
See #32246 . See #36674 .
Built from https://develop.svn.wordpress.org/trunk@37366
git-svn-id: http://core.svn.wordpress.org/trunk@37332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:03:27 +00:00