Commit Graph

466 Commits

Author SHA1 Message Date
Drew Jaynes e22597655b Variously inline documentation syntactical fixes in wp-includes/post-template.php.
See #31888.

Built from https://develop.svn.wordpress.org/trunk@32046


git-svn-id: http://core.svn.wordpress.org/trunk@32025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 16:50:29 +00:00
Sergey Biryukov 5f4e2cdba3 Avoid duplicate classes for different terms with UTF-8 slugs in `post_class()` and `body_class()`.
Fall back to term ID if the sanitized slug is numeric or only contains hyphens.

props SergeyBiryukov, A5hleyRich, sgrant, davideugenepratt.
fixes #30883.
Built from https://develop.svn.wordpress.org/trunk@31979


git-svn-id: http://core.svn.wordpress.org/trunk@31958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 01:05:27 +00:00
Dominik Schilling 55519962cc Improve newly added strings for i18n:
* Use a placeholder for the theme name to be able to reorder words.
* Uppercase D for "Theme Details" to match existing strings.
* Merge two revision date formats.
* Add translator comment to strings with placeholders.

props obenland.
see #31776.
Built from https://develop.svn.wordpress.org/trunk@31905


git-svn-id: http://core.svn.wordpress.org/trunk@31884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 20:56:26 +00:00
Dion Hulse cc903c3422 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121

Built from https://develop.svn.wordpress.org/trunk@31862


git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 02:14:27 +00:00
Helen Hou-Sandí 798abe9f78 Allow `is_page_template()` to accept an array, as many other conditional tags do.
props morganestes, tyxla, DrewAPicture.
fixes #31271.

Built from https://develop.svn.wordpress.org/trunk@31754


git-svn-id: http://core.svn.wordpress.org/trunk@31735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 16:28:27 +00:00
Helen Hou-Sandí c16129d3cf Enable more flexibility for non-URL GUIDs.
props stevenkword.
fixes #31080.

Built from https://develop.svn.wordpress.org/trunk@31726


git-svn-id: http://core.svn.wordpress.org/trunk@31707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 20:00:26 +00:00
Scott Taylor 8f0b626d13 Introduce a function, `wp_attachment_is( $type, $post = 0 )`, to collapse the logic for determining whether an attachment is an `image`, `audio`, or `video`.
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.

Built from https://develop.svn.wordpress.org/trunk@31645


git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 20:26:26 +00:00
Drew Jaynes bc378b8de1 Properly indent the hash notation of default arguments for `wp_page_menu()`.
See #28841.

Built from https://develop.svn.wordpress.org/trunk@31600


git-svn-id: http://core.svn.wordpress.org/trunk@31581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 06:16:26 +00:00
Sergey Biryukov 97698eb127 Always pass back the custom classes `get_post_class()` was called with, even if the post was not found.
props F J Kaiser, Bueltge.
fixes #22271.
Built from https://develop.svn.wordpress.org/trunk@31408


git-svn-id: http://core.svn.wordpress.org/trunk@31389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 04:00:26 +00:00
Drew Jaynes 15eaa179df Adjust the DocBlock for `wp_dropdown_pages()` to mark the entire `$args` parameter array as optional instead of each individual argument.
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31356


git-svn-id: http://core.svn.wordpress.org/trunk@31337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 08:56:23 +00:00
Drew Jaynes 19ba9e3715 Add documentation for the `$value_field` argument added to `wp_dropdown_pages()` in [31338].
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31355


git-svn-id: http://core.svn.wordpress.org/trunk@31336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 08:51:23 +00:00
Boone Gorges 14767d6c69 Introduce `'value_field'` parameter to `wp_dropdown_pages()`.
This parameter allows developers to choose the post field that will be used to
fill in the 'option' attribute of the generated dropdown markup.

See [31006] #30306 for a parallel enhancement in `wp_dropdown_categories()`.

Props jfarthing84.
Fixes #12494.
Built from https://develop.svn.wordpress.org/trunk@31338


git-svn-id: http://core.svn.wordpress.org/trunk@31319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:04:23 +00:00
Boone Gorges d1764d86e4 Use hash notation for `wp_dropdown_pages()` argument documentation.
Built from https://develop.svn.wordpress.org/trunk@31337


git-svn-id: http://core.svn.wordpress.org/trunk@31318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:00:25 +00:00
Boone Gorges 04216633b2 Add classes for custom taxonomy terms in `get_post_class()`.
Props sillybean.
Fixes #16223.
Built from https://develop.svn.wordpress.org/trunk@31271


git-svn-id: http://core.svn.wordpress.org/trunk@31252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 15:41:22 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Scott Taylor 786caa4d55 Correct the `@param` docs for arguments that are truthy/falsey.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30983


git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Mark Jaquith 0cf92119eb Revert [30036].
see #18035
Built from https://develop.svn.wordpress.org/trunk@30912


git-svn-id: http://core.svn.wordpress.org/trunk@30902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 17:35:23 +00:00
Drew Jaynes ad297dab6d Correctly capitalize JavaScript throughout core docs.
Fixes #30569.

Built from https://develop.svn.wordpress.org/trunk@30695


git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 00:31:22 +00:00
Scott Taylor 9a8be964b6 Improve the `@param` docs for `src/wp-includes/post*.php`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30671


git-svn-id: http://core.svn.wordpress.org/trunk@30661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 22:37:22 +00:00
Drew Jaynes 3b6c9519a8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape HTML tags in several argument descriptions for `wp_link_pages()`
* Remove an HTML tag from the summary for `prepend_attachment()`
* Backtick-escape inline code in the description for `get_extended()`
* Backtick-escape inline code in the description for `get_post_type_labels()`
* Various markdown formatting in the description for `add_rewrite_endpoint()`
* Markdown-indent a code snippet in the file header for wp-includes/shortcodes.php
* Markdown-indent code snippets in the description for `add_shortcode()

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30545


git-svn-id: http://core.svn.wordpress.org/trunk@30534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:15:24 +00:00
Scott Taylor 849a993269 Check `$_current_page` before using it in `Walker_Page->start_el()`.
Props jeremyfelt.
Fixes #26901.

Built from https://develop.svn.wordpress.org/trunk@30157


git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:29:22 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Dominik Schilling 4df00e156d Improve body class for page templates.
* Convert slash to dash too.
* Add sub-folder name as a separate body class.
* New classes are additional classes, old syntax will persists for BC.

With this `/page-templates/full-width.php` will produce `page-template`, `page-template-page-templates`, `page-template-full-width` and `page-template-page-templatesfull-width-php`.

props obenland, Caspie, donutz.
fixes #23470.
Built from https://develop.svn.wordpress.org/trunk@30100


git-svn-id: http://core.svn.wordpress.org/trunk@30100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:20:23 +00:00
Sergey Biryukov 16bbe9b57b Don't add 'sticky' class in get_post_class() if 'ignore_sticky_posts' query var is set.
props jakub.tyrcha, johneckman.
fixes #18035.
Built from https://develop.svn.wordpress.org/trunk@30036


git-svn-id: http://core.svn.wordpress.org/trunk@30036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-27 02:16:20 +00:00
John Blackbourn 524097970a In `wp_link_pages()`, only output link separators between actual pagination links. Fixes #24940. Props obenland.
Built from https://develop.svn.wordpress.org/trunk@30030


git-svn-id: http://core.svn.wordpress.org/trunk@30030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-26 22:41:18 +00:00
Scott Taylor 72d12b514d Add a 6th (!) attribute to `wp_get_attachment_link()` to allow `aria-describedby` to be added to gallery output.
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402.

Built from https://develop.svn.wordpress.org/trunk@29914


git-svn-id: http://core.svn.wordpress.org/trunk@29667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:28:17 +00:00
Scott Taylor b938bfb7d5 MediaElement upgrade: cleanup for generated markup for videos.
See #29110.

Built from https://develop.svn.wordpress.org/trunk@29429


git-svn-id: http://core.svn.wordpress.org/trunk@29207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:53:15 +00:00
Sergey Biryukov 13d0a0a367 Revert [28963].
see #28006.
Built from https://develop.svn.wordpress.org/trunk@29235


git-svn-id: http://core.svn.wordpress.org/trunk@29019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 00:26:16 +00:00
Drew Jaynes 458ae841ed Convert default arguments documentation for `wp_page_menu()` into a hash notation.
Props coffee2code for the initial patch/
See #28841.

Built from https://develop.svn.wordpress.org/trunk@29112


git-svn-id: http://core.svn.wordpress.org/trunk@28898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 23:13:15 +00:00
Sergey Biryukov 2550fb200a Add 'status-sticky' class in get_post_class() for sticky posts in the admin.
props mordauk, netweb.
fixes #22590.
Built from https://develop.svn.wordpress.org/trunk@29003


git-svn-id: http://core.svn.wordpress.org/trunk@28791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-05 00:13:14 +00:00
Drew Jaynes d4dd02b4ae Remove backticks on `$post` variables in some short parameter descriptions.
See [28653], [28654].
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28976


git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 19:28:14 +00:00
John Blackbourn b8bd46c406 Prepend "Draft:" to draft post titles when previewing on the front end, and add a "single-status-$status" class to the body classes for all post statuses. Fixes #28006. Props hlashbrooke
Built from https://develop.svn.wordpress.org/trunk@28963


git-svn-id: http://core.svn.wordpress.org/trunk@28756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 22:53:14 +00:00
Scott Taylor c8852cc909 Use the `WPINC` constant when loading `class-phpass.php`
Props wojtek.szkutnik
See #14157.

Built from https://develop.svn.wordpress.org/trunk@28903


git-svn-id: http://core.svn.wordpress.org/trunk@28702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 22:12:16 +00:00
Drew Jaynes 5f08eed052 Re-document default arguments in `wp_link_pages()` using the hash-notation style.
Props taylorde.
Fixes #28680.

Built from https://develop.svn.wordpress.org/trunk@28899


git-svn-id: http://core.svn.wordpress.org/trunk@28698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 18:56:16 +00:00
Scott Taylor 13d0a45932 If the `get_the_excerpt()` is called out of bounds of a global `$post`, return ''.
Fixes #22413.

Built from https://develop.svn.wordpress.org/trunk@28880


git-svn-id: http://core.svn.wordpress.org/trunk@28679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-28 04:01:14 +00:00
Scott Taylor c725b77068 Check for the existence of `$post` before using it in `get_the_ID()`. Return `false` if it doesn't exist.
Props UmeshSingla.
Fixes #17034.

Built from https://develop.svn.wordpress.org/trunk@28844


git-svn-id: http://core.svn.wordpress.org/trunk@28648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 02:05:14 +00:00
Sergey Biryukov e85c3deba5 Prevent get_post_class() and get_body_class() from returning duplicate classes.
props Compute.
fixes #28541.
Built from https://develop.svn.wordpress.org/trunk@28760


git-svn-id: http://core.svn.wordpress.org/trunk@28573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 15:18:16 +00:00
Sergey Biryukov 6d7e222ded Use get_pages() instead of a raw SQL query in get_body_class().
fixes #28159.
Built from https://develop.svn.wordpress.org/trunk@28696


git-svn-id: http://core.svn.wordpress.org/trunk@28513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-07 03:22:16 +00:00
Drew Jaynes 3724252959 Ensure `$post_id` is documented as optional where applicable.
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28654


git-svn-id: http://core.svn.wordpress.org/trunk@28472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-03 04:44:16 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable.
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-03 03:53:17 +00:00
Sergey Biryukov ac434b5c39 Pass $post to 'protected_title_format' and 'private_title_format' filters.
props johnjamesjacoby, DrewAPicture.
fixes #23724.
Built from https://develop.svn.wordpress.org/trunk@28571


git-svn-id: http://core.svn.wordpress.org/trunk@28396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-24 06:48:16 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method.
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:00:15 +00:00
Drew Jaynes c7c563532b Improve inline documentation of default arguments for `the_title_attribute()`.
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28498


git-svn-id: http://core.svn.wordpress.org/trunk@28324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 02:28:14 +00:00
Scott Taylor ae61a48489 Set `@param` back to `$output`, not `$html`, in the inline filter docs. This was a copy/paste mistake.
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28419


git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:08:14 +00:00
Scott Taylor a4a5560b22 Eliminate use of `extract()` in `Walker_Page::start_el()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28402


git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:41:15 +00:00
Scott Taylor 7b8d797355 Eliminate use of `extract()` in `wp_list_pages()` which, surprisingly, didn't even use any of the extracted variables.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28401


git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:22:15 +00:00
Scott Taylor 29d8832625 Eliminate use of `extract()` in `wp_dropdown_pages()`.
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28399


git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:12:13 +00:00
Scott Taylor fe2d90ab4f Eliminate use of `extract()` in `wp_link_pages()`.
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28398


git-svn-id: http://core.svn.wordpress.org/trunk@28226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 00:44:14 +00:00
Scott Taylor 92d2c60a65 Eliminate use of `extract()` in `the_title_attribute()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28383


git-svn-id: http://core.svn.wordpress.org/trunk@28211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:48:15 +00:00
Drew Jaynes 9098b45e53 Add inline documentation of the default arguments for `wp_list_pages()`.
Props garza for the initial patches.
Fixes #11338.

Built from https://develop.svn.wordpress.org/trunk@28357


git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 08:02:14 +00:00
Scott Taylor ef34785160 In `wp_get_attachment_link()`, `$post_title` is set and then not used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28331


git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:35:16 +00:00
Sergey Biryukov 0b08cd7a25 Prevent 'paged-*' from being added to body classes on 404 error pages.
props psoluch.
see #16468.
Built from https://develop.svn.wordpress.org/trunk@28249


git-svn-id: http://core.svn.wordpress.org/trunk@28077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:15 +00:00
Scott Taylor 92467fbd63 Fix a regression caused by [27622] in `prepend_attachment()` by passing all attachments that are not audio or video to the `else` clause.
Fixes #27634.


Built from https://develop.svn.wordpress.org/trunk@27908


git-svn-id: http://core.svn.wordpress.org/trunk@27739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 17:14:15 +00:00
Scott Taylor f947924b0a In `wp_list_pages()`, add the `current_page_item` class where applicable when used with a custom post type.
Adds a unit test.

Props nacin.
Fixes #17590.


Built from https://develop.svn.wordpress.org/trunk@27755


git-svn-id: http://core.svn.wordpress.org/trunk@27592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 22:47:14 +00:00
Scott Taylor 8bc15ab4fc Do not use the alternative if/elseif/else syntax in `prepend_attachment()` introduced in [27622], as per kovshenin.
Fixes #27243.


Built from https://develop.svn.wordpress.org/trunk@27682


git-svn-id: http://core.svn.wordpress.org/trunk@27523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 14:39:14 +00:00
Drew Jaynes 0e215d93cd Inline documentation for hooks in wp-includes/post-template.php.
Props Toru and kpdesign.
Fixes #25621.

Built from https://develop.svn.wordpress.org/trunk@27676


git-svn-id: http://core.svn.wordpress.org/trunk@27519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:37:16 +00:00
Scott Taylor b836d650bd On attachment pages for audio and video, display players. Currently, only a link is displayed. Add minimal CSS rules for compatibility with 2011, 2012, and 2013 themes.
In `prepend_attachment`, add logic to support attachment types that are not `image`.

In `get_post_class()`, don't add the `has-post-thumbnail` class for attachment pages.

Fixes #27243.


Built from https://develop.svn.wordpress.org/trunk@27622


git-svn-id: http://core.svn.wordpress.org/trunk@27465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 19:00:14 +00:00
Drew Jaynes da19fc531c Better standardize parameter value types in PHPDocs where both a post ID or `WP_Post` would be acceptable.
Covers cases where previously only `int` or `int|object` types were notated.

Props coffee2code for the original patch.
See #20495.

Built from https://develop.svn.wordpress.org/trunk@27473


git-svn-id: http://core.svn.wordpress.org/trunk@27318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 19:32:16 +00:00
Andrew Nacin cc56dde10c Add has-post-thumbnail as a post class.
props danielbachhuber, frank-klein.
fixes #18804.

Built from https://develop.svn.wordpress.org/trunk@27429


git-svn-id: http://core.svn.wordpress.org/trunk@27276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-06 06:06:14 +00:00
Sergey Biryukov 8fa00f68e7 Display empty-titled pages properly in Walker_PageDropdown, like we do in Walker_Page.
fixes #27218.
Built from https://develop.svn.wordpress.org/trunk@27360


git-svn-id: http://core.svn.wordpress.org/trunk@27210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 22:34:13 +00:00
John Blackbourn be967880e2 Pass along preview query args only if they are already present. Avoids sloppily appending a preview nonce when there should not be one. See #17157.
Built from https://develop.svn.wordpress.org/trunk@27334


git-svn-id: http://core.svn.wordpress.org/trunk@27186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 23:29:14 +00:00
John Blackbourn 9166734ff5 Enable previews for all pages of multi-page posts. Fixes #17157. Props solarissmoke, chrisscott
Built from https://develop.svn.wordpress.org/trunk@27333


git-svn-id: http://core.svn.wordpress.org/trunk@27185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 23:08:13 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Sergey Biryukov 7e969d706e Fix validation issue in get_the_password_form() caused by wpautop().
props andykeith.
fixes #27071.
Built from https://develop.svn.wordpress.org/trunk@27134


git-svn-id: http://core.svn.wordpress.org/trunk@27001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 13:23:13 +00:00
Andrew Nacin 5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin 7b27a47e85 Only add one body class when multiple post types manage to be present for a post type archive due to pre_get_posts manipulation.
fixes #25341.

Built from https://develop.svn.wordpress.org/trunk@25745


git-svn-id: http://core.svn.wordpress.org/trunk@25658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:14:09 +00:00
Helen Hou-Sandí 5760809319 Add classes to menus to indicate that an item has sub-items: `.menu-item-has-children` for `wp_nav_menu()` and `.page_item_has_children` for `wp_page_menu()`. props hotchkissconsulting. fixes #23834.
Built from https://develop.svn.wordpress.org/trunk@25602


git-svn-id: http://core.svn.wordpress.org/trunk@25519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 16:01:09 +00:00
Andrew Nacin 74f42a9dc4 Change 'This post is password protected' to 'This content', for the benefit of custom post types.
props MikeHansenMe.
fixes #23603.

Built from https://develop.svn.wordpress.org/trunk@25582


git-svn-id: http://core.svn.wordpress.org/trunk@25499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 20:29:09 +00:00
Andrew Nacin b07e886ed4 Remove redundant title attributes.
props sabreuse.
see #24766.

Built from https://develop.svn.wordpress.org/trunk@25570


git-svn-id: http://core.svn.wordpress.org/trunk@25488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 14:51:10 +00:00
Sergey Biryukov 48f63d061d Expect a possible array of post types in get_body_class(). props norcross. fixes #25341.
Built from https://develop.svn.wordpress.org/trunk@25471


git-svn-id: http://core.svn.wordpress.org/trunk@25392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-17 08:50:09 +00:00
Andrew Nacin 1ef62770d2 Remove display of 'Previously restored by' in the revisions meta box as it is busted.
Fixes invalid markup (missing closing ul tag) when there was no previously restored revision.

see #25051 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25194


git-svn-id: http://core.svn.wordpress.org/trunk@25166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-31 01:33:09 +00:00
Sergey Biryukov aadd546d48 Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005.
Built from https://develop.svn.wordpress.org/trunk@25028


git-svn-id: http://core.svn.wordpress.org/trunk@25015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 16:25:12 +00:00
Peter Westwood 11f6b487b9 Restore the for/id attributes in the post password for as they are necessary for accessibility tools. Fixes #18729.
Built from https://develop.svn.wordpress.org/trunk@25011


git-svn-id: http://core.svn.wordpress.org/trunk@25005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-07 13:44:32 +00:00
Peter Westwood 09ddd48b07 Make is much easier for a theme to style the Post Password form.
Fixes #18729 props philiparthurmoore for the original patches.

Built from https://develop.svn.wordpress.org/trunk@25010


git-svn-id: http://core.svn.wordpress.org/trunk@25004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-07 13:43:50 +00:00
Mark Jaquith e553e85ebb Remove `$pagenow` global from three functions that don’t use it.
Props jeremyfelt. Fixes #24920.

git-svn-id: http://core.svn.wordpress.org/trunk@24974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-02 04:42:08 +00:00
Mark Jaquith 60c9de28b4 Allow `the_title_attribute()` to receive a `post` argument, and use this in `get_adjacent_post_rel_link()` to make sure tags are stripped from the title output there.
Fixes #24232.

git-svn-id: http://core.svn.wordpress.org/trunk@24783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 16:05:40 +00:00
Andrew Nacin 092a33115c Remove wp_parse_post_content(), get_paged_content(), paginate_content() from 3.6, and remove the new $id parameters for get_the_content() and the_content().
The content parsing functions are good abstractions, but are no longer needed by core and are too closely tied to legacy globals, rather than paving a new path.

For get_the_content() and the_content(), this only worsens the function prototype. It muddies theme-specific display (more links, etc) with filtered content. `apply_filters( 'the_content', $post->post_content )` is sufficient practice for now.

see #24330, [24301]. see #23625, [23804].



git-svn-id: http://core.svn.wordpress.org/trunk@24598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 05:22:50 +00:00
Mark Jaquith 92af914abe Keep the Nav Menu walker from blowing up the layout on empty-titled items.
fixes #23254. props cais, SergeyBiryukov.

git-svn-id: http://core.svn.wordpress.org/trunk@24560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:41:46 +00:00
Mark Jaquith 12ec3e4d69 Hide the Revisions meta box content if no-JS, as JS is required to actually do anything with revisions.
fixes #24405. props DrewAPicture, MikeHansenMe.

git-svn-id: http://core.svn.wordpress.org/trunk@24557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:04:24 +00:00
Sergey Biryukov 58c364947f PHPDoc fixes and additions. fixes #24616.
git-svn-id: http://core.svn.wordpress.org/trunk@24490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 12:45:11 +00:00
Andrew Nacin 95800ae4f2 Validate post password hash.
git-svn-id: http://core.svn.wordpress.org/trunk@24466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 03:00:26 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Ryan Boren 99dc867670 Use the global post rather than the global post ID. They don't always match, and the global post is more canonical.
see #24330


git-svn-id: http://core.svn.wordpress.org/trunk@24336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 18:16:24 +00:00
Ryan Boren a2b4bc456f * Introduce wp_parse_post_content() and use it in setup_postdata(), get_the_content(), and get_the_remaining_content().
* Add a post ID argument to the_content(), get_the_content(), the_remaining_content(), and get_the_remaining_content().
* Pass the post ID to the the_content filter.
* Remove the format_pages global.
* Declare format_content and split_content as vars in WP_Post.
* phpdoc for the the_content filter that documents the new ID argument and denotes it as not-so-portable.

Props gcorne, DrewAPicture, duck_, aaroncampbell
see #24330


git-svn-id: http://core.svn.wordpress.org/trunk@24301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 11:05:50 +00:00
Sergey Biryukov 57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Sergey Biryukov 13adb37ce1 Avoid a PHP notice in get_page_template_slug() if the page does not exist. props tollmanz. fixes #24250.
git-svn-id: http://core.svn.wordpress.org/trunk@24191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 18:44:22 +00:00
Dominik Schilling 8ebc1c654e Revisions: Mark deprecated arguments in `wp_list_post_revisions()`.
* Second argument is now a string, which controls the revision type
* Back compat for $args['type']
* Remove lines for the old form-table format, since it's now just a list 

props a.hoereth. fixes #24213.

git-svn-id: http://core.svn.wordpress.org/trunk@24175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-04 12:54:00 +00:00
Dominik Schilling ea1cecebee Revisions UI: Add translation contexts and remove unneeded lines.
props nao. fixes #23917.

git-svn-id: http://core.svn.wordpress.org/trunk@24157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 10:12:19 +00:00
Dominik Schilling 0de35b1035 Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.
git-svn-id: http://core.svn.wordpress.org/trunk@24156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 09:35:35 +00:00
Sergey Biryukov dd1ea44441 Don't translate a single placeholder. Remove unused variables. props settle, DrewAPicture. fixes #24229.
git-svn-id: http://core.svn.wordpress.org/trunk@24150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-01 03:11:44 +00:00
Andrew Nacin 3139a0451e Variables passed by reference do not need to be set first.
props kovshenin.
see #24222.



git-svn-id: http://core.svn.wordpress.org/trunk@24129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 14:48:31 +00:00
Andrew Ozz 44752d0dad Revisions: compare revisions by date in wp_ajax_revisions_data(), deprecate the $parent arg in wp_list_post_revisions() as now revisions always include a copy of the current post, props adamsilverstein, see #23901
git-svn-id: http://core.svn.wordpress.org/trunk@23975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 19:29:21 +00:00
Andrew Ozz 51826e4cde Revisions: remove the new _wp_last_revision_matches_current_post(), can be replaced by a simple revisions version check. Fixes #23913
git-svn-id: http://core.svn.wordpress.org/trunk@23885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-02 19:39:48 +00:00
Mark Jaquith 925e7f5bd6 Make sure the first revision is seen as coming from emptiness, so it can be restored.
props adamsilverstein. fixes #23898.

git-svn-id: http://core.svn.wordpress.org/trunk@23872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:50:09 +00:00
Andrew Ozz 7b831aabd3 Post revisions:
- Always update the revision version when updating post authors.
- Check if revisions have been updated and return early.
- Update the revisions by direct query to avoid resetting post_modified.
- Fix a bug where we may be comparing with an autosave but need to compare with the latest revision.

Fixes #16215.

git-svn-id: http://core.svn.wordpress.org/trunk@23849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 05:28:44 +00:00
Andrew Ozz fd602a987b Fix wp_list_post_revisions() to include all autosaves when listing autosaves only and properly include or exclude the current post, see #23665, see #16215
git-svn-id: http://core.svn.wordpress.org/trunk@23830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-28 00:56:44 +00:00
Mark Jaquith 1b83157127 Give themers tangible, user-friendly template functions to take full advantage of structured post formats.
* the_audio()
* the_video()
* the_image()
* get_the_media()

Also introduces:

* get_the_extra_content()
* the_extra_content()

Those two functions are like their non-extra versions, except that they
will have any post-format bits extracted. e.g. It's an image post, for
which the_image() will extract an <img /> tag. the_extra_content() will
output the content *without* that image.

props wonderboymusic. Herculean effort. fixes #23572

git-svn-id: http://core.svn.wordpress.org/trunk@23819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 18:34:59 +00:00
Peter Westwood 9d6988a221 Revisions: UI Update.
* Refines the UI to make it clearer and easier to use
* Introduces weighted tickmarks
* Fixes comparison bugs.

See #23497 props adamsilverstein


git-svn-id: http://core.svn.wordpress.org/trunk@23769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 15:54:11 +00:00
Ryan Boren dfd8479246 Fix i18n for revision diff strings displaying human time.
Props johnbillion
fixes #23723


git-svn-id: http://core.svn.wordpress.org/trunk@23743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:58:30 +00:00
Andrew Ozz 2c5ad0030f Pass post format as a class to TinyMCE's body, props adamsilverstein, fixes #23198
git-svn-id: http://core.svn.wordpress.org/trunk@23730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 05:57:54 +00:00
Sergey Biryukov 17a24f8400 Make wp_link_pages() filterable. Add 'separator' argument. Simplify the function logic. props obenland, brianlayman. fixes #13578.
git-svn-id: http://core.svn.wordpress.org/trunk@23653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-08 18:33:52 +00:00
Peter Westwood 51db623107 Revisions: Updates to the new Revisions UI.
Various Updates including:
 * i18n fixes
 * Added tracking of what revision ID was restored
 * async fetching of diffs so that slider works sooner even with many revisions

See #23497 props adamsilverstein, ethitter


git-svn-id: http://core.svn.wordpress.org/trunk@23639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 15:32:26 +00:00
Ryan Boren 315bfb019a Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-03 21:11:40 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Peter Westwood 9bd192fab3 Revisions: First pass an implementing a new UI/UX for reviewing the revisions of posts. See #23497 props adamsilverstein for the initial patch.
This implements a new revisions ui using Backbone and preserves all the old methods of "integration" so the change should be transparent to plugins using revisi
ons with CPTs.

This is the first pass and so there are a number of things still to be resolved, more details in the ticket. Feedback welcomed.


git-svn-id: http://core.svn.wordpress.org/trunk@23506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 15:14:34 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Ryan Boren 06ee370814 Pinking shears
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Andrew Nacin 9beec00613 Sanity checks in get_body_class() to ensure we are operating on the type of queried object that we expect. props wonderboymusic. fixes #17662.
git-svn-id: http://core.svn.wordpress.org/trunk@22451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:12:44 +00:00
Ryan Boren 77518e9c71 Objects no longer need to be explicitly passed by ref to call_user_func*() to be callable. Props wonderboymusic. fixes #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 20:00:16 +00:00
Andrew Nacin 830e30031a Add no-customize-support to the body classes when the toolbar is showing. Allows for 'Customize' to be hidden when JS is disabled. props obenland, DrewAPicture. fixes #20896.
git-svn-id: http://core.svn.wordpress.org/trunk@22107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-03 20:54:54 +00:00
Andrew Nacin 7d7498f7ab Don't output the {$post_type} post class in the admin, to avoid clashes with admin CSS. props c3mdigital. fixes #21203.
git-svn-id: http://core.svn.wordpress.org/trunk@21848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-14 18:57:11 +00:00
Ryan Boren 249453b396 phpdoc fixes and additions for post-template.php. Props c3mdigital. fixes #21220
git-svn-id: http://core.svn.wordpress.org/trunk@21799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 20:04:33 +00:00
Ryan Boren d61f2d464c Restore in get_the_excerpt(). Props c3mdigital. fixes #21797
git-svn-id: http://core.svn.wordpress.org/trunk@21767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-05 19:54:08 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
Ryan Boren f56d8278bb Remove return ref from all calls to get_post()
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Ryan Boren 9377523bce Introduce WP_Post class. Clean up ancestors handling. Props scribu, toppa. fixes #10381 see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-20 19:47:52 +00:00
ryan fdae8f9b42 Fix some spelling errors. Props thee17. fixes #21191
git-svn-id: http://core.svn.wordpress.org/trunk@21333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 18:06:13 +00:00
nacin 70791f60b9 Deprecate sticky_class() in favor of post_class(). props solarissmoke, fixes #16675.
git-svn-id: http://core.svn.wordpress.org/trunk@21253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 21:10:59 +00:00
markjaquith c4205b38a4 Do not store post_excerpt in a temporary variable when we can just return it directly. props niallkennedy. fixes #21041
git-svn-id: http://core.svn.wordpress.org/trunk@21159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 19:26:06 +00:00
nacin 4e8f4e57d1 Fix validation issue in get_the_password_form() caused by wpautop(). see #21018 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 03:20:51 +00:00
nacin 64b9b4f940 Do not specify background-image: none when a user removes a custom background
on a theme that has a default background image.

The onus is on the theme to omit the default background-image from style.css,
to allow the user to remove the default background image. Or, the theme can
specify a background-image for the body selector, as long as they then zero
it out for body.custom-background, like so:

{{{
body {
	background-image: url( ... );
}
body.custom-background {
	background-image: none;
}
}}}

This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.

This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.

see #20132, which will now be marked as invalid.

Also, per previous changes in #20448, the custom-background class should not
be shown when only a default color is in use.

fixes #20448.



git-svn-id: http://core.svn.wordpress.org/trunk@21054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 21:25:05 +00:00
ryan 64e6663569 Fix removing the default background image for themes that hard-code the default in css. Honor the default background image for themes that do not provide a fallback in css.
* <style> will appear if there is a default image registered. This is the same as 3.3.
* If only a default color is registered, it still assumes it is in the stylesheet, and no <style> will appear. This is a change from 3.3.
* <style> will continue to appear as before if there is a custom background color or image. This is the same as 3.3.
* This then allows for a default background image with background-image: none, overriding style.css. This is new.

Props nacin
see #20448


git-svn-id: http://core.svn.wordpress.org/trunk@21001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:35:31 +00:00
ryan 0f1f59b092 Custom background fixes:
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.

Props nacin, kobenland
fixes #20448


git-svn-id: http://core.svn.wordpress.org/trunk@20973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:31:50 +00:00
ryan 0d99cf31a6 Don't escape anchor text as an attributein wp_get_attachment_link(). Props SergeyBiryukov. fixes #19282
git-svn-id: http://svn.automattic.com/wordpress/trunk@20654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 21:22:58 +00:00
ryan 54a1ee90b9 Always show search-results or search-no-results for searches, even archive searches. Props johnbillion. fixes #20435
git-svn-id: http://svn.automattic.com/wordpress/trunk@20595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 20:38:40 +00:00
nacin ae8af5d0dd Introduce get_page_template_slug( $id = null ) to return a page's template (like "showcase.php"). Returns false if post ID is not a page, and an empty string for the default page template. Use the function across core. props billerickson for initial patch. fixes #18750.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 18:56:54 +00:00
ryan 0dfe24e69b Set post password cookies via an action in wp-login.php. Retire wp-pass.php (one less root file). Obey login ssl preferences for post password form submission. Props SergeyBiryukov. fixes #19798
git-svn-id: http://svn.automattic.com/wordpress/trunk@19925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-14 18:29:22 +00:00
nacin 1098f33984 Don't create a variable we only use once. props niallkennedy, fixes #19941.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 22:33:43 +00:00
ryan ed8c96636c Hash post password in cookies. fixes #19797
git-svn-id: http://svn.automattic.com/wordpress/trunk@19728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-11 16:42:42 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan 5b9144b12d Use site_url() to link to wp-pass.php. Props dd32. fixes #14748
git-svn-id: http://svn.automattic.com/wordpress/trunk@19677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 20:05:39 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin f88cdc0668 Pass remaining start_el() arguments to page_css_class. props TheDeadMedic, fixes #17727.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 18:35:25 +00:00
nacin eea7874845 Simplify logic in wp_get_attachment_link(). see #18491.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 14:22:42 +00:00
ryan 75e238360a Avoid warning when non-existent ID pass to wp_get_attachment_link(). Tidy formatting of wp_get_attachment_link(). Props SergeyBiryukov, Jayjdk. fixes #18491
git-svn-id: http://svn.automattic.com/wordpress/trunk@19210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 14:08:25 +00:00
nacin 91a448be74 Use esc_attr() consistently in wp_dropdown_pages().
git-svn-id: http://svn.automattic.com/wordpress/trunk@19081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-28 22:40:09 +00:00
duck_ abd0c8c231 Correctly document $stripteaser as a boolean flag. Props GaryJ, fixes #18886.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-26 10:15:29 +00:00
markjaquith 37aae9f46f Give custom background CSS more specificity. props GaryJ. fixes #18698
git-svn-id: http://svn.automattic.com/wordpress/trunk@18886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 17:20:43 +00:00
nacin 3440dbb182 Add filter for the args into wp_dropdown_pages() in the page attributes box. Give the list_pages filter the context of the post object. fixes #8592 for 3.3.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 21:21:15 +00:00
ryan 69a52799a5 Do not output title attributes in the page walker since they match the anchor and are thus superfluous. Props logiclord. fixes #16783
git-svn-id: http://svn.automattic.com/wordpress/trunk@18739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-21 20:04:14 +00:00
dd32 bd5cf872c6 Allow Apostrophes in Post Passwords. $_POST and $_COOKIE are always slashed. Fixes #17145
git-svn-id: http://svn.automattic.com/wordpress/trunk@18712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-19 04:17:26 +00:00
duck_ c8a4ab1b4c Only add the post format body classes when the post type supports post formats. props ocean90. fixes #18228.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-07 20:10:42 +00:00
ryan 4ad0954961 Introduce register_meta(), get_metadata_by_mid(), and *_post_meta capabilities. fixes #17850
git-svn-id: http://svn.automattic.com/wordpress/trunk@18445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-20 22:04:35 +00:00
nacin 6590faa5ba Shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 05:34:15 +00:00
nacin 6a073f6d47 Restore page-template-default body class. props peterwilsoncc, fixes #18018 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 05:31:57 +00:00
westi bb74249c0d Ensure that we always coerce the class list passed to get_body_class to an array even when it is empty. Fixes #17717
git-svn-id: http://svn.automattic.com/wordpress/trunk@18176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-07 08:55:25 +00:00
ryan 47ff74214f Return false from is_page_template() if the template is default. Props johnbillion. fixes #17458
git-svn-id: http://svn.automattic.com/wordpress/trunk@18062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-27 15:24:33 +00:00